Re: [PATCH] drm: mali-dp: Uninitialized variable in malidp_se_check_scaling()

2017-12-12 Thread Mihail Atanassov
_scaling(struct malidp_plane *mp, if (mp->layer->id & (DE_SMART | DE_GRAPHICS2)) return -EINVAL; - mc = to_malidp_crtc_state(crtc_state); - mc->scaled_planes_mask |= mp->layer->id; /* Defer scaling requirements calculation to the crtc check. */

[PATCH] drm: mali-dp: add atomic_print_state for planes

2017-02-13 Thread Mihail Atanassov
Print all the extra fields of malidp_plane_state. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> --- drivers/gpu/drm/arm/malidp_planes.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c

[PATCH v2] drm: mali-dp: Add CTM support

2017-02-13 Thread Mihail Atanassov
All DPs have a COLORADJ matrix which is applied prior to output gamma. Attach that to the CTM property. Also, ensure the input CTM's coefficients can fit in the DP registers' Q3.12 format. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> --- Link to v1: https://lkml.org/lkml/20

[PATCH] drm: Add helper macro for duplicating custom drm_*_state

2017-02-09 Thread Mihail Atanassov
ple) is not first in the derived struct, to avoid missing any data before it and corrupting the base's data. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> --- include/drm/drm_atomic_helper.h | 33 + 1 file changed, 33 insertions(+) diff --git a/in

[RFC] drm: Helper macro for drm state duplication

2017-02-09 Thread Mihail Atanassov
red this also applies to the other drm_*_state derivatives, so I concocted a macro helper to do the copy in one chunk (two if you count the __drm_atomic_helper* one). I'd appreciate some comments on whether anyone else might find this macro useful. Thanks! Mihail Atanassov (1): drm: Add helper ma

[PATCH v3 1/2] drm: mali-dp: add malidp_crtc_state struct

2017-02-07 Thread Mihail Atanassov
Add a custom CRTC state struct to enable storing driver-private per-CRTC state. This patch only adds the base drm_crtc_state struct. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> Reviewed-by: Brian Starkey <brian.star...@arm.com> Acked-by: Liviu Dudau <liviu.du...@ar

[PATCH v3 2/2] drm: mali-dp: enable gamma support

2017-02-07 Thread Mihail Atanassov
table of coefficients for all 3 curves on DP500. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> Reviewed-by: Brian Starkey <brian.star...@arm.com> Acked-by: Liviu Dudau <liviu.du...@arm.com> --- drivers/gpu/drm/arm/malidp_crtc.c | 130 +

[PATCH v2 1/2] drm: mali-dp: add malidp_crtc_state struct

2017-02-01 Thread Mihail Atanassov
Add a custom CRTC state struct to enable storing driver-private per-CRTC state. This patch only adds the base drm_crtc_state struct. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> Reviewed-by: Brian Starkey <brian.star...@arm.com> --- Link to v1: https://lkml.org/lkml/

[PATCH v2 2/2] drm: mali-dp: enable gamma support

2017-02-01 Thread Mihail Atanassov
table of coefficients for all 3 curves on DP500. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> Reviewed-by: Brian Starkey <brian.star...@arm.com> --- drivers/gpu/drm/arm/malidp_crtc.c | 132 -- drivers/gpu/drm/arm/malidp_

[PATCH 2/2] drm: mali-dp: enable gamma support

2017-02-01 Thread Mihail Atanassov
table of coefficients for all 3 curves on DP500. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> --- drivers/gpu/drm/arm/malidp_crtc.c | 130 -- drivers/gpu/drm/arm/malidp_drv.c | 52 +++ drivers/gpu/drm/arm/malidp_drv.h

[PATCH 1/2] drm: mali-dp: add malidp_crtc_state struct

2017-02-01 Thread Mihail Atanassov
Add a custom CRTC state struct to enable storing driver-private per-CRTC state. This patch only adds the base drm_crtc_state struct. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> --- drivers/gpu/drm/arm/malidp_crtc.c | 39 +-- drivers/gpu/d

[PATCH] drm: mali-dp: Add CTM support

2017-02-01 Thread Mihail Atanassov
All DPs have a COLORADJ matrix which is applied prior to output gamma. Attach that to the CTM property. Also, ensure the input CTM's coefficients can fit in the DP registers' Q3.12 format. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> --- This patch depends on "[PATCH 2/2

[PATCH] drm: mali-dp: add custom plane ->reset hook

2017-01-30 Thread Mihail Atanassov
The reset hook needs to allocate space for a malidp_plane_state, which is larger than drm_plane_state. Otherwise, the hook is identical to the default one. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> --- drivers/gpu/drm/arm/malidp_planes.c | 23 ++-

[PATCH 2/2] drm: mali-dp: Check for sufficient address space

2017-01-23 Thread Mihail Atanassov
If the device-tree 'reg' node doesn't reserve enough space for the DP, fail to bind. Reviewed-by: Brian Starkey <brian.star...@arm.com> Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> --- drivers/gpu/drm/arm/malidp_drv.c | 20 drivers/gpu/drm/arm/m

[PATCH 1/2] drm: mali-dp: Check hw version matches device-tree

2017-01-23 Thread Mihail Atanassov
Refuse to bind if the device-tree compatible string lists a different hardware version. Reviewed-by: Brian Starkey <brian.star...@arm.com> Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> --- A couple of small improvements to driver-to-hardware binding. drivers

<    1   2   3