Re: [PATCH v3 0/4] Fix Win8 backlight issue

2013-09-29 Thread Mika Westerberg
, Tested-by: Mika Westerberg mika.westerb...@linux.intel.com ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm/nouveau/acpi: fix check for power resources support

2016-10-31 Thread Mika Westerberg
check flags.power_resources. Or alternatively explain this in the changelog (along the lines that we fail to find PowerResources because ACPICA does not handle certain conditional things in the same way than Windows 10). Other than that, looks good Reviewed-by: Mika Westerberg > + retur

[PATCH 4/4] drm/nouveau/acpi: fix lockup with PCIe runtime PM

2016-05-31 Thread Mika Westerberg
On Mon, May 30, 2016 at 06:13:51PM +0200, Peter Wu wrote: > Do you have any suggestions for the case where the pcieport driver > refuses to put the bridge in D3 (because the BIOS is too old)? In that > case the nouveau driver needs to fallback to the DSM method (but not > when runtime PM is

[PATCH 4/4] drm/nouveau/acpi: fix lockup with PCIe runtime PM

2016-06-01 Thread Mika Westerberg
On Tue, May 31, 2016 at 01:02:31PM +0200, Peter Wu wrote: > On Tue, May 31, 2016 at 11:43:56AM +0300, Mika Westerberg wrote: > > On Mon, May 30, 2016 at 06:13:51PM +0200, Peter Wu wrote: > > > Do you have any suggestions for the case where the pcieport driver > > > refu

[PATCH v2 4/4] drm/nouveau/acpi: fix lockup with PCIe runtime PM

2016-07-08 Thread Mika Westerberg
up/firmware-requirements-for-d3cold > [2]: > https://github.com/Bumblebee-Project/bbswitch/issues/78#issuecomment-223549072 > > v2: simply check directly for _PR3. Added affected machines. > > Signed-off-by: Peter Wu One nitpick below but otherwise looks reasonable to me. Reviewed-by:

[PATCH] drm/nouveau/acpi: use DSM if bridge does not support D3cold

2016-08-30 Thread Mika Westerberg
sts/linux-pci/msg52599.html > > Cc: Mika Westerberg Reviewed-by: Mika Westerberg

[PATCH 4/4] drm/nouveau/acpi: fix lockup with PCIe runtime PM

2016-05-25 Thread Mika Westerberg
On Wed, May 25, 2016 at 12:53:01AM +0200, Peter Wu wrote: > Since "PCI: Add runtime PM support for PCIe ports", the parent PCIe port > can be runtime-suspended which disables power resources via ACPI. This > is incompatible with DSM, resulting in a GPU device which is still in D3 > and locks up

[PATCH 4/4] drm/nouveau/acpi: fix lockup with PCIe runtime PM

2016-05-30 Thread Mika Westerberg
+Rafael On Fri, May 27, 2016 at 01:10:37PM +0200, Peter Wu wrote: > On Wed, May 25, 2016 at 04:55:35PM +0300, Mika Westerberg wrote: > > On Wed, May 25, 2016 at 12:53:01AM +0200, Peter Wu wrote: > > > Since "PCI: Add runtime PM support for PCIe ports", the parent PC

[PATCH 4/4] drm/nouveau/acpi: fix lockup with PCIe runtime PM

2016-05-30 Thread Mika Westerberg
On Mon, May 30, 2016 at 02:20:10PM +0200, Peter Wu wrote: > On Mon, May 30, 2016 at 12:57:09PM +0300, Mika Westerberg wrote: > > +Rafael > > > > On Fri, May 27, 2016 at 01:10:37PM +0200, Peter Wu wrote: > > > On Wed, May 25, 2016 at 04:55:35PM +0300, Mika Westerberg

[PATCH 1/2] vga_switcheroo: add power support for windows 10 machines.

2016-03-11 Thread Mika Westerberg
On Thu, Mar 10, 2016 at 09:57:09PM +0100, Rafael J. Wysocki wrote: > > It doesn't seem to do any runtime PM, > > I do wonder if pcieport should be doing it's own runtime PM handling, > > but that is a > > larger task than I'm thinking to tackle here. > > PCIe ports don't do PM - yet. Mika has

[PATCH 1/2] vga_switcheroo: add power support for windows 10 machines.

2016-03-14 Thread Mika Westerberg
On Mon, Mar 14, 2016 at 12:19:14PM +1000, Dave Airlie wrote: > On 11 March 2016 at 23:45, Rafael J. Wysocki wrote: > > On Friday, March 11, 2016 12:58:15 PM Mika Westerberg wrote: > >> On Thu, Mar 10, 2016 at 09:57:09PM +0100, Rafael J. Wysocki wrote: > >> > > It

[PATCH 1/2] vga_switcheroo: add power support for windows 10 machines.

2016-03-14 Thread Mika Westerberg
On Mon, Mar 14, 2016 at 07:47:39PM +1000, Dave Airlie wrote: > > > >> - if (pcie_port_runtime_suspend_allowed(dev)) > >> + if (pcie_port_runtime_suspend_allowed(dev)) { > >> + pm_runtime_allow(>dev); > > > > PCI drivers typically have left this decision up to the userspace. I'm

[PATCH 1/2] vga_switcheroo: add power support for windows 10 machines.

2016-03-14 Thread Mika Westerberg
On Mon, Mar 14, 2016 at 01:50:41PM +0100, Rafael J. Wysocki wrote: > On Mon, Mar 14, 2016 at 11:23 AM, Mika Westerberg > wrote: > > On Mon, Mar 14, 2016 at 07:47:39PM +1000, Dave Airlie wrote: > >> > > >> >> - if

[PATCH 1/2] vga_switcheroo: add power support for windows 10 machines.

2016-03-15 Thread Mika Westerberg
On Tue, Mar 15, 2016 at 02:39:58PM +0100, Lukas Wunner wrote: > Hi Mika, > > On Mon, Mar 14, 2016 at 11:43:35AM +0200, Mika Westerberg wrote: > > On Mon, Mar 14, 2016 at 12:19:14PM +1000, Dave Airlie wrote: > > > On 11 March 2016 at 23:45, Rafael J. Wysocki wrote: >

Re: [PATCH v4 1/3] ACPI / PMIC: Add support for executing PMIC MIPI sequence elements

2018-12-16 Thread Mika Westerberg
i_pmic_seq_element callback. This function will be called by the > i915 code to execture MIPI sequence PMIC elements. > > Signed-off-by: Hans de Goede Reviewed-by: Mika Westerberg ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v4 2/3] ACPI / PMIC: Implement exec_mipi_pmic_seq_element for CHT Whiskey Cove PMIC

2018-12-16 Thread Mika Westerberg
t see all that churn. If I can get an Ack from you or > Rafael for that then I can push the version with the include > dropped to drm-next (through drm-intel-next-queued) myself > once the 3th patch also has been acked. I guess it is up to Rafael whether my ack is enough

Re: [PATCH v4 2/3] ACPI / PMIC: Implement exec_mipi_pmic_seq_element for CHT Whiskey Cove PMIC

2018-12-16 Thread Mika Westerberg
tor was plugged in and > the GOP initialized only the external monitor. > > Signed-off-by: Hans de Goede One question see below, but regardless Reviewed-by: Mika Westerberg > --- > Changes in v4: > -The decoding of the raw data of the PMIC MIPI sequence element is n

Re: 4.20.0-rc3 nouveau/Quadro P2000 Mobile: runpm causing ACPI errors, lockups

2018-11-28 Thread Mika Westerberg
+linux-acpi Hi Michael, On Mon, Nov 26, 2018 at 10:53:26PM -0500, Michael S. Tsirkin wrote: > So a new thinkpad: > 01:00.0 VGA compatible controller: NVIDIA Corporation GP107GLM [Quadro P2000 > Mobile] (rev a1) > > Hangs whenever I try to poke at the card. It starts happily enough with > > [

Re: 4.20.0-rc3 nouveau/Quadro P2000 Mobile: runpm causing ACPI errors, lockups

2018-11-29 Thread Mika Westerberg
On Tue, Nov 27, 2018 at 09:49:44PM -0500, Michael S. Tsirkin wrote: > On Tue, Nov 27, 2018 at 11:36:50AM +0200, Mika Westerberg wrote: > > +linux-acpi > > > > Hi Michael, > > > > On Mon, Nov 26, 2018 at 10:53:26PM -0500, Michael S. Tsirkin wrote: > >

Re: 4.20.0-rc3 nouveau/Quadro P2000 Mobile: runpm causing ACPI errors, lockups

2018-11-29 Thread Mika Westerberg
On Wed, Nov 28, 2018 at 10:09:22AM -0500, Michael S. Tsirkin wrote: > Yea all this is weird, in particular I wonder why does everyone > using dsm insists on saying Arg4 > when they actually mean Arg3. ACPI numbers arguments from 0. > > So it's a bit ugly, and maybe worth fixing but unlikely to be

Re: [PATCH v2 1/3] ACPI / PMIC: Add support for executing PMIC MIPI sequence elements

2018-12-10 Thread Mika Westerberg
On Thu, Dec 06, 2018 at 02:47:03PM +0100, Hans de Goede wrote: > DSI LCD panels describe an initialization sequence in the Video BIOS > Tables using so called MIPI sequences. One possible element in these > sequences is a PMIC specific element of 15 bytes. > > Although this is not really an ACPI

Re: [PATCH v2 2/3] ACPI / PMIC: Implement exec_mipi_pmic_seq_element for CHT Whiskey Cove PMIC

2018-12-10 Thread Mika Westerberg
On Thu, Dec 06, 2018 at 02:47:04PM +0100, Hans de Goede wrote: > Implement the exec_mipi_pmic_seq_element callback for the CHT Whiskey Cove > PMIC. > > On some CHT devices this fixes the LCD panel not lighting up when it was > not initialized by the GOP, because an external monitor was plugged in

Re: Missing Thunderbolt 3 PCI-E atomics support

2019-03-15 Thread Mika Westerberg
On Thu, Mar 14, 2019 at 06:26:00PM +0100, Timur Kristóf wrote: > I know atomics is a PCIe feature, but in this case the PCIe goes > through TB3, so I would assume it has something to do with it. Does it work if you plug the graphics card directly to the PCIe slot? > Here is the output of 'lspci

Re: Missing Thunderbolt 3 PCI-E atomics support

2019-03-15 Thread Mika Westerberg
On Wed, Mar 13, 2019 at 07:09:26PM +0100, Timur Kristóf wrote: > Hi, Hi, > I was sent here by Greg KH from the Linux USB mailing list, I hope this > is the right place to ask. > > PCI-E atomics don't work for me with Thunderbolt 3. > I see the following message from my Thunderbolt 3 eGPU in

Re: Missing Thunderbolt 3 PCI-E atomics support

2019-03-15 Thread Mika Westerberg
On Thu, Mar 14, 2019 at 06:54:21PM +0100, Timur Kristóf wrote: > On Thu, 2019-03-14 at 19:40 +0200, Mika Westerberg wrote: > > On Thu, Mar 14, 2019 at 06:26:00PM +0100, Timur Kristóf wrote: > > > I know atomics is a PCIe feature, but in this case the PCIe goes > > > thr

Re: Why is Thunderbolt 3 limited to 2.5 GT/s on Linux?

2019-07-01 Thread Mika Westerberg
On Fri, Jun 28, 2019 at 04:53:02PM +0200, Timur Kristóf wrote: > On Fri, 2019-06-28 at 17:14 +0300, Mika Westerberg wrote: > > On Fri, Jun 28, 2019 at 03:33:56PM +0200, Timur Kristóf wrote: > > > I have two more questions: > > > > > > 1. What is the be

Re: Why is Thunderbolt 3 limited to 2.5 GT/s on Linux?

2019-07-01 Thread Mika Westerberg
On Mon, Jul 01, 2019 at 10:46:34AM -0400, Alex Deucher wrote: > > 2. As far as I understood what Mika said, there isn't really a 2.5 GT/s > > limitation there, since the virtual link should be running at 40 Gb/s > > regardless of the reported speed of that device. Would it be possible > > to run

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-10-01 Thread Mika Westerberg
On Mon, Sep 30, 2019 at 06:36:12PM +0200, Karol Herbst wrote: > On Mon, Sep 30, 2019 at 6:30 PM Mika Westerberg > wrote: > > > > On Mon, Sep 30, 2019 at 06:05:14PM +0200, Karol Herbst wrote: > > > still happens with your patch applied. The machine simply gets shut

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-10-01 Thread Mika Westerberg
On Tue, Oct 01, 2019 at 10:56:39AM +0200, Karol Herbst wrote: > On Tue, Oct 1, 2019 at 10:47 AM Mika Westerberg > wrote: > > > > On Mon, Sep 30, 2019 at 06:36:12PM +0200, Karol Herbst wrote: > > > On Mon, Sep 30, 2019 at 6:30 PM Mika Westerberg > > > wrote:

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-09-30 Thread Mika Westerberg
On Mon, Sep 30, 2019 at 06:05:14PM +0200, Karol Herbst wrote: > still happens with your patch applied. The machine simply gets shut down. > > dmesg can be found here: >

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-09-30 Thread Mika Westerberg
Hi Karol, On Fri, Sep 27, 2019 at 11:53:48PM +0200, Karol Herbst wrote: > > What exactly is the serious issue? I guess it's that the rescan > > doesn't detect the GPU, which means it's not responding to config > > accesses? Is there any timing component here, e.g., maybe we're > > missing some

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-09-30 Thread Mika Westerberg
On Mon, Sep 30, 2019 at 11:15:48AM +0200, Karol Herbst wrote: > On Mon, Sep 30, 2019 at 10:05 AM Mika Westerberg > wrote: > > > > Hi Karol, > > > > On Fri, Sep 27, 2019 at 11:53:48PM +0200, Karol Herbst wrote: > > > > What exactly is the se

Re: Why is Thunderbolt 3 limited to 2.5 GT/s on Linux?

2019-06-30 Thread Mika Westerberg
On Fri, Jun 28, 2019 at 01:08:07PM +0200, Timur Kristóf wrote: > Hi Mika, > > Thanks for your quick reply. > > > > 1. Why are there four bridge devices? 04:00.0, 04:01.0 and 04:02.0 > > > look > > > superfluous to me and nothing is connected to them. It actually > > > gives > > > me the feeling

Re: Why is Thunderbolt 3 limited to 2.5 GT/s on Linux?

2019-06-30 Thread Mika Westerberg
On Fri, Jun 28, 2019 at 03:33:56PM +0200, Timur Kristóf wrote: > I have two more questions: > > 1. What is the best way to test that the virtual link is indeed capable > of 40 Gbit / sec? So far I've been unable to figure out how to measure > its maximum throughput. I don't think there is any

Re: Why is Thunderbolt 3 limited to 2.5 GT/s on Linux?

2019-06-30 Thread Mika Westerberg
On Fri, Jun 28, 2019 at 02:21:36PM +0200, Timur Kristóf wrote: > > > > Sure, though in this case 3 of those downstream ports are not > > > exposed > > > by the hardware, so it's a bit surprising to see them there. > > > > They lead to other peripherals on the TBT host router such as the TBT > >

Re: Why is Thunderbolt 3 limited to 2.5 GT/s on Linux?

2019-06-30 Thread Mika Westerberg
On Fri, Jun 28, 2019 at 12:23:09PM +0200, Timur Kristóf wrote: > Hi guys, > > I use an AMD RX 570 in a Thunderbolt 3 external GPU box. > dmesg gives me the following message: > pci :3a:00.0: 8.000 Gb/s available PCIe bandwidth, limited by 2.5 GT/s x4 > link at :04:04.0 (capable of 31.504

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-21 Thread Mika Westerberg
On Wed, Nov 20, 2019 at 10:36:31PM +0100, Karol Herbst wrote: > with the branch and patch applied: > https://gist.githubusercontent.com/karolherbst/03c4c8141b0fa292d781badfa186479e/raw/5c62640afbc57d6e69ea924c338bd2836e770d02/gistfile1.txt Thanks for testing. Too bad it did not help :( I suppose

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-21 Thread Mika Westerberg
On Wed, Nov 20, 2019 at 11:29:33PM +0100, Rafael J. Wysocki wrote: > > last week or so I found systems where the GPU was under the "PCI > > Express Root Port" (name from lspci) and on those systems all of that > > seems to work. So I am wondering if it's indeed just the 0x1901 one, > > which also

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-21 Thread Mika Westerberg
On Thu, Nov 21, 2019 at 12:03:52PM +0100, Rafael J. Wysocki wrote: > On Thu, Nov 21, 2019 at 11:14 AM Mika Westerberg > wrote: > > > > On Wed, Nov 20, 2019 at 10:36:31PM +0100, Karol Herbst wrote: > > > with the branch and patch applied: > > > https://gi

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-21 Thread Mika Westerberg
On Thu, Nov 21, 2019 at 01:46:14PM +0200, Mika Westerberg wrote: > On Thu, Nov 21, 2019 at 12:34:22PM +0100, Rafael J. Wysocki wrote: > > On Thu, Nov 21, 2019 at 12:28 PM Mika Westerberg > > wrote: > > > > > > On Wed, Nov 20, 2019 at 11:29:33PM +0100, Rafael J. W

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-21 Thread Mika Westerberg
On Thu, Nov 21, 2019 at 12:34:22PM +0100, Rafael J. Wysocki wrote: > On Thu, Nov 21, 2019 at 12:28 PM Mika Westerberg > wrote: > > > > On Wed, Nov 20, 2019 at 11:29:33PM +0100, Rafael J. Wysocki wrote: > > > > last week or so I found systems where the GPU was under

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-21 Thread Mika Westerberg
On Thu, Nov 21, 2019 at 04:43:24PM +0100, Rafael J. Wysocki wrote: > On Thu, Nov 21, 2019 at 1:52 PM Mika Westerberg > wrote: > > > > On Thu, Nov 21, 2019 at 01:46:14PM +0200, Mika Westerberg wrote: > > > On Thu, Nov 21, 2019 at 12:34:22PM +0100, Rafael J. Wysocki wr

Re: [PATCH v3] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-10-21 Thread Mika Westerberg
cal explanation of the issue as a in-code comment > v3: disable it only for certain combinations of intel and nvidia hardware > > Signed-off-by: Karol Herbst > Cc: Bjorn Helgaas > Cc: Lyude Paul > Cc: Rafael J. Wysocki > Cc: Mika Westerberg > Cc: linux-...@vger.kernel.

Re: [PATCH v3] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-10-21 Thread Mika Westerberg
On Mon, Oct 21, 2019 at 03:02:23PM +0200, Karol Herbst wrote: > > No, just block runtime PM from the device in nouveau driver. > > but that's not what the patch does. It only skips the PCI PM reg > write, but still let the ACPI method be invoked to put the device into > D3cold Oh, indeed it

Re: [PATCH v3] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-10-21 Thread Mika Westerberg
On Wed, Oct 16, 2019 at 11:48:22PM +0200, Karol Herbst wrote: > On Wed, Oct 16, 2019 at 11:37 PM Bjorn Helgaas wrote: > > > > [+cc linux-acpi] > > > > On Wed, Oct 16, 2019 at 09:18:32PM +0200, Karol Herbst wrote: > > > but setting the PCI_DEV_FLAGS_NO_D3 flag does prevent using the > > > platform

Re: [PATCH v3] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-10-21 Thread Mika Westerberg
On Mon, Oct 21, 2019 at 03:54:09PM +0200, Karol Herbst wrote: > > I really would like to provide you more information about such > > workaround but I'm not aware of any ;-) I have not seen any issues like > > this when D3cold is properly implemented in the platform. That's why > > I'm bit

Re: [PATCH v3] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-10-21 Thread Mika Westerberg
On Mon, Oct 21, 2019 at 02:00:46PM +0200, Karol Herbst wrote: > On Mon, Oct 21, 2019 at 1:40 PM Mika Westerberg > wrote: > > > > Hi Karol, > > > > Sorry for commenting late, I just came back from vacation. > > > > On Wed, Oct 16, 2019 at 04:44:49PM +0

Re: [PATCH v3] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-10-21 Thread Mika Westerberg
On Mon, Oct 21, 2019 at 04:49:09PM +0200, Karol Herbst wrote: > On Mon, Oct 21, 2019 at 4:09 PM Mika Westerberg > wrote: > > > > On Mon, Oct 21, 2019 at 03:54:09PM +0200, Karol Herbst wrote: > > > > I really would like to provide you more information about s

Re: [PATCH v3] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-10-22 Thread Mika Westerberg
On Tue, Oct 22, 2019 at 11:16:14AM +0200, Karol Herbst wrote: > I think there is something I totally forgot about: > > When there was never a driver bound to the GPU, and if runtime power > management gets enabled on that device, runtime suspend/resume works > as expected (I am not 100% sure on

Re: [PATCH v3] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-10-23 Thread Mika Westerberg
On Tue, Oct 22, 2019 at 02:51:53PM +0200, Karol Herbst wrote: > On Tue, Oct 22, 2019 at 2:45 PM Mika Westerberg > wrote: > > > > On Tue, Oct 22, 2019 at 11:16:14AM +0200, Karol Herbst wrote: > > > I think there is something I totally forgot about: > > > >

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-20 Thread Mika Westerberg
On Wed, Nov 20, 2019 at 12:58:00PM +0100, Karol Herbst wrote: > overall, what I really want to know is, _why_ does it work on windows? So do I ;-) > Or what are we doing differently on Linux so that it doesn't work? If > anybody has any idea on how we could dig into this and figure it out > on

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-20 Thread Mika Westerberg
On Wed, Nov 20, 2019 at 01:22:16PM +0200, Mika Westerberg wrote: > If (((OSYS <= 0x07D9) || ((OSYS == 0x07DF) && (_REV == > 0x05 > { The OSYS comes from this (in DSDT): If

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-20 Thread Mika Westerberg
On Wed, Nov 20, 2019 at 11:52:22AM +0100, Rafael J. Wysocki wrote: > On Wed, Nov 20, 2019 at 11:18 AM Mika Westerberg > wrote: > > > > Hi Karol, > > > > On Tue, Nov 19, 2019 at 11:26:45PM +0100, Karol Herbst wrote: > > > On Tue, Nov 19, 2019 at 10:50 PM Bjo

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-20 Thread Mika Westerberg
i_rev_override in the command line makes the _REV to return 5 so it should go into the "Linux" path in PGOF(). [1] https://www.kernel.org/doc/html/latest/firmware-guide/acpi/osi.html#do-not-use-rev > > > Signed-off-by: Karol Herbst > > > Cc: Bjorn Helgaas > &g

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-20 Thread Mika Westerberg
On Wed, Nov 20, 2019 at 04:37:14PM +0100, Karol Herbst wrote: > On Wed, Nov 20, 2019 at 4:15 PM Mika Westerberg > wrote: > > > > On Wed, Nov 20, 2019 at 01:11:52PM +0100, Karol Herbst wrote: > > > On Wed, Nov 20, 2019 at 1:09 PM Mika Westerberg > > > wrote:

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-20 Thread Mika Westerberg
On Wed, Nov 20, 2019 at 05:53:07PM +0200, Mika Westerberg wrote: > On Wed, Nov 20, 2019 at 04:37:14PM +0100, Karol Herbst wrote: > > On Wed, Nov 20, 2019 at 4:15 PM Mika Westerberg > > wrote: > > > > > > On Wed, Nov 20, 2019 at 01:11:52PM +0100, Karol Herbst wr

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-20 Thread Mika Westerberg
On Wed, Nov 20, 2019 at 01:11:52PM +0100, Karol Herbst wrote: > On Wed, Nov 20, 2019 at 1:09 PM Mika Westerberg > wrote: > > > > On Wed, Nov 20, 2019 at 12:58:00PM +0100, Karol Herbst wrote: > > > overall, what I really want to know is, _why_ does it work

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-22 Thread Mika Westerberg
On Fri, Nov 22, 2019 at 12:30:20PM +0100, Rafael J. Wysocki wrote: > On Fri, Nov 22, 2019 at 11:36 AM Mika Westerberg > wrote: > > > > On Thu, Nov 21, 2019 at 11:39:23PM +0100, Rafael J. Wysocki wrote: > > > On Thu, Nov 21, 2019 at 8:49 PM Mika Westerberg > > >

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-22 Thread Mika Westerberg
On Thu, Nov 21, 2019 at 11:39:23PM +0100, Rafael J. Wysocki wrote: > On Thu, Nov 21, 2019 at 8:49 PM Mika Westerberg > wrote: > > > > On Thu, Nov 21, 2019 at 04:43:24PM +0100, Rafael J. Wysocki wrote: > > > On Thu, Nov 21, 2019 at 1:52 PM Mika Westerberg > > >

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-27 Thread Mika Westerberg
On Tue, Nov 26, 2019 at 06:10:36PM -0500, Lyude Paul wrote: > Hey-this is almost certainly not the right place in this thread to respond, > but this thread has gotten so deep evolution can't push the subject further to > the right, heh. So I'll just respond here. :) > I've been following this

Re: [PATCH v6] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2020-03-04 Thread Mika Westerberg
tential NULL pointer access > update the quirk documentation > v6: move quirk into nouveau This information typically goes under the '---' line. > Signed-off-by: Karol Herbst > Cc: Bjorn Helgaas > Cc: Lyude Paul > Cc: Rafael J. Wysocki > Cc: Mika Westerberg I have few m

Re: [PATCH v6] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2020-03-05 Thread Mika Westerberg
On Thu, Mar 05, 2020 at 05:11:57PM +0100, Karol Herbst wrote: > On Wed, Mar 4, 2020 at 10:33 AM Mika Westerberg > wrote: > > > > Hi, > > > > On Tue, Mar 03, 2020 at 11:10:52AM +0100, Karol Herbst wrote: > > > Fixes state transitions of Nvidia Pascal GPU

Re: nouveau regression with 5.7 caused by "PCI/PM: Assume ports without DLL Link Active train links in 100 ms"

2020-07-22 Thread Mika Westerberg
On Tue, Jul 21, 2020 at 11:01:55AM -0400, Lyude Paul wrote: > Sure thing. Also, feel free to let me know if you'd like access to one of the > systems we saw breaking with this patch - I'm fairly sure I've got one of them > locally at my apartment and don't mind setting up AMT/KVM/SSH Probably no

Re: nouveau regression with 5.7 caused by "PCI/PM: Assume ports without DLL Link Active train links in 100 ms"

2020-07-23 Thread Mika Westerberg
On Tue, Jul 21, 2020 at 02:24:19PM -0400, Lyude Paul wrote: > On Tue, 2020-07-21 at 12:00 -0400, Lyude Paul wrote: > > On Tue, 2020-07-21 at 18:27 +0300, Mika Westerberg wrote: > > > On Tue, Jul 21, 2020 at 11:01:55AM -0400, Lyude Paul wrote: > > > > Sure thing.

Re: nouveau regression with 5.7 caused by "PCI/PM: Assume ports without DLL Link Active train links in 100 ms"

2020-07-23 Thread Mika Westerberg
On Tue, Jul 21, 2020 at 01:37:12PM -0500, Patrick Volkerding wrote: > On 7/21/20 10:27 AM, Mika Westerberg wrote: > > On Tue, Jul 21, 2020 at 11:01:55AM -0400, Lyude Paul wrote: > >> Sure thing. Also, feel free to let me know if you'd like access to one of > >> the &

Re: nouveau regression with 5.7 caused by "PCI/PM: Assume ports without DLL Link Active train links in 100 ms"

2020-07-26 Thread Mika Westerberg
On Thu, Jul 23, 2020 at 10:30:58PM +0200, Karol Herbst wrote: > On Wed, Jul 22, 2020 at 11:25 AM Mika Westerberg > wrote: > > > > On Tue, Jul 21, 2020 at 01:37:12PM -0500, Patrick Volkerding wrote: > > > On 7/21/20 10:27 AM, Mika Westerberg wrote: > > > > O

Re: nouveau regression with 5.7 caused by "PCI/PM: Assume ports without DLL Link Active train links in 100 ms"

2020-07-21 Thread Mika Westerberg
On Fri, Jul 17, 2020 at 09:52:09PM +0200, Lukas Wunner wrote: > On Fri, Jul 17, 2020 at 03:04:10PM -0400, Lyude Paul wrote: > > Isn't it possible to tell whether a PCI device is connected through > > thunderbolt or not? We could probably get away with just defaulting > > to 100ms for thunderbolt

Re: nouveau regression with 5.7 caused by "PCI/PM: Assume ports without DLL Link Active train links in 100 ms"

2020-07-21 Thread Mika Westerberg
Hi, [Sorry for the delay, I was on vacation] On Fri, Jul 17, 2020 at 01:32:10PM +0200, Karol Herbst wrote: > Filed at https://bugzilla.kernel.org/show_bug.cgi?id=208597 Thanks for reporting. I'll check your logs and try to figure if there is something we can do to make both nouveau and TBT

Re: linux-next: manual merge of the drm tree with the pci tree

2020-12-09 Thread Mika Westerberg
Hi, On Tue, Dec 08, 2020 at 01:27:54PM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the drm tree got a conflict in: > > drivers/gpu/vga/vga_switcheroo.c > > between commit: > > 99efde6c9bb7 ("PCI/PM: Rename pci_wakeup_bus() to pci_resume_bus()") > > from the

Re: [PATCH v2 3/9] PCI: drop `is_thunderbolt` attribute

2022-02-13 Thread Mika Westerberg
Hi, On Sun, Feb 13, 2022 at 09:39:28AM +0100, Lukas Wunner wrote: > On Fri, Feb 11, 2022 at 12:23:51PM +0200, Mika Westerberg wrote: > > On Thu, Feb 10, 2022 at 04:43:23PM -0600, Mario Limonciello wrote: > > > @@ -2955,7 +2955,7 @@ bool pci_bridge_d3_possible(stru

Re: [PATCH v3 03/12] PCI: Move check for old Apple Thunderbolt controllers into a quirk

2022-02-13 Thread Mika Westerberg
Hi Lukas, On Sun, Feb 13, 2022 at 10:19:20AM +0100, Lukas Wunner wrote: > On Fri, Feb 11, 2022 at 01:32:41PM -0600, Mario Limonciello wrote: > > `pci_bridge_d3_possible` currently checks explicitly for a Thunderbolt > > controller to indicate that D3 is possible. As this is used solely > > for

Re: [PATCH v3 03/12] PCI: Move check for old Apple Thunderbolt controllers into a quirk

2022-02-13 Thread Mika Westerberg
> controller to indicate that D3 is possible. As this is used solely > > > for older Apple systems, move it into a quirk that enumerates across > > > all Intel TBT controllers. > > > > > > Suggested-by: Mika Westerberg > > > Signe

Re: [PATCH v2 4/9] PCI: mark USB4 devices as removable

2022-02-11 Thread Mika Westerberg
Hi Mario, On Thu, Feb 10, 2022 at 04:43:24PM -0600, Mario Limonciello wrote: > USB4 class devices are also removable like Intel Thunderbolt devices. > > Drivers of downstream devices use this information to declare functional > differences in how the drivers perform by knowing that they are

Re: [PATCH v2 3/9] PCI: drop `is_thunderbolt` attribute

2022-02-11 Thread Mika Westerberg
Hi Mario, On Thu, Feb 10, 2022 at 04:43:23PM -0600, Mario Limonciello wrote: > The `is_thunderbolt` attribute is currently a dumping ground for a > variety of things. > > Instead use the driver core removable attribute to indicate the > detail a device is attached to a thunderbolt or USB4 chain.

Re: [PATCH v2 1/9] thunderbolt: move definition of PCI_CLASS_SERIAL_USB_USB4

2022-02-11 Thread Mika Westerberg
> Acked-by: Alex Deucher > Signed-off-by: Mario Limonciello Acked-by: Mika Westerberg

Re: [PATCH v4 00/10] Overhaul `is_thunderbolt`

2022-02-16 Thread Mika Westerberg
Hi all, On Tue, Feb 15, 2022 at 01:07:00PM -0600, Limonciello, Mario wrote: > On 2/15/2022 01:29, Lukas Wunner wrote: > > On Mon, Feb 14, 2022 at 06:01:50PM -0600, Mario Limonciello wrote: > > > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +- > > > drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c | 2

Re: [PATCH v5 3/7] PCI: Drop the `is_thunderbolt` attribute from PCI core

2022-02-28 Thread Mika Westerberg
Hi Bjorn, On Fri, Feb 25, 2022 at 11:42:24AM -0600, Bjorn Helgaas wrote: > That would just leave the "PCI_VSEC_ID_INTEL_TBT implies external-facing" > assumption above. Not having a Thunderbolt spec, I have no idea how > you deal with that. You can download the spec here:

Re: [PATCH v5 3/7] PCI: Drop the `is_thunderbolt` attribute from PCI core

2022-02-28 Thread Mika Westerberg
Hi, On Mon, Feb 28, 2022 at 10:36:59PM +, Limonciello, Mario wrote: > [AMD Official Use Only] > > > -Original Message- > > From: Lukas Wunner > > Sent: Monday, February 28, 2022 16:33 > > To: Bjorn Helgaas > > Cc: Limonciello, Mario ; Mika Weste

Re: [PATCH v4 00/10] Overhaul `is_thunderbolt`

2022-02-17 Thread Mika Westerberg
Hi Mario, On Wed, Feb 16, 2022 at 10:50:31AM -0600, Limonciello, Mario wrote: > On 2/16/2022 08:44, Alex Deucher wrote: > > On Wed, Feb 16, 2022 at 9:34 AM Mika Westerberg > > wrote: > > > > > > Hi all, > > > > > > On Tue, Feb 15,

Re: [PATCH v3 05/12] PCI: Detect root port of internal USB4 devices by `usb4-host-interface`

2022-02-14 Thread Mika Westerberg
On Mon, Feb 14, 2022 at 09:52:02AM +0100, Lukas Wunner wrote: > On Mon, Feb 14, 2022 at 09:34:26AM +0200, Mika Westerberg wrote: > > On Fri, Feb 11, 2022 at 03:45:46PM -0600, Bjorn Helgaas wrote: > > > My expectation is that "USB" (like "PCI" and "PCIe&qu

Re: [PATCH v3 05/12] PCI: Detect root port of internal USB4 devices by `usb4-host-interface`

2022-02-14 Thread Mika Westerberg
On Mon, Feb 14, 2022 at 01:11:05PM +0200, Mika Westerberg wrote: > > > It is used to identify "tunneled" ports (whether PCIe, USB 3.x or > > > DisplayPort). Tunnels are created by software (in Linux it is the > > > Thunderbolt driver) and are dynamic in nat

Re: [PATCH v3 04/12] PCI: Drop the `is_thunderbolt` attribute from PCI core

2022-02-13 Thread Mika Westerberg
Hi Mario, On Sun, Feb 13, 2022 at 11:26:56AM -0600, Limonciello, Mario wrote: > On 2/13/2022 02:20, Lukas Wunner wrote: > > On Fri, Feb 11, 2022 at 01:32:42PM -0600, Mario Limonciello wrote: > > > The `is_thunderbolt` attribute is currently a dumping ground for a > > > variety of things. > > > >

Re: [PATCH v3 05/12] PCI: Detect root port of internal USB4 devices by `usb4-host-interface`

2022-02-13 Thread Mika Westerberg
> > This can be done by looking for the device property specified in > > the ACPI tables `usb4-host-interface`. > > > > Suggested-by: Mika Westerberg > > Link: > > https://docs.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie-root-ports#mappin

Re: Question regarding using Driver Component Framework (crashing kernel)

2022-03-23 Thread Mika Westerberg
Hi, Don't you have like a serial port that you can turn on early debugging to see where it blows up? If not that then at least the USB 3 DbC. On Tue, Mar 22, 2022 at 12:01:15PM -0700, Won Chung wrote: > Hi, > > I am not sure if this is the correct mailing list to ask about Driver > Component

Re: [PATCH v2 8/9] PCI: Exclude PCIe ports used for tunneling in pcie_bandwidth_available()

2023-11-06 Thread Mika Westerberg
Hi, On Mon, Nov 06, 2023 at 07:56:52PM +0100, Lukas Wunner wrote: > On Mon, Nov 06, 2023 at 12:44:25PM -0600, Mario Limonciello wrote: > > Tangentially related; the link speed is currently symmetric but there are > > two sysfs files. Mika left a comment in drivers/thunderbolt/switch.c it may > >

Re: [PATCH v2 8/9] PCI: Exclude PCIe ports used for tunneling in pcie_bandwidth_available()

2023-11-06 Thread Mika Westerberg
On Tue, Nov 07, 2023 at 07:45:26AM +0200, Mika Westerberg wrote: > Hi, > > On Mon, Nov 06, 2023 at 07:56:52PM +0100, Lukas Wunner wrote: > > On Mon, Nov 06, 2023 at 12:44:25PM -0600, Mario Limonciello wrote: > > > Tangentially related; the link speed is currently symmetric

Re: [PATCH v2 1/9] drm/nouveau: Switch from pci_is_thunderbolt_attached() to dev_is_removable()

2023-11-06 Thread Mika Westerberg
On Mon, Nov 06, 2023 at 02:25:24PM +0200, Ilpo Järvinen wrote: > On Fri, 3 Nov 2023, Mario Limonciello wrote: > > > pci_is_thunderbolt_attached() only works for Intel TBT devices. Switch to > > using dev_is_removable() to be able to detect USB4 devices as well. > > Please extend this with more

Re: [PATCH v3 3/5] treewide: use get_random_u32() when possible

2022-10-07 Thread Mika Westerberg
On Thu, Oct 06, 2022 at 10:53:44AM -0600, Jason A. Donenfeld wrote: > drivers/thunderbolt/xdomain.c | 2 +- Acked-by: Mika Westerberg

Re: [PATCH v3 5/7] PCI: ACPI: Detect PCIe root ports that are used for tunneling

2023-11-15 Thread Mika Westerberg
Hi Mario, On Tue, Nov 14, 2023 at 02:07:53PM -0600, Mario Limonciello wrote: > USB4 routers support a feature called "PCIe tunneling". This > allows PCIe traffic to be transmitted over USB4 fabric. > > PCIe root ports that are used in this fashion can be discovered > by device specific data that

Re: [PATCH v3 5/7] PCI: ACPI: Detect PCIe root ports that are used for tunneling

2023-11-16 Thread Mika Westerberg
Hi Mario, On Wed, Nov 15, 2023 at 11:08:43AM -0600, Mario Limonciello wrote: > On 11/15/2023 04:40, Mika Westerberg wrote: > > Hi Mario, > > > > On Tue, Nov 14, 2023 at 02:07:53PM -0600, Mario Limonciello wrote: > > > USB4 routers support a feature called "PCIe