RE: [PATCHv16 5/7] fbmon: add of_videomode helpers

2013-01-06 Thread Mohammed, Afzal
Hi Steffen, On Tue, Dec 18, 2012 at 22:34:14, Steffen Trumtrar wrote: Add helper to get fb_videomode from devicetree. drivers/video/fbmon.c | 42 ++ include/linux/fb.h|4 This breaks DaVinci (da8xx_omapl_defconfig), following change was

RE: [PATCHv16 0/7] of: add display helper

2013-01-06 Thread Mohammed, Afzal
Hi Steffen, On Tue, Dec 18, 2012 at 22:34:09, Steffen Trumtrar wrote: Finally, right in time before the end of the world on friday, v16 of the display helpers. After another big bang, your series in the previous world was tried ;) This series has been tested on DA850 EVM, AM335x EVM, EVM-SK

RE: [PATCHv16 5/7] fbmon: add of_videomode helpers

2013-01-07 Thread Mohammed, Afzal
Hi Rob, On Tue, Jan 08, 2013 at 01:36:50, Rob Clark wrote: On Mon, Jan 7, 2013 at 2:46 AM, Mohammed, Afzal af...@ti.com wrote: On Mon, Jan 07, 2013 at 13:36:48, Steffen Trumtrar wrote: I just did a quick make da8xx_omapl_defconfig make and it builds just fine. On what version did you

RE: [PATCHv16 0/7] of: add display helper

2013-01-09 Thread Mohammed, Afzal
Hi Steffen, On Thu, Jan 10, 2013 at 01:45:41, Steffen Trumtrar wrote: I think the series was tested at least with - imx6q: sabrelite, sabresd - imx53: tqma53/mba53 - omap: DA850 EVM, AM335x EVM, EVM-SK To clarify, This series was tested with DT boot (making use of the

RE: [PATCH v16 RESEND 0/7] of: add display helper

2013-01-24 Thread Mohammed, Afzal
Hi Steffen, On Thu, Jan 24, 2013 at 13:49:58, Steffen Trumtrar wrote: Thanks. I'll use that opportunity for a v17 that is rebased onto 3.8-rc4. As you are going to have a v17, if you can fold the diff[1] (that I mentioned earlier) into the patch, fbmon: add of_videomode helpers, it would be

RE: [PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-25 Thread Mohammed, Afzal
Hi Rob, On Wed, Jan 23, 2013 at 04:06:22, Rob Clark wrote: A simple DRM/KMS driver for the TI LCD Controller found in various smaller TI parts (AM33xx, OMAPL138, etc). This driver uses the +void tilcdc_crtc_update_clk(struct drm_crtc *crtc) + /* in raster mode, minimum divisor is 2:

RE: [PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-25 Thread Mohammed, Afzal
Hi Rob, On Fri, Jan 25, 2013 at 19:29:40, Rob Clark wrote: On Fri, Jan 25, 2013 at 7:19 AM, Mohammed, Afzal af...@ti.com wrote: On Wed, Jan 23, 2013 at 04:06:22, Rob Clark wrote: A simple DRM/KMS driver for the TI LCD Controller found in various smaller TI parts (AM33xx, OMAPL138, etc

RE: [PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-28 Thread Mohammed, Afzal
Hi Rob, On Fri, Jan 25, 2013 at 20:22:55, Rob Clark wrote: On Fri, Jan 25, 2013 at 8:15 AM, Mohammed, Afzal af...@ti.com wrote: It's not about being simple, but not doing the wrong way, here you are relying on a platform specific clock in a driver, think about the case where same IP

[PATCHv16 5/7] fbmon: add of_videomode helpers

2013-01-07 Thread Mohammed, Afzal
Hi Steffen, On Tue, Dec 18, 2012 at 22:34:14, Steffen Trumtrar wrote: > Add helper to get fb_videomode from devicetree. > drivers/video/fbmon.c | 42 ++ > include/linux/fb.h|4 This breaks DaVinci (da8xx_omapl_defconfig), following change

[PATCHv16 0/7] of: add display helper

2013-01-07 Thread Mohammed, Afzal
Hi Steffen, On Tue, Dec 18, 2012 at 22:34:09, Steffen Trumtrar wrote: > Finally, right in time before the end of the world on friday, v16 of the > display helpers. After another big bang, your series in the previous world was tried ;) This series has been tested on DA850 EVM, AM335x EVM,

[PATCHv16 5/7] fbmon: add of_videomode helpers

2013-01-07 Thread Mohammed, Afzal
Hi Steffen, On Mon, Jan 07, 2013 at 13:36:48, Steffen Trumtrar wrote: > On Mon, Jan 07, 2013 at 06:10:13AM +0000, Mohammed, Afzal wrote: > > This breaks DaVinci (da8xx_omapl_defconfig), following change was > > required to get it build if OF_VIDEOMODE or/and FB_MODE_HELPERS >

[PATCHv16 5/7] fbmon: add of_videomode helpers

2013-01-08 Thread Mohammed, Afzal
Hi Rob, On Tue, Jan 08, 2013 at 01:36:50, Rob Clark wrote: > On Mon, Jan 7, 2013 at 2:46 AM, Mohammed, Afzal wrote: > > On Mon, Jan 07, 2013 at 13:36:48, Steffen Trumtrar wrote: > >> I just did a quick "make da8xx_omapl_defconfig && make" and it builds just

[PATCHv16 0/7] of: add display helper

2013-01-10 Thread Mohammed, Afzal
Hi Steffen, On Thu, Jan 10, 2013 at 01:45:41, Steffen Trumtrar wrote: > I think the series was tested at least with > - imx6q: sabrelite, sabresd > - imx53: tqma53/mba53 > - omap: DA850 EVM, AM335x EVM, EVM-SK To clarify, This series was tested with DT boot (making use of the

[PATCH v16 RESEND 0/7] of: add display helper

2013-01-24 Thread Mohammed, Afzal
Hi Steffen, On Thu, Jan 24, 2013 at 13:49:58, Steffen Trumtrar wrote: > Thanks. I'll use that opportunity for a v17 that is rebased onto 3.8-rc4. As you are going to have a v17, if you can fold the diff[1] (that I mentioned earlier) into the patch, "fbmon: add of_videomode helpers", it would be

[PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-25 Thread Mohammed, Afzal
Hi Rob, On Wed, Jan 23, 2013 at 04:06:22, Rob Clark wrote: > A simple DRM/KMS driver for the TI LCD Controller found in various > smaller TI parts (AM33xx, OMAPL138, etc). This driver uses the > +void tilcdc_crtc_update_clk(struct drm_crtc *crtc) > + /* in raster mode, minimum divisor is

[PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-25 Thread Mohammed, Afzal
Hi Rob, On Fri, Jan 25, 2013 at 19:29:40, Rob Clark wrote: > On Fri, Jan 25, 2013 at 7:19 AM, Mohammed, Afzal wrote: > > On Wed, Jan 23, 2013 at 04:06:22, Rob Clark wrote: > >> A simple DRM/KMS driver for the TI LCD Controller found in various > >> smaller TI p

[PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-28 Thread Mohammed, Afzal
Hi Rob, On Fri, Jan 25, 2013 at 20:22:55, Rob Clark wrote: > On Fri, Jan 25, 2013 at 8:15 AM, Mohammed, Afzal wrote: > > It's not about being simple, but not doing the wrong way, here you are > > relying on a platform specific clock in a driver, think about the case > >