)
when != x = e
when != e = x
when any
if (<+...of_device_is_available(e)...+>) {
... when != of_node_put(e)
(
return e;
|
+ of_node_put(e);
return ...;
)
}
//
Fixes: d8f4a9eda0067 ("drm: Add NVIDIA Tegra20 support")
Signed-off-by: Julia Lawall
Reviewed
by: Julia Lawall
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff -u -p a/drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c
b/drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c
--- a/drivers
Please atleast mention here why it is required?
-Mukesh
On 4/1/2019 7:33 PM, Gerd Hoffmann wrote:
Signed-off-by: Gerd Hoffmann
---
drivers/gpu/drm/virtio/virtgpu_display.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c
1;
if (ioctl(fd, FBIOPUT_VSCREENINFO, ))
return 1;
return 0;
}
Signed-off-by: Shile Zhang
To avoid any exception we should include the check.
Looks fine to me.
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/video/fbdev/core/modedb.c |
On 3/29/2019 9:20 PM, Yannick Fertré wrote:
Wrong DISPLAY_FLAGS used to set the data enable polarity.
Used or checked?
Can you also explain how it is wrong to check against this FLAG in commit?
Signed-off-by: Yannick Fertré
---
drivers/gpu/drm/stm/ltdc.c | 2 +-
1 file changed, 1
On 3/27/2019 8:49 AM, YueHaibing wrote:
Make sure of_device_id tables are NULL terminated
Found by coccinelle spatch "misc/of_table.cocci"
Signed-off-by: YueHaibing
Reviewed-by: Mukesh Ojha <mailto:mo...@codeaurora.org>>
Thanks.
Mukesh
---
drivers/gpu/drm/omapd
YueHaibing
Reviewed-by: Mukesh Ojha <mailto:mo...@codeaurora.org>>
Thanks.
Mukesh
---
v2: fix patch prefix
---
drivers/gpu/drm/virtio/virtgpu_ttm.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_ttm.c
b/drivers/gpu/drm/virtio/virtgpu_ttm.c
/vmwgfx_fb.c:645:19: warning:
variable 'fb_depth' set but not used [-Wunused-but-set-variable]
They're not used any more, so can be removed.
Signed-off-by: YueHaibing
Reviewed-by: Mukesh Ojha <mailto:mo...@codeaurora.org>>
Thanks.
Mukesh
---
drivers/gpu/drm/vmwgfx/vmwgfx
/vmwgfx_fb.c:645:19: warning:
variable 'fb_depth' set but not used [-Wunused-but-set-variable]
They're not used any more, so can be removed.
Signed-off-by: YueHaibing
Reviewed-by: Mukesh Ojha
-Mukesh
---
drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 4 +---
1 file changed, 1 insertion(+), 3
On 3/25/2019 4:46 AM, Kangjie Lu wrote:
pm_runtime_get_sync could fail and thus deserves a check.
The patch adds such a check and return its error code upstream
if it indeed failed.
Signed-off-by: Kangjie Lu
Reviewed-by: Mukesh Ojha <mailto:mo...@codeaurora.org>>
Thank
On 3/9/2019 10:06 AM, Kangjie Lu wrote:
alloc_ordered_workqueue may fail and return NULL.
The fix returns ENOMEM when it fails to avoid potential NULL
pointer dereference.
Signed-off-by: Kangjie Lu
---
drivers/gpu/drm/vkms/vkms_crtc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
you mean adreno_dump?
[-Werror=implicit-function-declaration]
adreno_show(gpu, state, p);
^~~
Reported-by: Hulk Robot
Fixes: 1707add81551 ("drm/msm/a6xx: Add a6xx gpu state")
Signed-off-by: YueHaibing
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/gpu/drm/
On 3/28/2019 2:41 AM, jagdsh.li...@gmail.com wrote:
From: Jagadeesh Pagadala
Remove duplicate headers which are included twice.
Signed-off-by: Jagadeesh Pagadala
Reviewed-by: Mukesh Ojha
-Mukesh
---
drivers/gpu/drm/bridge/panel.c | 1 -
drivers/gpu/drm/i915/intel_display.c
YueHaibing
Reviewed-by: Mukesh Ojha
-Mukesh
---
v2: fix patch prefix
---
drivers/gpu/drm/virtio/virtgpu_ttm.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_ttm.c
b/drivers/gpu/drm/virtio/virtgpu_ttm.c
index d6225ba20b30..eb007c2569d8 100644
--- a/drive
On 3/25/2019 4:46 AM, Kangjie Lu wrote:
pm_runtime_get_sync could fail and thus deserves a check.
The patch adds such a check and return its error code upstream
if it indeed failed.
Signed-off-by: Kangjie Lu
Reviewed-by: Mukesh Ojha
-Mukesh
---
drivers/gpu/drm/v3d/v3d_drv.c | 2 ++
1
On 3/29/2019 7:11 AM, YueHaibing wrote:
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Signed-off-by: YueHaibing
Reviewed-by: Mukesh Ojha
-Mukesh
---
drivers/gpu/drm/omapdrm/dss/hdmi4_core.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers
Reviewed-by: Mukesh Ojha
-Mukesh
---
drivers/gpu/drm/bridge/panel.c | 1 -
drivers/gpu/drm/i915/intel_display.c | 7 ---
2 files changed, 8 deletions(-)
diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
index 38eeaf8..eb9567d 100644
--- a/drivers/gpu
Signed-off-by: YueHaibing
Reviewed-by: Mukesh Ojha
-Mukesh
---
drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c
b/drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c
index 2b41c75ce988..e02aa8e70
On 3/29/2019 9:20 PM, Yannick Fertré wrote:
Wrong DISPLAY_FLAGS used to set the data enable polarity.
Used or checked.
Can you also explain how it is wrong to check against this FLAG in commit?
Signed-off-by: Yannick Fertré
---
drivers/gpu/drm/stm/ltdc.c | 2 +-
1 file changed, 1
On 4/8/2019 8:28 AM, Wen Yang wrote:
The call to of_get_parent returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.
Detected by coccinelle with the following warnings:
drivers/gpu/drm/rcar-du/rcar_du_of.c:235:2-8: ERROR: missing
209, but
without a corresponding object release within this function.
Signed-off-by: Wen Yang
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
Reviewed-by: Laurent Pinchart
Cc: Tomi Valkeinen
Cc: David Airlie
Cc: Daniel Vetter
Cc: Sebastian Reichel
Cc: Laurent Pinchart
Cc: dri-devel
On 4/16/2019 5:29 PM, Colin King wrote:
From: Colin Ian King
There is a spelling mistake in a DRM_INFO message. Fix it.
Signed-off-by: Colin Ian King
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/gpu/drm/amd/amdgpu/vce_v2_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
On 5/15/2019 2:27 AM, Colin King wrote:
From: Colin Ian King
There is a spelling mistake in a warning message. Fix it.
Signed-off-by: Colin Ian King
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c | 2 +-
1 file changed, 1 insertion(+), 1
On 4/18/2019 10:23 PM, Colin King wrote:
From: Colin Ian King
There is a spelling mistake in a nvkm_debug message. Fix it.
Signed-off-by: Colin Ian King
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgk104.c | 2 +-
1 file changed, 1 insertion
On 4/18/2019 4:36 PM, Colin King wrote:
From: Colin Ian King
There is a spelling mistake in a gvt_dbg_core debug message. Fix it.
Signed-off-by: Colin Ian King
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/gpu/drm/i915/gvt/vgpu.c | 2 +-
1 file changed, 1 insertion(+), 1
On 4/18/2019 3:55 PM, Colin King wrote:
From: Colin Ian King
There is a spelling mistake in a pr_err message. Fix it.
Signed-off-by: Colin Ian King
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
))
goto free_cma;
LGTM.
Reviewed-By: Mukesh Ojha
-Mukesh
Signed-off-by: Elliot Berman
Acked-by: Mukesh Ojha
-Mukesh
---
arch/arm/mach-qcom/platsmp.c | 2 +-
drivers/cpuidle/cpuidle-qcom-spm.c | 2 +-
drivers/firmware/qcom_scm-legacy.c | 2 +-
drivers/firmware/qcom_scm-smc.c | 2
28 matches
Mail list logo
