Re: [PATCH 1/6] drm/bridge: aux-hpd: fix OF node leaks

2024-02-23 Thread Neil Armstrong
On 17/02/2024 16:02, Johan Hovold wrote: The two device node references taken during allocation need to be dropped when the auxiliary device is freed. Fixes: 6914968a0b52 ("drm/bridge: properly refcount DT nodes in aux bridge drivers") Cc: Dmitry Baryshkov Cc: Neil Armstrong

Re: [PATCH 1/6] drm/bridge: aux-hpd: fix OF node leaks

2024-02-23 Thread Neil Armstrong
On 17/02/2024 16:02, Johan Hovold wrote: The two device node references taken during allocation need to be dropped when the auxiliary device is freed. Fixes: 6914968a0b52 ("drm/bridge: properly refcount DT nodes in aux bridge drivers") Cc: Dmitry Baryshkov Cc: Neil Armstrong

Re: [PATCH 8/9] arm64: dts: qcom: qcs6490-rb3gen2: Enable USB Type-C display

2024-02-22 Thread neil . armstrong
int { + remote-endpoint = <_glink_sbu_in>; + }; + }; Nice to see the SBU switching works :-) Reviewed-by: Neil Armstrong + }; }; }; @@ -483,6 +521,15 @@ { status = "okay"; }; +_dp {

Re: [PATCH 8/8] arm64: dts: qcom: qrb2210-rb1: Enable the GPU

2024-02-20 Thread neil . armstrong
On 19/02/2024 22:37, Konrad Dybcio wrote: On 19.02.2024 15:49, Dmitry Baryshkov wrote: On Mon, 19 Feb 2024 at 15:36, Konrad Dybcio wrote: Enable the A702 GPU (also marketed as "3D accelerator by qcom [1], lol). Is it not? Sure, every electronic device is also a heater, I suppose.. I

Re: [PATCH v2 1/2] dt-bindings: display: simple: Add boe,bp082wx1-100 8.2" panel

2024-02-19 Thread Neil Armstrong
Hi, On Sun, 11 Feb 2024 13:16:58 +0200, Tony Lindgren wrote: > This panel is found on Motorola mapphone tablets mz607 to mz609. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/2] dt-bindings: display: simple: Add boe,bp082wx1-100 8.2" panel

Re: [PATCH] drm/panel: boe-tv101wum-nl6: make use of prepare_prev_first

2024-02-19 Thread Neil Armstrong
Hi, On Fri, 16 Feb 2024 12:31:12 -0800, Douglas Anderson wrote: > The panel on sc7180-trogdor-wormdingler and > sc7180-trogdor-quackingstick hasn't been coming up since commit > 9e15123eca79 ("drm/msm/dsi: Stop unconditionally powering up DSI hosts > at modeset"). Let's add "prepare_prev_first"

Re: [PATCH 5/6] phy: qcom-qmp-combo: fix drm bridge registration

2024-02-19 Thread Neil Armstrong
me_enable(dev); if (ret) Reviewed-by: Neil Armstrong

Re: [PATCH v1] drm/meson: improve encoder probe / initialization error handling

2024-02-19 Thread Neil Armstrong
Hi, On Sun, 18 Feb 2024 18:50:35 +0100, Martin Blumenstingl wrote: > Rename meson_encoder_{cvbs,dsi,hdmi}_init() to > meson_encoder_{cvbs,dsi,hdmi}_probe() so it's clear that these functions > are used at probe time during driver initialization. Also switch all > error prints inside those

Re: [PATCH] drm/meson: Don't remove bridges which are created by other drivers

2024-02-19 Thread Neil Armstrong
Hi, On Thu, 15 Feb 2024 23:04:42 +0100, Martin Blumenstingl wrote: > Stop calling drm_bridge_remove() for bridges allocated/managed by other > drivers in the remove paths of meson_encoder_{cvbs,dsi,hdmi}. > drm_bridge_remove() unregisters the bridge so it cannot be used > anymore. Doing so for

Re: [PATCH] drm/meson: Don't remove bridges which are created by other drivers

2024-02-19 Thread neil . armstrong
v) if (priv->encoders[MESON_ENC_HDMI]) { meson_encoder_hdmi = priv->encoders[MESON_ENC_HDMI]; drm_bridge_remove(_encoder_hdmi->bridge); - drm_bridge_remove(meson_encoder_hdmi->next_bridge); } } Reviewed-by: Neil Armstrong Thanks a lot for the patch! Neil

Re: [PATCH v1] drm/meson: improve encoder probe / initialization error handling

2024-02-19 Thread neil . armstrong
875db8 100644 --- a/drivers/gpu/drm/meson/meson_encoder_hdmi.h +++ b/drivers/gpu/drm/meson/meson_encoder_hdmi.h @@ -7,7 +7,7 @@ #ifndef __MESON_ENCODER_HDMI_H #define __MESON_ENCODER_HDMI_H -int meson_encoder_hdmi_init(struct meson_drm *priv); +int meson_encoder_hdmi_probe(struct meson_drm *priv); void meson_encoder_hdmi_remove(struct meson_drm *priv); #endif /* __MESON_ENCODER_HDMI_H */ Reviewed-by: Neil Armstrong

Re: [PATCH 1/1] drm: bridge: dw_hdmi: Set DRM bridge type

2024-02-16 Thread Neil Armstrong
Hi, On Mon, 08 Jan 2024 16:25:14 +0100, Alexander Stein wrote: > The bridge type was set to default (Unknown). Set proper bridge type. > With this fixed, debugfs output imx8mp looks proper. > $ cat /sys/kernel/debug/dri/1/encoder-0/bridges > bridge[0]: imx_hdmi_pvi_bridge_funcs [imx8mp_hdmi_pvi]

Re: (subset) [PATCH v3 0/4] Add display support for Fairphone 4

2024-02-16 Thread Neil Armstrong
Hi, On Fri, 16 Feb 2024 11:10:47 +0100, Luca Weiss wrote: > Introduce the bindings and panel driver for the LCD panel with the model > number 9A-3R063-1102B from DJN which is using the HX83112A driver IC. It > is used on the Fairphone 4 smartphone. > > Then we can add the panel to the device dts

[PATCH v3 6/7] arm64: dts: qcom: sm8650: add GPU nodes

2024-02-16 Thread Neil Armstrong
Add GPU nodes for the SM8650 platform. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 166 +++ 1 file changed, 166 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi index

[PATCH v3 3/7] dt-bindings: arm-smmu: Document SM8650 GPU SMMU

2024-02-16 Thread Neil Armstrong
Document the GPU SMMU found on the SM8650 platform. Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree

[PATCH v3 5/7] drm/msm: add support for A750 GPU

2024-02-16 Thread Neil Armstrong
-by: Konrad Dybcio Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 ++ drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 28 +--- drivers/gpu/drm/msm/adreno/adreno_device.c | 14 ++ drivers/gpu/drm/msm/adreno/adreno_gpu.h| 10

[PATCH v3 4/7] drm/msm/a6xx: Add missing regs for A750

2024-02-16 Thread Neil Armstrong
Sync missing regs for A750 clock gating control related registers from Mesa a6xx.xml.h generated file. Those registers were added in the !27576 merge request [1]. [1] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27576 Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/adreno

[PATCH v3 7/7] arm64: dts: qcom: sm8650-qrd: enable GPU

2024-02-16 Thread Neil Armstrong
Add path of the GPU firmware for the SM8650-QRD board Reviewed-by: Konrad Dybcio Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8650-qrd.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts b/arch/arm64/boot/dts/qcom/sm8650

[PATCH v3 1/7] dt-bindings: display/msm/gmu: Document Adreno 750 GMU

2024-02-16 Thread Neil Armstrong
Document the Adreno 750 GMU found on the SM8650 platform. Reviewed-by: Konrad Dybcio Acked-by: Conor Dooley Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/display/msm/gmu.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display

[PATCH v3 2/7] dt-bindings: arm-smmu: fix SM8[45]50 GPU SMMU if condition

2024-02-16 Thread Neil Armstrong
The if condition for the SM8[45]50 GPU SMMU is too large, add the other compatible strings to the condition to only allow the clocks for the GPU SMMU nodes. Fixes: 4fff78dc2490 ("dt-bindings: arm-smmu: Document SM8[45]50 GPU SMMU") Suggested-by: Dmitry Baryshkov Signed-off-by: Neil

[PATCH v3 0/7] drm/msm: Add support for the A750 GPU found on the SM8650 platform

2024-02-16 Thread Neil Armstrong
ttps://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26934 Signed-off-by: Neil Armstrong --- Changes in v3: - Fixed smmu bindings if condition for GMU smmu - Collected reviews - Link to v2: https://lore.kernel.org/r/20240215-topic-sm8650-gpu-v2-0-6be0b4bf2...@linaro.org Changes in v2: - Added sepa

Re: [PATCH v3 2/4] drm/panel: Add driver for DJN HX83112A LCD panel

2024-02-16 Thread Neil Armstrong
uot;djn,9a-3r063-1102b" }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, hx83112a_of_match); + +static struct mipi_dsi_driver hx83112a_driver = { + .probe = hx83112a_probe, + .remove = hx83112a_remove, + .driver = { + .name = "panel-himax-hx83112a", + .of_match_table = hx83112a_of_match, + }, +}; +module_mipi_dsi_driver(hx83112a_driver); + +MODULE_DESCRIPTION("DRM driver for hx83112a-equipped DSI panels"); +MODULE_LICENSE("GPL"); LGTM Reviewed-by: Neil Armstrong

Re: [PATCH] drm/dp: Don't attempt AUX transfers when eDP panels are not powered

2024-02-16 Thread neil . armstrong
+ Bjorn + Konrad + Johan On 15/02/2024 18:08, Doug Anderson wrote: Hi, On Thu, Feb 15, 2024 at 8:53 AM Neil Armstrong wrote: Hi Doug, On 15/02/2024 16:08, Doug Anderson wrote: Hi, On Thu, Feb 15, 2024 at 2:24 AM Jani Nikula wrote: On Wed, 14 Feb 2024, Doug Anderson wrote: Hi

Re: [PATCH] drm/dp: Don't attempt AUX transfers when eDP panels are not powered

2024-02-15 Thread Neil Armstrong
Hi Doug, On 15/02/2024 16:08, Doug Anderson wrote: Hi, On Thu, Feb 15, 2024 at 2:24 AM Jani Nikula wrote: On Wed, 14 Feb 2024, Doug Anderson wrote: Hi, On Tue, Feb 13, 2024 at 10:25 PM Hsin-Yi Wang wrote: On Wed, Feb 14, 2024 at 2:23 PM Douglas Anderson wrote: If an eDP panel is

Re: [PATCH v2 2/6] dt-bindings: arm-smmu: Document SM8650 GPU SMMU

2024-02-15 Thread neil . armstrong
On 15/02/2024 10:32, Dmitry Baryshkov wrote: On Thu, 15 Feb 2024 at 11:29, Neil Armstrong wrote: On 15/02/2024 10:25, Dmitry Baryshkov wrote: On Thu, 15 Feb 2024 at 11:20, Neil Armstrong wrote: Document the GPU SMMU found on the SM8650 platform. Signed-off-by: Neil Armstrong

Re: [PATCH v2 2/6] dt-bindings: arm-smmu: Document SM8650 GPU SMMU

2024-02-15 Thread Neil Armstrong
On 15/02/2024 10:25, Dmitry Baryshkov wrote: On Thu, 15 Feb 2024 at 11:20, Neil Armstrong wrote: Document the GPU SMMU found on the SM8650 platform. Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 7 +-- 1 file changed, 5 insertions(+), 2

[PATCH v2 6/6] arm64: dts: qcom: sm8650-qrd: enable GPU

2024-02-15 Thread Neil Armstrong
Add path of the GPU firmware for the SM8650-QRD board Reviewed-by: Konrad Dybcio Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8650-qrd.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts b/arch/arm64/boot/dts/qcom/sm8650

[PATCH v2 3/6] drm/msm/a6xx: Add missing regs for A750

2024-02-15 Thread Neil Armstrong
Sync missing regs for A750 clock gating control related registers from Mesa a6xx.xml.h generated file. Those registers were added in the !27576 merge request [1]. [1] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27576 Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/adreno

[PATCH v2 4/6] drm/msm: add support for A750 GPU

2024-02-15 Thread Neil Armstrong
-by: Neil Armstrong --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 ++ drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 28 +--- drivers/gpu/drm/msm/adreno/adreno_device.c | 14 ++ drivers/gpu/drm/msm/adreno/adreno_gpu.h| 10 -- 4 files changed, 49

[PATCH v2 5/6] arm64: dts: qcom: sm8650: add GPU nodes

2024-02-15 Thread Neil Armstrong
Add GPU nodes for the SM8650 platform. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 166 +++ 1 file changed, 166 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi index

[PATCH v2 2/6] dt-bindings: arm-smmu: Document SM8650 GPU SMMU

2024-02-15 Thread Neil Armstrong
Document the GPU SMMU found on the SM8650 platform. Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation

[PATCH v2 1/6] dt-bindings: display/msm/gmu: Document Adreno 750 GMU

2024-02-15 Thread Neil Armstrong
Document the Adreno 750 GMU found on the SM8650 platform. Reviewed-by: Konrad Dybcio Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/display/msm/gmu.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/msm/gmu.yaml b

[PATCH v2 0/6] drm/msm: Add support for the A750 GPU found on the SM8650 platform

2024-02-15 Thread Neil Armstrong
ttps://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26934 Signed-off-by: Neil Armstrong --- Changes in v2: - Added separate a6xx.xml.h sync from https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27576 - Collected review tags - Inlined skip_programming - Use A7XX_RBBM_CGC_P2S_STATUS_TXDONE ins

Re: [PATCH 3/5] drm: msm: add support for A750 GPU

2024-02-15 Thread neil . armstrong
On 14/02/2024 22:43, Konrad Dybcio wrote: On 12.02.2024 15:45, Neil Armstrong wrote: On 12/02/2024 11:46, Konrad Dybcio wrote: On 12.02.2024 11:37, Neil Armstrong wrote: Add support for the A750 GPU found on the SM8650 platform Unlike the the very close A740 GPU on the SM8550 SoC, the A750

Re: [PATCH v2 2/4] drm/panel: Add driver for DJN HX83112A LCD panel

2024-02-14 Thread neil . armstrong
On 14/02/2024 10:33, Luca Weiss wrote: On Mon Jan 22, 2024 at 12:27 PM CET, Luca Weiss wrote: On Fri Jan 12, 2024 at 11:26 AM CET, wrote: On 12/01/2024 11:23, Linus Walleij wrote: On Fri, Jan 12, 2024 at 10:52 AM Luca Weiss wrote: Since there's zero indication Truly is involved in this

Re: [PATCH 3/5] drm: msm: add support for A750 GPU

2024-02-12 Thread Neil Armstrong
On 12/02/2024 11:46, Konrad Dybcio wrote: On 12.02.2024 11:37, Neil Armstrong wrote: Add support for the A750 GPU found on the SM8650 platform Unlike the the very close A740 GPU on the SM8550 SoC, the A750 GPU doesn't have an HWCFG block but a separate register set. The missing registers

Re: [PATCH 4/5] arm64: dts: qcom: sm8650: add GPU nodes

2024-02-12 Thread Neil Armstrong
On 12/02/2024 11:50, Konrad Dybcio wrote: On 12.02.2024 11:37, Neil Armstrong wrote: Add GPU nodes for the SM8650 platform. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 169 +++ 1 file changed, 169 insertions(+) diff --git a/arch

Re: [PATCH 5/5] arm64: dts: qcom: sm8650-qrd: enable GPU

2024-02-12 Thread Neil Armstrong
Hi, On 12/02/2024 14:32, Dmitry Baryshkov wrote: On Mon, 12 Feb 2024 at 12:37, Neil Armstrong wrote: Add path of the GPU firmware for the SM8650-QRD board Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8650-qrd.dts | 8 1 file changed, 8 insertions(+) diff --git

[PATCH 5/5] arm64: dts: qcom: sm8650-qrd: enable GPU

2024-02-12 Thread Neil Armstrong
Add path of the GPU firmware for the SM8650-QRD board Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8650-qrd.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts b/arch/arm64/boot/dts/qcom/sm8650-qrd.dts index 8515498553bf

[PATCH 4/5] arm64: dts: qcom: sm8650: add GPU nodes

2024-02-12 Thread Neil Armstrong
Add GPU nodes for the SM8650 platform. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 169 +++ 1 file changed, 169 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi index

[PATCH 0/5] drm/msm: Add support for the A750 GPU found on the SM8650 platform

2024-02-12 Thread Neil Armstrong
ttps://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26934 Signed-off-by: Neil Armstrong --- Neil Armstrong (5): dt-bindings: display/msm/gmu: Document Adreno 750 GMU dt-bindings: arm-smmu: Document SM8650 GPU SMMU drm: msm: add support for A750 GPU arm64: dts: qcom: sm8650: add

[PATCH 3/5] drm: msm: add support for A750 GPU

2024-02-12 Thread Neil Armstrong
hwcfg is handled in a6xx_set_hwcg(). The A750 GPU info are added under the adreno_is_a750() macro and the ADRENO_7XX_GEN3 family id. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/adreno/a6xx.xml.h | 8 drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 ++ drivers/gpu/drm/msm

[PATCH 2/5] dt-bindings: arm-smmu: Document SM8650 GPU SMMU

2024-02-12 Thread Neil Armstrong
Document the GPU SMMU found on the SM8650 platform. Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation

[PATCH 1/5] dt-bindings: display/msm/gmu: Document Adreno 750 GMU

2024-02-12 Thread Neil Armstrong
Document the Adreno 750 GMU found on the SM8650 platform. Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/display/msm/gmu.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/msm/gmu.yaml b/Documentation/devicetree/bindings

Re: [PATCH][next] drm/msm/dp: Fix spelling mistake "enale" -> "enable"

2024-02-12 Thread neil . armstrong
link clocks\n"); + drm_dbg_dp(ctrl->drm_dev, "enable link clocks\n"); drm_dbg_dp(ctrl->drm_dev, "stream_clks:%s link_clks:%s core_clks:%s\n", ctrl->stream_clks_on ? "on" : "off", ctrl->link_clks_on ? "on" : "off", Reviewed-by: Neil Armstrong

Re: [PATCH] drm/bridge: imx8mp-hdmi-pvi: Fix build warnings

2024-02-07 Thread Neil Armstrong
Hi, On Tue, 06 Feb 2024 18:23:04 -0600, Adam Ford wrote: > Two separate build warnings were reported. One from an > uninitialized variable, and the other from returning 0 > instead of NULL from a pointer. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git

Re: [PATCH] drm/bridge: imx8mp-hdmi-pvi: Fix build warnings

2024-02-07 Thread Neil Armstrong
On 07/02/2024 10:22, Fabio Estevam wrote: Hi Adam, On Tue, Feb 6, 2024 at 9:23 PM Adam Ford wrote: Two separate build warnings were reported. One from an uninitialized variable, and the other from returning 0 instead of NULL from a pointer. Fixes: 059c53e877ca ("drm/bridge: imx: add driver

Re: [PATCH v2] drm/panel: re-alphabetize the menu list

2024-02-07 Thread Neil Armstrong
Hi, On Sun, 04 Feb 2024 22:27:08 -0800, Randy Dunlap wrote: > A few of the DRM_PANEL entries have become out of alphabetical order, > so move them around a bit to restore alpha order. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/1] drm/panel:

Re: [PATCH 5/5] drm/panel: simple: push blanking limit on RK32FN48H

2024-02-07 Thread Neil Armstrong
Hi, On Mon, 05 Feb 2024 10:26:50 +0100, Raphael Gallais-Pou wrote: > Push horizontal front porch and vertical back porch blanking limit. > This allows to get a 60 fps sharp. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [5/5] drm/panel: simple:

Re: (subset) [PATCH 0/5] Add display support for stm32mp135f-dk board

2024-02-07 Thread Neil Armstrong
Hi, On Mon, 05 Feb 2024 10:06:50 +0100, Raphael Gallais-Pou wrote: > This serie aims to enable display support for the stm32mp135f-dk board > > Those are only patches of the device-tree since the driver support has > already been added [1]. > > It respectivelly: > - adds support for the

Re: [PATCH] drm/bridge: imx8mp-hdmi-pvi: Fix build warnings

2024-02-07 Thread Neil Armstrong
e(crtc_state->state, next_bridge); Reviewed-by: Neil Armstrong

Re: [PATCH v2] drm/panel: re-alphabetize the menu list

2024-02-06 Thread Neil Armstrong
On 05/02/2024 07:27, Randy Dunlap wrote: A few of the DRM_PANEL entries have become out of alphabetical order, so move them around a bit to restore alpha order. Signed-off-by: Randy Dunlap Cc: Neil Armstrong Cc: Jessica Zhang Cc: Sam Ravnborg Cc: Maarten Lankhorst Cc: Maxime Ripard Cc

Re: [PATCH 4/5] drm/panel: simple: fix flags on RK043FN48H

2024-02-06 Thread Neil Armstrong
-by: Neil Armstrong

Re: [PATCH 5/5] drm/panel: simple: push blanking limit on RK32FN48H

2024-02-06 Thread Neil Armstrong
= { 2, 12, 12 }, + .vback_porch = { 2, 12, 26 }, .vfront_porch = { 1, 4, 4 }, .vsync_len = { 1, 10, 10 }, .flags = DISPLAY_FLAGS_VSYNC_LOW | DISPLAY_FLAGS_HSYNC_LOW | Reviewed-by: Neil Armstrong

Re: (subset) [PATCH V8 00/12] soc: imx8mp: Add support for HDMI

2024-02-06 Thread Neil Armstrong
Hi, On Sat, 03 Feb 2024 10:52:40 -0600, Adam Ford wrote: > The i.MX8M Plus has an HDMI controller, but it depends on two > other systems, the Parallel Video Interface (PVI) and the > HDMI PHY from Samsung. The LCDIF controller generates the display > and routes it to the PVI which converts passes

[PATCH v10 4/7] drm/meson: gate px_clk when setting rate

2024-02-05 Thread Neil Armstrong
Disable the px_clk when setting the rate to recover a fully configured and correctly reset VCLK clock tree after the rate is set. Fixes: 77d9e1e6b846 ("drm/meson: add support for MIPI-DSI transceiver") Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_dw_mipi_dsi.c | 7

[PATCH v10 7/7] arm64: dts: amlogic: meson-g12b-bananapi-cm4: add support for MNT Reform2 with CM4 adaper

2024-02-05 Thread Neil Armstrong
This adds a basic devicetree for the MNT Reform2 DIY laptop when using a CM4 adapter and a BPI-CM4 module. Co-developed-by: Lukas F. Hartmann Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/Makefile | 1 + .../meson-g12b-bananapi-cm4-mnt-reform2.dts| 384

[PATCH v10 6/7] arm64: meson: khadas-vim3l: add TS050 DSI panel overlay

2024-02-05 Thread Neil Armstrong
This add dtbo overlay to support the Khadas TS050 panel on the Khadas VIM3 & VIM3L boards. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/Makefile | 3 + .../boot/dts/amlogic/meson-khadas-vim3-ts050.dtso | 108 + 2 files changed,

[PATCH v10 5/7] arm64: meson: g12-common: add the MIPI DSI nodes

2024-02-05 Thread Neil Armstrong
Add the MIPI DSI Analog & Digital PHY nodes and the DSI control nodes with proper port endpoint to the VPU. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 70 +++ 1 file changed, 70 insertions(+) diff --git a/arch/arm64/boot

[PATCH v10 2/7] clk: meson: add vclk driver

2024-02-05 Thread Neil Armstrong
associated with CLK_SET_RATE_GATE it ensures the rate is set while the divider is disabled and in reset mode. The VCLK_DIV enable bit isn't implemented as a gate since it's part of the divider logic and vendor does this exact sequence to ensure the divider is correctly set. Signed-off-by: Neil

[PATCH v10 3/7] clk: meson: g12a: make VCLK2 and ENCL clock path configurable by CCF

2024-02-05 Thread Neil Armstrong
_encl endpoint. Signed-off-by: Neil Armstrong --- drivers/clk/meson/Kconfig | 1 + drivers/clk/meson/g12a.c | 72 ++- 2 files changed, 53 insertions(+), 20 deletions(-) diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig inde

[PATCH v10 1/7] dt-bindings: arm: amlogic: Document the MNT Reform 2 CM4 adapter with a BPI-CM4 Module

2024-02-05 Thread Neil Armstrong
The MNT Reform 2 CM4 adapter can be populated with any Raspberry Pi CM4 compatible module such as a BPI-CM4 Module, document that. Acked-by: Conor Dooley Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/arm/amlogic.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v10 0/7] drm/meson: add support for MIPI DSI Display

2024-02-05 Thread Neil Armstrong
I. The change from v5 is that now we use a "VCLK" driver instead of notifier and rely on CLK_SET_RATE_GATE to ensure the VCLK gate operation are called. Signed-off-by: Neil Armstrong --- Changes in v10: - Rename regmap_vclk to meson_clk and add _gate for the gate - Move COMMON_C

Re: [PATCH v9 07/12] clk: meson: add vclk driver

2024-02-05 Thread neil . armstrong
On 27/11/2023 17:24, Jerome Brunet wrote: On Mon 27 Nov 2023 at 17:14, Neil Armstrong wrote: On 24/11/2023 15:41, Jerome Brunet wrote: On Fri 24 Nov 2023 at 09:41, Neil Armstrong wrote: The VCLK and VCLK_DIV clocks have supplementary bits. The VCLK has a "SOFT RESET" bit to to

Re: (subset) [PATCH V8 00/12] soc: imx8mp: Add support for HDMI

2024-02-05 Thread Neil Armstrong
Hi, On Sat, 03 Feb 2024 10:52:40 -0600, Adam Ford wrote: > The i.MX8M Plus has an HDMI controller, but it depends on two > other systems, the Parallel Video Interface (PVI) and the > HDMI PHY from Samsung. The LCDIF controller generates the display > and routes it to the PVI which converts passes

Re: [PATCH] drm/panel: visionox-r66451: Set prepare_prev_first flag

2024-02-05 Thread Neil Armstrong
Hi, On Fri, 02 Feb 2024 13:50:21 -0800, Jessica Zhang wrote: > The DSI host needs to be enabled for the panel to be initialized in > prepare(). Ensure this happens by setting prepare_prev_first. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/1]

Re: [PATCH V8 09/12] dt-bindings: display: imx: add binding for i.MX8MP HDMI TX

2024-02-05 Thread Neil Armstrong
On 03/02/2024 17:52, Adam Ford wrote: From: Lucas Stach The HDMI TX controller on the i.MX8MP SoC is a Synopsys designware IP core with a little bit of SoC integration around it. Signed-off-by: Lucas Stach Signed-off-by: Adam Ford --- V3: Change name and location to better idenfity as a

Re: [linux][PATCH v2 3/4] MAINTAINERS: add SAM9X7 SoC's LVDS controller

2024-02-05 Thread neil . armstrong
ERS M:Conor Dooley S:Supported Reviewed-by: Neil Armstrong

Re: [linux][PATCH v2 2/4] drm/bridge: add lvds controller support for sam9x7

2024-02-05 Thread neil . armstrong
Hi, On 05/02/2024 12:06, Dharma Balasubiramani wrote: Add a new LVDS controller driver for sam9x7 which does the following: - Prepares and enables the LVDS Peripheral clock - Defines its connector type as DRM_MODE_CONNECTOR_LVDS and adds itself to the global bridge list. - Identifies its output

Re: [PATCH] drm/panel: visionox-r66451: Set prepare_prev_first flag

2024-02-03 Thread Neil Armstrong
E_CONNECTOR_DSI); ctx->panel.backlight = visionox_r66451_create_backlight(dsi); --- base-commit: 51b70ff55ed88edd19b080a524063446bcc34b62 change-id: 20230717-visionox-r66451-prev-first-67b036160e32 Best regards, Reviewed-by: Neil Armstrong

Re: [PATCH] dt-bindings: visionox-rm69299: Update maintainers

2024-02-02 Thread Neil Armstrong
Hi, On Fri, 02 Feb 2024 10:03:11 -0800, Jessica Zhang wrote: > The current maintainer (Harigovindan P) is no longer reachable through > the listed email. Update maintainers list to be Abhinav and I. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)

Re: [PATCH] drm/panel: novatek-nt36523: Set prepare_prev_first

2024-02-02 Thread Neil Armstrong
Hi, On Thu, 01 Feb 2024 23:17:40 +0100, Konrad Dybcio wrote: > The .prepare callback contains the init sequence, so the DSI host *must* > be enabled at that point. Set the prepare_prev_first flag to ensure that. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git

Re: [PATCH v2] drm/panel: visionox-vtdr6130: Set prepare_prev_first flag

2024-02-02 Thread Neil Armstrong
Hi, On Thu, 01 Feb 2024 16:10:15 -0800, Jessica Zhang wrote: > The DSI host must be enabled for the panel to be initialized in > prepare(). Set the prepare_prev_first flag to guarantee this. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/1]

Re: [PATCH] dt-bindings: drm/bridge: ti-sn65dsi86: Fix bouncing @codeaurora address

2024-02-02 Thread neil . armstrong
Anderson description: | The Texas Instruments SN65DSI86 bridge takes MIPI DSI in and outputs eDP. Reviewed-by: Neil Armstrong

Re: [PATCH] dt-bindings: visionox-rm69299: Update maintainers

2024-02-02 Thread Neil Armstrong
description: | This binding is for display panels using a Visionox RM692999 panel. --- base-commit: 51b70ff55ed88edd19b080a524063446bcc34b62 change-id: 20240202-rm69299-maintainers-7e069f78334f Best regards, Reviewed-by: Neil Armstrong

Re: [PATCH v2] drm/panel: visionox-vtdr6130: Set prepare_prev_first flag

2024-02-02 Thread Neil Armstrong
On 02/02/2024 01:10, Jessica Zhang wrote: The DSI host must be enabled for the panel to be initialized in prepare(). Set the prepare_prev_first flag to guarantee this. Signed-off-by: Jessica Zhang --- To: Neil Armstrong To: Sam Ravnborg To: David Airlie To: Daniel Vetter To: Jessica Zhang

Re: (subset) [PATCH RFC for upstream 0/4] Add support for ETML1010G3DRA LVDS display on phyBOARD-Pollux

2024-01-29 Thread Neil Armstrong
Hi, On Fri, 26 Jan 2024 09:57:22 +0100, Yannic Moog wrote: > This series adds the LVDS panel support in simple-panel, introduces > device tree support for the LVDS panel on the phyBOARD-Pollux and > enables the FSL_LDB config option needed for the driver for the imx8mp > ldb bridge. > Thanks,

Re: [PATCH v3 00/39] drm/bridge: switch to struct drm_edid

2024-01-25 Thread Neil Armstrong
ertions(+), 267 deletions(-) Thanks, but now some patches subjects are wrong: s/drm_bridge_read_edid/drm_bridge_edid_read/s With that fixed please add: Reviewed-by: Neil Armstrong Thanks, Neil

Re: [PATCH v3 01/39] drm/bridge: add ->edid_read hook and drm_bridge_edid_read()

2024-01-25 Thread Neil Armstrong
_read(struct drm_bridge *bridge, + struct drm_connector *connector); struct edid *drm_bridge_get_edid(struct drm_bridge *bridge, struct drm_connector *connector); void drm_bridge_hpd_enable(struct drm_bridge *bridge, Reviewed-by: Neil Armstrong

Re: [PATCH] drm/panel: novatek-nt36672e: Include

2024-01-16 Thread neil . armstrong
tek-nt36672e.c @@ -4,7 +4,7 @@ #include #include #include -#include +#include #include #include Fixes: ea4f9975625a ("drm/panel: Add support for Novatek NT36672E panel driver") Reviewed-by: Neil Armstrong

Re: [PATCH 0/2] drm/bridge: sii902x: Crash fixes

2024-01-16 Thread Neil Armstrong
Hi, On Wed, 03 Jan 2024 15:31:06 +0200, Tomi Valkeinen wrote: > Two small fixes to sii902x for crashes. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-fixes) [1/2] drm/bridge: sii902x: Fix probing race issue

Re: [PATCH] drm/bridge: synopsys: dw-mipi-dsi: fix deferred dsi host probe breaks dsi device probe

2024-01-15 Thread neil . armstrong
On 15/01/2024 11:07, Heiko Stübner wrote: Am Montag, 15. Januar 2024, 09:45:10 CET schrieb neil.armstr...@linaro.org: Hi, On 12/01/2024 19:07, Farouk Bouabid wrote: dw-mipi-dsi based drivers such as dw-mipi-dsi-rockchip or dw_mipi_dsi-stm depend on dw_mipi_dsi_probe() to initialize the

Re: [PATCH] drm/panel: nt36523: Set 120Hz fps for xiaomi,elish panels

2024-01-15 Thread Neil Armstrong
Hi, On Fri, 12 Jan 2024 22:00:47 +0800, Jianhua Lu wrote: > After commit e6c0de5f4450 ("drm/msm/dpu: try multirect based on mdp clock > limits") > merged, 120Hz is working on xiaomi,elish panels, so feature it. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git

Re: [PATCH] drm/bridge: synopsys: dw-mipi-dsi: fix deferred dsi host probe breaks dsi device probe

2024-01-15 Thread neil . armstrong
Hi, On 12/01/2024 19:07, Farouk Bouabid wrote: dw-mipi-dsi based drivers such as dw-mipi-dsi-rockchip or dw_mipi_dsi-stm depend on dw_mipi_dsi_probe() to initialize the dw_mipi_dsi driver structure (dmd pointer). This structure is only initialized once dw_mipi_dsi_probe() returns, creating the

Re: [PATCH] drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE

2024-01-15 Thread Neil Armstrong
Hi Luca, On 11/01/2024 13:38, Luca Weiss wrote: Since the kconfig symbol of DRM_PANEL_BRIDGE is only adding bridge/panel.o to drm_kms_helper object, we need to select DRM_KMS_HELPER to make sure the file is actually getting built. Otherwise with certain defconfigs e.g. devm_drm_of_get_bridge

Re: [PATCH v2 2/4] drm/panel: Add driver for DJN HX83112A LCD panel

2024-01-12 Thread neil . armstrong
On 12/01/2024 11:23, Linus Walleij wrote: On Fri, Jan 12, 2024 at 10:52 AM Luca Weiss wrote: Since there's zero indication Truly is involved in this panel in my documentation - much less the number 5P65 - I'm not going to add that. Ack OK then, I fold, thanks for looking into it. Keep

Re: [PATCH linux-next v2] drm/panel: Simplify with dev_err_probe()

2024-01-12 Thread Neil Armstrong
Hi, On Mon, 25 Dec 2023 22:26:15 +0800, chenguanxi11...@163.com wrote: > dev_err_probe() can check if the error code is -EPROBE_DEFER > and can return the error code, replacing dev_err() with it > simplifies the code. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git

Re: [PATCH linux-next] drm/panel: Simplify with dev_err_probe()

2024-01-12 Thread Neil Armstrong
Hi, On Wed, 20 Dec 2023 10:48:53 +0800, yang.gua...@zte.com.cn wrote: > dev_err_probe() can check if the error code is -EPROBE_DEFER > and can return the error code, replacing dev_err() with it > simplifies the code. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git

Re: [PATCH linux-next] drm/panel: samsung: Simplify with dev_err_probe()

2024-01-12 Thread neil . armstrong
On 03/01/2024 15:17, chenguanxi11...@163.com wrote: From: Chen Haonan dev_err_probe() can check if the error code is -EPROBE_DEFER and can return the error code, replacing dev_err() with it simplifies the code. Signed-off-by: Chen Haonan --- drivers/gpu/drm/panel/panel-samsung-s6d16d0.c |

Re: [v2 0/2] Add support for Novatek NT36672E LCD DSI panel

2024-01-12 Thread Neil Armstrong
Hi, On Mon, 08 Jan 2024 15:29:00 +0530, Ritesh Kumar wrote: > Add support for the 1080x2408 Novatek NT36672E LCD DSI mode panel > found on the Qualcomm QCM6490 MTP board. > > The driver will come with the uncompressed video mode support. > Thanks, Applied to

Re: [PATCH] drm/panel/raydium-rm692e5: select CONFIG_DRM_DISPLAY_DP_HELPER

2024-01-12 Thread Neil Armstrong
Hi, On Mon, 23 Oct 2023 13:55:58 +0200, Arnd Bergmann wrote: > As with several other panel drivers, this fails to link without the DP > helper library: > > ld: drivers/gpu/drm/panel/panel-raydium-rm692e5.o: in function > `rm692e5_prepare': > panel-raydium-rm692e5.c:(.text+0x11f4): undefined

Re: (subset) [PATCH v2 0/2] Fix panel polarity mixup in S6D7AA0 panel driver and Galaxy Tab 3 8.0 DTSI

2024-01-12 Thread Neil Armstrong
Hi, On Fri, 05 Jan 2024 07:53:00 +0100, Artur Weber wrote: > Two small one-line patches to address a mixup in the Samsung S6D7AA0 > panel driver and the Samsung Galaxy Tab 3 8.0 board it was initially > added for. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git

Re: (subset) [PATCH v3 0/4] arm64: rockchip: Pine64 PineTab2 support

2024-01-12 Thread neil . armstrong
From: Neil Armstrong Hi, On Tue, 02 Jan 2024 17:15:43 +0100, Manuel Traut wrote: > This adds support for the BOE TH101MB31IG002 LCD Panel used in PineTab2 [1] > and > PineTab-V [2] as well as the devictrees for the PineTab2 v0.1 and v2.0. > > The BOE LCD Panel patch was re

Re: [PATCH v2 1/1] drm: panel: simple: convert LG LB070WV8 fixed mode into display timings

2024-01-12 Thread Neil Armstrong
Hi, On Wed, 10 Jan 2024 09:22:45 +0100, Alexander Stein wrote: > At least the pixelclock has a range which can vary. Convert fixed mode > into display timings so they can be overwritten in DT if necessary. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git

Re: [PATCH v2 1/1] drm: panel-simple: add missing bus flags for Tianma tm070jvhg[30/33]

2024-01-12 Thread Neil Armstrong
Hi, On Thu, 12 Oct 2023 10:42:08 +0200, Alexander Stein wrote: > The DE signal is active high on this display, fill in the missing > bus_flags. This aligns panel_desc with its display_timing. > > Fixes: 9a2654c0f62a ("drm/panel: Add and fill drm_panel type field") > Fixes: b3bfcdf8a3b6

Re: [PATCH v2 1/1] drm: panel: simple: convert LG LB070WV8 fixed mode into display timings

2024-01-12 Thread Neil Armstrong
, 25 }, }; static const struct panel_desc lg_lb070wv8 = { - .modes = _lb070wv8_mode, - .num_modes = 1, + .timings = _lb070wv8_timing, + .num_timings = 1, .bpc = 8, .size = { .width = 151, Reviewed-by: Neil Armstrong

Re: [PATCH v2 2/4] drm/panel: Add driver for DJN HX83112A LCD panel

2024-01-12 Thread Neil Armstrong
On 12/01/2024 10:00, Luca Weiss wrote: On Thu Jan 11, 2024 at 8:05 PM CET, Linus Walleij wrote: On Thu, Jan 11, 2024 at 4:28 PM Luca Weiss wrote: In some internal documentation it says "LCD Driver IC" "HX83112A" and I don't see any reference to Truly 5P65 anywhere. In the Android directory

Re: [PATCH 1/2] drm/etnaviv: Expose a few more chipspecs to userspace

2024-01-10 Thread Neil Armstrong
On 10/01/2024 17:24, Neil Armstrong wrote: Hi, On Wed, 10 Jan 2024 16:37:00 +0100, Tomeu Vizoso wrote: These ones will be needed to make use fo the NN and TP units in the NPUs based on Vivante IP. Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.9

Re: [PATCH 1/2] drm/etnaviv: Expose a few more chipspecs to userspace

2024-01-10 Thread Neil Armstrong
Hi, On Wed, 10 Jan 2024 16:37:00 +0100, Tomeu Vizoso wrote: > These ones will be needed to make use fo the NN and TP units in the NPUs > based on Vivante IP. > > Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.9/arm64-dt) [1/2] drm/etnaviv: Expose a

Re: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add compatible property for waveshare 7inch touchscreen panel

2024-01-10 Thread neil . armstrong
On 09/01/2024 17:32, Conor Dooley wrote: On Tue, Jan 09, 2024 at 03:09:48PM +0800, Shengyang Chen wrote: The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480 panel It can be drived by Raspberry Pi panel's process but it needs different timing from Raspberry Pi panel. Add

<    1   2   3   4   5   6   7   8   9   10   >