Re: [PATCH] Revert "drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE"

2024-03-18 Thread Neil Armstrong
Hi, On Mon, 18 Mar 2024 15:16:21 +0100, Neil Armstrong wrote: > This reverts commit e3f18b0dd1db242791afbc3bd173026163ce0ccc. > > Selecting DRM_KMS_HELPER for DRM_PANEL_BRIDGE leads to: > WARNING: unmet direct dependencies detected for DRM_KMS_HELPER > Depends on [m]: HAS_IOMEM

[PATCH] Revert "drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE"

2024-03-18 Thread Neil Armstrong
kconfig warns and then multiple linker error. Reported-by: Imre Deak Reported-by: Jani Nikula Reported-by: Ville Syrjälä Fixes: e3f18b0dd1db ("drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE") Signed-off-by: Neil Armstrong --- drivers/gpu/drm/bridge/Kconfig | 1 - 1 file c

Re: [PATCH] drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE

2024-03-18 Thread Neil Armstrong
On 18/03/2024 14:41, Ville Syrjälä wrote: On Mon, Mar 18, 2024 at 12:52:10PM +0200, Jani Nikula wrote: On Mon, 18 Mar 2024, Neil Armstrong wrote: Hi, On Thu, 11 Jan 2024 13:38:04 +0100, Luca Weiss wrote: Since the kconfig symbol of DRM_PANEL_BRIDGE is only adding bridge/panel.o to

Re: [PATCH] drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE

2024-03-18 Thread Neil Armstrong
Hi, On Thu, 11 Jan 2024 13:38:04 +0100, Luca Weiss wrote: > Since the kconfig symbol of DRM_PANEL_BRIDGE is only adding > bridge/panel.o to drm_kms_helper object, we need to select > DRM_KMS_HELPER to make sure the file is actually getting built. > > Otherwise with certain defconfigs e.g. devm_dr

Re: [PATCH] drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE

2024-03-18 Thread neil . armstrong
On 08/03/2024 10:29, Luca Weiss wrote: On Sun Mar 3, 2024 at 9:37 PM CET, Dmitry Baryshkov wrote: On Thu, 29 Feb 2024 at 11:27, Luca Weiss wrote: On Wed Jan 17, 2024 at 9:59 AM CET, Luca Weiss wrote: On Mon Jan 15, 2024 at 9:43 AM CET, Neil Armstrong wrote: Hi Luca, On 11/01/2024 13:38

Re: [PATCH] drm/panel: ilitek-ili9881c: Fix warning with GPIO controllers that sleep

2024-03-18 Thread Neil Armstrong
1); return 0; } Anyway: Reviewed-by: Neil Armstrong

Re: [PATCH 2/2] drm/panel: ilitek-ili9881c: Add Startek KD050HDFIA020-C020A support

2024-03-18 Thread Neil Armstrong
atible = "wanchanglong,w552946aba", .data = &w552946aba_desc }, { .compatible = "ampire,am8001280g", .data = &am8001280g_desc }, Reviewed-by: Neil Armstrong

Re: [PATCH v3 0/3] panel-simple: add support for Crystal Clear CMT430B19N00

2024-03-13 Thread neil . armstrong
From: Neil Armstrong Hi, On Wed, 13 Mar 2024 18:20:13 +0100, Jérémie Dautheribes wrote: > This patch series add support for the Crystal Clear Technology > CMT430B19N00 4.3" 480x272 TFT-LCD panel. > It also adds Crystal Clear Technology to vendor-prefixes.yaml. > &

Re: [PATCH v3 3/3] drm/panel: simple: add CMT430B19N00 LCD panel support

2024-03-13 Thread Neil Armstrong
ompatible = "boe,hv070wsa-100", .data = &boe_hv070wsa + }, { + .compatible = "cct,cmt430b19n00", + .data = &cct_cmt430b19n00, }, { .compatible = "cdtech,s043wq26h-ct7", .da

Re: [PATCH v3 6/7] arm64: dts: qcom: sm8650: add GPU nodes

2024-03-12 Thread Neil Armstrong
On 12/03/2024 01:20, Konrad Dybcio wrote: On 2/16/24 12:03, Neil Armstrong wrote: Add GPU nodes for the SM8650 platform. Signed-off-by: Neil Armstrong ---   arch/arm64/boot/dts/qcom/sm8650.dtsi | 166 +++   1 file changed, 166 insertions(+) diff --git a/arch

Re: [PATCH 7/8] drm/bridge: lt9611uxc: use int for holding number of modes

2024-03-11 Thread Neil Armstrong
On 08/03/2024 17:03, Jani Nikula wrote: lt9611uxc_connector_get_modes() propagates the return value of drm_edid_connector_add_modes() but stores the int temporarily in an unsigned int. Use the correct type. Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Signed-off-by: Jani Nikula

Re: [PATCH] drm/bridge: correct DRM_BRIDGE_OP_EDID documentation

2024-03-11 Thread Neil Armstrong
hat set this flag shall implement -* the &drm_bridge_funcs->get_edid callback. +* the &drm_bridge_funcs->edid_read callback. */ DRM_BRIDGE_OP_EDID = BIT(1), /** --- base-commit: 1843e16d2df9d98427ef8045589571749d627cf7 change-id: 20240310-drm-bridge-fix-docs-0fd12bc6a041 Best regards, Reviewed-by: Neil Armstrong

Re: [PATCH 2/8] drm/panel: do not return negative error codes from drm_panel_get_modes()

2024-03-11 Thread Neil Armstrong
other counts leading to bogus values. On the other hand, many of the struct drm_panel_funcs .get_modes() hooks do return negative error codes, so handle them gracefully instead of propagating further. Return 0 for no modes, whatever the reason. Cc: Neil Armstrong Cc: Jessica Zhang Cc: Sam

Re: [PATCH v2 9/9] drm/panel: truly-nt35597: Don't log an error when DSI host can't be found

2024-03-01 Thread Neil Armstrong
, that's right. Comes down to personal opinion. There always was an exception for strings to go over the 80col, and I like it better as an one-liner. So I'm in favor with the initial proposal. Reviewed-by: Neil Armstrong Neil Cheers Reviewed-by: AngeloGioacchino Del Regno R

Re: [PATCH 1/3] dt-bindings: Add Crystal Clear Technology vendor prefix

2024-02-29 Thread Neil Armstrong
Hi Jérémie, On 23/02/2024 19:22, Conor Dooley wrote: On Fri, Feb 23, 2024 at 02:45:15PM +0100, Jérémie Dautheribes wrote: Update Documentation/devicetree/bindings/vendor-prefixes.yaml to include "cct" as a vendor prefix for "Crystal Clear Technology". CCT is the vendor of the CMT430B19N00 TFT-L

Re: (subset) [PATCH 0/3] drm/panel: Pixel 3a Panel

2024-02-29 Thread Neil Armstrong
Hi, On Thu, 08 Feb 2024 19:16:41 -0500, Richard Acayan wrote: > This adds support for the AMS559NK06 panel with the S6E3FA7 display > controller and enables the display subsystem on the Pixel 3a. > > Richard Acayan (3): > dt-bindings: display: panel-simple-dsi: add s6e3fa7 ams559nk06 compat >

Re: [PATCH] drm/dp: Don't attempt AUX transfers when eDP panels are not powered

2024-02-28 Thread neil . armstrong
On 28/02/2024 17:40, Doug Anderson wrote: Neil, On Thu, Feb 15, 2024 at 8:53 AM Neil Armstrong wrote: Hi Doug, On 15/02/2024 16:08, Doug Anderson wrote: Hi, On Thu, Feb 15, 2024 at 2:24 AM Jani Nikula wrote: On Wed, 14 Feb 2024, Doug Anderson wrote: Hi, On Tue, Feb 13, 2024 at 10

Re: [PATCH] drm/bridge: anx7625: Don't log an error when DSI host can't be found

2024-02-28 Thread Neil Armstrong
nd dsi host.\n"); dsi = devm_mipi_dsi_device_register_full(dev, host, &info); if (IS_ERR(dsi)) { --- base-commit: 2ae0a045e6814c8c1d676d6153c605a65746aa29 change-id: 20240226-anx7625-defer-log-no-dsi-host-c3f9ccbcb287 Best regards, Reviewed-by: Neil Armstrong

Re: [PATCH] Revert "drm/msm/dp: use drm_bridge_hpd_notify() to report HPD status changes"

2024-02-28 Thread neil . armstrong
dp->dp_display.connector_type, hpd); - drm_bridge_hpd_notify(bridge, dp->dp_display.link_ready); + dp_display_send_hpd_event(&dp->dp_display); return 0; } Tested-by: Neil Armstrong # on SM8650-HDK

Re: [PATCH 3/3] drm/panel: simple: add CMT430B19N00 LCD panel support

2024-02-26 Thread Neil Armstrong
.compatible = "cct,cmt430b19n00", + .data = &cct_cmt430b19n00, }, { .compatible = "cdtech,s043wq26h-ct7", .data = &cdtech_s043wq26h_ct7, Reviewed-by: Neil Armstrong

Re: [PATCH 0/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free

2024-02-23 Thread Neil Armstrong
On 23/02/2024 15:52, Johan Hovold wrote: On Fri, Feb 23, 2024 at 03:38:13PM +0100, Neil Armstrong wrote: On 23/02/2024 15:21, Johan Hovold wrote: But it is *not* standalone as I tried to explain above. So you have to drop it again as the later patches depend on it and cannot be merged

Re: [PATCH 0/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free

2024-02-23 Thread Neil Armstrong
-bridge.h | 15 + 5 files changed, 102 insertions(+), 36 deletions(-) For the serie: Acked-by: Neil Armstrong After an offline discussion, Dmitry, it's ok to push the remaining patches to drm-misc-fixes. Thanks, Neil

Re: [PATCH 0/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free

2024-02-23 Thread Neil Armstrong
On 23/02/2024 15:21, Johan Hovold wrote: On Fri, Feb 23, 2024 at 02:52:28PM +0100, Neil Armstrong wrote: On 23/02/2024 13:51, Johan Hovold wrote: On Fri, Feb 23, 2024 at 12:03:10PM +0100, Neil Armstrong wrote: On 23/02/2024 12:02, Neil Armstrong wrote: Thanks, Applied to https

Re: [PATCH 0/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free

2024-02-23 Thread Neil Armstrong
On 23/02/2024 13:51, Johan Hovold wrote: On Fri, Feb 23, 2024 at 12:03:10PM +0100, Neil Armstrong wrote: On 23/02/2024 12:02, Neil Armstrong wrote: Hi, On Sat, 17 Feb 2024 16:02:22 +0100, Johan Hovold wrote: Starting with 6.8-rc1 the internal display sometimes fails to come up on machines

Re: [PATCH 4/6] soc: qcom: pmic_glink: Fix boot when QRTR=m

2024-02-23 Thread Neil Armstrong
m_device *pdev) out_release_ucsi_aux: if (pg->client_mask & BIT(PMIC_GLINK_CLIENT_UCSI)) pmic_glink_del_aux_device(pg, &pg->ucsi_aux); +out_release_pdr_handle: + pdr_handle_release(pg->pdr); return ret; } Reviewed-by: Neil Armstrong

Re: [PATCH 0/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free

2024-02-23 Thread Neil Armstrong
On 23/02/2024 12:02, Neil Armstrong wrote: Hi, On Sat, 17 Feb 2024 16:02:22 +0100, Johan Hovold wrote: Starting with 6.8-rc1 the internal display sometimes fails to come up on machines like the Lenovo ThinkPad X13s and the logs indicate that this is due to a regression in the DRM subsystem [1

Re: [PATCH 0/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free

2024-02-23 Thread Neil Armstrong
Hi, On Sat, 17 Feb 2024 16:02:22 +0100, Johan Hovold wrote: > Starting with 6.8-rc1 the internal display sometimes fails to come up on > machines like the Lenovo ThinkPad X13s and the logs indicate that this > is due to a regression in the DRM subsystem [1]. > > This series fixes a race in the pm

Re: [PATCH 1/6] drm/bridge: aux-hpd: fix OF node leaks

2024-02-23 Thread Neil Armstrong
On 17/02/2024 16:02, Johan Hovold wrote: The two device node references taken during allocation need to be dropped when the auxiliary device is freed. Fixes: 6914968a0b52 ("drm/bridge: properly refcount DT nodes in aux bridge drivers") Cc: Dmitry Baryshkov Cc: Neil Armstrong Sig

Re: [PATCH 1/6] drm/bridge: aux-hpd: fix OF node leaks

2024-02-23 Thread Neil Armstrong
On 17/02/2024 16:02, Johan Hovold wrote: The two device node references taken during allocation need to be dropped when the auxiliary device is freed. Fixes: 6914968a0b52 ("drm/bridge: properly refcount DT nodes in aux bridge drivers") Cc: Dmitry Baryshkov Cc: Neil Armstrong Sig

Re: [PATCH 8/9] arm64: dts: qcom: qcs6490-rb3gen2: Enable USB Type-C display

2024-02-22 Thread neil . armstrong
_con_sbu: endpoint { + remote-endpoint = <&pmic_glink_sbu_in>; + }; + }; Nice to see the SBU switching works :-) Reviewed-by: Neil Armstrong + }; }; }; @@ -483,6 +5

Re: [PATCH 8/8] arm64: dts: qcom: qrb2210-rb1: Enable the GPU

2024-02-20 Thread neil . armstrong
On 19/02/2024 22:37, Konrad Dybcio wrote: On 19.02.2024 15:49, Dmitry Baryshkov wrote: On Mon, 19 Feb 2024 at 15:36, Konrad Dybcio wrote: Enable the A702 GPU (also marketed as "3D accelerator by qcom [1], lol). Is it not? Sure, every electronic device is also a heater, I suppose.. I found

Re: [PATCH v2 1/2] dt-bindings: display: simple: Add boe,bp082wx1-100 8.2" panel

2024-02-19 Thread Neil Armstrong
Hi, On Sun, 11 Feb 2024 13:16:58 +0200, Tony Lindgren wrote: > This panel is found on Motorola mapphone tablets mz607 to mz609. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/2] dt-bindings: display: simple: Add boe,bp082wx1-100 8.2" panel

Re: [PATCH] drm/panel: boe-tv101wum-nl6: make use of prepare_prev_first

2024-02-19 Thread Neil Armstrong
Hi, On Fri, 16 Feb 2024 12:31:12 -0800, Douglas Anderson wrote: > The panel on sc7180-trogdor-wormdingler and > sc7180-trogdor-quackingstick hasn't been coming up since commit > 9e15123eca79 ("drm/msm/dsi: Stop unconditionally powering up DSI hosts > at modeset"). Let's add "prepare_prev_first" as

Re: [PATCH 5/6] phy: qcom-qmp-combo: fix drm bridge registration

2024-02-19 Thread Neil Armstrong
m_runtime_enable(dev); if (ret) Reviewed-by: Neil Armstrong

Re: [PATCH v1] drm/meson: improve encoder probe / initialization error handling

2024-02-19 Thread Neil Armstrong
Hi, On Sun, 18 Feb 2024 18:50:35 +0100, Martin Blumenstingl wrote: > Rename meson_encoder_{cvbs,dsi,hdmi}_init() to > meson_encoder_{cvbs,dsi,hdmi}_probe() so it's clear that these functions > are used at probe time during driver initialization. Also switch all > error prints inside those function

Re: [PATCH] drm/meson: Don't remove bridges which are created by other drivers

2024-02-19 Thread Neil Armstrong
Hi, On Thu, 15 Feb 2024 23:04:42 +0100, Martin Blumenstingl wrote: > Stop calling drm_bridge_remove() for bridges allocated/managed by other > drivers in the remove paths of meson_encoder_{cvbs,dsi,hdmi}. > drm_bridge_remove() unregisters the bridge so it cannot be used > anymore. Doing so for bri

Re: [PATCH] drm/meson: Don't remove bridges which are created by other drivers

2024-02-19 Thread neil . armstrong
n_encoder_hdmi_remove(struct meson_drm *priv) if (priv->encoders[MESON_ENC_HDMI]) { meson_encoder_hdmi = priv->encoders[MESON_ENC_HDMI]; drm_bridge_remove(&meson_encoder_hdmi->bridge); - drm_bridge_remove(meson_encoder_hdmi->next_bridge); } } Reviewed-by: Neil Armstrong Thanks a lot for the patch! Neil

Re: [PATCH v1] drm/meson: improve encoder probe / initialization error handling

2024-02-19 Thread neil . armstrong
git a/drivers/gpu/drm/meson/meson_encoder_hdmi.h b/drivers/gpu/drm/meson/meson_encoder_hdmi.h index a6cd38eb5f71..fd5485875db8 100644 --- a/drivers/gpu/drm/meson/meson_encoder_hdmi.h +++ b/drivers/gpu/drm/meson/meson_encoder_hdmi.h @@ -7,7 +7,7 @@ #ifndef __MESON_ENCODER_HDMI_H #define __MESON_ENCODER_HDMI_H -int meson_encoder_hdmi_init(struct meson_drm *priv); +int meson_encoder_hdmi_probe(struct meson_drm *priv); void meson_encoder_hdmi_remove(struct meson_drm *priv); #endif /* __MESON_ENCODER_HDMI_H */ Reviewed-by: Neil Armstrong

Re: [PATCH 1/1] drm: bridge: dw_hdmi: Set DRM bridge type

2024-02-16 Thread Neil Armstrong
Hi, On Mon, 08 Jan 2024 16:25:14 +0100, Alexander Stein wrote: > The bridge type was set to default (Unknown). Set proper bridge type. > With this fixed, debugfs output imx8mp looks proper. > $ cat /sys/kernel/debug/dri/1/encoder-0/bridges > bridge[0]: imx_hdmi_pvi_bridge_funcs [imx8mp_hdmi_pvi] >

Re: (subset) [PATCH v3 0/4] Add display support for Fairphone 4

2024-02-16 Thread Neil Armstrong
Hi, On Fri, 16 Feb 2024 11:10:47 +0100, Luca Weiss wrote: > Introduce the bindings and panel driver for the LCD panel with the model > number 9A-3R063-1102B from DJN which is using the HX83112A driver IC. It > is used on the Fairphone 4 smartphone. > > Then we can add the panel to the device dts

[PATCH v3 6/7] arm64: dts: qcom: sm8650: add GPU nodes

2024-02-16 Thread Neil Armstrong
Add GPU nodes for the SM8650 platform. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 166 +++ 1 file changed, 166 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi index

[PATCH v3 3/7] dt-bindings: arm-smmu: Document SM8650 GPU SMMU

2024-02-16 Thread Neil Armstrong
Document the GPU SMMU found on the SM8650 platform. Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree

[PATCH v3 5/7] drm/msm: add support for A750 GPU

2024-02-16 Thread Neil Armstrong
ed-by: Konrad Dybcio Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 ++ drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 28 +--- drivers/gpu/drm/msm/adreno/adreno_device.c | 14 ++ drivers/gpu/drm/msm/adreno/adreno_gpu.h

[PATCH v3 4/7] drm/msm/a6xx: Add missing regs for A750

2024-02-16 Thread Neil Armstrong
Sync missing regs for A750 clock gating control related registers from Mesa a6xx.xml.h generated file. Those registers were added in the !27576 merge request [1]. [1] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27576 Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/adreno

[PATCH v3 7/7] arm64: dts: qcom: sm8650-qrd: enable GPU

2024-02-16 Thread Neil Armstrong
Add path of the GPU firmware for the SM8650-QRD board Reviewed-by: Konrad Dybcio Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8650-qrd.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts b/arch/arm64/boot/dts/qcom/sm8650

[PATCH v3 1/7] dt-bindings: display/msm/gmu: Document Adreno 750 GMU

2024-02-16 Thread Neil Armstrong
Document the Adreno 750 GMU found on the SM8650 platform. Reviewed-by: Konrad Dybcio Acked-by: Conor Dooley Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/display/msm/gmu.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display

[PATCH v3 2/7] dt-bindings: arm-smmu: fix SM8[45]50 GPU SMMU if condition

2024-02-16 Thread Neil Armstrong
The if condition for the SM8[45]50 GPU SMMU is too large, add the other compatible strings to the condition to only allow the clocks for the GPU SMMU nodes. Fixes: 4fff78dc2490 ("dt-bindings: arm-smmu: Document SM8[45]50 GPU SMMU") Suggested-by: Dmitry Baryshkov Signed-off-by: Neil

[PATCH v3 0/7] drm/msm: Add support for the A750 GPU found on the SM8650 platform

2024-02-16 Thread Neil Armstrong
ng. [0] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26934 Signed-off-by: Neil Armstrong --- Changes in v3: - Fixed smmu bindings if condition for GMU smmu - Collected reviews - Link to v2: https://lore.kernel.org/r/20240215-topic-sm8650-gpu-v2-0-6be0b4bf2...@linaro.org Changes in v2: -

Re: [PATCH v3 2/4] drm/panel: Add driver for DJN HX83112A LCD panel

2024-02-16 Thread Neil Armstrong
drm_panel_remove(&ctx->panel); +} + +static const struct of_device_id hx83112a_of_match[] = { + { .compatible = "djn,9a-3r063-1102b" }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, hx83112a_of_match); + +static struct mipi_dsi_driver hx83112a_driver = { + .probe = hx83112a_probe, + .remove = hx83112a_remove, + .driver = { + .name = "panel-himax-hx83112a", + .of_match_table = hx83112a_of_match, + }, +}; +module_mipi_dsi_driver(hx83112a_driver); + +MODULE_DESCRIPTION("DRM driver for hx83112a-equipped DSI panels"); +MODULE_LICENSE("GPL"); LGTM Reviewed-by: Neil Armstrong

Re: [PATCH] drm/dp: Don't attempt AUX transfers when eDP panels are not powered

2024-02-16 Thread neil . armstrong
+ Bjorn + Konrad + Johan On 15/02/2024 18:08, Doug Anderson wrote: Hi, On Thu, Feb 15, 2024 at 8:53 AM Neil Armstrong wrote: Hi Doug, On 15/02/2024 16:08, Doug Anderson wrote: Hi, On Thu, Feb 15, 2024 at 2:24 AM Jani Nikula wrote: On Wed, 14 Feb 2024, Doug Anderson wrote: Hi, On

Re: [PATCH] drm/dp: Don't attempt AUX transfers when eDP panels are not powered

2024-02-15 Thread Neil Armstrong
Hi Doug, On 15/02/2024 16:08, Doug Anderson wrote: Hi, On Thu, Feb 15, 2024 at 2:24 AM Jani Nikula wrote: On Wed, 14 Feb 2024, Doug Anderson wrote: Hi, On Tue, Feb 13, 2024 at 10:25 PM Hsin-Yi Wang wrote: On Wed, Feb 14, 2024 at 2:23 PM Douglas Anderson wrote: If an eDP panel is not

Re: [PATCH v2 2/6] dt-bindings: arm-smmu: Document SM8650 GPU SMMU

2024-02-15 Thread neil . armstrong
On 15/02/2024 10:32, Dmitry Baryshkov wrote: On Thu, 15 Feb 2024 at 11:29, Neil Armstrong wrote: On 15/02/2024 10:25, Dmitry Baryshkov wrote: On Thu, 15 Feb 2024 at 11:20, Neil Armstrong wrote: Document the GPU SMMU found on the SM8650 platform. Signed-off-by: Neil Armstrong

Re: [PATCH v2 2/6] dt-bindings: arm-smmu: Document SM8650 GPU SMMU

2024-02-15 Thread Neil Armstrong
On 15/02/2024 10:25, Dmitry Baryshkov wrote: On Thu, 15 Feb 2024 at 11:20, Neil Armstrong wrote: Document the GPU SMMU found on the SM8650 platform. Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 7 +-- 1 file changed, 5 insertions(+), 2

[PATCH v2 6/6] arm64: dts: qcom: sm8650-qrd: enable GPU

2024-02-15 Thread Neil Armstrong
Add path of the GPU firmware for the SM8650-QRD board Reviewed-by: Konrad Dybcio Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8650-qrd.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts b/arch/arm64/boot/dts/qcom/sm8650

[PATCH v2 3/6] drm/msm/a6xx: Add missing regs for A750

2024-02-15 Thread Neil Armstrong
Sync missing regs for A750 clock gating control related registers from Mesa a6xx.xml.h generated file. Those registers were added in the !27576 merge request [1]. [1] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27576 Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/adreno

[PATCH v2 4/6] drm/msm: add support for A750 GPU

2024-02-15 Thread Neil Armstrong
ff-by: Neil Armstrong --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 ++ drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 28 +--- drivers/gpu/drm/msm/adreno/adreno_device.c | 14 ++ drivers/gpu/drm/msm/adreno/adreno_gpu.h| 10 -- 4 files change

[PATCH v2 5/6] arm64: dts: qcom: sm8650: add GPU nodes

2024-02-15 Thread Neil Armstrong
Add GPU nodes for the SM8650 platform. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 166 +++ 1 file changed, 166 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi index

[PATCH v2 2/6] dt-bindings: arm-smmu: Document SM8650 GPU SMMU

2024-02-15 Thread Neil Armstrong
Document the GPU SMMU found on the SM8650 platform. Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation

[PATCH v2 1/6] dt-bindings: display/msm/gmu: Document Adreno 750 GMU

2024-02-15 Thread Neil Armstrong
Document the Adreno 750 GMU found on the SM8650 platform. Reviewed-by: Konrad Dybcio Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/display/msm/gmu.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/msm/gmu.yaml b

[PATCH v2 0/6] drm/msm: Add support for the A750 GPU found on the SM8650 platform

2024-02-15 Thread Neil Armstrong
ng. [0] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26934 Signed-off-by: Neil Armstrong --- Changes in v2: - Added separate a6xx.xml.h sync from https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27576 - Collected review tags - Inlined skip_programming - Use A7XX_RBBM_CGC_P2S_STATUS_

Re: [PATCH 3/5] drm: msm: add support for A750 GPU

2024-02-15 Thread neil . armstrong
On 14/02/2024 22:43, Konrad Dybcio wrote: On 12.02.2024 15:45, Neil Armstrong wrote: On 12/02/2024 11:46, Konrad Dybcio wrote: On 12.02.2024 11:37, Neil Armstrong wrote: Add support for the A750 GPU found on the SM8650 platform Unlike the the very close A740 GPU on the SM8550 SoC, the A750

Re: [PATCH v2 2/4] drm/panel: Add driver for DJN HX83112A LCD panel

2024-02-14 Thread neil . armstrong
On 14/02/2024 10:33, Luca Weiss wrote: On Mon Jan 22, 2024 at 12:27 PM CET, Luca Weiss wrote: On Fri Jan 12, 2024 at 11:26 AM CET, wrote: On 12/01/2024 11:23, Linus Walleij wrote: On Fri, Jan 12, 2024 at 10:52 AM Luca Weiss wrote: Since there's zero indication Truly is involved in this pan

Re: [PATCH 3/5] drm: msm: add support for A750 GPU

2024-02-12 Thread Neil Armstrong
On 12/02/2024 11:46, Konrad Dybcio wrote: On 12.02.2024 11:37, Neil Armstrong wrote: Add support for the A750 GPU found on the SM8650 platform Unlike the the very close A740 GPU on the SM8550 SoC, the A750 GPU doesn't have an HWCFG block but a separate register set. The missing register

Re: [PATCH 4/5] arm64: dts: qcom: sm8650: add GPU nodes

2024-02-12 Thread Neil Armstrong
On 12/02/2024 11:50, Konrad Dybcio wrote: On 12.02.2024 11:37, Neil Armstrong wrote: Add GPU nodes for the SM8650 platform. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 169 +++ 1 file changed, 169 insertions(+) diff --git a/arch

Re: [PATCH 5/5] arm64: dts: qcom: sm8650-qrd: enable GPU

2024-02-12 Thread Neil Armstrong
Hi, On 12/02/2024 14:32, Dmitry Baryshkov wrote: On Mon, 12 Feb 2024 at 12:37, Neil Armstrong wrote: Add path of the GPU firmware for the SM8650-QRD board Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8650-qrd.dts | 8 1 file changed, 8 insertions(+) diff --git

[PATCH 5/5] arm64: dts: qcom: sm8650-qrd: enable GPU

2024-02-12 Thread Neil Armstrong
Add path of the GPU firmware for the SM8650-QRD board Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8650-qrd.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts b/arch/arm64/boot/dts/qcom/sm8650-qrd.dts index 8515498553bf

[PATCH 4/5] arm64: dts: qcom: sm8650: add GPU nodes

2024-02-12 Thread Neil Armstrong
Add GPU nodes for the SM8650 platform. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 169 +++ 1 file changed, 169 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi index

[PATCH 0/5] drm/msm: Add support for the A750 GPU found on the SM8650 platform

2024-02-12 Thread Neil Armstrong
ng. [0] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26934 Signed-off-by: Neil Armstrong --- Neil Armstrong (5): dt-bindings: display/msm/gmu: Document Adreno 750 GMU dt-bindings: arm-smmu: Document SM8650 GPU SMMU drm: msm: add support for A750 GPU arm64: dts: qcom: s

[PATCH 3/5] drm: msm: add support for A750 GPU

2024-02-12 Thread Neil Armstrong
stent hwcfg is handled in a6xx_set_hwcg(). The A750 GPU info are added under the adreno_is_a750() macro and the ADRENO_7XX_GEN3 family id. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/adreno/a6xx.xml.h | 8 drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 ++ drivers/gpu/dr

[PATCH 2/5] dt-bindings: arm-smmu: Document SM8650 GPU SMMU

2024-02-12 Thread Neil Armstrong
Document the GPU SMMU found on the SM8650 platform. Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation

[PATCH 1/5] dt-bindings: display/msm/gmu: Document Adreno 750 GMU

2024-02-12 Thread Neil Armstrong
Document the Adreno 750 GMU found on the SM8650 platform. Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/display/msm/gmu.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/msm/gmu.yaml b/Documentation/devicetree/bindings

Re: [PATCH][next] drm/msm/dp: Fix spelling mistake "enale" -> "enable"

2024-02-12 Thread neil . armstrong
link clocks\n"); + drm_dbg_dp(ctrl->drm_dev, "enable link clocks\n"); drm_dbg_dp(ctrl->drm_dev, "stream_clks:%s link_clks:%s core_clks:%s\n", ctrl->stream_clks_on ? "on" : "off", ctrl->link_clks_on ? "on" : "off", Reviewed-by: Neil Armstrong

Re: [PATCH] drm/bridge: imx8mp-hdmi-pvi: Fix build warnings

2024-02-07 Thread Neil Armstrong
Hi, On Tue, 06 Feb 2024 18:23:04 -0600, Adam Ford wrote: > Two separate build warnings were reported. One from an > uninitialized variable, and the other from returning 0 > instead of NULL from a pointer. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-ne

Re: [PATCH] drm/bridge: imx8mp-hdmi-pvi: Fix build warnings

2024-02-07 Thread Neil Armstrong
On 07/02/2024 10:22, Fabio Estevam wrote: Hi Adam, On Tue, Feb 6, 2024 at 9:23 PM Adam Ford wrote: Two separate build warnings were reported. One from an uninitialized variable, and the other from returning 0 instead of NULL from a pointer. Fixes: 059c53e877ca ("drm/bridge: imx: add driver

Re: [PATCH v2] drm/panel: re-alphabetize the menu list

2024-02-07 Thread Neil Armstrong
Hi, On Sun, 04 Feb 2024 22:27:08 -0800, Randy Dunlap wrote: > A few of the DRM_PANEL entries have become out of alphabetical order, > so move them around a bit to restore alpha order. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/1] drm/panel:

Re: [PATCH 5/5] drm/panel: simple: push blanking limit on RK32FN48H

2024-02-07 Thread Neil Armstrong
Hi, On Mon, 05 Feb 2024 10:26:50 +0100, Raphael Gallais-Pou wrote: > Push horizontal front porch and vertical back porch blanking limit. > This allows to get a 60 fps sharp. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [5/5] drm/panel: simple: pu

Re: (subset) [PATCH 0/5] Add display support for stm32mp135f-dk board

2024-02-07 Thread Neil Armstrong
Hi, On Mon, 05 Feb 2024 10:06:50 +0100, Raphael Gallais-Pou wrote: > This serie aims to enable display support for the stm32mp135f-dk board > > Those are only patches of the device-tree since the driver support has > already been added [1]. > > It respectivelly: > - adds support for the di

Re: [PATCH] drm/bridge: imx8mp-hdmi-pvi: Fix build warnings

2024-02-07 Thread Neil Armstrong
e(crtc_state->state, next_bridge); Reviewed-by: Neil Armstrong

Re: [PATCH v2] drm/panel: re-alphabetize the menu list

2024-02-06 Thread Neil Armstrong
On 05/02/2024 07:27, Randy Dunlap wrote: A few of the DRM_PANEL entries have become out of alphabetical order, so move them around a bit to restore alpha order. Signed-off-by: Randy Dunlap Cc: Neil Armstrong Cc: Jessica Zhang Cc: Sam Ravnborg Cc: Maarten Lankhorst Cc: Maxime Ripard Cc

Re: [PATCH 4/5] drm/panel: simple: fix flags on RK043FN48H

2024-02-06 Thread Neil Armstrong
: Neil Armstrong

Re: [PATCH 5/5] drm/panel: simple: push blanking limit on RK32FN48H

2024-02-06 Thread Neil Armstrong
= { 2, 12, 12 }, + .vback_porch = { 2, 12, 26 }, .vfront_porch = { 1, 4, 4 }, .vsync_len = { 1, 10, 10 }, .flags = DISPLAY_FLAGS_VSYNC_LOW | DISPLAY_FLAGS_HSYNC_LOW | Reviewed-by: Neil Armstrong

Re: (subset) [PATCH V8 00/12] soc: imx8mp: Add support for HDMI

2024-02-06 Thread Neil Armstrong
Hi, On Sat, 03 Feb 2024 10:52:40 -0600, Adam Ford wrote: > The i.MX8M Plus has an HDMI controller, but it depends on two > other systems, the Parallel Video Interface (PVI) and the > HDMI PHY from Samsung. The LCDIF controller generates the display > and routes it to the PVI which converts passes

[PATCH v10 4/7] drm/meson: gate px_clk when setting rate

2024-02-05 Thread Neil Armstrong
Disable the px_clk when setting the rate to recover a fully configured and correctly reset VCLK clock tree after the rate is set. Fixes: 77d9e1e6b846 ("drm/meson: add support for MIPI-DSI transceiver") Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_dw_mipi_dsi.c | 7

[PATCH v10 7/7] arm64: dts: amlogic: meson-g12b-bananapi-cm4: add support for MNT Reform2 with CM4 adaper

2024-02-05 Thread Neil Armstrong
This adds a basic devicetree for the MNT Reform2 DIY laptop when using a CM4 adapter and a BPI-CM4 module. Co-developed-by: Lukas F. Hartmann Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/Makefile | 1 + .../meson-g12b-bananapi-cm4-mnt-reform2.dts| 384

[PATCH v10 6/7] arm64: meson: khadas-vim3l: add TS050 DSI panel overlay

2024-02-05 Thread Neil Armstrong
This add dtbo overlay to support the Khadas TS050 panel on the Khadas VIM3 & VIM3L boards. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/Makefile | 3 + .../boot/dts/amlogic/meson-khadas-vim3-ts050.dtso | 108 + 2 files changed,

[PATCH v10 5/7] arm64: meson: g12-common: add the MIPI DSI nodes

2024-02-05 Thread Neil Armstrong
Add the MIPI DSI Analog & Digital PHY nodes and the DSI control nodes with proper port endpoint to the VPU. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 70 +++ 1 file changed, 70 insertions(+) diff --git a/arch/arm64/boot

[PATCH v10 2/7] clk: meson: add vclk driver

2024-02-05 Thread Neil Armstrong
associated with CLK_SET_RATE_GATE it ensures the rate is set while the divider is disabled and in reset mode. The VCLK_DIV enable bit isn't implemented as a gate since it's part of the divider logic and vendor does this exact sequence to ensure the divider is correctly set. Signed-of

[PATCH v10 3/7] clk: meson: g12a: make VCLK2 and ENCL clock path configurable by CCF

2024-02-05 Thread Neil Armstrong
e cts_encl endpoint. Signed-off-by: Neil Armstrong --- drivers/clk/meson/Kconfig | 1 + drivers/clk/meson/g12a.c | 72 ++- 2 files changed, 53 insertions(+), 20 deletions(-) diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig

[PATCH v10 1/7] dt-bindings: arm: amlogic: Document the MNT Reform 2 CM4 adapter with a BPI-CM4 Module

2024-02-05 Thread Neil Armstrong
The MNT Reform 2 CM4 adapter can be populated with any Raspberry Pi CM4 compatible module such as a BPI-CM4 Module, document that. Acked-by: Conor Dooley Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/arm/amlogic.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a

[PATCH v10 0/7] drm/meson: add support for MIPI DSI Display

2024-02-05 Thread Neil Armstrong
I. The change from v5 is that now we use a "VCLK" driver instead of notifier and rely on CLK_SET_RATE_GATE to ensure the VCLK gate operation are called. Signed-off-by: Neil Armstrong --- Changes in v10: - Rename regmap_vclk to meson_clk and add _gate for the gate - Move COMMON_C

Re: [PATCH v9 07/12] clk: meson: add vclk driver

2024-02-05 Thread neil . armstrong
On 27/11/2023 17:24, Jerome Brunet wrote: On Mon 27 Nov 2023 at 17:14, Neil Armstrong wrote: On 24/11/2023 15:41, Jerome Brunet wrote: On Fri 24 Nov 2023 at 09:41, Neil Armstrong wrote: The VCLK and VCLK_DIV clocks have supplementary bits. The VCLK has a "SOFT RESET" bit to to

Re: (subset) [PATCH V8 00/12] soc: imx8mp: Add support for HDMI

2024-02-05 Thread Neil Armstrong
Hi, On Sat, 03 Feb 2024 10:52:40 -0600, Adam Ford wrote: > The i.MX8M Plus has an HDMI controller, but it depends on two > other systems, the Parallel Video Interface (PVI) and the > HDMI PHY from Samsung. The LCDIF controller generates the display > and routes it to the PVI which converts passes

Re: [PATCH] drm/panel: visionox-r66451: Set prepare_prev_first flag

2024-02-05 Thread Neil Armstrong
Hi, On Fri, 02 Feb 2024 13:50:21 -0800, Jessica Zhang wrote: > The DSI host needs to be enabled for the panel to be initialized in > prepare(). Ensure this happens by setting prepare_prev_first. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/1]

Re: [PATCH V8 09/12] dt-bindings: display: imx: add binding for i.MX8MP HDMI TX

2024-02-05 Thread Neil Armstrong
On 03/02/2024 17:52, Adam Ford wrote: From: Lucas Stach The HDMI TX controller on the i.MX8MP SoC is a Synopsys designware IP core with a little bit of SoC integration around it. Signed-off-by: Lucas Stach Signed-off-by: Adam Ford --- V3: Change name and location to better idenfity as a br

Re: [linux][PATCH v2 3/4] MAINTAINERS: add SAM9X7 SoC's LVDS controller

2024-02-05 Thread neil . armstrong
ERS M:Conor Dooley S:Supported Reviewed-by: Neil Armstrong

Re: [linux][PATCH v2 2/4] drm/bridge: add lvds controller support for sam9x7

2024-02-05 Thread neil . armstrong
Hi, On 05/02/2024 12:06, Dharma Balasubiramani wrote: Add a new LVDS controller driver for sam9x7 which does the following: - Prepares and enables the LVDS Peripheral clock - Defines its connector type as DRM_MODE_CONNECTOR_LVDS and adds itself to the global bridge list. - Identifies its output

Re: [PATCH] drm/panel: visionox-r66451: Set prepare_prev_first flag

2024-02-03 Thread Neil Armstrong
p;visionox_r66451_funcs, DRM_MODE_CONNECTOR_DSI); ctx->panel.backlight = visionox_r66451_create_backlight(dsi); --- base-commit: 51b70ff55ed88edd19b080a524063446bcc34b62 change-id: 20230717-visionox-r66451-prev-first-67b036160e32 Best regards, Reviewed-by: Neil Armstrong

Re: [PATCH] dt-bindings: visionox-rm69299: Update maintainers

2024-02-02 Thread Neil Armstrong
Hi, On Fri, 02 Feb 2024 10:03:11 -0800, Jessica Zhang wrote: > The current maintainer (Harigovindan P) is no longer reachable through > the listed email. Update maintainers list to be Abhinav and I. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1

Re: [PATCH] drm/panel: novatek-nt36523: Set prepare_prev_first

2024-02-02 Thread Neil Armstrong
Hi, On Thu, 01 Feb 2024 23:17:40 +0100, Konrad Dybcio wrote: > The .prepare callback contains the init sequence, so the DSI host *must* > be enabled at that point. Set the prepare_prev_first flag to ensure that. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-m

Re: [PATCH v2] drm/panel: visionox-vtdr6130: Set prepare_prev_first flag

2024-02-02 Thread Neil Armstrong
Hi, On Thu, 01 Feb 2024 16:10:15 -0800, Jessica Zhang wrote: > The DSI host must be enabled for the panel to be initialized in > prepare(). Set the prepare_prev_first flag to guarantee this. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/1] drm/

<    1   2   3   4   5   6   7   8   9   10   >