le32_to_cpu() was put around the wrong operand in the descriptor magic
value check. Fix this and put it around the descriptor value which is the
one that is in little endian format.
Fixes: 40e1a70 ("drm: Add GUD USB Display driver")
Reported-by: kernel test robot
Signed-off-by: Nora
Add support for initializing the controller from device properties when
the compatible is "sitronix,st7735r".
The rotation property does not apply in this case since a matching
ADDRESS_MODE/madctl value is necessary.
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/tiny/st77
by the
solomon,ssd1307fb.yaml binding in describing the attached panel. That
binding prefixes the properties with the vendor name, not sure why that
is and I think it looks strange so I try without it.
Noralf.
Noralf Trønnes (6):
dt-bindings: display: sitronix,st7735r: Fix backlight in example
d
Add helper functions for configuring a MIPI DBI controller from device
properties.
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/drm_mipi_dbi.c | 139 +
include/drm/drm_mipi_dbi.h | 3 +
2 files changed, 142 insertions(+)
diff --git a/drivers/gpu/drm
: Noralf Trønnes
---
.../bindings/display/sitronix,st7735r.yaml| 118 +-
1 file changed, 116 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml
b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml
index
;t be
messed up by transfer errors and the speed is only limited by the amount of
pixel glitches that one is able to tolerate.
Signed-off-by: Noralf Trønnes
---
.../devicetree/bindings/display/sitronix,st7735r.yaml | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --
There are other ways than using a gpio to reset the controller so make
this property optional.
Signed-off-by: Noralf Trønnes
---
Documentation/devicetree/bindings/display/sitronix,st7735r.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/sitronix
The backlight property was lost during conversion to yaml in commit
abdd9e3705c8 ("dt-bindings: display: sitronix,st7735r: Convert to DT schema").
Put it back.
Fixes: abdd9e3705c8 ("dt-bindings: display: sitronix,st7735r: Convert to DT
schema")
Signed-off-by: Noralf Trønnes
essary clipping from update function (Noralf)
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Noralf Trønnes
Den 09.11.2021 15.56, skrev Thomas Zimmermann:
> Hi,
>
> thanks for looking through all this code.
>
> Am 09.11.21 um 14:04 schrieb Noralf Trønnes:
>>
>>
>> Den 09.11.2021 13.38, skrev Thomas Zimmermann:
>>>
>>>
>>> Am 08.11.21 um
Den 09.11.2021 10.06, skrev Thomas Zimmermann:
> Hi
>
> Am 08.11.21 um 22:01 schrieb Noralf Trønnes:
>>
>>
>> Den 01.11.2021 15.15, skrev Thomas Zimmermann:
>>> Add constants for the maximum size of the shadow-plane surface
>>> size. Useful for
Den 09.11.2021 13.38, skrev Thomas Zimmermann:
>
>
> Am 08.11.21 um 21:55 schrieb Noralf Trønnes:
>>
>>
>> Den 01.11.2021 15.15, skrev Thomas Zimmermann:
>>> Enable the FB_DAMAGE_CLIPS property to reduce display-update
>>> overhead. Also fixes a
Den 01.11.2021 15.15, skrev Thomas Zimmermann:
> Add additional information on the semantics of the size fields in
> struct drm_mode_config. Also add a TODO to review all driver for
> correct usage of these fields.
>
> Signed-off-by: Thomas Zimmermann
> ---
Acked-by: Noralf Trønnes
Den 01.11.2021 15.15, skrev Thomas Zimmermann:
> Add constants for the maximum size of the shadow-plane surface
> size. Useful for shadow planes with virtual screen sizes. The
> current sizes are 4096 scanlines with 4096 pixels each. This
> seems reasonable for current hardware, but can be incre
Den 01.11.2021 15.15, skrev Thomas Zimmermann:
> Enable the FB_DAMAGE_CLIPS property to reduce display-update
> overhead. Also fixes a warning in the kernel log.
>
> simple-framebuffer simple-framebuffer.0: [drm]
> drm_plane_enable_fb_damage_clips() not called
>
> Fix the computation of the
Den 01.11.2021 15.15, skrev Thomas Zimmermann:
> Enable the FB_DAMAGE_CLIPS property to reduce display-update
> overhead. Also fixes a warning in the kernel log.
>
> simple-framebuffer simple-framebuffer.0: [drm]
> drm_plane_enable_fb_damage_clips() not called
>
> Fix the computation of the
return 'unsigned int' (Sam, Noralf)
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Noralf Trønnes
;fbdev: make FB_BACKLIGHT a tristate")
Cc:
Signed-off-by: Noralf Trønnes
---
Changes since v1:
- No need for the #ifdef at all since FB_BACKLIGHT is always selected
- Fix fb_ssd1351 as well
fb_watterott has the same problem, but I've sent a removal patch for that one.
dri
Den 30.10.2021 18.29, skrev Noralf Trønnes:
> Commit b4a1ed0cd18b ("fbdev: make FB_BACKLIGHT a tristate") forgot to
> update fbtft breaking its backlight support when FB_BACKLIGHT is a module.
>
> Fix this by using IS_ENABLED().
>
> Fixes: b4a1ed0cd18b ("fb
This driver was made for a prototype and as far as I know it never went
into production because it was too slow. So let's remove it.
Signed-off-by: Noralf Trønnes
---
drivers/staging/fbtft/Kconfig| 6 -
drivers/staging/fbtft/Makefile | 1 -
drivers/staging/fbtft/fb_watter
Commit b4a1ed0cd18b ("fbdev: make FB_BACKLIGHT a tristate") forgot to
update fbtft breaking its backlight support when FB_BACKLIGHT is a module.
Fix this by using IS_ENABLED().
Fixes: b4a1ed0cd18b ("fbdev: make FB_BACKLIGHT a tristate")
Cc:
Signed-off-by: Noralf Trønnes
Den 22.10.2021 15.28, skrev Thomas Zimmermann:
> Enable the FB_DAMAGE_CLIPS property to reduce display-update
> overhead. Also fixes a warning in the kernel log.
>
> simple-framebuffer simple-framebuffer.0: [drm]
> drm_plane_enable_fb_damage_clips() not called
>
> Fix the computation of the
Den 22.10.2021 15.28, skrev Thomas Zimmermann:
> Allocating a shadow buffer of the height of the buffer object does
> not support fbdev overallocation. Use surface height instead.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Noralf Trønnes
n't required.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Noralf Trønnes
kernel crash:
> + dst_pitch = len;
This works:
dst_pitch = drm_rect_width(clip);
With that fixed:
Tested-by: Noralf Trønnes
Reviewed-by: Noralf Trønnes
> +
> /*
>* The cma memory is write-combined so reads are uncached.
>
*clip, bool cached)
> +void drm_fb_swab(void *dst, unsigned int dst_pitch, const void *src,
> + const struct drm_framebuffer *fb, const struct drm_rect *clip,
> + bool cached)
Tested-by: Noralf Trønnes
Reviewed-by: Noralf Trønnes
Thomas Zimmermann
> ---
Tested-by: Noralf Trønnes
Reviewed-by: Noralf Trønnes
Den 22.10.2021 15.28, skrev Thomas Zimmermann:
> Provide a function that computes the offset into a blit destination
> buffer. This will allow to move destination-buffer clipping into the
> format-helper callers.
>
> Signed-off-by: Thomas Zimmermann
> ---
> drivers/gpu/drm/drm_format_helper.c
Den 30.09.2021 11.10, skrev Thomas Zimmermann:
> Hi
>
> Am 29.09.21 um 21:11 schrieb Noralf Trønnes:
>> Hi,
>>
>> I'd appreciate if someone could review the 3 small driver patches.
>
> Series is
>
> Acked-by: Thomas Zimmermann
>
Many t
Add support for 8-bit greyscale format.
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/gud/gud_drv.c | 2 ++
drivers/gpu/drm/gud/gud_internal.h | 4
drivers/gpu/drm/gud/gud_pipe.c | 2 ++
include/drm/gud.h | 4 ++--
4 files changed, 10 insertions(+), 2
Add support for the RGB332 pixel format.
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/gud/gud_drv.c | 2 ++
drivers/gpu/drm/gud/gud_internal.h | 4
drivers/gpu/drm/gud/gud_pipe.c | 2 ++
include/drm/gud.h | 1 +
4 files changed, 9 insertions(+)
diff --git a
Add support for the RGB888 pixel format.
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/gud/gud_drv.c | 2 ++
drivers/gpu/drm/gud/gud_internal.h | 4
drivers/gpu/drm/gud/gud_pipe.c | 2 ++
include/drm/gud.h | 1 +
4 files changed, 9 insertions(+)
diff --git a
Add XRGB emulation support for devices that can only do RGB332.
v2:
- Support Big Endian (Daniel)
Cc: Thomas Zimmermann
Reviewed-by: Daniel Vetter
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/drm_format_helper.c | 50 +
include/drm/drm_format_helper.h
Hi,
I'd appreciate if someone could review the 3 small driver patches.
Changes since version 2:
- Drop the patch adding module parameter 'xrgb'. Both Daniel and
Thomas had some comments that eventually led me to to drop this for now.
Noralf.
Noralf Trønnes (6):
drm/fo
Add an entry in drm_format_info for the existing format DRM_FORMAT_R8.
Reviewed-by: Daniel Vetter
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/drm_fourcc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c
index eda832f9200d
Add XRGB emulation support for devices that can only do RGB888.
Cc: Thomas Zimmermann
Reviewed-by: Daniel Vetter
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/drm_format_helper.c | 38 +
include/drm/drm_format_helper.h | 2 ++
2 files changed, 40
> > Hi Daniel,
> >
> > >
> > > I think for a substantial improvement here in robustness what you
really
> > > want is
> > > - kmscon in userspace
> > > - disable FB layer
> > > - ideally also disable console/vt layer in the kernel
> > > - have a minimal emergency/boot-up log thing in drm, patches
> Hi Daniel,
>
> >
> > I think for a substantial improvement here in robustness what you really
> > want is
> > - kmscon in userspace
> > - disable FB layer
> > - ideally also disable console/vt layer in the kernel
> > - have a minimal emergency/boot-up log thing in drm, patches for that
> > fl
Den 08.09.2021 20.10, skrev Thomas Zimmermann:
> Hi
>
> Am 07.09.21 um 13:57 schrieb Noralf Trønnes:
>> For devices that don't support XRGB give the user the ability to
>> choose what's most important: Color depth or frames per second.
>>
>> Add
Add support for 8-bit greyscale format.
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/gud/gud_drv.c | 2 ++
drivers/gpu/drm/gud/gud_internal.h | 4
drivers/gpu/drm/gud/gud_pipe.c | 2 ++
include/drm/gud.h | 4 ++--
4 files changed, 10 insertions(+), 2
Add support for the RGB888 pixel format.
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/gud/gud_drv.c | 2 ++
drivers/gpu/drm/gud/gud_internal.h | 4
drivers/gpu/drm/gud/gud_pipe.c | 2 ++
include/drm/gud.h | 1 +
4 files changed, 9 insertions(+)
diff --git a
Add XRGB emulation support for devices that can only do RGB888.
Cc: Thomas Zimmermann
Reviewed-by: Daniel Vetter
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/drm_format_helper.c | 38 +
include/drm/drm_format_helper.h | 2 ++
2 files changed, 40
Add support for the RGB332 pixel format.
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/gud/gud_drv.c | 2 ++
drivers/gpu/drm/gud/gud_internal.h | 4
drivers/gpu/drm/gud/gud_pipe.c | 2 ++
include/drm/gud.h | 1 +
4 files changed, 9 insertions(+)
diff --git a
is set and don't set
DRM_CAP_DUMB_PREFERRED_DEPTH if RGB565 is supported (AFAIK only X.org
supports this).
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/gud/gud_drv.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/gud/gud_drv.c b/drivers/gpu/drm/gud/gud
Add XRGB emulation support for devices that can only do RGB332.
v2:
- Support Big Endian (Daniel)
Cc: Thomas Zimmermann
Reviewed-by: Daniel Vetter
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/drm_format_helper.c | 50 +
include/drm/drm_format_helper.h
Add an entry in drm_format_info for the existing format DRM_FORMAT_R8.
Reviewed-by: Daniel Vetter
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/drm_fourcc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c
index eda832f9200d
since first version:
- RGB332: Support Big Endian in the emulation (Daniel)
Noralf.
Noralf Trønnes (7):
drm/fourcc: Add R8 to drm_format_info
drm/format-helper: Add drm_fb_xrgb_to_rgb332()
drm/format-helper: Add drm_fb_xrgb_to_rgb888()
drm/gud: Add GUD_PIXEL_FORMAT_R8
drm/gud
Den 31.08.2021 14.23, skrev Daniel Vetter:
> On Mon, Aug 30, 2021 at 02:08:14PM +0200, Noralf Trønnes wrote:
>>
>>
>> Den 17.08.2021 15.56, skrev Daniel Vetter:
>>> On Tue, Aug 17, 2021 at 02:29:12PM +0200, Noralf Trønnes wrote:
>>>> Add XRGB emul
Den 17.08.2021 15.56, skrev Daniel Vetter:
> On Tue, Aug 17, 2021 at 02:29:12PM +0200, Noralf Trønnes wrote:
>> Add XRGB emulation support for devices that can only do RGB332.
>>
>> Cc: Thomas Zimmermann
>> Signed-off-by: Noralf Trønnes
>> ---
>> d
Den 17.08.2021 15.49, skrev Daniel Vetter:
> On Tue, Aug 17, 2021 at 02:29:17PM +0200, Noralf Trønnes wrote:
>> For devices that don't support XRGB give the user the ability to
>> choose what's most important: Color depth or frames per second.
>>
>>
is set and don't set
DRM_CAP_DUMB_PREFERRED_DEPTH if RGB565 is supported (AFAIK only X.org
supports this).
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/gud/gud_drv.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/gud/gud_drv.c b/drivers/gpu/drm/gud/gud
Add support for 8-bit greyscale format.
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/gud/gud_drv.c | 2 ++
drivers/gpu/drm/gud/gud_internal.h | 4
drivers/gpu/drm/gud/gud_pipe.c | 2 ++
include/drm/gud.h | 4 ++--
4 files changed, 10 insertions(+), 2
Add XRGB emulation support for devices that can only do RGB888.
Cc: Thomas Zimmermann
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/drm_format_helper.c | 38 +
include/drm/drm_format_helper.h | 2 ++
2 files changed, 40 insertions(+)
diff --git a
Add support for the RGB888 pixel format.
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/gud/gud_drv.c | 2 ++
drivers/gpu/drm/gud/gud_internal.h | 4
drivers/gpu/drm/gud/gud_pipe.c | 2 ++
include/drm/gud.h | 1 +
4 files changed, 9 insertions(+)
diff --git a
Add XRGB emulation support for devices that can only do RGB332.
Cc: Thomas Zimmermann
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/drm_format_helper.c | 47 +
include/drm/drm_format_helper.h | 2 ++
2 files changed, 49 insertions(+)
diff --git a
Add support for the RGB332 pixel format.
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/gud/gud_drv.c | 2 ++
drivers/gpu/drm/gud/gud_internal.h | 4
drivers/gpu/drm/gud/gud_pipe.c | 2 ++
include/drm/gud.h | 1 +
4 files changed, 9 insertions(+)
diff --git a
Add an entry in drm_format_info for the existing format DRM_FORMAT_R8.
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/drm_fourcc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c
index eda832f9200d..783844bfecc1 100644
--- a
.
Noralf Trønnes (7):
drm/fourcc: Add R8 to drm_format_info
drm/format-helper: Add drm_fb_xrgb_to_rgb332()
drm/format-helper: Add drm_fb_xrgb_to_rgb888()
drm/gud: Add GUD_PIXEL_FORMAT_R8
drm/gud: Add GUD_PIXEL_FORMAT_RGB332
drm/gud: Add GUD_PIXEL_FORMAT_RGB888
drm/gud: Add
e-plane formats.
>
> No functional changes.
>
> Signed-off-by: Thomas Zimmermann
> ---
Acked-by: Noralf Trønnes
Den 16.07.2021 16.07, skrev Thomas Zimmermann:
> Provide helpers that wrap dma_buf_{begin,end}_cpu_access() for all
> GEM BOs attached to a framebuffer. Convert drivers and remove ugly
> boilerplate code.
>
Nice, for the series:
Reviewed-by: Noralf Trønnes
> Thomas Zimmerma
Den 22.07.2021 04.07, skrev Dillon Min:
> Hi Noralf
>
> Thanks for your time to review my patch.
>
> On Thu, 22 Jul 2021 at 01:42, Noralf Trønnes wrote:
>>
>>
>>
>> Den 21.07.2021 09.41, skrev dillon.min...@gmail.com:
>>> From: Dillon
Den 21.07.2021 09.41, skrev dillon.min...@gmail.com:
> From: Dillon Min
>
> This driver combine tiny/ili9341.c mipi_dbi_interface driver
> with mipi_dpi_interface driver, can support ili9341 with serial
> mode or parallel rgb interface mode by register configuration.
>
> Cc: Linus Walleij
>
drm_mode_create_blob comment
Mario Kleiner (1):
drm/fourcc: Add 16 bpc fixed point framebuffer formats.
Noralf Trønnes (1):
drm/uapi: Add USB connector type
Radhakrishna Sripada (1):
drm/framebuffer: Format modifier for Intel Gen 12 render compression with
Clear Color
Simon Ser
.4+
of_find_backlight() was added in 4.17 and the gpio fix in 5.4.
Or perhaps there are other ways to signal this dependency.
> Signed-off-by: Marek Vasut
> Cc: Daniel Thompson
> Cc: Meghana Madhyastha
> Cc: Noralf Trønnes
> Cc: Sean Paul
> Cc: Thierry Reding
> ---
Acked-by: Noralf Trønnes
t;> brightness 0 on boot in DT, which without this patch leads to the
>>> display
>>> brightness to be max instead of off.
>>>
>>> Fixes: c2adda27d202f ("video: backlight: Add of_find_backlight helper
>>> in backlight.c")
>>> Signed-off-b
municate with the
> display.
>
> Cc: phone-de...@vger.kernel.org
> Cc: Douglas Anderson
> Cc: Noralf Trønnes
> Signed-off-by: Linus Walleij
> ---
Reviewed-by: Noralf Trønnes
Den 03.07.2021 21.24, skrev Peter Stuge:
> Hi Noralf,
>
> Noralf Trønnes wrote:
>> Add VID/PID for the Raspberry Pi Pico implementation.
>> Source: https://github.com/notro/gud-pico
>>
>> +++ b/drivers/gpu/drm/gud/gud_drv.c
>> @@ -660,6 +660,7 @@ sta
Provide a way for userspace to choose synchronous flushing/pageflips.
This helps save CPU and power.
It is also useful for test scripts since userspace can know when a flush
has happended and wait before doing the next visual test.
Cc: Peter Stuge
Cc: Linus Walleij
Signed-off-by: Noralf
Add VID/PID for the Raspberry Pi Pico implementation.
Source: https://github.com/notro/gud-pico
Cc: Peter Stuge
Cc: Linus Walleij
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/gud/gud_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/gud/gud_drv.c b/drivers/gpu/drm
and() and actually checking
> the error explicitly, let it use mipi_dbi_command_buf() directly
> instead.
You forgot to remove this section.
With that fixed:
Reviewed-by: Noralf Trønnes
>
> After this any code wishing to send command arrays can rely on
> mipi_dbi_command() providin
and() and actually checking
> the error explicitly, let it use mipi_dbi_command_buf() directly
> instead.
>
> After this any code wishing to send command arrays can rely on
> mipi_dbi_command() providing an appropriate error message if something
> goes wrong.
>
> Suggested-b
eij
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/gud/gud_drv.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/gud/gud_drv.c b/drivers/gpu/drm/gud/gud_drv.c
index e8b672dc9832..45427c73587f 100644
--- a/drivers/gpu/drm/gud/gud_drv.c
+++ b/driv
mit (Linus)
- Change var name s/timer/ctx/ in gud_usb_bulk_timeout()
Reviewed-by: Linus Walleij
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/gud/gud_drv.c | 50 +-
drivers/gpu/drm/gud/gud_internal.h | 2 ++
drivers/gpu/drm/gud/gud_pipe.
Den 30.06.2021 21.46, skrev Noralf Trønnes:
>
>
> Den 30.06.2021 21.13, skrev Linus Walleij:
>> This creates a macro wrapping mipi_dbi_command() such that we get
>> some explicit error reporting if something goes wrong.
>>
>> Cc: Noralf Trønnes
>> Su
Den 30.06.2021 21.13, skrev Linus Walleij:
> This creates a macro wrapping mipi_dbi_command() such that we get
> some explicit error reporting if something goes wrong.
>
> Cc: Noralf Trønnes
> Suggested-by: Douglas Anderson
> Signed-off-by: Linus Walleij
> ---
> dri
municate with the
> display.
>
> Cc: phone-de...@vger.kernel.org
> Cc: Douglas Anderson
> Cc: Noralf Trønnes
> Signed-off-by: Linus Walleij
> ---
> diff --git a/drivers/gpu/drm/panel/panel-widechips-ws2401.c
> b/drivers/gpu/drm/panel/panel-widechips-ws2401.c
> +sta
municate with the
> display.
>
> Cc: phone-de...@vger.kernel.org
> Cc: Douglas Anderson
> Cc: Noralf Trønnes
> Signed-off-by: Linus Walleij
> ---
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index 4894913936e9..f4fe1dba9912 100644
>
Den 15.06.2021 11.17, skrev Peter Stuge:
> Hi Noralf,
>
> Noralf Trønnes wrote:
>>>> +static int gud_usb_bulk(struct gud_device *gdrm, size_t len)
> ..
>>>> + timer_setup_on_stack(&ctx.timer, gud_usb_bulk_timeout, 0);
>>>> + m
Den 14.06.2021 22.54, skrev Linus Walleij:
> Hi Noralf,
>
> On Mon, Mar 29, 2021 at 8:01 PM Noralf Trønnes wrote:
>
>> There'a limit to how big a kmalloc buffer can be, and as memory gets
>> fragmented it becomes more difficult to get big buffers. The downside
Den 14.06.2021 17.49, skrev Doug Anderson:
> Hi,
>
> On Fri, Jun 11, 2021 at 2:29 PM Linus Walleij
> wrote:
>>
>> +static int mipi_dbi_typec1_command_read(struct mipi_dbi *dbi, u8 *cmd,
>> + u8 *data, size_t len)
>> +{
>> + struct spi_device *spi =
Den 11.06.2021 23.42, skrev Linus Walleij:
> The SPI access to s6e63m0 is using the DBI protocol, so switch
> to using the elaborate DBI protocol implementation in the DRM
> DBI helper library.
>
> Cc: Douglas Anderson
> Cc: Noralf Trønnes
> Signed-off-by: Linus Walleij
s6e63m0 to read display MTP information
> which is used by the driver for backlight control.
>
> Cc: Douglas Anderson
> Cc: Noralf Trønnes
> Signed-off-by: Linus Walleij
> ---
Reviewed-by: Noralf Trønnes
gt; This is the first regular panel driver making use of the
> MIPI DBI helper library. The DBI "device" portions can not
> be used because that code assumes the use of a single
> regulator and specific timings around the reset pulse that
> do not match the DB7430 datasheet.
>
&
urn 0;
> + if (!pipe->funcs || !pipe->funcs->prepare_fb) {
> + if (WARN_ON_ONCE(drm_core_check_feature(plane->dev,
> DRIVER_GEM)))
Shouldn't this check be inverted? Looks like it warns on GEM drivers.
With that considered:
Acked-by: Noralf Trønnes
Hopef
Den 21.05.2021 11.09, skrev Daniel Vetter:
> Goes through all the drivers and deletes the default hook since it's
> the default now.
>
> Signed-off-by: Daniel Vetter
Acked-by: Noralf Trønnes
Den 21.04.2021 18.31, skrev Andy Shevchenko:
> The GPIO request can fail and probe may be deferred. Thus,
> the error message may be printed again and again. Avoid
> this by replacing DRM_DEV_ERROR() by dev_err_probe().
>
> Signed-off-by: Andy Shevchenko
> ---
Series is applied to drm-misc-ne
Den 02.04.2021 10.55, skrev Bernard Zhao:
> Fix coccicheck warning:
> drivers/gpu/drm/gud/gud_internal.h:89:2-3: Unneeded semicolon
> drivers/gpu/drm/gud/gud_internal.h:107:2-3: Unneeded semicolon
>
> Signed-off-by: Bernard Zhao
> ---
Applied to drm-misc-next.
Thanks,
Noralf.
___
aring since flushing is decoupled from rendering.
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/gud/gud_drv.c | 49 +-
drivers/gpu/drm/gud/gud_internal.h | 2 ++
drivers/gpu/drm/gud/gud_pipe.c | 47
3 files changed, 77 inser
evice on unplug.
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/gud/gud_drv.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/gud/gud_drv.c b/drivers/gpu/drm/gud/gud_drv.c
index e8b672dc9832..820c7331b3b3 100644
--- a/drivers/gpu/drm/gud/gud_drv.c
Den 22.03.2021 18.44, skrev Noralf Trønnes:
> From: kernel test robot
>
> drivers/gpu/drm/gud/gud_connector.c:710:37-43: ERROR: application of sizeof
> to pointer
>
> sizeof when applied to a pointer typed expression gives the size of
> the pointer
>
> Gener
.
Generated by: scripts/coccinelle/misc/semicolon.cocci
Fixes: 40e1a70b4aed ("drm: Add GUD USB Display driver")
Reported-by: kernel test robot
Signed-off-by: kernel test robot
[fix subject and squash 3 per file patches]
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/gud/gud_conne
splay driver")
Reported-by: kernel test robot
Signed-off-by: kernel test robot
[fix subject]
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/gud/gud_connector.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/gud/gud_connector.c
b/drivers/g
EST_NOT_SUPPORTED (-EOPNOTSUPP) or add a more fitting status
value.
If the driver sees -EPIPE this means that the device has failed to
respond properly. See gud_usb_transfer().
>
> Noralf Trønnes wrote:
>> +++ b/drivers/gpu/drm/gud/gud_connector.c
> ..
>> +static int gud_c
Den 13.03.2021 12.25, skrev Noralf Trønnes:
> Hi,
>
> A while back I had the idea to turn a Raspberry Pi Zero into a $5
> USB to HDMI/SDTV/DPI display adapter.
>
> The protocol is open so people are free to make displays implementing it and
> use this driver, all that
Den 16.03.2021 10.08, skrev Maxime Ripard:
> Hi!
>
> On Tue, Mar 09, 2021 at 06:08:49PM +0100, Noralf Trønnes wrote:
>> Hi drm-misc maintainers,
>>
>> I have this series:
>>
>> GUD USB Display driver
>> https://patchwork.freedesktop.org/series/87
D_PIXEL_FORMAT_XRGB/ (Peter)
- Fix R1 and XRGB format conversion
- Add FIXME about Big Endian being broken (Peter, Ilia)
Cc: Lubomir Rintel
Acked-by: Daniel Vetter
Reviewed-by: Peter Stuge
Tested-by: Peter Stuge
Signed-off-by: Noralf Trønnes
---
MAINTAINERS
in
drm-tip and linux-next)
Noralf.
[1] https://github.com/notro/gud/wiki
[2]
https://patchwork.freedesktop.org/patch/msgid/20210303133229.3288-1-tzimmerm...@suse.de
Noralf Trønnes (3):
drm/uapi: Add USB connector type
drm/probe-helper: Check epoch counter in output_poll_execute()
drm: A
anges.
v2:
- Add Fixes tag (Daniel)
Fixes: 5186421cbfe2 ("drm: Introduce epoch counter to drm_connector")
Reviewed-by: Daniel Vetter
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/drm_probe_helper.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --g
-by: Daniel Vetter
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/drm_connector.c | 1 +
include/uapi/drm/drm_mode.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
index 717c4e7271b0..52712daed3bc 100644
--- a/drivers
Den 12.03.2021 05.32, skrev Peter Stuge:
> Ilia Mirkin wrote:
>> XRGB means that the memory layout should match a 32-bit integer,
>> stored as LE, with the low bits being B, next bits being G, etc. This
>> translates to byte 0 = B, byte 1 = G, etc. If you're on a BE system,
>> and you're han
301 - 400 of 2475 matches
Mail list logo
