[PATCH 06/11] drm/tinydrm: Remove tinydrm_shutdown()

2019-01-20 Thread Noralf Trønnes
It's just a wrapper around drm_atomic_helper_shutdown() now. Also store drm_device in the drvdata field, since that's what's used. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/core/tinydrm-core.c | 14 -- drivers/gpu/drm/tinydrm/hx8357d.c | 7 +++ drivers

[PATCH 07/11] drm/tinydrm/repaper: Use devm_drm_dev_*()

2019-01-20 Thread Noralf Trønnes
Use devm_drm_dev_init(), devm_drm_dev_register_with_fbdev() and drop using tinydrm_device. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/repaper.c | 63 --- 1 file changed, 40 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/tinydrm/repaper.c

[PATCH 04/11] drm/tinydrm: Remove tinydrm_display_pipe_init()

2019-01-20 Thread Noralf Trønnes
Further strip down tinydrm.ko and switch to drm_simple_connector_create(). Signed-off-by: Noralf Trønnes --- Documentation/gpu/tinydrm.rst | 3 - drivers/gpu/drm/tinydrm/core/Makefile | 2 +- drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c | 183 drivers

[PATCH 08/11] drm/tinydrm: Use devm_drm_dev_*()

2019-01-20 Thread Noralf Trønnes
Use devm_drm_dev_init(), devm_drm_dev_register_with_fbdev() and drop using tinydrm_device. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/hx8357d.c | 25 +-- drivers/gpu/drm/tinydrm/ili9225.c | 25 +-- drivers/gpu/drm/tinydrm/ili9341.c | 25 +-- drivers/gpu/drm

[PATCH 02/11] drm/modes: Add DRM_SIMPLE_MODE()

2019-01-20 Thread Noralf Trønnes
This adds a helper macro to specify modes that only contain info about resolution. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/hx8357d.c | 2 +- drivers/gpu/drm/tinydrm/ili9225.c | 2 +- drivers/gpu/drm/tinydrm/ili9341.c | 2 +- drivers/gpu/drm/tinydrm/mi0283qt.c | 2

[PATCH 01/11] drm: Add devm_drm_dev_init/register

2019-01-20 Thread Noralf Trønnes
This adds resource managed (devres) versions of drm_dev_init() and drm_dev_register(). Also added is devm_drm_dev_register_with_fbdev() which sets up generic fbdev emulation as well. devm_drm_dev_register() isn't exported since there are no users. Signed-off-by: Noralf Trønnes

[PATCH 09/11] drm/tinydrm: Remove tinydrm_device

2019-01-20 Thread Noralf Trønnes
No more users left so it can go alongside its helpers. Update the tinydrm docs description and remove todo entry. Signed-off-by: Noralf Trønnes --- Documentation/gpu/tinydrm.rst | 26 +-- Documentation/gpu/todo.rst| 4 - drivers/gpu/drm/tinydrm/core

[PATCH 00/11] drm/tinydrm: Remove tinydrm_device

2019-01-20 Thread Noralf Trønnes
and bound fbcon. Noralf. Noralf Trønnes (11): drm: Add devm_drm_dev_init/register drm/modes: Add DRM_SIMPLE_MODE() drm/simple-kms-helper: Add drm_simple_connector_create() drm/tinydrm: Remove tinydrm_display_pipe_init() drm/tinydrm/mipi-dbi: Add drm_to_mipi_dbi() drm/tinydrm: Remove

[PATCH 03/11] drm/simple-kms-helper: Add drm_simple_connector_create()

2019-01-20 Thread Noralf Trønnes
This adds a function that creates a simple connector that has only one static mode. Additionally add a helper to set _mode_config width and height from the static mode. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_simple_kms_helper.c | 122 include/drm

Re: [PATCH v3 0/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-17 Thread Noralf Trønnes
Den 15.01.2019 05.36, skrev Noralf Trønnes: > David discovered a bug which gave memory corruption because the tx_buf > was written past its end for st7586 which has a smaller tx_buf. The > problem was that mipi_dbi_enable_flush() now calls directly into > mipi_dbi_fb_dirty() instead

Re: [PATCH v3] drm/cma-helper: Remove unused fbdev code

2019-01-17 Thread Noralf Trønnes
Den 14.01.2019 13.10, skrev Noralf Trønnes: > CMA helper drivers have been converted to drm_fbdev_generic_setup() > so the fbdev code can be removed. > > v3: Remove CMA specific conditional in the generic fbdev client > > v2: Clean up the includes some more (Laurent) > &

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-14 Thread Noralf Trønnes
Den 15.01.2019 05.38, skrev Noralf Trønnes: > > > Den 15.01.2019 00.26, skrev David Lechner: >> On 1/14/19 4:53 PM, Noralf Trønnes wrote: >>> >>> >>> Den 14.01.2019 23.33, skrev David Lechner: >>>> On 1/14/19 3:50 PM, David Lechner

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-14 Thread Noralf Trønnes
Den 15.01.2019 00.26, skrev David Lechner: > On 1/14/19 4:53 PM, Noralf Trønnes wrote: >> >> >> Den 14.01.2019 23.33, skrev David Lechner: >>> On 1/14/19 3:50 PM, David Lechner wrote: >>>> On 1/14/19 10:13 AM, Noralf Trønnes wrote: >&

[PATCH v3 0/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-14 Thread Noralf Trønnes
: - Include vblank header (Sam) - ili9225 and st7586 can't use mipi_dbi_enable_flush() (David) Noralf. Noralf Trønnes (5): drm/gem-fb-helper: Add drm_gem_fb_create_with_dirty() drm/damage-helper: Add drm_atomic_helper_damage_merged() drm/tinydrm: Use struct drm_rect drm/tinydrm: Use damage helper

[PATCH v3 1/5] drm/gem-fb-helper: Add drm_gem_fb_create_with_dirty()

2019-01-14 Thread Noralf Trønnes
This adds a .fb_create helper that sets the .dirty callback to drm_atomic_helper_dirtyfb(). v2: Improve docs (Daniel) Signed-off-by: Noralf Trønnes Acked-by: Daniel Vetter Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/drm_gem_framebuffer_helper.c | 50 +--- include/drm

[PATCH v3 2/5] drm/damage-helper: Add drm_atomic_helper_damage_merged()

2019-01-14 Thread Noralf Trønnes
Useful for drivers that only care about the combined damage. v2: Remove unnecessary clearing of damage clips Cc: Deepak Rawat Signed-off-by: Noralf Trønnes Acked-by: Daniel Vetter Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/drm_damage_helper.c | 41 + include

[PATCH v3 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-14 Thread Noralf Trønnes
it. v3: Include vblank header (Sam) ili9225 and st7586 can't use mipi_dbi_enable_flush() (David) v2: Remove fb check in mipi_dbi_enable_flush() it can't be NULL (kbuild test robot) Cc: David Lechner Cc: Eric Anholt Signed-off-by: Noralf Trønnes Acked-by: Daniel Vetter Reviewed

[PATCH v3 5/5] drm/todo: Tick off some tinydrm entries

2019-01-14 Thread Noralf Trønnes
by drm_gem_fb_create_with_dirty() Cc: Sam Ravnborg Signed-off-by: Noralf Trønnes Reviewed-by: Sam Ravnborg --- Documentation/gpu/todo.rst | 35 --- 1 file changed, 35 deletions(-) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index

[PATCH v3 3/5] drm/tinydrm: Use struct drm_rect

2019-01-14 Thread Noralf Trønnes
-by: Noralf Trønnes Acked-by: Daniel Vetter Reviewed-by: Sam Ravnborg --- .../gpu/drm/tinydrm/core/tinydrm-helpers.c| 19 drivers/gpu/drm/tinydrm/ili9225.c | 43 ++- drivers/gpu/drm/tinydrm/mipi-dbi.c| 21 - drivers/gpu/drm/tinydrm

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-14 Thread Noralf Trønnes
Den 15.01.2019 00.03, skrev David Lechner: > On 1/14/19 4:43 PM, Noralf Trønnes wrote: >> >> >> Den 14.01.2019 23.33, skrev David Lechner: >>> On 1/14/19 3:50 PM, David Lechner wrote: >>>> On 1/14/19 10:13 AM, Noralf Trønnes wrote: >&

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-14 Thread Noralf Trønnes
Den 14.01.2019 23.33, skrev David Lechner: > On 1/14/19 3:50 PM, David Lechner wrote: >> On 1/14/19 10:13 AM, Noralf Trønnes wrote: >>> >>> I see that you have this call chain: >>> st7586_pipe_enable() -> mipi_dbi_enable_flush() -> mipi_dbi_fb_dirty().

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-14 Thread Noralf Trønnes
Den 14.01.2019 23.06, skrev David Lechner: > On 1/11/19 2:12 PM, Noralf Trønnes wrote: >> This switches to drm_atomic_helper_dirtyfb() as the framebuffer dirty >> handler. All flushing will now happen in the pipe functions. >> >> Also enable the damage plane property f

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-14 Thread Noralf Trønnes
Den 14.01.2019 23.33, skrev David Lechner: > On 1/14/19 3:50 PM, David Lechner wrote: >> On 1/14/19 10:13 AM, Noralf Trønnes wrote: >>> >>> I see that you have this call chain: >>> st7586_pipe_enable() -> mipi_dbi_enable_flush() -> mipi_dbi_fb_dirty().

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-14 Thread Noralf Trønnes
Den 14.01.2019 16.00, skrev Noralf Trønnes: > > > Den 14.01.2019 03.15, skrev David Lechner: >> On 1/13/19 3:19 PM, David Lechner wrote: >>> On 1/11/19 2:12 PM, Noralf Trønnes wrote: >>>> This switches to drm_atomic_helper_dirtyfb() as the framebuffer dirty

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-14 Thread Noralf Trønnes
Den 14.01.2019 03.15, skrev David Lechner: > On 1/13/19 3:19 PM, David Lechner wrote: >> On 1/11/19 2:12 PM, Noralf Trønnes wrote: >>> This switches to drm_atomic_helper_dirtyfb() as the framebuffer dirty >>> handler. All flushing will now happen in the pipe fun

[PATCH v3] drm/cma-helper: Remove unused fbdev code

2019-01-14 Thread Noralf Trønnes
CMA helper drivers have been converted to drm_fbdev_generic_setup() so the fbdev code can be removed. v3: Remove CMA specific conditional in the generic fbdev client v2: Clean up the includes some more (Laurent) Cc: Laurent Pinchart Signed-off-by: Noralf Trønnes Acked-by: Sam Ravnborg

Re: [PATCH v3 2/5] drm/mxsfb: Use drm_fbdev_generic_setup()

2019-01-14 Thread Noralf Trønnes
Den 28.11.2018 22.27, skrev Noralf Trønnes: > The CMA helper is already using the drm_fb_helper_generic_probe part of > the generic fbdev emulation. This patch makes full use of the generic > fbdev emulation by using its drm_client callbacks. This means that > drm_mode_

Re: [PATCH v3 1/5] drm/hisilicon/kirin: Use drm_fbdev_generic_setup()

2019-01-14 Thread Noralf Trønnes
Den 28.11.2018 22.27, skrev Noralf Trønnes: > The CMA helper is already using the drm_fb_helper_generic_probe part of > the generic fbdev emulation. This patch makes full use of the generic > fbdev emulation by using its drm_client callbacks. This means that > drm_mode_

Re: [PATCH V7 2/2] drm/panel: Add Sitronix ST7701 panel driver

2019-01-11 Thread Noralf Trønnes
Den 11.01.2019 22.19, skrev Sam Ravnborg: > Hi Jagan. > > Gave this another more detailed read - triggered some additional comments. > Depite the comments it looks good, and this is all more or > less cosmetic improvements. > > Sam > >> +struct st7701_panel_desc { >> +const struct

[PATCH v2 0/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-11 Thread Noralf Trønnes
in drm-misc-next. Noralf. Noralf Trønnes (5): drm/gem-fb-helper: Add drm_gem_fb_create_with_dirty() drm/damage-helper: Add drm_atomic_helper_damage_merged() drm/tinydrm: Use struct drm_rect drm/tinydrm: Use damage helper for dirtyfb drm/todo: Tick off some tinydrm entries Documentation/gpu

[PATCH v2 2/5] drm/damage-helper: Add drm_atomic_helper_damage_merged()

2019-01-11 Thread Noralf Trønnes
Useful for drivers that only care about the combined damage. v2: Remove unnecessary clearing of damage clips Cc: Deepak Rawat Signed-off-by: Noralf Trønnes Acked-by: Sam Ravnborg Acked-by: Daniel Vetter --- drivers/gpu/drm/drm_damage_helper.c | 41 + include/drm

[PATCH v2 3/5] drm/tinydrm: Use struct drm_rect

2019-01-11 Thread Noralf Trønnes
-by: Noralf Trønnes Acked-by: Sam Ravnborg Acked-by: Daniel Vetter --- .../gpu/drm/tinydrm/core/tinydrm-helpers.c| 19 drivers/gpu/drm/tinydrm/ili9225.c | 43 ++- drivers/gpu/drm/tinydrm/mipi-dbi.c| 21 - drivers/gpu/drm/tinydrm/repaper.c

[PATCH v2 1/5] drm/gem-fb-helper: Add drm_gem_fb_create_with_dirty()

2019-01-11 Thread Noralf Trønnes
This adds a .fb_create helper that sets the .dirty callback to drm_atomic_helper_dirtyfb(). v2: Improve docs (Daniel) Signed-off-by: Noralf Trønnes Acked-by: Sam Ravnborg Acked-by: Daniel Vetter --- drivers/gpu/drm/drm_gem_framebuffer_helper.c | 50 +--- include/drm

[PATCH v2 5/5] drm/todo: Tick off some tinydrm entries

2019-01-11 Thread Noralf Trønnes
by drm_gem_fb_create_with_dirty() Cc: Sam Ravnborg Signed-off-by: Noralf Trønnes --- Documentation/gpu/todo.rst | 35 --- 1 file changed, 35 deletions(-) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 0a85dad876ae..38360ede1221 100644

[PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-11 Thread Noralf Trønnes
it. v2: Remove fb check in mipi_dbi_enable_flush() it can't be NULL (kbuild test robot) Cc: David Lechner Cc: Eric Anholt Signed-off-by: Noralf Trønnes Acked-by: Sam Ravnborg Acked-by: Daniel Vetter --- drivers/gpu/drm/tinydrm/core/tinydrm-core.c | 21 +--- .../gpu/drm/tinydrm/core

Re: [PATCH v8] drm/panel: Add a driver for the TPO TPG110

2019-01-11 Thread Noralf Trønnes
ch will be > decomissioned once this us upstream. > > Cc: Noralf Trønnes > Acked-by: Sam Ravnborg > Signed-off-by: Linus Walleij > --- Seems like it could make sense to add a devm_drm_panel_add(), but maybe for another day. Acked-by: Noralf Trønnes

Re: [PATCH 4/4] drm/tinydrm: Use damage helper for dirtyfb

2019-01-11 Thread Noralf Trønnes
Den 11.01.2019 02.06, skrev David Lechner: > On 1/9/19 11:49 AM, Noralf Trønnes wrote: >> This switches to drm_atomic_helper_dirtyfb() as the framebuffer dirty >> handler. All flushing will now happen in the pipe functions. >> >> Also enable the damage plane property f

Re: [PATCH] drm/mediatek: Add MTK Framebuffer-Device (mt7623)

2019-01-11 Thread Noralf Trønnes
Den 11.01.2019 11.25, skrev Daniel Vetter: > On Fri, Jan 11, 2019 at 05:49:15PM +0800, CK Hu wrote: >> Hi, Daniel: >> >> On Fri, 2019-01-11 at 10:20 +0100, Daniel Vetter wrote: >>> On Fri, Jan 11, 2019 at 11:20:09AM +0800, CK Hu wrote: Hi, Daniel: On Thu, 2019-01-10 at 21:02

Re: [PATCH 6/7] drm/tda998x: Don't set dpms hook

2019-01-11 Thread Noralf Trønnes
} > > static const struct drm_connector_funcs tda998x_connector_funcs = { > - .dpms = drm_helper_connector_dpms, > .reset = drm_atomic_helper_connector_reset, > .fill_modes = drm_helper_probe_single_connector_modes, >

Re: [PATCH 5/7] drm/arc: Don't set the dpms hook

2019-01-11 Thread Noralf Trønnes
_funcs arcpgu_drm_connector_funcs = { > - .dpms = drm_helper_connector_dpms, > .reset = drm_atomic_helper_connector_reset, > .fill_modes = drm_helper_probe_single_connector_modes, > .destroy = arcpgu_drm_connector_destroy, > Acked-by: Noralf Trønnes __

Re: [PATCH v7] drm/panel: Add a driver for the TPO TPG110

2019-01-10 Thread Noralf Trønnes
Den 10.01.2019 20.30, skrev Linus Walleij: > The TPO (Toppoly) TPG110 is a pretty generic display driver > similar in vein to the Ilitek 93xx devices. It is not a panel > per se but a driver used with several low-cost noname panels. > > This is used on the Nomadik NHK15 combined with a OSD >

Re: [PATCH 2/4] drm/damage-helper: Add drm_atomic_helper_damage_merged()

2019-01-10 Thread Noralf Trønnes
Den 09.01.2019 18.49, skrev Noralf Trønnes: > Useful for drivers that only care about the combined damage. > > Cc: Deepak Rawat > Signed-off-by: Noralf Trønnes > --- > drivers/gpu/drm/drm_damage_helper.c | 43 + > include/drm/drm_damage_help

Re: [PATCH v3 14/15] drm/bochs: drop old fbdev emulation code

2019-01-10 Thread Noralf Trønnes
Den 10.01.2019 11.16, skrev Gerd Hoffmann: > Hi, > >>> - drm_fb_helper_set_suspend_unlocked(>fb.helper, 1); >> >> The generic fbdev emulation doesn't take care of suspend/resume. You >> could do this: >> drm_fb_helper_set_suspend_unlocked(drm_dev->fb_helper, 1); > > Additional to

Re: [PATCH v3 14/15] drm/bochs: drop old fbdev emulation code

2019-01-10 Thread Noralf Trønnes
Den 10.01.2019 09.28, skrev Gerd Hoffmann: > Not needed any more, bochs uses the generic emulation now. > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Oleksandr Andrushchenko > Acked-by: Daniel Vetter > --- > drivers/gpu/drm/bochs/bochs.h | 9 --- >

Re: [PATCH 0/4] drm/tinydrm: Use damage helper for dirtyfb

2019-01-09 Thread Noralf Trønnes
Den 09.01.2019 19.26, skrev Sam Ravnborg: > Hi Noralf. > >> >> I was really pleased to see that the damage helper had landed. Now I can >> do framebuffer flushing solely through the display pipe functions. This >> prepares the ground for the removal of struct tinydrm_device in my next >>

[PATCH 1/4] drm/gem-fb-helper: Add drm_gem_fb_create_with_dirty()

2019-01-09 Thread Noralf Trønnes
This adds a .fb_create helper that sets the .dirty callback to drm_atomic_helper_dirtyfb(). Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_gem_framebuffer_helper.c | 47 +--- include/drm/drm_gem_framebuffer_helper.h | 3 ++ 2 files changed, 44 insertions(+), 6

[PATCH 2/4] drm/damage-helper: Add drm_atomic_helper_damage_merged()

2019-01-09 Thread Noralf Trønnes
Useful for drivers that only care about the combined damage. Cc: Deepak Rawat Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_damage_helper.c | 43 + include/drm/drm_damage_helper.h | 3 ++ 2 files changed, 46 insertions(+) diff --git a/drivers/gpu/drm

[PATCH 3/4] drm/tinydrm: Use struct drm_rect

2019-01-09 Thread Noralf Trønnes
-by: Noralf Trønnes --- .../gpu/drm/tinydrm/core/tinydrm-helpers.c| 19 drivers/gpu/drm/tinydrm/ili9225.c | 43 ++- drivers/gpu/drm/tinydrm/mipi-dbi.c| 21 - drivers/gpu/drm/tinydrm/repaper.c | 3 +- drivers/gpu/drm/tinydrm

[PATCH 4/4] drm/tinydrm: Use damage helper for dirtyfb

2019-01-09 Thread Noralf Trønnes
it. Cc: David Lechner Cc: Eric Anholt Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/core/tinydrm-core.c | 21 +--- .../gpu/drm/tinydrm/core/tinydrm-helpers.c| 91 +--- drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c | 30 -- drivers/gpu/drm/tinydrm/hx8357d.c

[PATCH 0/4] drm/tinydrm: Use damage helper for dirtyfb

2019-01-09 Thread Noralf Trønnes
when -rc1 arrives there. Noralf. Noralf Trønnes (4): drm/gem-fb-helper: Add drm_gem_fb_create_with_dirty() drm/damage-helper: Add drm_atomic_helper_damage_merged() drm/tinydrm: Use struct drm_rect drm/tinydrm: Use damage helper for dirtyfb drivers/gpu/drm/drm_damage_helper.c

Re: [PATCH] drm/fb-helper: fix leaks in error path of drm_fb_helper_fbdev_setup

2019-01-08 Thread Noralf Trønnes
Den 05.01.2019 19.25, skrev Noralf Trønnes: > > > Den 24.12.2018 16.03, skrev Peter Wu: >> On Mon, Dec 24, 2018 at 03:52:55PM +0100, Noralf Trønnes wrote: >>> >>> >>> Den 24.12.2018 00.10, skrev Peter Wu: >>>> On Sun,

Re: [PATCH] drm/fb-helper: generic: Fix setup error path

2019-01-08 Thread Noralf Trønnes
le the error path. >> >> Error cleanup is removed from .fb_probe and is handled by one function for >> all paths. >> >> Fixes: 9060d7f49376 ("drm/fb-helper: Finish the generic fbdev emulation") >> Reported-by: Peter Wu >> Signed-off-by: Noral

Re: [PATCH] drm/todo: Better defio support in the generic fbdev emulation

2019-01-07 Thread Noralf Trønnes
Den 07.01.2019 11.22, skrev Daniel Vetter: > The current one essentially means you need CMA or a vmalloc backed > object, which makes fbdev emulation a special case. > > Since implementing this will be quite a bit of work, capture the idea > in a TODO. > > Cc: Noralf

Re: [PATCH v2 13/14] drm/tinydrm: do not reply on drmP.h from drm_gem_cma_helper.h

2019-01-07 Thread Noralf Trønnes
in include/drm/ > > To prepare tinydrm/ for this add dependencies that > othwewise was pulled in by drmP.h from drm_gem_cma_helper.h > > To avoid that tinydrm.h became "include everything", > push include files to the individual drivers. > > Signed-off-by: Sam Ravnborg

Re: [PATCH v2 14/14] drm: remove drmP.h from drm_gem_cma_helper.h

2019-01-07 Thread Noralf Trønnes
> Cc: Maxime Ripard > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter > --- Acked-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 12/14] drm/stm: do not reply on drmP.h from drm_gem_cma_helper.h

2019-01-07 Thread Noralf Trønnes
n Gaignard > Cc: Vincent Abriou > Cc: David Airlie > Cc: Daniel Vetter > --- Acked-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 11/14] drm/arc: do not reply on drmP.h from drm_gem_cma_helper.h

2019-01-07 Thread Noralf Trønnes
in include/drm/ > > To prepare arc/ for this add dependencies that > othwewise was pulled in by drmP.h from drm_gem_cma_helper.h > > Signed-off-by: Sam Ravnborg > Cc: Alexey Brodkin > Cc: Daniel Vetter > Cc: David Airlie > --- Acked-by: Noralf Trønnes ___

Re: [PATCH v2 09/14] drm: remove include of drmP.h from drm_encoder_slave.h

2019-01-07 Thread Noralf Trønnes
Den 30.12.2018 18.48, skrev Sam Ravnborg: > No further changes required. > > Signed-off-by: Sam Ravnborg > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter > --- Acked-by: Noralf Trønnes

Re: [PATCH v2 05/14] drm: make drm_file.h self contained

2019-01-07 Thread Noralf Trønnes
pler to remove drmP.h includes > > Signed-off-by: Sam Ravnborg > Cc: Jani Nikula > Cc: Daniel Vetter > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Sean Paul > Cc: David Airlie > --- Acked-by: Noralf Trønnes ___ dri-de

Re: [PATCH v2 04/14] drm: make drm_framebuffer.h self contained

2019-01-07 Thread Noralf Trønnes
uct drm_framebuffer; > struct drm_file; > struct drm_device; > +struct drm_clip_rect; I think you can add drm_gem_object to this list. > > /** > * struct drm_framebuffer_funcs - framebuffer hooks > Acked-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/fb-helper: fix leaks in error path of drm_fb_helper_fbdev_setup

2019-01-05 Thread Noralf Trønnes
Den 24.12.2018 16.03, skrev Peter Wu: On Mon, Dec 24, 2018 at 03:52:55PM +0100, Noralf Trønnes wrote: Den 24.12.2018 00.10, skrev Peter Wu: On Sun, Dec 23, 2018 at 02:55:52PM +0100, Noralf Trønnes wrote: Den 23.12.2018 01.55, skrev Peter Wu: After drm_fb_helper_fbdev_setup calls

[PATCH] drm/fb-helper: generic: Fix setup error path

2019-01-05 Thread Noralf Trønnes
t;drm/fb-helper: Finish the generic fbdev emulation") Reported-by: Peter Wu Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c | 98 +++-- 1 file changed, 58 insertions(+), 40 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drive

Re: [PATCH 5/9] drm/fb-helper: Add generic fbdev emulation .fb_probe function

2019-01-03 Thread Noralf Trønnes
Den 28.12.2018 21.38, skrev Daniel Vetter: On Tue, May 29, 2018 at 9:54 AM Daniel Vetter wrote: On Fri, May 25, 2018 at 02:42:02PM +0200, Noralf Trønnes wrote: Den 24.05.2018 11.16, skrev Daniel Vetter: On Wed, May 23, 2018 at 04:34:07PM +0200, Noralf Trønnes wrote: This is the first

Re: [PATCH] drm/fb-helper: fix leaks in error path of drm_fb_helper_fbdev_setup

2018-12-24 Thread Noralf Trønnes
Den 24.12.2018 00.10, skrev Peter Wu: On Sun, Dec 23, 2018 at 02:55:52PM +0100, Noralf Trønnes wrote: Den 23.12.2018 01.55, skrev Peter Wu: After drm_fb_helper_fbdev_setup calls drm_fb_helper_init, "dev->fb_helper" will be initialized (and thus drm_fb_helper_fini will hav

Re: [PATCH] drm/fb-helper: fix leaks in error path of drm_fb_helper_fbdev_setup

2018-12-23 Thread Noralf Trønnes
etup/teardown()") Reported-by: kernel test robot Cc: Noralf Trønnes Signed-off-by: Peter Wu --- drivers/gpu/drm/drm_fb_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 9d64f874f965..432e

Re: [PATCH] drm/xen-front: Make shmem backed display buffer coherent

2018-12-19 Thread Noralf Trønnes
Den 19.12.2018 09.18, skrev Oleksandr Andrushchenko: On 12/18/18 9:20 PM, Noralf Trønnes wrote: Den 27.11.2018 11.32, skrev Oleksandr Andrushchenko: From: Oleksandr Andrushchenko When GEM backing storage is allocated with drm_gem_get_pages the backing pages may be cached, thus making

Re: [PATCH] drm/xen-front: Make shmem backed display buffer coherent

2018-12-18 Thread Noralf Trønnes
Den 27.11.2018 11.32, skrev Oleksandr Andrushchenko: From: Oleksandr Andrushchenko When GEM backing storage is allocated with drm_gem_get_pages the backing pages may be cached, thus making it possible that the backend sees only partial content of the buffer which may lead to screen artifacts.

Re: [Xen-devel][PATCH v2 2/3] drm/xen-front: Use Xen common shared buffer implementation

2018-12-18 Thread Noralf Trønnes
-by: Oleksandr Andrushchenko --- Reviewed-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] fbdev: fbcon: Fix unregister crash when more than one framebuffer

2018-12-12 Thread Noralf Trønnes
Den 12.12.2018 12.05, skrev Daniel Vetter: On Mon, Dec 10, 2018 at 08:02:55PM +0100, Noralf Trønnes wrote: When unregistering fbdev using unregister_framebuffer(), any bound console will unbind automatically. This is working fine if this is the only framebuffer, resulting in a switch

[PATCH] fbdev: fbcon: Fix unregister crash when more than one framebuffer

2018-12-10 Thread Noralf Trønnes
index. Fixes: cfafca8067c6 ("fbdev: fbcon: console unregistration from unregister_framebuffer") Signed-off-by: Noralf Trønnes Reviewed-by: Mikulas Patocka --- Mikulas, If you have forgotten about this, here's where you gave your r-b: https://lists.freedesktop.org/archives/dri-devel

Re: [PATCH -next] drm/tinydrm: Use kmemdup rather than duplicating its implementation in repaper_spi_transfer()

2018-12-04 Thread Noralf Trønnes
Den 29.11.2018 07.00, skrev YueHaibing: use kmemdup rather than duplicating its implementation Signed-off-by: YueHaibing --- Thanks, applied to drm-misc-next. Noralf. drivers/gpu/drm/tinydrm/repaper.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [Intel-gfx] [PATCH v5 4/5] drm: Add library for shmem backed GEM objects

2018-12-02 Thread Noralf Trønnes
wrote: Noralf Trønnes writes: +static void drm_gem_shmem_vm_close(struct vm_area_struct *vma) +{ + struct drm_gem_object *obj = vma->vm_private_data; + struct drm_gem_shmem_object *shmem = to_drm_gem_shmem_obj(obj); + + drm_gem_shmem_put_pages(shmem); + drm_gem_vm_close(

Re: [PATCH v3 3/5] drm/rcar-du: Use drm_fbdev_generic_setup()

2018-11-29 Thread Noralf Trønnes
Den 28.11.2018 22.27, skrev Noralf Trønnes: The CMA helper is already using the drm_fb_helper_generic_probe part of the generic fbdev emulation. This patch makes full use of the generic fbdev emulation by using its drm_client callbacks. This means that drm_mode_config_funcs->output_poll_chan

Re: [PATCH v3 4/5] drm/framebuffer: Include linux/sched.h in header file

2018-11-29 Thread Noralf Trønnes
Den 29.11.2018 10.35, skrev Daniel Vetter: On Wed, Nov 28, 2018 at 10:27:12PM +0100, Noralf Trønnes wrote: A cleanup of the includes in drm_fb_cma_helper resulted in: CC [M] drivers/gpu/drm/drm_fb_cma_helper.o In file included from drivers/gpu/drm/drm_fb_cma_helper.c:21:0: include/drm

[PATCH v3 3/5] drm/rcar-du: Use drm_fbdev_generic_setup()

2018-11-28 Thread Noralf Trønnes
driver, it is not part of the driver as such. If fbdev setup fails, an error is printed, but the driver succeeds probing. drm_fbdev_generic_setup() handles mode_config.num_connector being zero. In that case it retries fbdev setup on the next .output_poll_changed. Cc: Laurent Pinchart Signed-off-by: Noralf T

[PATCH v3 0/5] drm/cma-helper drivers: Use drm_fbdev_generic_setup()

2018-11-28 Thread Noralf Trønnes
Pinchart Noralf Trønnes (5): drm/hisilicon/kirin: Use drm_fbdev_generic_setup() drm/mxsfb: Use drm_fbdev_generic_setup() drm/rcar-du: Use drm_fbdev_generic_setup() drm/framebuffer: Include linux/sched.h in header file drm/cma-helper: Remove unused fbdev code drivers/gpu/drm/Kconfig

[PATCH v3 4/5] drm/framebuffer: Include linux/sched.h in header file

2018-11-28 Thread Noralf Trønnes
]; Fix it by including linux/sched.h. Signed-off-by: Noralf Trønnes --- include/drm/drm_framebuffer.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/drm_framebuffer.h b/include/drm/drm_framebuffer.h index c94acedfb08e..d4ce58568fa6 100644 --- a/include/drm/drm_framebuffer.h +++ b

[PATCH v3 2/5] drm/mxsfb: Use drm_fbdev_generic_setup()

2018-11-28 Thread Noralf Trønnes
driver, it is not part of the driver as such. If fbdev setup fails, an error is printed, but the driver succeeds probing. Cc: Marek Vasut Signed-off-by: Noralf Trønnes Acked-by: Sam Ravnborg --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 26 ++ drivers/gpu/drm/mxsfb/mxsfb_drv.h | 1 - 2

[PATCH v3 5/5] drm/cma-helper: Remove unused fbdev code

2018-11-28 Thread Noralf Trønnes
CMA helper drivers have been converted to drm_fbdev_generic_setup() so the fbdev code can be removed. v2: Clean up the includes some more (Laurent) Cc: Laurent Pinchart Signed-off-by: Noralf Trønnes Acked-by: Sam Ravnborg Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/Kconfig

[PATCH v3 1/5] drm/hisilicon/kirin: Use drm_fbdev_generic_setup()

2018-11-28 Thread Noralf Trønnes
driver, it is not part of the driver as such. If fbdev setup fails, an error is printed, but the driver succeeds probing. struct kirin_drm_private can be removed now that driver doesn't have to store the fbdev pointer. Cc: Xinliang Liu Cc: Rongrong Zou Cc: Xinwei Kong Cc: Chen Feng Signed-off-by: Noralf T

Re: [PATCH v2 5/9] drm/rcar-du: Use drm_fbdev_generic_setup()

2018-11-28 Thread Noralf Trønnes
Den 25.10.2018 22.13, skrev Noralf Trønnes: The CMA helper is already using the drm_fb_helper_generic_probe part of the generic fbdev emulation. This patch makes full use of the generic fbdev emulation by using its drm_client callbacks. This means that drm_mode_config_funcs->output_poll_chan

Re: [PATCH v2] drm/fb-helper/generic: Only restore when in use

2018-11-27 Thread Noralf Trønnes
Den 26.11.2018 21.07, skrev Daniel Vetter: On Mon, Nov 26, 2018 at 04:38:48PM +0100, Noralf Trønnes wrote: On drm_driver->last_close the generic fbdev emulation will restore fbdev regardless of it being used or not. This is a problem for e-ink displays which don't want to be overwrit

[PATCH v2] drm/fb-helper/generic: Only restore when in use

2018-11-26 Thread Noralf Trønnes
hen to restore. v1: Avoid special-casing and move the check to drm_fbdev_client_restore() (Daniel Vetter) Signed-off-by: Noralf Trønnes --- I was tied up in my previous attempt to solve this which predated the generic emulation, so I failed to see that I could solve this within the sc

Re: [PATCH] drm/prime: Fix drm_gem_prime_mmap() stack use

2018-11-22 Thread Noralf Trønnes
Den 22.11.2018 10.06, skrev Daniel Vetter: On Wed, Nov 21, 2018 at 07:02:15PM +0100, Noralf Trønnes wrote: drivers/gpu/drm/drm_prime.c: In function 'drm_gem_prime_mmap': drivers/gpu/drm/drm_prime.c:688:1: warning: the frame size of 1592 bytes is larger than 1024 bytes [-Wframe-larger

[PATCH] drm/prime: Fix drm_gem_prime_mmap() stack use

2018-11-21 Thread Noralf Trønnes
mmap()") Reported-by: kbuild test robot Cc: Daniel Vetter Cc: Christian König Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_prime.c | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu

[PATCH] drm/fb-helper/generic: Only restore when in use

2018-11-21 Thread Noralf Trønnes
pen() and drm_fbdev_fb_release() and use them. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c | 25 +++-- include/drm/drm_fb_helper.h | 14 ++ 2 files changed, 37 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/

Re: [PATCH v2 5/9] drm/rcar-du: Use drm_fbdev_generic_setup()

2018-11-20 Thread Noralf Trønnes
Laurent, Den 25.10.2018 22.13, skrev Noralf Trønnes: The CMA helper is already using the drm_fb_helper_generic_probe part of the generic fbdev emulation. This patch makes full use of the generic fbdev emulation by using its drm_client callbacks. This means that drm_mode_config_funcs

Re: [PATCH 0/5] drm/gem: Add drm_gem_object_funcs

2018-11-20 Thread Noralf Trønnes
Den 10.11.2018 15.56, skrev Noralf Trønnes: This patchset adds a GEM object function table and makes use of it in the CMA helper. This was originally part of a shmem helper series[1] that didn't make it. Daniel and Christian showed interest in the vtable part so I have hooked it up to some

[PATCH 0/5] drm/gem: Add drm_gem_object_funcs

2018-11-10 Thread Noralf Trønnes
. The tinydrm refactoring is part of a long term plan to get rid of tinydrm.ko. Noralf. [1] https://patchwork.freedesktop.org/series/27184/ Noralf Trønnes (5): drm/driver: Add defaults for .gem_prime_export/import callbacks drm/prime: Add drm_gem_prime_mmap() drm/gem: Add drm_gem_object_funcs

[PATCH 3/5] drm/gem: Add drm_gem_object_funcs

2018-11-10 Thread Noralf Trønnes
first choice highlighting the fact that this the new default way of doing it (Daniel Vetter) Signed-off-by: Noralf Trønnes Acked-by: Daniel Vetter --- Documentation/gpu/todo.rst | 6 ++ drivers/gpu/drm/drm_client.c | 12 ++-- drivers/gpu/drm/drm_gem.c| 109 ---

[PATCH 4/5] drm/cma-helper: Add DRM_GEM_CMA_VMAP_DRIVER_OPS

2018-11-10 Thread Noralf Trønnes
all in drm_gem_cma_free_object() safe. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_gem_cma_helper.c | 86 include/drm/drm_gem_cma_helper.h | 24 ++ 2 files changed, 110 insertions(+) diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/

[PATCH 2/5] drm/prime: Add drm_gem_prime_mmap()

2018-11-10 Thread Noralf Trønnes
Add a generic PRIME GEM mmap function. v2: Fix link in docs (Daniel Vetter) Suggested-by: Daniel Vetter Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_prime.c | 37 + include/drm/drm_prime.h | 1 + 2 files changed, 38

[PATCH 5/5] drm/tinydrm: Use DRM_GEM_CMA_VMAP_DRIVER_OPS

2018-11-10 Thread Noralf Trønnes
The CMA helper now has the functionality to ensure a virtual address on imported buffer so use that. While touching all tinydrm drivers, remove the unnecessary inclusion of drm_fb_helper.h in some drivers. Cc: David Lechner Cc: Eric Anholt Signed-off-by: Noralf Trønnes --- drivers/gpu/drm

[PATCH 1/5] drm/driver: Add defaults for .gem_prime_export/import callbacks

2018-11-10 Thread Noralf Trønnes
The majority of drivers use drm_gem_prime_export() and drm_gem_prime_import() for these callbacks so let's make them the default. Signed-off-by: Noralf Trønnes Acked-by: Daniel Vetter --- Documentation/gpu/todo.rst | 7 +++ drivers/gpu/drm/drm_prime.c | 10 -- include/drm

Re: [PATCH v2 8/9] drm/tilcdc: Use drm_fbdev_generic_setup()

2018-11-01 Thread Noralf Trønnes
Den 29.10.2018 16.55, skrev Jyri Sarha: On 25/10/18 23:13, Noralf Trønnes wrote: The CMA helper is already using the drm_fb_helper_generic_probe part of the generic fbdev emulation. This patch makes full use of the generic fbdev emulation by using its drm_client callbacks. This means

Re: [PATCH v2 7/9] drm/sun4i: Use drm_fbdev_generic_setup()

2018-11-01 Thread Noralf Trønnes
Den 26.10.2018 10.27, skrev Maxime Ripard: On Thu, Oct 25, 2018 at 10:13:38PM +0200, Noralf Trønnes wrote: The CMA helper is already using the drm_fb_helper_generic_probe part of the generic fbdev emulation. This patch makes full use of the generic fbdev emulation by using its drm_client

Re: [PATCH v2 6/9] drm/atmel-hlcdc: Use drm_fbdev_generic_setup()

2018-11-01 Thread Noralf Trønnes
Den 25.10.2018 22.25, skrev Boris Brezillon: On Thu, 25 Oct 2018 22:13:37 +0200 Noralf Trønnes wrote: The CMA helper is already using the drm_fb_helper_generic_probe part of the generic fbdev emulation. This patch makes full use of the generic fbdev emulation by using its drm_client

Re: [PATCH v2 2/9] drm/fsl-dcu: Use drm_fbdev_generic_setup()

2018-11-01 Thread Noralf Trønnes
Den 25.10.2018 22.13, skrev Noralf Trønnes: The CMA helper is already using the drm_fb_helper_generic_probe part of the generic fbdev emulation. This patch makes full use of the generic fbdev emulation by using its drm_client callbacks. This means that drm_mode_config_funcs->output_poll_chan

Re: [PATCH v2 1/9] drm/arc: Use drm_fbdev_generic_setup()

2018-11-01 Thread Noralf Trønnes
Den 25.10.2018 22.13, skrev Noralf Trønnes: The CMA helper is already using the drm_fb_helper_generic_probe part of the generic fbdev emulation. This patch makes full use of the generic fbdev emulation by using its drm_client callbacks. This means that drm_mode_config_funcs->output_poll_chan

Re: [PATCH v5 3/5] drm/gem: Add drm_gem_object_funcs

2018-10-31 Thread Noralf Trønnes
Den 17.10.2018 15.04, skrev Noralf Trønnes: This adds an optional function table on GEM objects. The main benefit is for drivers that support more than one type of memory (shmem,vram,cma) for their buffers depending on the hardware it runs on. With the callbacks attached to the GEM object

<    1   2   3   4   5   6   7   8   9   10   >