Re: [PATCH v2 2/2] drm/tinydrm: Make fb_dirty into a lower level hook

2018-03-23 Thread Noralf Trønnes
tinydrm_device directly for now. v2: Deal with the fb->dirty() in tinydrm_display_pipe_update() as weel (Noralf) Cc: "Noralf Trønnes" <nor...@tronnes.org> Cc: David Lechner <da...@lechnology.com> Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com> R

Re: [PATCH 2/2] drm/tinydrm: Make fb_dirty into a lower level hook

2018-03-23 Thread Noralf Trønnes
Den 23.03.2018 12.31, skrev Ville Syrjälä: On Fri, Mar 23, 2018 at 12:43:58AM +0100, Noralf Trønnes wrote: Den 22.03.2018 21.27, skrev Ville Syrjala: From: Ville Syrjälä <ville.syrj...@linux.intel.com> mipi_dbi_enable_flush() wants to call the fb->dirty() hook from t

Re: [PATCH 2/2] drm/tinydrm: Make fb_dirty into a lower level hook

2018-03-22 Thread Noralf Trønnes
->fb/crtc usage for atomic drivers' thread. If we do need a hook, I prefer that we add it to drm_simple_display_pipe_funcs. Noralf. Cc: "Noralf Trønnes" <nor...@tronnes.org> Cc: David Lechner <da...@lechnology.com> Signed-off-by: Ville Syrjälä <ville.syrj...@linux.in

Re: [PATCH 00/23] drm: Eliminate plane->fb/crtc usage for atomic drivers

2018-03-22 Thread Noralf Trønnes
Den 22.03.2018 19.49, skrev Ville Syrjälä: On Thu, Mar 22, 2018 at 05:51:35PM +0100, Noralf Trønnes wrote: tinydrm is also using plane->fb: $ grep -r "plane\.fb" drivers/gpu/drm/tinydrm/ drivers/gpu/drm/tinydrm/repaper.c:  if (tdev->pipe.plane.fb != fb) drivers/gpu/drm/ti

Re: [PATCH 00/23] drm: Eliminate plane->fb/crtc usage for atomic drivers

2018-03-22 Thread Noralf Trønnes
Den 22.03.2018 16.22, skrev Ville Syrjala: From: Ville Syrjälä I really just wanted to fix i915 to re-enable its planes afer load detection (a two line patch). This is what I actually ended up with after I ran into a framebuffer refcount leak with said two line

Re: [PATCH 1/6] drm/tinydrm: Use gem_free_object_unlocked

2018-03-22 Thread Noralf Trønnes
Den 22.03.2018 11.51, skrev Daniel Vetter: tinydrm doesn't use dev->struct_mutex and therefore has no need to use gem_free_object. Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> Cc: "Noralf Trønnes" <nor...@tronnes.org> --- Acked-by: Noralf Trønnes <nor

Re: [PATCH v2 00/11] drm/tinydrm: Support device unplug

2018-03-17 Thread Noralf Trønnes
Den 16.03.2018 09.03, skrev Daniel Vetter: On Fri, Sep 8, 2017 at 6:33 PM, Daniel Vetter<dan...@ffwll.ch> wrote: Hi Noralf, On Fri, Sep 08, 2017 at 05:07:19PM +0200, Noralf Trønnes wrote: This adds device unplug support to drm_fb_helper, drm_fb_cma_helper (fbdev) and t

Re: [RFC v3 09/12] drm: Add API for in-kernel clients

2018-03-12 Thread Noralf Trønnes
Den 12.03.2018 17.51, skrev Daniel Vetter: On Thu, Mar 08, 2018 at 06:12:11PM +0100, Noralf Tr??nnes wrote: Den 06.03.2018 09.56, skrev Daniel Vetter: On Thu, Feb 22, 2018 at 09:06:50PM +0100, Noralf Tr??nnes wrote: This adds an API for writing in-kernel clients. TODO: - Flesh out and

Re: [PATCH v2 2/2] drm/tinydrm: Remove chunk splitting in tinydrm_spi_transfer

2018-03-11 Thread Noralf Trønnes
Den 10.03.2018 16.52, skrev Meghana Madhyastha: Remove chunk splitting in tinydrm_spi_transfer in tinydrm-helpers as the spi core will split a buffer into max_dma_len chunks for the spi controller driver to handle, automatic byte swapping in tinydrm_spi_transfer as it doesn't have users.

Re: [PATCH v2 1/2] spi: Split spi message into chunks of <65535 in the spi subsystem

2018-03-11 Thread Noralf Trønnes
Den 10.03.2018 16.51, skrev Meghana Madhyastha: Split spi messages into chunks of <65535 in the spi subsystem and remove the message length warning in bcm2835_spi_can_dma. This is so that the messages can be transferred via dma and that the tinydrm drivers need not split it. Signed-off-by:

Re: [RFC v3 09/12] drm: Add API for in-kernel clients

2018-03-08 Thread Noralf Trønnes
Den 06.03.2018 09.56, skrev Daniel Vetter: On Thu, Feb 22, 2018 at 09:06:50PM +0100, Noralf Trønnes wrote: This adds an API for writing in-kernel clients. TODO: - Flesh out and complete documentation. - Cloned displays is not tested. - Complete tiled display support and test it. - Test plug

Re:

2018-03-05 Thread Noralf Trønnes
Den 05.03.2018 18.06, skrev Meghana Madhyastha: linux-...@vger.kernel.org,Noralf Trønnes <nor...@tronnes.org>,Sean Paul <seanp...@chromium.org>,ker...@martin.sperl.org Cc: Bcc: Subject: Re: [PATCH v2 0/2] Chunk splitting of spi transfers Reply-To: In-Reply-To: <f6dbf3ca

Re: [PATCH v2 0/2] Chunk splitting of spi transfers

2018-03-04 Thread Noralf Trønnes
Den 02.03.2018 12.11, skrev Meghana Madhyastha: On Sun, Feb 25, 2018 at 02:19:10PM +0100, Lukas Wunner wrote: [cc += linux-rpi-ker...@lists.infradead.org] On Sat, Feb 24, 2018 at 06:15:59PM +, Meghana Madhyastha wrote: I've added bcm2835_spi_transfer_one_message in spi-bcm2835. This

Re: [PATCH v2 0/2] Chunk splitting of spi transfers

2018-02-27 Thread Noralf Trønnes
Den 25.02.2018 14.19, skrev Lukas Wunner: [cc += linux-rpi-ker...@lists.infradead.org] On Sat, Feb 24, 2018 at 06:15:59PM +, Meghana Madhyastha wrote: I've added bcm2835_spi_transfer_one_message in spi-bcm2835. This calls spi_split_transfers_maxsize to split large chunks for spi dma

Re: [PATCH v2 1/2] drm/tinydrm: Remove chunk splitting in tinydrm_spi_transfer

2018-02-27 Thread Noralf Trønnes
Den 25.02.2018 18.03, skrev Lukas Wunner: On Sat, Feb 24, 2018 at 06:16:46PM +, Meghana Madhyastha wrote: -Remove chunk splitting in tinydrm_spi_transfer in tinydrm-helpers as The spi core will split a buffer into max_dma_len chunks for the spi controller driver to handle. -Remove

Re: [PATCH] drm/tinydrm: Allocate dummy SPI RX buffer if needed

2018-02-27 Thread Noralf Trønnes
these functions are re-used where possible (e.g. in mipi_dbi_init()). Cc: Noralf Trønnes <nor...@tronnes.org> Suggested-by: Noralf Trønnes <nor...@tronnes.org> Signed-off-by: David Lechner <da...@lechnology.com> --- This is a follow up from the mail thread "tinydrm: page allocation f

[RFC v3 11/12] drm/client: Add bootsplash client

2018-02-22 Thread Noralf Trønnes
Just a hack to test the client API. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/client/Kconfig | 5 + drivers/gpu/drm/client/Makefile | 1 + drivers/gpu/drm/client/drm_bootsplash.c | 205 3 files change

[RFC v3 10/12] drm/client: Add fbdev emulation client

2018-02-22 Thread Noralf Trønnes
lts in a NULL deref in fbcon_init(). fbcon/vt is awful when it comes to error handling. It doesn't look to be easily fixed, so I guess a buffer has to be pre-allocated to ensure health and safety. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/client/Kconfig

[RFC v3 12/12] drm/client: Add VT console client

2018-02-22 Thread Noralf Trønnes
Just a hack to test the client API. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/client/Kconfig | 5 + drivers/gpu/drm/client/Makefile| 1 + drivers/gpu/drm/client/drm_vtcon.c | 760 + 3 files changed, 766 inse

[RFC v3 00/12] drm: Add generic fbdev emulation

2018-02-22 Thread Noralf Trønnes
bot) ERROR: [drivers/gpu/drm/drm_kms_helper.ko] undefined! - Drop buggy patch: (Chris Wilson) drm/prime: Clear drm_gem_object->dma_buf on release - Defer buffer creation until fb_open. David Herrmann (1): drm: provide management functions for drm_file Noralf Trønnes (11): drm/file: Don

[RFC v3 05/12] drm: Add _ioctl suffix to some functions

2018-02-22 Thread Noralf Trønnes
Add _ioctl suffix to the remaining ioctl functions so they match up with the others: - drm_mode_addfb() - drm_mode_getfb() - drm_mode_getplane_res() - drm_mode_getplane() - drm_mode_setplane() Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/drm_crtc_internal.

[RFC v3 09/12] drm: Add API for in-kernel clients

2018-02-22 Thread Noralf Trønnes
a way to unbind individual client instances. - Maybe take the sysrq support in drm_fb_helper and move it here somehow. - Add suspend/resume callbacks. Does anyone know why fbdev requires suspend/resume? Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/K

[RFC v3 01/12] drm: provide management functions for drm_file

2018-02-22 Thread Noralf Trønnes
e fops implementations and APIs (not that I am aware of any such plans), and more importantly from in-kernel use where no real file is available. Signed-off-by: David Herrmann <dh.herrm...@gmail.com> Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Reviewed-by: Daniel Vetter <d

[RFC v3 08/12] drm/framebuffer: Add drm_mode_can_dirtyfb()

2018-02-22 Thread Noralf Trønnes
Add a function so the generic fbdev client can check if the framebuffer does flushing. This is needed to set up deferred I/O. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/drm_framebuffer.c | 31 +++ include/drm/drm_framebuffer.h

[RFC v3 06/12] drm: Add DRM device iterator

2018-02-22 Thread Noralf Trønnes
a separate drm_device list. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- Does anyone know how I can make checkpatch happy, I've tried parentheses around both dev and iter: -:129: ERROR: Macros with complex values should be enclosed in parentheses #129: FILE: include/drm/drm_drv.h:679: +#

[RFC v3 02/12] drm/file: Don't set master on in-kernel clients

2018-02-22 Thread Noralf Trønnes
It only makes sense for userspace clients. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/drm_file.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c index d4588d

[RFC v3 03/12] drm: Make ioctls available for in-kernel clients part 1

2018-02-22 Thread Noralf Trønnes
() - drm_mode_dirtyfb_ioctl() There is no functional change from the userspace side. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/drm_connector.c | 50 +++ drivers/gpu/drm/drm_crtc.c | 32 ++- drivers/gpu/drm/drm_crtc_internal.

[RFC v3 07/12] drm/modes: Add drm_umode_equal()

2018-02-22 Thread Noralf Trønnes
Add a way to check if userspace modes are equal. Useful for in-kernel clients. Also export drm_mode_convert_umode(). Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/drm_modes.c | 50 + include/drm/drm_modes.h | 2 ++ 2

[RFC v3 04/12] drm: Make ioctls available for in-kernel clients part 2

2018-02-22 Thread Noralf Trønnes
side. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/drm_crtc.c | 15 +++ drivers/gpu/drm/drm_crtc_internal.h | 37 +-- drivers/gpu/drm/drm_dumb_buffers.c | 33 drivers/gpu/drm/drm_encoder.c

Re: [PATCH] drm/pl111: Fix regression from fbdev CMA helper

2018-02-12 Thread Noralf Trønnes
Den 12.02.2018 16.53, skrev Linus Walleij: On Mon, Feb 12, 2018 at 3:01 PM, Noralf Trønnes <nor...@tronnes.org> wrote: Den 12.02.2018 14.42, skrev Noralf Trønnes: Den 12.02.2018 13.40, skrev Linus Walleij: drm_mode_config_reset(dev); -drm_fb_cma_fbdev_init(dev,

Re: [PATCH] drm/pl111: Fix regression from fbdev CMA helper

2018-02-12 Thread Noralf Trønnes
Den 12.02.2018 14.42, skrev Noralf Trønnes: Den 12.02.2018 13.40, skrev Linus Walleij: Commit d18df744de1a ("drm/pl111: Use drm_fb_cma_fbdev_init/fini()") refactored the driver to use fbdev handling in the core, but mistakedly limited the number of maximum connections to 0. Predict

Re: [PATCH] drm/pl111: Fix regression from fbdev CMA helper

2018-02-12 Thread Noralf Trønnes
gives zero framebuffers when using the system. So let's bump it to 1 so we get our framebuffer back. Cc: Noralf Trønnes <nor...@tronnes.org> Cc: Eric Anholt <e...@anholt.net> Fixes: d18df744de1a ("drm/pl111: Use drm_fb_cma_fbdev_init/fini()") Signed-off-by: Linus Walleij <linus.wa

Re: [PATCH] drm/fb-helper: Scale back depth to supported maximum

2018-02-01 Thread Noralf Trønnes
Den 01.02.2018 16.15, skrev Noralf Trønnes: Den 01.02.2018 14.19, skrev Ville Syrjälä: On Thu, Feb 01, 2018 at 02:04:46PM +0100, Linus Walleij wrote: The following happened when migrating an old fbdev driver to DRM: The Integrator/CP PL111 supports 16BPP but only ARGB1555/ABGR1555

Re: [PATCH] drm/fb-helper: Scale back depth to supported maximum

2018-02-01 Thread Noralf Trønnes
Den 01.02.2018 14.19, skrev Ville Syrjälä: On Thu, Feb 01, 2018 at 02:04:46PM +0100, Linus Walleij wrote: The following happened when migrating an old fbdev driver to DRM: The Integrator/CP PL111 supports 16BPP but only ARGB1555/ABGR1555 or XRGB1555/XBGR1555 i.e. the maximum depth is 15.

Re: [PATCH v19 10/10] drm/omapdrm: Use of_find_backlight helper

2018-01-24 Thread Noralf Trønnes
Den 24.01.2018 17.41, skrev Meghana Madhyastha: Replace of_find_backlight_by_node and of the code around it with of_find_backlight helper to avoid repetition of code. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Reviewed-by: Noralf Trønnes <nor...@tr

Re: [PATCH v18 10/10] drm/omapdrm: Use of_find_backlight helper

2018-01-23 Thread Noralf Trønnes
Den 23.01.2018 18.41, skrev Noralf Trønnes: Den 23.01.2018 17.55, skrev Meghana Madhyastha: On Tue, Jan 23, 2018 at 03:37:38PM +0100, Noralf Trønnes wrote: Den 22.01.2018 15.56, skrev Meghana Madhyastha: Replace of_find_backlight_by_node and of the code around it with of_find_backlight

Re: [PATCH v18 10/10] drm/omapdrm: Use of_find_backlight helper

2018-01-23 Thread Noralf Trønnes
Den 23.01.2018 17.55, skrev Meghana Madhyastha: On Tue, Jan 23, 2018 at 03:37:38PM +0100, Noralf Trønnes wrote: Den 22.01.2018 15.56, skrev Meghana Madhyastha: Replace of_find_backlight_by_node and of the code around it with of_find_backlight helper to avoid repetition of code. Signed-off

Re: [PATCH v18 01/10] video: backlight: Add helpers to enable and disable backlight

2018-01-23 Thread Noralf Trønnes
to avoid repetition of code and also to enforce a uniform and consistent way to enable/disable a backlight device. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Acked-by: Daniel Thompson <daniel.thomp...@linaro.org> Reviewed-by: Noralf Trønnes <nor...@tronnes.org>

Re: [PATCH v18 10/10] drm/omapdrm: Use of_find_backlight helper

2018-01-23 Thread Noralf Trønnes
Den 22.01.2018 15.56, skrev Meghana Madhyastha: Replace of_find_backlight_by_node and of the code around it with of_find_backlight helper to avoid repetition of code. Signed-off-by: Meghana Madhyastha --- Changes in v18: -Fixed warnings resulting from passing

Re: [PATCH v18 09/10] drm/panel: Use of_find_backlight helper

2018-01-23 Thread Noralf Trønnes
Den 22.01.2018 15.55, skrev Meghana Madhyastha: Replace of_find_backlight_by_node and of the code around it with of_find_backlight helper to avoid repetition of code. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Reviewed-by: Noralf Trønnes<nor...@tr

Re: [PATCH v18 08/10] drm/omapdrm: Use backlight_enable/disable helpers

2018-01-23 Thread Noralf Trønnes
viewed-by: Noralf Trønnes<nor...@tronnes.org> drivers/gpu/drm/omapdrm/displays/panel-dpi.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c index e065f7e10..ac95

Re: [PATCH v18 07/10] drm/panel: Use backlight_enable/disable helpers

2018-01-23 Thread Noralf Trønnes
viewed-by: Noralf Trønnes <nor...@tronnes.org> drivers/gpu/drm/panel/panel-innolux-p079zca.c | 6 ++ drivers/gpu/drm/panel/panel-jdi-lt070me05000.c | 6 ++ drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c | 10 ++ drivers/gpu/drm/panel/panel-sharp-ls043t

Re: [PATCH v17 03/10] video: backlight: Add of_find_backlight helper in backlight.c

2018-01-21 Thread Noralf Trønnes
Den 19.01.2018 12.05, skrev Daniel Thompson: On Fri, Jan 19, 2018 at 10:42:15AM +, Meghana Madhyastha wrote: Add of_find_backlight, a helper function which is a generic version of tinydrm_of_find_backlight that can be used by other drivers to avoid repetition of code and simplify things.

Re: [PATCH v17 06/10] drm/tinydrm: Call devres version of of_find_backlight

2018-01-21 Thread Noralf Trønnes
Den 19.01.2018 11.46, skrev Meghana Madhyastha: Call devm_of_find_backlight (the devres version) instead of of_find_backlight. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- I already put my r-b on this one in the previous version, but now also: Tested-by:

Re: [PATCH v17 03/10] video: backlight: Add of_find_backlight helper in backlight.c

2018-01-21 Thread Noralf Trønnes
com> --- Reviewed-by: Noralf Trønnes <nor...@tronnes.org> changes in v17: -rebase with drm-misc-next -convert st7735r callers from tinydrm specific helpers to new generic backlight helpers -remove select BACKLIGHT_LCD_SUPPORT and select BACKLIGHT_CLASS_DEVICE from tinydrm/Kconfi

Re: [PATCH v17 09/10] drm/panel: Use of_find_backlight helper

2018-01-21 Thread Noralf Trønnes
Den 19.01.2018 11.47, skrev Meghana Madhyastha: Replace of_find_backlight_by_node and of the code around it with of_find_backlight helper to avoid repetition of code. Signed-off-by: Meghana Madhyastha --- changes in v17: -remove put_device() to avoid double put

Re: [PATCH v16 09/10] drm/panel: Use of_find_backlight helper

2018-01-18 Thread Noralf Trønnes
Den 18.01.2018 13.07, skrev Meghana Madhyastha: On Tue, Jan 16, 2018 at 06:08:53PM +0100, Noralf Trønnes wrote: Den 16.01.2018 11.36, skrev Meghana Madhyastha: Replace of_find_backlight_by_node and of the code around it with of_find_backlight helper to avoid repetition of code. Signed-off

Re: [PATCH v16 01/10] video: backlight: Add helpers to enable and disable backlight

2018-01-18 Thread Noralf Trønnes
Den 17.01.2018 18.00, skrev Daniel Thompson: On 16/01/18 10:31, Meghana Madhyastha wrote: Add helper functions backlight_enable and backlight_disable to enable/disable a backlight device. These helper functions can then be used by different drm and tinydrm drivers to avoid repetition of code

Re: [PATCH v16 07/10] drm/panel: Use backlight_enable/disable helpers

2018-01-16 Thread Noralf Trønnes
Den 16.01.2018 11.35, skrev Meghana Madhyastha: Use backlight_enable/disable helpers instead of changing the property and calling backlight_update_status for cleaner and simpler code and also to avoid repetitions. Signed-off-by: Meghana Madhyastha ---

Re: [PATCH v16 09/10] drm/panel: Use of_find_backlight helper

2018-01-16 Thread Noralf Trønnes
Den 16.01.2018 11.36, skrev Meghana Madhyastha: Replace of_find_backlight_by_node and of the code around it with of_find_backlight helper to avoid repetition of code. Signed-off-by: Meghana Madhyastha --- drivers/gpu/drm/panel/panel-innolux-p079zca.c | 10

Re: [PATCH v16 06/10] drm/tinydrm: Call devres version of of_find_backlight

2018-01-16 Thread Noralf Trønnes
ith that fixed: Reviewed-by: Noralf Trønnes <nor...@tronnes.org> ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v16 05/10] video: backlight: Add devres versions of of_find_backlight

2018-01-16 Thread Noralf Trønnes
: -:26: WARNING: Block comments should align the * on each line This one is text so might as well fix it: -:29: WARNING: line over 80 characters With that fixed: Reviewed-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/video/backlight/backlight.c | 29 + i

Re: [PATCH v16 04/10] drm/tinydrm: Replace tinydrm_of_find_backlight with of_find_backlight

2018-01-16 Thread Noralf Trønnes
r work! With that fixed: Reviewed-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c | 40 -- drivers/gpu/drm/tinydrm/mi0283qt.c | 3 +- include/drm/tinydrm/tinydrm-helpers.h | 2 -- 3 files changed, 2 inser

Re: [PATCH v16 03/10] video: backlight: Add of_find_backlight helper in backlight.c

2018-01-16 Thread Noralf Trønnes
Den 16.01.2018 11.33, skrev Meghana Madhyastha: Add of_find_backlight, a helper function which is a generic version of tinydrm_of_find_backlight that can be used by other drivers to avoid repetition of code and simplify things. Signed-off-by: Meghana Madhyastha

Re: [PATCH v16 02/10] drm/tinydrm: Convert tinydrm_enable/disable_backlight to backlight_enable/disable

2018-01-16 Thread Noralf Trønnes
o mipi-dbi. Reviewed-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c | 55 -- drivers/gpu/drm/tinydrm/mipi-dbi.c | 4 +- include/drm/tinydrm/tinydrm-helpers.h | 2 - 3 files changed, 2 inser

Re: [PATCH v16 01/10] video: backlight: Add helpers to enable and disable backlight

2018-01-16 Thread Noralf Trønnes
way to enable/disable a backlight device. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> checkpatch complains: -:23: WARNING: Block comments should align the * on each line -:45: ERROR: trailing whitespace With that fixed: Reviewed-by: Noralf Trønnes <nor...@tr

Re: [PATCH v3 0/7] drm/tinydrm: Cleanup

2018-01-15 Thread Noralf Trønnes
Den 10.01.2018 19.59, skrev Noralf Trønnes: Fix a few things that came up during the tinydrm review but wasn't addressed at the time. Noralf. Thanks for review and testing, series applied to drm-misc. Noralf. Changes since version 2: - s/mipi_dbi_por_conditional

Re: [PATCH v3 4/7] drm/tinydrm/mipi-dbi: Add poweron-reset functions

2018-01-12 Thread Noralf Trønnes
Den 11.01.2018 23.22, skrev David Lechner: On 01/10/2018 12:59 PM, Noralf Trønnes wrote: Split out common poweron-reset functionality. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> ---   drivers/gpu/drm/tinydrm/mi0283qt.c | 22 ++--   drivers/gpu/drm/tinydrm/mipi-dbi.

Re: [RFC v2 6/8] drm: Handle fbdev emulation in core

2018-01-11 Thread Noralf Trønnes
Den 11.01.2018 08.45, skrev Daniel Vetter: On Wed, Jan 10, 2018 at 06:02:38PM +0100, Noralf Trønnes wrote: Den 09.01.2018 11.38, skrev Daniel Vetter: On Wed, Jan 03, 2018 at 11:21:08PM +0100, Noralf Trønnes wrote: Prepare for generic fbdev emulation by letting DRM core work directly

[PATCH v3 1/7] drm/tinydrm/mi0283qt: Use common include order

2018-01-10 Thread Noralf Trønnes
Include linux headers before drm headers as it's commonly done. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Reviewed-by: David Lechner <da...@lechnology.com> --- drivers/gpu/drm/tinydrm/mi0283qt.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a

[PATCH v3 3/7] drm/tinydrm/mipi-dbi: Add mipi_dbi_enable_flush()

2018-01-10 Thread Noralf Trønnes
Add and use a function for enabling, flushing and turning on backlight. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Reviewed-by: David Lechner <da...@lechnology.com> --- drivers/gpu/drm/tinydrm/ili9225.c | 6 +- drivers/gpu/drm/tinydrm/mipi-dbi.c | 20 +

[PATCH v3 6/7] drm/tinydrm: Embed the mode in tinydrm_connector

2018-01-10 Thread Noralf Trønnes
Embed the mode in tinydrm_connector instead of doing an devm_ allocation. Remove unnecessary use of ret variable at the end of tinydrm_display_pipe_init(). Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Reviewed-by: David Lechner <da...@lechnology.com> --- drivers/gpu/drm/

[PATCH v3 7/7] drm/tinydrm/mipi-dbi: Change reset active time

2018-01-10 Thread Noralf Trønnes
The MIPI DBI spec states that reset active/low time should be more than 9us. Change from 20ms to 20us. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/tinydrm/mipi-dbi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tinydrm/mipi

[PATCH v3 5/7] drm/tinydrm/mi0283qt: Let the display pipe handle power

2018-01-10 Thread Noralf Trønnes
It's better to leave power handling and controller init to the modesetting machinery using the simple pipe .enable and .disable callbacks. Remove unused mipi_dbi_pipe_enable(). Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Reviewed-by: David Lechner <da...@lechnology.com> ---

[PATCH v3 0/7] drm/tinydrm: Cleanup

2018-01-10 Thread Noralf Trønnes
. - Use drm_mode_copy() instead of direct assignment Noralf Trønnes (7): drm/tinydrm/mi0283qt: Use common include order drm/tinydrm/mi0283qt: Remove ili9341.h drm/tinydrm/mipi-dbi: Add mipi_dbi_enable_flush() drm/tinydrm/mipi-dbi: Add poweron-reset functions drm/tinydrm/mi0283qt: Let

[PATCH v3 4/7] drm/tinydrm/mipi-dbi: Add poweron-reset functions

2018-01-10 Thread Noralf Trønnes
Split out common poweron-reset functionality. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/tinydrm/mi0283qt.c | 22 ++-- drivers/gpu/drm/tinydrm/mipi-dbi.c | 73 ++ drivers/gpu/drm/tinydrm/st7586.c | 9 ++--- drive

[PATCH v3 2/7] drm/tinydrm/mi0283qt: Remove ili9341.h

2018-01-10 Thread Noralf Trønnes
No need for a public header file for the command macros. Just include the necessary ones in the driver. Also use the MIPI_DCS_PIXEL_FMT_16BIT macro. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Reviewed-by: David Lechner <da...@lechnology.com> --- drivers/gpu/drm/tinydrm/mi0

Re: [RFC v2 6/8] drm: Handle fbdev emulation in core

2018-01-10 Thread Noralf Trønnes
Den 09.01.2018 11.38, skrev Daniel Vetter: On Wed, Jan 03, 2018 at 11:21:08PM +0100, Noralf Trønnes wrote: Prepare for generic fbdev emulation by letting DRM core work directly with the fbdev compatibility layer. This is done by adding new fbdev helper vtable callbacks for restore

Re: [PATCH v2 4/6] drm/tinydrm/mipi-dbi: Add poweron-reset functions

2018-01-09 Thread Noralf Trønnes
Den 09.01.2018 02.38, skrev David Lechner: On 01/07/2018 11:44 AM, Noralf Trønnes wrote: Split out common poweron-reset functionality. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> ---   drivers/gpu/drm/tinydrm/mi0283qt.c | 20 ++--   drivers/gpu/drm/tinydrm/mipi-dbi.

Re: [PATCH v2 6/6] drm/tinydrm: Embed the mode in tinydrm_connector

2018-01-09 Thread Noralf Trønnes
Den 09.01.2018 11.08, skrev Daniel Vetter: On Mon, Jan 08, 2018 at 07:46:27PM -0600, David Lechner wrote: On 01/07/2018 11:44 AM, Noralf Trønnes wrote: Embed the mode in tinydrm_connector instead of doing an devm_ allocation. Remove unnecessary use of ret variable at the end

Re: [PATCH v2 4/6] drm/tinydrm/mipi-dbi: Add poweron-reset functions

2018-01-07 Thread Noralf Trønnes
Den 07.01.2018 18.44, skrev Noralf Trønnes: Split out common poweron-reset functionality. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/tinydrm/mi0283qt.c | 20 ++-- drivers/gpu/drm/tinydrm/mipi-dbi.c | 63 ++ drive

[PATCH v2 3/6] drm/tinydrm/mipi-dbi: Add mipi_dbi_enable_flush()

2018-01-07 Thread Noralf Trønnes
Add and use a function for enabling, flushing and turning on backlight. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/tinydrm/ili9225.c | 6 +- drivers/gpu/drm/tinydrm/mipi-dbi.c | 20 drivers/gpu/drm/tinydrm/st7586.c | 6 +- drive

[PATCH v2 5/6] drm/tinydrm/mi0283qt: Let the display pipe handle power

2018-01-07 Thread Noralf Trønnes
It's better to leave power handling and controller init to the modesetting machinery using the simple pipe .enable and .disable callbacks. Remove unused mipi_dbi_pipe_enable(). Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/tinydrm/mi0283qt.

[PATCH v2 4/6] drm/tinydrm/mipi-dbi: Add poweron-reset functions

2018-01-07 Thread Noralf Trønnes
Split out common poweron-reset functionality. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/tinydrm/mi0283qt.c | 20 ++-- drivers/gpu/drm/tinydrm/mipi-dbi.c | 63 ++ drivers/gpu/drm/tinydrm/st7586.c | 9 ++ drive

[PATCH v2 2/6] drm/tinydrm/mi0283qt: Remove ili9341.h

2018-01-07 Thread Noralf Trønnes
No need for a public header file for the command macros. Just include the necessary ones in the driver. Also use the MIPI_DCS_PIXEL_FMT_16BIT macro. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Reviewed-by: David Lechner <da...@lechnology.com> --- drivers/gpu/drm/tinydrm/mi0

[PATCH v2 6/6] drm/tinydrm: Embed the mode in tinydrm_connector

2018-01-07 Thread Noralf Trønnes
Embed the mode in tinydrm_connector instead of doing an devm_ allocation. Remove unnecessary use of ret variable at the end of tinydrm_display_pipe_init(). Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c | 34 +++---

[PATCH v2 1/6] drm/tinydrm/mi0283qt: Use common include order

2018-01-07 Thread Noralf Trønnes
Include linux headers before drm headers as it's commonly done. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Reviewed-by: David Lechner <da...@lechnology.com> --- drivers/gpu/drm/tinydrm/mi0283qt.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a

[PATCH v2 0/6] drm/tinydrm: Cleanup

2018-01-07 Thread Noralf Trønnes
drm_mode_copy() instead of direct assignment Noralf Trønnes (6): drm/tinydrm/mi0283qt: Use common include order drm/tinydrm/mi0283qt: Remove ili9341.h drm/tinydrm/mipi-dbi: Add mipi_dbi_enable_flush() drm/tinydrm/mipi-dbi: Add poweron-reset functions drm/tinydrm/mi0283qt: Let the display

Re: [PATCH 4/5] drm/tinydrm/mi0283qt: Let the display pipe handle power

2018-01-06 Thread Noralf Trønnes
Den 06.01.2018 19.10, skrev David Lechner: On 01/06/2018 06:45 AM, Noralf Trønnes wrote: Den 05.01.2018 19.59, skrev David Lechner: On 01/05/2018 10:55 AM, Noralf Trønnes wrote: It's better to leave power handling and controller init to the modesetting machinery using the simple pipe

Re: [PATCH 5/5] drm/tinydrm: Embed the mode in tinydrm_connector

2018-01-06 Thread Noralf Trønnes
Den 05.01.2018 20.14, skrev David Lechner: On 01/05/2018 10:56 AM, Noralf Trønnes wrote: Embed the mode in tinydrm_connector instead of doing an devm_ allocation. Remove unnecessary use of ret variable at the end of tinydrm_display_pipe_init(). Signed-off-by: Noralf Trønnes <

Re: [PATCH 4/5] drm/tinydrm/mi0283qt: Let the display pipe handle power

2018-01-06 Thread Noralf Trønnes
Den 05.01.2018 19.59, skrev David Lechner: On 01/05/2018 10:55 AM, Noralf Trønnes wrote: It's better to leave power handling and controller init to the modesetting machinery using the simple pipe .enable and .disable callbacks. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> ---   d

[PATCH 3/5] drm/tinydrm/mi0283qt: Clarify error message

2018-01-05 Thread Noralf Trønnes
Make it clear that the printed value is the error and not the command value itself. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/tinydrm/mi0283qt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tinydrm/mi0283qt.c b/drive

[PATCH 1/5] drm/tinydrm/mi0283qt: Use common include order

2018-01-05 Thread Noralf Trønnes
Include linux headers before drm headers as it's commonly done. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/tinydrm/mi0283qt.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/tinydrm/mi0283qt.c b/drivers/gpu/drm/t

[PATCH 0/5] drm/tinydrm: Cleanup

2018-01-05 Thread Noralf Trønnes
Patches 1-4 fixes a few things that came up during the tinydrm review but wasn't addressed at the time. Noralf. Noralf Trønnes (5): drm/tinydrm/mi0283qt: Use common include order drm/tinydrm/mi0283qt: Remove ili9341.h drm/tinydrm/mi0283qt: Clarify error message drm/tinydrm/mi0283qt: Let

[PATCH 5/5] drm/tinydrm: Embed the mode in tinydrm_connector

2018-01-05 Thread Noralf Trønnes
Embed the mode in tinydrm_connector instead of doing an devm_ allocation. Remove unnecessary use of ret variable at the end of tinydrm_display_pipe_init(). Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c | 34 +++---

[PATCH 2/5] drm/tinydrm/mi0283qt: Remove ili9341.h

2018-01-05 Thread Noralf Trønnes
No need for a public header file for the command macros. Just include the necessary ones in the driver. Also use the MIPI_DCS_PIXEL_FMT_16BIT macro. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/tinydrm/mi0283qt.c | 28 ++-- include/drm/tinydrm/ili

[PATCH 4/5] drm/tinydrm/mi0283qt: Let the display pipe handle power

2018-01-05 Thread Noralf Trønnes
It's better to leave power handling and controller init to the modesetting machinery using the simple pipe .enable and .disable callbacks. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/tinydrm/mi0283qt.c | 51 -- drivers/g

[RFC v2 7/8] drm/fb-helper: Add generic fbdev emulation

2018-01-03 Thread Noralf Trønnes
Add generic fbdev emulation which uses a drm_file to get a dumb_buffer and drm_framebuffer. The buffer is exported and vmap/mmap called on the dma-buf. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/drm_fb_helper.c | 301 +++- i

[RFC v2 4/8] drm/fb-helper: Ensure driver module is pinned in fb_open()

2018-01-03 Thread Noralf Trønnes
If struct fb_ops is defined in a library like cma, fb_open() and fbcon takes a ref on the library instead of the driver module. Use fb_ops.fb_open/fb_release to ensure that the driver module is pinned. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/drm_fb_helper.

[RFC v2 8/8] drm/vc4: Test generic fbdev emulation

2018-01-03 Thread Noralf Trønnes
Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/vc4/vc4_drv.c | 3 --- drivers/gpu/drm/vc4/vc4_kms.c | 3 +-- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c index ceb385fd69c5..ef8a2d3a6d1f

[RFC v2 6/8] drm: Handle fbdev emulation in core

2018-01-03 Thread Noralf Trønnes
Prepare for generic fbdev emulation by letting DRM core work directly with the fbdev compatibility layer. This is done by adding new fbdev helper vtable callbacks for restore, hotplug_event, unregister and release. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/drm_

[RFC v2 3/8] drm: Export some ioctl functions

2018-01-03 Thread Noralf Trønnes
Export the following functions so in-kernel users can allocate dumb buffers: - drm_file_alloc - drm_file_free - drm_prime_handle_to_fd_ioctl - drm_mode_addfb2 - drm_mode_create_dumb_ioctl - drm_dropmaster_ioctl Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/drm_

[RFC v2 2/8] drm/ioctl: Remove trailing whitespace

2018-01-03 Thread Noralf Trønnes
Remove a couple of trailing spaces. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/drm_ioctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c index 4aafe4802099..b1e96fb68ea8

[RFC v2 5/8] drm/fb-helper: Don't restore if fbdev is not in use

2018-01-03 Thread Noralf Trønnes
-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/drm_fb_helper.c | 15 +++ include/drm/drm_fb_helper.h | 14 ++ 2 files changed, 29 insertions(+) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 2c6adf1d80c2..f9dcc7

[RFC v2 1/8] drm: provide management functions for drm_file

2018-01-03 Thread Noralf Trønnes
e fops implementations and APIs (not that I am aware of any such plans), and more importantly from in-kernel use where no real file is available. Signed-off-by: David Herrmann <dh.herrm...@gmail.com> [rebased] Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/dr

[RFC v2 0/8] drm: Add generic fbdev emulation

2018-01-03 Thread Noralf Trønnes
ned! - Drop buggy patch: (Chris Wilson) drm/prime: Clear drm_gem_object->dma_buf on release - Defer buffer creation until fb_open. David Herrmann (1): drm: provide management functions for drm_file Noralf Trønnes (7): drm/ioctl: Remove trailing whitespace drm: Export some ioctl functions

Re: [PATCH v4 3/3] drm/tinydrm: add driver for ST7735R panels

2018-01-03 Thread Noralf Trønnes
.com> Reviewed-by: Noralf Trønnes <nor...@tronnes.org> Reviewed-by: Linus Walleij <linus.wall...@linaro.org> Thanks, series applied to drm-misc. Noralf. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 0/3] update compatible string for ILI9225

2018-01-03 Thread Noralf Trønnes
Den 21.12.2017 19.33, skrev David Lechner: This updates the device tree compatible string for an ILI9225 display. Detailed explanation is in the patches. David Lechner (3): dt-bindings: Add "vot" vendor prefix dt-bindings: update compatible string for ILI9225 drm/tinydrm: Update

Re: [PATCH v14 0/3] Move backlight helper functions from tinydrm-helpers to linux/backlight

2018-01-02 Thread Noralf Trønnes
Den 26.12.2017 07.39, skrev Meghana Madhyastha: On Thu, Dec 21, 2017 at 11:52:43AM +0100, Noralf Trønnes wrote: Den 11.12.2017 18.56, skrev Noralf Trønnes: Den 11.12.2017 18.45, skrev Noralf Trønnes: Den 11.12.2017 15.58, skrev Meghana Madhyastha: On Mon, Dec 11, 2017 at 03:12:06PM +0100

Re: [Intel-gfx] [RFC 4/7] drm/prime: Clear drm_gem_object->dma_buf on release

2018-01-01 Thread Noralf Trønnes
Den 31.12.2017 16.41, skrev Chris Wilson: Quoting Noralf Trønnes (2017-12-31 13:58:40) Clear the pointer so the buffer can be re-exported. Otherwise use after free happens in the next call to drm_gem_prime_handle_to_fd(). Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drive

<    4   5   6   7   8   9   10   11   12   13   >