[PATCH v5 0/1] drm/xen-front: Add support for Xen PV display frontend

From: Oleksandr Andrushchenko <oleksandr_andrushche...@epam.com> Hello! Boris/Daniel, I put your R-b tags, so please do let me know if this is not acceptable, so I remove the tags. This patch series adds support for Xen [1] para-virtualized frontend display driver. It implements the pr

Re: [PATCH v5 0/1] drm/xen-front: Add support for Xen PV display frontend

On 03/29/2018 12:22 PM, Oleksandr Andrushchenko wrote: Changes since v4: For your convenience I am attaching diff between v4..v5 diff --git a/Documentation/gpu/xen-front.rst b/Documentation/gpu/xen-front.rst index 8188e03c9d23..009d942386c5 100644 --- a/Documentation/gpu/xen-front.rst +++ b

Re: [PATCH] drm: Use srcu to protect drm_device.unplugged

On 03/28/2018 06:09 PM, Daniel Vetter wrote: On Wed, Mar 28, 2018 at 10:38:35AM +0300, Oleksandr Andrushchenko wrote: From: Noralf Trønnes <nor...@tronnes.org> Use srcu to protect drm_device.unplugged in a race free manner. Drivers can use drm_dev_enter()/drm_dev_exit() to protect an

Re: [PATCH v3] drm/xen-front: Add support for Xen PV display frontend

On 03/26/2018 11:18 AM, Daniel Vetter wrote: On Fri, Mar 23, 2018 at 05:54:49PM +0200, Oleksandr Andrushchenko wrote: My apologies, but I found a few more things that look strange and should be cleaned up. Sorry for this iterative review approach, but I think we're slowly getting there. Thank

Re: [PATCH v2 00/11] drm/tinydrm: Support device unplug

Hi, Noralf! On 03/17/2018 04:40 PM, Noralf Trønnes wrote: Den 16.03.2018 09.03, skrev Daniel Vetter: On Fri, Sep 8, 2017 at 6:33 PM, Daniel Vetter  wrote: Hi Noralf, On Fri, Sep 08, 2017 at 05:07:19PM +0200, Noralf Trønnes wrote: This adds device unplug support to

Re: [PATCH] MAINTAINERS: Add drm/xen-front maintainer entry

On 04/03/2018 03:32 PM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko <oleksandr_andrushche...@epam.com> Add myself as drivers/gpu/drm/xen maintainer. Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushche...@epam.com> --- MAINTAINERS | 9 + 1 fil

[PATCH v6 1/1] drm/xen-front: Add support for Xen PV display frontend

From: Oleksandr Andrushchenko <oleksandr_andrushche...@epam.com> Add support for Xen para-virtualized frontend display driver. Accompanying backend [1] is implemented as a user-space application and its helper library [2], capable of running as a Weston client or DRM master. Configuration o

[PATCH v6 0/1] drm/xen-front: Add support for Xen PV display frontend

From: Oleksandr Andrushchenko <oleksandr_andrushche...@epam.com> Hello! Boris/Daniel, I put your R-b tags, so please do let me know if this is not acceptable, so I remove the tags. This patch series adds support for Xen [1] para-virtualized frontend display driver. It implements the pr

[PATCH 0/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver

From: Oleksandr Andrushchenko <oleksandr_andrushche...@epam.com> Hello! When using Xen PV DRM frontend driver then on backend side one will need to do copying of display buffers' contents (filled by the frontend's user-space) into buffers allocated at the backend side. Taking into a

[PATCH 1/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver

From: Oleksandr Andrushchenko <oleksandr_andrushche...@epam.com> Introduce Xen zero-copy helper DRM driver, add user-space API of the driver: 1. DRM_IOCTL_XEN_ZCOPY_DUMB_FROM_REFS This will create a DRM dumb buffer from grant references provided by the frontend. The intended

Re: [PATCH v4 2/2] drm/xen-front: Add support for Xen PV display frontend

xen_drm_front_drm_pipeline *pipeline = + container_of(crtc, Could you please amend the patch in attachment when merging, so I don't resend? Thank you in advance, Oleksandr >From 3a82d76bd3d954056b760e5d1d09e2f96a2786ef Mon Sep 17 00:00:00 2001 From: Oleksandr Andrushchenko <oleksandr_andr

Re: [PATCH RESEND v2 1/2] drm/xen-front: Add support for Xen PV display frontend

On 03/19/2018 03:51 PM, Daniel Vetter wrote: On Fri, Mar 16, 2018 at 12:52:09PM +0200, Oleksandr Andrushchenko wrote: Hi, Daniel! Sorry, if I strip the patch too much below. On 03/16/2018 10:23 AM, Daniel Vetter wrote: S-o-b line went missing here :-) will restore it back ;) I've read

Re: [PATCH v2 00/11] drm/tinydrm: Support device unplug

On 03/19/2018 03:45 PM, Daniel Vetter wrote: On Sat, Mar 17, 2018 at 03:40:29PM +0100, Noralf Trønnes wrote: Den 16.03.2018 09.03, skrev Daniel Vetter: On Fri, Sep 8, 2017 at 6:33 PM, Daniel Vetter wrote: Hi Noralf, On Fri, Sep 08, 2017 at 05:07:19PM +0200, Noralf Trønnes

Re: [PATCH RESEND v2 0/2] drm/xen-front: Add support for Xen PV display frontend

On 03/20/2018 01:23 AM, Boris Ostrovsky wrote: On 03/13/2018 12:21 PM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko <oleksandr_andrushche...@epam.com> Hello! Resending with all the patches squashed on Daniel's request. Which of the two series are we supposed to review?

Re: [PATCH RESEND v2 1/2] drm/xen-front: Add support for Xen PV display frontend

On 03/19/2018 05:28 PM, Daniel Vetter wrote: On Mon, Mar 19, 2018 at 3:19 PM, Oleksandr Andrushchenko <andr2...@gmail.com> wrote: On 03/19/2018 03:51 PM, Daniel Vetter wrote: On Fri, Mar 16, 2018 at 12:52:09PM +0200, Oleksandr Andrushchenko wrote: Hi, Daniel! Sorry, if I strip the pat

Re: [PATCH v3] drm/xen-front: Add support for Xen PV display frontend

On 03/22/2018 03:14 AM, Boris Ostrovsky wrote: On 03/21/2018 10:58 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko <oleksandr_andrushche...@epam.com> Add support for Xen para-virtualized frontend display driver. Accompanying backend [1] is implemented as a user

Re: [PATCH RESEND v2 1/2] drm/xen-front: Add support for Xen PV display frontend

On 03/20/2018 03:47 PM, Daniel Vetter wrote: On Tue, Mar 20, 2018 at 01:58:01PM +0200, Oleksandr Andrushchenko wrote: On 03/19/2018 05:28 PM, Daniel Vetter wrote: There should be no difference between immediate removal and delayed removal of the drm_device from the xenbus pov. The lifetimes

[PATCH v3] drm/xen-front: Add support for Xen PV display frontend

From: Oleksandr Andrushchenko <oleksandr_andrushche...@epam.com> Add support for Xen para-virtualized frontend display driver. Accompanying backend [1] is implemented as a user-space application and its helper library [2], capable of running as a Weston client or DRM master. Configuration o

[PATCH v3] drm/xen-front: Add support for Xen PV display frontend

From: Oleksandr Andrushchenko <oleksandr_andrushche...@epam.com> Hello! This patch series adds support for Xen [1] para-virtualized frontend display driver. It implements the protocol from include/xen/interface/io/displif.h [2]. Accompanying backend [3] is implemented as a user-space appli

Re: [PATCH] drm/gem: Document that handle_create must be the last step

(all the kms/prime/syncobj stuff is handled by the core) no other functions seem to be in need of this clarification. Motivated by reviewing the xen-front kms driver. Cc: Oleksandr Andrushchenko <oleksandr_andrushche...@epam.com> Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> -

Re: [PATCH v3] drm/xen-front: Add support for Xen PV display frontend

My apologies, but I found a few more things that look strange and should be cleaned up. Sorry for this iterative review approach, but I think we're slowly getting there. Thank you for reviewing! Cheers, Daniel --- +static int xen_drm_drv_dumb_create(struct drm_file *filp, +

Re: [PATCH 6/9] drm/xen-front: Introduce DRM/KMS virtual display driver

On 03/05/2018 11:13 AM, Daniel Vetter wrote: On Wed, Feb 21, 2018 at 10:03:39AM +0200, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko <oleksandr_andrushche...@epam.com> Implement essential initialization of the display driver: - introduce required data structures -

Re: [PATCH 7/9] drm/xen-front: Implement KMS/connector handling

On 03/05/2018 11:23 AM, Daniel Vetter wrote: On Wed, Feb 21, 2018 at 10:03:40AM +0200, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko <oleksandr_andrushche...@epam.com> Implement kernel modesetiing/connector handling using DRM simple KMS helper pipeline: - implement KM

Re: [PATCH 8/9] drm/xen-front: Implement GEM operations

On 03/05/2018 11:32 AM, Daniel Vetter wrote: On Wed, Feb 21, 2018 at 10:03:41AM +0200, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko <oleksandr_andrushche...@epam.com> Implement GEM handling depending on driver mode of operation: depending on the requirements for th

Re: [PATCH 0/9] drm/xen-front: Add support for Xen PV display frontend

QEMU to run. Although this use case would work on x86 it will require additional changes to get this running on ARM, which is my target platform. Thank you, Oleksandr On 02/26/2018 10:21 AM, Oleksandr Andrushchenko wrote: ** *Hi, all!* * Last *Friday* some concerns on #dri-devel were raised

Re: [PATCH 8/9] drm/xen-front: Implement GEM operations

On 03/06/2018 09:26 AM, Daniel Vetter wrote: On Mon, Mar 05, 2018 at 03:46:07PM +0200, Oleksandr Andrushchenko wrote: On 03/05/2018 11:32 AM, Daniel Vetter wrote: On Wed, Feb 21, 2018 at 10:03:41AM +0200, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko <oleksandr_andrush

Re: [PATCH 7/9] drm/xen-front: Implement KMS/connector handling

On 03/06/2018 09:22 AM, Daniel Vetter wrote: On Mon, Mar 05, 2018 at 02:59:23PM +0200, Oleksandr Andrushchenko wrote: On 03/05/2018 11:23 AM, Daniel Vetter wrote: On Wed, Feb 21, 2018 at 10:03:40AM +0200, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko <oleksandr_andrush

Re: [PATCH 9/9] drm/xen-front: Implement communication with backend

On 03/05/2018 11:25 AM, Daniel Vetter wrote: On Wed, Feb 21, 2018 at 10:03:42AM +0200, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko <oleksandr_andrushche...@epam.com> Handle communication with the backend: - send requests and wait for the responses acc

Re: [PATCH] drm/simple_kms_helper: Fix NULL pointer dereference with no active CRTC

On 03/05/2018 10:52 AM, Daniel Vetter wrote: On Tue, Feb 20, 2018 at 03:29:07PM +0200, Oleksandr Andrushchenko wrote: On 02/20/2018 02:53 PM, Oleksandr Andrushchenko wrote: On 02/20/2018 02:49 PM, Daniel Vetter wrote: On Tue, Feb 20, 2018 at 02:36:05PM +0200, Oleksandr Andrushchenko wrote

[PATCH v2] drm/xen-front: Make shmem backed display buffer coherent

From: Oleksandr Andrushchenko When GEM backing storage is allocated with drm_gem_get_pages the backing pages may be cached, thus making it possible that the backend sees only partial content of the buffer which may lead to screen artifacts. Make sure that the frontend's memory is coherent

Re: [PATCH] drm: Split out drm_probe_helper.h

rivers/gpu/drm/xen/xen_drm_front_gem.c | 2 +- drivers/gpu/drm/xen/xen_drm_front_kms.c | 2 +- For Xen: Acked-by: Oleksandr Andrushchenko drivers/gpu/drm/zte/zx_drm_drv.c | 2 +- drivers/gpu/drm/zte/zx_hdmi.c | 2 +- drivers/gpu/drm/zte/zx_t

Re: [PATCH v2] drm/xen-front: Make shmem backed display buffer coherent

On 1/17/19 11:18 AM, Christoph Hellwig wrote: > On Wed, Jan 16, 2019 at 06:43:29AM +0000, Oleksandr Andrushchenko wrote: >>> This whole issue keeps getting more and more confusing. >> Well, I don't really do DMA here, but instead the buffers in >> question are shared w

Re: [Xen-devel] [PATCH v2] drm/xen-front: Make shmem backed display buffer coherent

On 1/18/19 1:43 PM, Julien Grall wrote: > (+ Stefano) > > Hi, > > Sorry for jumping late in the conversation. > > On 18/01/2019 09:40, Oleksandr Andrushchenko wrote: >> On 1/17/19 11:18 AM, Christoph Hellwig wrote: >>> On Wed, Jan 16, 2019 at 06:43:29AM +

Re: [Xen-devel] [PATCH v2] drm/xen-front: Make shmem backed display buffer coherent

Hello, Julien! On 1/21/19 7:09 PM, Julien Grall wrote: > Hello, > > On 21/01/2019 12:43, Oleksandr Andrushchenko wrote: >> On 1/18/19 1:43 PM, Julien Grall wrote: >>> On 18/01/2019 09:40, Oleksandr Andrushchenko wrote: >>>> On 1/17/19 11:18 AM, Christoph Hellw

Re: [PATCH v2] drm/xen-front: Make shmem backed display buffer coherent

On 1/16/19 8:36 AM, Christoph Hellwig wrote: > On Wed, Jan 16, 2019 at 07:30:02AM +0100, Gerd Hoffmann wrote: >>Hi, >> >>> + if (!dma_map_sg(dev->dev, xen_obj->sgt->sgl, xen_obj->sgt->nents, >>> + DMA_BIDIRECTIONAL)) { >>> + ret = -EFAULT; >>> + goto

Re: [PATCH v2] drm/xen-front: Make shmem backed display buffer coherent

On 1/16/19 8:30 AM, Gerd Hoffmann wrote: >Hi, > >> +if (!dma_map_sg(dev->dev, xen_obj->sgt->sgl, xen_obj->sgt->nents, >> +DMA_BIDIRECTIONAL)) { >> +ret = -EFAULT; >> +goto fail_free_sgt; >> +} > Hmm, so it seems the arm guys could not come up

Re: [Xen-devel][PATCH v2 2/3] drm/xen-front: Use Xen common shared buffer implementation

bump On 12/5/18 10:20 AM, Oleksandr Andrushchenko wrote: Hello, Daniel! Could you please ack/nack the patch, so either we can merge the series or I can address your comments if any Thank you, Oleksandr On 11/30/18 9:42 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko Use

Re: [PATCH] drm/xen-front: Make shmem backed display buffer coherent

Daniel, could you please comment? Thank you On 11/27/18 12:32 PM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko When GEM backing storage is allocated with drm_gem_get_pages the backing pages may be cached, thus making it possible that the backend sees only partial content

Re: [Xen-devel] [PATCH v2 2/3] drm/xen-front: Use Xen common shared buffer implementation

On 12/17/18 5:26 PM, Boris Ostrovsky wrote: On 12/17/18 10:03 AM, Oleksandr Andrushchenko wrote: On 12/17/18 4:52 PM, Boris Ostrovsky wrote: On 12/17/18 5:19 AM, Oleksandr Andrushchenko wrote: Hello, Juergen, Boris! As this DRM part of the series is the only one which needs ack/nack

Re: [Xen-devel][PATCH v2 2/3] drm/xen-front: Use Xen common shared buffer implementation

On 12/18/18 20:31, Boris Ostrovsky wrote: On 12/18/18 11:15 AM, Noralf Trønnes wrote: Den 30.11.2018 08.42, skrev Oleksandr Andrushchenko: From: Oleksandr Andrushchenko Use page directory based shared buffer implementation now available as common code for Xen frontend drivers. Remove

Re: [PATCH] drm/xen-front: Make shmem backed display buffer coherent

On 12/19/18 6:14 PM, Noralf Trønnes wrote: Den 19.12.2018 09.18, skrev Oleksandr Andrushchenko: On 12/18/18 9:20 PM, Noralf Trønnes wrote: Den 27.11.2018 11.32, skrev Oleksandr Andrushchenko: From: Oleksandr Andrushchenko When GEM backing storage is allocated with drm_gem_get_pages

Re: [PATCH 07/14] drm/bochs: atomic: use atomic page_flip helper

On 12/19/18 1:51 PM, Gerd Hoffmann wrote: Conversion to atomic modesetting, step five. Use atomic page_flip helper for crtc. Signed-off-by: Gerd Hoffmann Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/bochs/bochs_kms.c | 23 +-- 1 file changed, 1 insertion

Re: [PATCH 08/14] drm/bochs: atomic: set DRIVER_ATOMIC

On 12/19/18 1:51 PM, Gerd Hoffmann wrote: Conversion to atomic modesetting, final step. Set the DRIVER_ATOMIC flag. Signed-off-by: Gerd Hoffmann Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/bochs/bochs_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 09/14] drm/bochs: remove old bochs_crtc_* functions

On 12/19/18 1:51 PM, Gerd Hoffmann wrote: Remove the old, now unused crtc callbacks. Signed-off-by: Gerd Hoffmann Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/bochs/bochs_kms.c | 81 --- 1 file changed, 81 deletions(-) diff --git a/drivers

Re: [PATCH 06/14] drm/bochs: atomic: use atomic set_config helper

On 12/19/18 1:51 PM, Gerd Hoffmann wrote: Conversion to atomic modesetting, step four. Use atomic set_config helper for crtc. Signed-off-by: Gerd Hoffmann Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/bochs/bochs_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH 05/14] drm/bochs: atomic: switch planes to atomic, wire up helpers.

tc->primary->state, fb); Taking into account that crtc->primary access goes away in the series: Reviewed-by: Oleksandr Andrushchenko bochs_crtc_mode_set_base(crtc, 0, 0, old_fb); if (event) { spin_lock_irqsave(>dev->event_lock, irqflags); @@ -151

Re: [PATCH 13/14] drm/bochs: drop old fbdev emulation code

On 12/19/18 1:51 PM, Gerd Hoffmann wrote: Not needed any more, bochs uses the generic emulation now. Signed-off-by: Gerd Hoffmann Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/bochs/bochs.h | 9 --- drivers/gpu/drm/bochs/bochs_drv.c | 6 -- drivers/gpu/drm/bochs

Re: [PATCH 11/14] drm/bochs: add basic prime support

bochs_bo(obj); + + return ttm_fbdev_mmap(vma, >bo); +} With the above fixed: Reviewed-by: Oleksandr Andrushchenko ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: drm_gem_get_pages and proper flushing/coherency

community help understand the right way to flush those pages, so I don't need to use DMA for that? Thank you, Oleksandr On 11/26/18 2:15 PM, Oleksandr Andrushchenko wrote: Hello, all! My driver (Xen para-virtualized frontend) in some scenarios uses drm_gem_get_pages for allocating backing storage

Re: [PATCH] drm/xen-front: Make shmem backed display buffer coherent

On 12/19/18 4:10 PM, Gerd Hoffmann wrote: Hi, Sure this actually helps? It's below 4G in guest physical address space, so it can be backed by pages which are actually above 4G in host physical address space ... Yes, you are right here. This is why I wrote about the IOMMU and other

Re: [PATCH 04/14] drm/bochs: atomic: add mode_set_nofb callback.

On 12/19/18 1:51 PM, Gerd Hoffmann wrote: Conversion to atomic modesetting, step two. Add mode_set_nofb crtc helper callback. Signed-off-by: Gerd Hoffmann Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/bochs/bochs_kms.c | 9 + 1 file changed, 9 insertions(+) diff

Re: [PATCH 10/14] drm/bochs: drop unused gpu_addr arg from bochs_bo_pin()

On 12/19/18 1:51 PM, Gerd Hoffmann wrote: It's always NULL, so just remove it. Signed-off-by: Gerd Hoffmann Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/bochs/bochs.h | 2 +- drivers/gpu/drm/bochs/bochs_fbdev.c | 2 +- drivers/gpu/drm/bochs/bochs_kms.c | 2

Re: [PATCH 12/14] drm/bochs: switch to generic drm fbdev emulation

On 12/19/18 1:51 PM, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_drv.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bochs/bochs_drv.c b/drivers/gpu/drm/bochs/bochs_drv.c index a9c7140e3b..f1f65324bb 100644 ---

Re: [PATCH 14/14] drm/bochs: move remaining fb bits to kms

On 12/19/18 1:51 PM, Gerd Hoffmann wrote: bochs_fbdev.c is almost empty now. Move the remaining framebuffer bits over to bochs_kms.c. Pure code motion. No functional change. Signed-off-by: Gerd Hoffmann Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/bochs/bochs_fbdev.c | 29

Re: [PATCH v3] drm/bochs: add edid present check

/bochs: add edid support. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/bochs/bochs_hw.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/bochs/bochs_hw.c b/drivers/gpu/drm/bochs/bochs_hw.c index

Re: [PATCH] drm/xen-front: Make shmem backed display buffer coherent

On 12/20/18 5:36 PM, Christoph Hellwig wrote: On Tue, Dec 18, 2018 at 08:20:22PM +0100, Noralf Trønnes wrote: + if (!dma_map_sg(dev->dev, xen_obj->sgt->sgl, xen_obj->sgt->nents, + DMA_BIDIRECTIONAL)) { Are you using the DMA streaming API as a way to flush the

Re: [PATCH 01/10] drm/virtio: log error responses

On 12/19/18 2:26 PM, Gerd Hoffmann wrote: If we got an error response code from the host, print it to the log. Signed-off-by: Gerd Hoffmann Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/virtio/virtgpu_vq.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions

Re: [PATCH] drm/xen-front: Make shmem backed display buffer coherent

On 12/20/18 8:38 PM, Christoph Hellwig wrote: On Thu, Dec 20, 2018 at 07:35:15PM +0100, Daniel Vetter wrote: Err, with streaming DMA buffer sharing is trivial. The coherent DMA allocator is what causes all kinds of horrible hacks that can't actually work on various platforms. Hm, I thought

Re: [PATCH] drm/xen-front: Make shmem backed display buffer coherent

On 12/14/18 10:35 AM, Daniel Vetter wrote: On Fri, Dec 14, 2018 at 09:09:45AM +0200, Oleksandr Andrushchenko wrote: On 12/13/18 5:48 PM, Daniel Vetter wrote: On Thu, Dec 13, 2018 at 12:17:54PM +0200, Oleksandr Andrushchenko wrote: Daniel, could you please comment? Cross-revieweing someone

Re: [PATCH] drm/xen-front: Make shmem backed display buffer coherent

On 12/13/18 5:48 PM, Daniel Vetter wrote: On Thu, Dec 13, 2018 at 12:17:54PM +0200, Oleksandr Andrushchenko wrote: Daniel, could you please comment? Cross-revieweing someone else's stuff would scale better, fair enough I don't think I'll get around to anything before next year. I put you

Re: [Xen-devel][PATCH v2 2/3] drm/xen-front: Use Xen common shared buffer implementation

Hello, Juergen, Boris! As this DRM part of the series is the only one which needs ack/nack (and it might take quite some time to complete) could we please merge the patches 1 and 3 now that already have ack/r-b? Thank you, Oleksandr On 12/13/18 12:16 PM, Oleksandr Andrushchenko wrote: bump

Re: [Xen-devel] [PATCH v2 2/3] drm/xen-front: Use Xen common shared buffer implementation

On 12/17/18 4:52 PM, Boris Ostrovsky wrote: On 12/17/18 5:19 AM, Oleksandr Andrushchenko wrote: Hello, Juergen, Boris! As this DRM part of the series is the only one which needs ack/nack (and it might take quite some time to complete) could we please merge the patches 1 and 3 now

Re: [Xen-devel][PATCH v2 2/3] drm/xen-front: Use Xen common shared buffer implementation

Hello, Daniel! Could you please ack/nack the patch, so either we can merge the series or I can address your comments if any Thank you, Oleksandr On 11/30/18 9:42 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko Use page directory based shared buffer implementation now

Re: drm_gem_get_pages and proper flushing/coherency

On 11/26/18 2:15 PM, Oleksandr Andrushchenko wrote: Hello, all! My driver (Xen para-virtualized frontend) in some scenarios uses drm_gem_get_pages for allocating backing storage for dumb buffers. There are use-cases which showed some artifacts on the screen (modetest, other) which were worked

Re: [alsa-devel] [Xen-devel][PATCH v2 3/3] ALSA: xen-front: Use Xen common shared buffer implementation

On 12/3/18 11:36 AM, Takashi Iwai wrote: On Fri, 30 Nov 2018 08:42:05 +0100, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko Use page directory based shared buffer implementation now available as common code for Xen frontend drivers. Signed-off-by: Oleksandr Andrushchenko

Re: [PATCH 6/7] drm/xen: Don't set the dpms hook

On 12/10/18 12:03 PM, Daniel Vetter wrote: Doesn't do anything for atomic. Signed-off-by: Daniel Vetter Cc: Oleksandr Andrushchenko Cc: xen-de...@lists.xen.org --- drivers/gpu/drm/xen/xen_drm_front_conn.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/xen

Re: [Xen-devel][PATCH 1/3] xen: Introduce shared buffer helpers for page directory...

On 11/30/18 8:50 AM, Juergen Gross wrote: On 29/11/2018 12:22, Oleksandr Andrushchenko wrote: ping On 11/22/18 12:02 PM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko based frontends. Currently the frontends which implement similar code for sharing big buffers between

Re: [Xen-devel][PATCH v2 1/3] xen: Introduce shared buffer helpers for page directory...

Changes in the series since v1: - no changes to patch 1 (Xen shared code) - ALSA: fix comment from Takashi (NULL stream->buffer) - DRM: removed display buffer flush workaround (proper fix is on review [1]) Thank you, Oleksandr On 11/30/18 9:42 AM, Oleksandr Andrushchenko wrote: F

[Xen-devel][PATCH v2 2/3] drm/xen-front: Use Xen common shared buffer implementation

From: Oleksandr Andrushchenko Use page directory based shared buffer implementation now available as common code for Xen frontend drivers. Remove flushing of shared buffer on page flip as this workaround needs a proper fix. Signed-off-by: Oleksandr Andrushchenko --- drivers/gpu/drm/xen

[Xen-devel][PATCH v2 1/3] xen: Introduce shared buffer helpers for page directory...

From: Oleksandr Andrushchenko based frontends. Currently the frontends which implement similar code for sharing big buffers between frontend and backend are para-virtualized DRM and sound drivers. Both define the same way to share grant references of a data buffer with the corresponding backend

[Xen-devel][PATCH v2 3/3] ALSA: xen-front: Use Xen common shared buffer implementation

From: Oleksandr Andrushchenko Use page directory based shared buffer implementation now available as common code for Xen frontend drivers. Signed-off-by: Oleksandr Andrushchenko --- sound/xen/Kconfig | 1 + sound/xen/Makefile | 1 - sound/xen/xen_snd_front.c

Re: [Xen-devel][PATCH 1/3] xen: Introduce shared buffer helpers for page directory...

ping On 11/22/18 12:02 PM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko based frontends. Currently the frontends which implement similar code for sharing big buffers between frontend and backend are para-virtualized DRM and sound drivers. Both define the same way to share

Re: [alsa-devel] [Xen-devel][PATCH 3/3] ALSA: xen-front: Use Xen common shared buffer implementation

On 11/22/18 5:47 PM, Takashi Iwai wrote: On Thu, 22 Nov 2018 11:02:30 +0100, Oleksandr Andrushchenko wrote: @@ -214,12 +221,19 @@ static void stream_clear(struct xen_snd_front_pcm_stream_info *stream) stream->out_frames = 0; atomic_set(>hw_

Re: [Xen-devel][PATCH 2/3] drm/xen-front: Use Xen common shared buffer implementation

Hi, Daniel! On 11/22/18 4:33 PM, Daniel Vetter wrote: On Thu, Nov 22, 2018 at 12:02:29PM +0200, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko Use page directory based shared buffer implementation now available as common code for Xen frontend drivers. Signed-off-by: Oleksandr

[Xen-devel][PATCH 2/3] drm/xen-front: Use Xen common shared buffer implementation

From: Oleksandr Andrushchenko Use page directory based shared buffer implementation now available as common code for Xen frontend drivers. Signed-off-by: Oleksandr Andrushchenko --- drivers/gpu/drm/xen/Kconfig | 1 + drivers/gpu/drm/xen/Makefile | 1 - drivers

[Xen-devel][PATCH 1/3] xen: Introduce shared buffer helpers for page directory...

From: Oleksandr Andrushchenko based frontends. Currently the frontends which implement similar code for sharing big buffers between frontend and backend are para-virtualized DRM and sound drivers. Both define the same way to share grant references of a data buffer with the corresponding backend

[Xen-devel][PATCH 3/3] ALSA: xen-front: Use Xen common shared buffer implementation

From: Oleksandr Andrushchenko Use page directory based shared buffer implementation now available as common code for Xen frontend drivers. Signed-off-by: Oleksandr Andrushchenko --- sound/xen/Kconfig | 1 + sound/xen/Makefile | 1 - sound/xen/xen_snd_front.c

Re: [Xen-devel] [PATCH 5/9] drm/xen/xen_drm_front_gem.c: Convert to use vm_insert_range

p(struct file *filp, struct vm_area_struct *vma) With the above fixed, Reviewed-by: Oleksandr Andrushchenko ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Xen-devel] [PATCH 5/9] drm/xen/xen_drm_front_gem.c: Convert to use vm_insert_range

On 11/19/18 12:42 PM, Souptick Joarder wrote: On Mon, Nov 19, 2018 at 3:22 PM Oleksandr Andrushchenko wrote: On 11/15/18 5:49 PM, Souptick Joarder wrote: Convert to use vm_insert_range() to map range of kernel memory to user vma. Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox

drm_gem_get_pages and proper flushing/coherency

Hello, all! My driver (Xen para-virtualized frontend) in some scenarios uses drm_gem_get_pages for allocating backing storage for dumb buffers. There are use-cases which showed some artifacts on the screen (modetest, other) which were worked around by flushing pages of the buffer on page flip

[PATCH] drm/xen-front: Make shmem backed display buffer coherent

From: Oleksandr Andrushchenko When GEM backing storage is allocated with drm_gem_get_pages the backing pages may be cached, thus making it possible that the backend sees only partial content of the buffer which may lead to screen artifacts. Make sure that the frontend's memory is coherent

Re: [PATCH] drm/virtio: drop prime import/export callbacks

On 1/10/19 1:15 PM, Gerd Hoffmann wrote: Also set prime_handle_to_fd and prime_fd_to_handle to NULL, so drm will not advertive DRM_PRIME_CAP_{IMPORT,EXPORT} to userspace. Signed-off-by: Gerd Hoffmann Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/virtio/virtgpu_drv.h | 4

Re: [PATCH v4 08/16] drm/bochs: atomic: use suspend/resume helpers

On 1/11/19 7:37 AM, Gerd Hoffmann wrote: Switch to atomic helpers: drm_mode_config_helper_suspend/resume(). Signed-off-by: Gerd Hoffmann Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/bochs/bochs_drv.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff

Re: [PATCH 5/9] drm/xen/xen_drm_front_gem.c: Convert to use vm_insert_range

On 1/11/19 5:10 PM, Souptick Joarder wrote: Convert to use vm_insert_range() to map range of kernel memory to user vma. Signed-off-by: Souptick Joarder Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/xen/xen_drm_front_gem.c | 18 +- 1 file changed, 5 insertions

Re: [PATCH] drm/xen-front: Make shmem backed display buffer coherent

On 12/18/18 9:20 PM, Noralf Trønnes wrote: Den 27.11.2018 11.32, skrev Oleksandr Andrushchenko: From: Oleksandr Andrushchenko When GEM backing storage is allocated with drm_gem_get_pages the backing pages may be cached, thus making it possible that the backend sees only partial content

Re: [PATCH] drm/bochs: add edid present check

ointer arithmetic here? + return -1; + kfree(bochs->edid); bochs->edid = drm_do_get_edid(>connector, bochs_get_edid_block, bochs); With the above fixed: Reviewed-by: Oleksandr Andrushchenko ___ d

Re: [PATCH 02/14] drm/bochs: split bochs_hw_setmode

if (WARN_ON(crtc->primary->fb == NULL)) return -EINVAL; - bochs_hw_setmode(bochs, mode, crtc->primary->fb->format); + bochs_hw_setmode(bochs, mode); + bochs_hw_setformat(bochs, crtc->primary->fb->format); I was about to suggest that you

Re: [PATCH] drm/xen-front: Make shmem backed display buffer coherent

On 12/19/18 3:14 PM, Gerd Hoffmann wrote: Hi, +    mapping = xen_obj->base.filp->f_mapping; +    mapping_set_gfp_mask(mapping, GFP_USER | __GFP_DMA32); Let's see if I understand what you're doing: Here you say that the pages should be DMA accessible for devices that can only see 4GB.

Re: [PATCH 01/14] drm/bochs: encoder cleanup

) encoder->possible_crtcs = 0x1; drm_encoder_init(dev, encoder, _encoder_encoder_funcs, DRM_MODE_ENCODER_DAC, NULL); - drm_encoder_helper_add(encoder, _encoder_helper_funcs); } Reviewed-by: Oleksandr Andrushche

Re: [PATCH 03/14] drm/bochs: atomic: add atomic_flush+atomic_enable callbacks.

Hi, Gerd! On 12/19/18 1:51 PM, Gerd Hoffmann wrote: Conversion to atomic modesetting, step one. Add atomic crtc helper callbacks. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_kms.c | 25 + 1 file changed, 25 insertions(+) diff --git

Re: [PATCH] drm/bochs: add edid present check

On 12/19/18 5:21 PM, Gerd Hoffmann wrote: Hi, You could probably have a comment here explaining the magic below (just like in the commit message to ease the task of understanding while reading the code why 2 of 8 bytes of the EDID header is checked and why it is all needed). Of course one

Re: [PATCH -next] drm/xen-front: Drop pointless static qualifier in fb_destroy()

On 1/26/19 2:05 PM, YueHaibing wrote: > There is no need to have the 'struct drm_framebuffer *fb' variable > static since new value always be assigned before use it. > > Signed-off-by: YueHaibing Good catch, thank you! Reviewed-by: Oleksandr Andrushchenko > --- > d

Re: [PATCH] xen, fbfront: mark expected switch fall-through

+Xen-devel list On 2/27/19 10:53 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: drivers/video/fbdev/xen-fbfront.c: In function ‘xenfb_backend_changed’:

Re: [PATCH v2 2/2] drm/drv: drm_dev_unplug(): Move out drm_dev_put() call

rm_front.c +++ b/drivers/gpu/drm/xen/xen_drm_front.c @@ -582,6 +582,7 @@ static void xen_drm_drv_fini(struct xen_drm_front_info *front_info) drm_kms_helper_poll_fini(dev); drm_dev_unplug(dev); + drm_dev_put(dev); Acked-by: Oleksandr Andrushchenko front_info->dr

[Xen-devel][PATCH] drm/xen-front: Fix mmap attributes for display buffers

From: Oleksandr Andrushchenko When GEM backing storage is allocated those are normal pages, so there is no point using pgprot_writecombine while mmaping. This fixes mismatch of buffer pages' memory attributes between the frontend and backend which may cause screen artifacts. Fixes: c575b7eeb89f

Re: [Xen-devel] [PATCH v2] drm/xen-front: Make shmem backed display buffer coherent

On 1/24/19 5:02 PM, Julien Grall wrote: > > > On 24/01/2019 14:34, Oleksandr Andrushchenko wrote: >> Hello, Julien! > > Hi, > >> On 1/22/19 1:44 PM, Julien Grall wrote: >>> >>> >>> On 1/22/19 10:28 AM, Oleksandr Andrushchenko wrote: &g

Re: [Xen-devel] [PATCH v2] drm/xen-front: Make shmem backed display buffer coherent

Dropped in favor of https://lkml.org/lkml/2019/1/29/910 On 1/24/19 5:02 PM, Julien Grall wrote: > > > On 24/01/2019 14:34, Oleksandr Andrushchenko wrote: >> Hello, Julien! > > Hi, > >> On 1/22/19 1:44 PM, Julien Grall wrote: >>> >>> >&g

Re: [Xen-devel][PATCH] drm/xen-front: Fix mmap attributes for display buffers

On 1/29/19 9:07 PM, Julien Grall wrote: > Hi Oleksandr, > > On 1/29/19 3:04 PM, Oleksandr Andrushchenko wrote: >> From: Oleksandr Andrushchenko >> >> When GEM backing storage is allocated those are normal pages, >> so there is no point using pgprot_writecom

Re: [Xen-devel] [PATCH v2] drm/xen-front: Make shmem backed display buffer coherent

Hello, Julien! Sorry for the late reply - it took quite some time to collect the data requested. On 1/22/19 1:44 PM, Julien Grall wrote: > > > On 1/22/19 10:28 AM, Oleksandr Andrushchenko wrote: >> Hello, Julien! > > Hi, > >> On 1/21/19 7:09 PM, Julien Gral

Re: [PATCH -next] drm/xen-front: Drop pointless static qualifier in fb_destroy()

On 1/28/19 8:36 AM, Oleksandr Andrushchenko wrote: > On 1/26/19 2:05 PM, YueHaibing wrote: >> There is no need to have the 'struct drm_framebuffer *fb' variable >> static since new value always be assigned before use it. >> >> Signed-off-by: YueHaibing > Goo

<    1   2   3   4   5   >