Re: vc4: NULL pointer dereference in drm_client_dev_hotplug

2018-10-03 Thread Peter Robinson
Hi Stefan, > [add Peter and Andreas] > > > Am 02.10.2018 um 10:44 schrieb Daniel Vetter: > > On Mon, Oct 01, 2018 at 06:21:23PM +0200, Stefan Wahren wrote: > >> Hi, > >> > >>> Sergey Suloev hat am 1. Oktober 2018 um 12:17 > >>> geschrieben: > >>> > >>> > >>> Hi, Stefan, > >>> > >>> > >>> On

[PATCH] gpu/drm/v3d: Add ARCH_BCM2835 to DRM_V3D Kconfig

2019-12-18 Thread Peter Robinson
On arm64 the config ARCH_BCM doesn't exist so to be able to build for platforms such as the Raspberry Pi 4 we need to add ARCH_BCM2835 similar to what has been done on vc4. Signed-off-by: Peter Robinson --- drivers/gpu/drm/v3d/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] video: fbdev: simplefb: Fix info message during probe

2020-12-29 Thread Peter Robinson
(ptrval) Drop the extraneous bits to clean up the message: simple-framebuffer 3ea9b000.framebuffer: framebuffer at 0x3ea9b000, 0x12c000 bytes Signed-off-by: Peter Robinson --- drivers/video/fbdev/simplefb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/video

Re: [PATCH v2] drm/rockchip: remove existing generic drivers to take over the device

2021-05-17 Thread Peter Robinson
red by the rockchip DRM driver: > > [ 40.752420] fb0: switching to rockchip-drm-fb from EFI VGA > > Signed-off-by: Javier Martinez Canillas Tested-by: Peter Robinson Tested on Pinebook Pro (eDP), Rock960 (HDMI) and Firefly3399. > --- > > Changes in v2: > - Move drm

[PATCH] drm/rockchip: cdn-dp-core: add MODULE_FIRMWARE macro

2021-05-07 Thread Peter Robinson
The CDP DP component of the rockchip GPU driver requires firmware so define MODULE_FIRMWARE for rockchip/dptx.bin so the details are available in the module info. Signed-off-by: Peter Robinson --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers

Re: [PATCH] drm/simpledrm: Add "panel orientation" property on non-upright mounted LCD panels

2022-02-23 Thread Peter Robinson
On Wed, Feb 23, 2022 at 11:25 AM Hans de Goede wrote: > > Hi, > > On 2/22/22 20:14, Thomas Zimmermann wrote: > > Hi > > > > Am 21.02.22 um 23:00 schrieb Hans de Goede: > >> Some devices use e.g. a portrait panel in a standard laptop casing made > >> for landscape panels. efifb calls

Re: [PATCH 0/2] drm/nvdla: Add driver support for NVDLA

2022-04-25 Thread Peter Robinson
On Tue, Apr 19, 2022 at 3:08 PM Cai Huoqing wrote: > > The NVIDIA Deep Learning Accelerator (NVDLA) is an open source IP > which is integrated into NVIDIA Jetson AGX Xavier, > so add driver support for this accelerator. > > NVDLA introduce: > http://nvdla.org/primer.html > > User mode driver: >

Re: [PATCH v5 4/6] ARM: dts: bcm2711: Enable V3D

2022-06-02 Thread Peter Robinson
Hi Stefan, > Am 01.06.22 um 13:02 schrieb Peter Robinson: > > This adds the entry for V3D for bcm2711 (used in the Raspberry Pi 4) > > and the associated firmware clock entry. > > > > Signed-off-by: Nicolas Saenz Julienne > > Signed-off-by: Peter Robin

[PATCH v5 1/6] dt-bindings: gpu: v3d: Add BCM2711's compatible

2022-06-01 Thread Peter Robinson
BCM2711, Raspberry Pi 4's SoC, contains a V3D core. So add its specific compatible to the bindings. Signed-off-by: Nicolas Saenz Julienne Signed-off-by: Peter Robinson --- Changes since v5: - Change compatible to align downstream and othee HW, reorder to suit Documentation/devicetree/bindings

[PATCH v5 2/6] drm/v3d: Get rid of pm code

2022-06-01 Thread Peter Robinson
n with V3D on BCM2711 (Raspberry Pi 4), get rid of the PM code. PM will be reinstated once we figure out the underlying issues. Signed-off-by: Nicolas Saenz Julienne Signed-off-by: Peter Robinson --- Changes since v5: - Rebase Changes since v3: - Minor updates for rebase drivers/gpu/drm/v3d/v3d_debu

[PATCH v5 3/6] drm/v3d: Add support for bcm2711

2022-06-01 Thread Peter Robinson
Add compatible string and Kconfig options for bcm2711. Signed-off-by: Nicolas Saenz Julienne Signed-off-by: Peter Robinson --- Changes since v5: - Change compatible to align downstream and othee HW, reorder to suit drivers/gpu/drm/v3d/Kconfig | 2 +- drivers/gpu/drm/v3d/v3d_drv.c | 1 + 2

[PATCH v5 0/6] Raspberry PI 4 V3D enablement

2022-06-01 Thread Peter Robinson
into an independent set - Rebase to 5.18 - Individual changes in patches [1] https://www.spinics.net/lists/arm-kernel/msg980342.html Nicolas Saenz Julienne (1): arm64: config: Enable DRM_V3D Peter Robinson (5): dt-bindings: gpu: v3d: Add BCM2711's compatible drm/v3d: Get rid of pm code drm/v3d: Add

[PATCH v5 4/6] ARM: dts: bcm2711: Enable V3D

2022-06-01 Thread Peter Robinson
This adds the entry for V3D for bcm2711 (used in the Raspberry Pi 4) and the associated firmware clock entry. Signed-off-by: Nicolas Saenz Julienne Signed-off-by: Peter Robinson --- Changes since v5: - Move the firmware clock to bcm2711-rpi.dtsi arch/arm/boot/dts/bcm2711-rpi.dtsi | 4

[PATCH v5 5/6] ARM: configs: Enable DRM_V3D

2022-06-01 Thread Peter Robinson
BCM2711, the SoC used on the Raspberry Pi 4 has a different 3D render GPU IP than its predecessors. Enable it it on multi v7 and bcm2835 configs. Signed-off-by: Nicolas Saenz Julienne Signed-off-by: Peter Robinson --- Changes since v5: - Added to bcm2835_defconfig arch/arm/configs

[PATCH v5 6/6] arm64: config: Enable DRM_V3D

2022-06-01 Thread Peter Robinson
From: Nicolas Saenz Julienne BCM2711, the SoC used on the Raspberry Pi 4 has a different GPU than its predecessors. Enable it. Signed-off-by: Nicolas Saenz Julienne Signed-off-by: Peter Robinson --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64

Re: [PATCH 0/2] drm: A couple of fixes for drm_copy_field() helper function

2022-07-01 Thread Peter Robinson
On Fri, Jul 1, 2022 at 1:08 PM Javier Martinez Canillas wrote: > > Hello, > > Peter Robinson reported me a kernel bug in one of his aarch64 test boards > and even though I was not able to reproduce it, I think that figured out > what the problem was. It seems the cause is

Re: drm/vc4: module dysfunctional on Raspberry Pi 3B as of 5.18.0

2022-06-08 Thread Peter Robinson
Hi Maxime, > > > As of Linux 5.18.0, module vc4 apparently isn't working on Raspberry Pi > > > 3B any more. > > > > > > If a monitor is attached to the device, the boot messages show up as > > > usual, but right when KMS starts, the screen turns black. Similarly, the > > > screen also turns black

Re: drm/vc4: module dysfunctional on Raspberry Pi 3B as of 5.18.0

2022-06-08 Thread Peter Robinson
Hi Peter, Adding Stefan and Maxime > As of Linux 5.18.0, module vc4 apparently isn't working on Raspberry Pi > 3B any more. > > If a monitor is attached to the device, the boot messages show up as > usual, but right when KMS starts, the screen turns black. Similarly, the > screen also turns

[PATCH v6 6/6] arm64: config: Enable DRM_V3D

2022-06-03 Thread Peter Robinson
From: Nicolas Saenz Julienne BCM2711, the SoC used on the Raspberry Pi 4 has a different GPU than its predecessors. Enable it. Signed-off-by: Nicolas Saenz Julienne Signed-off-by: Peter Robinson Reviewed-by: Stefan Wahren Reviewed-by: Javier Martinez Canillas --- arch/arm64/configs

[PATCH v6 4/6] ARM: dts: bcm2711: Enable V3D

2022-06-03 Thread Peter Robinson
This adds the entry for V3D for bcm2711 (used in the Raspberry Pi 4) and the associated firmware clock entry. Signed-off-by: Nicolas Saenz Julienne Signed-off-by: Peter Robinson Reviewed-by: Javier Martinez Canillas --- Changes since v5: - Update the compatible to match the other updated ones

[PATCH v6 5/6] ARM: configs: Enable DRM_V3D

2022-06-03 Thread Peter Robinson
BCM2711, the SoC used on the Raspberry Pi 4 has a different 3D render GPU IP than its predecessors. Enable it it on multi v7 and bcm2835 configs. Signed-off-by: Nicolas Saenz Julienne Signed-off-by: Peter Robinson Reviewed-by: Stefan Wahren Reviewed-by: Javier Martinez Canillas --- Changes

[PATCH v6 0/6] Raspberry PI 4 V3D enablement

2022-06-03 Thread Peter Robinson
: Enable DRM_V3D Peter Robinson (5): dt-bindings: gpu: v3d: Add BCM2711's compatible drm/v3d: Get rid of pm code drm/v3d: Add support for bcm2711 ARM: dts: bcm2711: Enable V3D ARM: configs: Enable DRM_V3D .../devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 1 + arch/arm/boot/dts/bcm2711

[PATCH v6 2/6] drm/v3d: Get rid of pm code

2022-06-03 Thread Peter Robinson
n with V3D on BCM2711 (Raspberry Pi 4), get rid of the PM code. PM will be reinstated once we figure out the underlying issues. Signed-off-by: Nicolas Saenz Julienne Signed-off-by: Peter Robinson Reviewed-by: Javier Martinez Canillas --- Changes since v4: - Rebase Changes since v3: - Minor updates

[PATCH v6 1/6] dt-bindings: gpu: v3d: Add BCM2711's compatible

2022-06-03 Thread Peter Robinson
BCM2711, Raspberry Pi 4's SoC, contains a V3D core. So add its specific compatible to the bindings. Signed-off-by: Nicolas Saenz Julienne Signed-off-by: Peter Robinson Reviewed-by: Stefan Wahren Reviewed-by: Javier Martinez Canillas Acked-by: Rob Herring --- Changes since v4: - Change

[PATCH v6 3/6] drm/v3d: Add support for bcm2711

2022-06-03 Thread Peter Robinson
Add compatible string and Kconfig options and help for bcm2711. Signed-off-by: Nicolas Saenz Julienne Signed-off-by: Peter Robinson Reviewed-by: Stefan Wahren Reviewed-by: Javier Martinez Canillas --- Changes since v5: - Update help text to cover all supported SoCs Changes since v4: - Change

Re: drm/vc4: module dysfunctional on Raspberry Pi 3B as of 5.18.0

2022-06-09 Thread Peter Robinson
> > > > > > As of Linux 5.18.0, module vc4 apparently isn't working on > > > > > > Raspberry Pi > > > > > > 3B any more. > > > > > > > > > > > > If a monitor is attached to the device, the boot messages show up as > > > > > > usual, but right when KMS starts, the screen turns black. > > > > > >

Re: drm/vc4: module dysfunctional on Raspberry Pi 3B as of 5.18.0

2022-06-09 Thread Peter Robinson
> >>> As of Linux 5.18.0, module vc4 apparently isn't working on Raspberry Pi > >>> 3B any more. > >>> > >>> If a monitor is attached to the device, the boot messages show up as > >>> usual, but right when KMS starts, the screen turns black. Similarly, the > >>> screen also turns black when the

Re: drm/vc4: module dysfunctional on Raspberry Pi 3B as of 5.18.0

2022-06-10 Thread Peter Robinson
On Thu, Jun 9, 2022 at 10:33 PM Stefan Wahren wrote: > > Hi Peter, > > Am 09.06.22 um 13:52 schrieb Peter Robinson: > >>>>> As of Linux 5.18.0, module vc4 apparently isn't working on Raspberry Pi > >>>>> 3B any more. > >>>>> >

Re: [PATCH v2] drm/vc4: hdmi: Fix HSM clock too low on Pi4

2022-10-22 Thread Peter Robinson
a register access, and the modeset part will > set its requirement for the current resolution. And we let the CCF do > the coordination. > > It's not an ideal solution, but it's fairly unintrusive and doesn't > really change any part of the logic so it looks like a rather safe fix. > &

[PATCH] drm: rcar-du: depend on ARCH_RENESAS for components on that SoC

2023-01-07 Thread Peter Robinson
There's a few components in the rcar-du drm directory that don't make sense to be slectedable if ARCH_RENESAS isn't because they are part of those SoCs so add a dependency and add compile check to ensure they're still tested. Signed-off-by: Peter Robinson --- drivers/gpu/drm/rcar-du/Kconfig | 3

Re: [PATCH] drm: rcar-du: depend on ARCH_RENESAS for components on that SoC

2023-01-07 Thread Peter Robinson
Hi Laurent, > Thank you for the patch. > > On Sun, Jan 08, 2023 at 04:31:47AM +0000, Peter Robinson wrote: > > There's a few components in the rcar-du drm directory that > > don't make sense to be slectedable if ARCH_RENESAS isn't because > > s/slectedable/selectable/ &

[PATCH v2] drm: rcar-du: depend on DRM_RCAR_DU for components on that SoC

2023-01-07 Thread Peter Robinson
There's a few components in the rcar-du drm directory that don't make sense to be selectable if DRM_RCAR_DU isn't because they are part of the IP block so add a dependency and add compile check to ensure they're still tested. Signed-off-by: Peter Robinson --- v2: - typo fix in commit message

Re: [PATCH v2] drm: rcar-du: depend on DRM_RCAR_DU for components on that SoC

2023-01-18 Thread Peter Robinson
Hi Laurent, On Wed, Jan 18, 2023 at 7:16 PM Laurent Pinchart wrote: > > Hi Peter, > > Thank you for the patch. > > On Sun, Jan 08, 2023 at 06:04:01AM +0000, Peter Robinson wrote: > > There's a few components in the rcar-du drm directory that > > don't make sense t

[PATCH] drm/msm/adreno: Add some missing MODULE_FIRMWARE entries

2024-06-04 Thread Peter Robinson
: Add Adreno A690 support") Fixes: 18397519cb622 ("drm/msm/adreno: Add A702 support") Fixes: 3e7042ba87da ("drm/msm/adreno: Add ZAP firmware name to A635") Signed-off-by: Peter Robinson --- drivers/gpu/drm/msm/adreno/adreno_device.c | 3 +++ 1 file changed, 3 insertions(+)

Re: [PATCH] drm/msm/adreno: Add some missing MODULE_FIRMWARE entries

2024-06-04 Thread Peter Robinson
On Tue, 4 Jun 2024 at 23:18, Dmitry Baryshkov wrote: > > On Wed, 5 Jun 2024 at 00:40, Peter Robinson wrote: > > > > Add missing MODULE_FIRMWARE for firmware in linux-firmware, > > this is needed for automatically adding firmware to things > > like initrds when th