Re: [radeon-alex:drm-next-4.18-wip 44/78] drivers/gpu/drm/amd/amdgpu/soc15.c:680:3-24: duplicated argument to & or | (fwd)

2018-05-27 Thread Quan, Evan
Thanks Julia. It's a typo. And a patch had been sent out to fix it. Regards, Evan From: Julia Lawall <julia.law...@lip6.fr> Sent: Saturday, May 19, 2018 4:50:04 AM To: Quan, Evan Cc: Deucher, Alexander; dri-devel@lists.freedesktop.org; kbuild-...@

RE: [PATCH v2] tests/amdgpu: add deadlock test for sdma

2019-03-05 Thread Quan, Evan
Reviewed-and-tested-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of Cui, > Flora > Sent: Wednesday, March 06, 2019 2:37 PM > To: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Cui, Flora > Subject: [PATCH v2] tests/amdgpu: add deadlock test for

RE: [PATCH] drm/amd/powerplay: remove spurious semicolon

2019-05-04 Thread Quan, Evan
Reviewed-by: Evan Quan > -Original Message- > From: Andrea Righi > Sent: 2019年5月4日 0:56 > To: Deucher, Alexander ; Koenig, Christian > ; Zhou, David(ChunMing) > > Cc: Rex Zhu ; Wu, Hersen ; > Quan, Evan ; amd-...@lists.freedesktop.org; dri- > de...@lists

RE: [PATCH][drm-next] drm/amd/powerplay: remove redundant duplicated return check

2019-08-06 Thread Quan, Evan
Thanks! Reviewed-by: Evan Quan > -Original Message- > From: Colin King > Sent: Monday, August 05, 2019 6:30 PM > To: Rex Zhu ; Quan, Evan ; > Deucher, Alexander ; Koenig, Christian > ; Zhou, David(ChunMing) > ; David Airlie ; Daniel Vetter > ; amd-...@lists.fr

RE: [PATCH] drm/amd/powerplay: Zero initialize some variables

2019-08-04 Thread Quan, Evan
Thanks Nathan. The patch is reviewed-by: Evan Quan > -Original Message- > From: Nathan Chancellor > Sent: Monday, August 05, 2019 4:37 AM > To: Quan, Evan ; Deucher, Alexander > ; Koenig, Christian > ; Zhou, David(ChunMing) > > Cc: amd-...@lists.fr

RE: [PATCH 6/7] drm/amd/powerplay: Use proper enums in vega20_print_clk_levels

2019-07-15 Thread Quan, Evan
Sun peng (Leo) ; Rex Zhu ; > Quan, Evan ; David Airlie ; Daniel > Vetter ; amd-gfx list ; dri- > devel ; Linux Kernel Mailing List ker...@vger.kernel.org>; clang-built-linux li...@googlegroups.com>; Wang, Kevin(Yang) > Subject: Re: [PATCH 6/7] drm/amd/powerplay: Use proper enums in

RE: [PATCH 0/2] remove some set but not used variables in hwmgr

2019-11-10 Thread Quan, Evan
Series is reviewed-by: Evan Quan > -Original Message- > From: zhengbin > Sent: Monday, November 11, 2019 11:46 AM > To: rex....@amd.com; Quan, Evan ; Deucher, > Alexander ; Koenig, Christian > ; Zhou, David(ChunMing) > ; airl...@linux.ie; dan.

RE: [PATCH v2] drm/amd/powerplay: return errno code to caller when error occur

2019-11-18 Thread Quan, Evan
Reviewed-by: Evan Quan > -Original Message- > From: Chen Wandun > Sent: Monday, November 18, 2019 4:04 PM > To: Quan, Evan ; Deucher, Alexander > ; amd-...@lists.freedesktop.org; linux- > ker...@vger.kernel.org; dri-devel@lists.freedesktop.org > Cc: chenwan...

RE: [PATCH][next] drm/amdgpu/powerplay: fix dereference before null check of pointer hwmgr

2019-11-17 Thread Quan, Evan
Reviewed-by: Evan Quan -Original Message- From: Colin King Sent: Friday, November 15, 2019 5:48 PM To: Rex Zhu ; Quan, Evan ; Deucher, Alexander ; Koenig, Christian ; Zhou, David(ChunMing) ; David Airlie ; Daniel Vetter ; amd-...@lists.freedesktop.org; dri-devel

RE: [PATCH] drm/amd/powerplay: remove variable 'result' set but not used

2019-11-17 Thread Quan, Evan
Thanks. But it's better to return the 'result' out on 'result != 0'. Regards, Evan -Original Message- From: Chen Wandun Sent: Saturday, November 16, 2019 11:43 AM To: Deucher, Alexander ; Quan, Evan ; amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux-ker

RE: [PATCH] MAINTAINERS: Drop Rex Zhu for amdgpu powerplay

2019-11-24 Thread Quan, Evan
Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Saturday, November 23, 2019 3:19 AM > To: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH] MAINTAINERS: Drop Rex Zhu for amdgpu

RE: [PATCH -next] drm/amd/powerplay: Use bitwise instead of arithmetic operator for flags

2020-02-23 Thread Quan, Evan
Thanks. Reviewed-by: Evan Quan -Original Message- From: Chen Zhou Sent: Friday, February 21, 2020 8:22 PM To: Quan, Evan ; Deucher, Alexander ; Koenig, Christian ; Zhou, David(ChunMing) ; airl...@linux.ie; dan...@ffwll.ch Cc: Feng, Kenneth ; amd-...@lists.freedesktop.org; dri-devel

RE: [PATCH] drm/amdgpu: Add missing '\n' in log messages

2020-04-12 Thread Quan, Evan
Reviewed-by: Evan Quan -Original Message- From: Christophe JAILLET Sent: Saturday, April 11, 2020 10:04 PM To: Deucher, Alexander ; Koenig, Christian ; Zhou, David(ChunMing) ; airl...@linux.ie; dan...@ffwll.ch; Zhang, Hawking ; Quan, Evan ; Grodzovsky, Andrey ; Liu, Monk ; Russell

RE: [PATCH -next] drm/amd/powerplay: remove duplicate include

2020-08-19 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Evan Quan -Original Message- From: Wang Hai Sent: Wednesday, August 19, 2020 7:34 PM To: Quan, Evan ; Deucher, Alexander ; Koenig, Christian ; airl...@linux.ie; dan...@ffwll.ch Cc: amd-...@lists.freedesktop.org; dri

RE: [PATCH -next] amdgpu: fix Documentation builds for pm/ file movement

2020-08-23 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Thanks for fixing this. The patch is reviewed-by: Evan Quan BR Evan -Original Message- From: Randy Dunlap Sent: Monday, August 24, 2020 6:36 AM To: dri-devel ; LKML ; amd-...@lists.freedesktop.org; Deucher, Alexander Cc: Quan

RE: [PATCH v1] powerplay:hwmgr - modify the return value

2020-09-16 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Thanks. Reviewed-by: Evan Quan -Original Message- From: Xiaoliang Pang Sent: Thursday, September 17, 2020 11:46 AM To: Quan, Evan ; Deucher, Alexander ; Koenig, Christian ; airl...@linux.ie; dan...@ffwll.ch; Feng, Kenneth

RE: [PATCH AUTOSEL 5.4 265/330] drm/amd/powerplay: try to do a graceful shutdown on SW CTF

2020-09-18 Thread Quan, Evan
To: linux-ker...@vger.kernel.org; sta...@vger.kernel.org Cc: Quan, Evan ; Deucher, Alexander ; Sasha Levin ; dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 5.4 265/330] drm/amd/powerplay: try to do a graceful shutdown on SW CTF From: Evan Quan [ Upstream commit

RE: [PATCH] drm/amd/powerplay: fix a crash when overclocking Vega M

2020-07-17 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Evan Quan -Original Message- From: Qiu Wenbo Sent: Friday, July 17, 2020 3:10 PM To: Quan, Evan ; amd-...@lists.freedesktop.org Cc: Qiu Wenbo ; Deucher, Alexander ; Koenig, Christian ; Zhou, David(ChunMing) ; David

RE: [PATCH] drm/radeon: Fix reference count leaks caused by pm_runtime_get_sync

2020-06-15 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Acked-by: Evan Quan -Original Message- From: amd-gfx On Behalf Of Aditya Pakki Sent: Sunday, June 14, 2020 10:21 AM To: pakki...@umn.edu Cc: wu000...@umn.edu; David Airlie ; k...@umn.edu; linux-ker...@vger.kernel.org;

RE: [PATCH] drm/amd/powerplay: fix spelling mistake "smu_state_memroy_block" -> "smu_state_memory_block"

2020-11-23 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Evan Quan -Original Message- From: Colin King Sent: Monday, November 23, 2020 6:54 PM To: Deucher, Alexander ; Koenig, Christian ; David Airlie ; Daniel Vetter ; Quan, Evan ; Wang, Kevin(Yang) ; Gui, Jack ; amd

RE: [PATCH -next] drm/amdgpu/swsmu: Remove unused static struct 'navi10_i2c_algo'

2020-10-29 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Other used APIs should be also dropped together. navi10_i2c_func() navi10_i2c_xfer() navi10_i2c_write_data() navi10_i2c_read_data() Regards, Evan -Original Message- From: amd-gfx On Behalf Of Zou Wei Sent: Thursday, October 29, 2020

RE: [PATCH] gpu: drm: swsmu: fix error return code of smu_v11_0_set_allowed_mask()

2021-03-04 Thread Quan, Evan
[AMD Public Use] Thanks. Reviewed-by: Evan Quan -Original Message- From: Jia-Ju Bai Sent: Friday, March 5, 2021 11:54 AM To: Deucher, Alexander ; Koenig, Christian ; airl...@linux.ie; dan...@ffwll.ch; Quan, Evan ; Zhang, Hawking ; Wang, Kevin(Yang) ; Gao, Likun Cc: amd

RE: [PATCH v2] drm/amdgpu/swsmu/navi1x: Remove unnecessary conversion to bool

2021-02-21 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Evan Quan -Original Message- From: amd-gfx On Behalf Of Jiapeng Chong Sent: Saturday, February 20, 2021 10:55 AM To: Deucher, Alexander Cc: Jiapeng Chong ; airl...@linux.ie; linux-ker...@vger.kernel.org;

RE: [PATCH v3] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-17 Thread Quan, Evan
->gfx.gfx_off_req_count--; > + } else { > + adev->gfx.gfx_off_req_count++; > + } > > if (enable && !adev->gfx.gfx_off_state && !adev- > >gfx.gfx_off_req_count) { > schedule_delayed_work(>gfx.gfx_off_delay_work, > GFX_OFF_DELAY_ENABLE)

RE: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-17 Thread Quan, Evan
[AMD Official Use Only] Thanks! This seems fine to me. Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of > Michel Dänzer > Sent: Tuesday, August 17, 2021 4:23 PM > To: Deucher, Alexander ; Koenig, Christian > > Cc: Liu, Leo ; Zhu, James ; amd- >

RE: [PATCH 1/4] drm/amdgpu: Move flush VCE idle_work during HW fini

2021-08-24 Thread Quan, Evan
[AMD Official Use Only] Hi Andrey, I sent out a similar patch set to address S3 issue. And I believe it should be able to address the issue here too. https://lists.freedesktop.org/archives/amd-gfx/2021-August/067972.html https://lists.freedesktop.org/archives/amd-gfx/2021-August/067967.html BR

RE: [PATCH 1/4] drm/amdgpu: Move flush VCE idle_work during HW fini

2021-08-24 Thread Quan, Evan
[AMD Official Use Only] Just landed. Thanks, Evan > -Original Message- > From: Grodzovsky, Andrey > Sent: Wednesday, August 25, 2021 11:20 AM > To: Quan, Evan ; dri-devel@lists.freedesktop.org; > amd-...@lists.freedesktop.org > Cc: ckoenig.leichtzumer...@gmail.com >

RE: [PATCH] drm/amdgpu: Make use of the helper macro SET_RUNTIME_PM_OPS()

2021-08-29 Thread Quan, Evan
[AMD Official Use Only] Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of Cai > Huoqing > Sent: Saturday, August 28, 2021 4:41 PM > To: Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; > airl...@linux.ie; dan...@ffwll.ch > Cc:

RE: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-16 Thread Quan, Evan
[AMD Official Use Only] Hi Michel, The patch seems reasonable to me(especially the cancel_delayed_work_sync() part). However, can you explain more about the code below? What's the race issue here exactly? + /* mutex_lock could deadlock with cancel_delayed_work_sync in

RE: [RFC][PATCH] drm/amdgpu/powerplay/smu10: Add custom profile

2021-09-13 Thread Quan, Evan
11:11 PM > To: Daniel Gomez ; Huang, Ray ; > Quan, Evan ; Zhu, Changfeng > > Cc: amd-gfx list ; Maling list - DRI > developers ; Daniel Gomez > ; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui > Subject: Re: [RFC][PATCH] drm/amdgpu/powerplay/smu10: Add custom > prof

RE: [PATCH 1/2] MAINTAINERS: fix up entry for AMD Powerplay

2021-09-17 Thread Quan, Evan
[AMD Official Use Only] Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Saturday, September 18, 2021 12:16 AM > To: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH 1/2]

RE: [PATCH 2/2] drm/amdgpu: Use mod_delayed_work in JPEG/UVD/VCE/VCN ring_end_use hooks

2021-08-11 Thread Quan, Evan
[AMD Official Use Only] Different from the 1st patch(for amdgpu_gfx_off_ctrl) of the series, "cancel_delayed_work_sync(>uvd.idle_work)" will be called on like amdgpu_uvd_ring_begin_use(). Under this case, does it make any difference from previous implementation "schedule_delayed_work"?

RE: [PATCH 1/2] drm/amdgpu: Use mod_delayed_work in amdgpu_gfx_off_ctrl

2021-08-11 Thread Quan, Evan
[AMD Official Use Only] Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of > Michel Dänzer > Sent: Thursday, August 12, 2021 12:52 AM > To: Deucher, Alexander ; Koenig, Christian > > Cc: Liu, Leo ; Zhu, James ; amd- > g...@lists.freedesktop.org;

RE: Regression from 3c196f056666 ("drm/amdgpu: always reset the asic in suspend (v2)") on suspend?

2022-02-14 Thread Quan, Evan
[AMD Official Use Only] > -Original Message- > From: Salvatore Bonaccorso On Behalf > Of Salvatore Bonaccorso > Sent: Sunday, February 13, 2022 2:24 AM > To: Deucher, Alexander > Cc: Dominique Dumont ; 1005...@bugs.debian.org; > Tuikov, Luben ; Quan, Evan >

RE: [PATCH] gpu/amd: vega10_hwmgr: fix inappropriate private variable name

2022-02-25 Thread Quan, Evan
[AMD Official Use Only] Thanks! The patch is reviewed-by: Evan Quan > -Original Message- > From: Meng Tang > Sent: Friday, February 25, 2022 5:47 PM > To: airl...@linux.ie; dan...@ffwll.ch > Cc: Quan, Evan ; Deucher, Alexander > ; Koenig, Christian > ; P

RE: [PATCH] drm/amd/pm: fix error handling

2022-02-06 Thread Quan, Evan
[AMD Official Use Only] Reviewed-by: Evan Quan > -Original Message- > From: t...@redhat.com > Sent: Saturday, February 5, 2022 11:00 PM > To: Quan, Evan ; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; > airl...@linux.ie; dan...@ffwll.ch; nat...@ke

RE: [PATCH] drm/amd/pm: add missing prototypes to amdgpu_dpm_internal

2022-02-06 Thread Quan, Evan
[AMD Official Use Only] Thanks for the fix! Reviewed-by: Evan Quan > -Original Message- > From: Maíra Canal > Sent: Thursday, February 3, 2022 8:40 AM > To: Quan, Evan ; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; > airl...@linux.ie; dan...@ffwll.

RE: [V10 1/8] ACPI: Add support for AMD ACPI based Wifi band RFI mitigation feature

2023-08-27 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Simon Horman > Sent: Sunday, August 27, 2023 11:43 PM > To: Quan, Evan > Cc: l...@kernel.org; johan...@sipsolutions.net; da...@davemloft.net; > eduma...@google.com; k...@kernel.org; pab...@redhat.com; De

RE: [V10 5/8] drm/amd/pm: setup the framework to support Wifi RFI mitigation feature

2023-08-27 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Lazar, Lijo > Sent: Friday, August 25, 2023 10:09 PM > To: Quan, Evan ; l...@kernel.org; > johan...@sipsolutions.net; da...@davemloft.net; eduma...@google.com; > k...@kernel.org; pab...@redhat.com; Deucher,

RE: [V10 7/8] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.0

2023-08-27 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Lazar, Lijo > Sent: Friday, August 25, 2023 10:13 PM > To: Quan, Evan ; l...@kernel.org; > johan...@sipsolutions.net; da...@davemloft.net; eduma...@google.com; > k...@kernel.org; pab...@redhat.com; Deucher,

RE: [PATCH V8 2/9] drivers core: add ACPI based WBRF mechanism introduced by AMD

2023-08-14 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Simon Horman > Sent: Friday, August 11, 2023 5:38 PM > To: Quan, Evan > Cc: raf...@kernel.org; l...@kernel.org; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com

RE: [PATCH V8 6/9] drm/amd/pm: setup the framework to support Wifi RFI mitigation feature

2023-08-14 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Simon Horman > Sent: Friday, August 11, 2023 5:35 PM > To: Quan, Evan > Cc: raf...@kernel.org; l...@kernel.org; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com

RE: [PATCH V8 1/9] drivers core: Add support for Wifi band RF mitigations

2023-08-14 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Randy Dunlap > Sent: Thursday, August 10, 2023 11:41 PM > To: Quan, Evan ; raf...@kernel.org; l...@kernel.org; > Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com; d

RE: [PATCH V8 3/9] cfg80211: expose nl80211_chan_width_to_mhz for wide sharing

2023-08-14 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Jeff Johnson > Sent: Thursday, August 10, 2023 10:06 PM > To: Quan, Evan ; raf...@kernel.org; l...@kernel.org; > Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com; d

RE: [PATCH V7 4/9] wifi: mac80211: Add support for ACPI WBRF

2023-08-14 Thread Quan, Evan
Andrew Lunn > Sent: Wednesday, July 26, 2023 4:10 AM > To: Limonciello, Mario > Cc: Quan, Evan ; raf...@kernel.org; l...@kernel.org; > Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com; dan...@ffwll.ch; johan...@sipsolutions.net; > da...@davemloft.

RE: [PATCH v2 1/1] drm/amd/pm: Implement get GFXOFF status for vangogh

2022-07-11 Thread Quan, Evan
[AMD Official Use Only - General] Acked-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of > André Almeida > Sent: Tuesday, July 12, 2022 3:35 AM > To: Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; David > Airlie ; Daniel Vetter ; Zhang, Hawking > ; Zhou1, Tao ;

RE: [PATCH 1/4] drm/amd: Add detailed GFXOFF stats to debugfs

2022-07-25 Thread Quan, Evan
[AMD Official Use Only - General] Using "uint64_t" instead of "uint32_t" for entry counter may be better. BR Evan > -Original Message- > From: amd-gfx On Behalf Of > André Almeida > Sent: Saturday, July 23, 2022 4:34 AM > To: Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ;

RE: [PATCH 1/4] drm/amd: Add detailed GFXOFF stats to debugfs

2022-07-25 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: André Almeida > Sent: Tuesday, July 26, 2022 12:15 AM > To: Quan, Evan ; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; David > Airlie ; Daniel Vetter ; Zhang, Hawking > ; Zhou1, Tao ;

RE: [PATCH] drm/amdgpu/powerplay/psm: Fix memory leak in power state init

2022-10-17 Thread Quan, Evan
[AMD Official Use Only - General] Reviewed-by: Evan Quan > -Original Message- > From: Rafael Mendonca > Sent: Tuesday, October 18, 2022 8:54 AM > To: Quan, Evan ; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; David > Airlie ; Daniel Vetter > Cc: Ra

RE: [PATCH] drm/amdgpu: don't call drm_fb_helper_lastclose in lastclose()

2022-10-24 Thread Quan, Evan
[AMD Official Use Only - General] Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Thursday, October 20, 2022 10:36 PM > To: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Deucher, Alexander ; Thomas > Zimmermann >

RE: [PATCH v2] drivers/amd/pm: check the return value of amdgpu_bo_kmap

2022-09-21 Thread Quan, Evan
gt; ; Chen, Guchun ; > Limonciello, Mario ; Quan, Evan > ; Lazar, Lijo ; dan...@ffwll.ch; > airl...@linux.ie; Pan, Xinhui ; Koenig, Christian > ; Deucher, Alexander > ; Li Zhong > Subject: [PATCH v2] drivers/amd/pm: check the return value of > amdgpu_bo_kmap > > amdgpu_bo_

RE: [PATCH 2/2] drm/amd/pm: Fix a potential gpu_metrics_table memory leak

2022-08-03 Thread Quan, Evan
[AMD Official Use Only - General] Thanks for the fixes! The series is reviewed-by: Evan Quan Evan > -Original Message- > From: Zhen Ni > Sent: Wednesday, August 3, 2022 5:20 PM > To: airl...@linux.ie; dan...@ffwll.ch; Quan, Evan ; > Deucher, Alexander ; Koenig, Ch

RE: [PATCH] drm/amdgpu: add mb for si

2022-11-24 Thread Quan, Evan
[AMD Official Use Only - General] Could the attached patch help? Evan > -Original Message- > From: amd-gfx On Behalf Of ??? > Sent: Friday, November 18, 2022 5:25 PM > To: Michel Dänzer ; Koenig, Christian > ; Deucher, Alexander > > Cc: amd-...@lists.freedesktop.org; Pan, Xinhui ; >

RE: [PATCH] swsmu/amdgpu_smu: Fix the wrong if-condition

2022-11-24 Thread Quan, Evan
[AMD Official Use Only - General] Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of Yu > Songping > Sent: Thursday, November 24, 2022 9:53 AM > To: airl...@gmail.com; dan...@ffwll.ch > Cc: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; linux- >

RE: [PATCH] drm/amdgpu: add mb for si

2022-11-24 Thread Quan, Evan
l Message- > From: Christian König > Sent: Thursday, November 24, 2022 6:06 PM > To: Quan, Evan ; 李真能 ; > Michel Dänzer ; Koenig, Christian > ; Deucher, Alexander > > Cc: dri-devel@lists.freedesktop.org; Pan, Xinhui ; > linux-ker...@vger.kernel.org; amd-...@lists.fr

RE: [PATCH] drm/amdgpu: add mb for si

2022-11-24 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Lazar, Lijo > Sent: Thursday, November 24, 2022 6:49 PM > To: Quan, Evan ; 李真能 ; > Michel Dänzer ; Koenig, Christian > ; Deucher, Alexander > > Cc: amd-...@lists.freedesktop.org; P

RE: [PATCH 0/3] drm/amd/pm/powerplay: use bitwise or for bitmasks addition

2023-01-15 Thread Quan, Evan
[AMD Official Use Only - General] Series is reviewed-by: Evan Quan > -Original Message- > From: Deepak R Varma > Sent: Sunday, January 15, 2023 3:16 PM > To: Quan, Evan ; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; David > Airlie ; Dan

RE: [PATCH v3 2/2] drm/probe_helper: warning on poll_enabled for issue catching

2023-03-09 Thread Quan, Evan
[AMD Official Use Only - General] Series is acked-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of > Guchun Chen > Sent: Friday, March 10, 2023 9:02 AM > To: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > Deucher, Alexander ; Zhang, Hawking > ;

RE: [PATCH] gpu: amd/pm: mark symbols static where possible for smu11

2023-03-02 Thread Quan, Evan
[AMD Official Use Only - General] Thanks. But I think there was already a patch from Kun Liu to address this issue. https://lists.freedesktop.org/archives/amd-gfx/2023-March/090029.html BR Evan > -Original Message- > From: Jeff Pang > Sent: Thursday, March 2, 2023 5:16 PM &

RE: [PATCH] drm/amd/pm: remove unused num_of_active_display variable

2023-04-09 Thread Quan, Evan
[AMD Official Use Only - General] Reviewed-by: Evan Quan > -Original Message- > From: Tom Rix > Sent: Saturday, April 1, 2023 12:41 AM > To: Quan, Evan ; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com; dan...@ffwll.ch; nat...@ke

RE: [PATCH v2] drm/amd/pm: Vangogh: Add new gpu_metrics_v2_4 to acquire gpu_metrics

2023-07-17 Thread Quan, Evan
r, Alexander > ; Limonciello, Mario > ; Koenig, Christian > ; Pan, Xinhui ; Quan, > Evan > Cc: Yuan, Perry ; Liang, Richard qi > ; amd-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org; linux-ker...@vger.kernel.org > Subject: RE: [PATCH v2] drm/amd/pm: Vangogh: A

RE: [PATCH V6 1/9] drivers core: Add support for Wifi band RF mitigations

2023-07-18 Thread Quan, Evan
implementation. But I can make this AMD ACPI specific and bring a more generic version here. Evan > -Original Message- > From: Andrew Lunn > Sent: Thursday, July 13, 2023 7:12 AM > To: Quan, Evan > Cc: raf...@kernel.org; l...@kernel.org; Deucher, Alexander > ; Koenig, C

RE: [PATCH V6 1/9] drivers core: Add support for Wifi band RF mitigations

2023-07-18 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Andrew Lunn > Sent: Tuesday, July 18, 2023 10:16 PM > To: Quan, Evan > Cc: raf...@kernel.org; l...@kernel.org; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com

RE: [PATCH V5 4/9] wifi: mac80211: Add support for ACPI WBRF

2023-07-03 Thread Quan, Evan
[AMD Official Use Only - General] Hi Andrew, > -Original Message- > From: Andrew Lunn > Sent: Saturday, July 1, 2023 9:02 AM > To: Quan, Evan > Cc: raf...@kernel.org; l...@kernel.org; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com

RE: [PATCH V5 2/9] driver core: add ACPI based WBRF mechanism introduced by AMD

2023-07-03 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Andrew Lunn > Sent: Saturday, July 1, 2023 8:51 AM > To: Quan, Evan > Cc: raf...@kernel.org; l...@kernel.org; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com

RE: [PATCH V5 1/9] drivers core: Add support for Wifi band RF mitigations

2023-07-03 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Andrew Lunn > Sent: Saturday, July 1, 2023 8:25 AM > To: Limonciello, Mario > Cc: Quan, Evan ; raf...@kernel.org; l...@kernel.org; > Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; >

RE: [PATCH V5 1/9] drivers core: Add support for Wifi band RF mitigations

2023-07-03 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Andrew Lunn > Sent: Saturday, July 1, 2023 8:20 AM > To: Quan, Evan > Cc: raf...@kernel.org; l...@kernel.org; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com

RE: [PATCH V5 1/9] drivers core: Add support for Wifi band RF mitigations

2023-07-03 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Limonciello, Mario > Sent: Saturday, July 1, 2023 12:41 AM > To: Quan, Evan ; raf...@kernel.org; l...@kernel.org; > Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com; d

RE: [PATCH V5 1/9] drivers core: Add support for Wifi band RF mitigations

2023-07-03 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Simon Horman > Sent: Friday, June 30, 2023 9:39 PM > To: Quan, Evan > Cc: raf...@kernel.org; l...@kernel.org; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com

RE: [PATCH V5 1/9] drivers core: Add support for Wifi band RF mitigations

2023-07-05 Thread Quan, Evan
subsystems can do necessary wbrf support check in advance and coordinate their actions accordingly. Please let us know your thoughts. BR, Evan > -Original Message- > From: Andrew Lunn > Sent: Tuesday, July 4, 2023 9:07 PM > To: Quan, Evan > Cc: raf...@kernel.org; l...@kerne

RE: [PATCH V2 2/7] wifi: mac80211: Add support for ACPI WBRF

2023-06-12 Thread Quan, Evan
[AMD Official Use Only - General] Thanks Johannes. Comment in-line > -Original Message- > From: Johannes Berg > Sent: Friday, June 9, 2023 4:21 PM > To: Quan, Evan ; raf...@kernel.org; l...@kernel.org; > Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; > a

RE: [PATCH] drm/amdgpu: Clean up errors in vega20_baco.c

2023-08-01 Thread Quan, Evan
[AMD Official Use Only - General] Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of Ran > Sun > Sent: Tuesday, August 1, 2023 4:03 PM > To: Deucher, Alexander ; airl...@gmail.com; > dan...@ffwll.ch > Cc: Ran Sun ; dri-devel@lists.freedesktop.org; >

RE: [PATCH] drm/amd/pm: Clean up errors in vega20_hwmgr.h

2023-08-01 Thread Quan, Evan
[AMD Official Use Only - General] Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of Ran > Sun > Sent: Tuesday, August 1, 2023 10:39 AM > To: Deucher, Alexander ; airl...@gmail.com; > dan...@ffwll.ch > Cc: Ran Sun ; dri-devel@lists.freedesktop.org; >

RE: [PATCH V7 0/9] Enable Wifi RFI interference mitigation feature support

2023-07-23 Thread Quan, Evan
[AMD Official Use Only - General] Gentle ping on this series. Hi Rafael and Andrew, Can you help to check this latest series and share your thoughts if any? BR, Evan > -Original Message- > From: Quan, Evan > Sent: Wednesday, July 19, 2023 5:00 PM > To: raf...@k

RE: [PATCH V7 4/9] wifi: mac80211: Add support for ACPI WBRF

2023-07-25 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Limonciello, Mario > Sent: Monday, July 24, 2023 9:41 PM > To: Andrew Lunn ; Quan, Evan > Cc: raf...@kernel.org; l...@kernel.org; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; >

RE: [PATCH -next] drm/amd/pm: Remove many unnecessary NULL values

2023-08-01 Thread Quan, Evan
[AMD Official Use Only - General] Reviewed-by: Evan Quan > -Original Message- > From: Ruan Jinjie > Sent: Tuesday, August 1, 2023 8:55 PM > To: Quan, Evan ; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com; dan...@ffwll.ch; mrip...@k

RE: [PATCH V3 1/7] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-20 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Limonciello, Mario > Sent: Monday, June 19, 2023 10:04 AM > To: Quan, Evan > Cc: linux-ker...@vger.kernel.org; linux-a...@vger.kernel.org; amd- > g...@lists.freedesktop.org; dri-devel@lists.freedesktop.o

RE: [PATCH V3 2/7] wifi: mac80211: Add support for ACPI WBRF

2023-06-20 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Limonciello, Mario > Sent: Monday, June 19, 2023 10:17 AM > To: Quan, Evan > Cc: linux-ker...@vger.kernel.org; linux-a...@vger.kernel.org; amd- > g...@lists.freedesktop.org; dri-devel@lists.freedesktop.o

RE: [PATCH V3 2/7] wifi: mac80211: Add support for ACPI WBRF

2023-06-20 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Johannes Berg > Sent: Monday, June 19, 2023 4:24 PM > To: Limonciello, Mario ; Quan, Evan > > Cc: linux-ker...@vger.kernel.org; linux-a...@vger.kernel.org; amd- > g...@lists.freedesktop.org; dri-devel@

RE: [PATCH V3 4/7] drm/amd/pm: setup the framework to support Wifi RFI mitigation feature

2023-06-20 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Lazar, Lijo > Sent: Monday, June 19, 2023 10:55 PM > To: Quan, Evan ; raf...@kernel.org; l...@kernel.org; > Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com; dan...@ffwll.ch

RE: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-30 Thread Quan, Evan
June 24, 2023 1:16 AM > To: Limonciello, Mario > Cc: Rafael J. Wysocki ; Quan, Evan > ; l...@kernel.org; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com; dan...@ffwll.ch; johan...@sipsolutions.net; > da...@davemloft.net; eduma...@google.com; k.