v9:
rep_ctl is prepared for TCD too.
return moved into deault of rep_ctl prepare function [Shashank]
Signed-off-by: Ramalingam C
Reviewed-by: Shashank Sharma
Acked-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_hdcp.c | 152 ++
drivers/gpu/drm/i915/display/intel_hdmi.c | 1
I915 needs to send the index of the transcoder as per ME FW.
To support this, define enum mei_fw_tc and add as a member into
the struct hdcp_port_data.
v2:
Typo in commit msg is fixed [Shashank]
v3:
kdoc is added for mei_fw_tc [Tomas]
s/MEI_TC_x/MEI_TRANSCODER_x
Signed-off-by: Ramalingam
-by: Ramalingam C
Reviewed-by: Jani Nikula
Reviewed-by: Shashank Sharma
---
drivers/gpu/drm/i915/display/intel_bios.h| 3 ++-
drivers/gpu/drm/i915/display/intel_display.h | 20 +++-
drivers/gpu/drm/i915/display/intel_dp.h | 1 +
drivers/gpu/drm/i915/display
For gen12+ platform we need to pass the transcoder info
as part of the port info into ME FW.
This change fills the payload for ME FW from hdcp_port_data.
v2:
Doc is enhanced for physical_port and attached_transcoder [Tomas]
Signed-off-by: Ramalingam C
Acked-by: Jani Nikula
Reviewed
I915 converts it's port value into ddi index defiend by ME FW
and pass it as a member of hdcp_port_data structure.
Hence expose the enum mei_fw_ddi to I915 through
i915_mei_interface.h.
v2:
Copyright years are bumped [Tomas]
Signed-off-by: Ramalingam C
Acked-by: Jani Nikula
Reviewed
Enabling the HDCP1.4 and 2.2 on TGL by supporting the HW block movement
from DDI into transcoder.
v11:
Review comments from Tomas is addressed.
Ramalingam C (6):
drm/i915: mei_hdcp: I915 sends ddi index as per ME FW
drm: Move port definition back to i915 header
drm: Extend I915 mei
r [Jani]
> > v3:
> > comment is added for fw_ddi init for gen12+ [Shashank]
> > only hdcp capable transcoder is translated into fw_tc [Shashank]
> > v4:
> > fw_tc initialization is kept for modeset. [Tomas]
> > few extra doc is added at port_data i
On 2019-08-29 at 15:28:35 +0530, Winkler, Tomas wrote:
> > On 2019-08-28 at 22:12:10 +0530, Ramalingam C wrote:
> > > Enabling the HDCP1.4 and 2.2 on TGL by supporting the HW block
> > > movement from DDI into transcoder.
> > >
> > > v12:
> > &
For gen12+ platform we need to pass the transcoder info
as part of the port info into ME FW.
This change fills the payload for ME FW from hdcp_port_data.
v2:
Doc is enhanced for physical_port and attached_transcoder [Tomas]
Signed-off-by: Ramalingam C
Acked-by: Jani Nikula
Reviewed
v9:
rep_ctl is prepared for TCD too.
return moved into deault of rep_ctl prepare function [Shashank]
Signed-off-by: Ramalingam C
Reviewed-by: Shashank Sharma
Acked-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_hdcp.c | 152 ++
drivers/gpu/drm/i915/display/intel_hdmi.c | 1
On 2019-08-28 at 22:12:10 +0530, Ramalingam C wrote:
> Enabling the HDCP1.4 and 2.2 on TGL by supporting the HW block movement
> from DDI into transcoder.
>
> v12:
> r-b and ack are collected.
> few review comments are addressed.
Tomas,
Thanks for reviewing the patches and
I915 needs to send the index of the transcoder as per ME FW.
To support this, define enum mei_fw_tc and add as a member into
the struct hdcp_port_data.
v2:
Typo in commit msg is fixed [Shashank]
v3:
kdoc is added for mei_fw_tc [Tomas]
s/MEI_TC_x/MEI_TRANSCODER_x
Signed-off-by: Ramalingam
-by: Ramalingam C
Reviewed-by: Jani Nikula
Reviewed-by: Shashank Sharma
Reviewed-by: Tomas Winkler
---
drivers/gpu/drm/i915/display/intel_bios.h| 3 ++-
drivers/gpu/drm/i915/display/intel_display.h | 20 +++-
drivers/gpu/drm/i915/display/intel_dp.h | 1 +
drivers/gpu
I915 converts it's port value into ddi index defiend by ME FW
and pass it as a member of hdcp_port_data structure.
Hence expose the enum mei_fw_ddi to I915 through
i915_mei_interface.h.
v2:
Copyright years are bumped [Tomas]
Signed-off-by: Ramalingam C
Acked-by: Jani Nikula
Reviewed
Enabling the HDCP1.4 and 2.2 on TGL by supporting the HW block movement
from DDI into transcoder.
v12:
r-b and ack are collected.
few review comments are addressed.
Ramalingam C (6):
drm/i915: mei_hdcp: I915 sends ddi index as per ME FW
drm: Move port definition back to i915 header
drm
into fw_tc [Shashank]
v4:
fw_tc initialization is kept for modeset. [Tomas]
few extra doc is added at port_data init [Tomas]
v5:
Few comments are improvised [Tomas]
Signed-off-by: Ramalingam C
Acked-by: Jani Nikula
Reviewed-by: Shashank Sharma
---
.../drm/i915/display/intel_display_types.h
through i915_mei_interface.h.
> >
> > v2:
> > Copyright years are bumped [Tomas]
> >
> > Signed-off-by: Ramalingam C
> > Acked-by: Jani Nikula
> > Reviewed-by: Shashank Sharma
> > Acked-by: Tomas Winkler
> > ---
> > drivers/g
gt; > > > This change fills the payload for ME FW from hdcp_port_data.
> > > >
> > > > Signed-off-by: Ramalingam C
> > > > Acked-by: Jani Nikula
> > > > Reviewed-by: Shashank Sharma
> > > > ---
> > > > drivers/misc/mei/hdc
Jani]
> > v3:
> > comment is added for fw_ddi init for gen12+ [Shashank]
> > only hdcp capable transcoder is translated into fw_tc [Shashank]
> >
> > Signed-off-by: Ramalingam C
> > Acked-by: Jani Nikula
> > ---
> > .../drm/i915/display/intel
gt; > Typo in commit msg is fixed [Shashank]
> >
> > Signed-off-by: Ramalingam C
> > Acked-by: Jani Nikula
> > ---
> > include/drm/i915_mei_hdcp_interface.h | 13 +
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/include/
On 2019-08-27 at 19:49:19 +0530, Winkler, Tomas wrote:
> > For gen12+ platform we need to pass the transcoder info as part of the port
> > info into ME FW.
> >
> > This change fills the payload for ME FW from hdcp_port_data.
> >
> > Signed-off-by: Ram
On 2019-09-12 at 00:15:32 +, Harry Wentland wrote:
> Adding a couple AMD guys.
>
> I know this is already merged but I have a few questions after some
> internal discussions.
>
> On 2019-05-07 12:27 p.m., Ramalingam C wrote:
> > On every hdcp revocation check request
On 2019-09-09 at 15:54:50 +, Lakha, Bhawanpreet wrote:
> Hi all,
>
> This is regarding the recent hdcp content type patch that was merged into
> drm-misc.
> (https://patchwork.freedesktop.org/patch/320958/?series=57233=11)
>
> There are displays on the market that advertise HDCP 2.2
On 2019-09-12 at 14:23:05 +, Harry Wentland wrote:
> On 2019-09-12 3:47 a.m., Ramalingam C wrote:
> > On 2019-09-09 at 15:54:50 +, Lakha, Bhawanpreet wrote:
> >> Hi all,
> >>
> >> This is regarding the recent hdcp content type patch that was merg
On 2019-08-01 at 13:05:02 +0300, Pekka Paalanen wrote:
> On Mon, 29 Jul 2019 15:03:16 +0530
> Ramalingam C wrote:
>
> > On 2019-07-29 at 17:20:40 +0300, Pekka Paalanen wrote:
> > > On Sun, 14 Jul 2019 16:30:08 +0530
> > > Ramalingam C wrote:
> > >
&
On 2019-08-01 at 16:06:37 +0530, Sharma, Shashank wrote:
> Hi Ram,
> Just a minor nitpick.
>
> Regards
> Shashank
> > -Original Message-
> > From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf
> > Of
> > Ramalingam C
&
On 2019-07-29 at 17:20:40 +0300, Pekka Paalanen wrote:
> On Sun, 14 Jul 2019 16:30:08 +0530
> Ramalingam C wrote:
>
> > This patch adds a DRM ENUM property to the selected connectors.
> > This property is used for mentioning the protected content's type
> > fr
On 2019-08-01 at 17:11:13 +0530, Ramalingam C wrote:
> Series adds the content_type support for HDCP2.2. Along with that uevent
> is sent for each HDCP state change triggered within kernel.
>
> Pekka have completed the Weston DRM-backend review in
> https://gitlab.freedesktop.org
In the kernel documentation, HDCP specifications links are shared as a
reference for SRM table format.
v2:
Fixed small nits. [Shashank]
Signed-off-by: Ramalingam C
Reviewed-by: Shashank Sharma
Acked-by: Pekka Paalanen
---
drivers/gpu/drm/drm_hdcp.c | 7 +++
1 file changed, 7 insertions
/merge_requests/48
and the UAPI for HDCP 2.2 looks good.
The userspace is accepted in Weston.
v2:
Minor fixes at KDoc comments [Daniel]
v3:
Check the property is really attached with connector [Daniel]
v4:
Typos and string length suggestions are addressed [Sean]
Signed-off-by: Ramalingam C
Reviewed
-by: Ramalingam C
Reviewed-by: Daniel Vetter
Acked-by: Pekka Paalanen
---
drivers/gpu/drm/i915/display/intel_hdcp.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c
b/drivers/gpu/drm/i915/display/intel_hdcp.c
index a52f6ef2951e
.
The userspace is accepted in Weston.
v2:
Update only when state is different from old one.
v3:
KDoc is added [Daniel]
v4:
KDoc is extended bit more [pekka]
v5:
Uevent usage is documented at kdoc of "Content Protection" also
[pekka]
Signed-off-by: Ramalingam C
Reviewed-by: Dan
state is ignored.
Signed-off-by: Ramalingam C
Reviewed-by: Daniel Vetter
Acked-by: Pekka Paalanen
---
drivers/gpu/drm/i915/display/intel_ddi.c | 39
drivers/gpu/drm/i915/display/intel_hdcp.c | 43 +++
drivers/gpu/drm/i915/display/intel_hdcp.h | 2 +-
3
. [pekka]
v8:
Few more clarification into kernel doc of content type [pekka]
v9:
Small fixes in coding style.
v10:
Moving DRM_MODE_HDCP_CONTENT_TYPEx definition to drm_hdcp.h [pekka]
Signed-off-by: Ramalingam C
Reviewed-by: Daniel Vetter
Acked-by: Pekka Paalanen
---
drivers/gpu/drm
.
The userspace is accepted in Weston.
v12:
DRM_MODE_HDCP_CONTENT_TYPEx definition are moved into drm_hdcp.h
[pekka]
Picked Acked-by and R-by from reviewers.
Test-with: <20190703095446.14092-2-ramalinga...@intel.com>
Ramalingam C (6):
drm: Add Content protection type property
drm/i915:
On 2019-07-09 at 17:31:10 +0300, Pekka Paalanen wrote:
> On Mon, 8 Jul 2019 16:51:11 +0530
> Ramalingam C wrote:
>
> > This patch adds a DRM ENUM property to the selected connectors.
> > This property is used for mentioning the protected content's type
> > fr
On 2019-07-09 at 16:26:31 +0300, Pekka Paalanen wrote:
> On Mon, 8 Jul 2019 14:42:29 +0530
> Ramalingam C wrote:
>
> > On 2019-07-08 at 12:59:59 +0300, Pekka Paalanen wrote:
> > > On Mon, 8 Jul 2019 12:52:17 +0300
> > > Pekka Paalanen wrote:
> > >
rly.run
> #v1
>
> Changes in v2:
> -Remove 'generate' in intel_dp_aux_generate_xfer_flags, make arg const (Ville)
> -Bundle Aksv if statement together (Ville)
> -Rename 'txbuf' to 'aksv' (Ville)
LGTM
Reviewed-by: Ramalingam C
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 62 ++
k + base implementation")
> Cc: Chris Wilson
> Cc: Ramalingam C
> Cc: Daniel Vetter
> Cc: Sean Paul
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
> Cc: Rodrigo Vivi
> Cc: intel-...@lists.freedesktop.org
> Cc: # v4.17+
> Signed-off-by: Sean Paul
>
> Changes
On 2019-12-12 at 14:02:23 -0500, Sean Paul wrote:
> From: Sean Paul
>
> Instead of using intel_dig_port's encoder pipe to determine which
> transcoder to toggle signalling on, use the cpu_transcoder field already
> stored in intel_hdmi.
you mean intel_hdcp
LGTM.
Reviewed-b
is not (yet)
> supported. Oh, and the sha_leftovers == 1 case works perfectly!
Yes. The repeaters tested at our side too with sha_leftovers = 1 with
mostly ksv count of 1. non availability of the repeaters is killer here.
>
> Fixes: ee5e5e7a5e0f ("drm/i915: Add HDCP framework + base i
n Paul
> Link:
> https://patchwork.freedesktop.org/patch/msgid/20191203173638.94919-7-s...@poorly.run
> #v1
LGTM.
Reviewed-by: Ramalingam C
>
> Changes in v2:
> -None
> ---
> drivers/gpu/drm/i915/display/intel_hdcp.c | 67 ---
> 1 file changed
done.
>
> Signed-off-by: Sean Paul
Will there be an instance where prop_work is scheduled but before
execution cancelled from the queue itself? This will leak the connector
reference.
Atleast hdcp stack is not requesting for such action. So Looks good to me.
Reviewed-by: Ramalingam C
On 2019-12-12 at 14:02:26 -0500, Sean Paul wrote:
> From: Sean Paul
>
> This patch is required for HDCP over MST. If a port is being used for
> multiple HDCP streams, we don't want to fully disable HDCP on a port if
> one of them is disabled. Instead, we just disable the HDCP signalling on
>
On 2019-12-12 at 14:02:21 -0500, Sean Paul wrote:
> From: Sean Paul
>
> HDCP signalling should not be left on, WARN if it is
LGTM
Reviewed-by: Ramalingam C
>
> Cc: Ville Syrjälä
> Cc: Daniel Vetter
> Signed-off-by: Sean Paul
>
> Changes in v2:
> - Added to th
:
roll over of seq_num_m detected at the start of stream management.
Signed-off-by: Ramalingam C
---
drivers/gpu/drm/i915/display/intel_hdcp.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c
b/drivers/gpu/drm/i915
of DRM_DEBUG_KMS [Anshuman]
Signed-off-by: Ramalingam C
---
drivers/gpu/drm/i915/display/intel_hdcp.c | 75 ++-
1 file changed, 46 insertions(+), 29 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c
b/drivers/gpu/drm/i915/display/intel_hdcp.c
index
When roll over detected for seq_num_m, we shouldn't continue with stream
management with rolled over value.
So we are terminating the stream management retry, on roll over of the
seq_num_m.
v2:
using drm_dbg_kms instead of DRM_DEBUG_KMS [Anshuman]
Signed-off-by: Ramalingam C
---
drivers/gpu
Converts remaining instances of the printk based logging macros in
i915/display/intel_hdcp.c with the struct drm_device based macros
manually.
This is continuation of commit 65833c463886 ("drm/i915/hdcp: conversion
to struct drm_device based logging macros.")
Signed-off-by: Ramali
On 2020-02-12 at 12:01:08 +0200, Jani Nikula wrote:
> On Wed, 12 Feb 2020, Ramalingam C wrote:
> > Converts remaining instances of the printk based logging macros in
> > i915/display/intel_hdcp.c with the struct drm_device based macros
> > manually.
> >
> &g
Need to extract the 2 most significant bits from a byte for constructing
the revoked KSV count of the SRM.
Signed-off-by: Ramalingam C
---
include/drm/drm_hdcp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h
index
with functional testing.
v4:
fix htmldoc [lkp]
Signed-off-by: Ramalingam C
Suggested-by: Sean Paul
---
drivers/gpu/drm/drm_hdcp.c | 158 -
drivers/gpu/drm/drm_internal.h | 4 -
drivers/gpu/drm/drm_sysfs.c| 2 -
include/drm/drm_hdcp.h | 4 +-
4 files
Combined HDCP patches together. Few for DRM SRM handling and few
more for hdcp2.2 compliance fix at I915.
Ramalingam C (5):
drm/hdcp: optimizing the srm handling
drm/hdcp: fix DRM_HDCP_2_KSV_COUNT_2_LSBITS
drm/i915: terminate reauth at stream management failure
drm/i915: dont retry stream
Need to extract the 2 most significant bits from a byte for constructing
the revoked KSV count of the SRM.
Signed-off-by: Ramalingam C
---
include/drm/drm_hdcp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h
index
-off-by: Ramalingam C
---
drivers/gpu/drm/i915/display/intel_hdcp.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c
b/drivers/gpu/drm/i915/display/intel_hdcp.c
index b24d12efae0a..b35f50d4a0e9 100644
--- a/drivers/gpu/drm
Combined HDCP patches together. Few for DRM SRM handling and few
more for hdcp2.2 compliance fix at I915.
v2:
minor changes in i915 related 3 patches.
Ramalingam C (5):
drm/hdcp: optimizing the srm handling
drm/hdcp: fix DRM_HDCP_2_KSV_COUNT_2_LSBITS
drm/i915: terminate reauth at stream
with functional testing.
v4:
fix htmldoc [lkp]
Signed-off-by: Ramalingam C
Suggested-by: Sean Paul
---
drivers/gpu/drm/drm_hdcp.c | 158 -
drivers/gpu/drm/drm_internal.h | 4 -
drivers/gpu/drm/drm_sysfs.c| 2 -
include/drm/drm_hdcp.h | 4 +-
4 files
ed instead of drm_device for reusability [JaniN]
Signed-off-by: Ramalingam C
cc: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_hdcp.c | 108 --
1 file changed, 61 insertions(+), 47 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c
b/drivers/gpu/drm/i9
of DRM_DEBUG_KMS [Anshuman]
v4:
dev_priv is used as i915 [JaniN]
Signed-off-by: Ramalingam C
---
drivers/gpu/drm/i915/display/intel_hdcp.c | 75 ++-
1 file changed, 46 insertions(+), 29 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c
b/drivers/gpu/drm
On 2020-02-12 at 13:31:45 +0200, Jani Nikula wrote:
> On Wed, 12 Feb 2020, Ramalingam C wrote:
> > Converts remaining instances of the printk based logging macros in
> > i915/display/intel_hdcp.c with the struct drm_device based macros
> > manually.
> >
> &g
On 2020-02-12 at 15:59:37 +0530, Ramalingam C wrote:
> Combined HDCP patches together. Few for DRM SRM handling and few
> more for hdcp2.2 compliance fix at I915.
>
> v2:
> minor changes in i915 related 3 patches.
>
> Ramalingam C (5):
> drm/hdcp: optimizing the s
+ seq_puts(m, "No Connector Support");
> + goto out;
> + }
With shim check moved inside the hdcp_info, we could remove it from
i915_hdcp_sink_capability_show. Let us return "No connector support" for
that debugfs too.
With that addressed.
Rev
As we are not using the sysfs infrastructure anymore, link to it is
removed. And global srm data and mutex to protect it are removed,
with required handling at revocation check function.
v2:
srm_data is dropped and few more comments are addressed.
Signed-off-by: Ramalingam C
Suggested
On 2020-01-27 at 16:10:32 -0500, Sean Paul wrote:
> On Mon, Jan 27, 2020 at 11:42:31PM +0530, Ramalingam C wrote:
> > As we are not using the sysfs infrastructure anymore, link to it is
> > removed. And global srm data and mutex to protect it are removed,
> > with required h
with functional testing.
Signed-off-by: Ramalingam C
Suggested-by: Sean Paul
---
drivers/gpu/drm/drm_hdcp.c | 158 -
drivers/gpu/drm/drm_internal.h | 4 -
drivers/gpu/drm/drm_sysfs.c| 2 -
include/drm/drm_hdcp.h | 4 +-
4 files changed, 61 insertions
t need to revisit the
HDCP support we have for gen12+.
I am not seeing this scenario addressed in this series. Am I missing something?
-Ram
>
> Cc: Ramalingam C
> Signed-off-by: Sean Paul
> Link:
> https://patchwork.freedesktop.org/patch/msgid/20191203173638.94919-8-s...@poorly.run
with functional testing.
v4:
fix htmldoc [lkp]
Signed-off-by: Ramalingam C
Suggested-by: Sean Paul
---
drivers/gpu/drm/drm_hdcp.c | 158 -
drivers/gpu/drm/drm_internal.h | 4 -
drivers/gpu/drm/drm_sysfs.c| 2 -
include/drm/drm_hdcp.h | 4 +-
4 files
As we are not using the sysfs infrastructure anymore, link to it is
removed. And global srm data and mutex to protect it are removed,
with required handling at revocation check function.
Yet to test hence RFC tag is added.
Signed-off-by: Ramalingam C
Suggested-by: Sean Paul
---
drivers/gpu
e won't end up trying to parse the ksv list if there is an error
> fetching it.
>
> Fixes: 79643fddd6eb ("drm/hdcp: optimizing the srm handling")
> Cc: sta...@vger.kernel.org
> Cc: Ramalingam C
> Cc: Sean Paul
> Cc: Maarten Lankhorst
> Cc: Maxime Ripard
>
On 2020-04-29 at 09:58:16 -0400, Sean Paul wrote:
> On Wed, Apr 29, 2020 at 9:50 AM Ramalingam C wrote:
> >
> > On 2020-04-14 at 15:02:55 -0400, Sean Paul wrote:
> > > From: Sean Paul
> > >
> > > The SRM cleanup in 79643fddd6eb2 ("drm/hdcp: op
drm_hdcp_check_ksvs_revoked() returns the number of revoked keys and
error codes when the SRM parsing is failed.
Errors in SRM parsing can't affect the HDCP auth, hence with this patch,
I915 will look out for revoked key count alone.
Signed-off-by: Ramalingam C
cc: Sean Paul
---
drivers/gpu
On 2020-04-29 at 10:46:29 -0400, Sean Paul wrote:
> On Wed, Apr 29, 2020 at 10:22 AM Ramalingam C wrote:
> >
> > On 2020-04-29 at 09:58:16 -0400, Sean Paul wrote:
> > > On Wed, Apr 29, 2020 at 9:50 AM Ramalingam C
> > > wrote:
> > > >
> > &
On 2020-04-29 at 15:54:46 -0400, Sean Paul wrote:
> From: Sean Paul
>
> Changes in v6:
> -Rebased on -tip
> -Disabled HDCP over MST on GEN12
> -Addressed Lyude's review comments in the QUERY_STREAM_ENCRYPTION_STATUS patch
Sean,
What is the test setup you have used?
I am afraid our CI dont
HDCP signalling on
> that particular pipe and exit early. The last pipe to disable HDCP will
> also bring down HDCP on the port.
>
> In order to achieve this, we need to keep a refcount in intel_digital_port
> and protect it using a new hdcp_mutex.
>
> Cc: Ramalingam C
> Sig
On 2020-04-29 at 15:55:02 -0400, Sean Paul wrote:
> From: Sean Paul
>
> Now that all the groundwork has been laid, we can turn on HDCP 1.4 over
> MST. Everything except for toggling the HDCP signalling and HDCP 2.2
> support is the same as the DP case, so we'll re-use those callbacks
>
> Cc:
On 2020-05-18 at 10:32:09 -0400, Sean Paul wrote:
> On Fri, May 15, 2020 at 10:48 AM Ramalingam C wrote:
> >
> > On 2020-04-29 at 15:54:46 -0400, Sean Paul wrote:
> > > From: Sean Paul
> > >
> > > Changes in v6:
> > > -Rebased on -tip
>
t)
> supported. Oh, and the sha_leftovers == 1 case works perfectly!
>
> Fixes: ee5e5e7a5e0f (drm/i915: Add HDCP framework + base implementation)
> Cc: Chris Wilson
> Cc: Ramalingam C
> Cc: Daniel Vetter
> Cc: Sean Paul
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
ry
> logic and delays from drm dp helpers, let's just use the helpers and hide
> the aksv select as best as we can.
>
> Reviewed-by: Ville Syrjälä
> Reviewed-by: Ramalingam C
Just reconfirming my R-b here. LGTM
Reviewed-by: Ramalingam C
> Signed-off-by: Sean Paul
>
On 2020-04-29 at 15:54:49 -0400, Sean Paul wrote:
> From: Sean Paul
>
> HDCP signalling should not be left on, WARN if it is
>
> Cc: Ville Syrjälä
> Cc: Daniel Vetter
> Reviewed-by: Ramalingam C
Just reconfirming the R-b.
-Ram
> Signed-off-by: Sea
ase implementation)
> Cc: Chris Wilson
> Cc: Ramalingam C
> Cc: Daniel Vetter
> Cc: Sean Paul
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
> Cc: Rodrigo Vivi
> Cc: intel-...@lists.freedesktop.org
> Cc: # v4.17+
> Reviewed-by: Ramalingam C
Just reconfirming my R-b here.
On 2020-05-20 at 15:47:44 -0400, Sean Paul wrote:
> From: Sean Paul
>
> If userspace sets the CP property to DESIRED while it's already ENABLED,
> the driver will try to re-enable HDCP. On some displays, this will
> result in R0' mismatches. I'm guessing this is because the display is
> still
On 2020-05-20 at 15:50:15 -0400, Sean Paul wrote:
> On Wed, May 20, 2020 at 9:08 AM Sean Paul wrote:
> >
> > From: Sean Paul
> >
> > We're seeing some R0' mismatches in the field, particularly with
> > repeaters. I'm guessing the (already lenient) 300ms wait time isn't
> > enough for some
On 2020-08-18 at 11:38:48 -0400, Sean Paul wrote:
> From: Sean Paul
>
> Only one functional change, reversed the hdcp_1x/2x_present bits in the
> QUERY_STREAM_ENCRYPTION_STATUS parsing with a comment explaining my
> confusion.
>
> Other than that, lots of rebasing, the most notable being the
>
On 2020-05-20 at 09:11:38 -0400, Sean Paul wrote:
> On Mon, May 18, 2020 at 12:41 PM Ramalingam C wrote:
> >
> > On 2020-05-18 at 10:32:09 -0400, Sean Paul wrote:
> > > On Fri, May 15, 2020 at 10:48 AM Ramalingam C
> > > wrote:
> > > >
> > &
On 2020-05-19 at 18:16:21 -0400, Sean Paul wrote:
> From: Sean Paul
>
> We're seeing some R0' mismatches in the field, particularly with
I think you want to say Vprime verification? delay is added in between
the retry for vprime verfication.
-Ram
> repeaters. I'm guessing the (already lenient)
-by: Sean Paul
Reviewed-by: Ramalingam C
> Link:
> https://patchwork.freedesktop.org/patch/msgid/20200305201236.152307-13-s...@poorly.run
> #v5
> Link:
> https://patchwork.freedesktop.org/patch/msgid/20200429195502.39919-13-s...@poorly.run
> #v6
>
> Changes in v5:
> -
On 2020-06-23 at 11:59:00 -0400, Sean Paul wrote:
> From: Sean Paul
>
> Although DP_MST fake encoders are not subclassed from digital ports,
> they are associated with them. Support these encoders.
>
> Signed-off-by: Sean Paul
Reviewed-by: Ramalingam C
On 2020-06-23 at 11:59:07 -0400, Sean Paul wrote:
> From: Sean Paul
>
> Now that all the groundwork has been laid, we can turn on HDCP 1.4 over
> MST. Everything except for toggling the HDCP signalling and HDCP 2.2
> support is the same as the DP case, so we'll re-use those callbacks
>
> Cc:
On 2020-06-23 at 11:58:58 -0400, Sean Paul wrote:
> From: Sean Paul
>
> Add an out label and un-indent hdcp disable in preparation for
> hdcp_mutex. No functional changes
>
> Signed-off-by: Sean Paul
Reviewed-by: Ramalingam C
> Link:
> https://patchwork.fre
HDCP signalling on
> that particular pipe and exit early. The last pipe to disable HDCP will
> also bring down HDCP on the port.
>
> In order to achieve this, we need to keep a refcount in intel_digital_port
> and protect it using a new hdcp_mutex.
>
> Cc: Ramalingam C
> Sig
Redundant wrapper for drm_mode_object_find is removed.
Signed-off-by: Ramalingam C
---
drivers/gpu/drm/drm_crtc_internal.h | 6 ++---
drivers/gpu/drm/drm_framebuffer.c | 2 +-
drivers/gpu/drm/drm_mode_object.c | 38 +++--
drivers/gpu/drm/drm_property.c | 6
Typo in the KDoc for the DRM_MODE_PROP_SIGNED_RANGE type of
drm_properties is fixed.
Signed-off-by: Ramalingam C
---
include/drm/drm_property.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_property.h b/include/drm/drm_property.h
index 4a0a80d658c7
> with same dig_port.
Reviewed-by: Ramalingam C
>
> Cc: Ramalingam C
> Reviewed-by: Uma Shankar
> Signed-off-by: Anshuman Gupta
> ---
> drivers/gpu/drm/i915/display/intel_display_types.h | 3 ++-
> drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 3 ++-
> dr
On 2020-11-24 at 20:32:43 +0530, Anshuman Gupta wrote:
> On 2020-11-24 at 19:50:17 +0530, Ramalingam C wrote:
> > On 2020-11-11 at 11:50:42 +0530, Anshuman Gupta wrote:
> > > Enable HDCP 1.4 over DP MST for Gen12.
> > >
> > > Cc: Ramalingam C
4:
> - 's/port_auth/hdcp_port_auth'. [Ram]
> - Commit log improvement.
>
> Cc: Ramalingam C
> Reviewed-by: Uma Shankar
> Signed-off-by: Anshuman Gupta
> ---
> .../drm/i915/display/intel_display_types.h| 4 +-
> drivers/gpu/drm/i915/display/intel_hdcp.c | 103
ue less comment. [Uma]
> v4:
> - Split the Gen12 HDCP enablement patch. [Ram]
> - Add connector details in drm_err.
>
> Cc: Ramalingam C
> Reviewed-by: Uma Shankar
> Signed-off-by: Anshuman Gupta
> ---
> drivers/gpu/drm/i915/display/intel_hdcp.c | 45 -
On 2020-11-11 at 11:50:42 +0530, Anshuman Gupta wrote:
> Enable HDCP 1.4 over DP MST for Gen12.
>
> Cc: Ramalingam C
> Signed-off-by: Anshuman Gupta
> ---
> drivers/gpu/drm/i915/display/intel_dp_mst.c | 10 +++---
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
request on MST connector without
encoder initialized(modeset). But userspace are not supposed to request hdcp at
such
scenario right?.
Ram
> Don't enable HDCP in such cases to prevent any crash.
>
> Cc: Ramalingam C
> Cc: Juston Li
> Signed-off-by: Anshuman Gupta
> --
dded a debug print for stream enc.
> v3:
> - uniformity for connector detail in DMESG. [Ram]
>
> Cc: Ramalingam C
> Reviewed-by: Uma Shankar
Reviewed-by: Ramalingam C
> Tested-by: Karthik B S
> Signed-off-by: Anshuman Gupta
> ---
> drivers/gpu/drm/i915/display/intel_hdcp.c |
On 2020-12-11 at 19:12:44 +0530, Anshuman Gupta wrote:
> Enable HDCP 2.2 MST support till Gen12.
>
> Cc: Ramalingam C
Reviewed-by: Ramalingam C
> Tested-by: Karthik B S
> Signed-off-by: Anshuman Gupta
> ---
> drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +-
> 1 f
801 - 900 of 1382 matches
Mail list logo
