Re: [PATCH 0/8] ARM: sun8i: a33: Mali improvements

[Rask Ingemann Lambertsen]

On Fri, Feb 17, 2017 at 04:44:19PM +0100, Maxime Ripard wrote:
[...]
> We already have DT bindings for out of tree drivers, there's really
> nothing new here.

We have DT bindings for *hardware*, not for drivers. As stated in
Documentation/devicetree/usage-model.txt:

"The "Open Firmware Device Tree", or simply Device Tree (DT), is a data
structure and language for describing hardware.  More specifically, it
is a description of hardware that is readable by an operating system
so that the operating system doesn't need to hard code details of the
machine."

"2.1 High Level View
---
The most important thing to understand is that the DT is simply a data
structure that describes the hardware."

-- 
Rask Ingemann Lambertsen
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 5/6] ARM: dts: Add NextThing GR8 dtsi

[Rask Ingemann Lambertsen]

On Wed, Aug 31, 2016 at 4:18 PM, Maxime Ripard
 wrote:
> From: Mylène Josserand 
>
> The GR8 is an SoC made by Nextthing loosely based on the sun5i family.
>
> Since it's not clear yet what we can factor out and merge with the A10s and
> A13 support, let's keep it out of the sun5i.dtsi include tree. We will
> figure out what can be shared when things settle down.
>
> Signed-off-by: Mylène Josserand 
> Signed-off-by: Maxime Ripard 
> ---
>  arch/arm/boot/dts/gr8.dtsi | 1080 
> 
>  1 file changed, 1080 insertions(+)
>  create mode 100644 arch/arm/boot/dts/gr8.dtsi
>
> diff --git a/arch/arm/boot/dts/gr8.dtsi b/arch/arm/boot/dts/gr8.dtsi
> new file mode 100644
> index ..d21cfa3f3c14
> --- /dev/null
> +++ b/arch/arm/boot/dts/gr8.dtsi

In the node names, you sometimes use underscores and sometimes use hyphens.
Here are the ones I spotted:

> +   osc3M: osc3M_clk {
> +   pll3x2: pll3x2_clk {
> +   pll7x2: pll7x2_clk {
> +   display-engine {
> +   sram-controller at 01c0 {
> +   otg_sram: sram-section at  {
> +   dma: dma-controller at 01c02000 {
> +   tve0: tv-encoder at 01c0a000 {
> +   tcon0: lcd-controller at 01c0c000 {
> +   intc: interrupt-controller at 01c20400 {
> +   lcd_rgb666_pins: lcd_rgb666 at 0 {
> +   nand_pins_a: nand_base0 at 0 {
> +   nand_cs0_pins_a: nand_cs at 0 {
> +   nand_rb0_pins_a: nand_rb at 0 {
> +   uart1_cts_rts_pins_a: uart1-cts-rts at 0 {
> +   fe0: display-frontend at 01e0 {
> +   be0: display-backend at 01e6 {

Underscores should not be used in node names. [1][2] Since you're adding a
new file here, please use hyphens instead.

[1] https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1122967.html
[2] https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1145633.html

-- 
Rask Ingemann Lambertsen