Re: [PATCH 09/10] MCDE: Add build files and bus

2011-03-12 Thread Rob Clark
On Sun, Dec 5, 2010 at 5:28 AM, Daniel Vetter dan...@ffwll.ch wrote: On Sat, Dec 04, 2010 at 04:34:22PM -0500, Alex Deucher wrote: This doesn't seem that different from the graphics chips we support with kms.  I don't think it would require much work to use KMS.  One thing we considered, but

Re: Future desktop on dumb frame buffers?

2011-03-19 Thread Rob Clark
On Sat, Mar 19, 2011 at 6:20 AM, Geert Uytterhoeven ge...@linux-m68k.org wrote: As noone responded to my question in http://www.spinics.net/lists/dri-devel/msg08851.html (yes, it was a bit hidden in a thread), I'm asking it here again (and also on the Wayland mailing list). Basically I'm

[RFC] drm platform multi-device support

2011-03-29 Thread Rob Clark
From: Rob Clark robdcl...@gmail.com Include the minor device id in the bus-id to give userspace a way to open the correct cardN when there are multiple device instances. --- It may seem a bit strange to have multiple platform device instances, but we have a use-case for this. And this relatively

Re: [RFC] drm platform multi-device support

2011-03-30 Thread Rob Clark
, 2011 at 7:57 AM, Ilija Hadzic ihad...@research.bell-labs.com wrote: Are you by any chance working off a stale branch in git ? Apparently the lines you are modifying now live in drm_platform_set_busid function in drm_platform.c -- Ilija On Tue, 29 Mar 2011, Rob Clark wrote: From: Rob

Re: [RFC] drm platform multi-device support

2011-04-04 Thread Rob Clark
On Mon, Apr 4, 2011 at 7:30 PM, Dave Airlie airl...@gmail.com wrote: On Wed, Mar 30, 2011 at 2:44 AM, Rob Clark r...@ti.com wrote: From: Rob Clark robdcl...@gmail.com Include the minor device id in the bus-id to give userspace a way to open the correct cardN when there are multiple device

Re: [RFC] drm: add overlays as first class KMS objects

2011-04-28 Thread Rob Clark
2011/4/25 Stéphane Marchesin stephane.marche...@gmail.com: On Mon, Apr 25, 2011 at 16:22, Jesse Barnes jbar...@virtuousgeek.org wrote: On Mon, 25 Apr 2011 16:16:18 -0700 Keith Packard kei...@keithp.com wrote: On Mon, 25 Apr 2011 15:12:20 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote:

Re: [RFC] drm: add overlays as first class KMS objects

2011-04-28 Thread Rob Clark
On Tue, Apr 26, 2011 at 5:01 AM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: A lot of older hardware had one overlay that could be sourced to any crtc, just not simultaneously.  The tricky part is the formats and capabilities: alpha blending, color/chromakey, gamma correction, etc. Even the

Re: [RFC] drm: add overlays as first class KMS objects

2011-04-28 Thread Rob Clark
On Mon, Apr 25, 2011 at 5:12 PM, Jesse Barnes jbar...@virtuousgeek.org wrote: Looking for comments on this.  Obviously if we're going to add a new type of KMS object, we'd better get the ioctl more or less right to begin with, which means having all the attributes we'd like to track, plus some

Re: Summary of the V4L2 discussions during LDS - was: Re: Embedded Linux memory management interest group list

2011-05-15 Thread Rob Clark
On Sun, May 15, 2011 at 4:27 PM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: On both cases, the requirement is to pass a framebuffer between two entities, and not a video stream. It may not even be a framebuffer. In many cases you'll pass a framebuffer or some memory target (in DRI think

Re: 3D support for Displaylink devices

2011-06-02 Thread Rob Clark
On Mon, May 30, 2011 at 12:30 PM, PRASANNA KUMAR prasanna_tsm_ku...@yahoo.co.in wrote: USB graphics devices from displaylink does not have 3D hardware. To get 3D effects (compiz, GNOME 3, KWin, OpenGL apps etc) with these device in Linux the native (primary) GPU can be used to provide hardware

Re: [RFC] Updated plane support v3

2011-06-21 Thread Rob Clark
On Mon, Jun 20, 2011 at 3:11 PM, Jesse Barnes jbar...@virtuousgeek.org wrote: This version adds both source and dest rect params to the set_plane ioctl, and makes the source fixed point to support hardware that needs it. I haven't changed the name of the SNB implementation yet (per Chris's

Re: [RFC] Updated plane support v3

2011-06-21 Thread Rob Clark
On Tue, Jun 21, 2011 at 6:21 AM, Rob Clark robdcl...@gmail.com wrote: On Mon, Jun 20, 2011 at 3:11 PM, Jesse Barnes jbar...@virtuousgeek.org wrote: This version adds both source and dest rect params to the set_plane ioctl, and makes the source fixed point to support hardware that needs

Re: [RFC] Updated plane support v3

2011-06-21 Thread Rob Clark
On Tue, Jun 21, 2011 at 11:19 AM, Jesse Barnes jbar...@virtuousgeek.org wrote: On Tue, 21 Jun 2011 06:21:11 -0500 Rob Clark robdcl...@gmail.com wrote: On Mon, Jun 20, 2011 at 3:11 PM, Jesse Barnes jbar...@virtuousgeek.org wrote: This version adds both source and dest rect params

Re: Some questions about DRM(Direct Rendering Manager)

2011-06-22 Thread Rob Clark
fwiw, drm_fb_helper_single_fb_probe() calls register_framebuffer() (if that was the question?) BR, -R 2011/6/22 InKi Dae daei...@gmail.com: It adds dri-devel@lists.freedesktop.org to this mail thread. Thank you. 2011년 6월 22일 오후 3:04, daeinki inki@samsung.com님의 말: below is additional

[PATCH] drm: platform multi-device support

2011-07-13 Thread Rob Clark
Include the device id in the bus-id to give userspace a way to open the correct cardN when there are multiple device instances. Signed-off-by: Rob Clark r...@ti.com --- drivers/gpu/drm/drm_platform.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 0/3] RFC: Common functions for GEM offset creation

2011-07-18 Thread Rob Clark
and it is slightly more than half baked ;-) Rob Clark (3): drm/gem: add functions for mmap offset creation drm/i915: use common functions for mmap offset creation drm/gma500: use common functions for mmap offset creation drivers/gpu/drm/drm_gem.c| 88

[PATCH 1/3] drm/gem: add functions for mmap offset creation

2011-07-18 Thread Rob Clark
--- drivers/gpu/drm/drm_gem.c | 88 + include/drm/drmP.h|3 ++ 2 files changed, 91 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index 2b997d2..809358a 100644 ---

[PATCH 2/3] drm/i915: use common functions for mmap offset creation

2011-07-18 Thread Rob Clark
--- drivers/gpu/drm/i915/i915_gem.c | 85 +-- 1 files changed, 2 insertions(+), 83 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 5c0d124..5676eaa 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++

Re: [PATCH 0/3] RFC: Common functions for GEM offset creation

2011-07-19 Thread Rob Clark
On Tue, Jul 19, 2011 at 3:57 AM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: On Mon, 18 Jul 2011 19:20:56 -0500 Rob Clark r...@ti.com wrote: In the process of adding GEM support for OMAP DRM driver, I noticed that I was adding code for creating/freeing mmap offsets which was virtually identical

Re: [PATCH 0/3] RFC: Common functions for GEM offset creation

2011-07-19 Thread Rob Clark
On Tue, Jul 19, 2011 at 4:33 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Mon, 18 Jul 2011 19:20:56 -0500, Rob Clark r...@ti.com wrote: In the process of adding GEM support for OMAP DRM driver, I noticed that I was adding code for creating/freeing mmap offsets which was virtually

Re: [PATCH] gem: RFC: add support for private objects

2011-07-19 Thread Rob Clark
a...@linux.intel.com Tested-by: Rob Clark r...@ti.com ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/4] drm: add plane support

2011-07-22 Thread Rob Clark
On Mon, Jun 20, 2011 at 3:11 PM, Jesse Barnes jbar...@virtuousgeek.org wrote:  /** + * drm_plane_funcs - driver plane control functions + * @update_plane: update the plane configuration + */ +struct drm_plane_funcs { +       int (*update_plane)(struct drm_plane *plane, +                    

Re: [PATCH 1/4] drm: add plane support

2011-07-22 Thread Rob Clark
On Fri, Jul 22, 2011 at 10:30 AM, Jesse Barnes jbar...@virtuousgeek.org wrote: On Fri, 22 Jul 2011 08:52:52 -0500 Rob Clark robdcl...@gmail.com wrote: On Mon, Jun 20, 2011 at 3:11 PM, Jesse Barnes jbar...@virtuousgeek.org wrote:  /** + * drm_plane_funcs - driver plane control functions

Re: [PATCH 1/4] drm: add plane support

2011-07-25 Thread Rob Clark
On Mon, Jul 25, 2011 at 3:18 AM, Joonyoung Shim dofm...@gmail.com wrote: 2011/7/22 Jesse Barnes jbar...@virtuousgeek.org: On Thu, 21 Jul 2011 19:30:00 +0900 Joonyoung Shim dofm...@gmail.com wrote: Hi, simple questions :) 2011/6/21 Jesse Barnes jbar...@virtuousgeek.org: Planes are a bit

Re: [PATCH 0/3] RFC: Common functions for GEM offset creation

2011-08-04 Thread Rob Clark
On Tue, Jul 19, 2011 at 8:12 AM, Rob Clark robdcl...@gmail.com wrote: On Tue, Jul 19, 2011 at 4:33 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Mon, 18 Jul 2011 19:20:56 -0500, Rob Clark r...@ti.com wrote: In the process of adding GEM support for OMAP DRM driver, I noticed that I

[PATCH 1/9] drm/gem: add functions for mmap offset creation

2011-08-04 Thread Rob Clark
--- drivers/gpu/drm/drm_gem.c | 88 + include/drm/drmP.h|3 ++ 2 files changed, 91 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index 2b997d2..809358a 100644 ---

[PATCH 2/9] drm/i915: use common functions for mmap offset creation

2011-08-04 Thread Rob Clark
--- drivers/gpu/drm/i915/i915_gem.c | 85 +-- 1 files changed, 2 insertions(+), 83 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 5c0d124..5676eaa 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++

[PATCH 3/9] drm/gma500: use common functions for mmap offset creation

2011-08-04 Thread Rob Clark
--- drivers/staging/gma500/psb_gem.c | 63 + 1 files changed, 2 insertions(+), 61 deletions(-) diff --git a/drivers/staging/gma500/psb_gem.c b/drivers/staging/gma500/psb_gem.c index 76ff7ba..3a397f5 100644 --- a/drivers/staging/gma500/psb_gem.c +++

[PATCH 1/3] drm/gem: add functions for mmap offset creation

2011-08-10 Thread Rob Clark
Signed-off-by: Rob Clark r...@ti.com --- drivers/gpu/drm/drm_gem.c | 88 + include/drm/drmP.h|3 ++ 2 files changed, 91 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index 2b997d2

[PATCH 2/3] drm/i915: use common functions for mmap offset creation

2011-08-10 Thread Rob Clark
Signed-off-by: Rob Clark r...@ti.com --- drivers/gpu/drm/i915/i915_gem.c | 85 +-- 1 files changed, 2 insertions(+), 83 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 5c0d124..5676eaa 100644 --- a/drivers

[PATCH 3/3] drm/gma500: use common functions for mmap offset creation

2011-08-10 Thread Rob Clark
Signed-off-by: Rob Clark r...@ti.com Signed-off-by: Alan Cox a...@linux.intel.com --- drivers/staging/gma500/psb_gem.c | 63 + 1 files changed, 2 insertions(+), 61 deletions(-) diff --git a/drivers/staging/gma500/psb_gem.c b/drivers/staging/gma500/psb_gem.c

Re: Review request to DRM Driver for Samsung SoC Exynos4210.

2011-08-30 Thread Rob Clark
On Tue, Aug 30, 2011 at 7:38 AM, Inki Dae inki@samsung.com wrote: Basically gem_dumb_* and gem_* are same operation. The difference between them is that gem_dumb_ needs framebuffer information such width, height and bpp to allocate buffer and gem_ needs only size. in case of

Re: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-08-30 Thread Rob Clark
Hi Inki, Sorry for slightly overdue review.. it took a little while to go through the whole thing comments in-line below On Fri, Aug 26, 2011 at 6:47 AM, Inki Dae inki@samsung.com wrote: This patch is a DRM Driver for Samsung SoC Exynos4210 and now enables only FIMD yet but we will add

Re: [PATCH] drm: Fix the number of connector and encoder to cleanup functions

2011-08-30 Thread Rob Clark
this seems like a better fix than decrementing the count in individual drivers, but would like to hear what some 'old timers' think ;-) BR, -R On Fri, Aug 26, 2011 at 9:06 PM, Joonyoung Shim jy0922.s...@samsung.com wrote: It is left out the code to decrease the number of connector and encoder

Re: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-08-31 Thread Rob Clark
On Wed, Aug 31, 2011 at 1:51 AM, Inki Dae inki@samsung.com wrote: Hello, Rob. Below is my answers and questions. and could you please include me as CC when you post your driver? sure thing +static int samsung_drm_connector_get_modes(struct drm_connector *connector) +{ +      

Re: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-09-01 Thread Rob Clark
On Thu, Sep 1, 2011 at 8:02 PM, Kyungmin Park kmp...@infradead.org wrote: Just thinking hypothetically.. what if some future device had two hdmi controllers.  Then you'd want two instances of the same display object. Although it seems this API is just internal to the DRM driver (which I had

Re: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-09-01 Thread Rob Clark
On Thu, Sep 1, 2011 at 8:06 AM, Inki Dae inki@samsung.com wrote: +struct samsung_drm_gem_obj * +               find_samsung_drm_gem_object(struct drm_file *file_priv, +                       struct drm_device *dev, unsigned int handle) +{ +       struct drm_gem_object *gem_obj;

Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-03 Thread Rob Clark
On Sat, Sep 3, 2011 at 1:57 AM, Dave Airlie airl...@gmail.com wrote: A simple plugin mechanism is provided to allow integration with external kernel modules (*cough* PVR), but also to keep the code more modular as support is added for various other accelerator blocks that exist in various

Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-04 Thread Rob Clark
;-) Cheers, Daniel On Fri, Sep 02, 2011 at 03:07:27PM -0500, Rob Clark wrote: [snip] +int omap_connector_sync(struct drm_connector *connector) +{ +     struct omap_connector *omap_connector = to_omap_connector(connector); +     struct omap_dss_device *dssdev = omap_connector-dssdev

Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-04 Thread Rob Clark
On Sun, Sep 4, 2011 at 2:49 PM, Daniel Vetter dan...@ffwll.ch wrote: On Sun, Sep 04, 2011 at 11:29:43AM -0500, Rob Clark wrote: Above set of get/put functions seem to do very little. Drop them for the first round? The intention is to do attach/detach_pages here.. and in case of get

Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-05 Thread Rob Clark
+ * + * Copyright (C) 2011 Texas Instruments + * Author: Rob Clark r...@ti.com + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 as published by + * the Free Software Foundation. + * + * This program

Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-07 Thread Rob Clark
On Wed, Sep 7, 2011 at 1:00 AM, Inki Dae inki@samsung.com wrote: Hello, Rob. [snip] +static void page_flip_cb(void *arg) +{ +     struct drm_crtc *crtc = arg; +     struct drm_device *dev = crtc-dev; +     struct omap_crtc *omap_crtc = to_omap_crtc(crtc); +     struct

Re: [PATCH v4] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-09-10 Thread Rob Clark
On Sat, Sep 10, 2011 at 9:04 AM, Thomas Hellstrom tho...@shipmail.org wrote: On 09/09/2011 01:38 PM, Inki Dae wrote: This patch is a DRM Driver for Samsung SoC Exynos4210 and now enables only FIMD yet but we will add HDMI support also in the future. from now on, I will remove RFC prefix

[PATCH 0/6] Common functions for GEM (v2)

2011-09-12 Thread Rob Clark
From: Rob Clark r...@ti.com In the process of adding GEM support for omapdrm driver, I noticed that I was adding code for creating/freeing mmap offsets which was virtually identical to what was already duplicated in i915 and gma500 drivers. And the code for attach/detatch_pages was quite similar

[PATCH 1/6] drm/gem: add functions for mmap offset creation

2011-09-12 Thread Rob Clark
From: Rob Clark r...@ti.com Signed-off-by: Rob Clark r...@ti.com --- drivers/gpu/drm/drm_gem.c | 88 + include/drm/drmP.h|3 ++ 2 files changed, 91 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm

[PATCH 2/6] drm/i915: use common functions for mmap offset creation

2011-09-12 Thread Rob Clark
From: Rob Clark r...@ti.com Signed-off-by: Rob Clark r...@ti.com --- drivers/gpu/drm/i915/i915_gem.c | 85 +-- 1 files changed, 2 insertions(+), 83 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index a546a71

[PATCH 3/6] drm/gma500: use common functions for mmap offset creation

2011-09-12 Thread Rob Clark
From: Rob Clark r...@ti.com Signed-off-by: Rob Clark r...@ti.com Signed-off-by: Alan Cox a...@linux.intel.com --- drivers/staging/gma500/gem.c |2 +- drivers/staging/gma500/gem_glue.c | 61 + drivers/staging/gma500/gem_glue.h |1 - 3 files

[PATCH 4/6] drm/gem: add functions to get/put pages

2011-09-12 Thread Rob Clark
From: Rob Clark r...@ti.com This factors out common code from psb_gtt_attach_pages()/ i915_gem_object_get_pages_gtt() and psb_gtt_detach_pages()/ i915_gem_object_put_pages_gtt(). Signed-off-by: Rob Clark r...@ti.com --- drivers/gpu/drm/drm_gem.c | 68

[PATCH 5/6] drm/i915: use common functions for get/put pages

2011-09-12 Thread Rob Clark
From: Rob Clark r...@ti.com Signed-off-by: Rob Clark r...@ti.com --- drivers/gpu/drm/i915/i915_gem.c | 51 +++--- 1 files changed, 10 insertions(+), 41 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index ee59f31

[PATCH 6/6] drm/gma500: use common functions for get/put pages

2011-09-12 Thread Rob Clark
From: Rob Clark r...@ti.com Signed-off-by: Rob Clark r...@ti.com --- drivers/staging/gma500/gtt.c | 47 ++--- 1 files changed, 12 insertions(+), 35 deletions(-) diff --git a/drivers/staging/gma500/gtt.c b/drivers/staging/gma500/gtt.c index 461ead2..f453321

Re: [PATCH 6/6] drm/gma500: use common functions for get/put pages

2011-09-12 Thread Rob Clark
On Mon, Sep 12, 2011 at 3:31 PM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: On Mon, 12 Sep 2011 14:21:26 -0500 Rob Clark rob.cl...@linaro.org wrote: From: Rob Clark r...@ti.com Signed-off-by: Rob Clark r...@ti.com Generally looks sensible but: 1. This is a staging driver, so good practise

Re: [PATCH 4/6] drm/gem: add functions to get/put pages

2011-09-12 Thread Rob Clark
On Mon, Sep 12, 2011 at 2:21 PM, Rob Clark rob.cl...@linaro.org wrote: From: Rob Clark r...@ti.com This factors out common code from psb_gtt_attach_pages()/ i915_gem_object_get_pages_gtt() and psb_gtt_detach_pages()/ i915_gem_object_put_pages_gtt(). Signed-off-by: Rob Clark r...@ti.com

Re: [PATCH v4] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-09-13 Thread Rob Clark
On Tue, Sep 13, 2011 at 9:03 PM, Inki Dae inki@samsung.com wrote: Hi Thomas. -Original Message- From: Thomas Hellstrom [mailto:tho...@shipmail.org] Sent: Monday, September 12, 2011 3:32 PM To: Rob Clark Cc: Inki Dae; kyungmin.p...@samsung.com; sw0312@samsung.com; linux- arm

Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-14 Thread Rob Clark
On Wed, Sep 14, 2011 at 12:44 AM, Inki Dae inki@samsung.com wrote: Hello Rob. Sorry for being late. here was a national holiday. -Original Message- From: robdcl...@gmail.com [mailto:robdcl...@gmail.com] On Behalf Of Rob Clark Sent: Thursday, September 08, 2011 3:44 AM To: Inki

Re: [PATCH v4] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-09-14 Thread Rob Clark
On Wed, Sep 14, 2011 at 2:57 AM, Thomas Hellstrom tho...@shipmail.org wrote: +static struct drm_ioctl_desc samsung_ioctls[] = { +       DRM_IOCTL_DEF_DRV(SAMSUNG_GEM_CREATE, samsung_drm_gem_create_ioctl, +                       DRM_UNLOCKED | DRM_AUTH), Hi! With reference my previous

Re: Proposal for a low-level Linux display framework

2011-09-15 Thread Rob Clark
On Thu, Sep 15, 2011 at 12:21 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Thu, 2011-09-15 at 10:50 -0500, Keith Packard wrote: On Thu, 15 Sep 2011 18:29:54 +0300, Tomi Valkeinen tomi.valkei...@ti.com wrote: 1) It's part of DRM, so it doesn't help fb or v4l2 drivers. Except if the

[PATCH] drm/gem: add functions to get/put pages

2011-09-15 Thread Rob Clark
From: Rob Clark r...@ti.com This factors out common code from psb_gtt_attach_pages()/ i915_gem_object_get_pages_gtt() and psb_gtt_detach_pages()/ i915_gem_object_put_pages_gtt(). Signed-off-by: Rob Clark r...@ti.com --- drivers/gpu/drm/drm_gem.c | 87

Re: Proposal for a low-level Linux display framework

2011-09-17 Thread Rob Clark
On Sat, Sep 17, 2011 at 9:44 AM, Felipe Contreras felipe.contre...@gmail.com wrote: On Thu, Sep 15, 2011 at 9:58 PM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: One of my biggest problems with KMS is that it has (naturally) a lot more complexity than the fb API which leads to instability.

Re: Proposal for a low-level Linux display framework

2011-09-17 Thread Rob Clark
On Sat, Sep 17, 2011 at 11:11 AM, Florian Tobias Schandinat florianschandi...@gmx.de wrote: On 09/17/2011 03:16 PM, Rob Clark wrote: From userspace perspective, fbdev doesn't go away.  It is just a legacy interface provided on top of DRM/KMS driver mostly via helper functions

Re: [PATCH] RFCv2: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-18 Thread Rob Clark
On Sun, Sep 18, 2011 at 5:23 AM, Daniel Vetter dan...@ffwll.ch wrote: On Sat, Sep 17, 2011 at 04:32:09PM -0500, Rob Clark wrote: From: Rob Clark r...@ti.com A DRM display driver for TI OMAP platform.  Similar to omapfb (fbdev) and omap_vout (v4l2 display) drivers in the past, this driver uses

Re: Proposal for a low-level Linux display framework

2011-09-18 Thread Rob Clark
On Sat, Sep 17, 2011 at 6:12 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi everybody, On Thursday 15 September 2011 20:39:21 Florian Tobias Schandinat wrote: On 09/15/2011 05:52 PM, Alex Deucher wrote: Please don't claim that the DRM developers do not want to cooperate.

Re: [PATCH] RFCv2: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-18 Thread Rob Clark
On Sun, Sep 18, 2011 at 10:55 AM, Daniel Vetter dan...@ffwll.ch wrote: There's the little funny caveat though that if userspace passes in less data than the kernel expects, it's not being cleared. But that can be fixed. oh, heh, good catch.. I'll send a patch for that shortly, before I forget

[PATCH] drm: drm_ioctl() should zero-init extra data

2011-09-18 Thread Rob Clark
From: Rob Clark r...@ti.com If an older userspace passes in a smaller arg than the current kernel ioctl arg struct, then extra fields should be initialized to zero rather than passing random data to the DRM driver. Signed-off-by: Rob Clark r...@ti.com --- A potential issue that Daniel Vetter

Re: [PATCH] RFCv2: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-18 Thread Rob Clark
On Sun, Sep 18, 2011 at 2:36 PM, Thomas Hellstrom tho...@shipmail.org wrote: On 09/17/2011 11:32 PM, Rob Clark wrote: From: Rob Clarkr...@ti.com A DRM display driver for TI OMAP platform.  Similar to omapfb (fbdev) and omap_vout (v4l2 display) drivers in the past, this driver uses the DSS2

Re: [PATCH] RFCv2: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-18 Thread Rob Clark
On Sun, Sep 18, 2011 at 3:00 PM, Thomas Hellstrom tho...@shipmail.org wrote: On 09/18/2011 09:50 PM, Rob Clark wrote: On Sun, Sep 18, 2011 at 2:36 PM, Thomas Hellstromtho...@shipmail.org  wrote: On 09/17/2011 11:32 PM, Rob Clark wrote: From: Rob Clarkr...@ti.com A DRM display driver

Re: [PATCH] RFCv2: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-18 Thread Rob Clark
On Sun, Sep 18, 2011 at 3:31 PM, Thomas Hellstrom tho...@shipmail.org wrote: On 09/18/2011 10:15 PM, Rob Clark wrote: On Sun, Sep 18, 2011 at 3:00 PM, Thomas Hellstromtho...@shipmail.org  wrote: On 09/18/2011 09:50 PM, Rob Clark wrote: On Sun, Sep 18, 2011 at 2:36 PM, Thomas Hellstromtho

Re: Proposal for a low-level Linux display framework

2011-09-19 Thread Rob Clark
On Sun, Sep 18, 2011 at 5:23 PM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: This would leave us with the issue of controlling formats and other parameters on the pipelines. We could keep separate DRM, KMS, FB and V4L APIs for that, There are some other differences that matter. The exact state

Re: [PATCH] RFCv2: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-19 Thread Rob Clark
On Mon, Sep 19, 2011 at 2:44 AM, Inki Dae inki@samsung.com wrote: Hello Rob. Is there some reason that you don't head your driver gpu/drm, just staging? and below is my short comments. thank you. mainly because it is still a work-in-progress.. I expect some re-shuffling of the

Re: [PATCH v4] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-09-21 Thread Rob Clark
On Wed, Sep 21, 2011 at 7:41 AM, Marek Szyprowski m.szyprow...@samsung.com wrote: I'm not entirely sure what will happen w/ dma_alloc_coherent, etc, if the global CMA pool is exhausted. Marek?  I guess you know what would happen? The allocation will simply fail and dma_alloc_coherent will

Re: [PATCH] RFCv2: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-22 Thread Rob Clark
On Wed, Sep 21, 2011 at 5:32 PM, Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: So I did a cursory look and stopped at omap_drv.h due to the lack of time. Some comments below. +++ b/drivers/staging/omapdrm/Kconfig @@ -0,0 +1,24 @@ + +config DRM_OMAP +     tristate OMAP DRM

Re: [PATCH] drm/gem: add functions to get/put pages

2011-09-26 Thread Rob Clark
On Thu, Sep 15, 2011 at 5:47 PM, Rob Clark rob.cl...@linaro.org wrote: +/** + * drm_gem_get_pages - helper to allocate backing pages for a GEM object + * @obj: obj in question + * @gfpmask: gfp mask of requested pages + */ +struct page ** drm_gem_get_pages(struct drm_gem_object *obj, gfp_t

Re: [PATCH] drm/gem: add functions to get/put pages

2011-09-26 Thread Rob Clark
On Mon, Sep 26, 2011 at 2:43 PM, Daniel Vetter dan...@ffwll.ch wrote: On Mon, Sep 26, 2011 at 01:18:40PM -0500, Rob Clark wrote: On Thu, Sep 15, 2011 at 5:47 PM, Rob Clark rob.cl...@linaro.org wrote: +/** + * drm_gem_get_pages - helper to allocate backing pages for a GEM object + * @obj

Re: [PATCH] drm/gem: add functions to get/put pages

2011-09-26 Thread Rob Clark
On Mon, Sep 26, 2011 at 3:22 PM, Daniel Vetter dan...@ffwll.ch wrote: On Mon, Sep 26, 2011 at 21:56, Rob Clark rob.cl...@linaro.org wrote: On Mon, Sep 26, 2011 at 2:43 PM, Daniel Vetter dan...@ffwll.ch wrote: On Mon, Sep 26, 2011 at 01:18:40PM -0500, Rob Clark wrote: On Thu, Sep 15, 2011 at 5

Re: [PATCH] drm/gem: add functions to get/put pages

2011-09-27 Thread Rob Clark
On Tue, Sep 27, 2011 at 4:35 AM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: Well I think for this case the solution is simple: Tiling not allowed if userspace is too dumb to properly round the buffer up so it fulfills whatever odd requirement the hw has. I think hiding the fact that certain

Re: [PATCH v5] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-10-05 Thread Rob Clark
@samsung.com Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com Signed-off-by: SeungWoo Kim sw0312@samsung.com Signed-off-by: kyungmin.park kyungmin.p...@samsung.com Reviewed-by: Rob Clark rob.cl...@linaro.org' BR, -R ___ dri-devel mailing list dri

Re: [Linaro-mm-sig] [RFC 1/2] dma-buf: Introduce dma buffer sharing mechanism

2011-10-12 Thread Rob Clark
On Wed, Oct 12, 2011 at 7:41 AM, Dave Airlie airl...@gmail.com wrote: On Tue, Oct 11, 2011 at 10:23 AM, Sumit Semwal sumit.sem...@ti.com wrote: This is the first step in defining a dma buffer sharing mechanism. A new buffer object dma_buf is added, with operations and API to allow easy

Re: [Linaro-mm-sig] [RFC 1/2] dma-buf: Introduce dma buffer sharing mechanism

2011-10-12 Thread Rob Clark
On Wed, Oct 12, 2011 at 8:35 AM, Dave Airlie airl...@gmail.com wrote: well, the mmap is actually implemented by the buffer allocator (v4l/drm).. although not sure if this was the point Then why not use the correct interface? doing some sort of not-quite generic interface isn't really helping

Re: [Linaro-mm-sig] [RFC 1/2] dma-buf: Introduce dma buffer sharing mechanism

2011-10-12 Thread Rob Clark
On Wed, Oct 12, 2011 at 9:01 AM, Dave Airlie airl...@gmail.com wrote: But then we'd need a different set of accessors for every different drm/v4l/etc driver, wouldn't we? Not any more different than you need for this, you just have a new interface that you request a sw object from, then mmap

Re: [Linaro-mm-sig] [RFC 1/2] dma-buf: Introduce dma buffer sharing mechanism

2011-10-12 Thread Rob Clark
On Wed, Oct 12, 2011 at 9:34 AM, Dave Airlie airl...@gmail.com wrote: On Wed, Oct 12, 2011 at 3:24 PM, Rob Clark robdcl...@gmail.com wrote: On Wed, Oct 12, 2011 at 9:01 AM, Dave Airlie airl...@gmail.com wrote: But then we'd need a different set of accessors for every different drm/v4l/etc

Re: [PATCH] RFCv2: omapdrm DRM/KMS driver for TI OMAP platforms

2011-10-14 Thread Rob Clark
On Mon, Sep 26, 2011 at 8:55 AM, Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: I'm a bit undecided on some of this error handling at startup..  I guess ENOMEM is clear enough.  But some of the other parts, like connector initialization, could fail just because some hw is not

Re: [RFC 1/2] dma-buf: Introduce dma buffer sharing mechanism

2011-10-14 Thread Rob Clark
On Fri, Oct 14, 2011 at 5:00 AM, Tomasz Stanislawski t.stanisl...@samsung.com wrote: + * @attach: allows different devices to 'attach' themselves to the given + *         buffer. It might return -EBUSY to signal that backing storage + *         is already allocated and incompatible with the

Re: [PATCH] DRM: omapdrm DRM/KMS driver for TI OMAP platforms

2011-10-23 Thread Rob Clark
thx Daniel.. I'll shortly be sending an updated patch with some changes based on your comments and some TODO updates.. On Wed, Oct 19, 2011 at 8:27 AM, Daniel Vetter dan...@ffwll.ch wrote: On Fri, Oct 14, 2011 at 10:45:50AM -0500, Rob Clark wrote: [snip] +     dev-mode_config.min_width = 256

Re: [PATCH 01/11] drm: add plane support

2011-10-25 Thread Rob Clark
On Tue, Oct 25, 2011 at 9:09 AM, Jesse Barnes jbar...@virtuousgeek.org wrote: diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h index 34a0d22..dafe8df 100644 --- a/include/drm/drm_mode.h +++ b/include/drm/drm_mode.h @@ -272,8 +272,9 @@ struct drm_mode_fb_cmd2 {        __u32 bpp;  

Re: [PATCH 01/11] drm: add plane support

2011-10-25 Thread Rob Clark
On Tue, Oct 25, 2011 at 2:41 PM, Daniel Vetter dan...@ffwll.ch wrote: On Tue, Oct 25, 2011 at 11:43:09AM -0500, Rob Clark wrote: On Tue, Oct 25, 2011 at 9:09 AM, Jesse Barnes jbar...@virtuousgeek.org wrote: diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h index 34a0d22..dafe8df

Re: [PATCH] DRM planes

2011-11-03 Thread Rob Clark
On Thu, Nov 3, 2011 at 12:36 PM, Jesse Barnes jbar...@virtuousgeek.org wrote: On Thu, 3 Nov 2011 18:29:14 +0100 Daniel Vetter dan...@ffwll.ch wrote: Hi all, I've discussed this a bit on irc and consensus seems to be some ugliness due to interface impendance mistmatches in the kernel? who

Re: [PATCH 2/5] drm: add an fb creation ioctl that takes a pixel format

2011-11-07 Thread Rob Clark
On Mon, Nov 7, 2011 at 10:12 AM, Jesse Barnes jbar...@virtuousgeek.org wrote: On Mon, 7 Nov 2011 23:55:02 +0900 InKi Dae daei...@gmail.com wrote: +struct drm_mode_fb_cmd2 { +       __u32 fb_id; +       __u32 width, height; +       __u32 pixel_format; /* fourcc code from videodev2.h */

Re: [PATCH 08/11] drm/ttm: introduce callback for ttm_tt populate unpopulate

2011-11-07 Thread Rob Clark
On Thu, Nov 3, 2011 at 6:39 PM, j.gli...@gmail.com wrote: From: Jerome Glisse jgli...@redhat.com Move the page allocation and freeing to driver callback and provide ttm code helper function for those. btw, having page allocation/freeing in driver callback would solve one issue that I've been

Re: [PATCH 2/2] drm: add an fb creation ioctl that takes a pixel format

2011-11-09 Thread Rob Clark
name from videodev2.h.  Implement the fb creation hooks in terms of the new mode_fb_cmd2 using helpers where the old bpp/depth values are needed. Acked-by: Alan Cox a...@lxorguk.ukuu.org.uk Reviewed-by: Rob Clark rob.cl...@linaro.org Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org

Re: [PATCH 2/2] drm: add an fb creation ioctl that takes a pixel format

2011-11-10 Thread Rob Clark
On Thu, Nov 10, 2011 at 8:54 AM, InKi Dae daei...@gmail.com wrote: 2011/11/9 Rob Clark robdcl...@gmail.com: On Wed, Nov 9, 2011 at 7:25 AM, InKi Dae daei...@gmail.com wrote: Hello, all. I am trying to implement multi planer using your plane patch and I think it's good but I am still warried

Re: [PATCH 2/2] drm: add an fb creation ioctl that takes a pixel format v4

2011-11-14 Thread Rob Clark
On Mon, Nov 14, 2011 at 3:16 PM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Mon, Nov 14, 2011 at 12:21:55PM -0800, Jesse Barnes wrote: +#define fourcc_code(a,b,c,d) ((u32)(a) | ((u32)(b) 8) | \ +                           ((u32)(c) 16) | ((u32)(d) 24)) + +/* RGB codes */

Re: drm pixel formats update

2011-11-17 Thread Rob Clark
On Thu, Nov 17, 2011 at 11:06 AM, Jesse Barnes jbar...@virtuousgeek.org wrote: On Thu, 17 Nov 2011 00:20:44 +0200 Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Wed, Nov 16, 2011 at 01:23:01PM -0800, Jesse Barnes wrote: On Wed, 16 Nov 2011 23:19:38 +0200 Ville Syrjälä

Re: [Linaro-mm-sig] [RFC 1/2] dma-buf: Introduce dma buffer sharing mechanism

2011-11-26 Thread Rob Clark
On Sat, Nov 26, 2011 at 8:00 AM, Daniel Vetter dan...@ffwll.ch wrote: On Fri, Nov 25, 2011 at 17:28, Dave Airlie airl...@gmail.com wrote: I've rebuilt my PRIME interface on top of dmabuf to see how it would work, I've got primed gears running again on top, but I expect all my object lifetime

Re: [RFC v2 1/2] dma-buf: Introduce dma buffer sharing mechanism

2011-12-05 Thread Rob Clark
On Mon, Dec 5, 2011 at 11:18 AM, Arnd Bergmann a...@arndb.de wrote: On Friday 02 December 2011, Sumit Semwal wrote: This is the first step in defining a dma buffer sharing mechanism. This looks very nice, but there are a few things I don't understand yet and a bunch of trivial comments I have

Re: [RFC v2 1/2] dma-buf: Introduce dma buffer sharing mechanism

2011-12-05 Thread Rob Clark
On Mon, Dec 5, 2011 at 3:23 PM, Daniel Vetter dan...@ffwll.ch wrote: On Mon, Dec 05, 2011 at 02:46:47PM -0600, Rob Clark wrote: On Mon, Dec 5, 2011 at 11:18 AM, Arnd Bergmann a...@arndb.de wrote: In the patch 2, you have a section about migration that mentions that it is possible to export

Re: [RFC v2 1/2] dma-buf: Introduce dma buffer sharing mechanism

2011-12-05 Thread Rob Clark
On Mon, Dec 5, 2011 at 4:09 PM, Arnd Bergmann a...@arndb.de wrote: https://github.com/robclark/kernel-omap4/commits/dmabuf Ok, thanks. I think it would be good to post these for reference in v3, with a clear indication that they are not being submitted for discussion/inclusion yet. btw,

Re: [RFC v2 1/2] dma-buf: Introduce dma buffer sharing mechanism

2011-12-05 Thread Rob Clark
On Mon, Dec 5, 2011 at 4:09 PM, Arnd Bergmann a...@arndb.de wrote: On Monday 05 December 2011 14:46:47 Rob Clark wrote: I sort of preferred having the DMABUF shim because that lets you pass a buffer around userspace without the receiving code knowing about a device specific API

[PATCH 0/2] omap/drm: dmm/tiler support for GEM buffers

2011-12-05 Thread Rob Clark
From: Rob Clark r...@ti.com Support for DMM and tiled buffers. The DMM/TILER block in omap4+ SoC provides support for remapping physically discontiguous buffers for various DMA initiators (DSS, IVAHD, etc) which do not otherwise support non-physically contiguous buffers, as well as providing

[PATCH 2/2] drm/omap: add GEM support for tiled/dmm buffers

2011-12-05 Thread Rob Clark
From: Rob Clark r...@ti.com TILER/DMM provides two features for omapdrm GEM objects: 1) providing a physically contiguous view to discontiguous memory for hw initiators that cannot otherwise support discontiguous buffers (DSS scanout, IVAHD video decode/encode, etc) 2) providing untiling

Re: [PATCH 2/2] drm/omap: add GEM support for tiled/dmm buffers

2011-12-06 Thread Rob Clark
On Tue, Dec 6, 2011 at 5:30 AM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: On Mon,  5 Dec 2011 19:19:22 -0600 Rob Clark rob.cl...@linaro.org wrote: +     usergart = kzalloc(3 * sizeof(*usergart), GFP_KERNEL); + +     /* reserve 4k aligned/wide regions for userspace mappings: */ +     for (i

drm_framebuffer_cleanup cleanup..

2011-12-09 Thread Rob Clark
On Wed, Oct 19, 2011 at 8:27 AM, Daniel Vetter dan...@ffwll.ch wrote: +static void omap_framebuffer_destroy(struct drm_framebuffer *fb) +{ +     struct drm_device *dev = fb-dev; +     struct omap_framebuffer *omap_fb = to_omap_framebuffer(fb); + +     DBG(destroy: FB ID: %d (%p), fb-base.id,

  1   2   3   4   5   6   7   8   9   10   >