Re: [RFC 4/6] drm: Add simple fdinfo memory helpers

2023-04-19 Thread Rob Clark
On Wed, Apr 19, 2023 at 6:16 AM Tvrtko Ursulin wrote: > > > On 18/04/2023 18:18, Rob Clark wrote: > > On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin > > wrote: > >> > >> From: Tvrtko Ursulin > >> > >> For drivers who only wish to show on

Re: [RFC 4/6] drm: Add simple fdinfo memory helpers

2023-04-18 Thread Rob Clark
On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > For drivers who only wish to show one memory region called 'system, > and only account the GEM buffer object handles under it. > > Signed-off-by: Tvrtko Ursulin > --- > drivers/gpu/drm/drm_file.c | 45 +++

Re: [RFC 3/6] drm: Add fdinfo memory stats

2023-04-18 Thread Rob Clark
On Tue, Apr 18, 2023 at 9:44 AM Tvrtko Ursulin wrote: > > > On 18/04/2023 17:13, Rob Clark wrote: > > On Tue, Apr 18, 2023 at 7:46 AM Tvrtko Ursulin > > wrote: > >> On 18/04/2023 15:36, Rob Clark wrote: > >>> On Tue, Apr 18, 2023 at 7:19 AM Tvrtko Ursuli

[PATCH] drm/msm/atomic: Don't try async if crtc not active

2023-04-18 Thread Rob Clark
From: Rob Clark For a similar reason as commit f2c7ca890182 ("drm/atomic-helper: Don't set deadline for modesets"), we need the crtc to be already active in order to compute a target vblank time for an async commit. Otherwise we get this splat reminding us that we are

Re: [RFC 3/6] drm: Add fdinfo memory stats

2023-04-18 Thread Rob Clark
On Tue, Apr 18, 2023 at 7:46 AM Tvrtko Ursulin wrote: > > > On 18/04/2023 15:36, Rob Clark wrote: > > On Tue, Apr 18, 2023 at 7:19 AM Tvrtko Ursulin > > wrote: > >> > >> > >> On 18/04/2023 14:49, Rob Clark wrote: > >>>

Re: [RFC 6/6] drm/i915: Implement fdinfo memory stats printing

2023-04-18 Thread Rob Clark
On Tue, Apr 18, 2023 at 7:58 AM Tvrtko Ursulin wrote: > > > On 18/04/2023 15:39, Rob Clark wrote: > > On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin > > wrote: > >> > >> From: Tvrtko Ursulin > >> > >> Show how more driver specific set of

Re: [RFC 3/3] drm/msm: Add comm/cmdline fields

2023-04-18 Thread Rob Clark
On Tue, Apr 18, 2023 at 1:53 AM Tvrtko Ursulin wrote: > > > On 17/04/2023 21:12, Rob Clark wrote: > > From: Rob Clark > > > > Normally this would be the same information that can be obtained in > > other ways. But in some cases the process opening the drm fd

Re: [RFC 6/6] drm/i915: Implement fdinfo memory stats printing

2023-04-18 Thread Rob Clark
On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Show how more driver specific set of memory stats could be shown, > more specifically where object can reside in multiple regions, showing all > the supported stats, and where there is more to show than just user v

Re: [RFC 3/6] drm: Add fdinfo memory stats

2023-04-18 Thread Rob Clark
On Tue, Apr 18, 2023 at 7:19 AM Tvrtko Ursulin wrote: > > > On 18/04/2023 14:49, Rob Clark wrote: > > On Tue, Apr 18, 2023 at 2:00 AM Tvrtko Ursulin > > wrote: > >> > >> > >> On 17/04/2023 20:39, Rob Clark wrote: > >>>

Re: [RFC 2/3] drm/msm: Rework get_comm_cmdline() helper

2023-04-18 Thread Rob Clark
On Tue, Apr 18, 2023 at 1:34 AM Daniel Vetter wrote: > > On Tue, Apr 18, 2023 at 09:27:49AM +0100, Tvrtko Ursulin wrote: > > > > On 17/04/2023 21:12, Rob Clark wrote: > > > From: Rob Clark > > > > > > Make it work in terms of ctx so that it can be

Re: [RFC 3/6] drm: Add fdinfo memory stats

2023-04-18 Thread Rob Clark
On Tue, Apr 18, 2023 at 3:47 AM Tvrtko Ursulin wrote: > > > On 17/04/2023 17:20, Christian König wrote: > > Am 17.04.23 um 17:56 schrieb Tvrtko Ursulin: > >> From: Tvrtko Ursulin > >> > >> Add support to dump GEM stats to fdinfo. > >> > >> Signed-off-by: Tvrtko Ursulin > >> --- > >> Documentat

Re: [RFC 3/6] drm: Add fdinfo memory stats

2023-04-18 Thread Rob Clark
On Tue, Apr 18, 2023 at 2:00 AM Tvrtko Ursulin wrote: > > > On 17/04/2023 20:39, Rob Clark wrote: > > On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin > > wrote: > >> > >> From: Tvrtko Ursulin > >> > >> Add support to dump GEM

[PATCH] drm/msm: Move cmdstream dumping out of sched kthread

2023-04-17 Thread Rob Clark
From: Rob Clark This is something that can block for arbitrary amounts of time as userspace consumes from the FIFO. So we don't really want this to be in the fence signaling path. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_submit.c | 2 ++ drivers/gpu/drm/msm/msm_

[PATCH] drm/msm: Fix vmap madv warning

2023-04-17 Thread Rob Clark
From: Rob Clark Commit d6ae7d1cd58e ("drm/msm/gem: Simplify vmap vs LRU tracking") introduced a splat in the pin_pages_locked() path for buffers that had been MADV_DONTNEED. [ cut here ] msm_obj->madv != 0 WARNING: CPU: 1 PID: 144 at driver

Re: [RFC 0/3] drm: Add comm/cmdline fdinfo fields

2023-04-17 Thread Rob Clark
On Mon, Apr 17, 2023 at 1:12 PM Rob Clark wrote: > > From: Rob Clark > > When many of the things using the GPU are processes in a VM guest, the > actual client process is just a proxy. The msm driver has a way to let > the proxy tell the kernel the actual VM client process

[RFC 3/3] drm/msm: Add comm/cmdline fields

2023-04-17 Thread Rob Clark
From: Rob Clark Normally this would be the same information that can be obtained in other ways. But in some cases the process opening the drm fd is merely a sort of proxy for the actual process using the GPU. This is the case for guest VM processes using the GPU via virglrenderer, in which

[RFC 2/3] drm/msm: Rework get_comm_cmdline() helper

2023-04-17 Thread Rob Clark
From: Rob Clark Make it work in terms of ctx so that it can be re-used for fdinfo. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 4 ++-- drivers/gpu/drm/msm/msm_drv.c | 2 ++ drivers/gpu/drm/msm/msm_gpu.c | 13 ++--- drivers/gpu/drm/msm

[RFC 1/3] drm/doc: Relax fdinfo string constraints

2023-04-17 Thread Rob Clark
From: Rob Clark The restriction about no whitespace, etc, really only applies to the usage of strings in keys. Values can contain anything (other than newline). Signed-off-by: Rob Clark --- Documentation/gpu/drm-usage-stats.rst | 29 ++- 1 file changed, 15 insertions

[RFC 0/3] drm: Add comm/cmdline fdinfo fields

2023-04-17 Thread Rob Clark
From: Rob Clark When many of the things using the GPU are processes in a VM guest, the actual client process is just a proxy. The msm driver has a way to let the proxy tell the kernel the actual VM client process's executable name and command-line, which has until now been used simply fo

[PATCH] drm/docs: Fix usage stats typos

2023-04-17 Thread Rob Clark
From: Rob Clark Fix a couple missing ':'s. Signed-off-by: Rob Clark --- Documentation/gpu/drm-usage-stats.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/gpu/drm-usage-stats.rst b/Documentation/gpu/drm-usage-stats.rst index b46327356e80..72

Re: [RFC 3/6] drm: Add fdinfo memory stats

2023-04-17 Thread Rob Clark
On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Add support to dump GEM stats to fdinfo. > > Signed-off-by: Tvrtko Ursulin > --- > Documentation/gpu/drm-usage-stats.rst | 12 +++ > drivers/gpu/drm/drm_file.c| 52 +++ > i

Re: [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-17 Thread Rob Clark
On Mon, Apr 17, 2023 at 7:20 AM Tvrtko Ursulin wrote: > > > On 17/04/2023 14:42, Rob Clark wrote: > > On Mon, Apr 17, 2023 at 4:10 AM Tvrtko Ursulin > > wrote: > >> > >> > >> On 16/04/2023 08:48, Daniel Vetter wrote: > >>> On Fri, Apr

Re: [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-17 Thread Rob Clark
On Mon, Apr 17, 2023 at 4:10 AM Tvrtko Ursulin wrote: > > > On 16/04/2023 08:48, Daniel Vetter wrote: > > On Fri, Apr 14, 2023 at 06:40:27AM -0700, Rob Clark wrote: > >> On Fri, Apr 14, 2023 at 1:57 AM Tvrtko Ursulin > >> wrote: > >>> > &g

Re: [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-14 Thread Rob Clark
023 at 01:58:34PM +0100, Tvrtko Ursulin wrote: > >>>> > >>>> On 12/04/2023 20:18, Daniel Vetter wrote: > >>>>> On Wed, Apr 12, 2023 at 11:42:07AM -0700, Rob Clark wrote: > >>>>>> On Wed, Apr 12, 2023 at 11:17 AM Daniel Vetter wrote: &

Re: [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-13 Thread Rob Clark
On Thu, Apr 13, 2023 at 9:40 AM Tvrtko Ursulin wrote: > > > On 13/04/2023 14:27, Daniel Vetter wrote: > > On Thu, Apr 13, 2023 at 01:58:34PM +0100, Tvrtko Ursulin wrote: > >> > >> On 12/04/2023 20:18, Daniel Vetter wrote: > >>> On Wed, Apr 12, 2023 at

Re: [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-13 Thread Rob Clark
On Thu, Apr 13, 2023 at 5:58 AM Tvrtko Ursulin wrote: > > > On 12/04/2023 20:18, Daniel Vetter wrote: > > On Wed, Apr 12, 2023 at 11:42:07AM -0700, Rob Clark wrote: > >> On Wed, Apr 12, 2023 at 11:17 AM Daniel Vetter wrote: > >>> > >>> On Wed, A

Re: [PATCH v4 4/6] drm/i915: Switch to fdinfo helper

2023-04-13 Thread Rob Clark
On Thu, Apr 13, 2023 at 6:07 AM Tvrtko Ursulin wrote: > > > On 12/04/2023 23:42, Rob Clark wrote: > > From: Rob Clark > > There is more do to here to remove my client->id fully (would now be > dead code) so maybe easiest if you drop this patch and I do it after you &g

[PATCH v4 6/6] drm/msm: Add memory stats to fdinfo

2023-04-12 Thread Rob Clark
From: Rob Clark Use the new helper to export stats about memory usage. v2: Drop unintended hunk v3: Rebase Signed-off-by: Rob Clark Reviewed-by: Emil Velikov --- drivers/gpu/drm/msm/msm_gem.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_gem.c

[PATCH v4 5/6] drm: Add fdinfo memory stats

2023-04-12 Thread Rob Clark
From: Rob Clark Add support to dump GEM stats to fdinfo. v2: Fix typos, change size units to match docs, use div_u64 v3: Do it in core v4: more kerneldoc Signed-off-by: Rob Clark Reviewed-by: Emil Velikov Reviewed-by: Daniel Vetter --- Documentation/gpu/drm-usage-stats.rst | 21

[PATCH v4 4/6] drm/i915: Switch to fdinfo helper

2023-04-12 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- drivers/gpu/drm/i915/i915_driver.c | 3 ++- drivers/gpu/drm/i915/i915_drm_client.c | 18 +- drivers/gpu/drm/i915/i915_drm_client.h | 2 +- 3 files changed, 8 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/i915

[PATCH v4 3/6] drm/amdgpu: Switch to fdinfo helper

2023-04-12 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c | 16 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.h | 2 +- 3 files changed, 9 insertions(+), 12 deletions(-) diff --git a/drivers/gpu

[PATCH v4 1/6] drm: Add common fdinfo helper

2023-04-12 Thread Rob Clark
From: Rob Clark Handle a bit of the boiler-plate in a single case, and make it easier to add some core tracked stats. v2: Update drm-usage-stats.rst, 64b client-id, rename drm_show_fdinfo Reviewed-by: Daniel Vetter Signed-off-by: Rob Clark --- Documentation/gpu/drm-usage-stats.rst | 10

[PATCH v4 2/6] drm/msm: Switch to fdinfo helper

2023-04-12 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_drv.c | 11 +-- drivers/gpu/drm/msm/msm_gpu.c | 2 -- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 5a10d28de9dd..3d73b98d6a9c

[PATCH v4 0/6] drm: fdinfo memory stats

2023-04-12 Thread Rob Clark
From: Rob Clark Similar motivation to other similar recent attempt[1]. But with an attempt to have some shared code for this. As well as documentation. It is probably a bit UMA-centric, I guess devices with VRAM might want some placement stats as well. But this seems like a reasonable start

Re: [PATCH v3 5/7] drm/etnaviv: Switch to fdinfo helper

2023-04-12 Thread Rob Clark
On Wed, Apr 12, 2023 at 12:59 AM Daniel Vetter wrote: > > On Tue, Apr 11, 2023 at 03:56:10PM -0700, Rob Clark wrote: > > From: Rob Clark > > > > Signed-off-by: Rob Clark > > You're on an old tree, this got reverted. But I'm kinda wondering whether >

Re: [Freedreno] [PATCH v2 0/2] drm: fdinfo memory stats

2023-04-12 Thread Rob Clark
On Wed, Apr 12, 2023 at 1:19 PM Dmitry Baryshkov wrote: > > On Wed, 12 Apr 2023 at 23:09, Rob Clark wrote: > > > > On Wed, Apr 12, 2023 at 5:47 AM Rodrigo Vivi wrote: > > > > > > On Wed, Apr 12, 2023 at 10:11:32AM +0200, Daniel Vetter wrote: > > &g

Re: [Freedreno] [PATCH v2 0/2] drm: fdinfo memory stats

2023-04-12 Thread Rob Clark
On Wed, Apr 12, 2023 at 5:47 AM Rodrigo Vivi wrote: > > On Wed, Apr 12, 2023 at 10:11:32AM +0200, Daniel Vetter wrote: > > On Wed, Apr 12, 2023 at 01:36:52AM +0300, Dmitry Baryshkov wrote: > > > On 11/04/2023 21:28, Rob Clark wrote: > > > > On Tue, Apr 11,

Re: [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-12 Thread Rob Clark
On Wed, Apr 12, 2023 at 11:17 AM Daniel Vetter wrote: > > On Wed, Apr 12, 2023 at 10:59:54AM -0700, Rob Clark wrote: > > On Wed, Apr 12, 2023 at 7:42 AM Tvrtko Ursulin > > wrote: > > > > > > > > > On 11/04/2023 23:56, Rob Clark wrote: > > >

Re: [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-12 Thread Rob Clark
On Wed, Apr 12, 2023 at 7:42 AM Tvrtko Ursulin wrote: > > > On 11/04/2023 23:56, Rob Clark wrote: > > From: Rob Clark > > > > Add support to dump GEM stats to fdinfo. > > > > v2: Fix typos, change size units to match docs, use div_u64 > > v3: D

[PATCH v3 7/7] drm/msm: Add memory stats to fdinfo

2023-04-11 Thread Rob Clark
From: Rob Clark Use the new helper to export stats about memory usage. v2: Drop unintended hunk v3: Rebase Signed-off-by: Rob Clark Reviewed-by: Emil Velikov --- drivers/gpu/drm/msm/msm_gem.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_gem.c

[PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-11 Thread Rob Clark
From: Rob Clark Add support to dump GEM stats to fdinfo. v2: Fix typos, change size units to match docs, use div_u64 v3: Do it in core Signed-off-by: Rob Clark Reviewed-by: Emil Velikov --- Documentation/gpu/drm-usage-stats.rst | 21 drivers/gpu/drm/drm_file.c| 76

[PATCH v3 5/7] drm/etnaviv: Switch to fdinfo helper

2023-04-11 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c index 44ca803237a5..17d6af94 100644 --- a/drivers

[PATCH v3 4/7] drm/i915: Switch to fdinfo helper

2023-04-11 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- drivers/gpu/drm/i915/i915_driver.c | 3 ++- drivers/gpu/drm/i915/i915_drm_client.c | 18 +- drivers/gpu/drm/i915/i915_drm_client.h | 2 +- 3 files changed, 8 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/i915

[PATCH v3 3/7] drm/amdgpu: Switch to fdinfo helper

2023-04-11 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c | 16 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.h | 2 +- 3 files changed, 9 insertions(+), 12 deletions(-) diff --git a/drivers/gpu

[PATCH v3 1/7] drm: Add common fdinfo helper

2023-04-11 Thread Rob Clark
From: Rob Clark Handle a bit of the boiler-plate in a single case, and make it easier to add some core tracked stats. Signed-off-by: Rob Clark --- drivers/gpu/drm/drm_file.c | 39 ++ include/drm/drm_drv.h | 7 +++ include/drm/drm_file.h | 4

[PATCH v3 2/7] drm/msm: Switch to fdinfo helper

2023-04-11 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_drv.c | 11 +-- drivers/gpu/drm/msm/msm_gpu.c | 2 -- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 5a10d28de9dd..e516a3544505

[PATCH v3 0/7] drm: fdinfo memory stats

2023-04-11 Thread Rob Clark
From: Rob Clark Similar motivation to other similar recent attempt[1]. But with an attempt to have some shared code for this. As well as documentation. It is probably a bit UMA-centric, I guess devices with VRAM might want some placement stats as well. But this seems like a reasonable start

Re: [Freedreno] [PATCH v2 0/2] drm: fdinfo memory stats

2023-04-11 Thread Rob Clark
On Tue, Apr 11, 2023 at 10:36 AM Dmitry Baryshkov wrote: > > On Tue, 11 Apr 2023 at 20:13, Rob Clark wrote: > > > > On Tue, Apr 11, 2023 at 9:53 AM Daniel Vetter wrote: > > > > > > On Tue, Apr 11, 2023 at 09:47:32AM -0700, Rob Clark wrote: > > >

Re: [PATCH v2 0/2] drm: fdinfo memory stats

2023-04-11 Thread Rob Clark
On Tue, Apr 11, 2023 at 9:53 AM Daniel Vetter wrote: > > On Tue, Apr 11, 2023 at 09:47:32AM -0700, Rob Clark wrote: > > On Mon, Apr 10, 2023 at 2:06 PM Rob Clark wrote: > > > > > > From: Rob Clark > > > > > > Similar motivation to other similar

Re: [PATCH v2 0/2] drm: fdinfo memory stats

2023-04-11 Thread Rob Clark
On Mon, Apr 10, 2023 at 2:06 PM Rob Clark wrote: > > From: Rob Clark > > Similar motivation to other similar recent attempt[1]. But with an > attempt to have some shared code for this. As well as documentation. > > It is probably a bit UMA-centric, I guess devices with V

Re: [pull] drm/msm: drm-msm-next-2023-04-10 for v6.4

2023-04-11 Thread Rob Clark
On Tue, Apr 11, 2023 at 8:00 AM Daniel Vetter wrote: > > On Tue, Apr 11, 2023 at 07:55:33AM -0700, Rob Clark wrote: > > On Tue, Apr 11, 2023 at 3:27 AM Daniel Vetter wrote: > > > > Konrad Dybcio (18): > > > > drm/msm/adreno: Use OPP for every GPU gen

Re: [PATCH v2 1/2] drm: Add fdinfo memory stats

2023-04-11 Thread Rob Clark
On Tue, Apr 11, 2023 at 3:43 AM Daniel Vetter wrote: > > On Mon, Apr 10, 2023 at 02:06:06PM -0700, Rob Clark wrote: > > From: Rob Clark > > > > Add a helper to dump memory stats to fdinfo. For the things the drm > > core isn't aware of, use a callback. >

Re: [pull] drm/msm: drm-msm-next-2023-04-10 for v6.4

2023-04-11 Thread Rob Clark
On Tue, Apr 11, 2023 at 3:27 AM Daniel Vetter wrote: > > On Mon, Apr 10, 2023 at 07:50:50AM -0700, Rob Clark wrote: > > Hi Dave, > > > > This is the main pull for v6.4, see below for description. A bit big > > this time because of (1) generated header updates and

[PATCH v2 2/2] drm/msm: Add memory stats to fdinfo

2023-04-10 Thread Rob Clark
From: Rob Clark Use the new helper to export stats about memory usage. v2: Drop unintended hunk Signed-off-by: Rob Clark Reviewed-by: Emil Velikov --- drivers/gpu/drm/msm/msm_drv.c | 25 - drivers/gpu/drm/msm/msm_gpu.c | 2 -- 2 files changed, 24 insertions(+), 3

[PATCH v2 0/2] drm: fdinfo memory stats

2023-04-10 Thread Rob Clark
From: Rob Clark Similar motivation to other similar recent attempt[1]. But with an attempt to have some shared code for this. As well as documentation. It is probably a bit UMA-centric, I guess devices with VRAM might want some placement stats as well. But this seems like a reasonable start

[PATCH v2 1/2] drm: Add fdinfo memory stats

2023-04-10 Thread Rob Clark
From: Rob Clark Add a helper to dump memory stats to fdinfo. For the things the drm core isn't aware of, use a callback. v2: Fix typos, change size units to match docs, use div_u64 Signed-off-by: Rob Clark Reviewed-by: Emil Velikov --- Documentation/gpu/drm-usage-stats.rst

Re: [RFC 1/2] drm: Add fdinfo memory stats

2023-04-10 Thread Rob Clark
On Sat, Apr 8, 2023 at 5:20 AM Emil Velikov wrote: > > Hey Rob, > > On Thu, 6 Apr 2023 at 22:59, Rob Clark wrote: > > > +- drm-purgeable-memory: [KiB|MiB] > > + > > +The total size of buffers that are purgable. > > s/purgable/purgeable/ > > >

[pull] drm/msm: drm-msm-next-2023-04-10 for v6.4

2023-04-10 Thread Rob Clark
_job_add_syncobj_dependency() Neil Armstrong (4): dt-bindings: display/msm: document MDSS on SM8550 dt-bindings: display: msm: sm8450-mdss: Fix DSI compatible dt-bindings: display/msm: document DPU on SM8550 dt-bindings: display: msm: dp-controller: document SM8450 c

Re: [RFC 2/2] drm/msm: Add memory stats to fdinfo

2023-04-09 Thread Rob Clark
On Sat, Apr 8, 2023 at 5:28 AM Emil Velikov wrote: > > On Thu, 6 Apr 2023 at 22:59, Rob Clark wrote: > > > > From: Rob Clark > > > > Use the new helper to export stats about memory usage. > > > > Signed-off-by: Rob Clark >

[RFC 2/2] drm/msm: Add memory stats to fdinfo

2023-04-06 Thread Rob Clark
From: Rob Clark Use the new helper to export stats about memory usage. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_drv.c | 26 +- drivers/gpu/drm/msm/msm_gpu.c | 2 -- 2 files changed, 25 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm

[RFC 1/2] drm: Add fdinfo memory stats

2023-04-06 Thread Rob Clark
From: Rob Clark Add a helper to dump memory stats to fdinfo. For the things the drm core isn't aware of, use a callback. Signed-off-by: Rob Clark --- Documentation/gpu/drm-usage-stats.rst | 21 +++ drivers/gpu/drm/drm_file.c| 79 +++ includ

[RFC 0/2] drm: fdinfo memory stats

2023-04-06 Thread Rob Clark
From: Rob Clark Similar motivation to other similar recent attempt[1]. But with an attempt to have some shared code for this. As well as documentation. It is probably a bit UMA-centric, I guess devices with VRAM might want some placement stats as well. But this seems like a reasonable start

Re: [Intel-gfx] [PATCH] drm/atomic-helper: Don't set deadline for modesets

2023-04-05 Thread Rob Clark
so skip on inactive crtc (Ville) > > Link: > https://lore.kernel.org/dri-devel/dfc21f18-7e1e-48f0-c05a-d659b9c90...@linaro.org/ > Fixes: d39e48ca80c0 ("drm/atomic-helper: Set fence deadline for vblank") > Cc: Ville Syrjälä > Cc: Rob Clark > Cc: Daniel Vetter > Cc:

Re: [PATCH v2] drm/vblank: Fix for drivers that do not drm_vblank_init()

2023-04-03 Thread Rob Clark
On Mon, Apr 3, 2023 at 9:25 AM Nathan Chancellor wrote: > > On Mon, Apr 03, 2023 at 09:03:14AM -0700, Rob Clark wrote: > > From: Rob Clark > > > > This should fix a crash that was reported on ast (and possibly other > > drivers which do not initialize vblank).

[PATCH] drm/vblank: Simplify drm_dev_has_vblank()

2023-04-03 Thread Rob Clark
From: Rob Clark What does vblank have to do with num_crtcs? Well, this was technically correct, but you'd have to go look at where num_crtcs is initialized to understand why. Lets just replace it with the simpler and more obvious check. Signed-off-by: Rob Clark --- drivers/gp

[PATCH v2] drm/vblank: Fix for drivers that do not drm_vblank_init()

2023-04-03 Thread Rob Clark
From: Rob Clark This should fix a crash that was reported on ast (and possibly other drivers which do not initialize vblank). fbcon: Taking over console Unable to handle kernel NULL pointer dereference at virtual address 0074 Mem abort info: ESR = 0x9604

Re: [syzbot] [dri?] general protection fault in drm_crtc_next_vblank_start

2023-04-03 Thread Rob Clark
e.googleapis.com/syzbot-assets/fabbf89c0d22/vmlinux-a6d9e303.xz > kernel image: > https://storage.googleapis.com/syzbot-assets/1ed05d6192fa/bzImage-a6d9e303.xz > > The issue was bisected to: > > commit d39e48ca80c0960b039cb38633957f0040f63e1a > Author: Rob Clark > Date: Fr

Re: [PATCH v10 11/15] drm/atomic-helper: Set fence deadline for vblank

2023-04-01 Thread Rob Clark
On Fri, Mar 31, 2023 at 4:30 PM Nathan Chancellor wrote: > > On Fri, Mar 31, 2023 at 03:14:30PM -0700, Rob Clark wrote: > > On Fri, Mar 31, 2023 at 1:44 PM Nathan Chancellor wrote: > > > > > > Hi Rob, > > > > > > On Wed, Mar 08, 2023 at 07:53:02AM

[PATCH] drm/vblank: Fix for drivers that do not drm_vblank_init()

2023-04-01 Thread Rob Clark
From: Rob Clark This should fix a crash that was reported on ast (and possibly other drivers which do not initialize vblank). fbcon: Taking over console Unable to handle kernel NULL pointer dereference at virtual address 0074 Mem abort info: ESR = 0x9604

Re: [PATCH v10 11/15] drm/atomic-helper: Set fence deadline for vblank

2023-03-31 Thread Rob Clark
On Fri, Mar 31, 2023 at 1:44 PM Nathan Chancellor wrote: > > Hi Rob, > > On Wed, Mar 08, 2023 at 07:53:02AM -0800, Rob Clark wrote: > > From: Rob Clark > > > > For an atomic commit updating a single CRTC (ie. a pageflip) calculate > > the next vblank t

Re: [PATCH] Revert "drm/sched: Use parent fence instead of finished"

2023-03-31 Thread Rob Clark
On Fri, Dec 2, 2022 at 9:24 AM Arvind Yadav wrote: > > This reverts commit e4dc45b1848bc6bcac31eb1b4ccdd7f6718b3c86. > > This is causing instability on Linus' desktop, and Observed System > hung when running MesaGL benchmark or VK CTS runs. > > netconsole got me the following oops: >

Re: linux-next: build warning after merge of the drm tree

2023-03-30 Thread Rob Clark
On Wed, Mar 29, 2023 at 8:28 PM Stephen Rothwell wrote: > > Hi all, > > After merging the drm tree, today's linux-next build (htmldocs) produced > this warning: > > include/uapi/linux/sync_file.h:77: warning: Function parameter or member > 'num_fences' not described in 'sync_file_info' > thanks,

[PATCH] dma-buf/sync_file: Fix doc build warning

2023-03-30 Thread Rob Clark
From: Rob Clark Fixes warning: include/uapi/linux/sync_file.h:77: warning: Function parameter or member 'num_fences' not described in 'sync_file_info' Reported-by: Stephen Rothwell Fixes: 2d75c88fefb2 ("staging/android: refactor SYNC IOCTLs") Signed-off-by

Re: [PATCH] drm/msm/adreno: adreno_gpu: Use suspend() instead of idle() on load error

2023-03-29 Thread Rob Clark
On Wed, Mar 29, 2023 at 8:48 AM Konrad Dybcio wrote: > > > > On 29.03.2023 16:37, Johan Hovold wrote: > > On Wed, Mar 29, 2023 at 04:04:44PM +0200, Konrad Dybcio wrote: > >> If we fail to initialize the GPU for whatever reason (say we don't > >> embed the GPU firmware files in the initrd), the err

Re: [pull] drm: dma-fence-deadline-core for v6.4

2023-03-28 Thread Rob Clark
On Tue, Mar 28, 2023 at 10:19 AM Daniel Vetter wrote: > > On Sat, Mar 25, 2023 at 11:24:56AM -0700, Rob Clark wrote: > > Hi Dave and Daniel, > > > > Here is the series for dma-fence deadline hint, without driver > > specific patches, with the intent that it can be me

[pull] drm: dma-fence-deadline for v6.4

2023-03-28 Thread Rob Clark
ignaled before issuing the atomic ioctl, for example to maintain 60fps cursor updates even when the GPU is not able to maintain that framerate. -------- Rob Clark (8): dma-buf/dma-fence: Add deadline awareness dma-buf/fence-

Re: [pull] drm: dma-fence-deadline-core for v6.4

2023-03-28 Thread Rob Clark
On Tue, Mar 28, 2023 at 10:19 AM Daniel Vetter wrote: > > On Sat, Mar 25, 2023 at 11:24:56AM -0700, Rob Clark wrote: > > Hi Dave and Daniel, > > > > Here is the series for dma-fence deadline hint, without driver > > specific patches, with the intent that it can be me

Re: [PATCH] drm/msm: Avoid rounding down to zero jiffies

2023-03-28 Thread Rob Clark
On Tue, Mar 28, 2023 at 8:28 AM Dmitry Baryshkov wrote: > > On 25/03/2023 00:00, Rob Clark wrote: > > From: Rob Clark > > > > If userspace asked for a timeout greater than zero, but less than a > > jiffy, they clearly weren't planning on spinning. So

Re: [PATCH v2 17/23] PM / QoS: Fix constraints alloc vs reclaim locking

2023-03-27 Thread Rob Clark
On Mon, Mar 27, 2023 at 10:53 AM Rafael J. Wysocki wrote: > > On Mon, Mar 20, 2023 at 3:45 PM Rob Clark wrote: > > > > From: Rob Clark > > > > In the process of adding lockdep annotation for drm GPU scheduler's > > job_run() to detect potential deadlock

[PATCH] drm/msm: Rename drm_msm_gem_submit_reloc::or in C++ code

2023-03-26 Thread Rob Clark
From: Danylo Piliaiev Clashes with C++ `or` keyword Signed-off-by: Danylo Piliaiev Signed-off-by: Rob Clark --- This is a port of a C++ compat fix that was made in mesa's copy of the drm uapi headers. include/uapi/drm/msm_drm.h | 4 1 file changed, 4 insertions(+) diff --git a/in

Re: [PATCH v4 04/14] drm/msm/a6xx: Extend and explain UBWC config

2023-03-25 Thread Rob Clark
Dybcio Reviewed-by: Rob Clark > --- > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 39 > +++ > 1 file changed, 30 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > in

[pull] drm: dma-fence-deadline-core for v6.4

2023-03-25 Thread Rob Clark
-helper: Set fence deadline for vblank (2023-03-25 10:55:08 -0700) Immutable branch with dma-fence deadline hint support between drm-next and driver -next trees. Rob Clark

[PATCH] drm/msm: Avoid rounding down to zero jiffies

2023-03-24 Thread Rob Clark
From: Rob Clark If userspace asked for a timeout greater than zero, but less than a jiffy, they clearly weren't planning on spinning. So it is better to round up to one. This fixes an issue with supertuxkart that was (for some reason) spinning on a gl sync with 1ms timeout. CPU time

Re: [RFC] drm/scheduler: Unwrap job dependencies

2023-03-23 Thread Rob Clark
On Thu, Mar 23, 2023 at 7:03 AM Christian König wrote: > > Am 23.03.23 um 14:54 schrieb Rob Clark: > > On Thu, Mar 23, 2023 at 12:35 AM Christian König > > wrote: > >> Am 22.03.23 um 23:44 schrieb Rob Clark: > >>> From: Rob Clark > >>> >

Re: [PATCH v3 2/2] drm/virtio: Support sync objects

2023-03-23 Thread Rob Clark
On Thu, Mar 23, 2023 at 12:05 PM Dmitry Osipenko wrote: > > Add sync object DRM UAPI support to VirtIO-GPU driver. It's required > for enabling a full-featured Vulkan fencing by Venus and native context > VirtIO-GPU Mesa drivers. > > Signed-off-by: Dmitry Osipenko > --- > drivers/gpu/drm/virtio/

Re: [PATCH v3 1/2] drm/virtio: Refactor job submission code path

2023-03-23 Thread Rob Clark
On Thu, Mar 23, 2023 at 12:05 PM Dmitry Osipenko wrote: > > Move virtio_gpu_execbuffer_ioctl() into separate virtgpu_submit.c file > and refactor the code along the way to ease addition of new features to > the ioctl. > > Signed-off-by: Dmitry Osipenko Reviewed-by: Rob Clark

Re: [RFC] drm/scheduler: Unwrap job dependencies

2023-03-23 Thread Rob Clark
On Thu, Mar 23, 2023 at 12:35 AM Christian König wrote: > > Am 22.03.23 um 23:44 schrieb Rob Clark: > > From: Rob Clark > > > > Container fences have burner contexts, which makes the trick to store at > > most one fence per context somewhat useless if we don'

[RFC] drm/scheduler: Unwrap job dependencies

2023-03-22 Thread Rob Clark
From: Rob Clark Container fences have burner contexts, which makes the trick to store at most one fence per context somewhat useless if we don't unwrap array or chain fences. Signed-off-by: Rob Clark --- tbh, I'm not sure why we weren't doing this already, unless there i

Re: [PATCH v2 1/2] drm/virtio: Refactor job submission code path

2023-03-22 Thread Rob Clark
On Sun, Mar 19, 2023 at 9:11 AM Dmitry Osipenko wrote: > > Move virtio_gpu_execbuffer_ioctl() into separate virtgpu_submit.c file > and refactor the code along the way to ease addition of new features to > the ioctl. > > Signed-off-by: Dmitry Osipenko > --- > drivers/gpu/drm/virtio/Makefile

Re: [PATCH] drm/msm/dpu: Fix bit-shifting UB in DPU_HW_VER() macro

2023-03-22 Thread Rob Clark
4a352c2fc15aec1e ("drm/msm/dpu: Introduce SC8280XP") > > Fixes: 100d7ef6995d1f86 ("drm/msm/dpu: add support for SM8450") > > Signed-off-by: Geert Uytterhoeven > > Reviewed-by: Randy Dunlap Reviewed-by: Rob Clark > > Thanks. > > > --- > &g

Re: [PATCH v10 01/15] dma-buf/dma-fence: Add deadline awareness

2023-03-21 Thread Rob Clark
On Tue, Mar 21, 2023 at 6:24 AM Jonas Ådahl wrote: > > On Fri, Mar 17, 2023 at 08:59:48AM -0700, Rob Clark wrote: > > On Fri, Mar 17, 2023 at 3:23 AM Jonas Ådahl wrote: > > > > > > On Thu, Mar 16, 2023 at 09:28:55AM -0700, Rob Clark wrote: > > > > O

Re: [PATCH v2 01/23] drm/msm: Pre-allocate hw_fence

2023-03-20 Thread Rob Clark
On Mon, Mar 20, 2023 at 9:52 AM Christian König wrote: > > > > Am 20.03.23 um 15:43 schrieb Rob Clark: > > From: Rob Clark > > > > Avoid allocating memory in job_run() by pre-allocating the hw_fence. > > > > Signed-off-by: Rob Clark > > ---

Re: [PATCH 1/2] drm/msm/a6xx: Some reg64 conversion

2023-03-20 Thread Rob Clark
On Mon, Mar 20, 2023 at 11:57 AM Konrad Dybcio wrote: > > > > On 20.03.2023 19:56, Konrad Dybcio wrote: > > > > > > On 20.03.2023 19:54, Rob Clark wrote: > >> From: Rob Clark > >> > >> The next generated header update will drop the _LO

[PATCH 1/2] drm/msm/a6xx: Some reg64 conversion

2023-03-20 Thread Rob Clark
From: Rob Clark The next generated header update will drop the _LO/_HI suffix, now that the userspace tooling properly understands 64b vs 32b regs (and the _LO/ _HI workarounds are getting cleaned up). So convert to using the 64b reg helpers in prep. Signed-off-by: Rob Clark --- drivers/gpu

Re: [Freedreno] [PATCH v3 4/7] drm/msm/a2xx: Implement .gpu_busy

2023-03-20 Thread Rob Clark
On Mon, Mar 13, 2023 at 9:54 AM Konrad Dybcio wrote: > > > > On 24.02.2023 16:04, Jonathan Marek wrote: > > This won't work because a2xx freedreno userspace expects to own all the > > perfcounters. > > > > This will break perfcounters for userspace, and when userspace isn't using > > perfcounter

[PATCH v2 19/23] PM / QoS: Teach lockdep about dev_pm_qos_mtx locking order

2023-03-20 Thread Rob Clark
From: Rob Clark Annotate dev_pm_qos_mtx to teach lockdep to scream about allocations that could trigger reclaim under dev_pm_qos_mtx. Signed-off-by: Rob Clark --- drivers/base/power/qos.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/base/power/qos.c b/drivers/base

[PATCH v2 23/23] drm/sched: Add (optional) fence signaling annotation

2023-03-20 Thread Rob Clark
From: Rob Clark Based on https://lore.kernel.org/dri-devel/20200604081224.863494-10-daniel.vet...@ffwll.ch/ but made to be optional. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_ringbuffer.c | 1 + drivers/gpu/drm/scheduler/sched_main.c | 9 + include/drm/gpu_scheduler.h

[PATCH v2 22/23] interconnect: Teach lockdep about icc_bw_lock order

2023-03-20 Thread Rob Clark
From: Rob Clark Teach lockdep that icc_bw_lock is needed in code paths that could deadlock if they trigger reclaim. Signed-off-by: Rob Clark --- drivers/interconnect/core.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/interconnect/core.c b/drivers

[PATCH v2 17/23] PM / QoS: Fix constraints alloc vs reclaim locking

2023-03-20 Thread Rob Clark
From: Rob Clark In the process of adding lockdep annotation for drm GPU scheduler's job_run() to detect potential deadlock against shrinker/reclaim, I hit this lockdep splat: == WARNING: possible circular locking dependency det

[PATCH v2 21/23] interconnect: Fix locking for runpm vs reclaim

2023-03-20 Thread Rob Clark
From: Rob Clark For cases where icc_bw_set() can be called in callbaths that could deadlock against shrinker/reclaim, such as runpm resume, we need to decouple the icc locking. Introduce a new icc_bw_lock for cases where we need to serialize bw aggregation and update to decouple that from paths

<    1   2   3   4   5   6   7   8   9   10   >