Re: [RFC] Documentation: DRM framework documentation

2012-06-11 Thread Rob Clark
On Thu, Jun 7, 2012 at 2:52 AM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Rob, On Tuesday 05 June 2012 04:31:54 Rob Clark wrote: +  - int (*firstopen) (struct drm_device *) +  - void (*lastclose) (struct drm_device *) +  - int (*open) (struct drm_device *, struct

Re: [PATCH] omap2+: add drm device

2012-06-11 Thread Rob Clark
On Wed, May 23, 2012 at 3:08 PM, Andy Gross andy.gr...@ti.com wrote: Register OMAP DRM/KMS platform device.  DMM is split into a separate device using hwmod. Signed-off-by: Andy Gross andy.gr...@ti.com Signed-off-by: Rob Clark rob.cl...@linaro.org ---  arch/arm/mach-omap2/Makefile

[RFC libdrm] omap: add refcnting and handle tracking

2012-06-17 Thread Rob Clark
From: Rob Clark r...@ti.com There can be scenarios, especially when re-importing an existing buffer, where you end up with multiple 'struct omap_bo's wrapping a single GEM object handle. Which causes badness when the first of the evil-clones is omap_bo_del()'d. To do this, introduce reference

Re: [PATCH 10/10] drm/exynos: consider memory releasing to exported gem buffer into dmabuf

2012-06-27 Thread Rob Clark
On Wed, Jun 27, 2012 at 3:03 AM, Inki Dae inki@samsung.com wrote: exported gem buffer into dmabuf should be released when a gem relese is requested by user. with dma_buf_put() call, if file-f_count is 0 then a release callback of exynos gem module(exporter) will be called to release its

[PATCH] staging: drm/omap: add rotation properties

2012-06-27 Thread Rob Clark
From: Rob Clark r...@ti.com Use tiled buffers for rotated/reflected scanout, with CRTC and plane properties as the interface for userspace to configure rotation. Signed-off-by: Rob Clark r...@ti.com --- drivers/staging/omapdrm/omap_crtc.c | 17 + drivers/staging/omapdrm

Re: [PATCH] staging: drm/omap: add rotation properties

2012-06-27 Thread Rob Clark
On Wed, Jun 27, 2012 at 9:06 AM, Rob Clark rob.cl...@linaro.org wrote: From: Rob Clark r...@ti.com Use tiled buffers for rotated/reflected scanout, with CRTC and plane properties as the interface for userspace to configure rotation. btw, I assume the potential controversial part of the patch

Re: [PATCH] staging: drm/omap: add rotation properties

2012-06-27 Thread Rob Clark
On Wed, Jun 27, 2012 at 2:40 PM, Greg KH g...@kroah.com wrote: On Wed, Jun 27, 2012 at 09:06:26AM -0500, Rob Clark wrote: From: Rob Clark r...@ti.com Use tiled buffers for rotated/reflected scanout, with CRTC and plane properties as the interface for userspace to configure rotation. Signed

[PATCH] staging: drm/omap: update TODO

2012-06-27 Thread Rob Clark
From: Rob Clark r...@ti.com Update TODO file, which had been neglected. Signed-off-by: Rob Clark r...@ti.com --- drivers/staging/omapdrm/TODO |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/omapdrm/TODO b/drivers/staging/omapdrm/TODO index 55b1837

Re: [PATCH] staging: drm/omap: add rotation properties

2012-06-29 Thread Rob Clark
On Fri, Jun 29, 2012 at 5:46 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Wed, 2012-06-27 at 09:06 -0500, Rob Clark wrote: From: Rob Clark r...@ti.com Use tiled buffers for rotated/reflected scanout, with CRTC and plane properties as the interface for userspace to configure rotation

[PATCH] dma-fence: dma-buf synchronization

2012-07-11 Thread Rob Clark
From: Rob Clark r...@ti.com A dma-fence can be attached to a buffer which is being filled or consumed by hw, to allow userspace to pass the buffer without waiting to another device. For example, userspace can call page_flip ioctl to display the next frame of graphics after kicking the GPU

Re: [RFC] dma-fence: dma-buf synchronization

2012-07-11 Thread Rob Clark
oh, btw, this should be an [RFC] On Wed, Jul 11, 2012 at 5:29 PM, Rob Clark rob.cl...@linaro.org wrote: From: Rob Clark r...@ti.com A dma-fence can be attached to a buffer which is being filled or consumed by hw, to allow userspace to pass the buffer without waiting to another device

Re: [PATCH] dma-fence: dma-buf synchronization

2012-07-11 Thread Rob Clark
On Wed, Jul 11, 2012 at 6:49 PM, Maarten Lankhorst m.b.lankho...@gmail.com wrote: Op 12-07-12 00:29, Rob Clark schreef: From: Rob Clark r...@ti.com A dma-fence can be attached to a buffer which is being filled or consumed by hw, to allow userspace to pass the buffer without waiting to another

[RFC] dma-fence: dma-buf synchronization (v2)

2012-07-13 Thread Rob Clark
From: Rob Clark r...@ti.com A dma-fence can be attached to a buffer which is being filled or consumed by hw, to allow userspace to pass the buffer without waiting to another device. For example, userspace can call page_flip ioctl to display the next frame of graphics after kicking the GPU

Re: [RFC] dma-fence: dma-buf synchronization (v2)

2012-07-13 Thread Rob Clark
On Fri, Jul 13, 2012 at 12:35 PM, Tom Cooksey tom.cook...@arm.com wrote: My other thought is around atomicity. Could this be extended to (safely) allow for hardware devices which might want to access multiple buffers simultaneously? I think it probably can with some tweaks to the interface? An

Re: [RFC] dma-fence: dma-buf synchronization (v2)

2012-07-13 Thread Rob Clark
On Fri, Jul 13, 2012 at 4:44 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Hey, Op 13-07-12 20:52, Rob Clark schreef: On Fri, Jul 13, 2012 at 12:35 PM, Tom Cooksey tom.cook...@arm.com wrote: My other thought is around atomicity. Could this be extended to (safely) allow

Re: [PATCH] Documentation: DocBook DRM framework documentation

2012-07-16 Thread Rob Clark
will as usual be appreciated, and acks will be even more welcome (I've been working on this document for longer than I feel comfortable with). btw, thanks for this! One minor typo below.. with that, Reviewed-by: Rob Clark rob.cl...@linaro.org diff --git a/Documentation/DocBook/drm.tmpl b

[PATCH 0/2] dma-parms and helpers for dma-buf

2012-07-19 Thread Rob Clark
From: Rob Clark r...@ti.com Re-sending first patch, with a wider audience. Apparently I didn't spam enough inboxes the first time. And, at Daniel Vetter's suggestion, adding some helper functions in dma-buf to get the most restrictive parameters of all the attached devices. Rob Clark (2

[PATCH 1/2] device: add dma_params-max_segment_count

2012-07-19 Thread Rob Clark
From: Rob Clark r...@ti.com For devices which have constraints about maximum number of segments in an sglist. For example, a device which could only deal with contiguous buffers would set max_segment_count to 1. The initial motivation is for devices sharing buffers via dma-buf, to allow

[PATCH 2/2] dma-buf: add helpers for attacher dma-parms

2012-07-19 Thread Rob Clark
From: Rob Clark r...@ti.com Add some helpers to iterate through all attachers and get the most restrictive segment size/count/boundary. Signed-off-by: Rob Clark r...@ti.com --- drivers/base/dma-buf.c | 63 +++ include/linux/dma-buf.h | 19

Re: [PATCH 0/7] modetest cleanup and enhancements

2012-07-20 Thread Rob Clark
On Fri, Jul 20, 2012 at 7:50 AM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi everybody, I've enhanced the modetest utility to test various features of the SH Mobile LCDC DRM driver. Here are the corresponding patches. They mostly touch buffer allocation cleanup (1/7), adding

Re: [PATCH 2/2] dma-buf: add helpers for attacher dma-parms

2012-07-20 Thread Rob Clark
to the cleanup of moving dma_mask/coherent_dma_mask into dma_parms, I'll do this first. So anyways, don't consider this patch yet for inclusion, I'll make an updated one based on dma_parms.. BR, -R On Thu, Jul 19, 2012 at 11:23 AM, Rob Clark rob.cl...@linaro.org wrote: From: Rob Clark r

Re: [PATCH 2/3] drm/exynos: add dmabuf mmap function

2012-07-21 Thread Rob Clark
On Tue, Jul 10, 2012 at 8:32 AM, Cooper Yuan coopery...@gmail.com wrote: implement mmap function of dma_buf_ops. Signed-off-by: Cooper Yuan coopery...@gmail.com --- drivers/gpu/drm/exynos/exynos_drm_dmabuf.c | 38 1 files changed, 38 insertions(+), 0

Re: [PATCH 3/3] drm/exynos: implement kmap/kunmap/kmap_atomic/kunmap_atomic functions of dma_buf_ops

2012-07-21 Thread Rob Clark
On Fri, Jul 20, 2012 at 11:31 PM, InKi Dae daei...@gmail.com wrote: diff --git a/drivers/gpu/drm/exynos/exynos_drm_dmabuf.c b/drivers/gpu/drm/exynos/exynos_drm_dmabuf.c index 913a23e..805b344 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dmabuf.c +++

Re: [PATCH] modeset: Split buffer allocation to a separate file

2012-07-23 Thread Rob Clark
On Fri, Jul 20, 2012 at 12:38 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Rob, On Friday 20 July 2012 10:34:46 Rob Clark wrote: thanks! I've pushed to a branch on my github tree, in case you want to double check that I'm not missing anything: git://github.com

[PATCH] drm/prime: drop reference on imported dma-buf

2012-07-23 Thread Rob Clark
From: Rob Clark r...@ti.com The GEM handle takes the reference. If a driver is actually importing a foreign dmabuf, rather than just re-importing it's own dmabuf, it needs to do a get_dma_buf(). Signed-off-by: Rob Clark r...@ti.com --- drivers/gpu/drm/drm_prime.c|7

[RFC 0/3] solving omapdrm/omapdss layering issues

2012-07-27 Thread Rob Clark
From: Rob Clark r...@ti.com I've been working for the better part of the week on solving some of the omapdss vs kms mismatches, which is one of the bigger remaining issues in the TODO before moving omapdrm out of staging. The biggest place that this shows up is in GO bit handling. Basically

[RFC 1/3] OMAPDSS: expose dispc for use from omapdrm

2012-07-27 Thread Rob Clark
From: Rob Clark r...@ti.com Not very clean, just for proof of concept. Signed-off-by: Rob Clark r...@ti.com --- drivers/video/omap2/dss/apply.c |4 ++- drivers/video/omap2/dss/dispc.c | 76 ++- drivers/video/omap2/dss/dss.h |2 ++ drivers/video

[RFC 2/3] omap2+: use dss_dispc hwmod for omapdrm

2012-07-27 Thread Rob Clark
From: Rob Clark r...@ti.com We need this so that platform_get_irq() works when drm core sets up the irq handling. Signed-off-by: Rob Clark r...@ti.com --- arch/arm/mach-omap2/drm.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/arch/arm/mach

[RFC 3/3] drm/omap: use dispc directly

2012-07-27 Thread Rob Clark
From: Rob Clark r...@ti.com This is still work in progress, but it nicely solves the omapdss vs drm impedence mismatches, and properly fixes unpin confusion vs GO bit status. As an added bonus, we also no longer leave the last overlay buffer pinned. Adding the previously missing vblank event

Re: [PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-07-31 Thread Rob Clark
On Tue, Jul 31, 2012 at 7:11 AM, Hans Verkuil hverk...@xs4all.nl wrote: For that matter, wouldn't it be useful to support exporting a userptr buffer at some point in the future? Shouldn't USERPTR usage be discouraged once we get dma-buf support ? Why? It's perfectly fine to use it and

Re: [PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-07-31 Thread Rob Clark
On Tue, Jul 31, 2012 at 8:39 AM, Rémi Denis-Courmont r...@remlab.net wrote: Le mardi 31 juillet 2012 14:56:14 Laurent Pinchart, vous avez écrit : For that matter, wouldn't it be useful to support exporting a userptr buffer at some point in the future? Shouldn't USERPTR usage be discouraged

Re: [RFC 0/3] solving omapdrm/omapdss layering issues

2012-07-31 Thread Rob Clark
On Tue, Jul 31, 2012 at 8:40 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: Hi, On Fri, 2012-07-27 at 20:07 -0500, Rob Clark wrote: From: Rob Clark r...@ti.com I've been working for the better part of the week on solving some of the omapdss vs kms mismatches, which is one of the bigger

[PATCH] drm: refcnt drm_framebuffer

2012-07-31 Thread Rob Clark
From: Rob Clark r...@ti.com This simplifies drm fb lifetime, and if the crtc/plane needs to hold a ref to the fb when disabling a pipe until the next vblank, this avoids the need to make disabling an overlay synchronous. This is a problem that shows up when userspace is using a drm plane

Re: [PATCH] drm: refcnt drm_framebuffer

2012-07-31 Thread Rob Clark
On Tue, Jul 31, 2012 at 12:00 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, 31 Jul 2012 11:20:21 -0500, Rob Clark rob.cl...@linaro.org wrote: From: Rob Clark r...@ti.com This simplifies drm fb lifetime, and if the crtc/plane needs to hold a ref to the fb when disabling a pipe until

Re: [PATCH] drm: refcnt drm_framebuffer

2012-07-31 Thread Rob Clark
On Tue, Jul 31, 2012 at 12:47 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, 31 Jul 2012 12:41:28 -0500, Rob Clark rob.cl...@linaro.org wrote: On Tue, Jul 31, 2012 at 12:00 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, 31 Jul 2012 11:20:21 -0500, Rob Clark rob.cl

Re: [PATCH] staging: drm/omap: remove reclaim_buffers callback

2012-08-01 Thread Rob Clark
, the callback for reclaim_buffers is removed from omapdrm. Signed-off-by: Chandrabhanu Mahapatra cmahapa...@ti.com Signed-off-by: Rob Clark r...@ti.com --- drivers/staging/omapdrm/omap_drv.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/omapdrm/omap_drv.c b/drivers

Re: [PATCH] drm: refcnt drm_framebuffer

2012-08-01 Thread Rob Clark
On Wed, Aug 1, 2012 at 6:36 AM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Tue, Jul 31, 2012 at 02:28:29PM -0500, Rob Clark wrote: On Tue, Jul 31, 2012 at 12:47 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, 31 Jul 2012 12:41:28 -0500, Rob Clark rob.cl...@linaro.org

Re: [RFC 0/3] solving omapdrm/omapdss layering issues

2012-08-01 Thread Rob Clark
On Wed, Aug 1, 2012 at 4:21 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Tue, 2012-07-31 at 09:45 -0500, Rob Clark wrote: On Tue, Jul 31, 2012 at 8:40 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: It's not really about being friendly. Omapdss tries to do as little as possible

Re: [RFC 0/3] solving omapdrm/omapdss layering issues

2012-08-01 Thread Rob Clark
On Wed, Aug 1, 2012 at 11:46 AM, Archit Taneja arc...@ti.com wrote: Hi, On Wednesday 01 August 2012 07:55 PM, Rob Clark wrote: On Wed, Aug 1, 2012 at 4:21 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Tue, 2012-07-31 at 09:45 -0500, Rob Clark wrote: On Tue, Jul 31, 2012 at 8:40 AM

Re: [RFC 0/3] solving omapdrm/omapdss layering issues

2012-08-01 Thread Rob Clark
On Wed, Aug 1, 2012 at 11:53 AM, Rob Clark rob.cl...@linaro.org wrote: On Wed, Aug 1, 2012 at 11:46 AM, Archit Taneja arc...@ti.com wrote: Hi, On Wednesday 01 August 2012 07:55 PM, Rob Clark wrote: On Wed, Aug 1, 2012 at 4:21 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Tue, 2012

Re: [PATCH] staging: drm/omap: remove reclaim_buffers callback

2012-08-01 Thread Rob Clark
support and so the callback for reclaim_buffers is being removed from omapdrm. Signed-off-by: Chandrabhanu Mahapatra cmahapa...@ti.com Signed-off-by: Rob Clark r...@ti.com --- drivers/staging/omapdrm/omap_drv.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/omapdrm

Re: [RFC 0/3] solving omapdrm/omapdss layering issues

2012-08-01 Thread Rob Clark
On Wed, Aug 1, 2012 at 12:38 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Wed, 2012-08-01 at 11:53 -0500, Rob Clark wrote: Ok.. this would help. I'll take a look. I do request that interfaces/panels don't set any mgr/timing related registers. I had to comment all this stuff out in my

Re: [RFC 0/3] solving omapdrm/omapdss layering issues

2012-08-02 Thread Rob Clark
On Thu, Aug 2, 2012 at 2:13 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Wed, 2012-08-01 at 09:25 -0500, Rob Clark wrote: On Wed, Aug 1, 2012 at 4:21 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: I guess the fact is that DRM concepts do not really match the OMAP DSS hardware

Re: [RFC 0/3] solving omapdrm/omapdss layering issues

2012-08-02 Thread Rob Clark
On Thu, Aug 2, 2012 at 8:15 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Thu, 2012-08-02 at 07:45 -0500, Rob Clark wrote: On Thu, Aug 2, 2012 at 2:13 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Wed, 2012-08-01 at 09:25 -0500, Rob Clark wrote: On Wed, Aug 1, 2012 at 4:21 AM, Tomi

Re: [RFC 0/3] solving omapdrm/omapdss layering issues

2012-08-03 Thread Rob Clark
On Fri, Aug 3, 2012 at 1:01 AM, Semwal, Sumit sumit.sem...@ti.com wrote: Hi Rob, Tomi, On Thu, Aug 2, 2012 at 7:46 PM, Rob Clark rob.cl...@linaro.org wrote: On Thu, Aug 2, 2012 at 8:15 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Thu, 2012-08-02 at 07:45 -0500, Rob Clark wrote: On Thu

Re: [PATCH] staging: omapdrm: Fix DMM sparse warnings

2012-08-09 Thread Rob Clark
: warning: Using plain integer as NULL pointer Signed-off-by: Andy Gross andy.gr...@ti.com Signed-off-by: Rob Clark rob.cl...@linaro.org --- drivers/staging/omapdrm/omap_dmm_tiler.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/omapdrm

Re: [PATCH] staging: omapdrm: Remove unnecessary memcpy

2012-08-10 Thread Rob Clark
On Thu, Aug 9, 2012 at 12:13 AM, Andy Gross andy.gr...@ti.com wrote: Removed the unnecessary copy of the memory page addresses when programming the DMM/PAT and all support code for the lut copy. The original intent was to have this code in place for suspend/resume functionality w.r.t.

Re: [Linaro-mm-sig] [PATCH 2/4] dma-fence: dma-buf synchronization (v8 )

2012-08-11 Thread Rob Clark
/dma-fence.c new file mode 100644 index 000..93448e4 --- /dev/null +++ b/drivers/base/dma-fence.c @@ -0,0 +1,268 @@ +/* + * Fence mechanism for dma-buf to allow for asynchronous dma access + * + * Copyright (C) 2012 Texas Instruments + * Author: Rob Clark rob.cl...@linaro.org

Re: [Linaro-mm-sig] [PATCH 1/4] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER

2012-08-11 Thread Rob Clark
back to when it was a user configurable option, rather than something select'd by drivers using dmabuf, and we just never went back to clean up. Let's drop the fallbacks. Reviewed-by: Rob Clark rob.cl...@linaro.org -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48

Re: [Linaro-mm-sig] [PATCH 2/4] dma-fence: dma-buf synchronization (v8 )

2012-08-11 Thread Rob Clark
On Sat, Aug 11, 2012 at 2:22 PM, Daniel Vetter dan...@ffwll.ch wrote: + +/** + * dma_fence_wait - wait for a fence to be signaled + * + * @fence: [in]The fence to wait on + * @intr:[in]if true, do an interruptible wait + * @timeout: [in]absolute time for timeout, in

[PATCH 0/2] drm/omap: properties patches

2012-08-15 Thread Rob Clark
From: Rob Clark r...@ti.com Re-sending the earlier rotation property patch, plus Andre's z-order property patch rebased on latest staging-next. Andre Renaud (1): Expose the OMAP Z-Order property through DRM Rob Clark (1): staging: drm/omap: add rotation properties drivers/staging/omapdrm

[PATCH 1/2] staging: drm/omap: add rotation properties

2012-08-15 Thread Rob Clark
From: Rob Clark r...@ti.com Use tiled buffers for rotated/reflected scanout, with CRTC and plane properties as the interface for userspace to configure rotation. Signed-off-by: Rob Clark r...@ti.com --- drivers/staging/omapdrm/omap_crtc.c | 10 +++ drivers/staging/omapdrm

[PATCH 2/2] Expose the OMAP Z-Order property through DRM

2012-08-15 Thread Rob Clark
From: Andre Renaud an...@bluewatersys.com Added support for zorder changes through DRM plane properties Signed-off-by: Andre Renaud an...@bluewatersys.com Signed-off-by: Rob Clark r...@ti.com --- drivers/staging/omapdrm/omap_drv.h |1 + drivers/staging/omapdrm/omap_plane.c | 19

Re: [PATCH 2/2] Expose the OMAP Z-Order property through DRM

2012-08-16 Thread Rob Clark
On Thu, Aug 16, 2012 at 8:00 AM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Wed, Aug 15, 2012 at 03:18:02PM -0500, Rob Clark wrote: From: Andre Renaud an...@bluewatersys.com Added support for zorder changes through DRM plane properties Signed-off-by: Andre Renaud

Re: [RFC][PATCH 08/10] WIP: drm: Atomic modeset ioctl

2012-08-31 Thread Rob Clark
On Wed, Jun 27, 2012 at 5:24 AM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com First draft. The ioctl simply takes a list of object IDs and property IDs and their values. For setting values to blob properties, the property value indicates the length

Re: [RFC][PATCH 08/10] WIP: drm: Atomic modeset ioctl

2012-09-01 Thread Rob Clark
On Sat, Sep 1, 2012 at 6:12 AM, Daniel Vetter dan...@ffwll.ch wrote: On Fri, Aug 31, 2012 at 05:47:13PM -0500, Rob Clark wrote: On Wed, Jun 27, 2012 at 5:24 AM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com First draft. The ioctl simply takes

Re: [RFC][PATCH 08/10] WIP: drm: Atomic modeset ioctl

2012-09-01 Thread Rob Clark
On Sat, Sep 1, 2012 at 11:56 AM, Daniel Vetter dan...@ffwll.ch wrote: On Sat, Sep 1, 2012 at 5:58 PM, Rob Clark robdcl...@gmail.com wrote: yeah, nuclear-pageflip would be associated only w/ a single crtc. Actually I was kinda assuming atomic-modeset was too.. ie. moving a plane from one crtc

kmscube: simple example using kms+gbm

2012-09-04 Thread Rob Clark
From time to time I've been getting questions about how to use gl/egl without x11. And I would point them at Jesse's blog post: http://virtuousgeek.org/blog/index.php/jbarnes/2011/10/31/writing_stanalone_programs_with_egl_and_ But I wanted some simple example that was updated to work w/ the

[PATCH 1/2] drm: support for rotated scanout

2012-09-04 Thread Rob Clark
From: Rob Clark r...@ti.com For drivers that can support rotated scanout, the extra parameter checking in drm-core, while nice, tends to get confused. To solve this drivers can set the crtc or plane invert_dimensions field so that the dimension checking takes into account the rotation

[PATCH 2/2] drm/omap: invert dimensions on crtc when rotated

2012-09-04 Thread Rob Clark
From: Rob Clark r...@ti.com If rotated 90 or 270, we need to invert the dimensions used by drm core for calculating if the dimensions of an attached fb are correct. Signed-off-by: Rob Clark r...@ti.com --- drivers/staging/omapdrm/omap_crtc.c |7 +++ 1 file changed, 7 insertions(+) diff

Re: [PATCH] drm/prime: drop reference on imported dma-buf

2012-09-04 Thread Rob Clark
Dave, I just noticed that I still have this patch locally, but don't see it in drm-next.. so just checking that it didn't get forgotten BR, -R On Tue, Jul 24, 2012 at 3:05 AM, Daniel Vetter dan...@ffwll.ch wrote: On Tue, Jul 24, 2012 at 1:07 AM, Rob Clark rob.cl...@linaro.org wrote: From: Rob

[PATCH 1/2] drm: remove unused fxn prototypes

2012-09-04 Thread Rob Clark
From: Rob Clark r...@ti.com Signed-off-by: Rob Clark r...@ti.com --- include/drm/drm_crtc.h | 15 --- 1 file changed, 15 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 7ba9b39..a82e0a2 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm

[PATCH] drm/omap: hold a ref to the bo while waiting for flip

2012-09-04 Thread Rob Clark
From: Rob Clark r...@ti.com Since the plane hasn't yet taken a reference, we need to hold a reference while waiting to ensure the backing GEM bo doesn't get freed from under us. Signed-off-by: Rob Clark r...@ti.com --- drivers/staging/omapdrm/omap_crtc.c | 16 ++-- 1 file changed

Re: [PATCH 1/2] drm: remove unused fxn prototypes

2012-09-04 Thread Rob Clark
oh.. and this should be a 1/1 (no 2nd part.. apparently I suck at git-format-patch) On Tue, Sep 4, 2012 at 5:46 PM, Rob Clark rob.cl...@linaro.org wrote: From: Rob Clark r...@ti.com Signed-off-by: Rob Clark r...@ti.com --- include/drm/drm_crtc.h | 15 --- 1 file changed, 15

[PATCH] drm: refcnt drm_framebuffer

2012-09-04 Thread Rob Clark
From: Rob Clark r...@ti.com This simplifies drm fb lifetime, and if the crtc/plane needs to hold a ref to the fb when disabling a pipe until the next vblank, this avoids the need to make disabling an overlay synchronous. This is a problem that shows up when userspace is using a drm plane

Re: [PATCH] drm/prime: drop reference on imported dma-buf

2012-09-05 Thread Rob Clark
On Wed, Sep 5, 2012 at 4:02 AM, Daniel Vetter dan...@ffwll.ch wrote: On Tue, Sep 04, 2012 at 05:32:21PM -0500, Rob Clark wrote: Dave, I just noticed that I still have this patch locally, but don't see it in drm-next.. so just checking that it didn't get forgotten My locking fixes blew up

Re: [Patch 0/1]drm_irq: Introducing the irq_thread support

2012-09-05 Thread Rob Clark
On Wed, Sep 5, 2012 at 8:27 AM, Daniel Vetter dan...@ffwll.ch wrote: On Wed, Sep 05, 2012 at 01:53:44AM +, Liu, Chuansheng wrote: This patch is for introducing the irq thread support in drm_irq. Why we need irq thread in drm_irq code? In our GPU system, the gpu interrupt handler need some

[PATCH] drm: refcnt drm_framebuffer

2012-09-05 Thread Rob Clark
From: Rob Clark r...@ti.com This simplifies drm fb lifetime, and if the crtc/plane needs to hold a ref to the fb when disabling a pipe until the next vblank, this avoids the need to make disabling an overlay synchronous. This is a problem that shows up when userspace is using a drm plane

Re: [PATCH] drm: refcnt drm_framebuffer

2012-09-05 Thread Rob Clark
On Wed, Sep 5, 2012 at 1:17 PM, Rob Clark rob.cl...@linaro.org wrote: From: Rob Clark r...@ti.com This simplifies drm fb lifetime, and if the crtc/plane needs to hold a ref to the fb when disabling a pipe until the next vblank, this avoids the need to make disabling an overlay synchronous

[PATCH] drm: refcnt drm_framebuffer

2012-09-05 Thread Rob Clark
From: Rob Clark r...@ti.com This simplifies drm fb lifetime, and if the crtc/plane needs to hold a ref to the fb when disabling a pipe until the next vblank, this avoids the need to make disabling an overlay synchronous. This is a problem that shows up when userspace is using a drm plane

[PATCH] drm/omap: update for interlaced

2012-09-05 Thread Rob Clark
From: Rob Clark r...@ti.com 'struct omap_video_timings' was updated w/ a 'bool interlaced'. Without a matching update in omap_connector, this field could have undefined values from the stack, which isn't quite ideal. Update the fxns to convert omapdss-drm timings structs, and zero-init 'struct

[PATCH] drm/omap: add more new timings fields

2012-09-07 Thread Rob Clark
From: Rob Clark r...@ti.com Without these, DVI is broken. Signed-off-by: Rob Clark r...@ti.com --- Greg, it looks like the omapdss changes which added these fields, as well as the interlaced field, where merged in Linux 3.5-rc5. So I think both this and the 'update for interlaced' patch

[PATCH] drm: remove property_blob_list

2012-09-07 Thread Rob Clark
From: Rob Clark r...@ti.com It isn't used anywhere. Signed-off-by: Rob Clark r...@ti.com --- drivers/gpu/drm/drm_crtc.c |2 -- include/drm/drm_crtc.h |1 - 2 files changed, 3 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 7552675..21a0a85

Re: [PATCH] drm: remove property_blob_list

2012-09-09 Thread Rob Clark
On Fri, Sep 7, 2012 at 9:38 PM, Rob Clark rob.cl...@linaro.org wrote: From: Rob Clark r...@ti.com It isn't used anywhere. duh, nevermind.. I figured out how it is used. But maybe I'll add a comment. BR, -R Signed-off-by: Rob Clark r...@ti.com --- drivers/gpu/drm/drm_crtc.c |2

[RFC 0/9] nuclear pageflip

2012-09-09 Thread Rob Clark
From: Rob Clark r...@ti.com This is following a bit the approach that Ville is taking for atomic- modeset, in that it is switching over to using properties for everything. The advantage of this approach is that it makes it easier to add new attributes to set as part of a page-flip (and even opens

[RFC 1/9] drm: add atomic fxns

2012-09-09 Thread Rob Clark
From: Rob Clark r...@ti.com The 'atomic' mechanism allows for multiple properties to be updated, checked, and commited atomically. This will be the basis of atomic- modeset and nuclear-pageflip. The basic flow is: state = dev-atomic_begin(); for (... one or more ...) obj

[RFC 2/9] drm: add object property type

2012-09-09 Thread Rob Clark
From: Rob Clark r...@ti.com An object property is an id (idr) for a drm mode object. This will allow a property to be used set/get a framebuffer, CRTC, etc. --- drivers/gpu/drm/drm_crtc.c | 28 include/drm/drm_crtc.h |5 + include/drm/drm_mode.h

[RFC 3/9] drm: add DRM_MODE_PROP_DYNAMIC property flag

2012-09-09 Thread Rob Clark
From: Rob Clark r...@ti.com This indicates to userspace that the property is something that can be set dynamically without requiring a test step to check if the hw is capable. This allows a userspace compositor, such as weston, to avoid an extra ioctl to check whether it needs to fall-back

[RFC 4/9] drm: convert plane to properties

2012-09-09 Thread Rob Clark
From: Rob Clark r...@ti.com Use atomic properties mechanism to set plane attributes. This by itself doesn't accomplish anything, but it avoids having multiple code paths to do the same thing when nuclear-pageflip and atomic- modeset are introduced. --- drivers/gpu/drm/drm_crtc.c | 270

[RFC 5/9] drm: add drm_plane_state

2012-09-09 Thread Rob Clark
From: Rob Clark r...@ti.com Break the mutable state of a plane out into a separate structure. This makes it easier to have some helpers for plane-set_property() and for checking for invalid params. The idea is that individual drivers can wrap the state struct in their own struct which adds

[RFC 6/9] drm: convert page_flip to properties

2012-09-09 Thread Rob Clark
From: Rob Clark r...@ti.com Use atomic properties mechanism for CRTC page_flip. This by itself doesn't accomplish anything, but it avoids having multiple code paths to do the same thing when nuclear-pageflip and atomic-modeset are introduced. --- drivers/gpu/drm/drm_crtc.c | 59

[RFC 7/9] drm: add drm_crtc_state

2012-09-09 Thread Rob Clark
From: Rob Clark r...@ti.com Start breaking out the mutable state of the CRTC into it's own structure. Plus add _check_state() and _set_property() helpers. This only moves the state that is related to scanout fb, which is needed for nuclear-pageflip. The rest of the mutable state should be moved

[RFC 8/9] drm: nuclear pageflip

2012-09-09 Thread Rob Clark
From: Rob Clark r...@ti.com --- drivers/gpu/drm/drm_crtc.c | 147 +++- drivers/gpu/drm/drm_drv.c |1 + include/drm/drm.h |2 + include/drm/drm_crtc.h |2 + include/drm/drm_mode.h | 38 5 files changed, 161

[RFC 9/9] drm/omap: update for atomic age

2012-09-09 Thread Rob Clark
From: Rob Clark r...@ti.com --- drivers/staging/omapdrm/Makefile |1 + drivers/staging/omapdrm/omap_atomic.c | 270 + drivers/staging/omapdrm/omap_atomic.h | 52 +++ drivers/staging/omapdrm/omap_crtc.c | 247

Re: [RFC 0/9] nuclear pageflip

2012-09-09 Thread Rob Clark
On Sun, Sep 9, 2012 at 10:03 PM, Rob Clark rob.cl...@linaro.org wrote: From: Rob Clark r...@ti.com This is following a bit the approach that Ville is taking for atomic- modeset, in that it is switching over to using properties for everything. The advantage of this approach is that it makes

Re: [PATCH] drm/omap: add more new timings fields

2012-09-10 Thread Rob Clark
On Mon, Sep 10, 2012 at 12:50 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Fri, 2012-09-07 at 12:59 -0500, Rob Clark wrote: From: Rob Clark r...@ti.com Without these, DVI is broken. Signed-off-by: Rob Clark r...@ti.com --- Greg, it looks like the omapdss changes which added

Re: [RFC 0/9] nuclear pageflip

2012-09-11 Thread Rob Clark
On Tue, Sep 11, 2012 at 4:15 PM, Ben Widawsky b...@bwidawsk.net wrote: On Sun, 9 Sep 2012 22:19:59 -0500 Rob Clark r...@ti.com wrote: On Sun, Sep 9, 2012 at 10:03 PM, Rob Clark rob.cl...@linaro.org wrote: From: Rob Clark r...@ti.com This is following a bit the approach that Ville

Re: [RFC 0/9] nuclear pageflip

2012-09-12 Thread Rob Clark
On Wed, Sep 12, 2012 at 3:59 AM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Tue, Sep 11, 2012 at 05:07:49PM -0500, Rob Clark wrote: On Tue, Sep 11, 2012 at 4:15 PM, Ben Widawsky b...@bwidawsk.net wrote: On Sun, 9 Sep 2012 22:19:59 -0500 Rob Clark r...@ti.com wrote: On Sun, Sep

Re: [RFC 0/9] nuclear pageflip

2012-09-12 Thread Rob Clark
On Wed, Sep 12, 2012 at 9:23 AM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Wed, Sep 12, 2012 at 07:30:18AM -0500, Rob Clark wrote: On Wed, Sep 12, 2012 at 3:59 AM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Tue, Sep 11, 2012 at 05:07:49PM -0500, Rob Clark wrote

Re: [RFC 0/9] nuclear pageflip

2012-09-12 Thread Rob Clark
On Wed, Sep 12, 2012 at 9:34 AM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Wed, Sep 12, 2012 at 09:28:43AM -0500, Rob Clark wrote: On Wed, Sep 12, 2012 at 9:23 AM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Wed, Sep 12, 2012 at 07:30:18AM -0500, Rob Clark wrote

Re: [RFC 0/9] nuclear pageflip

2012-09-12 Thread Rob Clark
On Wed, Sep 12, 2012 at 10:12 AM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Wed, Sep 12, 2012 at 09:42:27AM -0500, Rob Clark wrote: On Wed, Sep 12, 2012 at 9:34 AM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Wed, Sep 12, 2012 at 09:28:43AM -0500, Rob Clark wrote

Re: [RFC 0/9] nuclear pageflip

2012-09-12 Thread Rob Clark
On Wed, Sep 12, 2012 at 10:32 AM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Wed, Sep 12, 2012 at 10:23:48AM -0500, Rob Clark wrote: On Wed, Sep 12, 2012 at 10:12 AM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Wed, Sep 12, 2012 at 09:42:27AM -0500, Rob Clark wrote

Re: [RFC 1/9] drm: add atomic fxns

2012-09-12 Thread Rob Clark
On Wed, Sep 12, 2012 at 11:57 AM, Jesse Barnes jbar...@virtuousgeek.org wrote: On Sun, 9 Sep 2012 22:03:14 -0500 Rob Clark rob.cl...@linaro.org wrote: From: Rob Clark r...@ti.com The 'atomic' mechanism allows for multiple properties to be updated, checked, and commited atomically

Re: [RFC 1/9] drm: add atomic fxns

2012-09-12 Thread Rob Clark
On Wed, Sep 12, 2012 at 1:03 PM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Wed, Sep 12, 2012 at 12:35:01PM -0500, Rob Clark wrote: On Wed, Sep 12, 2012 at 11:57 AM, Jesse Barnes jbar...@virtuousgeek.org wrote: On Sun, 9 Sep 2012 22:03:14 -0500 Rob Clark rob.cl...@linaro.org

Re: [RFC 0/9] nuclear pageflip

2012-09-12 Thread Rob Clark
On Wed, Sep 12, 2012 at 1:58 PM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Wed, Sep 12, 2012 at 01:00:19PM -0500, Clark, Rob wrote: On Wed, Sep 12, 2012 at 12:27 PM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Wed, Sep 12, 2012 at 10:48:16AM -0500, Rob Clark wrote

Re: [RFC 1/9] drm: add atomic fxns

2012-09-12 Thread Rob Clark
On Wed, Sep 12, 2012 at 2:05 PM, Jesse Barnes jbar...@virtuousgeek.org wrote: On Wed, 12 Sep 2012 12:35:01 -0500 Rob Clark rob.cl...@linaro.org wrote: On Wed, Sep 12, 2012 at 11:57 AM, Jesse Barnes jbar...@virtuousgeek.org wrote: On Sun, 9 Sep 2012 22:03:14 -0500 Rob Clark rob.cl

[PATCH] drm: change ioctl permissions

2012-09-12 Thread Rob Clark
From: Rob Clark r...@ti.com Previously read-only KMS ioctls had some somewhat inconsistent settings regarding whether mastership was required. For example, GETRESOURCES did not require master, but GETPLANERESOURCES, GETPROPERTY, etc. did. At least for debugging, it is nice to be able to use

[RFC 01/11] drm: add atomic fxns

2012-09-13 Thread Rob Clark
From: Rob Clark r...@ti.com The 'atomic' mechanism allows for multiple properties to be updated, checked, and commited atomically. This will be the basis of atomic- modeset and nuclear-pageflip. The basic flow is: state = dev-atomic_begin(); for (... one or more ...) obj

[RFC 00/11] atomic pageflip (v2)

2012-09-13 Thread Rob Clark
From: Rob Clark r...@ti.com This is following a bit the approach that Ville is taking for atomic- modeset, in that it is switching over to using properties for everything. The advantage of this approach is that it makes it easier to add new attributes to set as part of a page-flip (and even opens

[RFC 02/11] drm: add object property type

2012-09-13 Thread Rob Clark
From: Rob Clark r...@ti.com An object property is an id (idr) for a drm mode object. This will allow a property to be used set/get a framebuffer, CRTC, etc. --- drivers/gpu/drm/drm_crtc.c | 35 ++- include/drm/drm_crtc.h | 10 ++ include/drm

<    1   2   3   4   5   6   7   8   9   10   >