Re: [RFC] Virtual CRTCs (proposal + experimental code)

2011-11-03 Thread Roland Scheidegger
Am 03.11.2011 16:59, schrieb Ilija Hadzic: Hi everyone, I would like to bring to the attention of dri-devel and linux-fbdev community a set of hopefully useful and interesting patches that I (and a few other colleagues) have been working on during the past few months. Here, I will provide a

Re: [PATCH 3/4] drm: Add drm_format_{horz, vert}_chroma_subsampling() utility functions

2012-04-11 Thread Roland Scheidegger
Am 05.04.2012 20:35, schrieb ville.syrj...@linux.intel.com: From: Ville Syrjälä ville.syrj...@linux.intel.com These functions return the chroma subsampling factors for the specified pixel format. Hmm not really related but looking at it this reminds me these formats always look a bit

Re: [PATCH 3/4] drm: Add drm_format_{horz, vert}_chroma_subsampling() utility functions

2012-04-12 Thread Roland Scheidegger
Am 12.04.2012 14:23, schrieb Ville Syrjälä: On Wed, Apr 11, 2012 at 08:53:08PM +0200, Roland Scheidegger wrote: Am 05.04.2012 20:35, schrieb ville.syrj...@linux.intel.com: From: Ville Syrjälä ville.syrj...@linux.intel.com These functions return the chroma subsampling factors for the specified

Fixing SIGILL on Pentium 4

2016-01-17 Thread Roland Scheidegger
Am 17.01.2016 um 20:09 schrieb Michael Harder: > Hi all, > > I'm trying to get my Kodi media center working but am experiencing > crashes when playing a movie. There is a ticket > at https://bugs.freedesktop.org/show_bug.cgi?id=27512. From the help > I've received so far and the research I've

[PATCH 3/4] drm: Add drm_format_{horz, vert}_chroma_subsampling() utility functions

2012-04-11 Thread Roland Scheidegger
Am 05.04.2012 20:35, schrieb ville.syrjala at linux.intel.com: > From: Ville Syrj?l? > > These functions return the chroma subsampling factors for the specified > pixel format. Hmm not really related but looking at it this reminds me these formats always look a bit underspecified wrt chroma

[PATCH 3/4] drm: Add drm_format_{horz, vert}_chroma_subsampling() utility functions

2012-04-13 Thread Roland Scheidegger
Am 12.04.2012 14:23, schrieb Ville Syrj?l?: > On Wed, Apr 11, 2012 at 08:53:08PM +0200, Roland Scheidegger wrote: >> Am 05.04.2012 20:35, schrieb ville.syrjala at linux.intel.com: >>> From: Ville Syrj?l? >>> >>> These functions return the chroma subsampling

[PATCH 2/2] radeon: optimize allocation for depth w/o stencil and stencil w/o depth on EG

2012-07-30 Thread Roland Scheidegger
Am 30.07.2012 16:56, schrieb Jerome Glisse: > On Sun, Jul 29, 2012 at 1:04 PM, Marek Ol??k wrote: >> If we don't need stencil, don't allocate it. >> If we need only stencil (like PIPE_FORMAT_S8_UINT), don't allocate depth. >> >> v2: actually do it correctly > > Big NAK > > We need to allocate

[PATCH] drm/radeon/kms: fix thermal sensor reading on juniper

2011-05-26 Thread Roland Scheidegger
Am 26.05.2011 00:45, schrieb Alex Deucher: > Uses a different method than other evergreen asics. Strange the temps displayed always seemed to make sense here even with the wrong method :-). Roland

[RFC] Virtual CRTCs (proposal + experimental code)

2011-11-03 Thread Roland Scheidegger
Am 03.11.2011 16:59, schrieb Ilija Hadzic: > Hi everyone, > > I would like to bring to the attention of dri-devel and linux-fbdev > community a set of hopefully useful and interesting patches that > I (and a few other colleagues) have been working on during the past > few months. Here, I will

drm/radeon/kms: improve performance of blit-copy

2011-10-13 Thread Roland Scheidegger
Am 13.10.2011 05:29, schrieb Ilija Hadzic: > > The following set of patches will improve the performance of > blit-copy functions for Radeon GPUs based on R600, R700, Evergreen > and NI ASICs. > > The foundation for improvement is the use of tiled mode access (which > for copying bo's can be

Re: [PATCH] drm/radeon: fill in rb backend map on evergreen/ni.

2018-01-09 Thread Roland Scheidegger
FWIW I was wrong that it was never filled in - when the backend map query was introduced, the data indeed got filled in. However that got lost very soon afterwards (over 6 years ago) by some fixes for backend map calculation. In any case, Reviewed-by: Roland Scheidegger <srol...@vmware.com&g

Re: [PATCH][next] drm/vmwgfx: fix spelling mistake "Cound" -> "Could"

2020-03-26 Thread Roland Scheidegger
nd streamoutput to bind.\n"); > + DRM_ERROR("Could not find streamoutput to bind.\n"); > return PTR_ERR(res); > } > > Reviewed-by: Roland Scheidegger ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Linux-graphics-maintainer] [PATCH v3 15/25] drm: vmwgfx: fix common struct sg_table related issues

2020-05-11 Thread Roland Scheidegger
I'm not exactly an expert on this, but looks alright to me. Acked-by: Roland Scheidegger Am 05.05.20 um 10:46 schrieb Marek Szyprowski: > The Documentation/DMA-API-HOWTO.txt states that dma_map_sg returns the > numer of the created entries in the DMA address space. However the > subsequ

[PATCH] drm/vmwgfx: update MAINTAINERS entry

2020-05-15 Thread Roland Scheidegger
From: Roland Scheidegger Maintainer switch from Thomas Hellstrom to Roland Scheidegger Reviewed-by: Charmaine Lee Reviewed-by: Neha Bhende Acked-by: Thomas Hellstrom Signed-off-by: Roland Scheidegger --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Linux-graphics-maintainer] [PATCH] drm/vmwgfx: Return true in function vmw_fence_obj_signaled()

2020-05-14 Thread Roland Scheidegger
I've pulled that into our tree, thanks! Roland Am 07.05.20 um 13:07 schrieb Jason Yan: > Fix the following coccicheck warning: > > drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:518:9-10: WARNING: return of 0/1 > in function 'vmw_fence_obj_signaled' with return type bool > > Signed-off-by: Jason Yan >

Re: [PATCH 15/17] drm/vmwgfx: Add surface define v4 command

2020-03-23 Thread Roland Scheidegger
stride in surface metadata and create surface using new >> command if support is available. >> >> Also with this patch replace device specific data types with kernel >> types. >> >> Signed-off-by: Deepak Rawat >> Reviewed-by: Thomas Hellström (VMware) >&g

Re: [git pull] feature/staging_sm5

2020-03-23 Thread Roland Scheidegger
Am 23.03.20 um 01:36 schrieb Dave Airlie: > On Sat, 21 Mar 2020 at 08:57, Roland Scheidegger (VMware) > wrote: >> >> Dave, Daniel, >> >> vmwgfx pull for for 5.7. Needed for GL4 functionality. >> Sync up device headers, add support for new commands, code >

[PATCH v2 16/17] drm/vmwgfx: Add SM5 param for userspace

2020-03-23 Thread Roland Scheidegger
From: Deepak Rawat Add a new param for user-space to determine if kernel module is SM5 capable. Signed-off-by: Deepak Rawat Reviewed-by: Thomas Hellström (VMware) Reviewed-by: Roland Scheidegger Signed-off-by: Roland Scheidegger --- drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c | 3 +++ include

[PATCH v2 15/17] drm/vmwgfx: Add surface define v4 command

2020-03-23 Thread Roland Scheidegger
Rawat Reviewed-by: Thomas Hellström (VMware) Reviewed-by: Roland Scheidegger Signed-off-by: Roland Scheidegger --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 2 ++ drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 36 +++-- include/uapi/drm/vmwgfx_drm.h | 12 + 3

[PATCH v2 08/17] drm/vmwgfx: Support SM5 shader type in command buffer

2020-03-23 Thread Roland Scheidegger
From: Deepak Rawat Virtual device now supports new shader types, allow them as valid shader type in command buffer. Also add per shader bind info in binding manager state for new shader type. Signed-off-by: Deepak Rawat Reviewed-by: Thomas Hellström (VMware) Reviewed-by: Roland Scheidegger

[PATCH v2 06/17] drm/vmwgfx: Add a new enum for SM5 graphics context capability

2020-03-23 Thread Roland Scheidegger
From: Deepak Rawat A new enum to represent new SM5 graphics context capability in vmwgfx. v2: use new correct cap bits (merged several later commits into it). Signed-off-by: Deepak Rawat Signed-off-by: Thomas Hellström (VMware) Reviewed-by: Roland Scheidegger Signed-off-by: Roland

[PATCH v2 12/17] drm/vmwgfx: Add support for streamoutput with mob commands

2020-03-23 Thread Roland Scheidegger
as only one can be set to context. v4: Fix comment typos Signed-off-by: Deepak Rawat Signed-off-by: Neha Bhende Reviewed-by: Thomas Hellström (VMware) Reviewed-by: Roland Scheidegger Signed-off-by: Roland Scheidegger --- drivers/gpu/drm/vmwgfx/Makefile | 2 +- drivers/gpu/drm

[PATCH v2 09/17] drm/vmwgfx: Add support for UA view commands

2020-03-23 Thread Roland Scheidegger
deprecated PTR_RET) Signed-off-by: Deepak Rawat Signed-off-by: Neha Bhende Reviewed-by: Thomas Hellström (VMware) Reviewed-by: Roland Scheidegger Signed-off-by: Roland Scheidegger --- drivers/gpu/drm/vmwgfx/vmwgfx_binding.c | 129 - drivers/gpu/drm/vmwgfx/vmwgfx_binding.h

[PATCH v2 13/17] drm/vmwgfx: Split surface metadata from struct vmw_surface

2020-03-23 Thread Roland Scheidegger
Scheidegger Signed-off-by: Roland Scheidegger --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 56 -- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 16 +- drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c| 44 +++-- drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 240 +--- 4 files changed, 202

[PATCH v2 04/17] drm/vmwgfx: Use enum to represent graphics context capabilities

2020-03-23 Thread Roland Scheidegger
) Reviewed-by: Roland Scheidegger Signed-off-by: Roland Scheidegger --- drivers/gpu/drm/vmwgfx/vmwgfx_context.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 34 ++--- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 40 +++-- drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 6

[PATCH v2 00/17] drm/vmwgfx add support for GL4

2020-03-23 Thread Roland Scheidegger
From: "Roland Scheidegger (VMware)" This series updates vmwgfx to support newer vmware svga device protocol and expose new commands to userspace.. This is required for supporting newer GL4 features in the guest. This syncs up the device headers, adds support for the new commands

[PATCH v2 02/17] drm/vmwgfx: Sync legacy multisampling device capability

2020-03-23 Thread Roland Scheidegger
. Signed-off-by: Deepak Rawat Reviewed-by: Thomas Hellström (VMware) Reviewed-by: Roland Scheidegger Signed-off-by: Roland Scheidegger --- .../gpu/drm/vmwgfx/device_include/svga3d_devcaps.h | 13 + drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c | 11 +++ 2 files changed

[PATCH v2 10/17] drm/vmwgfx: Add support for indirect and dispatch commands

2020-03-23 Thread Roland Scheidegger
From: Deepak Rawat Validate indirect and dispatch commands in command buffer. Signed-off-by: Deepak Rawat Reviewed-by: Thomas Hellström (VMware) Reviewed-by: Roland Scheidegger Signed-off-by: Roland Scheidegger --- drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 70 + 1

[PATCH v2 17/17] drm/vmwgfx: Use vmwgfx version 2.18 to signal SM5 compatibility

2020-03-23 Thread Roland Scheidegger
From: Thomas Hellström (VMware) Signed-off-by: Thomas Hellström (VMware) Reviewed-by: Charmaine Lee Reviewed-by: Brian Paul Reviewed-by: Roland Scheidegger Signed-off-by: Roland Scheidegger ___ v2: Use 2.18 instead of 2.17 --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 2 +- 1 file changed, 1

[PATCH v2 07/17] drm/vmwgfx: Read new register for GB memory when available

2020-03-23 Thread Roland Scheidegger
From: Deepak Rawat Virtual device added new register for suggested GB memory, read the new register when available. Signed-off-by: Deepak Rawat Reviewed-by: Thomas Hellström (VMware) Reviewed-by: Roland Scheidegger Signed-off-by: Roland Scheidegger --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c

[PATCH v2 11/17] drm/vmwgfx: Rename stream output target binding tracker struct

2020-03-23 Thread Roland Scheidegger
-by: Deepak Rawat Reviewed-by: Thomas Hellström (VMware) Reviewed-by: Roland Scheidegger Signed-off-by: Roland Scheidegger --- drivers/gpu/drm/vmwgfx/vmwgfx_binding.c | 36 - drivers/gpu/drm/vmwgfx/vmwgfx_binding.h | 6 ++--- drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 4

[PATCH v2 14/17] drm/vmwgfx: Refactor surface_define to use vmw_surface_metadata

2020-03-23 Thread Roland Scheidegger
Scheidegger Signed-off-by: Roland Scheidegger --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 5 + drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 27 +- drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c| 51 +--- drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 378 4 files changed, 215 insertions

Re: [git pull] feature/staging_sm5

2020-03-23 Thread Roland Scheidegger
Am 23.03.20 um 19:43 schrieb Roland Scheidegger: > Am 23.03.20 um 01:36 schrieb Dave Airlie: >> On Sat, 21 Mar 2020 at 08:57, Roland Scheidegger (VMware) >> wrote: >>> >>> Dave, Daniel, >>> >>> vmwgfx pull for for 5.7. Needed for GL4 functionali

[PATCH v2 01/17] drm/vmwgfx: Also check for SVGA_CAP_DX before reading DX context support

2020-03-23 Thread Roland Scheidegger
Scheidegger Signed-off-by: Roland Scheidegger --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c index 4f58364421ce..f976dabe18de 100644 --- a/drivers/gpu/drm/vmwgfx

[PATCH v2 03/17] drm/vmwgfx: Deprecate logic ops commands

2020-03-23 Thread Roland Scheidegger
From: Deepak Rawat Logic ops commands are marked as deprecated by virtual device and were never used by vmwgfx. Signed-off-by: Deepak Rawat Reviewed-by: Thomas Hellström (VMware) Reviewed-by: Roland Scheidegger Signed-off-by: Roland Scheidegger --- .../gpu/drm/vmwgfx/device_include

Re: [PATCH 3/5] drm/vmwgfx: add a move callback.

2020-10-08 Thread Roland Scheidegger
Both vmwgxf patches look good to me too. Reviewed-by: Roland Scheidegger Am 06.10.20 um 02:06 schrieb Dave Airlie: > From: Dave Airlie > > This just copies the fallback to vmwgfx, I'm going to iterate on this > a bit until it's not the same as the fallback path. > > Signed-o

Re: [PATCH AUTOSEL 5.8 10/12] drm/vmwgfx: Fix error handling in get_node

2020-10-05 Thread Roland Scheidegger
igned-off-by: Zack Rusin > Reviewed-by: Roland Scheidegger > Reviewed-by: Martin Krastev > Sigend-off-by: Roland Scheidegger > Signed-off-by: Sasha Levin > --- > drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c | 2 +- > drivers/gpu/drm/vmwgfx/vmwgfx_thp.c | 2 +- > 2 fi

Re: [vmwgfx] Xwayland crash on latest linus git

2020-08-19 Thread Roland Scheidegger
I'm now able to reproduce this, looking into it. (The crash looks actually similar to what was also happening with the next commit, drm/ttm: make TT creation purely optional v3, but that got reverted already.) Roland Am 19.08.20 um 09:47 schrieb 허종만: > > Hi, > > > I'm running Linux guest OS

Re: [linux.git drm/ttm]: NULL pointer dereference upon driver probe

2020-08-06 Thread Roland Scheidegger
Am 06.08.20 um 17:28 schrieb Christian König: > My best guess is that you are facing two separate bugs here. > > Crash #1 is somehow related to CRTCs and might even be cause by the > atomic-helper change you noted below. > > Crash #2 is caused because vmw_bo_create_and_populate() tries to >

Re: [PATCH] drm/vmwgfx/stdu: Use drm_mode_config_reset

2020-08-06 Thread Roland Scheidegger
uot;drm/atomic-helper: reset vblank on crtc reset") > Reported-by: Tetsuo Handa > Cc: Tetsuo Handa > Signed-off-by: Daniel Vetter > Cc: VMware Graphics > Cc: Roland Scheidegger > --- > drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 9 ++--- > 1 file changed, 2 insertions

Re: [PATCH] drm/vmwgfx: fix spelling mistake "Cant" -> "Can't"

2020-08-10 Thread Roland Scheidegger
Thanks, I've put the fix in the vmwgfx-next branch. Roland Am 10.08.20 um 12:04 schrieb Colin King: > From: Colin Ian King > > There is a spelling mistake in a DRM_ERROR message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 2 +- > 1 file changed,

Re: [PATCH] drm/vmwgfx: Use correct vmw_legacy_display_unit pointer

2020-07-13 Thread Roland Scheidegger
Sorry for the delay, finally got time to look at this, seems all correct to me, thanks. Applied to our vmvgfx-next tree. (I do wonder how this somehow was supposed to work for all this time...) Roland Am 26.06.20 um 12:34 schrieb Dan Carpenter: > The "entry" pointer is an offset from the list

Re: [PATCH] drm/vmwgfx: Fix two list_for_each loop exit tests

2020-07-13 Thread Roland Scheidegger
Am 26.06.20 um 12:39 schrieb Dan Carpenter: > These if statements are supposed to be true if we ended the > list_for_each_entry() loops without hitting a break statement but they > don't work. > > In the first loop, we increment "i" after the "if (i == unit)" condition > so we don't necessarily

Re: [PATCH] drm/vmwgfx: Fix two list_for_each loop exit tests

2020-07-14 Thread Roland Scheidegger
Am 14.07.20 um 10:25 schrieb Dan Carpenter: > On Tue, Jul 14, 2020 at 03:39:13AM +0200, Roland Scheidegger wrote: >> Am 26.06.20 um 12:39 schrieb Dan Carpenter: >>> These if statements are supposed to be true if we ended the >>> list_for_each_entry() loops withou

Re: PROBLEM: kernel oops caused by vmwgfx_cmdbuf.c:399

2020-07-07 Thread Roland Scheidegger
Hi, we are aware of an issue in our driver with kernel 5.7 resulting in black screen and working on fixing it. Roland Am 07.07.20 um 17:43 schrieb Carle, Peter: > Good morning! Line 399 of vmwgfx_cmdbuf.c apparently causes a kernel oops > that freezes the OS during boot-time. > > Here is the

Re: [Linux-graphics-maintainer] [PATCH 2/3] drm: uapi: Use SPDX in DRM drivers uAPI headers

2020-06-23 Thread Roland Scheidegger
At least for the vmwgfx bits, no objections here, Reviewed-by: Roland Scheidegger Am 21.06.20 um 04:07 schrieb Laurent Pinchart: > Most of the DRM drivers uAPI headers are licensed under the MIT license, > and carry copies of the license with slight variations. Replace them > with SPD

Re: [PATCH] drm/vmwgfx: Use __drm_atomic_helper_crtc_reset

2020-06-22 Thread Roland Scheidegger
Looks great to me. Reviewed-by: Roland Scheidegger Am 12.06.20 um 22:49 schrieb Daniel Vetter: > Now also comes with the added benefit of doing a drm_crtc_vblank_off(), > which means vblank state isn't ill-defined and fail-y at driver load > before the first modeset on each crtc

Re: [PATCH][next] drm/vmwgfx: Use struct_size() helper

2020-06-22 Thread Roland Scheidegger
I've commited this to our next branch, thanks! (I'm actually kind of impressed this can be found automatically...) Roland Am 17.06.20 um 23:51 schrieb Gustavo A. R. Silva: > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. >

Re: [PATCH v2 1/2] drm: vmwgfx: remove drm_driver::master_set() return typ

2020-06-03 Thread Roland Scheidegger
Looks like a nice cleanup to me. (No idea if at some point there actually was a reason for a return value...) Reviewed-by: Roland Scheidegger Am 30.05.20 um 14:46 schrieb Emil Velikov: > The function always returns zero (success). Ideally we'll remove it all > together - although

Re: [PATCH] ttm: ttm_bo_swapout_all doesn't use it's argument.

2020-07-30 Thread Roland Scheidegger
Patch looks good to me too. Reviewed-by: Roland Scheidegger Seems indeed like we should do some cleanup. Roland Am 28.07.20 um 09:37 schrieb Christian König: > Am 28.07.20 um 05:42 schrieb Dave Airlie: >> From: Dave Airlie >> >> Just drop the argument from this

Re: [PATCH 1/3] drm/vmwgfx: Drop svga_lock

2021-01-14 Thread Roland Scheidegger
Hi, looking at it, seems alright. Not sure why the lock was supposedly needed, maybe it was at some point (it seems like all usage of this lock was introduced way back in 2015, commit 153b3d5b037ee). For the series: Reviewed-by: Roland Scheidegger Roland Am 12.01.21 um 09:49 schrieb Daniel

[PATCH] drm/vmwgfx: add some 16:9 / 16:10 default resolutions

2021-02-04 Thread Roland Scheidegger
The default list was old and in particular lacking all common 16:9 resolutions, as well as some newer 16:10 ones. This makes them selectable in resolution change lists, which can be quite useful (for instance in case auto-fit isn't enabled). Signed-off-by: Roland Scheidegger Reviewed-by: Martin

Re: [RESEND 00/53] Rid GPU from W=1 warnings

2021-03-05 Thread Roland Scheidegger
The vmwgfx ones look all good to me, so for 23-53: Reviewed-by: Roland Scheidegger That said, they were already signed off by Zack, so not sure what happened here. Roland On 03.03.21 14:42, Lee Jones wrote: > This is a resend. All of these patches have been sent before. > > The vm

Re: [patch 2/7] drm/vmgfx: Replace kmap_atomic()

2021-03-05 Thread Roland Scheidegger
n pgprot. > > Remove the NULL pointer check for the map. These functions return a valid > address for valid pages and the return was bogus anyway as it would have > left preemption and pagefaults disabled. > > Signed-off-by: Thomas Gleixner > Cc: VMware Graphics > Cc: Rola

Re: [PATCH v3] drm/vmwgfx: Make sure bo's are unpinned before putting them back

2021-04-15 Thread Roland Scheidegger
The logic is all complex, but looks good to me. Reviewed-by: Roland Scheidegger On 13.04.21 22:59, Zack Rusin wrote: > During cotable resize we pin the backup buffer to make sure the > trylock doesn't fail. We were never unpinning the backup buffer > resulting in every subsequent cotab

[git pull] vmwgfx-fixes-5.7

2020-05-15 Thread Roland Scheidegger (VMware)
) Colin Ian King (1): drm/vmwgfx: remove redundant assignment to variable ret Guixiong Wei (1): drm/vmwgfx: Fix parameter name in vmw_bo_init Jason Yan (1): drm/vmwgfx: Return true in function vmw_fence_obj_signaled() Roland Scheidegger (1): drm/vmwgfx: update

[git pull] feature/staging_sm5

2020-03-20 Thread Roland Scheidegger (VMware)
Dave, Daniel, vmwgfx pull for for 5.7. Needed for GL4 functionality. Sync up device headers, add support for new commands, code refactoring around surface definition. Preliminary mesa userspace code using these new vmwgfx features can be found at: https://gitlab.freedesktop.org/bhenden/mesa The

[git pull] feature/staging_sm5

2020-03-23 Thread Roland Scheidegger (VMware)
Dave, Daniel, vmwgfx pull for for 5.7. Needed for GL4 functionality. Sync up device headers, add support for new commands, code refactoring around surface definition. Preliminary mesa userspace code using these new vmwgfx features can be found at: https://gitlab.freedesktop.org/bhenden/mesa v2:

[PATCH v2 04/17] drm/vmwgfx: Use enum to represent graphics context capabilities

2020-03-23 Thread Roland Scheidegger (VMware)
) Reviewed-by: Roland Scheidegger Signed-off-by: Roland Scheidegger --- drivers/gpu/drm/vmwgfx/vmwgfx_context.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 34 ++--- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 40 +++-- drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 6

[PATCH v2 08/17] drm/vmwgfx: Support SM5 shader type in command buffer

2020-03-23 Thread Roland Scheidegger (VMware)
From: Deepak Rawat Virtual device now supports new shader types, allow them as valid shader type in command buffer. Also add per shader bind info in binding manager state for new shader type. Signed-off-by: Deepak Rawat Reviewed-by: Thomas Hellström (VMware) Reviewed-by: Roland Scheidegger

[PATCH v2 06/17] drm/vmwgfx: Add a new enum for SM5 graphics context capability

2020-03-23 Thread Roland Scheidegger (VMware)
From: Deepak Rawat A new enum to represent new SM5 graphics context capability in vmwgfx. v2: use new correct cap bits (merged several later commits into it). Signed-off-by: Deepak Rawat Signed-off-by: Thomas Hellström (VMware) Reviewed-by: Roland Scheidegger Signed-off-by: Roland

[PATCH v2 01/17] drm/vmwgfx: Also check for SVGA_CAP_DX before reading DX context support

2020-03-23 Thread Roland Scheidegger (VMware)
Scheidegger Signed-off-by: Roland Scheidegger --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c index 4f58364421ce..f976dabe18de 100644 --- a/drivers/gpu/drm/vmwgfx

[PATCH v2 16/17] drm/vmwgfx: Add SM5 param for userspace

2020-03-23 Thread Roland Scheidegger (VMware)
From: Deepak Rawat Add a new param for user-space to determine if kernel module is SM5 capable. Signed-off-by: Deepak Rawat Reviewed-by: Thomas Hellström (VMware) Reviewed-by: Roland Scheidegger Signed-off-by: Roland Scheidegger --- drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c | 3 +++ include

[PATCH v2 02/17] drm/vmwgfx: Sync legacy multisampling device capability

2020-03-23 Thread Roland Scheidegger (VMware)
. Signed-off-by: Deepak Rawat Reviewed-by: Thomas Hellström (VMware) Reviewed-by: Roland Scheidegger Signed-off-by: Roland Scheidegger --- .../gpu/drm/vmwgfx/device_include/svga3d_devcaps.h | 13 + drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c | 11 +++ 2 files changed

[PATCH v2 11/17] drm/vmwgfx: Rename stream output target binding tracker struct

2020-03-23 Thread Roland Scheidegger (VMware)
-by: Deepak Rawat Reviewed-by: Thomas Hellström (VMware) Reviewed-by: Roland Scheidegger Signed-off-by: Roland Scheidegger --- drivers/gpu/drm/vmwgfx/vmwgfx_binding.c | 36 - drivers/gpu/drm/vmwgfx/vmwgfx_binding.h | 6 ++--- drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 4

[PATCH v2 13/17] drm/vmwgfx: Split surface metadata from struct vmw_surface

2020-03-23 Thread Roland Scheidegger (VMware)
Scheidegger Signed-off-by: Roland Scheidegger --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 56 -- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 16 +- drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c| 44 +++-- drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 240 +--- 4 files changed, 202

[PATCH v2 14/17] drm/vmwgfx: Refactor surface_define to use vmw_surface_metadata

2020-03-23 Thread Roland Scheidegger (VMware)
Scheidegger Signed-off-by: Roland Scheidegger --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 5 + drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 27 +- drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c| 51 +--- drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 378 4 files changed, 215 insertions

[PATCH v2 09/17] drm/vmwgfx: Add support for UA view commands

2020-03-23 Thread Roland Scheidegger (VMware)
deprecated PTR_RET) Signed-off-by: Deepak Rawat Signed-off-by: Neha Bhende Reviewed-by: Thomas Hellström (VMware) Reviewed-by: Roland Scheidegger Signed-off-by: Roland Scheidegger --- drivers/gpu/drm/vmwgfx/vmwgfx_binding.c | 129 - drivers/gpu/drm/vmwgfx/vmwgfx_binding.h

[PATCH v2 03/17] drm/vmwgfx: Deprecate logic ops commands

2020-03-23 Thread Roland Scheidegger (VMware)
From: Deepak Rawat Logic ops commands are marked as deprecated by virtual device and were never used by vmwgfx. Signed-off-by: Deepak Rawat Reviewed-by: Thomas Hellström (VMware) Reviewed-by: Roland Scheidegger Signed-off-by: Roland Scheidegger --- .../gpu/drm/vmwgfx/device_include

[PATCH v2 17/17] drm/vmwgfx: Use vmwgfx version 2.18 to signal SM5 compatibility

2020-03-23 Thread Roland Scheidegger (VMware)
From: Thomas Hellström (VMware) Signed-off-by: Thomas Hellström (VMware) Reviewed-by: Charmaine Lee Reviewed-by: Brian Paul Reviewed-by: Roland Scheidegger Signed-off-by: Roland Scheidegger ___ v2: Use 2.18 instead of 2.17 --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 2 +- 1 file changed, 1

[PATCH v2 12/17] drm/vmwgfx: Add support for streamoutput with mob commands

2020-03-23 Thread Roland Scheidegger (VMware)
as only one can be set to context. v4: Fix comment typos Signed-off-by: Deepak Rawat Signed-off-by: Neha Bhende Reviewed-by: Thomas Hellström (VMware) Reviewed-by: Roland Scheidegger Signed-off-by: Roland Scheidegger --- drivers/gpu/drm/vmwgfx/Makefile | 2 +- drivers/gpu/drm

[PATCH v2 10/17] drm/vmwgfx: Add support for indirect and dispatch commands

2020-03-23 Thread Roland Scheidegger (VMware)
From: Deepak Rawat Validate indirect and dispatch commands in command buffer. Signed-off-by: Deepak Rawat Reviewed-by: Thomas Hellström (VMware) Reviewed-by: Roland Scheidegger Signed-off-by: Roland Scheidegger --- drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 70 + 1

[PATCH v2 07/17] drm/vmwgfx: Read new register for GB memory when available

2020-03-23 Thread Roland Scheidegger (VMware)
From: Deepak Rawat Virtual device added new register for suggested GB memory, read the new register when available. Signed-off-by: Deepak Rawat Reviewed-by: Thomas Hellström (VMware) Reviewed-by: Roland Scheidegger Signed-off-by: Roland Scheidegger --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c

[PATCH v2 00/17] drm/vmwgfx add support for GL4

2020-03-23 Thread Roland Scheidegger (VMware)
This series updates vmwgfx to support newer vmware svga device protocol and expose new commands to userspace.. This is required for supporting newer GL4 features in the guest. This syncs up the device headers, adds support for the new commands, and also refactors some code (in particular around

[PATCH v2 15/17] drm/vmwgfx: Add surface define v4 command

2020-03-23 Thread Roland Scheidegger (VMware)
Rawat Reviewed-by: Thomas Hellström (VMware) Reviewed-by: Roland Scheidegger Signed-off-by: Roland Scheidegger --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 2 ++ drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 36 +++-- include/uapi/drm/vmwgfx_drm.h | 12 + 3

[PATCH] drm/vmwgfx: Fix error handling in get_node

2020-09-29 Thread Roland Scheidegger (VMware)
. That seems to fix recent regressions with vmwgfx. Signed-off-by: Zack Rusin Reviewed-by: Roland Scheidegger Reviewed-by: Martin Krastev Sigend-off-by: Roland Scheidegger --- drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_thp.c | 2 +- 2 files

[git pull] vmwgfx-fixes-5.9

2020-09-29 Thread Roland Scheidegger (VMware)
Dave, Daniel One important fix for recent breakage. The following changes since commit a1b8638ba1320e6684aa98233c15255eb803fac7: Linux 5.9-rc7 (2020-09-27 14:38:10 -0700) are available in the Git repository at: git://people.freedesktop.org/~sroland/linux vmwgfx-fixes-5.9 for you to fetch

[git pull] vmwgfx-next-5.9

2020-08-11 Thread Roland Scheidegger (VMware)
Daniel Vetter (1): drm/vmwgfx/stdu: Use drm_mode_config_reset Gustavo A. R. Silva (1): drm/vmwgfx: Use struct_size() helper Roland Scheidegger (2): drm/vmwgfx/sou: Use drm_mode_config_reset drm/vmwgfx/ldu: Use drm_mode_config_reset drivers/gpu/drm/vmwgfx/v

[PATCH 2/2] drm/vmwgfx/ldu: Use drm_mode_config_reset

2020-08-10 Thread Roland Scheidegger (VMware)
From: Roland Scheidegger Same problem as in stdu, same fix. Fixes: 51f644b40b4b ("drm/atomic-helper: reset vblank on crtc reset") Acked-by: Charmaine Lee Reviewed-by: Zack Rusin Signed-off-by: Roland Scheidegger --- drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 8 ++-- 1 file

[PATCH 1/2] drm/vmwgfx/sou: Use drm_mode_config_reset

2020-08-10 Thread Roland Scheidegger (VMware)
From: Roland Scheidegger Same problem as in stdu, same fix. Fixes: 51f644b40b4b ("drm/atomic-helper: reset vblank on crtc reset") Acked-by: Charmaine Lee Reviewed-by: Zack Rusin Signed-off-by: Roland Scheidegger --- drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 9 ++--- 1 file

[PATCH] drm/vmwgfx: fix update of display surface when resolution changes

2020-07-13 Thread Roland Scheidegger (VMware)
From: Roland Scheidegger The assignment of metadata overwrote the new display resolution values, hence we'd miss the size actually changed and wouldn't redefine the surface. This would then lead to command buffer error when trying to update the screen target (due to the size mismatch

[git pull] vmwgfx-fixes-5.8

2020-07-15 Thread Roland Scheidegger (VMware)
Dave, Daniel, vmwgfx-fixes pull for 5.8. Just one fix for now, but it's a really important one, causing black screens in VMs (sometimes on boot), hence marking it for stable. The following changes since commit 1f054fd26e29784d373c3d29c348ee48f1c41fb2: drm/vmwgfx: fix update of display surface