[PATCH 5/8] drm/i2c: tda998x: add video and audio input configuration

2013-08-14 Thread Russell King - ARM Linux
On Tue, Aug 06, 2013 at 12:20:15AM +0200, Sebastian Hesselbarth wrote: > - also calculate CTS This is wrong... > + /* > + * HDMI 1.3a, 7.2.2 CTS parameter: > + * (avg cts) = (fTMDS * N) / (128 * fS) > + */ > + cts = n * mode->clock / p->audio_sample_rate; > + cts *=

[PATCH 6/8] drm/i2c: tda998x: fix sync generation and calculation

2013-08-14 Thread Russell King - ARM Linux
On Tue, Aug 06, 2013 at 12:20:16AM +0200, Sebastian Hesselbarth wrote: > + de_pix_s = mode->htotal - mode->hdisplay; > + de_pix_e = de_pix_s + mode->hdisplay; > + hs_pix_s = mode->hsync_start - mode->hdisplay; > + hs_pix_e = hs_pix_s + mode->hsync_end -

[PATCH 5/8] drm/i2c: tda998x: add video and audio input configuration

2013-08-14 Thread Russell King - ARM Linux
On Tue, Aug 06, 2013 at 12:20:15AM +0200, Sebastian Hesselbarth wrote: > @@ -0,0 +1,23 @@ > +#ifndef __TDA998X_H__ > +#define __TDA998X_H__ > + > +enum tda998x_audio_format { > + AFMT_I2S, > + AFMT_SPDIF, > +}; > + > +struct tda998x_encoder_params { > + int audio_cfg; > + int

[PATCH 6/8] drm/i2c: tda998x: fix sync generation and calculation

2013-08-14 Thread Russell King - ARM Linux
On Tue, Aug 06, 2013 at 12:20:16AM +0200, Sebastian Hesselbarth wrote: > This fixes the wrong sync generation and sync calculation of TDA998x > for HS/VS-based sync detection. > > Signed-off-by: Sebastian Hesselbarth The plus point with this is that interlaced modes (1080i) do work with the

[PATCH v2 0/8] Several NXP TDA998x patches

2013-08-16 Thread Russell King - ARM Linux
es for v2, too. > > I have not added Russell King's Tested-by, as I hope he will have a > close look at what I changed after his review comments. > > Darren Etheridge (1): > drm/tilcdc fixup mode to workaround sync for tda998x > > Russell King (5): > drm/i2c: tda998x: fix

[PATCH v2 5/8] drm/i2c: tda998x: add video and audio input configuration

2013-08-19 Thread Russell King - ARM Linux
On Mon, Aug 19, 2013 at 09:23:17AM +1000, Dave Airlie wrote: > On Thu, Aug 15, 2013 at 5:43 AM, Sebastian Hesselbarth > wrote: > > From: Russell King <rmk+kernel at arm.linux.org.uk> > > > > This patch adds tda998x specific parameters to allow it to be configured

[PATCH v2 4/8] drm/i2c: tda998x: prepare for video input configuration

2013-08-22 Thread Russell King - ARM Linux
On Wed, Aug 21, 2013 at 08:26:46PM +0200, Jean-Francois Moine wrote: > On Wed Aug 14 12:43:29 PDT 2013, Sebastian Hesselbarth wrote: > > From: Russell King <rmk+kernel at arm.linux.org.uk> > > > > The video-input-port (VIP) is highly configurable. This prepares

[PATCH v2 5/8] drm/i2c: tda998x: add video and audio input configuration

2013-08-22 Thread Russell King - ARM Linux
On Wed, Aug 21, 2013 at 08:33:55PM +0200, Jean-Francois Moine wrote: > On Wed Aug 14 12:43:30 PDT 2013, Sebastian Hesselbarth wrote: > > +static void > > +reg_write_range(struct drm_encoder *encoder, uint16_t reg, uint8_t *p, int > > cnt) > > +{ > > + struct i2c_client *client =

[PATCH v2 4/8] drm/i2c: tda998x: prepare for video input configuration

2013-08-22 Thread Russell King - ARM Linux
On Thu, Aug 22, 2013 at 08:53:13AM +0200, Jean-Francois Moine wrote: > On Wed, 21 Aug 2013 23:36:05 +0100 > Russell King - ARM Linux wrote: > > > > AFAIK, the TI boards have no "pin-swapped", nor has the Cubox (there is > > > no need to set t

[PATCH v2 4/8] drm/i2c: tda998x: prepare for video input configuration

2013-08-22 Thread Russell King - ARM Linux
On Thu, Aug 22, 2013 at 07:33:43AM -0400, Rob Clark wrote: > On Thu, Aug 22, 2013 at 2:53 AM, Jean-Francois Moine > wrote: > > On Wed, 21 Aug 2013 23:36:05 +0100 > > Russell King - ARM Linux wrote: > > > >> > AFAIK, the TI boards have no "pin-swapped&quo

[PATCH 1/3] drm: Add LCD display clock polarity flags

2013-12-02 Thread Russell King - ARM Linux
On Mon, Dec 02, 2013 at 04:39:26PM +0100, Marek Vasut wrote: > Add DRM flags for the LCD display clock polarity so the pixelclk-active DT > property can be properly handled by drivers using the DRM API. I still say that not even this should be part of the DRM mode API to userspace. The hint that

[PATCH 1/3] drm: Add LCD display clock polarity flags

2013-12-03 Thread Russell King - ARM Linux
On Tue, Dec 03, 2013 at 07:44:52PM +0800, Shawn Guo wrote: > On Mon, Dec 02, 2013 at 04:39:26PM +0100, Marek Vasut wrote: > > Add DRM flags for the LCD display clock polarity so the pixelclk-active DT > > property can be properly handled by drivers using the DRM API. > > > > Signed-off-by: Marek

[PATCH 0/4] Armada DRM: four fixes

2013-12-09 Thread Russell King - ARM Linux
Rob, David, Here are four fixes for review for the Armada DRM driver. drivers/gpu/drm/armada/armada_drm.h |1 + drivers/gpu/drm/armada/armada_drv.c |7 ++- drivers/gpu/drm/armada/armada_fbdev.c | 20 +++- drivers/gpu/drm/armada/armada_gem.c |7 --- 4

[PATCH v9 2/2] video: drm: exynos: Add pinctrl support to fimd

2013-02-28 Thread Russell King - ARM Linux
On Thu, Feb 28, 2013 at 11:03:57PM +0100, Sylwester Nawrocki wrote: > Please just use IS_ERR(), let's stop this IS_ERR_OR_NULL() insanity. Yes, indeed. On that topic (and off-topic for this thread, sorry) I've committed a set of patches to remove most users of IS_ERR_OR_NULL() from arch/arm.

[PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-23 Thread Russell King - ARM Linux
On Wed, Jan 23, 2013 at 07:24:33AM -0600, Rob Clark wrote: > On Wed, Jan 23, 2013 at 3:42 AM, Jean-Francois Moine > wrote: > > Hi Rob, > > > > As I wanted to re-use your nxp-tda998x driver for the Marvell Dove SoC, > > I had a look at your IT LCD driver. Comments below. > > Just fyi, you can

[PATCH 2/4] drm/i2c: nxp-tda998x (v3)

2013-01-31 Thread Russell King - ARM Linux
On Thu, Jan 31, 2013 at 08:23:53AM -0600, Rob Clark wrote: > On Wed, Jan 30, 2013 at 8:23 PM, Sebastian Hesselbarth > wrote: > > On 01/29/2013 06:23 PM, Rob Clark wrote: > >> > >> Driver for the NXP TDA998X i2c hdmi encoder slave. > > > > > > Rob, > > > > good to see a driver for TDA998x comming!

[PATCH RFC 1/3] DRM: Armada: Add Armada DRM driver

2013-07-02 Thread Russell King - ARM Linux
On Tue, Jul 02, 2013 at 09:01:55PM +0300, Ville Syrj?l? wrote: > On Sun, Jun 30, 2013 at 07:29:27PM +0200, Daniel Vetter wrote: > > On Sun, Jun 30, 2013 at 2:52 PM, Russell King - ARM Linux > > wrote: > > > | Default Colorimetry > > > | > > > | ... &g

DT binding review for Armada display subsystem

2013-07-13 Thread Russell King - ARM Linux
On Sat, Jul 13, 2013 at 12:56:50PM +0200, Sylwester Nawrocki wrote: > On 07/13/2013 10:35 AM, Jean-Francois Moine wrote: >> On Fri, 12 Jul 2013 13:00:23 -0600 Daniel Drake wrote: >>> On Fri, Jul 12, 2013 at 12:39 PM, Jean-Francois Moine >>> wrote: > - the phandles to the clocks does not

DT binding review for Armada display subsystem

2013-07-13 Thread Russell King - ARM Linux
On Sat, Jul 13, 2013 at 08:25:15AM -0600, Daniel Drake wrote: > I guess the IRE falls into the same category as the DCON - we won't > implement it for now, but knowing where it might fit in is useful. I don't see much need at the moment for IRE. IRE isn't going to be useful for general graphics

DT binding review for Armada display subsystem

2013-07-13 Thread Russell King - ARM Linux
On Sat, Jul 13, 2013 at 07:44:58PM +0200, Sebastian Hesselbarth wrote: > On 07/13/2013 01:12 PM, Russell King - ARM Linux wrote: >> When I designed the clk API, I arranged for things like clk_get() to >> take a reference on the module if the clock was supplied by a module. >

DT binding review for Armada display subsystem

2013-07-13 Thread Russell King - ARM Linux
On Sat, Jul 13, 2013 at 10:43:29PM +0200, Sylwester Nawrocki wrote: > I wasn't aware of it, thanks. I've seen a patch from Jiada Wang, it seems > they're working on v4 with clock object reference counting. Presumably we > need both clk_get() to be taking reference on the module and reference >

DT binding review for Armada display subsystem

2013-07-14 Thread Russell King - ARM Linux
On Sun, Jul 14, 2013 at 12:16:58AM +0200, Sylwester Nawrocki wrote: > On 07/13/2013 11:02 PM, Russell King - ARM Linux wrote: >> On Sat, Jul 13, 2013 at 10:43:29PM +0200, Sylwester Nawrocki wrote: >>> I wasn't aware of it, thanks. I've seen a patch from Jiada Wang, it seems &

[RFC 0/1] drm/pl111: Initial drm/kms driver for pl111

2013-07-26 Thread Russell King - ARM Linux
On Thu, Jul 25, 2013 at 02:21:59PM -0400, Rob Clark wrote: > On Thu, Jul 25, 2013 at 1:17 PM, wrote: > > Known issues: > > * It uses KDS. We intend to switch to whatever implicit per-buffer > >synchronisation mechanism gets merged, once something is merged. > > * It abuses flags parameter

[PATCH 0/2] drm/tilcdc drm/i2c/tda998x workaround for sync issues on TI SoC

2013-07-31 Thread Russell King - ARM Linux
On Wed, Jul 31, 2013 at 10:21:20PM +0200, Sebastian Hesselbarth wrote: > Should we prepare a new patch set comprising the following patches? > > Russell King: > drm/i2c: nxp-tda998x: fix EDID reading on TDA19988 devices > drm/i2c: nxp-tda998x: ensure VIP output mux is properly set

[RFC v2 0/8] rmk's Dove DRM/TDA19988 Cubox driver

2013-06-09 Thread Russell King - ARM Linux
This is version 2 of my DRM driver. Changes since the previous version: 1. It's now called Armada not Dove, because the "LCD controllers" aka CRTCs are found in Armada 16x as well as Armada 510 Dove. The Armada 16x is preliminary work. 2. Cursor support is now a separate patch. I've

[RFC v2 0/8] rmk's Dove DRM/TDA19988 Cubox driver

2013-06-09 Thread Russell King - ARM Linux
On Sun, Jun 09, 2013 at 08:06:12PM +0100, Russell King - ARM Linux wrote: > This is version 2 of my DRM driver. Changes since the previous version: Okay, patch 1 got removed from this set, so some people won't see it (it shouldn't have been sent). Patch 2 is in moderation, which is proba

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-11 Thread Russell King - ARM Linux
On Tue, Jun 11, 2013 at 09:24:16AM +1000, Dave Airlie wrote: > I'd like to see all the ARM based drivers based on CMA if it can meet > their requirements > and using close to standard GEM/dma-buf interfaces. Otherwise it'll be > come an unmaintainable > nightmare for everyone, but mostly for me.

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Russell King - ARM Linux
On Mon, Jun 10, 2013 at 11:57:32AM -0400, Rob Clark wrote: > On Sun, Jun 9, 2013 at 3:29 PM, Russell King > <rmk+kernel at arm.linux.org.uk> wrote: > > This patch adds support for the pair of LCD controllers on the Marvell > > Armada 510 SoCs. This driver supports: &

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Russell King - ARM Linux
On Mon, Jun 10, 2013 at 03:59:34PM -0400, Rob Clark wrote: > On Mon, Jun 10, 2013 at 1:06 PM, Russell King - ARM Linux > wrote: > > ARMADA_GEM_CREATE_PHYS is to deal with creating a gem buffer object for > > a chunk of physical memory allocated by other means (e

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Russell King - ARM Linux
On Mon, Jun 10, 2013 at 05:01:18PM -0400, Rob Clark wrote: > I would like to get at least some of the driver upstream. I'd hate > for it to have to live completely out of tree. I can think of a > couple possibilities. > > 1) the best would be, if there was some way for the drm driver to know >

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Russell King - ARM Linux
On Mon, Jun 10, 2013 at 11:57:32AM -0400, Rob Clark wrote: > On Sun, Jun 9, 2013 at 3:29 PM, Russell King > <rmk+kernel at arm.linux.org.uk> wrote: > > +/* The mode_config.mutex will be held for this call */ > > +static int armada_drm_crtc_mode_set_base(struct drm_crtc

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Russell King - ARM Linux
On Mon, Jun 10, 2013 at 01:10:18PM +0200, Sebastian Hesselbarth wrote: > On 06/09/13 21:29, Russell King wrote: >> +/* >> + * The spec is unclear about the polarities of the syncs. >> + * We assume their non-inverted state is active high. >> + */ >

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-11 Thread Russell King - ARM Linux
On Tue, Jun 11, 2013 at 12:01:59AM +0200, Daniel Vetter wrote: > On Mon, Jun 10, 2013 at 9:59 PM, Rob Clark wrote: > > On Mon, Jun 10, 2013 at 1:06 PM, Russell King - ARM Linux > > wrote: > >> On Mon, Jun 10, 2013 at 11:57:32AM -0400, Rob Clark wrote: > >>

[RFC v3 0/4] rmk's Dove DRM/TDA19988 Cubox driver

2013-06-11 Thread Russell King - ARM Linux
Okay, so the previous set didn't contain all the updates I wanted. That's partly because of the timespan between making those changes and re-posting the RFC. This time, the "Add Armada DRM driver" commit contains all the updates it should've had from last time! However, I'm posting a slightly

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-11 Thread Russell King - ARM Linux
On Mon, Jun 10, 2013 at 06:49:06PM -0400, Rob Clark wrote: > I guess in the short term, the best I can think is keep those phys > ioctls as a small patch on top of the upstream driver. It is ok to > leave place-holder ioctl #'s in the upstream driver so that the ioctl > #'s don't shift when you

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-11 Thread Russell King - ARM Linux
On Mon, Jun 10, 2013 at 07:17:22PM -0400, Rob Clark wrote: > On Mon, Jun 10, 2013 at 6:56 PM, Russell King - ARM Linux > wrote: > > On Mon, Jun 10, 2013 at 06:49:06PM -0400, Rob Clark wrote: > >> I guess in the short term, the best I can think is keep those phys > &g

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-11 Thread Russell King - ARM Linux
On Tue, Jun 11, 2013 at 09:48:57AM +1000, Dave Airlie wrote: > On Tue, Jun 11, 2013 at 9:36 AM, Russell King - ARM Linux > wrote: > > On Tue, Jun 11, 2013 at 09:24:16AM +1000, Dave Airlie wrote: > >> I'd like to see all the ARM based drivers based on CMA if it can meet &g

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-12 Thread Russell King - ARM Linux
On Tue, Jun 11, 2013 at 09:48:57AM +1000, Dave Airlie wrote: > On Tue, Jun 11, 2013 at 9:36 AM, Russell King - ARM Linux > wrote: > > On Tue, Jun 11, 2013 at 09:24:16AM +1000, Dave Airlie wrote: > >> I'd like to see all the ARM based drivers based on CMA if it can meet &g

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-12 Thread Russell King - ARM Linux
On Wed, Jun 12, 2013 at 09:56:22AM -0400, Rob Clark wrote: > On Wed, Jun 12, 2013 at 9:48 AM, Russell King - ARM Linux > wrote: > > And having thought about this driver, DRM some more, I'm now of the > > opinion that DRM is not suitable for driving hardware where the GPU

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-12 Thread Russell King - ARM Linux
On Wed, Jun 12, 2013 at 05:49:14PM +0100, Russell King - ARM Linux wrote: > On Wed, Jun 12, 2013 at 09:56:22AM -0400, Rob Clark wrote: > > On Wed, Jun 12, 2013 at 9:48 AM, Russell King - ARM Linux > > wrote: > > > And having thought about this driver, DRM some more, I'm

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-12 Thread Russell King - ARM Linux
On Wed, Jun 12, 2013 at 06:05:12PM +0100, Russell King - ARM Linux wrote: > On Wed, Jun 12, 2013 at 05:49:14PM +0100, Russell King - ARM Linux wrote: > > On Wed, Jun 12, 2013 at 09:56:22AM -0400, Rob Clark wrote: > > > On Wed, Jun 12, 2013 at 9:48 AM, Russell King - ARM

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-13 Thread Russell King - ARM Linux
And here's another one - look carefully at this path: buf = dev->driver->gem_prime_export(dev, obj, flags); if (IS_ERR(buf)) { /* normally the created dma-buf takes ownership of the ref, * but if that fails then

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-13 Thread Russell King - ARM Linux
And another issue... What is drm_crtc_helper_set_mode() passed as the fb argument? Is it the old fb, or the new fb? bool drm_crtc_helper_set_mode(struct drm_crtc *crtc, struct drm_display_mode *mode, int x, int y,

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-13 Thread Russell King - ARM Linux
On Thu, Jun 13, 2013 at 12:19:03PM +0100, Russell King - ARM Linux wrote: > The deeper I look, the more bugs there seem to be in this DRM stuff, > and I'm continuing to look because I'm chasing a framebuffer refcount > bug. So, this refcount bug - I think I've just found it. This is

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-13 Thread Russell King - ARM Linux
On Thu, Jun 13, 2013 at 12:50:16PM +0100, Russell King - ARM Linux wrote: > On Thu, Jun 13, 2013 at 12:19:03PM +0100, Russell King - ARM Linux wrote: > > The deeper I look, the more bugs there seem to be in this DRM stuff, > > and I'm continuing to look because I'm chasing a frame

[RFC PATCH] dmabuf-sync: Introduce buffer synchronization framework

2013-06-13 Thread Russell King - ARM Linux
On Thu, Jun 13, 2013 at 05:28:08PM +0900, Inki Dae wrote: > This patch adds a buffer synchronization framework based on DMA BUF[1] > and reservation[2] to use dma-buf resource, and based on ww-mutexes[3] > for lock mechanism. > > The purpose of this framework is not only to couple cache

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-14 Thread Russell King - ARM Linux
On Fri, Jun 14, 2013 at 03:53:41PM +0200, Daniel Vetter wrote: > On Thu, Jun 13, 2013 at 12:50:16PM +0100, Russell King - ARM Linux wrote: > > On Thu, Jun 13, 2013 at 12:19:03PM +0100, Russell King - ARM Linux wrote: > > > The deeper I look, the more bugs there seem to be

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-14 Thread Russell King - ARM Linux
On Fri, Jun 14, 2013 at 04:23:22PM +0200, Daniel Vetter wrote: > On Thu, Jun 13, 2013 at 3:03 PM, Russell King - ARM Linux > wrote: > > There's a bigger issue here - if it's possible for > > drm_crtc_helper_set_config() > > to be called with set->fb set but set-&g

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-15 Thread Russell King - ARM Linux
On Fri, Jun 14, 2013 at 09:50:22PM +0200, Daniel Vetter wrote: > On Fri, Jun 14, 2013 at 4:42 PM, Russell King - ARM Linux > wrote: > > If you're happy with the patch I supplied, that's probably the minimal fix > > which should go to stable kernels (I'm using 3.9 here)

[RFC PATCH v2] dmabuf-sync: Introduce buffer synchronization framework

2013-06-17 Thread Russell King - ARM Linux
On Mon, Jun 17, 2013 at 10:04:45PM +0900, Inki Dae wrote: > It's just to implement a thin sync framework coupling cache operation. This > approach is based on dma-buf for more generic implementation against android > sync driver or KDS. > > The described steps may be summarized as: > lock

[RFC PATCH v2] dmabuf-sync: Introduce buffer synchronization framework

2013-06-17 Thread Russell King - ARM Linux
On Tue, Jun 18, 2013 at 12:03:31AM +0900, Inki Dae wrote: > 2013/6/17 Russell King - ARM Linux > Exactly right. But that is not definitely my point. Could you please see > the below simple example?: > (Presume that CPU and DMA share a buffer and the buffer is mapped with user > sp

[RFC PATCH v2] dmabuf-sync: Introduce buffer synchronization framework

2013-06-17 Thread Russell King - ARM Linux
On Mon, Jun 17, 2013 at 04:42:37PM +0100, Russell King - ARM Linux wrote: > On Tue, Jun 18, 2013 at 12:03:31AM +0900, Inki Dae wrote: > > 2013/6/17 Russell King - ARM Linux > > Exactly right. But that is not definitely my point. Could you please see > > the below simple e

[RFC PATCH v2] dmabuf-sync: Introduce buffer synchronization framework

2013-06-17 Thread Russell King - ARM Linux
On Tue, Jun 18, 2013 at 02:19:04AM +0900, Inki Dae wrote: > It seems like that all pages of the scatterlist should be mapped with > DMA every time DMA operation is started (or drm_xxx_set_src_dma_buffer > function call), and the pages should be unmapped from DMA again every > time DMA operation

[RFC PATCH v2] dmabuf-sync: Introduce buffer synchronization framework

2013-06-18 Thread Russell King - ARM Linux
On Tue, Jun 18, 2013 at 02:27:40PM +0900, Inki Dae wrote: > So I'd like to ask for other DRM maintainers. How do you think about it? it > seems like that Intel DRM (maintained by Daniel), OMAP DRM (maintained by > Rob) and GEM CMA helper also have same issue Russell pointed out. I think > not only

[RFC PATCH v2] dmabuf-sync: Introduce buffer synchronization framework

2013-06-18 Thread Russell King - ARM Linux
On Tue, Jun 18, 2013 at 06:04:44PM +0900, Inki Dae wrote: > > > > -Original Message- > > From: Russell King - ARM Linux [mailto:linux at arm.linux.org.uk] > > Sent: Tuesday, June 18, 2013 5:43 PM > > To: Inki Dae > > Cc: 'Maarten Lankhorst'; 'linux-f

[RFC PATCH v2] dmabuf-sync: Introduce buffer synchronization framework

2013-06-18 Thread Russell King - ARM Linux
On Tue, Jun 18, 2013 at 09:00:16AM +0200, Daniel Vetter wrote: > On Mon, Jun 17, 2013 at 04:42:37PM +0100, Russell King - ARM Linux wrote: > > What we need is something along the lines of: > > (a) dma_buf_map_attachment() _not_ to map the scatterlist for DMA. > > or > &g

[RFC PATCH v2] dmabuf-sync: Introduce buffer synchronization framework

2013-06-19 Thread Russell King - ARM Linux
On Thu, Jun 20, 2013 at 12:10:04AM +0900, Inki Dae wrote: > On the other hand, the below shows how we could enhance the conventional > way with my approach (just example): > > CPU -> DMA, > ioctl(qbuf command) ioctl(streamon) > |

[RFC PATCH v2] dmabuf-sync: Introduce buffer synchronization framework

2013-06-20 Thread Russell King - ARM Linux
i-devel-bounces+inki.dae=samsung.com at lists.freedesktop.org] > > > On > > > Behalf Of Russell King - ARM Linux > > > Sent: Thursday, June 20, 2013 3:29 AM > > > To: Inki Dae > > > Cc: linux-fbdev; DRI mailing list; Kyungmin Park; m

[PATCH v4] drm/i2c: tda998x: fix sync generation and calculation

2013-06-20 Thread Russell King - ARM Linux
On Thu, Jun 20, 2013 at 09:46:03PM +0200, Sebastian Hesselbarth wrote: > + ref_pix = 3 + mode->hsync_start - mode->hdisplay; > + de_pix_s = mode->htotal - mode->hdisplay; > + de_pix_e = de_pix_s + mode->hdisplay; > + hs_pix_s = mode->hsync_start - mode->hdisplay; >

Armada DRM driver on OLPC XO

2013-06-26 Thread Russell King - ARM Linux
On Wed, Jun 26, 2013 at 06:42:50PM +0200, Jean-Francois Moine wrote: > Do you know that there are 2 drm drivers for the Cubox? I posted mine > (http://lists.infradead.org/pipermail/linux-arm-kernel/2013-May/168732.html) > before Russell, but I got no return about it yet. > > As it uses the CMA

Armada DRM driver on OLPC XO

2013-06-27 Thread Russell King - ARM Linux
On Tue, Jun 25, 2013 at 04:47:26PM -0400, Daniel Drake wrote: > Hi Russell, > > Thanks a lot for writing the Armada DRM driver. > > I have tested it on OLPC XO-1.75 (MMP2 aka Armada610) and OLPC XO-4 (MMP3 > aka PXA2128). After a bit of fighting, I have it running. Could you share your > X

Armada DRM driver on OLPC XO

2013-06-28 Thread Russell King - ARM Linux
On Fri, Jun 28, 2013 at 01:54:21PM -0600, Daniel Drake wrote: > On Wed, Jun 26, 2013 at 10:42 AM, Jean-Francois Moine > wrote: > > Do you know that there are 2 drm drivers for the Cubox? I posted mine > > (http://lists.infradead.org/pipermail/linux-arm-kernel/2013-May/168732.html) > > before

armada_drm clock selection

2013-06-28 Thread Russell King - ARM Linux
On Fri, Jun 28, 2013 at 04:11:32PM -0400, Daniel Drake wrote: > Hi Russell, > > Thanks for pointing me to the most recent version of your driver. > Can you comment on the below patch for improved clock handling? Sure... lets add some background info first: the big problem here is the completely

armada_drm clock selection

2013-06-28 Thread Russell King - ARM Linux
On Fri, Jun 28, 2013 at 10:18:48PM +0100, Russell King - ARM Linux wrote: > On Fri, Jun 28, 2013 at 04:11:32PM -0400, Daniel Drake wrote: > > +int armada_drm_find_best_clock(struct armada_private *priv, long > > needed_rate) > > +{ > > + int i; > > + >

Armada DRM driver on OLPC XO

2013-06-28 Thread Russell King - ARM Linux
On Tue, Jun 25, 2013 at 04:47:26PM -0400, Daniel Drake wrote: > I have tested it on OLPC XO-1.75 (MMP2 aka Armada610) and OLPC XO-4 (MMP3 > aka PXA2128). After a bit of fighting, I have it running. Could you share your > X driver, or your methodology for testing hardware cursors? I'd like to test

Armada DRM driver on OLPC XO

2013-06-28 Thread Russell King - ARM Linux
On Fri, Jun 28, 2013 at 03:36:37PM -0600, Daniel Drake wrote: > On Fri, Jun 28, 2013 at 3:27 PM, Russell King - ARM Linux > wrote: > > On Tue, Jun 25, 2013 at 04:47:26PM -0400, Daniel Drake wrote: > >> I have tested it on OLPC XO-1.75 (MMP2 aka Armada610) and OLPC XO-4 (

armada_drm clock selection

2013-06-29 Thread Russell King - ARM Linux
On Sat, Jun 29, 2013 at 05:58:26PM +0200, Sebastian Hesselbarth wrote: > On 06/29/2013 05:06 PM, Daniel Drake wrote: >> On Fri, Jun 28, 2013 at 3:18 PM, Russell King - ARM Linux >> wrote: >>> Sure... lets add some background info first: the big problem here is the

armada_drm clock selection

2013-06-29 Thread Russell King - ARM Linux
On Sat, Jun 29, 2013 at 09:06:47AM -0600, Daniel Drake wrote: > MMP2 (Armada 610) and MMP3 (PXA2128, no Armada name) is even a bit > more complex than that. > On MMP2 the selectable clocks are written in bits 31:30 and are: > 0 - AXI, 1 - LCD1, 2 - LCD2, 3 - HDMI > > On MMP3 the selectable clocks

[PATCH RFC v4 0/3] Armada DRM driver

2013-06-30 Thread Russell King - ARM Linux
Quite a number of things has changed since the last revision in the core code - notably the move to use drm_plane for overlay, and the limited and restricted use of dma_buf so that gem objects can be passed to the GALCORE code and libbmm contiguous video frames can be imported into DRM. As I

[PATCH RFC 1/3] DRM: Armada: Add Armada DRM driver

2013-06-30 Thread Russell King - ARM Linux
On Sun, Jun 30, 2013 at 01:59:41PM +0200, Daniel Vetter wrote: > On Sat, Jun 29, 2013 at 11:53:22PM +0100, Russell King wrote: > > +static uint32_t armada_drm_crtc_calculate_csc(struct armada_crtc *dcrtc) > > +{ > > + struct drm_display_mode *adj = >crtc.mode;

[PATCH RFC 1/3] DRM: Armada: Add Armada DRM driver

2013-06-30 Thread Russell King - ARM Linux
On Sun, Jun 30, 2013 at 02:37:41PM +0200, Daniel Vetter wrote: > On Sat, Jun 29, 2013 at 11:53:22PM +0100, Russell King wrote: > > + mutex_lock(>struct_mutex); > > + free = drm_mm_search_free(>linear, size, align, 0); > > + if (free)

[PATCH RFC 1/3] DRM: Armada: Add Armada DRM driver

2013-06-30 Thread Russell King - ARM Linux
On Sun, Jun 30, 2013 at 02:04:56PM +0100, Russell King - ARM Linux wrote: > On Sun, Jun 30, 2013 at 02:37:41PM +0200, Daniel Vetter wrote: > > On Sat, Jun 29, 2013 at 11:53:22PM +0100, Russell King wrote: > > > + mutex_lock(>struct_mutex); > > > + fre

[PATCH RFC 1/3] DRM: Armada: Add Armada DRM driver

2013-06-30 Thread Russell King - ARM Linux
Right, so, incrementally, the changes are (this may not entirely apply to the version I've posted because I have several patches on top of that.) I've also added locking to the calls to drm_mm_dump_table() as otherwise these walk those lists without holding any locks what so ever, which could

[PATCH RFC 1/3] DRM: Armada: Add Armada DRM driver

2013-07-01 Thread Russell King - ARM Linux
On Mon, Jul 01, 2013 at 10:01:30AM +1000, Dave Airlie wrote: > OMG I'm working in a subsystem where stuff is being developed, with only > a few resources! I know my full time job isn't maintaining a 500,000 > line subsystem, > and the sub maintainers and developers do a great job refactoring >

[PATCH v3 06/14] Documentation: drm/bridge: add document for analogix_dp

2015-08-25 Thread Russell King - ARM Linux
On Tue, Aug 25, 2015 at 11:12:48AM +0200, Thierry Reding wrote: > On Mon, Aug 24, 2015 at 09:48:27AM -0500, Rob Herring wrote: > > It goes beyond bindings IMO. The use of the component framework or not > > has been at the whim of driver writers as well. It is either used or > > private APIs are

[PATCH v3 06/14] Documentation: drm/bridge: add document for analogix_dp

2015-08-25 Thread Russell King - ARM Linux
On Tue, Aug 25, 2015 at 12:40:01PM +0200, Thierry Reding wrote: > On Tue, Aug 25, 2015 at 10:29:39AM +0100, Russell King - ARM Linux wrote: > > Now, what happens when some other DRM driver wants to use the tda998x > > driver, and its bindings are not compatible with the co

[PATCH 12/29] drm/armada: Drop struct_mutex from cursor paths

2015-12-03 Thread Russell King - ARM Linux
On Mon, Nov 23, 2015 at 10:32:45AM +0100, Daniel Vetter wrote: > @@ -957,11 +955,9 @@ static int armada_drm_crtc_cursor_move(struct drm_crtc > *crtc, int x, int y) > if (!dcrtc->variant->has_spu_adv_reg) > return -EFAULT; > > - mutex_lock(>struct_mutex); >

[PATCH v4 0/4] drm: Add support for the ARM HDLCD display controller

2015-12-03 Thread Russell King - ARM Linux
On Thu, Dec 03, 2015 at 10:40:45AM +, Liviu Dudau wrote: > This series depends on Sudeep Holla's SCPI driver (now in mainline) and on > the tda998x patches that have been queued on Russell's patch system here [1]. Now merged into my tree. Can I ask a fairly obvious question... >

[PATCH 02/12] drm/etnaviv: add devicetree bindings

2015-12-04 Thread Russell King - ARM Linux
On Fri, Dec 04, 2015 at 10:29:56AM -0600, Rob Herring wrote: > On Fri, Dec 04, 2015 at 02:59:54PM +0100, Lucas Stach wrote: > > +Vivante GPU core devices > > + > > + > > +Required properties: > > +- compatible: Should be "vivante,gc" > > This should at least have the specific

[PATCH 02/12] drm/etnaviv: add devicetree bindings

2015-12-04 Thread Russell King - ARM Linux
On Fri, Dec 04, 2015 at 05:41:45PM +0100, Lucas Stach wrote: > Am Freitag, den 04.12.2015, 10:29 -0600 schrieb Rob Herring: > > On Fri, Dec 04, 2015 at 02:59:54PM +0100, Lucas Stach wrote: > > > +gpu-subsystem { > > > + compatible = "fsl,imx-gpu-subsystem"; > > > + cores = <_2d>, <_3d>; > > > +};

[PATCH 11/12] MAINTAINERS: add Lucas Stach as maintainer for the etnaviv DRM driver

2015-12-04 Thread Russell King - ARM Linux
On Fri, Dec 04, 2015 at 03:00:03PM +0100, Lucas Stach wrote: > Signed-off-by: Lucas Stach Acked-by: Russell King <rmk+kernel at arm.linux.org.uk> Although, I would like to be copied on patches, I don't think we have a way to encode that information in MAINTAINERS. > --- >

[PATCH 11/12] MAINTAINERS: add Lucas Stach as maintainer for the etnaviv DRM driver

2015-12-04 Thread Russell King - ARM Linux
On Fri, Dec 04, 2015 at 12:08:47PM -0500, Ilia Mirkin wrote: > On Fri, Dec 4, 2015 at 12:07 PM, Russell King - ARM Linux > wrote: > > On Fri, Dec 04, 2015 at 03:00:03PM +0100, Lucas Stach wrote: > >> Signed-off-by: Lucas Stach > > > > Acked-by: Russell Kin

[PATCH 11/12] MAINTAINERS: add Lucas Stach as maintainer for the etnaviv DRM driver

2015-12-04 Thread Russell King - ARM Linux
On Fri, Dec 04, 2015 at 06:26:38PM +0100, Marc Kleine-Budde wrote: > On 12/04/2015 06:07 PM, Russell King - ARM Linux wrote: > > On Fri, Dec 04, 2015 at 03:00:03PM +0100, Lucas Stach wrote: > >> Signed-off-by: Lucas Stach > > > > Acked-by: Russell King &

[PATCH 02/12] drm/etnaviv: add devicetree bindings

2015-12-04 Thread Russell King - ARM Linux
On Fri, Dec 04, 2015 at 11:33:22AM -0600, Rob Herring wrote: > On Fri, Dec 4, 2015 at 10:41 AM, Lucas Stach > wrote: > > I'm aware of that, but I don't see much value in kicking this discussion > > around for every DRM driver submission. This is the binding that has > > emerged from a lengthy

[PATCH 02/12] drm/etnaviv: add devicetree bindings

2015-12-04 Thread Russell King - ARM Linux
On Fri, Dec 04, 2015 at 02:19:42PM -0600, Rob Herring wrote: > On Fri, Dec 4, 2015 at 11:56 AM, Lucas Stach > wrote: > > Am Freitag, den 04.12.2015, 11:33 -0600 schrieb Rob Herring: > >> On Fri, Dec 4, 2015 at 10:41 AM, Lucas Stach > >> wrote: > >> > Am Freitag, den 04.12.2015, 10:29 -0600

[PATCH 02/12] drm/etnaviv: add devicetree bindings

2015-12-04 Thread Russell King - ARM Linux
On Fri, Dec 04, 2015 at 03:42:47PM -0500, Ilia Mirkin wrote: > On Fri, Dec 4, 2015 at 3:31 PM, Russell King - ARM Linux > wrote: > > Moreover, DRI3 is not yet available for Gallium, so if we're talking > > about Xorg, then functional DRI2 is a requirement, and that _needs_ &g

[PATCH 02/12] drm/etnaviv: add devicetree bindings

2015-12-05 Thread Russell King - ARM Linux
On Sat, Dec 05, 2015 at 11:12:08AM +0100, Daniel Vetter wrote: > Given that I think the current etnaviv is a sound architecture. And I'm > not saying that because drm requires everything to be smashed into one > driver, since that's simple not the case. There's other reasons as well, mostly from

[PATCH 02/12] drm/etnaviv: add devicetree bindings

2015-12-05 Thread Russell King - ARM Linux
On Sat, Dec 05, 2015 at 12:26:19PM +0100, Lucas Stach wrote: > I see where you are going here and I appreciate that this discussion > isn't a exercise in bikeshed, but based on technical facts. It would be nice (for the sake of this discussion not getting heated) if Rob could show that he's been

[PATCH 02/12] drm/etnaviv: add devicetree bindings

2015-12-05 Thread Russell King - ARM Linux
On Sat, Dec 05, 2015 at 12:26:19PM +0100, Lucas Stach wrote: > I already sketched up the alternative of having the master driver scan > the DT for matching GPU nodes at probe time and binding them together > into a single device. But given that we end up with one master device > anyways, do you

[PATCH 02/12] drm/etnaviv: add devicetree bindings

2015-12-05 Thread Russell King - ARM Linux
On Sat, Dec 05, 2015 at 04:35:11PM +0100, Daniel Vetter wrote: > In theory dma-buf could keep track of who's flushed a buffer already, but > there's no implementation of that yet. And for a generic one we'd need to > violate the current dma api abstractions. So yeah, perf is going to tank > until

[PATCH 12/12] ARM: dts: imx6: add Vivante GPU nodes

2015-12-07 Thread Russell King - ARM Linux
On Fri, Dec 04, 2015 at 03:00:04PM +0100, Lucas Stach wrote: > This adds the device nodes for 2D, 3D and VG GPU cores. > > Signed-off-by: Russell King <rmk+kernel at arm.linux.org.uk> > Signed-off-by: Lucas Stach This should have been copied to the arm-soc people, as we'

[PATCH 0/4] Component helper updates

2015-12-07 Thread Russell King - ARM Linux
Given the lack of interest in these patches, I've put these into my "for-next" branch so that they can get some exposure in linux-next. On Mon, Nov 23, 2015 at 04:02:11PM +0000, Russell King - ARM Linux wrote: > Greg, > > These four patches update the component helper by: >

[PATCH 5/5] drm/tda998x: Remove dummy save/restore funcs

2015-12-08 Thread Russell King - ARM Linux
On Tue, Dec 08, 2015 at 11:11:01AM +0100, Daniel Vetter wrote: > On Tue, Dec 08, 2015 at 09:30:48AM +, Emil Velikov wrote: > > On 8 December 2015 at 08:49, Daniel Vetter > > wrote: > > > In my quest to remove all the drm_encoder_helper_funcs->save/restore > > > hooks I somehow missed that

-next trees and my time this cycle

2015-12-11 Thread Russell King - ARM Linux
On Fri, Dec 11, 2015 at 04:58:08PM +1000, Dave Airlie wrote: > I've seen etnaviv, rockchip(?), vc4 gpu api, can I get plans for if > people would like these in now, also anything I've missed on the list. I would definitely like to see etnaviv make it in for the next merge window, but that depends

-next trees and my time this cycle

2015-12-11 Thread Russell King - ARM Linux
On Fri, Dec 11, 2015 at 05:15:40PM +0100, Daniel Vetter wrote: > On Fri, Dec 11, 2015 at 10:02:45AM +0000, Russell King - ARM Linux wrote: > > On Fri, Dec 11, 2015 at 04:58:08PM +1000, Dave Airlie wrote: > > > I've seen etnaviv, rockchip(?), vc4 gpu api, can I get plans for if

[PATCH v2 0/2] Improve drm_of_component_probe() and move rockchip to use it

2015-12-23 Thread Russell King - ARM Linux
On Wed, Dec 23, 2015 at 06:20:33PM +0100, Jean-Francois Moine wrote: > On Wed, 23 Dec 2015 10:05:34 + > Liviu Dudau wrote: > > > > What was the reason to keep the "ports" node instead of the device? > > > > The function is an extract of common code sprinkled through a few DRM > > drivers,

[PATCH v2 0/2] Improve drm_of_component_probe() and move rockchip to use it

2015-12-24 Thread Russell King - ARM Linux
On Thu, Dec 24, 2015 at 09:15:28AM +0100, Jean-Francois Moine wrote: > On Wed, 23 Dec 2015 18:59:48 + > Russell King - ARM Linux wrote: > > > > > Have a look at my v2 where I've introduced two compare functions and > > > > also > > > > mod

[PATCH v2 0/2] Improve drm_of_component_probe() and move rockchip to use it

2015-12-24 Thread Russell King - ARM Linux
On Thu, Dec 24, 2015 at 01:27:08PM +0100, Jean-Francois Moine wrote: > On Thu, 24 Dec 2015 10:52:07 + > Russell King - ARM Linux wrote: > > However, when we come to the Linux implementation, things get sticky > > because we need to select the correct platform de

[PATCH v2 08/12] drm: bridge/dw_hdmi: add audio config interfaces

2015-02-02 Thread Russell King - ARM Linux
On Mon, Feb 02, 2015 at 12:02:50PM +0800, Daniel Kurtz wrote: > Hi ykk, > > On Sat, Jan 31, 2015 at 10:34 PM, Yang Kuankuan wrote: > > > > On 01/31/2015 06:48 AM, Russell King - ARM Linux wrote: > >> > >>> +void hdmi_audio_clk_enable(struct dw_h

[PATCH v2 08/12] drm: bridge/dw_hdmi: add audio config interfaces

2015-02-02 Thread Russell King - ARM Linux
On Mon, Feb 02, 2015 at 07:32:05AM -0500, Yang Kuankuan wrote: > On 02/02/2015 06:53 AM, Russell King - ARM Linux wrote: > >On Mon, Feb 02, 2015 at 12:02:50PM +0800, Daniel Kurtz wrote: > >>Hi ykk, > >> > >>On Sat, Jan 31, 2015 at 10:34 PM, Yang Kuankuan &g

<    9   10   11   12   13   14   15   16   17   18   >