[PATCH] drm/i915: drop various VLAs in i915_debugfs.c

2018-03-14 Thread Salvatore Mesoraca
code. [1] https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Salvatore Mesoraca <s.mesorac...@gmail.com> --- drivers/gpu/drm/i915/i915_debugfs.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/dr

Re: [PATCH] drm/i915: drop various VLAs in i915_debugfs.c

2018-03-15 Thread Salvatore Mesoraca
2018-03-14 13:17 GMT+01:00 Jani Nikula : > Thanks for your patch. However, Chris beat you to it with: > > 7aa0b14ede64 ("drm/i915: Remove variable length arrays from sseu debugfs > printers") I didn't notice it :) > as well as adding -Wvla to our subdir-ccflags-y to

Re: [PATCH] drm/i915: drop various VLAs in i915_debugfs.c

2018-03-15 Thread Salvatore Mesoraca
2018-03-14 13:27 GMT+01:00 Joonas Lahtinen : > CHV_SS_MAX should be good enough. Make these function scoped (so #define > at the beginning and #undef at the end of function). > > Do use ARRAY_SIZE() instead of repeating. Thank you very much for your suggestions.