issing comma to drm_of_get_data_lanes_count_ep() .
>
> Fixes: fc801750b197 ("drm: of: Add drm_of_get_data_lanes_count and
> drm_of_get_data_lanes_ep")
> Reported-by: kernel test robot
> Signed-off-by: Marek Vasut
> Cc: Andrzej Hajda
> Cc: Laurent Pinchart
> Cc: Lucas Stach
> Cc: Max
> Cc: Lucas Stach
> Cc: Maxime Ripard
> Cc: Robert Foss
> Cc: Sam Ravnborg
> To: dri-devel@lists.freedesktop.org
Looks fine.
I wondered why the _ep variant could not be used, but endpoint is
required later and there is no need to look it up twice.
Acked-by: Sam Ravnborg
S
zej Hajda
> Cc: Laurent Pinchart
> Cc: Lucas Stach
> Cc: Maxime Ripard
> Cc: Robert Foss
> Cc: Sam Ravnborg
Looks OK,
Acked-by: Sam Ravnborg
On Sat, Jun 11, 2022 at 09:55:04AM -0700, Douglas Anderson wrote:
> Two blank lines are needed to make the rst valid.
>
> Fixes: 69ef4a192bba ("drm: Document the power requirements for DP AUX
> transfers")
> Reported-by: Stephen Rothwell
> Signed-off-by: Douglas Ande
Hi Rob,
On Fri, Jun 10, 2022 at 02:38:18PM -0600, Rob Herring wrote:
> 'arm,rtsm-display' is a panel for Arm, Ltd. virtual platforms (e.g. FVP).
> The binding has been in use for a long time, but was never documented.
>
> Some users and an example have a 'panel-dpi' compatible, but that's not
>
On Fri, Jun 10, 2022 at 10:43:06PM +0200, Stephen Kitt wrote:
> Hi Sam,
>
> On Fri, 10 Jun 2022 22:22:59 +0200, Sam Ravnborg wrote:
> > On Tue, Jun 07, 2022 at 08:55:16PM +0200, Stephen Kitt wrote:
> > > backlight_properties.fb_blank is deprecated. The states it repr
nd insulates this from future changes.
>
> Signed-off-by: Stephen Kitt
> Cc: Paul Mackerras
> Cc: Helge Deller
> Cc: linux-fb...@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
This and the other 6 patches in this series are all:
Reviewed-by: Sam Ravnborg
I did not r
Hi Stephen,
On Tue, Jun 07, 2022 at 08:55:16PM +0200, Stephen Kitt wrote:
> backlight_properties.fb_blank is deprecated. The states it represents
> are handled by other properties; but instead of accessing those
> properties directly, drivers should use the helpers provided by
> backlight.h.
>
>
Hi Stephen,
> > > >
> > > > Thanks, I’ll wait a little more to see if there are any other reviews of
> > > > the patches and then push a v2 with that fix.
> > > It would be very nice if you could kill all uses of FB_BLANK in the
> > > drivers/gpu/drm/panel/* drivers, and post them as one
Hi Stephen.
On Fri, Jun 10, 2022 at 07:47:20PM +0200, Stephen Kitt wrote:
> Hi Sebastian,
>
> On Thu, 9 Jun 2022 23:52:36 +0200, Sebastian Reichel
> wrote:
> > On Tue, Jun 07, 2022 at 08:20:25PM +0200, Stephen Kitt wrote:
> > > diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c
> > >
t; Cc: linux-fb...@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-arm-ker...@lists.infradead.org
Acked-by: Sam Ravnborg
Sam
Hi Stephen,
thanks for taking care of all these backlight simplifications - this
really helps to make the code simpler and more readable.
On Thu, Jun 09, 2022 at 10:54:12AM +0100, Daniel Thompson wrote:
> On Wed, Jun 08, 2022 at 10:56:23PM +0200, Stephen Kitt wrote:
> > Instead of checking the
Hi Javier.
On Thu, Jun 09, 2022 at 03:09:21PM +0200, Javier Martinez Canillas wrote:
> Hello Thomas,
>
> On 6/9/22 13:49, Thomas Zimmermann wrote:
> > Hi Javier
> >
> > Am 07.06.22 um 20:23 schrieb Javier Martinez Canillas:
> >> From: Daniel Vetter
> >>
> >> Well except when the olpc dcon
Hi Hans,
> > Please move this up so it is together with the other get_* methods, in
> > alphabetic order. That is, right after get_modes(), and then this also
> > matches the order in the .c file with is extra bonus.
>
> The downside of moving this up is that it will break drivers which don't
>
Hi Hsin-Yi,
On Mon, Jun 06, 2022 at 11:24:31PM +0800, Hsin-Yi Wang wrote:
> Panel orientation property should be set before drm_dev_register().
> Mediatek drm driver calls drm_dev_register() in .bind(). However, most
> panels sets orientation property relatively late, mostly in .get_modes()
>
Hi Hsin-Yi,
thanks for this nice series.
On Mon, Jun 06, 2022 at 11:24:23PM +0800, Hsin-Yi Wang wrote:
> Panels usually call drm_connector_set_panel_orientation(), which is
> later than drm/kms driver calling drm_dev_register(). This leads to a
> WARN()[1].
>
> The orientation property is known
ngs,
> + .get_orientation = panel_simple_get_orientation,
I like the order in this list to match the order in the .h file.
So my OCD would like you to move it up right after get_modes,
but feel free to ignore this.
With the suggested changes:
Reviewed-by: Sam Ravnborg
> };
>
> static struct panel_desc panel_dpi;
> --
> 2.36.1.255.ge46751e96f-goog
entation)(struct drm_panel *panel);
Please move this up so it is together with the other get_* methods, in
alphabetic order. That is, right after get_modes(), and then this also
matches the order in the .c file with is extra bonus.
With the two fixes:
Reviewed-by: Sam Ravnborg
> };
>
arious property schemas which are missing a type. Most of these
> tend to be device specific properties which don't have a vendor prefix.
> A vendor prefix is how we normally ensure a type is defined.
>
> Signed-off-by: Rob Herring
Acked-by: Sam Ravnborg # for everything in
.../bindings/display/
Hi Venkateshwar,
On Thu, May 12, 2022 at 07:23:13PM +0530, Venkateshwar Rao Gannavarapu wrote:
> The Xilinx MIPI DSI Tx Subsystem soft IP is used to display video
> data from AXI-4 stream interface.
>
> It supports upto 4 lanes, optional register interface for the DPHY
> and multiple RGB color
On Wed, May 11, 2022 at 07:34:38PM +0200, Javier Martinez Canillas wrote:
> Hello Guenter,
>
> On 5/11/22 19:17, Guenter Roeck wrote:
> > On 5/11/22 10:00, Sam Ravnborg wrote:
>
> [snip]
>
> >>> struct fb_info *registered_fb[FB_MAX] __read_mostly
ff-by: Joel Selvaraj
Driver looks good:
Reviewed-by: Sam Ravnborg
I expect someone else to pick it up and apply.
Sam
Vetter
> Cc: Helge Deller
> Cc: Matthew Wilcox
> Cc: Sam Ravnborg
> Cc: Tetsuo Handa
> Cc: Zhen Lei
> Cc: Alex Deucher
> Cc: Xiyu Yang
> Cc: linux-fb...@vger.kernel.org
> Cc: Zheyu Ma
> Cc: Guenter Roeck
> Signed-off-by: Javier Martinez Canillas
> ---
d_io_fsync() is not in fbmem.o, the helper has to be
> exported. Rename it and add a fb_ prefix to denote that is public now.
>
> Reported-by: Junxiao Chang
> Signed-off-by: Javier Martinez Canillas
Acked-by: Sam Ravnborg
Hi Javier,
On Tue, May 03, 2022 at 06:46:16PM +0200, Javier Martinez Canillas wrote:
> A reference to the framebuffer device struct fb_info is stored in the file
> private data, but this reference could no longer be valid and must not be
> accessed directly. Instead, the file_fb_info() accessor
Hi Thomas,
> > > +
> > > /* this is to find and return the vmalloc-ed fb pages */
> > > static vm_fault_t fb_deferred_io_fault(struct vm_fault *vmf)
> > > {
> > > @@ -59,7 +113,7 @@ static vm_fault_t fb_deferred_io_fault(struct vm_fault
> > > *vmf)
> > > printk(KERN_ERR
Hi Thomas.
On Mon, Apr 25, 2022 at 01:27:51PM +0200, Thomas Zimmermann wrote:
> Refactor the page-write handler for deferred I/O. Drivers use the
> function to let fbdev track written pages of mmap'ed framebuffer
> memory.
I like how the comments got a brush up and a little more info was added.
Hi Thomas,
a little ramblings below. Just my thoughts while trying to understand
the code - especially since I looked at it before.
Sam
On Mon, Apr 25, 2022 at 01:27:50PM +0200, Thomas Zimmermann wrote:
> Store the per-page state for fbdev's deferred I/O in struct
>
Hi Thomas,
On Mon, Apr 25, 2022 at 07:26:32PM +0200, Sam Ravnborg wrote:
> Hi Thomas,
>
> > diff --git a/drivers/video/fbdev/core/fb_defio.c
> > b/drivers/video/fbdev/core/fb_defio.c
> > index 6aaf6d0abf39..6924d489a289 100644
> > --- a/drivers/video/fbdev/cor
Hi Thomas,
> diff --git a/drivers/video/fbdev/core/fb_defio.c
> b/drivers/video/fbdev/core/fb_defio.c
> index 6aaf6d0abf39..6924d489a289 100644
> --- a/drivers/video/fbdev/core/fb_defio.c
> +++ b/drivers/video/fbdev/core/fb_defio.c
> @@ -181,6 +181,7 @@ int fb_deferred_io_mmap(struct fb_info
> Signed-off-by: Marek Vasut
> Cc: Christoph Fritz
> Cc: Laurent Pinchart
> Cc: Maxime Ripard
> Cc: Sam Ravnborg
> Cc: Thomas Zimmermann
Acked-by: Sam Ravnborg
> ---
> drivers/gpu/drm/panel/panel-simple.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --
ld it be static?
>
> These variables are only used in fbcon.c. Single file use variables should
> be static, so change their storage-class specifiers to static.
>
> Signed-off-by: Tom Rix
Acked-by: Sam Ravnborg
> ---
> drivers/video/fbdev/core/fbcon.c | 4 ++--
> 1 file changed, 2
t; Cc: Lucas Stach
> Cc: Peng Fan
> Cc: Robby Cai
> Cc: Sam Ravnborg
> Cc: Stefan Agner
Acked-by: Sam Ravnborg
On Fri, Apr 22, 2022 at 03:36:14PM -0300, Fabio Estevam wrote:
> From: Heiko Schocher
>
> Add Startek KD070WVFPA043-C069A 7" TFT LCD panel support.
>
> Signed-off-by: Heiko Schocher
> Signed-off-by: Fabio Estevam
Acked-by: Sam Ravnborg
h
> Signed-off-by: Marek Vasut
> Cc: Alexander Stein
> Cc: Laurent Pinchart
> Cc: Lucas Stach
> Cc: Peng Fan
> Cc: Robby Cai
> Cc: Sam Ravnborg
> Cc: Stefan Agner
Acked-by: Sam Ravnborg
aurent Pinchart
> Cc: Lucas Stach
> Cc: Peng Fan
> Cc: Robby Cai
> Cc: Sam Ravnborg
> Cc: Stefan Agner
Acked-by: Sam Ravnborg
Fan
> Cc: Robby Cai
> Cc: Sam Ravnborg
> Cc: Stefan Agner
Acked-by: Sam Ravnborg
> Cc: Laurent Pinchart
> Cc: Lucas Stach
> Cc: Maxime Ripard
> Cc: Peng Fan
> Cc: Robby Cai
> Cc: Robert Foss
> Cc: Sam Ravnborg
> Cc: Thomas Zimmermann
> To: dri-devel@lists.freedesktop.org
Good to see a bridge driver that stays away from the deprecated stuff,
and
On Tue, Apr 19, 2022 at 09:56:24PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam
>
> Add Startek KD070WVFPA043-C069A 7" TFT LCD panel compatible string.
>
> Signed-off-by: Fabio Estevam
Acked-by: Sam Ravnborg
> ---
> .../devicetree/bindings/display/panel/pan
On Fri, Apr 22, 2022 at 12:22:42PM +0200, Marek Vasut wrote:
> Add DataImage FG040346DSSWBG04 4.3" 480x272 TFT LCD 24bit DPI panel
> support.
>
> Acked-by: Thomas Zimmermann
> Signed-off-by: Marek Vasut
> Cc: Sam Ravnborg
> Cc: Thomas Zimmermann
> To: dri-deve
On Fri, Apr 22, 2022 at 12:22:41PM +0200, Marek Vasut wrote:
> Add DataImage FG040346DSSWBG04 4.3" 480x272 TFT LCD 24bit DPI panel
> compatible string.
>
> Acked-by: Thomas Zimmermann
> Signed-off-by: Marek Vasut
> Cc: Rob Herring
> Cc: Sam Ravnborg
> Cc: Tho
erializer as a bridge.
>
> Signed-off-by: Marek Vasut
> Cc: Laurent Pinchart
> Cc: Lucas Stach
> Cc: Maxime Ripard
> Cc: Peng Fan
> Cc: Rob Herring
> Cc: Robby Cai
> Cc: Robert Foss
> Cc: Sam Ravnborg
> Cc: Thomas Zimmermann
> Cc: devicet...@vger.ker
: Laurent Pinchart
> Cc: Lucas Stach
> Cc: Maxime Ripard
> Cc: Peng Fan
> Cc: Rob Herring
> Cc: Robby Cai
> Cc: Robert Foss
> Cc: Sam Ravnborg
> Cc: Thomas Zimmermann
> Cc: devicet...@vger.kernel.org
> To: dri-devel@lists.freedesktop.org
Acked-by: Sam Ravnbo
On Tue, Apr 19, 2022 at 09:56:25PM -0300, Fabio Estevam wrote:
> From: Heiko Schocher
>
> Add Startek KD070WVFPA043-C069A 7" TFT LCD panel support.
>
> Signed-off-by: Heiko Schocher
> Signed-off-by: Fabio Estevam
> ---
> drivers/gpu/drm/panel/panel-simple.c | 33
drm/panel: Add panel driver for NewVision NV3052C based
> LCDs")
> Cc: Christophe Branchereau
> Cc: kbuild-all
> Cc: Stephen Rothwell
> Reported-by: kernel test robot
> Signed-off-by: Paul Cercueil
Acked-by: Sam Ravnborg
> ---
> drivers/gpu/drm/panel/panel-newvision-
Herring
Looks good,
Reviewed-by: Sam Ravnborg
Let me know if we shall take it in drm-misc.
Sam
en .prepare and .enable, if
> > > > it exists.
> > > >
> > > > Add it so the backlight is only enabled after the crtc is, to avoid
> > > > graphical issues.
> > > >
> > > > Signed-off-by: Christophe Branchereau
> > >
> > > Didn't Sam acked it?
No, that was the new driver, already replied.
For these changes - with the updated changelog:
Acked-by: Sam Ravnborg
ndheld console.
>
> Signed-off-by: Christophe Branchereau
Please add:
Reviewed-by: Sam Ravnborg
from the previous review round.
Sam
Hi Christophe,
> > > + { 0x0d, 0x58 },
> > > + { 0x0e, 0x48 },
> > > + { 0x0f, 0x38 },
> > > + { 0x10, 0x2b },
> > > +
> > > + { 0xff, 0x30 },
> > > + { 0xff, 0x52 },
> > > + { 0xff, 0x00 },
> > > + { 0x36, 0x0a },
> > > +};
> > There are some random (?) empty
Hi Patrik,
On Thu, Mar 17, 2022 at 10:25:52AM +0100, Patrik Jakobsson wrote:
> Most of these are old leftovers from one of the driver merges. This is
> all dead code.
Nice cleanups.
For all four patches:
Acked-by: Sam Ravnborg
> PTR_ERR to return the actual errno.
>
> Fixes: 623a3531e9cf ("drm/panel: Add driver for Novatek NT35950 DSI DriverIC
> panels")
> Signed-off-by: Lu Wei
Acked-by: Sam Ravnborg
el: Select DRM_DP_HELPER for DRM_PANEL_EDP")
> Reported-by: kernel test robot
> Cc: Thomas Zimmermann
> Cc: Naresh Kamboju
> Cc: Linux Kernel Functional Testing
> Cc: Lyude Paul
> Cc: Sam Ravnborg
> Cc: Daniel Vetter
> Cc: Maarten Lankhorst
> Cc: Maxime Ripard
> Cc: dri-devel@lists.freedesktop.org
> Cc: Dave Airlie
> Cc: Thierry Reding
Acked-by: Sam Ravnborg
onsole.
I had to get away from my day-time job and you were the lucky winner.
A couple of comments in the following that you can address now or later.
>
> Signed-off-by: Christophe Branchereau
Reviewed-by: Sam Ravnborg
> ---
> drivers/gpu/drm/panel/Kconfig | 9
Hi Xin.
On Fri, Mar 11, 2022 at 06:35:25PM +0800, Xin Ji wrote:
> The property length which returns from "of_get_property", it means array
> bytes count if the property has prefix as "/bits/ 8". The driver should
> call function "of_property_read_u8_array" to get correct array value.
>
> Fixes:
Hi Xin,
On Thu, Mar 10, 2022 at 05:16:53PM +0800, Xin Ji wrote:
> The property length which returns from "of_get_property", divided by
> sizeof(int) to get the total property counts.
>
> Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
>
> Signed-off-by: Xin Ji
> ---
>
Hi Thomas,
One comment below.
On Sun, Mar 06, 2022 at 09:36:15PM +0100, Thomas Zimmermann wrote:
> The current implementation of psb_gtt_init() also does resume
> handling. Move the resume code into its own helper.
>
> Signed-off-by: Thomas Zimmermann
> ---
> drivers/gpu/drm/gma500/gtt.c
Hi Rob,
> > > diff --git a/include/drm/drm_gem.h b/include/drm/drm_gem.h
> > > index 35e7f44c2a75..987e78b18244 100644
> > > --- a/include/drm/drm_gem.h
> > > +++ b/include/drm/drm_gem.h
> > > @@ -327,7 +327,7 @@ struct drm_gem_object {
> > > * non-static version of this you're probably doing
DPI spec has optional support for DPI where the controller is
> configured over DBI. Rework the command functions so they can be moved
> to drm_mipi_dbi and shared with a future panel-mipi-dpi-spi driver
>
> v2:
> - Drop model property and use compatible instead (Rob)
> - Add wiki entry in MAINTAINERS
>
> Acked-by: Maxime Ripard
> Signed-off-by: Noralf Trønnes
Looks good.
Reviewed-by: Sam Ravnborg
On Thu, Feb 24, 2022 at 04:27:06PM +0100, Noralf Trønnes wrote:
> Add a function to get a drm_display_mode from a panel-timing
> device tree subnode.
Thanks for implementing this!
>
> Suggested-by: Sam Ravnborg
> Signed-off-by: Noralf Trønnes
Reviewed-by: Sam Ravnborg
On Thu, Feb 24, 2022 at 04:27:05PM +0100, Noralf Trønnes wrote:
> Remove trailing whitespace from a comment.
>
> Signed-off-by: Noralf Trønnes
Acked-by: Sam Ravnborg
> ---
> drivers/gpu/drm/drm_modes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff
Hi Javier,
On Thu, Feb 24, 2022 at 10:02:59AM +0100, Javier Martinez Canillas wrote:
> Hello Sam,
>
> On 2/23/22 21:25, Sam Ravnborg wrote:
>
> [snip]
>
> >
> > Question: What is cfb an abbreviation for anyway?
> > Not related to the patch - but if I have kn
require architecture specific helpers (e.g., storel()
> +storeq()).
> +
> +Contact: Thomas Zimmermann
> +
> +Level: Intermediate
With the small fixes above:
Acked-by: Sam Ravnborg
Another option would be to re-implement imageblit() to be drm specific.
Maybe we can then th
cycles
>
> In the optimized case, cfb_imageblit() is now ~2x faster than before.
>
> v3:
> * fix commit description (Pekka)
>
> Signed-off-by: Thomas Zimmermann
Acked-by: Sam Ravnborg
The code looks equally complicated now in the sys and cfb variants.
Questio
On Wed, Feb 23, 2022 at 08:38:02PM +0100, Thomas Zimmermann wrote:
> Fix coding style. No functional changes.
>
> Signed-off-by: Thomas Zimmermann
Acked-by: Sam Ravnborg
Hi José,
On Sun, Feb 20, 2022 at 08:52:12PM +0100, José Expósito wrote:
> Use the "drm_of_find_panel_or_bridge" function instead of a custom
> version of it to reduce the boilerplate.
Thanks for looking into this.
>From the documentation of drm_of_find_panel_or_bridge():
* This function is
Hi Noralf,
On Sun, Feb 20, 2022 at 04:59:34PM +0100, Noralf Trønnes wrote:
>
>
> Den 19.02.2022 23.10, skrev Sam Ravnborg:
> > Hi Noralf,
> > On Fri, Feb 18, 2022 at 04:11:10PM +0100, Noralf Trønnes wrote:
> >> Add a driver that will work with most
Hi Noralf,
> >>mode->flags) {
> >>dev_err(dev, "%pOF: panel-timing out of bounds\n",
> >> dev->of_node);
> >>return -EINVAL;
> >>}
> > With the display_timing => drm_display_mode I think the above is no
> > longer required.
> >
>
> I still need to verify the
Hi Noralf.
On Sun, Feb 20, 2022 at 07:11:14PM +0100, Noralf Trønnes wrote:
> > Den 20.02.2022 11.04, skrev Sam Ravnborg:
> > > Hi Noralf,
> > >
> > >>> +static int panel_mipi_dbi_get_mode(struct mipi_dbi_dev *dbidev,
> struct drm_display_mode *mode)
>
Hi Noralf,
> > +static int panel_mipi_dbi_get_mode(struct mipi_dbi_dev *dbidev, struct
> > drm_display_mode *mode)
> > +{
> > + struct device *dev = dbidev->drm.dev;
> > + u32 width_mm = 0, height_mm = 0;
> > + struct display_timing timing;
> > + struct videomode vm;
> > + int ret;
> >
Hi Noralf,
On Fri, Feb 18, 2022 at 04:11:10PM +0100, Noralf Trønnes wrote:
> Add a driver that will work with most MIPI DBI compatible SPI panels.
> This avoids adding a driver for every new MIPI DBI compatible controller
> that is to be used by Linux. The 'compatible' Device Tree property with
>
for
> its additional state.
>
> v3:
> - Add documentation
>
> Acked-by: Maxime Ripard
> Signed-off-by: Noralf Trønnes
Acked-by: Sam Ravnborg
ral-props.yaml#
> +
> +properties:
> + compatible:
> +items:
> + - {} # Panel Specific Compatible
> + - const: panel-mipi-dbi-spi
> +
> + write-only:
> +type: boolean
> + description:
> + Controller is not readable (ie. MISO is not wired up).
It would be easier to understand if this comment refers to one of the
pins on the display described above. So maybe something like
(ie. Din (MSIO on the SPI interface) is not wired up).
With the comment updated to include a reference to Din,
Acked-by: Sam Ravnborg
Hi Linus,
On Mon, Jan 03, 2022 at 12:38:22PM +0100, Linus Walleij wrote:
> Add some code and config to also support the ACX424AKM used in
> some Sony (Ericsson) Mobile phones.
>
> Signed-off-by: Linus Walleij
Acked-by: Sam Ravnborg
d ID looks like a bug, vendor IDs begin at 0x80
> * and panel 00 ... seems like default values.
> */
This comment needs adjustment s/third/fourth/
With the comment fixed:
Acked-by: Sam Ravnborg
> -#define DISPLAY_SONY_ACX424AKP_ID3 0x8000
> +#define DISPLAY_SONY_ACX424AKP_ID4 0x8
ver to cover any other panels also using
> the Novatek NT35560 display controller.
>
> Signed-off-by: Linus Walleij
Acked-by: Sam Ravnborg
Hi Linus,
On Sat, Feb 19, 2022 at 02:40:33AM +0100, Linus Walleij wrote:
> On Sat, Jan 29, 2022 at 2:26 AM Linus Walleij
> wrote:
> > On Mon, Jan 3, 2022 at 12:40 PM Linus Walleij
> > wrote:
> >
> > > A code drop from Sony Mobile reveals that the ACX424 panels are
> > > built around the
n dev, oldmode;
> identifier newmode;
> @@
> - newmode = drm_mode_create(dev);
> + newmode = drm_mode_duplicate(dev, oldmode);
> ...
> - drm_mode_copy(newmode, oldmode);
>
> Signed-off-by: Ville Syrjälä
> Cc: Thierry Reding
> Cc: Sam Ravnborg
Looks good,
Acked-by: Sam Ravnborg
mance gain from this.
The actual implementation looks good.
So with or without the extra un-rolling the patch is:
Acked-by: Sam Ravnborg
One small nit belwo.
Sam
>
> A microbenchmark measures the average number of CPU cycles
> for sys_imageblit() after a stabilizing period of
the CFB implementation.
>
> Signed-off-by: Thomas Zimmermann
Nice optimization.
Reviewed-by: Sam Ravnborg
> ---
> drivers/video/fbdev/core/sysfillrect.c | 16 +++-
> 1 file changed, 3 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/video/fbde
Hi Geert,
On Tue, Feb 15, 2022 at 05:52:18PM +0100, Geert Uytterhoeven wrote:
> Hi all,
>
> A long outstanding issue with the DRM subsystem has been the lack of
> support for low-color displays, as used typically on older desktop
> systems and small embedded displays.
This is one of the
Hi Geert,
>
> C1 is color-indexed, which can be any two colors.
> R1 is light-on-dark.
> D1 is dark-on-light.
It would be nice to have this explained in the fourcc.h file,
preferably with a little more verbosity than the current explanations.
Sam
Hi Geert,
> > > + switch (fb->format->depth) {
> >
> > The depth field is deprecated. It's probably better to use
> > fb->format->format and test against 4CC codes.
>
> The reason I checked for depth instead of a 4CC code is that the only
> thing that matters here is the number of bits per
On Wed, Feb 16, 2022 at 09:41:36AM +0100, Geert Uytterhoeven wrote:
> Fix various grammar mistakes in the kerneldoc comments documenting the
> drm_mode_fb_cmd2 structure:
> - s/is/are/,
> - s/8 bit/8-bit/.
>
> Signed-off-by: Geert Uytterhoeven
Acked-by: Sam Ravnborg
/it/its/.
>
> Signed-off-by: Geert Uytterhoeven
Acked-by: Sam Ravnborg
It would be great if you could get drm-misc commiter rights, then you
can push this and all your other nice patches yourself.
Especially since you are soon becoming a drm driver maintainer
Sam
Hi Laurent,
On Tue, Feb 08, 2022 at 02:30:42AM +0200, Laurent Pinchart wrote:
> Hi Sam,
>
> Thank you for the patch.
>
> On Sun, Feb 06, 2022 at 04:43:57PM +0100, Sam Ravnborg wrote:
> > The DRM_BRIDGE_STATE_OPS can be used as shortcut for bridge drivers tha
shedding - my personal style is to have the likely part first.
This makes reading the code easier.
The following drivers uses deferred io but are not listed as
they need the page list sorted:
- hecubafb
- hyperv_fb
- sh_mobile_lcdcfb
- smscufx
- ssd1307fb
- xen-fbfront
It would be nice with
if (cur->index > page->index)
> break;
> }
>
> @@ -194,7 +197,7 @@ static void fb_deferred_io_work(struct work_struct *work)
>
> /* clear the list */
> list_for_each_safe(node, next, >pagelist) {
> - list_del(node);
> + list_del_init(node);
> }
> mutex_unlock(>lock);
> }
With the comment adjusted as you see fit
Acked-by: Sam Ravnborg
On Wed, Feb 09, 2022 at 08:48:10AM +, cgel@gmail.com wrote:
> From: Changcheng Deng
>
> Use min() in order to make code cleaner.
>
> Reported-by: Zeal Robot
> Signed-off-by: Changcheng Deng
Reviewed-by: Sam Ravnborg
I had preferred in minmax.h was included, but
Hi Douglas,
On Mon, Feb 07, 2022 at 02:34:34PM -0800, Doug Anderson wrote:
> Hi,
>
> On Sun, Feb 6, 2022 at 7:44 AM Sam Ravnborg wrote:
> >
> > From: Rob Clark
> >
> > Slightly awkward to fish out the display_info when we aren't creating
> > own connec
On Mon, Feb 07, 2022 at 02:34:10PM -0800, Doug Anderson wrote:
> Hi,
>
> On Sun, Feb 6, 2022 at 7:44 AM Sam Ravnborg wrote:
> >
> > To prepare for DRM_BRIDGE_ATTACH_NO_CONNECTOR support,
> > fix so the bpc is found using the output format.
> >
> > This
On Tue, Feb 08, 2022 at 02:44:25AM +0200, Laurent Pinchart wrote:
> Hello,
>
> On Mon, Feb 07, 2022 at 02:32:45PM -0800, Doug Anderson wrote:
> > On Sun, Feb 6, 2022 at 7:44 AM Sam Ravnborg wrote:
> > >
> > > There is a number of bridge drivers that support
ton
> Cc: Greg Kroah-Hartman
> Cc: linux-stag...@lists.linux.dev
> Signed-off-by: Daniel Vetter
> Cc: Daniel Vetter
> Cc: Helge Deller
> Cc: Matthew Wilcox
> Cc: Sam Ravnborg
> Cc: Tetsuo Handa
> Cc: Zhen Lei
> Cc: Alex Deucher
> Cc: Xiyu Yang
> Cc: linux-
Hi Daniel,
On Tue, Feb 08, 2022 at 03:03:28PM +0100, Daniel Vetter wrote:
> On Fri, Feb 04, 2022 at 09:15:40PM +0100, Sam Ravnborg wrote:
> > Hi Daniel,
> >
> > On Mon, Jan 31, 2022 at 10:05:50PM +0100, Daniel Vetter wrote:
> > > Accessing the one in fbmem.c
On Tue, Feb 08, 2022 at 02:58:21PM +0100, Daniel Vetter wrote:
> On Fri, Feb 04, 2022 at 09:06:38PM +0100, Sam Ravnborg wrote:
> > Hi Daniel,
> >
> > On Mon, Jan 31, 2022 at 10:05:49PM +0100, Daniel Vetter wrote:
> > > There's a bunch of confusions going on here:
&g
On Tue, Feb 08, 2022 at 02:53:59PM +0100, Daniel Vetter wrote:
> On Fri, Feb 04, 2022 at 08:35:31PM +0100, Sam Ravnborg wrote:
> > On Mon, Jan 31, 2022 at 10:05:44PM +0100, Daniel Vetter wrote:
> > > No idea why con2fb_acquire_newinfo() initializes much less than
> > &
Hi Daniel,
On Tue, Feb 08, 2022 at 02:48:29PM +0100, Daniel Vetter wrote:
> On Thu, Feb 03, 2022 at 10:15:14PM +0100, Sam Ravnborg wrote:
> > Hi Daniel,
> >
> > On Mon, Jan 31, 2022 at 10:05:42PM +0100, Daniel Vetter wrote:
> > > There's two minor behaviour cha
Hi Daniel,
On Tue, Feb 08, 2022 at 02:46:33PM +0100, Daniel Vetter wrote:
> On Thu, Feb 03, 2022 at 10:31:00PM +0100, Sam Ravnborg wrote:
> > On Mon, Jan 31, 2022 at 10:05:41PM +0100, Daniel Vetter wrote:
> > > It was only used by fbcon, and that now switched to its own,
Hi Daniel,
On Tue, Feb 08, 2022 at 02:42:25PM +0100, Daniel Vetter wrote:
> On Thu, Feb 03, 2022 at 09:45:29PM +0100, Sam Ravnborg wrote:
> > Hi Daniel,
> >
> > On Mon, Jan 31, 2022 at 10:05:37PM +0100, Daniel Vetter wrote:
> > &
Hi Neail,
On Fri, Feb 04, 2022 at 03:33:37PM +0100, Neil Armstrong wrote:
> When the dw-hdmi bridge is in first place of the bridge chain, this
> means there is no way to select an input format of the dw-hdmi HW
> component.
>
> Since introduction of display-connector, negotiation was broken
Hi Tomohito,
On Fri, Feb 04, 2022 at 11:36:35AM +0900, Tomohito Esaki wrote:
> Remove allow_fb_modifiers setting in this driver. The allow_fb_modifiers
> flag was removed.
>
> Signed-off-by: Tomohito Esaki
> Fixes: 3d082157a242 ("drm: remove allow_fb_modifiers")
> Reported-by: kernel test robot
601 - 700 of 3956 matches
Mail list logo
