Re: [PATCHv2 01/56] ARM: dts: omap: add channel to DSI panels

2020-02-24 Thread Sebastian Reichel
Hi Laurent, On Tue, Feb 25, 2020 at 01:38:21AM +0200, Laurent Pinchart wrote: > Hi Sebastian, > > Thank you for the patch. > > On Tue, Feb 25, 2020 at 12:20:31AM +0100, Sebastian Reichel wrote: > > The standard binding for DSI requires, that the channel number > > of

Re: [PATCHv2 02/56] ARM: dts: omap4-droid4: add panel compatible

2020-02-24 Thread Sebastian Reichel
Hi Laurent, On Tue, Feb 25, 2020 at 01:37:08AM +0200, Laurent Pinchart wrote: > Hi Sebastian, > > Thank you for the patch. Thanks for the review. > On Tue, Feb 25, 2020 at 12:20:32AM +0100, Sebastian Reichel wrote: > > Add Droid 4 specific compatible value in addition to t

Re: [PATCHv2 00/56] drm/omap: Convert DSI code to use drm_mipi_dsi and drm_panel

2020-02-24 Thread Sebastian Reichel
Hi, On Mon, Feb 24, 2020 at 04:10:11PM -0800, Tony Lindgren wrote: > * Sebastian Reichel [200224 23:22]: > > This updates the existing omapdrm DSI code, so that it uses > > common drm_mipi_dsi API and drm_panel. > > > > The patchset has been tested with Droid 4

Re: [PATCH 1/3] drm/omap: Prepare DSS for probing without legacy platform data

2020-02-24 Thread Sebastian Reichel
n > Signed-off-by: Tony Lindgren > --- > > This is needed for dropping DSS platform data that I'll be posting > seprately. If this looks OK, can you guys please test and ack? > > --- Reviewed-by: Sebastian Reichel FWIW, I dropped omapdss-boot-init.c in my patch series upda

[PATCHv2.1 45/56] drm/omap: dsi: Register a drm_bridge

2020-02-26 Thread Sebastian Reichel
In order to integrate with a chain of drm_bridge, the internal DSI output has to expose its operations through the drm_bridge API. Register a bridge at initialisation time to do so and remove the omap_dss_device operations that are now unused. Signed-off-by: Sebastian Reichel --- PATCHv2

[PATCHv2 57/56] dt-bindings: display: panel-dsi-cm: convert to YAML

2020-02-26 Thread Sebastian Reichel
Convert panel-dsi-cm bindings to YAML and add missing properties while at it. Signed-off-by: Sebastian Reichel --- .../bindings/display/panel/panel-dsi-cm.txt | 31 -- .../bindings/display/panel/panel-dsi-cm.yaml | 97 +++ 2 files changed, 97 insertions(+), 31 deletions

Re: [PATCHv2 05/56] drm/omap: dsi: use MIPI_DSI_FMT_* instead of OMAP_DSS_DSI_FMT_*

2020-02-26 Thread Sebastian Reichel
Hi, On Tue, Feb 25, 2020 at 03:58:23PM +0200, Laurent Pinchart wrote: > Hi Sebastian, > > Thank you for the patch. > > On Tue, Feb 25, 2020 at 12:20:35AM +0100, Sebastian Reichel wrote: > > This replaces OMAP specific enum for pixel format with > > common implemen

Re: [PATCHv2 04/56] omap/drm: drop unused dsi.configure_pins

2020-02-26 Thread Sebastian Reichel
Hi Laurent, On Wed, Feb 26, 2020 at 11:36:30PM +0200, Laurent Pinchart wrote: > > > I think you can drop the definition of the omap_dsi_pin_config structure > > > earlier in this file too, as well as the OMAP_DSS_MAX_DSI_PINS macro. > > > With this fixed, > > > > No, the struct is still used by

Re: [PATCHv2 11/56] drm/omap: dsi: simplify write function

2020-02-26 Thread Sebastian Reichel
Hi Laurent, On Tue, Feb 25, 2020 at 05:31:05PM +0200, Laurent Pinchart wrote: > > + if (mipi_dsi_packet_format_is_short(msg->type)) { > > + u16 data = packet.header[1] | (packet.header[2] << 8); > > + r = dsi_vc_send_short(dsi, msg->channel, msg->type, data, 0); > > You use

Re: [PATCHv2 04/56] omap/drm: drop unused dsi.configure_pins

2020-02-26 Thread Sebastian Reichel
Hi Laurent, On Tue, Feb 25, 2020 at 01:42:49AM +0200, Laurent Pinchart wrote: > Hi Sebastian, > > Thank you for the patch. > > On Tue, Feb 25, 2020 at 12:20:34AM +0100, Sebastian Reichel wrote: > > The panel-dsi-cm's ddata->pin_config is always NULL, so this >

Re: [PATCHv2 08/56] drm/omap: panel-dsi-cm: convert to transfer API

2020-02-26 Thread Sebastian Reichel
Hi, On Tue, Feb 25, 2020 at 04:52:21PM +0200, Laurent Pinchart wrote: > Hi Sebastian, > > Thank you for the patch. > > On Tue, Feb 25, 2020 at 12:20:38AM +0100, Sebastian Reichel wrote: > > This converts the panel-dsi-cm driver to use the transfer > > API instea

Re: [PATCHv2 43/56] drm/omap: bind components with drm_device argument

2020-02-26 Thread Sebastian Reichel
Hi, On Tue, Feb 25, 2020 at 12:21:13AM +0100, Sebastian Reichel wrote: > This fixes the omapdrm driver to call component_bind_all() > with drm_device as data argument as recommended in the > DRM component helper usage text. > > After this patch DRM functionality can be imple

Re: [PATCHv2 00/56] drm/omap: Convert DSI code to use drm_mipi_dsi and drm_panel

2020-02-26 Thread Sebastian Reichel
Hi, On Wed, Feb 26, 2020 at 02:28:23PM +0200, Tomi Valkeinen wrote: > On 25/02/2020 01:20, Sebastian Reichel wrote: > > This updates the existing omapdrm DSI code, so that it uses > > common drm_mipi_dsi API and drm_panel. > > > > The patchset has been tested with

Re: [PATCHv2 13/56] drm/omap: dsi: switch dsi_vc_send_long/short to mipi_dsi_msg

2020-02-26 Thread Sebastian Reichel
Hi Laurent, On Tue, Feb 25, 2020 at 06:30:01PM +0200, Laurent Pinchart wrote: > On Tue, Feb 25, 2020 at 12:20:43AM +0100, Sebastian Reichel wrote: > > Simplify the DSI encoder by using mipi_dsi_msg for > > dsi_vc_send_long and dsi_vc_send_short. Further improvements > >

[PATCHv2 42/56] drm/omap: remove global dss_device variable

2020-02-25 Thread Sebastian Reichel
We can simply provide the device to the omapdrm driver via pdata. omapdss_is_initialized() is no longer required (even before this patch), since omapdrm device is only registered after the pointer is initialized. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/dss/base.c| 14

[PATCHv2 36/56] drm/omap: drop omapdss-boot-init

2020-02-25 Thread Sebastian Reichel
The table of compatible values needed to be prefixed with "omapdss," is empty, so all of this code is doing nothing now. Let's drop it. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/dss/Kconfig | 3 - drivers/gpu/drm/omapdrm/dss/Makefile | 2 - .

[PATCHv2 48/56] drm/omap: simplify omap_display_id

2020-02-25 Thread Sebastian Reichel
We no longer need to check for the DSS API, since all encoders, panels and connectors have been converted to the bridge API. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/omap_drv.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm

[PATCHv2 00/56] drm/omap: Convert DSI code to use drm_mipi_dsi and drm_panel

2020-02-25 Thread Sebastian Reichel
suggestion is to merge the first two patches ASAP and backport to stable, since it does not affect old kernels and the change is rather small. RFCv1: https://lore.kernel.org/dri-devel/20191117023946.VjCC3yE08DMx7JIKxNagPoT5et7WTnKGVV6MtOtB9Ro@z/ -- Sebastian Sebastian Reichel (56): ARM: dts

[PATCHv2 46/56] drm/omap: remove legacy DSS device operations

2020-02-25 Thread Sebastian Reichel
All DSS devices have been converted to bridge API, so the device operations are always NULL. This removes the device ops function pointers and all code using it. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/dss/base.c | 66 drivers/gpu/drm/omapdrm

[PATCHv2 20/56] drm/omap: dsi: drop unused get_te()

2020-02-25 Thread Sebastian Reichel
The get_te() callback is not used, so we can drop the custom API. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 13 - drivers/gpu/drm/omapdrm/dss/omapdss.h | 1 - 2 files changed, 14 deletions(-) diff --git a/drivers/gpu/drm

[PATCHv2 13/56] drm/omap: dsi: switch dsi_vc_send_long/short to mipi_dsi_msg

2020-02-25 Thread Sebastian Reichel
Simplify the DSI encoder by using mipi_dsi_msg for dsi_vc_send_long and dsi_vc_send_short. Further improvements require cleaning up the channel allocation code first. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/dss/dsi.c | 92 +++ 1 file changed, 45

[PATCHv2 47/56] drm/omap: remove unused omap_connector

2020-02-25 Thread Sebastian Reichel
Remove unused code. Connectors are now created via drm_bridge_connector_init() and no longer OMAP specific. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/Makefile | 1 - drivers/gpu/drm/omapdrm/omap_connector.c | 128 --- drivers/gpu/drm/omapdrm

[PATCHv2 19/56] drm/omap: dsi: drop unused memory_read()

2020-02-25 Thread Sebastian Reichel
Signed-off-by: Sebastian Reichel --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 93 --- drivers/gpu/drm/omapdrm/dss/omapdss.h | 4 - 2 files changed, 97 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c b/drivers/gpu/drm/omapdrm/displays

[PATCHv2 28/56] drm/omap: dsi: do bus locking in host driver

2020-02-25 Thread Sebastian Reichel
This moves the bus locking into the host driver and unexports the custom API in preparation for drm_panel support. Signed-off-by: Sebastian Reichel --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 46 +-- drivers/gpu/drm/omapdrm/dss/dsi.c | 33

[PATCHv2 02/56] ARM: dts: omap4-droid4: add panel compatible

2020-02-25 Thread Sebastian Reichel
Add Droid 4 specific compatible value in addition to the generic one, so that we have the ability to add panel specific quirks in the future. Signed-off-by: Sebastian Reichel --- arch/arm/boot/dts/motorola-mapphone-common.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCHv2 05/56] drm/omap: dsi: use MIPI_DSI_FMT_* instead of OMAP_DSS_DSI_FMT_*

2020-02-25 Thread Sebastian Reichel
This replaces OMAP specific enum for pixel format with common implementation. Signed-off-by: Sebastian Reichel --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 2 +- drivers/gpu/drm/omapdrm/dss/dsi.c | 49 +++ drivers/gpu/drm/omapdrm/dss/omapdss.h | 10

[PATCHv2 50/56] drm/omap: drop empty omap_encoder helper functions

2020-02-25 Thread Sebastian Reichel
Cleanup empty functions for encoder enable, disable and atomic check. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/omap_encoder.c | 28 -- 1 file changed, 28 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_encoder.c b/drivers/gpu/drm/omapdrm

[PATCHv2 23/56] drm/omap: dsi: use pixel-format and mode from attach

2020-02-25 Thread Sebastian Reichel
In order to reduce the amount of custom functionality, this moves handling of pixel format and DSI mode from set_config() to dsi attach. Signed-off-by: Sebastian Reichel --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 2 -- drivers/gpu/drm/omapdrm/dss/dsi.c | 20

[PATCHv2 26/56] drm/omap: dsi: move TE GPIO handling into core

2020-02-25 Thread Sebastian Reichel
in the same way as the exynos DSI implementation. Signed-off-by: Sebastian Reichel --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 101 + drivers/gpu/drm/omapdrm/dss/dsi.c | 140 -- 2 files changed, 135 insertions(+), 106 deletions(-) diff --git a/drivers

[PATCHv2 17/56] drm/omap: panel-dsi-cm: drop hardcoded VC

2020-02-25 Thread Sebastian Reichel
Use dsi->channel everywhere, which originates from DT. Signed-off-by: Sebastian Reichel --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 20 +++ 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c b/drivers/gpu/

[PATCHv2 34/56] drm/omap: dsi: drop custom panel capability support

2020-02-25 Thread Sebastian Reichel
Due to previous changes the DSI encoder gets the capabilities via DSI client's mode_flags and no longer needs the omapdss specific caps. The core code now checks if the DSI encoder is actually configured into command mode instead of just checking the panel capabilities. Signed-off-by: Sebastian

[PATCHv2 01/56] ARM: dts: omap: add channel to DSI panels

2020-02-25 Thread Sebastian Reichel
The standard binding for DSI requires, that the channel number of the panel is encoded in DT. This adds the channel number in all OMAP3-5 boards, in preparation for using common infrastructure. Signed-off-by: Sebastian Reichel --- .../devicetree/bindings/display/panel/panel-dsi-cm.txt | 4

[PATCHv2 15/56] drm/omap: panel-dsi-cm: use DSI helpers

2020-02-25 Thread Sebastian Reichel
After converting the driver to mipi_dsi_device we can use the generic message helpers to simplify the driver a lot. Signed-off-by: Sebastian Reichel --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 126 +++--- 1 file changed, 18 insertions(+), 108 deletions(-) diff --git

[PATCHv2 49/56] drm/omap: drop unused DSS next pointer

2020-02-25 Thread Sebastian Reichel
Since all encoders and panels are using the bridge API now, we next pointer is no longer useful and can be dropped. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/dss/base.c | 2 +- drivers/gpu/drm/omapdrm/dss/omapdss.h | 1 - drivers/gpu/drm/omapdrm/dss/output.c | 13

[PATCHv2 30/56] drm/dsi: add MIPI_DSI_MODE_ULPS_IDLE

2020-02-25 Thread Sebastian Reichel
the DSI host implementation that the panel allows going into ULPS mode. Signed-off-by: Sebastian Reichel --- include/drm/drm_mipi_dsi.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h index 360e6377e84b..f36f89c14b4a 100644

[PATCHv2 40/56] drm/omap: panel-dsi-cm: fix remove()

2020-02-25 Thread Sebastian Reichel
Do not try to reset the panel after DSI has been detached, since the DSI clocks may have been disabled at this point. The panel will be disabled and unprepared before being removed and a reset will be done when being probed again. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm

[PATCHv2 27/56] drm/omap: dsi: drop custom enable_te() API

2020-02-25 Thread Sebastian Reichel
Instead of using the custon enable_te() API, this automatically enables/disables TE core support when a matching packet is send to the panel. Signed-off-by: Sebastian Reichel --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 3 -- drivers/gpu/drm/omapdrm/dss/dsi.c | 33

[PATCHv2 12/56] drm/omap: dsi: simplify read functions

2020-02-25 Thread Sebastian Reichel
Simplify the read related message handling by using the functionality provided by CONFIG_DRM_MIPI_DSI. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/dss/dsi.c | 109 +- 1 file changed, 33 insertions(+), 76 deletions(-) diff --git a/drivers/gpu/drm

[PATCHv2 54/56] ARM: omap2plus_defconfig: Update for moved DSI command mode panel

2020-02-25 Thread Sebastian Reichel
The DSI command mode panel is no longer specific to OMAP and thus the config option has been renamed slightly. Signed-off-by: Sebastian Reichel --- arch/arm/configs/omap2plus_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/configs/omap2plus_defconfig b

[PATCHv2 44/56] drm/panel: Move OMAP's DSI command mode panel driver

2020-02-25 Thread Sebastian Reichel
The panel driver is no longer using any OMAP specific APIs, so let's move it into the generic panel directory. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/Kconfig| 1 - drivers/gpu/drm/omapdrm/Makefile | 1 - drivers/gpu/drm

[PATCHv2 16/56] drm/omap: dsi: request VC via mipi_dsi_attach

2020-02-25 Thread Sebastian Reichel
Drop custom request_vc/release_vc callbacks by using the generic mipi_dsi_attach/mipi_dsi_detach functions. Signed-off-by: Sebastian Reichel --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 24 +--- drivers/gpu/drm/omapdrm/dss/dsi.c | 61 --- drivers/gpu/drm

[PATCHv2 33/56] drm/omap: dsi: Reverse direction of the DSS device enable/disable operations

2020-02-25 Thread Sebastian Reichel
it further to a standard drm_panel driver. Signed-off-by: Sebastian Reichel --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 75 ++- drivers/gpu/drm/omapdrm/omap_encoder.c| 24 ++ 2 files changed, 46 insertions(+), 53 deletions(-) diff --git a/drivers/gpu/drm/omapdr

[PATCHv2 43/56] drm/omap: bind components with drm_device argument

2020-02-25 Thread Sebastian Reichel
of abstraction. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/dss/dss.c | 27 +-- drivers/gpu/drm/omapdrm/dss/omapdss.h | 3 +++ drivers/gpu/drm/omapdrm/omap_drv.c| 15 +++ 3 files changed, 31 insertions(+), 14 deletions(-) diff --git a/drivers

[PATCHv2 51/56] drm/omap: drop DSS ops_flags

2020-02-25 Thread Sebastian Reichel
The omapdss device's ops_flags field is no longer used and can be dropped. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/dss/omapdss.h | 9 - drivers/gpu/drm/omapdrm/dss/venc.c| 1 - 2 files changed, 10 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h

[PATCHv2 06/56] drm/omap: constify write buffers

2020-02-25 Thread Sebastian Reichel
The write buffers are not modified, so they can be constant. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/dss/dsi.c | 24 drivers/gpu/drm/omapdrm/dss/omapdss.h | 10 +- 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers

[PATCHv2 07/56] drm/omap: dsi: add generic transfer function

2020-02-25 Thread Sebastian Reichel
-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/dss/dsi.c | 52 +++ drivers/gpu/drm/omapdrm/dss/omapdss.h | 3 ++ 2 files changed, 55 insertions(+) diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c index f01e0476296d..84e2eb0b51d7 100644

[PATCHv2 04/56] omap/drm: drop unused dsi.configure_pins

2020-02-25 Thread Sebastian Reichel
The panel-dsi-cm's ddata->pin_config is always NULL, so this callback is never called. Instead the DSI encoder gets the pin configuration directly from DT. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 11 --- drivers/gpu/drm/omapdrm/dss/ds

[PATCHv2 32/56] drm/omap: dsi: move panel refresh function to host

2020-02-25 Thread Sebastian Reichel
This moves the panel refresh/update function from the panel driver into the DSI host driver to prepare for common drm_panel support. Signed-off-by: Sebastian Reichel --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 68 drivers/gpu/drm/omapdrm/dss/dsi.c | 101

[PATCHv2 55/56] drm/panel/panel-dsi-cm: support rotation property

2020-02-25 Thread Sebastian Reichel
Add support for the rotation property described by the common panel bindings. The information is forwarded to userspace using the orientation property. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-dsi-cm.c | 24 +++- 1 file changed, 23 insertions(+), 1

[PATCHv2 09/56] drm/omap: dsi: unexport specific data transfer functions

2020-02-25 Thread Sebastian Reichel
After converting all DSI drivers, unexport the specific transfer functions. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/dss/dsi.c | 12 drivers/gpu/drm/omapdrm/dss/omapdss.h | 20 2 files changed, 32 deletions(-) diff --git a/drivers/gpu

[PATCHv2 10/56] drm/omap: dsi: drop virtual channel logic

2020-02-25 Thread Sebastian Reichel
This drops the virtual channel logic. Afterwards DSI clients request their channel number and get the virtual channel with the same number or -EBUSY if already in use. Signed-off-by: Sebastian Reichel --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 11 ++--- drivers/gpu/drm/omapdrm/dss

[PATCHv2 14/56] drm/omap: dsi: introduce mipi_dsi_host

2020-02-25 Thread Sebastian Reichel
This moves from custom platform driver infrastructure to mipi_dsi_host and mipi_dsi_device. Note, that this is a graduate step and the driver only uses the devices types and transfer function, but not yet the new device binding style or drm_panel. Signed-off-by: Sebastian Reichel --- .../gpu

[PATCHv2 11/56] drm/omap: dsi: simplify write function

2020-02-25 Thread Sebastian Reichel
Simplify the write related messages handling by using the functionality provided by CONFIG_DRM_MIPI_DSI. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/dss/Kconfig | 1 + drivers/gpu/drm/omapdrm/dss/dsi.c | 144 +++- 2 files changed, 33 insertions

[PATCHv2 41/56] drm/omap: dsi: return proper error code from dsi_update_all()

2020-02-25 Thread Sebastian Reichel
Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/dss/dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c index acbfffe83b3e..f629e6b1025b 100644 --- a/drivers/gpu/drm/omapdrm/dss/dsi.c +++ b

[PATCHv2 35/56] drm/omap: dsi: convert to drm_panel

2020-02-25 Thread Sebastian Reichel
This converts the DSI module to expect common drm_panel display drivers instead of dssdev based ones. Signed-off-by: Sebastian Reichel --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 210 +++--- drivers/gpu/drm/omapdrm/dss/dsi.c | 133 +-- .../gpu/drm/omapdrm

[PATCHv2 56/56] ARM: dts: omap4-droid4: add panel orientation

2020-02-25 Thread Sebastian Reichel
Add information about panel orientation, so that the system boots into a properly rotated shell. Signed-off-by: Sebastian Reichel --- arch/arm/boot/dts/motorola-mapphone-common.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/motorola-mapphone-common.dtsi b/arch/arm

[PATCHv2 18/56] drm/omap: panel-dsi-cm: use common MIPI DCS 1.3 defines

2020-02-25 Thread Sebastian Reichel
Drop local definition of common MIPI DCS 1.3 defines. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c b/drivers/gpu/drm/omapdrm

[PATCHv2 08/56] drm/omap: panel-dsi-cm: convert to transfer API

2020-02-25 Thread Sebastian Reichel
This converts the panel-dsi-cm driver to use the transfer API instead of specific functions, so that the specific functions can be unexported and squashed into the generic transfer function. Signed-off-by: Sebastian Reichel --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 133

[PATCHv2 29/56] drm/omap: dsi: untangle ulps ops from enable/disable

2020-02-25 Thread Sebastian Reichel
Create a custom function pointer for ULPS and use it instead of reusing disable/enable functions for ULPS mode switch. This allows us to use the common disable/enable functions pointers for DSI. Signed-off-by: Sebastian Reichel --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 8

[PATCHv2 39/56] drm/omap: panel-dsi-cm: support unbinding

2020-02-25 Thread Sebastian Reichel
Now, that the driver implements the common DRM panel API the unbind no longer needs to be suppressed. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/displays

[PATCHv2 38/56] drm/omap: panel-dsi-cm: use DEVICE_ATTR_RO

2020-02-25 Thread Sebastian Reichel
Use DEVICE_ATTR_RO helper instead of plain DEVICE_ATTR, which makes the code a bit shorter and easier to read. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/omapdrm

[PATCHv2 25/56] drm/omap: dsi: lp/hs switching support for transfer()

2020-02-25 Thread Sebastian Reichel
Integrate low-power / high-speed bus switching into transfer function and drop the omapdrm specific enable_hs() callback. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 6 +++--- drivers/gpu/drm/omapdrm/dss/dsi.c | 13 +++-- drivers

[PATCHv2 22/56] drm/omap: dsi: drop useless sync()

2020-02-25 Thread Sebastian Reichel
The DSI sync() function only locks the bus and then releases it again. Currently the only invocation is directly before update(), which locks the bus anyways. Signed-off-by: Sebastian Reichel --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c| 18 -- drivers/gpu/drm/omapdrm/dss

[PATCHv2 21/56] drm/omap: dsi: drop unused enable_te()

2020-02-25 Thread Sebastian Reichel
enable_te() is not used, so the custom API can be dropped. Signed-off-by: Sebastian Reichel --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 39 --- drivers/gpu/drm/omapdrm/dss/omapdss.h | 2 - 2 files changed, 41 deletions(-) diff --git a/drivers/gpu/drm/omapdrm

[PATCHv2 03/56] Revert "drm/omap: dss: Remove unused omap_dss_device operations"

2020-02-25 Thread Sebastian Reichel
From: Sebastian Reichel This reverts commit 4ff8e98879e6eeae9d125dfcf3b642075d00089d. --- drivers/gpu/drm/omapdrm/dss/base.c | 26 +++ drivers/gpu/drm/omapdrm/dss/omapdss.h | 6 drivers/gpu/drm/omapdrm/omap_encoder.c | 44 +++--- 3 files changed, 71

[PATCHv2 24/56] drm/omap: panel-dsi-cm: use bulk regulator API

2020-02-25 Thread Sebastian Reichel
Use bulk regulator API to simplify the code. This also switches from _optional variant to normal variant, which will provide a dummy regulator (i.e. if some always-enabled regulator is not described in DT). Signed-off-by: Sebastian Reichel --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 65

[PATCHv2 31/56] drm/omap: dsi: do ULPS in host driver

2020-02-25 Thread Sebastian Reichel
Move ULPS handling into the DSI host controller, so that we no longer need a custom API for the DSI client. Signed-off-by: Sebastian Reichel --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 273 +- drivers/gpu/drm/omapdrm/dss/dsi.c | 61 +++- drivers/gpu/drm

[PATCHv2 37/56] drm/omap: dsi: implement check timings

2020-02-25 Thread Sebastian Reichel
Implement check timings, which will check if its possible to configure the clocks for the provided mode using the same code as the set_config() hook. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/dss/dsi.c | 70 +++ 1 file changed, 44 insertions(+), 26

[PATCHv2 45/56] drm/omap: dsi: Register a drm_bridge

2020-02-25 Thread Sebastian Reichel
In order to integrate with a chain of drm_bridge, the internal DSI output has to expose its operations through the drm_bridge API. Register a bridge at initialisation time to do so and remove the omap_dss_device operations that are now unused. Signed-off-by: Sebastian Reichel --- drivers/gpu

[PATCHv2 53/56] drm/omap: simplify DSI manual update code

2020-02-25 Thread Sebastian Reichel
Move dsi_ops into the main structure, since all other ops are gone. Instead of checking the device type we can simply check if dsi_ops are set. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/dss/dsi.c | 10 -- drivers/gpu/drm/omapdrm/dss/omapdss.h | 6 +- drivers

[PATCHv2 52/56] drm/omap: drop dssdev display field

2020-02-25 Thread Sebastian Reichel
All displays are using drm_panel instead off dssdev now, so this field is always 0 and can be dropped. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/dss/base.c| 2 +- drivers/gpu/drm/omapdrm/dss/omapdss.h | 6 -- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git

Re: [PATCH v6 00/51] drm/omap: Replace custom display drivers with drm_bridge and drm_panel

2020-02-17 Thread Sebastian Reichel
t; [2] https://patchwork.kernel.org/cover/11102445/ > [3] https://patchwork.kernel.org/cover/11349617/ The series is Tested-by: Sebastian Reichel Reviewed-by: Sebastian Reichel Testing was done on Droid 4, DSI command mode panel is still working. I had to add the following patch because of the base

Re: [PATCH v6 49/51] drm/omap: dss: Remove unused omap_dss_device operations

2020-02-20 Thread Sebastian Reichel
Hi, On Sun, Feb 16, 2020 at 11:03:06PM +0200, Laurent Pinchart wrote: > The omap_dss_device .pre_enable(), .post_disable() and .set_timings() > are not used anymore. Remove them. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Tomi Valkeinen > --- Actually it would be good to postpone this

Re: [PATCH v6 49/51] drm/omap: dss: Remove unused omap_dss_device operations

2020-02-21 Thread Sebastian Reichel
Hi, On Thu, Feb 20, 2020 at 11:45:30PM +0200, Laurent Pinchart wrote: > On Thu, Feb 20, 2020 at 10:39:38PM +0100, Sebastian Reichel wrote: > > On Sun, Feb 16, 2020 at 11:03:06PM +0200, Laurent Pinchart wrote: > > > The omap_dss_device .pre_enable(), .post_disable(

Re: [PATCH 2/3] ARM: dts: am437x-gp/epos-evm: drop unused panel timings

2020-02-13 Thread Sebastian Reichel
Hi, On Tue, Feb 11, 2020 at 07:22:14PM +0200, Tomi Valkeinen wrote: > On 11/02/2020 18:27, Tony Lindgren wrote: > > > We are still missing DSI command mode support, and moving it > > > to the common DRM model. > > > > Nope, DSI command mode support has been working just fine for > > a while now

Re: [PATCH 2/3] ARM: dts: am437x-gp/epos-evm: drop unused panel timings

2020-02-13 Thread Sebastian Reichel
Hi, On Tue, Feb 11, 2020 at 01:10:07PM +0200, Laurent Pinchart wrote: > On Tue, Feb 11, 2020 at 01:08:12PM +0200, Tomi Valkeinen wrote: > > On 11/02/2020 13:07, Laurent Pinchart wrote: > > > > >> Hopefully soon (in five years? =) we can say that omapdrm supports all > > >> the boards, and we can

Re: [PATCH] backlight: add led-backlight driver

2020-02-19 Thread Sebastian Reichel
<2>; > ti,led-mode = <0>; > label = ":backlight"; > - linux,default-trigger = "backlight"; > }; > > led@1 { > diff --git a/arch/arm/configs/omap2plus_

[PATCHv2 1/3] drm/panel: simple: Add support for AUO G190EAN01 panel

2020-04-16 Thread Sebastian Reichel
Add timings for the G190EAN01 dual channel LVDS panel. Signed-off-by: Sebastian Reichel --- .../bindings/display/panel/panel-simple.yaml | 2 ++ drivers/gpu/drm/panel/panel-simple.c | 33 +++ 2 files changed, 35 insertions(+) diff --git a/Documentation/devicetree

[PATCHv2 0/3] Add multiple AUO panels

2020-04-16 Thread Sebastian Reichel
Hi, Patches are more or less independent of each other. There was a previous version for the 12" and 15" panels, which was missing the DT binding update. The 19" patch is new, for the previous 10" panel a different patch has been merged in the meantime. -- Sebastian Sebastia

[PATCHv2 3/3] drm/panel: simple: Add support for AUO G121EAN01.4 panel

2020-04-16 Thread Sebastian Reichel
Add timings for the AUO G121EAN01.4 panel. Signed-off-by: Sebastian Reichel --- .../bindings/display/panel/panel-simple.yaml | 2 ++ drivers/gpu/drm/panel/panel-simple.c | 28 +++ 2 files changed, 30 insertions(+) diff --git a/Documentation/devicetree/bindings

[PATCHv2 2/3] drm/panel: simple: Add support for AUO G156XTN01.0 panel

2020-04-16 Thread Sebastian Reichel
Add timings for the AUO G156XTN01.0 panel. Signed-off-by: Sebastian Reichel --- .../bindings/display/panel/panel-simple.yaml | 2 ++ drivers/gpu/drm/panel/panel-simple.c | 28 +++ 2 files changed, 30 insertions(+) diff --git a/Documentation/devicetree/bindings

[PATCHv1] gpu: ipu-v3: Add 8 pixel alignment fix

2020-09-11 Thread Sebastian Reichel
by a kernel at default loglevel is: [1.876609] [drm] Initialized imx-drm 1.0.0 20120507 for display-subsystem on minor 1 After this patch the system boots fine and it is possible to start X.org and Weston from Debian testing. Suggested-by: Boris Brezillon Signed-off-by: Sebastian Reichel --- Hi

Re: [PATCH 4/4] dt-bindings: Explicitly allow additional properties in common schemas

2020-10-05 Thread Sebastian Reichel
ays allow for > additionalProperties. > > Signed-off-by: Rob Herring > --- > [...] > .../devicetree/bindings/power/supply/power-supply.yaml | 2 ++ > [...] Acked-by: Sebastian Reichel -- Sebastian signature.asc Description: PGP signature

Re: [PATCH] dt-bindings: Another round of adding missing 'additionalProperties'

2020-10-05 Thread Sebastian Reichel
ke this thru the DT tree. > > [...] > .../bindings/power/supply/cw2015_battery.yaml | 2 ++ > .../bindings/power/supply/rohm,bd99954.yaml | 8 ++++ > [...] Acked-by: Sebastian Reichel -- Sebastian signature.asc Description: PGP signature _

Re: [PATCH v2 23/24] drm/omap: display: Backlight update

2020-08-29 Thread Sebastian Reichel
gt; - Use macro for backlight initialization > > v2: > - Drop backlight_update() call as it is redundant (Sebastian) > > Signed-off-by: Sam Ravnborg > Cc: Tomi Valkeinen > Cc: Sebastian Reichel > Cc: Laurent Pinchart > Cc: Zheng Bin > Cc: Sam Ravnborg > --

Re: [PATCH v2] MAINTAINERS: add Dan Murphy as TP LP8xxx drivers maintainer

2020-09-29 Thread Sebastian Reichel
regulator) drivers. > > > > > > > > > > Cc: Dan Murphy > > > > > Signed-off-by: Krzysztof Kozlowski > > > > > > > > Acked-by: Dan Murphy > > > > > > > Not sure who will pick this one up, but >

[PATCHv2 0/4] Subject: panel-dsi-cm: update bindings

2020-07-17 Thread Sebastian Reichel
tch description from patch 2 * Apply Reviewed-by tags [0] https://lore.kernel.org/dri-devel/20200629223315.118256-1-sebastian.reic...@collabora.com/ -- Sebastian Sebastian Reichel (4): dt-bindings: display: panel-dsi-cm: convert to YAML ARM: dts: omap: add channel to DSI panels ARM: dts: omap4-dro

[PATCHv2 1/4] dt-bindings: display: panel-dsi-cm: convert to YAML

2020-07-17 Thread Sebastian Reichel
Convert panel-dsi-cm bindings to YAML and add missing properties while at it. Reviewed-by: Laurent Pinchart Reviewed-by: Rob Herring Signed-off-by: Sebastian Reichel --- .../bindings/display/panel/panel-dsi-cm.txt | 29 --- .../bindings/display/panel/panel-dsi-cm.yaml | 86

[PATCHv2 4/4] ARM: dts: omap4-droid4: add panel orientation

2020-07-17 Thread Sebastian Reichel
Add information about panel orientation, so that the system boots into a properly rotated shell. Reviewed-by: Laurent Pinchart Signed-off-by: Sebastian Reichel --- arch/arm/boot/dts/motorola-mapphone-common.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/motorola

[PATCHv2 2/4] ARM: dts: omap: add channel to DSI panels

2020-07-17 Thread Sebastian Reichel
The standard binding for DSI requires that the channel number of the panel is encoded in DT. This adds the channel number in all OMAP3-5 boards in preparation for using common infrastructure. Reviewed-by: Laurent Pinchart Signed-off-by: Sebastian Reichel --- arch/arm/boot/dts/motorola-mapphone

[PATCHv2 3/4] ARM: dts: omap4-droid4: add panel compatible

2020-07-17 Thread Sebastian Reichel
Add Droid 4 specific compatible value in addition to the generic one, so that we have the ability to add panel specific quirks in the future. Reviewed-by: Laurent Pinchart Signed-off-by: Sebastian Reichel --- arch/arm/boot/dts/motorola-mapphone-common.dtsi | 2 +- 1 file changed, 1 insertion

Re: [PATCH v1 21/22] drm/omap: display: Backlight update

2020-08-02 Thread Sebastian Reichel
gt; - Use macro for backlight initialization > > Signed-off-by: Sam Ravnborg > Cc: Tomi Valkeinen > Cc: Sebastian Reichel > Cc: Laurent Pinchart > Cc: Zheng Bin > Cc: Sam Ravnborg > --- > .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 35 --- >

Re: [PATCH v1 21/22] drm/omap: display: Backlight update

2020-08-02 Thread Sebastian Reichel
Hi, On Sun, Aug 02, 2020 at 04:32:07PM +0200, Sam Ravnborg wrote: > On Sun, Aug 02, 2020 at 04:26:05PM +0200, Sebastian Reichel wrote: > > On Sun, Aug 02, 2020 at 01:06:35PM +0200, Sam Ravnborg wrote: > > > - Introduce backlight_{enable/disable) > >

[PATCHv1 3/4] ARM: dts: omap4-droid4: add panel compatible

2020-06-30 Thread Sebastian Reichel
Add Droid 4 specific compatible value in addition to the generic one, so that we have the ability to add panel specific quirks in the future. Signed-off-by: Sebastian Reichel --- arch/arm/boot/dts/motorola-mapphone-common.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCHv1 0/4] panel-dsi-cm: update bindings

2020-06-30 Thread Sebastian Reichel
aml) and modifies the DT slightly. -- Sebastian Sebastian Reichel (4): dt-bindings: display: panel-dsi-cm: convert to YAML ARM: dts: omap: add channel to DSI panels ARM: dts: omap4-droid4: add panel compatible ARM: dts: omap4-droid4: add panel orientation .../bindings/display/panel/panel-

[PATCHv1 1/4] dt-bindings: display: panel-dsi-cm: convert to YAML

2020-06-30 Thread Sebastian Reichel
Convert panel-dsi-cm bindings to YAML and add missing properties while at it. Signed-off-by: Sebastian Reichel --- .../bindings/display/panel/panel-dsi-cm.txt | 29 - .../bindings/display/panel/panel-dsi-cm.yaml | 100 ++ 2 files changed, 100 insertions(+), 29 deletions

[PATCHv1 4/4] ARM: dts: omap4-droid4: add panel orientation

2020-06-30 Thread Sebastian Reichel
Add information about panel orientation, so that the system boots into a properly rotated shell. Signed-off-by: Sebastian Reichel --- arch/arm/boot/dts/motorola-mapphone-common.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/motorola-mapphone-common.dtsi b/arch/arm

[PATCHv1 2/4] ARM: dts: omap: add channel to DSI panels

2020-06-30 Thread Sebastian Reichel
The standard binding for DSI requires, that the channel number of the panel is encoded in DT. This adds the channel number in all OMAP3-5 boards, in preparation for using common infrastructure. Signed-off-by: Sebastian Reichel --- arch/arm/boot/dts/motorola-mapphone-common.dtsi | 3 ++- arch

Re: [PATCHv2 1/4] dt-bindings: display: panel-dsi-cm: convert to YAML

2020-07-16 Thread Sebastian Reichel
Hi, On Thu, Jul 16, 2020 at 07:52:58PM +0200, Sam Ravnborg wrote: > On Thu, Jul 16, 2020 at 02:57:30PM +0200, Sebastian Reichel wrote: > > Convert panel-dsi-cm bindings to YAML and add > > missing properties while at it. > > > > Reviewed-by: Laurent Pinchart &

[PATCH] drm/panel: sony-acx565akm: Fix race condition in probe

2020-11-29 Thread Sebastian Reichel
er Ujfalusi Reported-by: Tony Lindgren Reported-by: Aaro Koskinen Reported-by: Ivaylo Dimitrov Cc: Merlijn Wajer Cc: Laurent Pinchart Cc: Tomi Valkeinen Fixes: 1c8fc3f0c5d2 ("drm/panel: Add driver for the Sony ACX565AKM panel") Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/pan

<    1   2   3   4   5   6   7   >