Re: [PATCH 06/10] drm/edid: Fix cea mode aspect ratio handling

Regards Shashank On 11/17/2017 6:19 PM, Ville Syrjälä wrote: On Fri, Nov 17, 2017 at 05:50:11PM +0530, Sharma, Shashank wrote: Regards Shashank On 11/17/2017 5:05 PM, Ville Syrjälä wrote: On Fri, Nov 17, 2017 at 08:49:49AM +0530, Sharma, Shashank wrote: Regards Shashank On 11/16/2017

Re: [PATCH 07/10] drm/edid: Don't send bogus aspect ratios in AVI infoframes

Regards Shashank On 11/17/2017 5:08 PM, Ville Syrjälä wrote: On Fri, Nov 17, 2017 at 08:53:54AM +0530, Sharma, Shashank wrote: Regards Shashank On 11/16/2017 9:56 PM, Ville Syrjälä wrote: On Thu, Nov 16, 2017 at 08:31:36PM +0530, Sharma, Shashank wrote: Regards Shashank On 11/13/2017

Re: [PATCH 06/10] drm/edid: Fix cea mode aspect ratio handling

Regards Shashank On 11/17/2017 5:05 PM, Ville Syrjälä wrote: On Fri, Nov 17, 2017 at 08:49:49AM +0530, Sharma, Shashank wrote: Regards Shashank On 11/16/2017 9:53 PM, Ville Syrjälä wrote: On Thu, Nov 16, 2017 at 08:21:44PM +0530, Sharma, Shashank wrote: Regards Shashank On 11/13/2017

Re: [PATCH 07/10] drm/edid: Don't send bogus aspect ratios in AVI infoframes

Regards Shashank On 11/16/2017 9:56 PM, Ville Syrjälä wrote: On Thu, Nov 16, 2017 at 08:31:36PM +0530, Sharma, Shashank wrote: Regards Shashank On 11/13/2017 10:34 PM, Ville Syrjala wrote: From: Ville Syrjälä <ville.syrj...@linux.intel.com> If the user mode would specify an aspect

Re: [PATCH 06/10] drm/edid: Fix cea mode aspect ratio handling

Regards Shashank On 11/16/2017 9:53 PM, Ville Syrjälä wrote: On Thu, Nov 16, 2017 at 08:21:44PM +0530, Sharma, Shashank wrote: Regards Shashank On 11/13/2017 10:34 PM, Ville Syrjala wrote: From: Ville Syrjälä <ville.syrj...@linux.intel.com> commit 6dffd431e229 ("drm: Add a

Re: [PATCH 02/10] drm/edid: Allow HDMI infoframe without VIC or S3D

Regards Shashank On 11/16/2017 9:51 PM, Ville Syrjälä wrote: On Thu, Nov 16, 2017 at 08:10:55PM +0530, Sharma, Shashank wrote: Regards Shashank On 11/13/2017 10:34 PM, Ville Syrjala wrote: From: Ville Syrjälä <ville.syrj...@linux.intel.com> Appedix F of HDMI 2.0 says that some HDM

Re: [PATCH 01/10] video/hdmi: Allow "empty" HDMI infoframes

Regards Shashank On 11/16/2017 9:46 PM, Ville Syrjälä wrote: On Thu, Nov 16, 2017 at 08:06:18PM +0530, Sharma, Shashank wrote: Regards Shashank On 11/13/2017 10:34 PM, Ville Syrjala wrote: From: Ville Syrjälä <ville.syrj...@linux.intel.com> HDMI 2.0 Appendix F suggest that we

Re: [PATCH 07/10] drm/edid: Don't send bogus aspect ratios in AVI infoframes

Regards Shashank On 11/13/2017 10:34 PM, Ville Syrjala wrote: From: Ville Syrjälä If the user mode would specify an aspect ratio other than 4:3 or 16:9 we now silently ignore it. Maybe a better apporoach is to return an error? Let's try that. Also we must be

Re: [PATCH 06/10] drm/edid: Fix cea mode aspect ratio handling

Regards Shashank On 11/13/2017 10:34 PM, Ville Syrjala wrote: From: Ville Syrjälä commit 6dffd431e229 ("drm: Add aspect ratio parsing in DRM layer") cause us to not send out any VICs in the AVI infoframes. That commit was since reverted, but if and when we add

Re: [PATCH 02/10] drm/edid: Allow HDMI infoframe without VIC or S3D

Regards Shashank On 11/13/2017 10:34 PM, Ville Syrjala wrote: From: Ville Syrjälä Appedix F of HDMI 2.0 says that some HDMI sink may fail to switch from 3D to 2D mode in a timely fashion if the source simply stops sending the HDMI infoframe. The suggested

Re: [PATCH 01/10] video/hdmi: Allow "empty" HDMI infoframes

Regards Shashank On 11/13/2017 10:34 PM, Ville Syrjala wrote: From: Ville Syrjälä HDMI 2.0 Appendix F suggest that we should keep sending the infoframe when switching from 3D to 2D mode, even if the infoframe isn't strictly necessary (ie. not needed to

Re: [PATCH 3/3] drm/scdc-helper: Use consistent spelling for TMDS

Reviewed-by: Shashank Sharma Regards Shashank On 9/1/2017 8:14 PM, Thierry Reding wrote: From: Thierry Reding The file uses inconsistent capitalization for TMDS. Since it is an abbreviation, all uppercase is correct. Signed-off-by: Thierry

Re: [PATCH 2/3] drm/scdc-helper: Use consistent error reporting

Regards Shashank On 9/1/2017 8:14 PM, Thierry Reding wrote: From: Thierry Reding The error messages generated by the SCDC helpers are somewhat inconsistent with other DRM errors and even with other errors in the same file. Fix them all up to use a common format.

Re: [PATCH 1/3] drm/scdc-helper: Remove gratuitous blank lines

Regards Shashank On 9/1/2017 8:14 PM, Thierry Reding wrote: From: Thierry Reding It's unusual to separate kerneldoc comments from the functions that they describe by a blank line. Remove them. Signed-off-by: Thierry Reding ---

RE: [PATCH 1/4] drm/modes: Fix drm_mode_is_420_only() comment

Reviewed-by: Shashank Sharma Regards Shashank -Original Message- From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of Sean Paul Sent: Thursday, July 20, 2017 11:18 PM To: dri-devel@lists.freedesktop.org Cc: Vetter, Daniel

Re: FW: [PATCH v2 2/4] drm: Fix warning when building docs for scdc_helper

Thanks for adding this fix , Sean, and sorry about missing this alignment in doc. Regards Shashank On 7/24/2017 9:01 PM, Sharma, Shashank wrote: -Original Message- From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of Sean Paul Sent: Friday, July 21, 2017 1:39

Re: [PATCH v2 00/14] YCBCR 4:2:0 handling in DRM layer

Regards Shashank On 7/15/2017 12:32 AM, Ville Syrjälä wrote: On Thu, Jul 13, 2017 at 09:03:06PM +0530, Shashank Sharma wrote: Following YCBCR 4:4:4 and 4:2:2, YCBCR 4:2:0 is a new output format, which is currently supported on HDMI 2.0 sources/sinks. Due to lower chroma sub-sampling rate,

Re: [PATCH v2 12/14] drm/i915: prepare csc unit for YCBCR420 output

Regards Shashank On 7/15/2017 12:06 AM, Ville Syrjälä wrote: On Thu, Jul 13, 2017 at 09:03:18PM +0530, Shashank Sharma wrote: To support ycbcr output, we need a pipe CSC block to do RGB->YCBCR conversion. Current Intel platforms have only one pipe CSC unit, so we can either do color

Re: [PATCH v2 11/14] drm/i915: prepare pipe for YCBCR420 output

Regards Shashank On 7/15/2017 12:03 AM, Ville Syrjälä wrote: On Thu, Jul 13, 2017 at 09:03:17PM +0530, Shashank Sharma wrote: To get HDMI YCBCR420 output, the PIPEMISC register should be programmed to: - Generate YCBCR output (bit 11) - In case of YCBCR420 outputs, it should be programmed in

Re: [PATCH v2 10/14] drm/i915: prepare scaler for YCBCR420 modeset

Regards Shahank On 7/15/2017 12:00 AM, Ville Syrjälä wrote: On Thu, Jul 13, 2017 at 09:03:16PM +0530, Shashank Sharma wrote: To get a YCBCR420 output from intel platforms, we need one scaler to scale down YCBCR444 samples to YCBCR420 samples. This patch: - Does scaler allocation for HDMI

Re: [PATCH v2 09/14] drm/i915: add config function for YCBCR420 outputs

Regards Shashank On 7/15/2017 12:00 AM, Ville Syrjälä wrote: On Thu, Jul 13, 2017 at 09:03:15PM +0530, Shashank Sharma wrote: This patch checks encoder level support for YCBCR420 outputs. The logic goes as simple as this: If the input mode is YCBCR420-only mode: prepare HDMI for YCBCR420

Re: [PATCH v2 06/14] drm/edid: parse YCBCR420 videomodes from EDID

Regards Shashank On 7/13/2017 9:51 PM, Ville Syrjälä wrote: On Thu, Jul 13, 2017 at 09:03:12PM +0530, Shashank Sharma wrote: HDMI 2.0 spec adds support for YCBCR420 sub-sampled output. CEA-861-F adds two new blocks in EDID's CEA extension blocks, to provide information about sink's YCBCR420

Re: [PATCH 10/20] drm/i915: add config function for YCBCR420 outputs

On 7/13/2017 7:40 PM, Ville Syrjälä wrote: What I mean is for_each() { ... + if (420) { + if (!420_dc) + return false; + } else { if (!444_dc) return false; + } } Got it, Thanks !

Re: [PATCH 10/20] drm/i915: add config function for YCBCR420 outputs

On 7/13/2017 6:56 PM, Ville Syrjälä wrote: We don't want breaks in the loop. It's meant to go through all the connectors for the crtc. Granted on modern platforms there can only be one, but IMO assuming that just makes the whole thing look confusing. It's much clearer IMO if we do if (420) {

Re: [PATCH 20/20] drm/i915: write AVI infoframes for LSPCON

On 7/13/2017 6:49 PM, Ville Syrjälä wrote: Yeah something like this perhaps: "We send 4:4:4 data to LSPCON which performs the 4:4:4->4:2:0 downsampling or us, hence we don't need a pipe scaler." Seems good ! Will add this. - Shashank ___ dri-devel

Re: [PATCH 18/20] drm/i915: YCBCR 420 support for LSPCON

On 7/13/2017 6:43 PM, Ville Syrjälä wrote: We don't use those clocks with DP. You've just added them here because the function call requires them as parameters. Also the function call is actually doing the wrong thing for DP by halving port_clock. Ah, missed that part. Thanks for letting me

Re: [PATCH 08/20] drm: set output colorspace in AVI infoframe

On 7/13/2017 6:33 PM, Ville Syrjälä wrote: If the mode requires pixel repeat to meet the minimum clock requirement, then we can't just not do pixel repeat. That would violate the spec in other ways, and IIRC we couldn't even generate a low enough clock for it. The YCBCR420 modes I am seeing on

Re: [PATCH 06/20] drm: add helper to validate YCBCR420 modes

On 7/13/2017 6:30 PM, Ville Syrjälä wrote: I guess then you just need to add the bitmap already in the validation patch. An alternative would be just squash the patches, but that seems a bit drastic, and probably would mix up too many things in one patch. Ok then, I will introduce this bitmap

Re: [PATCH 20/20] drm/i915: write AVI infoframes for LSPCON

Regards Shashank On 7/13/2017 6:25 PM, Ville Syrjälä wrote: On Thu, Jul 13, 2017 at 06:09:53PM +0530, Sharma, Shashank wrote: Regards Shashank On 7/13/2017 5:57 PM, Ville Syrjälä wrote: On Thu, Jul 13, 2017 at 11:11:53AM +0530, Sharma, Shashank wrote: Regards Shashank On 7/12/2017 10

Re: [PATCH 10/20] drm/i915: add config function for YCBCR420 outputs

Regards Shashank On 7/13/2017 6:23 PM, Ville Syrjälä wrote: On Thu, Jul 13, 2017 at 10:56:06AM +0530, Sharma, Shashank wrote: Regards Shashank On 7/12/2017 10:47 PM, Ville Syrjälä wrote: On Mon, Jul 10, 2017 at 04:48:38PM +0530, Shashank Sharma wrote: This patch checks encoder level

Re: [Intel-gfx] [PATCH 11/20] drm/i915: prepare scaler for YCBCR420 modeset

Regards Shashank On 7/13/2017 6:22 PM, Ville Syrjälä wrote: On Thu, Jul 13, 2017 at 10:51:04AM +0530, Sharma, Shashank wrote: Regards Shashank On 7/12/2017 10:47 PM, Ville Syrjälä wrote: On Mon, Jul 10, 2017 at 04:48:39PM +0530, Shashank Sharma wrote: To get a YCBCR420 output from intel

Re: [PATCH 13/20] drm/i915: prepare csc unit for YCBCR420 output

Regards Shashank On 7/13/2017 6:20 PM, Ville Syrjälä wrote: On Thu, Jul 13, 2017 at 10:44:51AM +0530, Sharma, Shashank wrote: Regards Shashank On 7/12/2017 10:47 PM, Ville Syrjälä wrote: On Mon, Jul 10, 2017 at 04:48:41PM +0530, Shashank Sharma wrote: To support ycbcr output, we need

Re: [PATCH 16/20] drm: add function to read vendor OUI

Regards Shashank On 7/13/2017 6:07 PM, Ville Syrjälä wrote: On Thu, Jul 13, 2017 at 10:34:26AM +0530, Sharma, Shashank wrote: Regads Shashank On 7/12/2017 10:45 PM, Ville Syrjälä wrote: On Mon, Jul 10, 2017 at 04:48:44PM +0530, Shashank Sharma wrote: This patch adds a helper function

Re: [PATCH 08/20] drm: set output colorspace in AVI infoframe

Regards Shashank On 7/13/2017 6:05 PM, Ville Syrjälä wrote: On Thu, Jul 13, 2017 at 10:37:53AM +0530, Sharma, Shashank wrote: Regards Shashank On 7/12/2017 10:47 PM, Ville Syrjälä wrote: On Mon, Jul 10, 2017 at 04:48:36PM +0530, Shashank Sharma wrote: A source must set output colorspace

Re: [PATCH 06/20] drm: add helper to validate YCBCR420 modes

Regards Shashank On 7/13/2017 6:01 PM, Ville Syrjälä wrote: On Thu, Jul 13, 2017 at 11:02:18AM +0530, Sharma, Shashank wrote: Regards Shashank On 7/12/2017 10:48 PM, Ville Syrjälä wrote: On Mon, Jul 10, 2017 at 04:48:34PM +0530, Shashank Sharma wrote: YCBCR420 modes are supported only

Re: [PATCH 20/20] drm/i915: write AVI infoframes for LSPCON

Regards Shashank On 7/13/2017 5:57 PM, Ville Syrjälä wrote: On Thu, Jul 13, 2017 at 11:11:53AM +0530, Sharma, Shashank wrote: Regards Shashank On 7/12/2017 10:54 PM, Ville Syrjälä wrote: On Mon, Jul 10, 2017 at 04:48:48PM +0530, Shashank Sharma wrote: LSPCON chips can't pick the HDMI

Re: [PATCH 20/20] drm/i915: write AVI infoframes for LSPCON

Regards Shashank On 7/12/2017 10:54 PM, Ville Syrjälä wrote: On Mon, Jul 10, 2017 at 04:48:48PM +0530, Shashank Sharma wrote: LSPCON chips can't pick the HDMI AVI infoframes from direct link. In order to pass AVI infoframes from display controller to LSPCON, we have to write infoframe

Re: [PATCH 02/20] drm/edid: complete CEA modedb(VIC 1-107)

Regards Shashank On 7/12/2017 10:48 PM, Ville Syrjälä wrote: On Mon, Jul 10, 2017 at 04:48:30PM +0530, Shashank Sharma wrote: CEA-861-F specs defines new video modes to be used with HDMI 2.0 EDIDs. The VIC range has been extended from 1-64 to 1-107. Our existing CEA modedb contains only 64

Re: [PATCH 07/20] drm/edid: parse ycbcr 420 deep color information

Regards Shashank On 7/12/2017 10:48 PM, Ville Syrjälä wrote: On Mon, Jul 10, 2017 at 04:48:35PM +0530, Shashank Sharma wrote: CEA-861-F spec adds ycbcr420 deep color support information in hf-vsdb block. This patch extends the existing hf-vsdb parsing function by adding parsing of ycbcr420

Re: [PATCH 06/20] drm: add helper to validate YCBCR420 modes

Regards Shashank On 7/12/2017 10:48 PM, Ville Syrjälä wrote: On Mon, Jul 10, 2017 at 04:48:34PM +0530, Shashank Sharma wrote: YCBCR420 modes are supported only on HDMI 2.0 capable sources. This patch adds: - A drm helper to validate YCBCR420-only mode on a particular connector. This

Re: [PATCH 09/20] drm: add helper functions for YCBCR420 handling

Regards Shashank On 7/12/2017 10:47 PM, Ville Syrjälä wrote: On Mon, Jul 10, 2017 at 04:48:37PM +0530, Shashank Sharma wrote: This patch adds helper functions for YCBCR 420 handling. These functions do: - check if a given video mode is YCBCR 420 only mode. - check if a given video mode is

Re: [PATCH 10/20] drm/i915: add config function for YCBCR420 outputs

Regards Shashank On 7/12/2017 10:47 PM, Ville Syrjälä wrote: On Mon, Jul 10, 2017 at 04:48:38PM +0530, Shashank Sharma wrote: This patch checks encoder level support for YCBCR420 outputs. The logic goes as simple as this: If the input mode is YCBCR420-only mode: prepare HDMI for YCBCR420

Re: [Intel-gfx] [PATCH 11/20] drm/i915: prepare scaler for YCBCR420 modeset

Regards Shashank On 7/12/2017 10:47 PM, Ville Syrjälä wrote: On Mon, Jul 10, 2017 at 04:48:39PM +0530, Shashank Sharma wrote: To get a YCBCR420 output from intel platforms, we need one scaler to scale down YCBCR444 samples to YCBCR420 samples. This patch: - Does scaler allocation for HDMI

Re: [PATCH 13/20] drm/i915: prepare csc unit for YCBCR420 output

Regards Shashank On 7/12/2017 10:47 PM, Ville Syrjälä wrote: On Mon, Jul 10, 2017 at 04:48:41PM +0530, Shashank Sharma wrote: To support ycbcr output, we need a pipe CSC block to do RGB->YCBCR conversion. Current Intel platforms have only one pipe CSC unit, so we can either do color

Re: [PATCH 08/20] drm: set output colorspace in AVI infoframe

Regards Shashank On 7/12/2017 10:47 PM, Ville Syrjälä wrote: On Mon, Jul 10, 2017 at 04:48:36PM +0530, Shashank Sharma wrote: A source must set output colorspace information in AVI infoframes, so that the sink can decode upcoming frames accordingly. This patch adds a function to add the

Re: [PATCH 16/20] drm: add function to read vendor OUI

Regads Shashank On 7/12/2017 10:45 PM, Ville Syrjälä wrote: On Mon, Jul 10, 2017 at 04:48:44PM +0530, Shashank Sharma wrote: This patch adds a helper function in DP dual mode layer to read the vendor's IEEE OUI signature from a Dual mode adapter. This will be used to differentiate between

Re: [PATCH 18/20] drm/i915: YCBCR 420 support for LSPCON

Regards Shashank On 7/12/2017 10:45 PM, Ville Syrjälä wrote: On Mon, Jul 10, 2017 at 04:48:46PM +0530, Shashank Sharma wrote: LSPCON chips support YCBCR420 outputs. To be able to get YCBCR420 output from LSPCON chip, the source should: - Generate YCBCR444 HDMI output - Set AVI infoframes for

Re: [PATCH 19/20] drm/i915: Move AVI infoframe function to DDI layer

Thanks for the review, Ville. My comments, inline. Regards Shashank On 7/12/2017 10:45 PM, Ville Syrjälä wrote: On Mon, Jul 10, 2017 at 04:48:47PM +0530, Shashank Sharma wrote: We have an existing function to prepare AVI infoframes for HDMI, this patch moves that function from HDMI layer, to

Re: [PATCH v5 04/17] drm: add helper to validate ycbcr420 modes

Regards Shashank On 7/5/2017 3:46 PM, Ville Syrjälä wrote: On Wed, Jul 05, 2017 at 08:48:40AM +0530, Sharma, Shashank wrote: Regards Shashank On 7/4/2017 9:26 PM, Ville Syrjälä wrote: On Tue, Jul 04, 2017 at 07:41:51PM +0530, Shashank Sharma wrote: YCBCR420 modes are supported only

Re: [PATCH v5 09/17] drm: create hdmi output property

Regards Shashank On 7/5/2017 12:01 PM, Daniel Vetter wrote: On Wed, Jul 05, 2017 at 11:39:30AM +0530, Sharma, Shashank wrote: Regards Shashank On 7/4/2017 9:06 PM, Daniel Vetter wrote: On Tue, Jul 04, 2017 at 07:41:56PM +0530, Shashank Sharma wrote: HDMI displays can support various

Re: [PATCH v5 09/17] drm: create hdmi output property

Regards Shashank On 7/4/2017 9:06 PM, Daniel Vetter wrote: On Tue, Jul 04, 2017 at 07:41:56PM +0530, Shashank Sharma wrote: HDMI displays can support various output types, based on the color space and subsampling type. The possible outputs from a HDMI 2.0 monitor could be: - RGB - YCBCR

Re: [PATCH v5 04/17] drm: add helper to validate ycbcr420 modes

Regards Shashank On 7/4/2017 9:26 PM, Ville Syrjälä wrote: On Tue, Jul 04, 2017 at 07:41:51PM +0530, Shashank Sharma wrote: YCBCR420 modes are supported only on HDMI 2.0 capable sources. This patch adds a drm helper to validate YCBCR420-only mode on a particular connector. This function will

Re: [PATCH v5 02/17] drm: add YCBCR 420 capability identifier

Regards Shashank On 7/4/2017 9:25 PM, Ville Syrjälä wrote: On Tue, Jul 04, 2017 at 07:41:49PM +0530, Shashank Sharma wrote: This patch adds a bool variable (ycbcr_420_allowed) in the drm connector structure. While handling the EDID from HDMI 2.0 sinks, its important to know if the source is

Re: [Intel-gfx] [PATCH v3] drm/edid: rename macro for CEA extended-tag

Regards Shashank On 7/3/2017 9:14 PM, David Weinehall wrote: On Mon, Jul 03, 2017 at 08:41:53PM +0530, Shashank Sharma wrote: CEA-861-F introduces extended tag codes for EDID extension blocks, which indicates the actual type of the data block. The code for using exteded tag is 0x7, whereas

RE: [PATCH v3] drm/edid: rename macro for CEA extended-tag

Please ignore this version, sent premature. Actual one on the way. -Original Message- From: Sharma, Shashank Sent: Monday, July 3, 2017 8:39 PM To: dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org Cc: Sharma, Shashank <shashank.sha...@intel.com>; Ville S

Re: [RESEND-CI v4 01/15] drm: add HDMI 2.0 VIC support for AVI info-frames

Regards Shashank On 7/3/2017 3:27 PM, Ville Syrjälä wrote: On Mon, Jul 03, 2017 at 02:36:58PM +0530, Sharma, Shashank wrote: Regards Shashank On 6/30/2017 5:24 PM, Ville Syrjälä wrote: On Wed, Jun 21, 2017 at 04:03:59PM +0530, Shashank Sharma wrote: HDMI 1.4b support the CEA video modes

Re: [RESEND-CI v4 01/15] drm: add HDMI 2.0 VIC support for AVI info-frames

Regards Shashank On 6/30/2017 5:24 PM, Ville Syrjälä wrote: On Wed, Jun 21, 2017 at 04:03:59PM +0530, Shashank Sharma wrote: HDMI 1.4b support the CEA video modes as per range of CEA-861-D (VIC 1-64). For any other mode, the VIC filed in AVI infoframes should be 0. HDMI 2.0 sinks, support

Re: [RESEND-CI v4 11/15] drm/i915: prepare scaler for YCBCR420 modeset

Regards Shashank On 6/30/2017 7:45 PM, Ander Conselvan De Oliveira wrote: On Fri, 2017-06-30 at 17:29 +0530, Sharma, Shashank wrote: Regards Shashank On 6/30/2017 5:04 PM, Ander Conselvan De Oliveira wrote: On Fri, 2017-06-30 at 11:20 +0530, Sharma, Shashank wrote: Regards Shashank

Re: [Intel-gfx] [RESEND-CI v4 15/15] drm/i915/glk: set HDMI 2.0 identifier

Regards Shashank On 6/30/2017 5:37 PM, Ander Conselvan De Oliveira wrote: On Wed, 2017-06-21 at 16:04 +0530, Shashank Sharma wrote: This patch sets the is_hdmi2_src identifier in drm connector for GLK platform. GLK contains a native HDMI 2.0 controller. This identifier will help the EDID

Re: [RESEND-CI v4 04/15] drm/edid: parse YCBCR 420 videomodes from EDID

Regards Shashank On 6/30/2017 5:28 PM, Ville Syrjälä wrote: On Fri, Jun 30, 2017 at 10:47:48AM +0530, Sharma, Shashank wrote: Regards Shashank On 6/27/2017 5:22 PM, Ville Syrjälä wrote: On Wed, Jun 21, 2017 at 04:04:02PM +0530, Shashank Sharma wrote: HDMI 2.0 spec adds support

Re: [RESEND-CI v4 06/15] drm/edid: parse sink information before CEA blocks

Regards Shashank On 6/30/2017 5:16 PM, Ville Syrjälä wrote: On Fri, Jun 30, 2017 at 10:52:54AM +0530, Sharma, Shashank wrote: Regards Shashank On 6/27/2017 5:25 PM, Ville Syrjälä wrote: On Wed, Jun 21, 2017 at 04:04:04PM +0530, Shashank Sharma wrote: CEA-861-F adds ycbcr capability map

Re: [RESEND-CI v4 11/15] drm/i915: prepare scaler for YCBCR420 modeset

Regards Shashank On 6/30/2017 5:04 PM, Ander Conselvan De Oliveira wrote: On Fri, 2017-06-30 at 11:20 +0530, Sharma, Shashank wrote: Regards Shashank On 6/27/2017 5:46 PM, Ander Conselvan De Oliveira wrote: On Wed, 2017-06-21 at 16:04 +0530, Shashank Sharma wrote: To get a YCBCR420

Re: [RESEND-CI v4 13/15] drm/i915: prepare csc unit for YCBCR HDMI output

Regards Shashank On 6/29/2017 5:38 PM, Ander Conselvan De Oliveira wrote: On Wed, 2017-06-21 at 16:04 +0530, Shashank Sharma wrote: To support ycbcr HDMI output, we need a pipe CSC block to do the RGB->YCBCR conversion, as the blender output is in RGB. Current Intel platforms have only one

Re: [RESEND-CI v4 11/15] drm/i915: prepare scaler for YCBCR420 modeset

Regards Shashank On 6/27/2017 5:46 PM, Ander Conselvan De Oliveira wrote: On Wed, 2017-06-21 at 16:04 +0530, Shashank Sharma wrote: To get a YCBCR420 output from intel platforms, we need one scaler to scale down YCBCR444 samples to YCBCR420 samples. This patch: - Does scaler allocation for

Re: [PATCH v5 7/7] drm: create hdmi output property

Regards Shashank On 6/27/2017 5:44 PM, Ville Syrjälä wrote: On Wed, Jun 21, 2017 at 04:04:13PM +0530, Shashank Sharma wrote: HDMI displays can support various output types, based on the color space and subsampling type. The possible outputs from a HDMI 2.0 monitor could be: - RGB - YCBCR

Re: [RESEND-CI v4 06/15] drm/edid: parse sink information before CEA blocks

Regards Shashank On 6/27/2017 5:25 PM, Ville Syrjälä wrote: On Wed, Jun 21, 2017 at 04:04:04PM +0530, Shashank Sharma wrote: CEA-861-F adds ycbcr capability map block, for HDMI 2.0 sinks. This block contains a map of indexes of CEA modes, which can support YCBCR 420 output also. To avoid

Re: [RESEND-CI v4 05/15] drm/edid: parse ycbcr 420 deep color information

Regards Shashank On 6/27/2017 5:23 PM, Ville Syrjälä wrote: On Wed, Jun 21, 2017 at 04:04:03PM +0530, Shashank Sharma wrote: CEA-861-F spec adds ycbcr420 deep color support information in hf-vsdb block. This patch extends the existing hf-vsdb parsing function by adding parsing of ycbcr420

Re: [RESEND-CI v4 04/15] drm/edid: parse YCBCR 420 videomodes from EDID

Regards Shashank On 6/27/2017 5:22 PM, Ville Syrjälä wrote: On Wed, Jun 21, 2017 at 04:04:02PM +0530, Shashank Sharma wrote: HDMI 2.0 spec adds support for YCBCR420 sub-sampled output. CEA-861-F adds two new blocks in EDID's CEA extension blocks, to provide information about sink's YCBCR420

Re: [RESEND-CI v4 03/15] drm/edid: Complete CEA modedb(VIC 1-107)

Regards Shashank On 6/27/2017 5:02 PM, Ville Syrjälä wrote: On Wed, Jun 21, 2017 at 04:04:01PM +0530, Shashank Sharma wrote: CEA-861-F specs defines new video modes to be used with HDMI 2.0 EDIDs. The VIC range has been extended from 1-64 to 1-107. Our existing CEA modedb contains only 64

Re: [Intel-gfx] [PATCH v5 7/7] drm: create hdmi output property

Regards Shashank On 6/23/2017 2:50 PM, Daniel Vetter wrote: On Thu, Jun 22, 2017 at 10:33 AM, Sharma, Shashank <shashank.sha...@intel.com> wrote: - The property values should be limited to what the driver can support, I guess that would mean limiting the available ycbcr modes? O

Re: [Intel-gfx] [RESEND-CI v4 09/15] drm: add helper functions for YCBCR output handling

Regards Shashank On 6/23/2017 2:42 PM, Daniel Vetter wrote: On Thu, Jun 22, 2017 at 11:42 AM, Sharma, Shashank <shashank.sha...@intel.com> wrote: You should explain in 1-2 sentences what exactly this function does, and when a driver should use it. Just documenting the input/output

Re: [Intel-gfx] [RESEND-CI v4 09/15] drm: add helper functions for YCBCR output handling

Regards Shashank On 6/22/2017 12:35 PM, Daniel Vetter wrote: On Wed, Jun 21, 2017 at 04:04:06PM +0530, Shashank Sharma wrote: This patch adds set of helper functions for YCBCR HDMI output handling. These functions provide functionality like: - check if a given video mode is YCBCR 420 only

Re: [Intel-gfx] [PATCH v5 7/7] drm: create hdmi output property

Thanks for the review, Daniel. My comments inline. Regards Shashank On 6/22/2017 12:44 PM, Daniel Vetter wrote: On Wed, Jun 21, 2017 at 04:04:13PM +0530, Shashank Sharma wrote: HDMI displays can support various output types, based on the color space and subsampling type. The possible outputs

Re: [Intel-gfx] [PATCH v4 10/15] drm/i915: add compute-config for YCBCR outputs

Regards Shashank On 6/20/2017 7:50 PM, Ander Conselvan De Oliveira wrote: On Mon, 2017-06-19 at 21:38 +0530, Shashank Sharma wrote: This patch checks encoder level support for HDMI YCBCR outputs. HDMI output mode is a connector property, this patch checks if source and sink can support the

Re: [PATCH v3 04/14] drm/edid: parse YCBCR 420 videomodes from EDID

typing these examples :-). Ok then, I will add a flag which sounds more like ycbcr_420_supported or so. Regards Shashank On 6/15/2017 10:29 PM, Ville Syrjälä wrote: On Thu, Jun 15, 2017 at 10:18:40PM +0530, Sharma, Shashank wrote: Regards Shashank On 6/15/2017 9:42 PM, Ville Syrjälä wrote

Re: [PATCH v3 04/14] drm/edid: parse YCBCR 420 videomodes from EDID

Regards Shashank On 6/15/2017 9:42 PM, Ville Syrjälä wrote: On Thu, Jun 15, 2017 at 09:05:10PM +0530, Sharma, Shashank wrote: Regards Shashank On 6/15/2017 8:13 PM, Ville Syrjälä wrote: On Wed, Jun 14, 2017 at 11:17:35PM +0530, Shashank Sharma wrote: HDMI 2.0 spec adds support

Re: [PATCH v3 04/14] drm/edid: parse YCBCR 420 videomodes from EDID

Regards Shashank On 6/15/2017 8:13 PM, Ville Syrjälä wrote: On Wed, Jun 14, 2017 at 11:17:35PM +0530, Shashank Sharma wrote: HDMI 2.0 spec adds support for YCBCR420 sub-sampled output. CEA-861-F adds two new blocks in EDID's CEA extension blocks, to provide information about sink's YCBCR420

Re: [PATCH v3 02/14] drm/edid: Complete CEA modedb(VIC 1-107)

Regards Shashank On 6/15/2017 6:59 PM, Ville Syrjälä wrote: On Wed, Jun 14, 2017 at 11:17:33PM +0530, Shashank Sharma wrote: CEA-861-F specs defines new video modes to be used with HDMI 2.0 EDIDs. The VIC range has been extended from 1-64 to 1-107. Our existing CEA modedb contains only 64

Re: [PATCH v3 01/14] drm: add HDMI 2.0 VIC support for AVI info-frames

Hello Thierry, Thanks for the comments. In fact, that was the plan earlier, but the problem is, this function is being called from several drivers, and not all of them have the drm_connector readily available with their caller function. For few drivers, I might have to go up two to three

Re: [PATCH v2 01/11] drm: Add HDMI 2.0 VIC support for AVI info-frames

Regards Shashank On 5/31/2017 6:11 PM, Ville Syrjälä wrote: On Tue, May 30, 2017 at 10:00:12PM +0530, Sharma, Shashank wrote: Regards Shashank On 5/30/2017 9:43 PM, Ville Syrjälä wrote: On Tue, May 30, 2017 at 05:43:40PM +0530, Shashank Sharma wrote: HDMI 1.4b support the CEA video

Re: [PATCH v2 02/11] drm/edid: Complete CEA modedb(VIC 1-107)

Regards Shashank On 5/31/2017 6:09 PM, Ville Syrjälä wrote: On Tue, May 30, 2017 at 09:56:56PM +0530, Sharma, Shashank wrote: Regards Shashank On 5/30/2017 9:48 PM, Ville Syrjälä wrote: On Tue, May 30, 2017 at 05:43:41PM +0530, Shashank Sharma wrote: CEA-861-F specs defines new video

Re: [PATCH v2 05/11] drm: create hdmi output property

Regards Shashank On 5/31/2017 6:16 PM, Ville Syrjälä wrote: On Tue, May 30, 2017 at 10:18:19PM +0530, Sharma, Shashank wrote: Regards Shashank On 5/30/2017 10:06 PM, Ville Syrjälä wrote: On Tue, May 30, 2017 at 05:43:44PM +0530, Shashank Sharma wrote: HDMI displays can support various

Re: [PATCH v2 05/11] drm: create hdmi output property

Regards Shashank On 5/30/2017 10:06 PM, Ville Syrjälä wrote: On Tue, May 30, 2017 at 05:43:44PM +0530, Shashank Sharma wrote: HDMI displays can support various output types, based on the color space and subsampling type. The possible outputs from a HDMI 2.0 monitor could be: - RGB -

Re: [PATCH v2 01/11] drm: Add HDMI 2.0 VIC support for AVI info-frames

Regards Shashank On 5/30/2017 9:43 PM, Ville Syrjälä wrote: On Tue, May 30, 2017 at 05:43:40PM +0530, Shashank Sharma wrote: HDMI 1.4b support the CEA video modes as per range of CEA-861-D (VIC 1-64). For any other mode, the VIC filed in AVI infoframes should be 0. HDMI 2.0 sinks, support

Re: [PATCH v2 02/11] drm/edid: Complete CEA modedb(VIC 1-107)

Regards Shashank On 5/30/2017 9:48 PM, Ville Syrjälä wrote: On Tue, May 30, 2017 at 05:43:41PM +0530, Shashank Sharma wrote: CEA-861-F specs defines new video modes to be used with HDMI 2.0 EDIDs. The VIC range has been extended from 1-64 to 1-107. Our existing CEA modedb contains only 64

Re: [PATCH 03/11] drm: parse ycbcr 420 vdb block

Regards Shashank On 5/9/2017 8:58 PM, Ville Syrjälä wrote: On Tue, May 09, 2017 at 02:04:55PM +0530, Sharma, Shashank wrote: Regards Shashank On 5/8/2017 10:39 PM, Ville Syrjälä wrote: On Mon, May 08, 2017 at 10:11:53PM +0530, Sharma, Shashank wrote: Regards Shashank On 5/8/2017 9:54

Re: [PATCH 03/11] drm: parse ycbcr 420 vdb block

Regards Shashank On 5/8/2017 10:39 PM, Ville Syrjälä wrote: On Mon, May 08, 2017 at 10:11:53PM +0530, Sharma, Shashank wrote: Regards Shashank On 5/8/2017 9:54 PM, Ville Syrjälä wrote: On Fri, Apr 07, 2017 at 07:39:20PM +0300, Shashank Sharma wrote: From: Jose Abreu <jose

Re: [PATCH 04/11] drm: parse ycbcr420 vcb block

Regards Shashank On 5/8/2017 10:28 PM, Ville Syrjälä wrote: On Fri, Apr 07, 2017 at 07:39:21PM +0300, Shashank Sharma wrote: HDMI 2.0 spec adds support for ycbcr420 subsampled output. CEA-861-F adds two new blocks in EDID, to provide information about sink's support for ycbcr420 output. One

Re: [PATCH 02/11] drm/edid: Complete CEA modedb(VIC 1-107)

Regards Shashank On 5/8/2017 9:52 PM, Ville Syrjälä wrote: On Fri, Apr 07, 2017 at 07:39:19PM +0300, Shashank Sharma wrote: CEA-861-F specs defines new video modes to be used with HDMI 2.0 EDIDs. The VIC range has been extended from 1-64 to 1-107. Our existing CEA modedb contains only 64

Re: [PATCH 03/11] drm: parse ycbcr 420 vdb block

Regards Shashank On 5/8/2017 9:54 PM, Ville Syrjälä wrote: On Fri, Apr 07, 2017 at 07:39:20PM +0300, Shashank Sharma wrote: From: Jose Abreu HDMI 2.0 spec adds support for ycbcr420 subsampled output. CEA-861-F adds two new blocks in EDID, to provide information

Re: [PATCH RFC v2 2/2] drm: Add YCBCR_DECODE_CSC and YCBCR_CSC_PREOFFSET properties to drm_plane

Regards Shashank On 5/5/2017 12:43 PM, Daniel Vetter wrote: On Fri, May 5, 2017 at 9:06 AM, Sharma, Shashank <shashank.sha...@intel.com> wrote: On 5/5/2017 12:28 PM, Daniel Vetter wrote: On Thu, May 04, 2017 at 05:51:45PM +0300, Ville Syrjälä wrote: On Thu, May 04, 2017 at 03:22:45PM

Re: [PATCH RFC v2 2/2] drm: Add YCBCR_DECODE_CSC and YCBCR_CSC_PREOFFSET properties to drm_plane

Regards Shashank On 5/5/2017 12:28 PM, Daniel Vetter wrote: On Thu, May 04, 2017 at 05:51:45PM +0300, Ville Syrjälä wrote: On Thu, May 04, 2017 at 03:22:45PM +0200, Daniel Vetter wrote: On Thu, May 04, 2017 at 10:14:26AM +0300, Jyri Sarha wrote: Add standard optinal property blobs for

Re: [PATCH RFC 3/6] drm: Plane YCbCr to RGB conversion related properties

Regards Shashank On 4/26/2017 6:26 PM, Jyri Sarha wrote: On 04/24/17 19:55, Ville Syrjälä wrote: In fact we have plane specific YCbCr to RGB CSC (only preoffset possible), then (per crtc) gamma table, and finally a (per crtc) RGB to YCbCr CSC with optional post offset (so it can be used

Re: [PATCH RFC 3/6] drm: Plane YCbCr to RGB conversion related properties

Regards Shashank On 4/21/2017 4:47 PM, Ville Syrjälä wrote: On Fri, Apr 21, 2017 at 12:51:14PM +0300, Jyri Sarha wrote: Add standard properties to control YCbCr to RGB conversion in DRM planes. The created properties are stored to drm_plane object to allow different set of supported

Re: [PATCH RFC 0/6] drm: Add properties to control YCbCr to RGB conversion

Regards Shashank On 4/21/2017 3:21 PM, Jyri Sarha wrote: The series adds plane specific atomic properties to control YCbCr to RGB conversions. My intention was to try to implement the plane specific (before DEGAMMA) part of the suggestion in this dri-devel post: I would probably extend this

Re: [PATCH 04/11] drm: parse ycbcr420 vcb block

Regards Shashank On 4/8/2017 11:13 PM, Emil Velikov wrote: Hi Shashank, On 7 April 2017 at 17:39, Shashank Sharma wrote: + u64 hdmi_420_cap_map = connector->display_info.hdmi.ycbcr420_vcb_map; for (i = 0; i < len; i++) { struct

Re: [PATCH 01/11] drm: Add HDMI 2.0 VIC support for AVI info-frames

Regards Shashank On 4/10/2017 3:17 PM, Andrzej Hajda wrote: On 07.04.2017 18:39, Shashank Sharma wrote: HDMI 1.4b support the CEA video modes as per range of CEA-861-D (VIC 1-64). For any other mode, the VIC filed in AVI infoframes should be 0. HDMI 2.0 sinks, support video modes range as

Re: [PATCH 07/11] drm: set output colorspace in AVI infoframe

Regards Shashank On 4/12/2017 3:19 PM, Jose Abreu wrote: Hi Shashank, On 07-04-2017 17:39, Shashank Sharma wrote: HDMI source must set output colorspace information in AVI infoframes, so that the sink can decode upcoming frames accordingly. As this patch series is adding support for HDMI

Re: [PATCH 06/11] drm: create hdmi output property

Hello Jose, Sorry for delay in response, I was on vacation. Please find my comments inline. Regards Shashank On 4/12/2017 3:28 PM, Jose Abreu wrote: Hi Shashank, On 07-04-2017 17:39, Shashank Sharma wrote: HDMI displays can support various output types, based on the color space and

RE: [PATCH v5] drm: Add description for scdc variable

V6: https://patchwork.freedesktop.org/patch/146749/ Regards Shashank -Original Message- From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter Sent: Tuesday, March 28, 2017 9:54 AM To: Sharma, Shashank <shashank.sha...@intel.com> Cc: dri

<    1   2   3   4   5   >