Regards
Shashank
On 10/17/2016 5:55 PM, Daniel Vetter wrote:
> On Mon, Oct 17, 2016 at 05:34:36PM +0530, Shashank Sharma wrote:
>> This patch series adds 4 patches.
>> - The first two patches add aspect ratio support in DRM layes
>> - Next two patches add new aspect ratios defined in CEA-861-F
Regards
Shashank
On 10/17/2016 5:01 PM, Jose Abreu wrote:
> Hi Shashank,
>
>
> On 17-10-2016 12:32, Shashank Sharma wrote:
>> This patch series adds 4 patches.
>> - The first two patches add aspect ratio support in DRM layes
>> - Next two patches add new aspect ratios defined in CEA-861-F
>>
Please ignore this series, I mixed up one patch from LSPCON in here.
Will send the right series in few minutes.
Regards
Shashank
-Original Message-
From: Sharma, Shashank
Sent: Monday, October 17, 2016 4:52 PM
To: dri-devel at lists.freedesktop.org; jim.bride at linux.intel.com
Cc
vet...@ffwll.ch] On Behalf Of Daniel Vetter
Sent: Monday, October 17, 2016 11:33 AM
To: Jim Bride
Cc: Sharma, Shashank ; dri-devel at
lists.freedesktop.org; seanpaul at chromium.org; Jose.Abreu at synopsys.com;
Daniel Vetter ; intel-gfx at lists.freedesktop.org;
Vetter, Daniel
Subject: Re: [Intel-
.
Will keep you in CC.
I am planning to send a new patch set by tonight.
Regards
Shashank
-Original Message-
From: daniel.vetter at ffwll.ch [mailto:daniel.vet...@ffwll.ch] On Behalf Of
Daniel Vetter
Sent: Tuesday, August 9, 2016 7:14 PM
To: Jose Abreu
Cc: Sharma, Shashank ; Emil Velikov
Regards
Shashank
On 8/4/2016 9:39 PM, Daniel Vetter wrote:
> On Thu, Aug 04, 2016 at 03:31:45PM +0100, Emil Velikov wrote:
>> On 4 August 2016 at 14:15, Sharma, Shashank
>> wrote:
>>> On 8/4/2016 5:04 PM, Emil Velikov wrote:
>>>> On 4 August 2016 at
Regards
Shashank
On 8/4/2016 7:46 PM, Jose Abreu wrote:
> Hi Sharma,
>
>
> On 03-08-2016 16:47, Sharma, Shashank wrote:
>> Hello Joes,
>>> I've also seen this before and I am using them in order to pass HDMI
>>> compliance. Without
>>> these patche
Regards
Shashank
On 8/4/2016 5:04 PM, Emil Velikov wrote:
> On 4 August 2016 at 11:16, Sharma, Shashank
> wrote:
>> Hello Emil,
>>
>> Thanks for your time.
>>
>> I have got mixed opinion on this.
>>
>> IMHO we should expose them to userspa
Thanks Daniel.
My comments, inline.
Regards
Shashank
On 8/4/2016 4:06 PM, Daniel Vetter wrote:
> On Thu, Aug 04, 2016 at 03:46:09PM +0530, Sharma, Shashank wrote:
>> Hello Emil,
>>
>> Thanks for your time.
>>
>> I have got mixed opinion on this.
>>
>>
Hello Emil,
Thanks for your time.
I have got mixed opinion on this.
IMHO we should expose them to userspace too, as UI agents like Hardware
composer/X/Wayland must know what does these
flags means, so that they can display them on the end user screen (like
settings menu)
But few people even
Regards
Shashank
On 8/3/2016 11:14 PM, Sean Paul wrote:
> On Wed, Aug 3, 2016 at 6:56 AM, Shashank Sharma
> wrote:
>> Current DRM layer functions dont parse aspect ratio information
> s/dont/don't/
Got it.
>
>> while converting a user mode->kernel mode or viceversa. This
> s/viceversa/vice
Thanks for the review, Sean.
My comments, inline.
Regards
Shashank
On 8/3/2016 11:10 PM, Sean Paul wrote:
> On Wed, Aug 3, 2016 at 6:56 AM, Shashank Sharma
> wrote:
>> This patch adds drm flag bits for aspect ratio information
>>
>> Currently drm flag bits don't have field for mode's picture
>>
s it would be
required for X and Wayland too, coz finally these guys issue the modeset.
So May be X server is not handling these flags, ignoring these flags, and
sending the flagless modeset back to libdrm.
Regards
Shashank
-Original Message-
From: Jose Abreu [mailto:jose.ab...@synops
f Of Daniel Vetter
Sent: Wednesday, August 3, 2016 5:18 PM
To: Sharma, Shashank
Cc: dri-devel at lists.freedesktop.org; intel-gfx at lists.freedesktop.org;
ville.syrjala at linux.intel.com; rodrigo.vivi at gmail.com; Vetter, Daniel
Subject: Re: [PATCH 0/4]: Picture aspect ratio support in DRM lay
Reviewed-by: Shashank Sharma
Regards
Shashank
On 5/4/2016 5:15 PM, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä
>
> DP dual mode type 1 DVI adaptors aren't required to implement any
> registers, so it's a bit hard to detect them. The best way would
> be to check the state of
On 5/4/2016 5:19 PM, Ville Syrjälä wrote:
> On Wed, May 04, 2016 at 03:43:30PM +0530, Sharma, Shashank wrote:
>>
>> On 5/3/2016 12:38 AM, ville.syrjala at linux.intel.com wrote:
>>> From: Ville Syrjälä
>>>
>>> To save a bit of power, let's try to
On 5/3/2016 12:38 AM, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä
>
> DP dual mode type 1 DVI adaptors aren't required to implement any
> registers, so it's a bit hard to detect them. The best way would
> be to check the state of the CONFIG1 pin, but we have no way to
> do
On 5/3/2016 12:38 AM, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä
>
> To save a bit of power, let's try to turn off the TMDS output buffers
> in DP++ adaptors when we're not driving the port.
>
> v2: Let's not forget DDI, toss in a debug message while at it
> v3: Just do the
Reviewed-by: Shashank Sharma
Regards
Shashank
On 5/3/2016 12:38 AM, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä
>
> Try to detect the max TMDS clock limit for the DP++ adaptor (if any)
> and take it into account when checking the port clock.
>
> Note that as with the sink
On 5/3/2016 12:38 AM, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä
>
> Add a helper which aids in the identification of DP dual mode
> (aka. DP++) adaptors. There are several types of adaptors
> specified: type 1 DVI, type 1 HDMI, type 2 DVI, type 2 HDMI
>
> Type 1 adaptors
Thanks for the review Daniel.
My comments inline.
Regards
Shashank
On 4/21/2016 8:34 PM, Daniel Vetter wrote:
> On Fri, Mar 25, 2016 at 01:47:35PM +0530, Shashank Sharma wrote:
>> HDMI 2.0/CEA-861-F introduces two new aspect ratios:
>> - 64:27
>> - 256:135
>>
>> This patch adds support for these
No problems, I guessed the mail situation :)
Regards
Shashank
-Original Message-
From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter
Sent: Monday, February 29, 2016 9:12 PM
To: Sharma, Shashank
Cc: Daniel Vetter; Ville Syrjälä; Oleksandr Natalenko; Vetter
Please see the latest mail chain, Sonika has already started on it.
Regards
Shashank
-Original Message-
From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter
Sent: Monday, February 29, 2016 8:44 PM
To: Sharma, Shashank
Cc: Ville Syrjälä; Oleksandr Natalenko
: Tuesday, February 23, 2016 8:38 PM
To: Oleksandr Natalenko
Cc: Vetter, Daniel; intel-gfx at lists.freedesktop.org; dri-devel at
lists.freedesktop.org; linux-kernel at vger.kernel.org; Daniel Vetter; Jindal,
Sonika; Sharma, Shashank; Wang, Gary C
Subject: Re: [REGRESSION] i915: No HDMI output
I checked locally in BDC,
Seems we don't have these boards available with us (in working state).
Regards
Shashank
-Original Message-
From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com]
Sent: Tuesday, February 09, 2016 11:53 PM
To: Sharma, Shashank
Cc: Nick Bowler; Daniel
?
Regards
Shashank
-Original Message-
From: Nick Bowler [mailto:nbow...@draconx.ca]
Sent: Tuesday, February 09, 2016 10:03 PM
To: Jindal, Sonika
Cc: linux-kernel at vger.kernel.org; dri-devel at lists.freedesktop.org; Daniel
Vetter; Sharma, Shashank
Subject: Re: PROBLEM: Intel HDMI output
Thanks for the suggestion. I will check with Thierrey also.
Regards
Shashank
-Original Message-
From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com]
Sent: Thursday, October 29, 2015 6:48 PM
To: Sharma, Shashank
Cc: Lespiau, Damien; Jani Nikula; intel-gfx at lists.freedesktop.org
Thanks Daniel, Rob, for providing the clarification.
Jim, Does this sound good to you, now ?
Regards
Shashank
-Original Message-
From: Bradford, Robert
Sent: Thursday, October 22, 2015 5:36 PM
To: Bish, Jim; Sharma, Shashank
Cc: Palleti, Avinash Reddy; kausalmalladi at gmail.com; intel
in count.
Please have a look.
Regards
Shashank
-Original Message-
From: Sharma, Shashank
Sent: Tuesday, October 20, 2015 1:46 PM
To: 'Daniel Vetter'; Smith, Gary K
Cc: Bish, Jim; dri-devel at lists.freedesktop.org; intel-gfx at
lists.freedesktop.org; emil.l.velikov at gmail.com; Roper
Message-
From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter
Sent: Tuesday, October 20, 2015 12:58 PM
To: Smith, Gary K
Cc: Daniel Vetter; Bish, Jim; Sharma, Shashank; dri-devel at
lists.freedesktop.org; intel-gfx at lists.freedesktop.org; emil.l.velikov at
gmail.com
; Daniel Vetter
Cc: Bish, Jim; Sharma, Shashank; dri-devel at lists.freedesktop.org; intel-gfx
at lists.freedesktop.org; emil.l.velikov at gmail.com; Roper, Matthew D;
Bradford, Robert; kausalmalladi at gmail.com; Vetter, Daniel; Gilliam, Amy
Subject: RE: [Intel-gfx] [PATCH v6 14/23] drm/i915: CHV: Pipe
Regards
Shashank
On 10/13/2015 7:29 PM, Emil Velikov wrote:
> On 13 October 2015 at 14:40, Sharma, Shashank
> wrote:
>
>> I am not sure if I915 follows a general rule of using for(...) over while(),
>> coz I see many instances of using a while in i915_gem, i915_drv
Regards
Shashank
On 10/13/2015 7:15 PM, Emil Velikov wrote:
> On 10 October 2015 at 06:34, Sharma, Shashank
> wrote:
>> On 10/10/2015 5:24 AM, Emil Velikov wrote:
>>>
>>> Hi Shashank,
>>>
>>> On 9 October 2015 at 20:29, Shashank Sharma
>
Regards
Shashank
On 10/13/2015 7:03 PM, Emil Velikov wrote:
> On 10 October 2015 at 06:26, Sharma, Shashank
> wrote:
>> On 10/10/2015 5:13 AM, Emil Velikov wrote:
>>>
>>> On 9 October 2015 at 20:29, Shashank Sharma
>>> wrote:
>>>>
>>>
Regards
Shashank
On 10/13/2015 6:53 PM, Emil Velikov wrote:
> On 10 October 2015 at 06:21, Sharma, Shashank
> wrote:
>> On 10/10/2015 5:09 AM, Emil Velikov wrote:
>>>
>>> Hi Shashank,
>>>
>>> On 9 October 2015 at 20:29, Shashank S
Regards
Shashank
On 10/13/2015 6:47 PM, Emil Velikov wrote:
> On 10 October 2015 at 06:20, Sharma, Shashank
> wrote:
>> On 10/10/2015 4:54 AM, Emil Velikov wrote:
>>>
>>> Hi Shashank,
>>>
>>> On 9 October 2015 at 20:29, Shashank Sharma
>&
Regards
Shashank
On 10/13/2015 6:38 PM, Emil Velikov wrote:
> On 10 October 2015 at 06:09, Sharma, Shashank
> wrote:
>> On 10/10/2015 4:37 AM, Emil Velikov wrote:
>>>
>>> Hi Shashank,
>>>
>>> On 9 October 2015 at 20:29, Shashank Sharma
&g
Regards
Shashank
On 10/13/2015 6:33 PM, Emil Velikov wrote:
> On 10 October 2015 at 06:01, Sharma, Shashank
> wrote:
>> On 10/10/2015 3:51 AM, Emil Velikov wrote:
>>>
>>> Hi Shashank,
>>>
>>> On 9 October 2015 at 20:29, Shashank Sharma
Thanks for the review Emil.
Please find my comments inline
Regards
Shashank
On 10/13/2015 6:29 PM, Emil Velikov wrote:
> On 10 October 2015 at 05:55, Sharma, Shashank
> wrote:
>> On 10/10/2015 4:17 AM, Emil Velikov wrote:
>>>
>>> Hi Shashank,
>>>
>>
Regards
Shashank
On 10/12/2015 11:43 PM, Rob Bradford wrote:
> On Sat, 2015-10-10 at 00:59 +0530, Shashank Sharma wrote:
>> I915 color manager registers pipe degamma correction as palette
>> correction before CTM, DRM property.
>>
>> This patch adds the no of coefficients(65) for degamma
Regards
Shashank
On 10/12/2015 11:39 PM, Rob Bradford wrote:
> On Sat, 2015-10-10 at 00:59 +0530, Shashank Sharma wrote:
>> BDW/SKL/BXT platforms support various Gamma correction modes
>> which are:
>> 1. Legacy 8-bit mode
>> 2. 10-bit Split Gamma mode
>> 3. 12-bit mode
>>
>> This patch does the
Thanks for the review Rob.
Regards
Shashank
On 10/12/2015 11:38 PM, Rob Bradford wrote:
> On Sat, 2015-10-10 at 00:59 +0530, Shashank Sharma wrote:
>> BDW/SKL/BXT supports Degamma color correction feature, which
>> linearizes the non-linearity due to gamma encoded color values.
>> This will be
l Velikov [mailto:emil.l.veli...@gmail.com]
Sent: Tuesday, October 13, 2015 7:24 PM
To: Sharma, Shashank
Cc: Matheson, Annie J; Bradford, Robert; Palleti, Avinash Reddy; intel-gfx at
lists.freedesktop.org; ML dri-devel; Mukherjee, Indranil; Bish, Jim; Barnes,
Jesse; Smith, Gary K; Kausal Malladi; Vette
Regards
Shashank
On 10/10/2015 5:24 AM, Emil Velikov wrote:
> Hi Shashank,
>
> On 9 October 2015 at 20:29, Shashank Sharma
> wrote:
>> BDW/SKL/BXT support Color Space Conversion (CSC) using a 3x3 matrix
>> that needs to be programmed into respective CSC registers.
>>
>> This patch does the
Regards
Shashank
On 10/10/2015 5:19 AM, Emil Velikov wrote:
> Hi Shashank,
>
> On 9 October 2015 at 20:29, Shashank Sharma
> wrote:
>> BDW/SKL/BXT supports Degamma color correction feature, which
>> linearizes the non-linearity due to gamma encoded color values.
>> This will be applied before
Regards
Shashank
On 10/10/2015 5:15 AM, Emil Velikov wrote:
> On 9 October 2015 at 20:29, Shashank Sharma
> wrote:
>> Function intel_attach_color_properties_to_crtc attaches a
>> color property to its CRTC object. This patch calls this
>> function from crtc initialization sequence.
>>
>>
Regards
Shashank
On 10/10/2015 5:13 AM, Emil Velikov wrote:
> On 9 October 2015 at 20:29, Shashank Sharma
> wrote:
>> CHV/BSW supports Color Space Conversion (CSC) using a 3x3 matrix
>> that needs to be programmed into CGM (Color Gamut Mapping) registers.
>>
>> This patch does the following:
>>
Regards
Shashank
On 10/10/2015 5:09 AM, Emil Velikov wrote:
> Hi Shashank,
>
> On 9 October 2015 at 20:29, Shashank Sharma
> wrote:
> [snip]
>> diff --git a/drivers/gpu/drm/i915/intel_color_manager.c
>> b/drivers/gpu/drm/i915/intel_color_manager.c
>> index d5315b2..74f8fc3 100644
>> ---
Regards
Shashank
On 10/10/2015 4:54 AM, Emil Velikov wrote:
> Hi Shashank,
>
> On 9 October 2015 at 20:29, Shashank Sharma
> wrote:
>> The color correction blob values are loaded during set_property
>> calls. This patch adds a function to find the blob and apply the
>> correction values to the
Regards
Shashank
On 10/10/2015 4:41 AM, Emil Velikov wrote:
> Hi Shashank,
>
> On 9 October 2015 at 20:29, Shashank Sharma
> wrote:
>> CHV/BSW supports Degamma color correction, which linearizes all
>> the non-linear color values. This will be applied before Color
>> Transformation.
>>
>> This
Regards
Shashank
On 10/10/2015 4:37 AM, Emil Velikov wrote:
> Hi Shashank,
>
> On 9 October 2015 at 20:29, Shashank Sharma
> wrote:
>> CHV/BSW platform supports two different pipe level gamma
>> correction modes, which are:
>> 1. Legacy 8-bit mode
>> 2. 10-bit CGM (Color Gamut Mapping) mode
>>
Regards
Shashank
On 10/10/2015 3:51 AM, Emil Velikov wrote:
> Hi Shashank,
>
> On 9 October 2015 at 20:29, Shashank Sharma
> wrote:
>> From DRM color management:
>>
>> DRM color manager supports these color properties:
>> 1. "ctm": Color transformation matrix
Regards
Shashank
On 10/10/2015 4:17 AM, Emil Velikov wrote:
> Hi Shashank,
>
> On 9 October 2015 at 20:28, Shashank Sharma
> wrote:
> [snip]
>> +
>> +/* Color management bit utilities */
>> +#define GET_BIT_MASK(n) ((1 << n) - 1)
>> +
>> +/* Read bits of a word from bit no. 'start'(lsb) till
Regards
Shashank
On 10/10/2015 3:55 AM, Emil Velikov wrote:
> Hi Shashank,
>
> On 9 October 2015 at 20:28, Shashank Sharma
> wrote:
>> As per DRM color manager design, if a userspace wants to set a correction
>> blob, it prepares it and sends the blob_id to kernel via set_property
>> call. DRM
Thanks for the review comments, Emil.
Regards
Shashank
On 10/10/2015 3:53 AM, Emil Velikov wrote:
> Hi Shashank,
>
> On 9 October 2015 at 20:28, Shashank Sharma
> wrote:
>> This patch adds new variables in CRTC state, to hold respective color
>> correction blobs. These blobs will be required
Hi Annie,
This might add a day or two, but considering this is a long weekend in India,
you can expect the patches by mid next week.
Regards
Shashank
-Original Message-
From: Matheson, Annie J
Sent: Wednesday, September 30, 2015 10:01 PM
To: Sharma, Shashank
Cc: Bradford, Robert
Hey Rob,
Thanks for the feedback, and the testing efforts.
I will check into your suggestions and get back.
Regards
Shashank
-Original Message-
From: Bradford, Robert
Sent: Wednesday, September 30, 2015 8:02 PM
To: Sharma, Shashank; Roper, Matthew D; Bish, Jim; Smith, Gary K; dri
Ok, anyways it was sounding like a good idea.
Will do the changes accordingly.
Regards
Shashank
-Original Message-
From: Roper, Matthew D
Sent: Tuesday, September 29, 2015 3:13 AM
To: Sharma, Shashank
Cc: Daniel Vetter; Bish, Jim; Bradford, Robert; Smith, Gary K; dri-devel
Matt, your opinion about this ?
Regards
Shashank
-Original Message-
From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter
Sent: Monday, September 28, 2015 12:14 PM
To: Sharma, Shashank
Cc: Daniel Vetter; Roper, Matthew D; Bish, Jim; Bradford, Robert; Smith, Gary
On 9/23/2015 1:52 PM, Sharma, Shashank wrote:
>> Since color manager properties are meant as a new standardize KMS
>> extension (we put them into the core drm_crtc_state) the get/set support
>> should also be in the core. See e.g. how the rotation property is handled
>>
Regards
Shashank
On 9/23/2015 6:19 PM, Daniel Vetter wrote:
> On Wed, Sep 23, 2015 at 01:45:16PM +0530, Sharma, Shashank wrote:
>> Regards
>> Shashank
>>
>> On 9/22/2015 6:38 PM, Daniel Vetter wrote:
>>> On Wed, Sep 16, 2015 at 11:07:01PM +0530, Shashank Sha
Regards
Shashank
On 9/22/2015 6:57 PM, Daniel Vetter wrote:
> On Wed, Sep 16, 2015 at 11:06:57PM +0530, Shashank Sharma wrote:
>> This patch set adds Color Manager implementation in DRM layer. Color Manager
>> is an extension in DRM framework to support color correction/enhancement.
>>
>> Various
Regards
Shashank
On 9/22/2015 6:54 PM, Daniel Vetter wrote:
> On Wed, Sep 16, 2015 at 11:07:06PM +0530, Shashank Sharma wrote:
>> DRM color manager contains these color properties:
>>
>> 1. "crtc_palette_capabilities_property": to allow a
>> core driver to load and showcase its color correction
Regards
Shashank
On 9/22/2015 6:45 PM, Daniel Vetter wrote:
> On Wed, Sep 16, 2015 at 11:07:07PM +0530, Shashank Sharma wrote:
>> I915 driver registers gamma correction as palette correction
>> property with DRM layer. This patch adds set_property() and get_property()
>> handlers for pipe level
Regards
Shashank
On 9/22/2015 6:38 PM, Daniel Vetter wrote:
> On Wed, Sep 16, 2015 at 11:07:02PM +0530, Shashank Sharma wrote:
>> From: Kausal Malladi
>>
>> Color Manager framework defines a color correction property for color
>> space transformation and Gamut mapping. This property is called
Regards
Shashank
On 9/22/2015 6:38 PM, Daniel Vetter wrote:
> On Wed, Sep 16, 2015 at 11:07:01PM +0530, Shashank Sharma wrote:
>> From: Kausal Malladi
>>
>> This patch adds new structures in DRM layer for Palette color
>> correction.These structures will be used by user space agents
>> to
Hi Matt, Daniel
Addressing the review comments from both of you here.
Regards
Shashank
On 9/22/2015 6:32 PM, Daniel Vetter wrote:
> On Wed, Sep 16, 2015 at 10:51:31AM -0700, Matt Roper wrote:
>> On Wed, Sep 16, 2015 at 11:06:59PM +0530, Shashank Sharma wrote:
>>> From: Kausal Malladi
>>>
>>>
Sent: Wednesday, September 23, 2015 3:17 PM
To: Sharma, Shashank; Daniel Vetter; Roper, Matthew D
Cc: Matheson, Annie J; Bradford, Robert; Palleti, Avinash Reddy; intel-gfx at
lists.freedesktop.org; dri-devel at lists.freedesktop.org; Mukherjee, Indranil;
Bish, Jim; kausalmalladi at gmail.com; Vetter
Sure Matt,
We are planning to add documentation for color properties, as suggested by you
and Daniel.
Regards
Shashank
-Original Message-
From: Roper, Matthew D
Sent: Wednesday, September 16, 2015 11:21 PM
To: Sharma, Shashank
Cc: Bish, Jim; Bradford, Robert; Smith, Gary K; dri-devel
Regards
Shashank
On 9/21/2015 10:16 PM, Ville Syrjälä wrote:
> On Wed, Sep 16, 2015 at 11:07:01PM +0530, Shashank Sharma wrote:
>> From: Kausal Malladi
>>
>> This patch adds new structures in DRM layer for Palette color
>> correction.These structures will be used by user space agents
>> to
Regards
Shashank
On 8/22/2015 4:11 AM, Matt Roper wrote:
> On Thu, Aug 06, 2015 at 10:08:24PM +0530, Shashank Sharma wrote:
>> From: Kausal Malladi
>>
>> This patch initializes gamma color correction proeprty
>
>
Regards
Shashank
On 8/22/2015 4:11 AM, Matt Roper wrote:
> On Thu, Aug 06, 2015 at 10:08:18PM +0530, Shashank Sharma wrote:
>> From: Kausal Malladi
>>
>> CHV/BSW platform supports two different pipe level gamma
>> correction modes, which are:
>> 1. Legacy 8-bit mode
>> 2. 10-bit CGM (Color Gamut
Regards
Shashank
On 8/22/2015 4:10 AM, Matt Roper wrote:
> On Thu, Aug 06, 2015 at 10:08:17PM +0530, Shashank Sharma wrote:
>> From: Kausal Malladi
>>
>> I915 driver registers gamma correction as palette correction
>> property with DRM layer. This patch adds set_property() and get_property()
>>
Regards
Shashank
On 8/22/2015 4:10 AM, Matt Roper wrote:
> On Thu, Aug 06, 2015 at 10:08:15PM +0530, Shashank Sharma wrote:
>> From: Kausal Malladi
>>
>> This patch adds new variables in CRTC state, to hold respective color
>> correction blobs. These blobs will be required during the atomic
Regards
Shashank
On 8/22/2015 4:10 AM, Matt Roper wrote:
> On Thu, Aug 06, 2015 at 10:08:14PM +0530, Shashank Sharma wrote:
>> From: Kausal Malladi
>>
>> As per Color Manager design, each driver is responsible to load its
>> palette color correction and enhancement capabilities in the form of
>>
Thanks for the review Matt.
Regards
Shashank
On 8/22/2015 4:10 AM, Matt Roper wrote:
> On Thu, Aug 06, 2015 at 10:08:12PM +0530, Shashank Sharma wrote:
>> From: Kausal Malladi
>>
>> This patch adds atomic get property interface for Intel CRTC. This
>> interface will be used for get operation on
We have already added a patch, in I915 driver, which caches the EDID, in
connector, and releases it only after a hot unplug.
The patch is under review, but may be the same logic can be reused here.
The problem is, every time we have a connector->detect() call, most of the
driver re-read the
; Sharma, Shashank
Subject: Re: [PATCH 02/16] drm: Create Color Management DRM properties
On Wed, Jul 15, 2015 at 06:39:26PM +0530, Kausal Malladi wrote:
[...]
> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index
> 57ca8cc..408d39a 100644
> --- a/include/drm/drm_crtc.
: Hans Verkuil [mailto:hverk...@xs4all.nl]
Sent: Friday, June 26, 2015 5:27 PM
To: Sharma, Shashank; 'robdclark at gmail.com'; 'alexander.deucher at amd.com';
'bskeggs at redhat.com'; dri-devel at lists.freedesktop.org
Cc: Matheson, Annie J; R, Dhanya p; Pillai, Manikandan K; Mukherjee, Indranil
the patches.
We will wait for few more days, and then as you suggested, we will send the
patch series with design explained in the cover-letter itself.
Regards
Shashank
-Original Message-
From: Emil Velikov [mailto:emil.l.veli...@gmail.com]
Sent: Friday, June 26, 2015 4:12 PM
To: Sharma, Shashank
Gentle reminder for the review and comments.
For those who prefer having the design available with the mail, I am attaching
a PDF copy of the design document with this mail.
It would be great for us to hear from you guys, on this.
Regards
Shashank
From: Sharma, Shashank
Sent: Monday, June 22
Hi Rob, Alex, Ben, All :)
I am Shashank Sharma, from Linux display team Intel, Bangalore.
We are planning to add a color management extension in the existing I915
driver, for Intel HWs.
Plan was to provide a color correction and enhancement interface for any Linux
based userspace, based on
, 2015 2:00 AM
To: Daniel Vetter; Lespiau, Damien; Sharma, Shashank; Bhattacharjee, Susanta
Cc: Malladi, Kausal; R, Dhanya p; intel-gfx at lists.freedesktop.org; dri-devel
at lists.freedesktop.org; Purushothaman, Vijay A; Barnes, Jesse; Vetter, Daniel
Subject: RE: [Intel-gfx] [PATCH v2 00/10] Color
; Vetter, Daniel; Sharma, Shashank
Subject: Re: [PATCH v2 04/10] drm: Add Gamma correction structure
Hi Kausal Malladi,
On 5 June 2015 at 13:00, Jindal, Sonika wrote:
> On 6/4/2015 7:12 PM, Kausal Malladi wrote:
>>
>> From: Kausal Malladi
>>
...
>> v2: Addressing Da
Regards
Shashank
On 6/6/2015 11:03 AM, Jindal, Sonika wrote:
>
>
> On 6/4/2015 7:12 PM, Kausal Malladi wrote:
>> From: Kausal Malladi
>>
>> This patch does the following:
>> 1. Adds the core function to program Gamma correction values for CHV/BSW
>> platform
>> 2. Adds Gamma correction
Regards
Shashank
On 6/6/2015 6:31 AM, Matt Roper wrote:
> On Thu, Jun 04, 2015 at 07:12:37PM +0530, Kausal Malladi wrote:
>> From: Kausal Malladi
>>
>> The atomic CRTC set infrastructure is not available yet. So, the atomic
>> check path throws error for any non-plane property.
>>
>> This patch
Regards
Shashank
On 6/6/2015 6:30 AM, Matt Roper wrote:
> On Thu, Jun 04, 2015 at 07:12:36PM +0530, Kausal Malladi wrote:
>> From: Kausal Malladi
>>
>> This patch adds a new function to update color blob properties
>> and exports it.
>>
>> v2: Addressing Sonika's comment,
>> 1. Moved this
Regards
Shashank
On 6/6/2015 6:30 AM, Matt Roper wrote:
> On Thu, Jun 04, 2015 at 07:12:35PM +0530, Kausal Malladi wrote:
>> From: Kausal Malladi
>>
>> This patch adds a new structure in DRM layer for Gamma color correction.
>> This structure will be used by all user space agents to configure
>>
Thanks for your time and review Matt.
Please find my comments inline
Regards
Shashank
On 6/6/2015 6:30 AM, Matt Roper wrote:
> On Thu, Jun 04, 2015 at 07:12:32PM +0530, Kausal Malladi wrote:
>> From: Kausal Malladi
>>
>> Color Manager is an extension in i915 driver to handle color correction
>>
Hi Daniel,
Thanks for the review.
Please find my comments inline.
Regards
Shashank
On 6/2/2015 5:23 PM, Daniel Stone wrote:
> Hi,
>
> On 2 June 2015 at 12:38, Jindal, Sonika wrote:
>> On 6/2/2015 1:22 AM, Kausal Malladi wrote:
>>> +int drm_mode_crtc_update_color_property(struct drm_device
; Purushothaman, Vijay A; intel-gfx at lists.freedesktop.org;
dri-devel at lists.freedesktop.org
Cc: Vetter, Daniel; Sharma, Shashank; Kamath, Sunil; Mukherjee, Indranil;
annie.j.matherson at intel.com; R, Dhanya p; Palleti, Avinash Reddy
Subject: Re: [PATCH 5/7] drm/i915: Add pipe level Gamma
: Lespiau, Damien
Sent: Tuesday, June 02, 2015 5:31 PM
To: Malladi, Kausal
Cc: Roper, Matthew D; Barnes, Jesse; Jindal, Sonika; R, Durgadoss;
Purushothaman, Vijay A; intel-gfx at lists.freedesktop.org; dri-devel at
lists.freedesktop.org; Vetter, Daniel; Sharma, Shashank; Kamath, Sunil;
Mukherjee
platform may not be valid for other. So the
atomic modeset should have a clear idea of what is supported on which
platforms.
Thanks for your time and review.
Regards
Shashank
On 5/14/2014 9:24 PM, Thierry Reding wrote:
> On Tue, May 13, 2014 at 09:18:45AM +0530, Sharma, Shashank wrote:
>&g
Sounds good to me.
Regards
Shashank
-Original Message-
From: Thierry Reding [mailto:thierry.red...@gmail.com]
Sent: Thursday, May 15, 2014 12:36 PM
To: Sharma, Shashank
Cc: Daniel Vetter; intel-gfx; dri-devel; Purushothaman, Vijay A; Mukherjee,
Indranil; Shankar, Uma; Jindal, Sonika
Daniel,
Please find my comments inline.
Regards
Shashank
On 5/12/2014 8:58 PM, Daniel Vetter wrote:
> On Mon, May 12, 2014 at 05:35:13PM +0530, Sharma, Shashank wrote:
>> Thanks for your time and the comments David.
>> please find mine inline.
>>
>> Regards
>>
Thanks for your time and the comments David.
please find mine inline.
Regards
Shashank
On 5/12/2014 5:20 PM, David Herrmann wrote:
> Hi
>
> On Mon, May 12, 2014 at 12:26 PM, Sharma, Shashank
> wrote:
>> Benefits of using color manager:
>> ===
all the properties we already have.
>
> What's the technical reasons for adding this interface? Your proposal
> is only describing how it works, so is lacking this crucial
> information.
> -Daniel
>
> On Wed, May 7, 2014 at 4:22 PM, Sharma, Shashank
> wrote:
>> He
Thanks again David,
Comments inline.
Regards
Shashank
-Original Message-
From: David Herrmann [mailto:dh.herrm...@gmail.com]
Sent: Tuesday, April 22, 2014 5:10 PM
To: Sharma, Shashank
Cc: intel-gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org;
Ville Syrj?l?; Thierry
Thanks for the review and comments David.
Please find my comments inline.
Regards
Shashank
-Original Message-
From: David Herrmann [mailto:dh.herrm...@gmail.com]
Sent: Tuesday, April 22, 2014 3:08 PM
To: Sharma, Shashank
Cc: intel-gfx at lists.freedesktop.org; dri-devel
Gentle reminder
Regards
Shashank
-Original Message-
From: Sharma, Shashank
Sent: Friday, April 18, 2014 12:01 PM
To: intel-gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org;
Ville Syrj?l?; Thierry Reding; Alex Deucher; Sean Paul; robdclark at gmail.com
Cc: Shankar, Uma
301 - 400 of 406 matches
Mail list logo
