[PATCH 7/8] ASoC: fsl_spdif: fix struct clk pointer comparing

2015-02-26 Thread Shawn Guo
On Thu, Feb 26, 2015 at 11:12:50AM +0900, Mark Brown wrote: > On Wed, Feb 25, 2015 at 10:53:37PM +0800, Shawn Guo wrote: > > Since commit 035a61c314eb ("clk: Make clk API return per-user struct clk > > instances"), clk API users can no longer check if two struct clk

Re: [PATCH] drm-misc: Next phase in small drivers in drm-misc

2017-03-29 Thread Shawn Guo
> Cc: Neil Armstrong <narmstr...@baylibre.com> > Cc: Mark Yao <mark@rock-chips.com> > Cc: Eric Anholt <e...@anholt.net> > Cc: Shawn Guo <shawn...@kernel.org> Acked-by: Shawn Guo <shawn...@kernel.org> > Cc: Dave Airlie <airl...@redhat.com>

[PATCH] drm: zte: remove leftover 'inf' from struct zx_hdmi

2017-03-21 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> There is a leftover 'inf' field in struct zx_hdmi from commit '831a8d5e0bef ("drm: zte: move struct vou_inf into zx_vou driver")'. Remove it. Signed-off-by: Shawn Guo <shawn@linaro.org> --- drivers/gpu/drm/zte/zx_hdmi.c |

Re: [PATCH V4] dts/imx6q-b850v3: Use megachips-stdpxxxx-ge-b850v3-fw bridges (LVDS-DP++)

2017-03-16 Thread Shawn Guo
On Tue, Mar 14, 2017 at 10:23:02AM +0100, Peter Senna Tschudin wrote: > Configures the megachips-stdp-ge-b850v3-fw bridges on the GE > B850v3 dts file. > > Cc: Laurent Pinchart > Cc: Martyn Welch > Cc: Martin Donnelly

Re: [PATCH] drm: zte: remove leftover 'inf' from struct zx_hdmi

2017-03-22 Thread Shawn Guo
On Tue, Mar 21, 2017 at 04:59:55PM +0800, Shawn Guo wrote: > From: Shawn Guo <shawn@linaro.org> > > There is a leftover 'inf' field in struct zx_hdmi from commit > '831a8d5e0bef ("drm: zte: move struct vou_inf into zx_vou driver")'. > Remove it. >

[PATCH 4/4] drm: zte: add VGA driver support

2017-03-21 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> It adds VGA driver support, which needs to configure corresponding VOU interface in RGB_888 format, and thus the following changes are needed on zx_vou. - Rename the CSC block of Graphic Layer a bit to make it more specific, and add CSC of C

[PATCH 2/4] drm: zte: move CSC register definitions into a common header

2017-03-21 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The CSC (Color Space Conversion) block in VOU is used by not only Graphic Layer (plane) but also channel (CRTC) module. Let's move its register definitions into a common header, so that CRTC driver can include it when needed. Signed-off-by: Sha

[PATCH 0/4] Add ZTE VGA driver support

2017-03-21 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The series adds the driver for ZTE VGA device, which becomes the third VOU output device we support, besides the existing HDMI and TV Encoder. Shawn Guo (4): drm: zte: do not enable clock auto-gating by default drm: zte: move CSC register defin

[PATCH 3/4] dt: add bindings for ZTE VGA device

2017-03-21 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> It adds bindings doc for ZTE VOU VGA output device. Signed-off-by: Shawn Guo <shawn@linaro.org> --- .../devicetree/bindings/display/zte,vou.txt | 21 + 1 file changed, 21 insertions(+) diff --git a/Documentatio

[PATCH 1/4] drm: zte: do not enable clock auto-gating by default

2017-03-21 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> Some VOU modules do not work well with clock auto-gating. For example, VGA I2C bus will fail to read EDID data from monitor. Let's not enable this feature by default, and leave it to the possible future low-power optimization. Signed-off-by: Sha

Re: [PATCH 4/4] drm: zte: add VGA driver support

2017-04-04 Thread Shawn Guo
On Mon, Apr 03, 2017 at 11:23:51AM +0200, Daniel Vetter wrote: > > +static int zx_vga_ddc_register(struct zx_vga *vga) > > +{ > > + struct device *dev = vga->dev; > > + struct i2c_adapter *adap; > > + struct zx_vga_i2c *ddc; > > + int ret; > > + > > + ddc = devm_kzalloc(dev,

[PATCH v2 0/4] Add ZTE VGA driver support

2017-04-06 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The series adds the driver for ZTE VGA device, which becomes the third VOU output device we support, besides the existing HDMI and TV Encoder. Changes for v2: - Add return check for encoder and connector init function calls. - Improve comments in fu

[PATCH v2 4/4] drm: zte: add VGA driver support

2017-04-06 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> It adds VGA driver support, which needs to configure corresponding VOU interface in RGB_888 format, and thus the following changes are needed on zx_vou. - Rename the CSC block of Graphic Layer a bit to make it more specific, and add CSC of C

[PATCH v2 1/4] drm: zte: do not enable clock auto-gating by default

2017-04-06 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> Some VOU modules do not work well with clock auto-gating. For example, VGA I2C bus will fail to read EDID data from monitor. Let's not enable this feature by default, and leave it to the possible future low-power optimization. Signed-off-by: Sha

[PATCH v2 2/4] drm: zte: move CSC register definitions into a common header

2017-04-06 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The CSC (Color Space Conversion) block in VOU is used by not only Graphic Layer (plane) but also channel (CRTC) module. Let's move its register definitions into a common header, so that CRTC driver can include it when needed. Signed-off-by: Sha

[PATCH v2 3/4] dt-bindings: display: add support for ZTE VGA device

2017-04-06 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> It adds bindings doc for ZTE VOU VGA output device. Signed-off-by: Shawn Guo <shawn@linaro.org> --- .../devicetree/bindings/display/zte,vou.txt | 21 + 1 file changed, 21 insertions(+) diff --git a/Documentatio

Re: [PATCH 4/4] drm: zte: add VGA driver support

2017-04-05 Thread Shawn Guo
On Tue, Apr 04, 2017 at 01:46:48PM -0400, Sean Paul wrote: > > +static int zx_vga_register(struct drm_device *drm, struct zx_vga *vga) > > +{ > > + struct drm_encoder *encoder = >encoder; > > + struct drm_connector *connector = >connector; > > + > > + encoder->possible_crtcs = VOU_CRTC_MASK;

[PATCH v3 4/4] drm: zte: add VGA driver support

2017-04-11 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> It adds VGA driver support, which needs to configure corresponding VOU interface in RGB_888 format, and thus the following changes are needed on zx_vou. - Rename the CSC block of Graphic Layer a bit to make it more specific, and add CSC of C

Re: [PATCH v2 4/4] drm: zte: add VGA driver support

2017-04-11 Thread Shawn Guo
On Fri, Apr 07, 2017 at 10:43:02AM -0400, Sean Paul wrote: > On Fri, Apr 07, 2017 at 11:02:33AM +0800, Shawn Guo wrote: > > When you suggested to have a lock for DETECT_SEL register access, I > > thought we are accessing it in a read-modify-write way and thus agreed > > to ad

Re: [PATCH V3 4/4] dts/imx6q-b850v3: Use megachips-stdpxxxx-ge-b850v3-fw bridges (LVDS-DP++)

2017-03-13 Thread Shawn Guo
On Fri, Mar 03, 2017 at 04:57:10PM +0100, Peter Senna Tschudin wrote: > Configures the megachips-stdp-ge-b850v3-fw bridges on the GE > B850v3 dts file. > > Cc: Laurent Pinchart > Cc: Martyn Welch > Cc: Martin Donnelly

Re: [PATCH] MAINTAINERS: Update git entries for drivers in drm-misc

2017-03-01 Thread Shawn Guo
On Tue, Feb 28, 2017 at 08:36:57PM +0100, Daniel Vetter wrote: > It's still just an experiment, but one lesson learned from drm-misc is > that not updating MAINTAINERS just leads to confusion. And this is > easy to revert. ... > Cc: Shawn Guo <shawn...@kernel.org> > Signed-

Re: [PATCH 4/4] drm: zte: add VGA driver support

2017-04-05 Thread Shawn Guo
On Tue, Apr 04, 2017 at 01:32:39PM -0400, Sean Paul wrote: > On Tue, Apr 04, 2017 at 09:47:38PM +0800, Shawn Guo wrote: > > On Mon, Apr 03, 2017 at 11:23:51AM +0200, Daniel Vetter wrote: > > > > +static int zx_vga_ddc_register(struct zx_vga *vga) > > > > +{ > &g

Re: [PATCH v2 4/4] drm: zte: add VGA driver support

2017-04-06 Thread Shawn Guo
On Thu, Apr 06, 2017 at 01:12:51PM -0400, Sean Paul wrote: > On Thu, Apr 06, 2017 at 11:01:10PM +0800, Shawn Guo wrote: > > +static int zx_vga_connector_get_modes(struct drm_connector *connector) > > +{ > > + struct zx_vga *vga = to_zx_vga(connector); > > + unsigned

Re: [PATCH 7/8] drm: Nuke drm_atomic_helper_connector_dpms

2017-07-25 Thread Shawn Guo
| 1 - > drivers/gpu/drm/zte/zx_vga.c | 1 - Acked-by: Shawn Guo <shawn...@kernel.org> ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 20/41] drm/zte: Use .dumb_map_offset and .dumb_destroy defaults

2017-07-25 Thread Shawn Guo
On Sun, Jul 23, 2017 at 09:16:36PM +0200, Noralf Trønnes wrote: > This driver can use the drm_driver.dumb_destroy and > drm_driver.dumb_map_offset defaults, so no need to set them. > > Cc: Shawn Guo <shawn...@kernel.org> Acked-by: Shawn Guo <shawn...@kernel.org> > Si

Re: [PATCH v3 21/22] drm/zte: Use drm_gem_fb_create()

2017-08-17 Thread Shawn Guo
On Sun, Aug 13, 2017 at 03:32:04PM +0200, Noralf Trønnes wrote: > drm_fb_cma_create() is just a wrapper around drm_gem_fb_create() now, > so use the function directly. > > Cc: Shawn Guo <shawn...@kernel.org> > Signed-off-by: Noralf Trønnes <nor...@tronnes.org>

Re: [PATCH 12/13] drm/zte: Drop drm_vblank_cleanup

2017-06-21 Thread Shawn Guo
On Wed, Jun 21, 2017 at 10:28:49AM +0200, Daniel Vetter wrote: > It again looks all cargo-culted for no good reasons. > > Cc: Shawn Guo <shawn...@kernel.org> > Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> Acked-by: Shawn

Re: [PATCH 36/37] drm/zte: Drop drm_vblank_cleanup

2017-05-26 Thread Shawn Guo
On Fri, May 26, 2017 at 08:57:32AM +0200, Daniel Vetter wrote: > On Thu, May 25, 2017 at 5:01 AM, Shawn Guo <shawn...@kernel.org> wrote: > > On Wed, May 24, 2017 at 04:52:11PM +0200, Daniel Vetter wrote: > >> It again looks all cargo-culted for no good reasons. &g

Re: [PATCH 36/37] drm/zte: Drop drm_vblank_cleanup

2017-05-24 Thread Shawn Guo
On Wed, May 24, 2017 at 04:52:11PM +0200, Daniel Vetter wrote: > It again looks all cargo-culted for no good reasons. drm_vblank_cleanup() is called to release the resources allocated by drm_vblank_init(). I think that's the reason, no? Shawn > > Cc: Shawn Guo <shawn...@kernel.o

Re: [PATCH 03/15] drm: zte: use devm_of_platform_populate()

2017-06-04 Thread Shawn Guo
On Mon, May 29, 2017 at 05:45:51PM +0200, Benjamin Gaignard wrote: > Use devm_of_platform_populate() to be sure that of_platform_depopulate > is called when removing the driver. > > Signed-off-by: Benjamin Gaignard Applied to drm-misc, thanks.

Re: [PATCH v3 4/4] drm: zte: add VGA driver support

2017-05-02 Thread Shawn Guo
Hi Sean, On Tue, Apr 11, 2017 at 7:30 PM, Shawn Guo <shawn...@kernel.org> wrote: > From: Shawn Guo <shawn@linaro.org> > > It adds VGA driver support, which needs to configure corresponding VOU > interface in RGB_888 format, and thus the following changes are needed &g

Re: [PATCH 14/15] drm/zte: Use drm_mode_get_hv_timing() to populate plane clip rectangle

2017-11-28 Thread Shawn Guo
t Pinchart <laurent.pinch...@ideasonboard.com> > Cc: Shawn Guo <shawn...@kernel.org> Acked-by: Shawn Guo <shawn...@kernel.org> > Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com> ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 00/22] drm/cma-helper: Remove drm_fbdev_cma* functions

2017-11-16 Thread Shawn Guo
On Wed, Nov 15, 2017 at 03:19:39PM +0100, Noralf Trønnes wrote: > This patchset adds drm_fb_cma_fbdev_init/fini() functions that replaces > drm_fbdev_cma_init/fini(). The reason for doing so is to get rid of > struct drm_fbdev_cma and it's wrapper functions. The final piece will > happen when

Re: [PATCH v2 18/22] drm/zte: Use drm_fb_cma_fbdev_init/fini()

2017-11-17 Thread Shawn Guo
gt; Also use the drm_fb_helper functions directly. > > Cc: Shawn Guo <shawn...@kernel.org> Acked-by: Shawn Guo <shawn...@kernel.org> ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v4 0/7] Add basic support for emtrion emCON-MX6 modules

2018-04-27 Thread Shawn Guo
On Fri, Apr 27, 2018 at 03:24:35PM +0200, jan.tu...@emtrion.com wrote: > From: Jan Tuerk > > Changes for v4: > - re-arrange the Patch-series to match the DT-submitting-patches > - Additional patch for the Documentation of the new DT-bindings > > [PATCH v4 1/7]

Re: [PATCH v4 6/7] ARM: dts: Add support for emtrion emCON-MX6 series

2018-04-27 Thread Shawn Guo
On Fri, Apr 27, 2018 at 03:24:41PM +0200, jan.tu...@emtrion.com wrote: > From: Jan Tuerk > > This patch adds support for the emtrion GmbH emCON-MX6 modules. > They are available with imx.6 Solo, Dual-Lite, Dual and Quad > equipped with Memory from 512MB to 2GB (configured

Re: [PATCH v4 6/7] ARM: dts: Add support for emtrion emCON-MX6 series

2018-05-04 Thread Shawn Guo
On Thu, May 03, 2018 at 12:00:06PM +0200, Türk, Jan wrote: > > > +/ { > > > + aliases { > > > + mmc0 = > > > + mmc2 = > > > + mmc1 = > > > + mmc3 = > > > + boardID = > > > > Why do you need this boardID alias? > I wanted to have a generic

[PATCH] dma-buf/sw_sync: fix document of sw_sync_create_fence_data

2018-01-14 Thread Shawn Guo
The structure should really be sw_sync_create_fence_data rather than sw_sync_ioctl_create_fence which is the function name. Signed-off-by: Shawn Guo <shawn@linaro.org> --- drivers/dma-buf/sw_sync.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/d

Re: [PATCH 12/12] drm: zte: Use drm_atomic_helper_shutdown() to disable planes on removal

2018-02-01 Thread Shawn Guo
w consisting only of a call to drm_plane_cleanup(), replace it > with direct calls to that function. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Acked-by: Shawn Guo <shawn...@kernel.org> ___

Re: [PATCH v3 0/7] ARM: dts: imx6q: engicam LVDS panel changes

2018-02-05 Thread Shawn Guo
On Sun, Feb 04, 2018 at 11:19:24PM +0530, Jagan Teki wrote: > Series adda LVDS panel attributes on panel drivers instead of defining > them in dts nodes, and also added new icorem6 engicam boards. > > Jagan Teki (7): > drm/panel: simple: add support for Ampire AM-800480AYTZQW-00H > ARM: dts:

Re: [PATCH 5/5] drm: Don't pass clip to drm_atomic_helper_check_plane_state()

2018-02-04 Thread Shawn Guo
..@redhat.com> > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Cc: Sandy Huang <h...@rock-chips.com> > Cc: "Heiko Stübner" <he...@sntech.de> > Cc: Maxime Ripard <maxime.rip...@free-electrons.com> > Cc: Thierry Reding <thierry.red.

Re: [PATCH] fix double ;;s in code

2018-02-22 Thread Shawn Guo
Hi Pavel, On Sat, Feb 17, 2018 at 10:19:55PM +0100, Pavel Machek wrote: ... > diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c > index 53f7275..cfb42f5 100644 > --- a/drivers/soc/imx/gpc.c > +++ b/drivers/soc/imx/gpc.c > @@ -348,7 +348,7 @@ static int imx_gpc_old_dt_init(struct device

Re: [PATCH] fix double ;;s in code

2018-02-24 Thread Shawn Guo
On Sat, Feb 24, 2018 at 09:52:27AM +0100, Pavel Machek wrote: > Hi! > > > > diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c > > > index 53f7275..cfb42f5 100644 > > > --- a/drivers/soc/imx/gpc.c > > > +++ b/drivers/soc/imx/gpc.c > > > @@ -348,7 +348,7 @@ static int

Re: [PATCH] gpu: do not double put device node in zx_drm_probe

2018-08-27 Thread Shawn Guo
On Fri, Aug 17, 2018 at 10:24:06AM +0800, zhong jiang wrote: > for_each_available_child_of_node will get and put the node properly, > the following of_node_put will lead to the double put. So just > remove it. > > Signed-off-by: zhong jiang Acke

Re: [PATCH] drm/zte: Replace drm_dev_unref with drm_dev_put

2018-07-18 Thread Shawn Guo
mermann Acked-by: Shawn Guo > --- > drivers/gpu/drm/zte/zx_drm_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/zte/zx_drm_drv.c > b/drivers/gpu/drm/zte/zx_drm_drv.c > index 6f4205e80378..02ae1caf6e8a 100644 > --- a/drivers/g

Re: [PATCH v2] ARM: dts: imx6sl: Add vivante gpu nodes

2018-07-17 Thread Shawn Guo
On Fri, Jul 13, 2018 at 12:39:35PM +0300, Leonard Crestez wrote: > The imx6sl soc has gpu_2d and gpu_vg, no 3d support: > > etnaviv-gpu 220.gpu: model: GC320, revision: 5007 > etnaviv-gpu 2204000.gpu: model: GC355, revision: 1215 > > The IP blocks seem to be already supported. > >

Re: [PATCH 19/20] drm/zte: Use drm_fbdev_generic_setup()

2018-09-09 Thread Shawn Guo
his is done to highlight the fact that fbdev emulation is an > internal client that makes use of the driver, it is not part of the > driver as such. If fbdev setup fails, an error is printed, but the driver > succeeds probing. > > Cc: Shawn Guo >

Re: [PATCH] drm: zte: Fix an error handling path in 'zx_crtc_bind()'

2018-03-12 Thread Shawn Guo
ff-by: Christophe JAILLET <christophe.jail...@wanadoo.fr> Acked-by: Shawn Guo <shawn...@kernel.org> ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v3 5/6] ARM: dts: Add support for emtrion emCON-MX6 series

2018-04-23 Thread Shawn Guo
On Fri, Apr 20, 2018 at 02:50:52PM +0200, jan.tu...@emtrion.com wrote: > From: Jan Tuerk > > This patch adds support for the emtrion GmbH emCON-MX6 modules. > They are available with imx.6 Solo, Dual-Lite, Dual and Quad > equipped with Memory from 512MB to 2GB (configured

Re: [PATCH v2 13/23] drm/zte: Stop consulting plane->fb

2018-03-26 Thread Shawn Guo
t log? Other than that: Acked-by: Shawn Guo <shawn...@kernel.org> > > v2: Use old_state->crtc (Maarten) > > Cc: Shawn Guo <shawn...@kernel.org> > Cc: Maarten Lankhorst <maarten.lankho...@linux.intel.com> > Signed-off-by: Ville Syrjälä <ville.syrj...@linux

Re: [PATCH 2/3] PCI: imx: Add multi-pd support

2018-10-07 Thread Shawn Guo
On Mon, Oct 01, 2018 at 11:56:17PM +0300, Leonard Crestez wrote: > On some chips the PCIE and PCIE_PHY blocks are in separate power domains > which can be power-gated independently. The driver needs to handle this > by keeping both domain active. > > This is intended for imx6sx where PCIE is in

Re: [PATCH v2 1/4] soc: imx: gpc: Increase GPC_CLK_MAX to 7

2018-10-31 Thread Shawn Guo
On Mon, Oct 08, 2018 at 06:06:19PM +, Leonard Crestez wrote: > The DISPLAY power domain on imx6sx has 7 clocks. > > Signed-off-by: Leonard Crestez Applied, thanks. ___ dri-devel mailing list dri-devel@lists.freedesktop.org

Re: [PATCH v2 4/4] ARM: dts: imx6sx: Add DISPLAY power domain support

2018-10-31 Thread Shawn Guo
On Mon, Oct 08, 2018 at 06:06:23PM +, Leonard Crestez wrote: > This was implemented in the driver but not actually defined and > referenced in dts. This makes it always on. > > From reference manual in section "10.4.1.4.1 Power Distribution": > > "Display domain - The DISPLAY domain contains

Re: [PATCH v2 4/4] ARM: dts: imx6sx: Add DISPLAY power domain support

2018-11-03 Thread Shawn Guo
On Wed, Oct 31, 2018 at 12:17:50PM +, Leonard Crestez wrote: > On 10/31/2018 8:12 AM, Shawn Guo wrote: > > On Mon, Oct 08, 2018 at 06:06:23PM +, Leonard Crestez wrote: > >> This was implemented in the driver but not actually defined and > >> referenced i

Re: [PATCH v1 0/4] ARM: dts: ccimx6ulsbcpro: Add 10" AUO/Goodix LVDS panel accessory kit

2018-11-04 Thread Shawn Guo
On Thu, Oct 25, 2018 at 05:09:29PM +0200, Alex Gonzalez wrote: > Alex Gonzalez (4): > drm/panel: simple: Add AUO G101EVN010 panel support > ARM: dts: ccimx6ulsbcpro: Enable AUO G101EVN010 lcdif panel > ARM: imx_v6_v7_defconfig: Select TOUCHSCREEN_GOODIX > ARM: dts: ccimx6ulsbcpro: Add

Re: [PATCH 14/21] drm/zte: Use drm_atomic_helper_shutdown

2018-10-05 Thread Shawn Guo
should > use drm_atomic_helper_shutdown() instead. > > Reviewed-by: Ville Syrjälä > Signed-off-by: Daniel Vetter > Cc: Shawn Guo Acked-by: Shawn Guo ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [RESEND PATCH] drm/zte: Replace drm_dev_unref with drm_dev_put

2018-09-30 Thread Shawn Guo
ermann > Acked-by: Shawn Guo Pushed to drm-misc-next, thanks. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] gpu: do not double put device node in zx_drm_probe

2018-09-19 Thread Shawn Guo
On Tue, Sep 18, 2018 at 05:19:09PM +0200, Daniel Vetter wrote: > On Mon, Aug 27, 2018 at 9:18 AM, Shawn Guo wrote: > > On Fri, Aug 17, 2018 at 10:24:06AM +0800, zhong jiang wrote: > >> for_each_available_child_of_node will get and put the node properly, > >> the foll

Re: [PATCH v1 0/4] ARM: dts: ccimx6ulsbcpro: Add 10" AUO/Goodix LVDS panel accessory kit

2018-12-04 Thread Shawn Guo
On Thu, Oct 25, 2018 at 05:09:29PM +0200, Alex Gonzalez wrote: > Alex Gonzalez (4): > drm/panel: simple: Add AUO G101EVN010 panel support > ARM: dts: ccimx6ulsbcpro: Enable AUO G101EVN010 lcdif panel > ARM: imx_v6_v7_defconfig: Select TOUCHSCREEN_GOODIX > ARM: dts: ccimx6ulsbcpro: Add

Re: [PATCH v2 3/4] PCI: imx: Add multi-pd support

2018-11-19 Thread Shawn Guo
On Fri, Nov 16, 2018 at 12:25:41PM +, Lorenzo Pieralisi wrote: > On Mon, Oct 08, 2018 at 06:06:21PM +, Leonard Crestez wrote: > > On some chips the PCIE and PCIE_PHY blocks are in separate power domains > > which can be power-gated independently. The pci driver needs to handle > > this by

Re: [PATCH 3/9] drm: replace "drm_dev_unref" function with "drm_dev_put"

2018-11-19 Thread Shawn Guo
On Thu, Nov 15, 2018 at 11:16:23PM +0100, Fernando Ramos wrote: > This patch unifies the naming of DRM functions for reference counting as > requested on Documentation/gpu/todo.rst > > Signed-off-by: Fernando Ramos > --- > drivers/gpu/drm/arc/arcpgu_drv.c | 4 ++-- >

Re: [PATCH] ARM: imx_v6_v7_defconfig: Enable CONFIG_PWM_IMX27

2019-03-21 Thread Shawn Guo
On Thu, Mar 21, 2019 at 10:49:03AM +0100, Uwe Kleine-König wrote: > Hello, > > On Wed, Mar 20, 2019 at 01:01:26PM +, Leonard Crestez wrote: > > Commit d80f8206905c ("pwm: imx: Split into two drivers") also adds a new > > CONFIG_PWM_IMX27 for the PWM block on recent IMX chips and we should > >

Re: [PATCH 0/2] drm: imx: Add NWL MIPI DSI host controller support

2019-05-27 Thread Shawn Guo
Hi Lucas, On Mon, May 27, 2019 at 03:36:53PM +0200, Lucas Stach wrote: > We have been looking at how to support DCSS in mainline for a while, > but most of the actual work got pushed behind in schedule due to other > priorities. I have some time to contribute. Would you suggest how I should

Re: [EXT] Re: [PATCH 0/2] drm: imx: Add NWL MIPI DSI host controller support

2019-05-28 Thread Shawn Guo
Hi Laurentiu, On Tue, May 28, 2019 at 07:03:54AM +, Laurentiu Palcu wrote: > Hi Shawn, Lucas, > > On Tue, May 28, 2019 at 09:38:02AM +0800, Shawn Guo wrote: > > Caution: EXT Email > > > > Hi Lucas, > > > > On Mon, May 27, 2019 at 03:36:53PM +0200

Re: [PATCH 0/2] drm: imx: Add NWL MIPI DSI host controller support

2019-05-26 Thread Shawn Guo
On Wed, May 08, 2019 at 07:18:27PM +0200, Guido Günther wrote: > If somebody is working on DCSS support it'd be cool to know since this I have some time slots here and will start looking at it, if no one else is already working on it. Shawn > driver is currently a component of

Re: [PATCH 39/59] drm/zte: Drop drm_gem_prime_export/import

2019-06-18 Thread Shawn Guo
On Fri, Jun 14, 2019 at 10:35:55PM +0200, Daniel Vetter wrote: > They're the default. > > Aside: Would be really nice to switch the others over to > drm_gem_object_funcs. > > Signed-off-by: Daniel Vetter > Cc: Shawn Guo Acked-by: Shawn Guo > --- > drivers/g

Re: [PATCH v4 12/23] drm: zte: Provide ddc symlink in hdmi connector sysfs directory

2019-07-22 Thread Shawn Guo
On Thu, Jul 11, 2019 at 01:26:39PM +0200, Andrzej Pietrasiewicz wrote: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Acked-by: Shawn Guo ___ dri-devel mailing list dri-devel@lists.freede

Re: [PATCH v4 13/23] drm: zte: Provide ddc symlink in vga connector sysfs directory

2019-07-23 Thread Shawn Guo
On Thu, Jul 11, 2019 at 01:26:40PM +0200, Andrzej Pietrasiewicz wrote: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Acked-by: Shawn Guo ___ dri-devel mailing list dri-devel@lists.freede

Re: [PATCH v1 10/33] drm/zte: drop use of drmP.h

2019-07-18 Thread Shawn Guo
On Sun, Jun 30, 2019 at 08:18:59AM +0200, Sam Ravnborg wrote: > Drop use of the deprecated drmP.h header file. > Fix fallout. > > Signed-off-by: Sam Ravnborg > Cc: Shawn Guo > Cc: David Airlie > Cc: Daniel Vetter Acked-by: Shawn Guo

Re: [PATCH v2 2/2] dt-bindings: etnaviv: Add #cooling-cells

2019-10-06 Thread Shawn Guo
On Mon, Sep 16, 2019 at 04:32:55PM +0200, Lucas Stach wrote: > On Mi, 2019-09-11 at 19:40 -0700, Guido Günther wrote: > > Add #cooling-cells for when the gpu acts as a cooling device. > > > > Signed-off-by: Guido Günther > > Reviewed-by: Lucas Stach Lucas, I assume you will pick it up.

Re: [PATCH v2 1/2] dts: arm64: imx8mq: Enable gpu passive throttling

2019-10-06 Thread Shawn Guo
On Wed, Sep 11, 2019 at 07:40:35PM -0700, Guido Günther wrote: > Temperature and hysteresis were picked after the CPU. > > Signed-off-by: Guido Günther The patch prefix should be 'arm64: dts: ...' I fixed it up and applied the patch. Shawn > --- > arch/arm64/boot/dts/freescale/imx8mq.dtsi |

Re: [PATCH 07/11] dts: arm64: layerscape: add dma-ranges property to qoric-mc node

2019-10-14 Thread Shawn Guo
On Mon, Oct 14, 2019 at 12:00:25PM +0200, Nicolas Saenz Julienne wrote: > On Mon, 2019-10-14 at 16:28 +0800, Shawn Guo wrote: > > On Tue, Sep 24, 2019 at 08:12:38PM +0200, Nicolas Saenz Julienne wrote: > > > qoriq-mc's dpmacs DMA configuration is inherited from their parent node

Re: [PATCH 07/11] dts: arm64: layerscape: add dma-ranges property to qoric-mc node

2019-10-14 Thread Shawn Guo
On Tue, Sep 24, 2019 at 08:12:38PM +0200, Nicolas Saenz Julienne wrote: > qoriq-mc's dpmacs DMA configuration is inherited from their parent node, > which acts a bus in this regard. So far it maked all devices as > dma-coherent but no dma-ranges recommendation is made. > > The truth is that the

Re: [PATCH 08/11] dts: arm64: layerscape: add dma-ranges property to pcie nodes

2019-10-14 Thread Shawn Guo
On Tue, Sep 24, 2019 at 08:12:39PM +0200, Nicolas Saenz Julienne wrote: > The bus behind the board's PCIe core has DMA addressing limitations. Add > an empty 'dma-ranges' property on all PCIe bus descriptions to inform > the OF core that a translation is due further down the line. > >

Re: [PATCH] backlight: l4f00242t03: Convert to GPIO descriptors

2020-04-28 Thread Shawn Guo
t;enable" and "reset" as found in > the device tree bindings for panel GPIOs. > > This saves a lot of code in the driver and makes it possible > to get rid of the platform data header altogether. > > Cc: Sascha Hauer > Cc: Anson Huang > Cc: Shawn Guo > Cc:

Re: [PATCH] drivers: gpu: drm: Add MDP5 configuration for MSM8x36 and its derivatives, such as MSM8939.

2020-05-08 Thread Shawn Guo
Hi Konrad, On Fri, May 01, 2020 at 10:51:59PM +0200, Konrad Dybcio wrote: > Signed-off-by: Konrad Dybcio Please write up some commit log. Since this is based on msm8x16_config, maybe document the differences from it in commit log? > --- > drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 70

[PATCH 0/2] Add adreno a405 GPU support

2020-05-09 Thread Shawn Guo
The series adds support for adreno a405 found on MSM8936/MSM8939 and APQ variants. Shawn Guo (2): drm/msm/a4xx: add adreno a405 support drm/msm/a4xx: add a405_registers for a405 device drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 82 ++ drivers/gpu/drm/msm/adreno

Re: [Freedreno] [v2 PATCH] drivers: gpu: drm: Add MDP5 configuration for MSM8x36.

2020-05-09 Thread Shawn Guo
git log of file/folder changed here. Other than that: Reviewed-by: Shawn Guo ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 1/2] drm/msm/a4xx: add adreno a405 support

2020-05-09 Thread Shawn Guo
-by: Shawn Guo --- drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 29 +- drivers/gpu/drm/msm/adreno/adreno_device.c | 11 drivers/gpu/drm/msm/adreno/adreno_gpu.c| 2 +- drivers/gpu/drm/msm/adreno/adreno_gpu.h| 5 4 files changed, 34 insertions(+), 13

[PATCH 2/2] drm/msm/a4xx: add a405_registers for a405 device

2020-05-09 Thread Shawn Guo
adreno_gpu_init(). Signed-off-by: Shawn Guo --- drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 53 +-- 1 file changed, 50 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a4xx_gpu.c b/drivers/gpu/drm/msm/adreno/a4xx_gpu.c index 70de59751188..9e244982974e 100644

Re: [PATCH] drm/zte: remove unneeded semicolon

2020-05-19 Thread Shawn Guo
> > Signed-off-by: Jason Yan Acked-by: Shawn Guo ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 2/4] ARM: dts: ims53: Group port definitions for the dvi-converter

2020-05-19 Thread Shawn Guo
On Thu, May 14, 2020 at 04:36:10PM +0200, Ricardo Cañuelo wrote: > Group the port definitions of the dvi-converter in a 'ports' node to > make it compliant with the ti,tfp410 binding. > > Signed-off-by: Ricardo Cañuelo s/ims53/imx53-cx9020 in subject. I fixed it up and applied the patch.

Re: [PATCH v1 1/3] drm/msm: Attach the IOMMU device during initialization

2020-05-23 Thread Shawn Guo
On Fri, May 22, 2020 at 04:03:14PM -0600, Jordan Crouse wrote: > diff --git a/drivers/gpu/drm/msm/msm_gpummu.c > b/drivers/gpu/drm/msm/msm_gpummu.c > index 34980d8eb7ad..0ad0f848560a 100644 > --- a/drivers/gpu/drm/msm/msm_gpummu.c > +++ b/drivers/gpu/drm/msm/msm_gpummu.c > @@ -21,11 +21,6 @@

Re: [PATCH v1 0/3] drm/msm: Cleanups ahead of per-instance pagetables

2020-05-23 Thread Shawn Guo
ress space initialization > drm/msm: Update the MMU helper function APIs FWIW, on A405 with glmark2: Tested-by: Shawn Guo ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 08/13] arm64: dts: imx8mm-var-som-symphony: Use newer interrupts property

2020-09-12 Thread Shawn Guo
On Fri, Sep 04, 2020 at 04:53:07PM +0200, Krzysztof Kozlowski wrote: > The int-gpios was deprecated in favor of generic interrupts property. > > Signed-off-by: Krzysztof Kozlowski Applied patch #8 ~ #13, thanks. ___ dri-devel mailing list

[PATCH] drm/drm_vblank: use drm_warn_once() to warn undefined mode timing

2020-10-16 Thread Shawn Guo
ting services may treat kernel WARNINGS as crashes. Let's drop WARN_ON_ONCE() and change drm_dbg_core() to drm_warn_once() for warning undefined mode timing. Signed-off-by: Shawn Guo --- drivers/gpu/drm/drm_vblank.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dr

Re: [PATCH] drm/drm_vblank: use drm_warn_once() to warn undefined mode timing

2020-10-16 Thread Shawn Guo
On Fri, Oct 16, 2020 at 09:58:46AM +0200, Daniel Vetter wrote: > On Fri, Oct 16, 2020 at 9:13 AM Shawn Guo wrote: > > > > Commit 5caa0feafcc6 ("drm/vblank: Lock down vblank->hwmode more") added > > WARN_ON_ONCE() for atomic drivers to warn the case that vsync is

Re: [PATCH] drm/drm_vblank: use drm_warn_once() to warn undefined mode timing

2020-10-16 Thread Shawn Guo
On Fri, Oct 16, 2020 at 11:30:04AM +0200, Daniel Vetter wrote: > On Fri, Oct 16, 2020 at 10:54 AM Shawn Guo wrote: > > > > On Fri, Oct 16, 2020 at 09:58:46AM +0200, Daniel Vetter wrote: > > > On Fri, Oct 16, 2020 at 9:13 AM Shawn Guo wrote: > > > > > >

Re: [PATCH 03/13] dt-bindings: arm: fsl: Fix matching Purism Librem5 phones

2020-09-21 Thread Shawn Guo
On Fri, Sep 04, 2020 at 04:53:02PM +0200, Krzysztof Kozlowski wrote: > All Purism Librem5 phones have three compatibles so they need their own > entry to fix dbts_check warnings like: > > arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml: /: > compatible: ['purism,librem5r2',

Re: [PATCH v2] drm/atomic_helper: add a flag for duplicating drm_private_obj state

2020-07-11 Thread Shawn Guo
On Sat, Jun 27, 2020 at 7:53 PM Shawn Guo wrote: > > From: Shawn Guo > > The msm/mdp5 driver uses state of drm_private_obj as its global atomic > state, which keeps the assignment of hwpipe to plane. With > drm_private_obj missing from duplicate state call in context of atomi

[PATCH v2] drm/atomic_helper: add a flag for duplicating drm_private_obj state

2020-06-27 Thread Shawn Guo
From: Shawn Guo The msm/mdp5 driver uses state of drm_private_obj as its global atomic state, which keeps the assignment of hwpipe to plane. With drm_private_obj missing from duplicate state call in context of atomic suspend/resume helpers, mdp5 suspend works with no problem only for the very

[PATCH] drm/atomic_helper: duplicate state for drm_private_obj

2020-06-25 Thread Shawn Guo
From: Shawn Guo The msm/mdp5 driver uses drm_private_obj as its global atomic state, which keeps the assignment of hwpipe to plane. With drm_private_obj missing from duplicate state call, mdp5 suspend works with no problem only for the very first time. Any subsequent suspend will hit

Re: [PATCH for v5.9] ARM: dts: mxs: Replace HTTP links with HTTPS ones

2020-07-19 Thread Shawn Guo
> Replace HTTP with HTTPS. > > Signed-off-by: Alexander A. Klimov s/mxs/imx in the subject. Otherwise: Acked-by: Shawn Guo > --- > Continuing my work started at 93431e0607e5. > See also: git log --oneline '--author=Alexander A. Klimov > ' v5.7..master

Re: [PATCH v7 0/8] mainline Plymovent M2M and BAS board

2021-01-06 Thread Shawn Guo
On Mon, Dec 07, 2020 at 03:09:31PM +0100, Oleksij Rempel wrote: > changes v7: > - panel-simple.yaml: fix comments and part order > - panel-simple.yaml: invent a product description for the Kyocera tcg070wvlq > panel > > changes v6: > - do more panel-simple.yaml related cleanups > > changes v5:

Re: [PATCH] Revert "i2c: qcom-geni: Disable DMA processing on the Lenovo Yoga C630"

2020-11-29 Thread Shawn Guo
> Disable DMA processing on the Lenovo Yoga C630")'. > > Signed-off-by: Bjorn Andersson Acked-by: Shawn Guo ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm/bridge: ti-sn65dsi86: rename GPIO register bits

2020-12-10 Thread Shawn Guo
From: Shawn Guo It renames GPIO register bits to drop 'SN_' prefix, so that they are consistent to other definitions - prefixing register name with 'SN_' but not for bit fields. Signed-off-by: Shawn Guo --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 26 +- 1 file changed

Re: [PATCH] drm/bridge: ti-sn65dsi86: Implement the pwm_chip

2020-12-09 Thread Shawn Guo
On Mon, Dec 07, 2020 at 10:40:22PM -0600, Bjorn Andersson wrote: > The SN65DSI86 provides the ability to supply a PWM signal on GPIO 4, > with the primary purpose of controlling the backlight of the attached > panel. Add an implementation that exposes this using the standard PWM > framework, to

Re: [PATCH] drm/bridge: ti-sn65dsi86: Implement the pwm_chip

2020-12-10 Thread Shawn Guo
Hi Uwe, On Thu, Dec 10, 2020 at 9:05 PM Uwe Kleine-König wrote: > > > @@ -111,6 +118,8 @@ > > > > > > #define SN_LINK_TRAINING_TRIES 10 > > > > > > +#define SN_PWM_GPIO3 > > > > So this maps to the GPIO4 described in sn65dsi86 datasheet. I'm > > wondering if

Re: [PATCH] drm/drm_vblank: use drm_warn_once() to warn undefined mode timing

2020-10-21 Thread Shawn Guo
On Mon, Oct 19, 2020 at 05:48:29PM +0200, Daniel Vetter wrote: > On Fri, Oct 16, 2020 at 07:46:41PM +0800, Shawn Guo wrote: > > Indeed! Adding drm_crtc_vblank_reset() into driver crtc reset hook > > removes the WARNING for me. Really appreciate your comments, Daniel! >

Re: [PATCHv2 5/5] ARM: dts: imx6: Add GE B1x5v2

2021-05-22 Thread Shawn Guo
On Thu, Apr 29, 2021 at 12:29:53AM +0200, Sebastian Reichel wrote: > This adds device tree files for the General Electric Healthcare > (GEHC) B1x5v2 series. All models make use of Congatec's QMX6 module, > which is described in its own device tree include, so that it can > also be used by other

<    1   2   3   4   >