with the buffer structure in DRM, maybe there are
better ways to handle something like this in DRI.
--
Ville Syrjälä
syrj...@sci.fi mailto:syrj...@sci.fi
http://www.sci.fi/~syrjala/
Regards,
--
Sylwester Nawrocki
Samsung Poland RD Center
On 03/30/2012 01:09 PM, Marcus Lorentzon wrote:
On 03/30/2012 12:12 PM, Ville Syrjälä wrote:
+#define DRM_FORMAT_NV12MT fourcc_code('T', 'M', '1', '2') /* 2x2
subsampled Cr:Cb plane 64x32 macroblocks */
This one is more difficult. Until now tiling was always handled in
driver specific manner.
Hi,
On 04/10/2012 12:11 PM, Tomasz Stanislawski wrote:
From: Dave Airlieairl...@redhat.com
Add vmap to dmabuf interface.
Signed-off-by: Dave Airlieairl...@redhat.com
---
drivers/base/dma-buf.c | 29 +
include/linux/dma-buf.h | 16
2 files
-by: Sylwester Nawrocki s.nawro...@samsung.com
Just one nitpick, please change the commit summary prefix from
v4l: fimc: ... to s5p-fimc: ... when sending upstream.
Thanks.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org
Hi,
On 06/07/2012 08:43 AM, Hans Verkuil wrote:
On Thu June 7 2012 02:52:06 Laurent Pinchart wrote:
On Wednesday 06 June 2012 10:17:03 Hans Verkuil wrote:
On Wed 6 June 2012 05:46:34 Laurent Pinchart wrote:
On Monday 04 June 2012 12:34:23 Rebecca Schultz Zavin wrote:
I have a system where
Hi,
On 07/30/2012 10:45 AM, Leela Krishna Amudala wrote:
Moved the contents of regs-fb-v4.h and regs-fb.h from arch side
to include/video/samsung_fimd.h
Signed-off-by: Leela Krishna Amudala l.kris...@samsung.com
---
arch/arm/plat-samsung/include/plat/regs-fb-v4.h | 159 ---
Hi,
On 07/30/2012 10:53 AM, Jingoo Han wrote:
+/*FIMD V8 REG OFFSET */
+#define FIMD_V8_VIDTCON0(0x20010)
+#define FIMD_V8_VIDTCON1(0x20014)
+#define FIMD_V8_VIDTCON2(0x20018)
+#define FIMD_V8_VIDTCON3(0x2001C)
+#define FIMD_V8_VIDCON1 (0x20004)
CC'ed Marek.
Hi,
On 07/31/2012 02:51 PM, Sergei Shtylyov wrote:
+/*EXYNOS5 FIMD REG OFFSET */
How about changing it to, e.g.
/* EXYNOS5 specific register offset definitions */
(but just in case you happen to resend this patch series)
+#define EXYNOS5_VIDTCON0(0x20010)
+#define EXYNOS5_VIDTCON1
On 08/07/2012 04:33 PM, Russell King - ARM Linux wrote:
On Tue, Aug 07, 2012 at 06:04:30PM +0530, Leela Krishna Amudala wrote:
arch/arm/plat-samsung/include/plat/regs-fb-v4.h| 159
drivers/gpu/drm/exynos/exynos_drm_fimd.c |2 +-
drivers/video/s3c-fb.c
Hi Laurent,
On 08/15/2012 11:09 PM, Laurent Pinchart wrote:
On Wednesday 15 August 2012 18:13:19 Sylwester Nawrocki wrote:
On 08/15/2012 12:06 AM, Laurent Pinchart wrote:
On Tuesday 14 August 2012 18:37:23 Sylwester Nawrocki wrote:
On 08/14/2012 03:04 PM, Mauro Carvalho Chehab wrote
Hi,
On 09/06/2012 09:21 AM, InKi Dae wrote:
+Required properties:
+ - compatible: Should be samsung,exynos5-fimd or samsung,exynos4-fb for
Doesn't better to use single word? fimd or fb?. I think 'fb' is used
for framebuffer historically.
but now it's used both fb and drm, so fimd is neutral
Hi Sakari,
On 11/13/2012 03:24 PM, Sakari Ailus wrote:
Hi all,
Comments would be appreciated, either positive or negative. The omap3isp
driver does the same check itself currently, but I think this is more
generic than that.
Thanks.
On Fri, Oct 26, 2012 at 10:46:17PM +0300, Sakari
On 12/18/2012 07:21 AM, Rob Clark wrote:
On Mon, Dec 17, 2012 at 11:04 PM, Dave Airlieairl...@gmail.com wrote:
So this might be a bit off topic but this whole CDF triggered me
looking at stuff I generally avoid:
The biggest problem I'm having currently with the whole ARM graphics
and output
Hi,
On 01/08/2013 11:56 PM, Stephen Warren wrote:
On 01/08/2013 01:16 PM, Sean Paul wrote:
Add a property to the hdmi node so we can specify the HDMI version in
the device tree instead of just defaulting to v1.4 with the existence of
the dt node.
I guess this seems OK to me if required,
On 01/30/2013 09:50 AM, Inki Dae wrote:
+static const struct of_device_id exynos_g2d_match[] = {
+ { .compatible = samsung,g2d-v41 },
not only Exynos5 and also Exyno4 has the g2d gpu and drm-based g2d
driver shoud support for all Exynos SoCs. How about using
samsung,exynos5-g2d instead
Hi Inki,
On 01/31/2013 02:30 AM, Inki Dae wrote:
-Original Message-
From: Sylwester Nawrocki [mailto:sylvester.nawro...@gmail.com]
Sent: Thursday, January 31, 2013 5:51 AM
To: Inki Dae
Cc: Sachin Kamat; linux-me...@vger.kernel.org; dri-
de...@lists.freedesktop.org; devicetree-disc
On 02/01/2013 09:33 AM, Sachin Kamat wrote:
On 1 February 2013 06:57, Inki Dae inki@samsung.com wrote:
For example,
If compatible = samsung,g2d-3.0 is added to exynos4210.dtsi, it'd be
reasonable. But what if that compatible string is added to exynos4.dtsi?.
This case isn't considered
On 02/05/2013 04:03 AM, Inki Dae wrote:
[...]
Exynos4210 has same g2d IP (v3.0) as C110 or V210; so the same
comptible string will be used for this one too.
And please check if exynos4212 and 4412 SoCs have same fimg-2d ip.
If it's different, we might need to add ip version property or
On 02/06/2013 09:51 AM, Inki Dae wrote:
[...]
I think that it's better to go to gpu than media and we can divide Exynos
IPs into the bellow categories,
Media : mfc
GPU : g2d, g3d, fimc, gsc
Heh, nice try! :) GPU and FIMC ? FIMC is a camera subsystem (hence 'C'
in the acronym), so what it
Hi Rahul,
On 02/06/2013 03:57 PM, Rahul Sharma wrote:
Binding Documents for drm-devices are placed in
Documentation/devicetree/bindings/drm/*. But these devices are common
for v4l framework, hence moved to a common place
Documentation/devicetree/bindings/video/. 'exynos_' prefix is added to
On 02/12/2013 02:17 PM, Inki Dae wrote:
Applied and will go to -next.
And please post the document(in
Documentation/devicetree/bindings/gpu/) for it later.
There is already some old patch applied in the devicetree/next tree:
On 02/12/2013 06:30 PM, Sachin Kamat wrote:
Hi Sylwester,
On Wednesday, 6 February 2013, Sachin Kamat sachin.ka...@linaro.org wrote:
This patch adds device tree based discovery support to G2D driver
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
Based on for_v3.9 branch of below
On 02/28/2013 05:12 AM, Vikas Sajjan wrote:
Adds support for pinctrl to drm fimd
Signed-off-by: Leela Krishna Amudalal.kris...@samsung.com
Signed-off-by: Vikas Sajjanvikas.saj...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c |9 +
1 file changed, 9 insertions(+)
diff
operation of the DRM FIMC and the camera ISP
on Exynos4x12.
Thanks,
Sylwester
Sylwester Nawrocki (3):
drm/exynos: Remove redundant devm_kfree()
drm/exynos: Rework fimc clocks handling
drm/exynos: Add device tree support for fimc ipp driver
drivers/gpu/drm/exynos/Kconfig |2
There is no need for explicit calls of devm_kfree(), as
the allocated memory will be freed during driver's detach.
Remove the redundant devm_kfree() calls from probe() and
remove() callbacks.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p
-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 168 +-
1 file changed, 98 insertions(+), 70 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
b/drivers/gpu/drm
from the
device tree.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/gpu/drm/exynos/Kconfig |2 +-
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 101 +++---
drivers/gpu/drm/exynos/regs
On 04/17/2013 06:02 AM, Sachin Kamat wrote:
Hi Sylwester,
On 16 April 2013 23:01, Sylwester Nawrocki s.nawro...@samsung.com wrote:
@@ -1835,16 +1859,19 @@ static int fimc_probe(struct platform_device *pdev)
ret = exynos_drm_ippdrv_register(ippdrv);
if (ret 0
operation of the DRM FIMC and the camera ISP
on Exynos4x12.
Changes since v1:
- removed devm_kfree() that got erroneously re-added in patch 2/3 during
rebase.
Thanks,
Sylwester
Sylwester Nawrocki (3):
drm/exynos: Remove redundant devm_kfree()
drm/exynos: Rework fimc clocks handling
drm
There is no need for explicit calls of devm_kfree(), as
the allocated memory will be freed during driver's detach.
Remove the redundant devm_kfree() calls from probe() and
remove() callbacks.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p
-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 167 +-
1 file changed, 97 insertions(+), 70 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
b/drivers/gpu/drm
from the
device tree.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/gpu/drm/exynos/Kconfig |2 +-
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 101 +++---
drivers/gpu/drm/exynos/regs
On 04/22/2013 11:56 AM, Tomasz Figa wrote:
On Monday 22 of April 2013 10:44:00 Viresh Kumar wrote:
On 21 April 2013 20:13, Tomasz Figa tomasz.f...@gmail.com wrote:
3) after those two changes, all that remains is to fix compliance with
Common Clock Framework, in other words:
On 04/22/2013 12:03 PM, Inki Dae wrote:
Also looks good to me. But what if power domain was disabled without pm
runtime? In this case, you must enable the power domain at machine code
or
bootloader somewhere. This way would not only need some hard codes to
turn
the
Hi,
On 04/19/2013 01:26 PM, Eunchul Kim wrote:
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
index d812c57..bc8411a 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
@@ -76,6 +76,27 @@ enum
Hi Inki,
On 04/20/2013 06:11 PM, Inki Dae wrote:
Hi Sylwester,
DRM FIMC driver could be more cleaned up with this patch series. And your
third
patch
And just minor issue. The second patch has build warnings like below,
WARNING: static const char * array should probably be static const
On 04/20/2013 06:21 PM, Inki Dae wrote:
+static int fimc_parse_dt(struct fimc_context *ctx)
+{
+ struct device_node *node = ctx-dev-of_node;
+
+ if (!of_property_read_bool(node, samsung,lcd-wb))
+ return -ENODEV;
Isn't the above
On 04/19/2013 01:38 PM, Eunchul Kim wrote:
static void fimc_set_type_ctrl(struct fimc_context *ctx, enum fimc_wb wb)
@@ -1628,7 +1617,9 @@ static int fimc_ippdrv_start(struct device *dev, enum
drm_exynos_ipp_cmd cmd)
fimc_handle_lastend(ctx, true);
/* setup FIMD */
-
and comments,
- fixed error paths in fimc_setup_clocks() function.
Changes since v1:
- removed devm_kfree() that got erroneously re-added in patch 2/3 during
rebase.
Thanks,
Sylwester
Sylwester Nawrocki (3):
drm/exynos: remove redundant devm_kfree()
drm/exynos: rework fimc clocks handling
There is no need for explicit calls of devm_kfree(), as
the allocated memory will be freed during driver's detach.
Remove the redundant devm_kfree() calls from probe() and
remove() callbacks.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p
-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 169 +-
1 file changed, 99 insertions(+), 70 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
b/drivers/gpu/drm
data
for the FIMC IPP, i.e. uses it.
Camera input signal polarities are not currently parsed from the
device tree.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/gpu/drm/exynos/Kconfig |2 +-
drivers/gpu
On 04/26/2013 10:20 AM, Inki Dae wrote:
Exactly right. it's my mistake. But now it seems that __mode_of_device_table
is
multi defined at fimd and g2d side so there still is module build error. :(
Since all drivers seem to be linked into single a single module, you
likely need to create a
On 04/26/2013 09:42 PM, Tomasz Figa wrote:
On Friday 26 of April 2013 11:48:50 Sylwester Nawrocki wrote:
On 04/26/2013 10:20 AM, Inki Dae wrote:
Exactly right. it's my mistake. But now it seems that
__mode_of_device_table is multi defined at fimd and g2d side so there
still is module build
Hi,
On 04/29/2013 07:04 PM, Sean Paul wrote:
On Mon, Apr 29, 2013 at 10:50 AM, Rahul Sharma rahul.sha...@samsung.com
wrote:
Hdmiphy clock flows from hdmiphy hw to hdmi ip and mixer. It is commonly
accessed among hdmi and hdmiphy driver. During power cycle, each of these
driver decrements
| 69
++
drivers/gpu/drm/exynos/regs-hdmi.h |4 ++
3 files changed, 71 insertions(+), 8 deletions(-)
--
1.7.10.4
--
Sylwester Nawrocki
Samsung RD Institute Poland
Samsung Electronics
___
dri-devel mailing list
On 07/13/2013 10:35 AM, Jean-Francois Moine wrote:
On Fri, 12 Jul 2013 13:00:23 -0600 Daniel Draked...@laptop.org wrote:
On Fri, Jul 12, 2013 at 12:39 PM, Jean-Francois Moinemoin...@free.fr wrote:
- the phandles to the clocks does not tell how the clock may be set by
the driver (it is
On 07/13/2013 07:44 PM, Sebastian Hesselbarth wrote:
On 07/13/2013 01:12 PM, Russell King - ARM Linux wrote:
On Sat, Jul 13, 2013 at 12:56:50PM +0200, Sylwester Nawrocki wrote:
On 07/13/2013 10:35 AM, Jean-Francois Moine wrote:
On Fri, 12 Jul 2013 13:00:23 -0600 Daniel Draked...@laptop.org
On 07/13/2013 11:02 PM, Russell King - ARM Linux wrote:
On Sat, Jul 13, 2013 at 10:43:29PM +0200, Sylwester Nawrocki wrote:
I wasn't aware of it, thanks. I've seen a patch from Jiada Wang, it seems
they're working on v4 with clock object reference counting. Presumably we
need both clk_get
On 07/22/2013 03:31 PM, Inki Dae wrote:
---Original Message-
From: linux-samsung-soc-ow...@vger.kernel.org [mailto:linux-samsung-soc-
ow...@vger.kernel.org] On Behalf Of Lucas Stach
Sent: Monday, July 22, 2013 9:47 PM
To: Inki Dae
Cc: 'Mark Rutland'; 'Chanho Park';
Hi Rahul,
On 07/31/2013 01:23 PM, Rahul Sharma wrote:
I think your hdmiphy pmu patch is good enough just if dt binding for pmu
is in hdmiphy binding instead of hdmi binding. So I recommended to make
pmu patch set on the top of independent hdmiphy patch set because with
independent hdmiphy
Hi Vikas,
On 08/02/2013 12:10 PM, Vikas Sajjan wrote:
yeah, we could not allocate CMA region for FIMD, because the function
dma_declare_contiguous() needs dev as the first argument and we have
access to dev node only if it is NON-DT way of probing like the way
it is done in
Vikas,
On 08/06/2013 07:23 AM, Vikas Sajjan wrote:
While trying to get boot-logo up on exynos5420 SMDK which has eDP panel
connected with resolution 2560x1600, following error occured even with
IOMMU enabled:
[0.88] [drm:lowlevel_buffer_allocate] *ERROR* failed to allocate buffer.
Can you please quote only related part of e-mails when replying ?
It discourages to read such discussions when you have to scroll
through few pages of garbage before getting to the actual reply
text.
--
Thanks,
Sylwester
___
dri-devel mailing list
On 09/28/2013 06:10 PM, Inki Dae wrote:
Any opinion from Device-Tree folks?
IMO, we should have same consensus on Shirish patches before proceeding.
Rahul, it seems that DT people have no interest in this issue. So let's
have a consensus about this issue internally.
To Mr. Kyungmin,
On 01/14/2017 01:36 PM, Krzysztof Kozlowski wrote:
> Support for Exynos4415 is going away because there are no internal nor
> external users.
>
> Since commit 46dcf0ff0de3 ("ARM: dts: exynos: Remove exynos4415.dtsi"),
> the platform cannot be instantiated so remove also the drivers.
>
>
On 10/21/2016 04:05 PM, Krzysztof Kozlowski wrote:
> The samsung,power-domain property is obsolete since commit 0da658704136
> ("ARM: dts: convert to generic power domain bindings for exynos DT").
> Replace it with generic one.
>
> Signed-off-by: Krzysztof Kozlowski
("of: reserved_mem: add support for using more than
>one region for given device")
> Signed-off-by: Marek Szyprowski
Reviewed-by: Sylwester Nawrocki
I think this needs to be added to the media tree, where the original
patch it fixes was applied.
--
Thanks,
Sylwester
Hi Sakari,
On 11/13/2012 03:24 PM, Sakari Ailus wrote:
> Hi all,
>
> Comments would be appreciated, either positive or negative. The omap3isp
> driver does the same check itself currently, but I think this is more
> generic than that.
>
> Thanks.
>
> On Fri, Oct 26, 2012 at 10:46:17PM +0300,
On 10/17/2013 02:32 PM, Tomi Valkeinen wrote:
> On 17/10/13 15:17, Laurent Pinchart wrote:
>> On Thursday 17 October 2013 14:59:41 Tomi Valkeinen wrote:
>>> On 17/10/13 14:51, Laurent Pinchart wrote:
> I'm not sure if there's a specific need for the port or endpoint nodes
> in cases like
On 10/24/2013 12:52 PM, Tomi Valkeinen wrote:
> On 24/10/13 13:40, Laurent Pinchart wrote:
>
>>> panel {
>>> remote =<>;
>>> common-video-property =;
>>> };
>>>
>>> panel {
>>> port {
>>> endpoint {
>>> remote =<>;
>>>
Hi,
On 29/10/13 20:23, Tomasz Figa wrote:
>> It's a very deeply nested structure, I'm not sure there's a need to
>> > make a ports {} subnode really.
>> >
>> > Also, I don't know if it makes sense to always name it
>> > remote-endpoint, or to use a more flexible name depending on what is
>> >
Hi,
On 09/04/14 11:12, Rahul Sharma wrote:
> Idea looks good. How about keeping compatible which is independent
> of SoC, something like "samsung,exynos-simple-phy" and provide Reg
> and Bit through phy provider node. This way we can avoid SoC specific
> hardcoding in phy driver and don't need to
On 15/04/14 10:41, Sachin Kamat wrote:
> On 15 April 2014 11:17, YoungJun Cho wrote:
>> This patch adds sysreg device node, and sysreg property to fimd device node
>> which is required to use I80 interface.
>>
>> Signed-off-by: YoungJun Cho
>> Signed-off-by: Inki Dae
>> Signed-off-by: Kyungmin
Hi,
On 09/06/2012 09:21 AM, InKi Dae wrote:
>>> +Required properties:
>>> + - compatible: Should be "samsung,exynos5-fimd" or "samsung,exynos4-fb" for
>> Doesn't better to use single word? fimd or fb?. I think 'fb' is used
>> for framebuffer historically.
>> but now it's used both fb and drm, so
operation of the DRM FIMC and the camera ISP
on Exynos4x12.
Thanks,
Sylwester
Sylwester Nawrocki (3):
drm/exynos: Remove redundant devm_kfree()
drm/exynos: Rework fimc clocks handling
drm/exynos: Add device tree support for fimc ipp driver
drivers/gpu/drm/exynos/Kconfig |2
There is no need for explicit calls of devm_kfree(), as
the allocated memory will be freed during driver's detach.
Remove the redundant devm_kfree() calls from probe() and
remove() callbacks.
Signed-off-by: Sylwester Nawrocki
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos
ting up parent clocks on DT platforms.
Signed-off-by: Sylwester Nawrocki
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 168 +-
1 file changed, 98 insertions(+), 70 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
b/driv
from the
device tree.
Signed-off-by: Sylwester Nawrocki
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/Kconfig |2 +-
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 101 +++---
drivers/gpu/drm/exynos/regs-fimc.h |7 +--
3 files changed, 53
On 04/17/2013 06:02 AM, Sachin Kamat wrote:
> Hi Sylwester,
>
> On 16 April 2013 23:01, Sylwester Nawrocki wrote:
>> @@ -1835,16 +1859,19 @@ static int fimc_probe(struct platform_device *pdev)
>> ret = exynos_drm_ippdrv_register(ippdrv);
&
operation of the DRM FIMC and the camera ISP
on Exynos4x12.
Changes since v1:
- removed devm_kfree() that got erroneously re-added in patch 2/3 during
rebase.
Thanks,
Sylwester
Sylwester Nawrocki (3):
drm/exynos: Remove redundant devm_kfree()
drm/exynos: Rework fimc clocks handling
drm
There is no need for explicit calls of devm_kfree(), as
the allocated memory will be freed during driver's detach.
Remove the redundant devm_kfree() calls from probe() and
remove() callbacks.
Signed-off-by: Sylwester Nawrocki
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos
ting up parent clocks on DT platforms.
Signed-off-by: Sylwester Nawrocki
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 167 +-
1 file changed, 97 insertions(+), 70 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
b/driv
from the
device tree.
Signed-off-by: Sylwester Nawrocki
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/Kconfig |2 +-
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 101 +++---
drivers/gpu/drm/exynos/regs-fimc.h |7 +--
3 files changed, 53
On 04/22/2013 11:56 AM, Tomasz Figa wrote:
> On Monday 22 of April 2013 10:44:00 Viresh Kumar wrote:
>> On 21 April 2013 20:13, Tomasz Figa wrote:
>>> 3) after those two changes, all that remains is to fix compliance with
>>> Common Clock Framework, in other words:
>>>
>>>
On 04/22/2013 12:03 PM, Inki Dae wrote:
> > Also looks good to me. But what if power domain was disabled without pm
> > runtime? In this case, you must enable the power domain at machine code
> or
> > bootloader somewhere. This way would not only need some hard codes to
> turn
>
Hi,
On 04/19/2013 01:26 PM, Eunchul Kim wrote:
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
>> b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
>> index d812c57..bc8411a 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
>> @@ -76,6
Hi Inki,
On 04/20/2013 06:11 PM, Inki Dae wrote:
> Hi Sylwester,
>
> DRM FIMC driver could be more cleaned up with this patch series. And your
> third
> patch
> And just minor issue. The second patch has build warnings like below,
>
> WARNING: static const char * array should probably be
On 04/20/2013 06:21 PM, Inki Dae wrote:
> +static int fimc_parse_dt(struct fimc_context *ctx)
> +{
> + struct device_node *node = ctx->dev->of_node;
> +
> + if (!of_property_read_bool(node, "samsung,lcd-wb"))
> + return -ENODEV;
>
>
>
> Isn't
On 04/19/2013 01:38 PM, Eunchul Kim wrote:
>> static void fimc_set_type_ctrl(struct fimc_context *ctx, enum fimc_wb wb)
>> @@ -1628,7 +1617,9 @@ static int fimc_ippdrv_start(struct device *dev, enum
>> drm_exynos_ipp_cmd cmd)
>> fimc_handle_lastend(ctx, true);
>>
>> /* setup
and comments,
- fixed error paths in fimc_setup_clocks() function.
Changes since v1:
- removed devm_kfree() that got erroneously re-added in patch 2/3 during
rebase.
Thanks,
Sylwester
Sylwester Nawrocki (3):
drm/exynos: remove redundant devm_kfree()
drm/exynos: rework fimc clocks handling
There is no need for explicit calls of devm_kfree(), as
the allocated memory will be freed during driver's detach.
Remove the redundant devm_kfree() calls from probe() and
remove() callbacks.
Signed-off-by: Sylwester Nawrocki
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos
ting up parent clocks on DT platforms.
Signed-off-by: Sylwester Nawrocki
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 169 +-
1 file changed, 99 insertions(+), 70 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
b/driv
data
for the FIMC IPP, i.e. uses it.
Camera input signal polarities are not currently parsed from the
device tree.
Signed-off-by: Sylwester Nawrocki
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/Kconfig |2 +-
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 110
On 04/26/2013 10:20 AM, Inki Dae wrote:
> Exactly right. it's my mistake. But now it seems that __mode_of_device_table
> is
> multi defined at fimd and g2d side so there still is module build error. :(
Since all drivers seem to be linked into single a single module, you
likely need to create a
On 04/26/2013 09:42 PM, Tomasz Figa wrote:
> On Friday 26 of April 2013 11:48:50 Sylwester Nawrocki wrote:
>> On 04/26/2013 10:20 AM, Inki Dae wrote:
>>> Exactly right. it's my mistake. But now it seems that
>>> __mode_of_device_table is multi defined at fimd and
Hi,
On 04/29/2013 07:04 PM, Sean Paul wrote:
> On Mon, Apr 29, 2013 at 10:50 AM, Rahul Sharma
> wrote:
>> Hdmiphy clock flows from hdmiphy hw to hdmi ip and mixer. It is commonly
>> accessed among hdmi and hdmiphy driver. During power cycle, each of these
>> driver decrements the ref-count and
Hi Vikas,
On 08/02/2013 12:10 PM, Vikas Sajjan wrote:
> yeah, we could not allocate CMA region for FIMD, because the function
> dma_declare_contiguous() needs "dev" as the first argument and we have
> access to "dev" node only if it is NON-DT way of probing like the way
> it is done in
Vikas,
On 08/06/2013 07:23 AM, Vikas Sajjan wrote:
> While trying to get boot-logo up on exynos5420 SMDK which has eDP panel
> connected with resolution 2560x1600, following error occured even with
> IOMMU enabled:
> [0.88] [drm:lowlevel_buffer_allocate] *ERROR* failed to allocate buffer.
>
On 02/01/2013 09:33 AM, Sachin Kamat wrote:
> On 1 February 2013 06:57, Inki Dae wrote:
>>
>> For example,
>> If compatible = "samsung,g2d-3.0" is added to exynos4210.dtsi, it'd be
>> reasonable. But what if that compatible string is added to exynos4.dtsi?.
>> This case isn't considered for
On 02/05/2013 04:03 AM, Inki Dae wrote:
[...]
>> Exynos4210 has same g2d IP (v3.0) as C110 or V210; so the same
>> comptible string will be used for this one too.
>>
>>> And please check if exynos4212 and 4412 SoCs have same fimg-2d ip.
>>> If it's different, we might need to add ip version
On 02/06/2013 09:51 AM, Inki Dae wrote:
[...]
> I think that it's better to go to gpu than media and we can divide Exynos
> IPs into the bellow categories,
>
> Media : mfc
> GPU : g2d, g3d, fimc, gsc
Heh, nice try! :) GPU and FIMC ? FIMC is a camera subsystem (hence 'C'
in the acronym), so what
Hi Rahul,
On 02/06/2013 03:57 PM, Rahul Sharma wrote:
> Binding Documents for drm-devices are placed in
> Documentation/devicetree/bindings/drm/*. But these devices are common
> for v4l framework, hence moved to a common place
> Documentation/devicetree/bindings/video/. 'exynos_' prefix is added
On 02/12/2013 02:17 PM, Inki Dae wrote:
> Applied and will go to -next.
> And please post the document(in
> Documentation/devicetree/bindings/gpu/) for it later.
There is already some old patch applied in the devicetree/next tree:
On 02/12/2013 06:30 PM, Sachin Kamat wrote:
>
> Hi Sylwester,
>
> On Wednesday, 6 February 2013, Sachin Kamat
> wrote:
>> This patch adds device tree based discovery support to G2D driver
>>
>> Signed-off-by: Sachin Kamat
>> ---
>> Based on for_v3.9 branch of below tree:
>>
On 02/28/2013 05:12 AM, Vikas Sajjan wrote:
> Adds support for pinctrl to drm fimd
>
> Signed-off-by: Leela Krishna Amudala
> Signed-off-by: Vikas Sajjan
> ---
> drivers/gpu/drm/exynos/exynos_drm_fimd.c |9 +
> 1 file changed, 9 insertions(+)
>
> diff --git
Hi,
On 01/08/2013 11:56 PM, Stephen Warren wrote:
> On 01/08/2013 01:16 PM, Sean Paul wrote:
>> Add a property to the hdmi node so we can specify the HDMI version in
>> the device tree instead of just defaulting to v1.4 with the existence of
>> the dt node.
>
> I guess this seems OK to me if
On 01/30/2013 09:50 AM, Inki Dae wrote:
>> +static const struct of_device_id exynos_g2d_match[] = {
>> + { .compatible = "samsung,g2d-v41" },
>
> not only Exynos5 and also Exyno4 has the g2d gpu and drm-based g2d
> driver shoud support for all Exynos SoCs. How about using
>
Hi Sachin,
On 01/25/2013 10:55 AM, Sachin Kamat wrote:
> This patch adds device tree based discovery support to G2D driver
>
> Signed-off-by: Sachin Kamat
> ---
> drivers/media/platform/s5p-g2d/g2d.c | 17 -
> 1 files changed, 16 insertions(+), 1 deletions(-)
>
> diff --git
Hi Inki,
On 01/31/2013 02:30 AM, Inki Dae wrote:
>> -Original Message-
>> From: Sylwester Nawrocki [mailto:sylvester.nawrocki at gmail.com]
>> Sent: Thursday, January 31, 2013 5:51 AM
>> To: Inki Dae
>> Cc: Sachin Kamat; linux-media at
1 - 100 of 225 matches
Mail list logo
