Refactor the code base a bit for the further work to adapt more clients.
Signed-off-by: Takashi Iwai ti...@suse.de
---
drivers/gpu/vga/vga_switcheroo.c | 209 --
1 file changed, 110 insertions(+), 99 deletions(-)
diff --git a/drivers/gpu/vga/vga_switcheroo.c
-off-by: Takashi Iwai ti...@suse.de
---
drivers/gpu/vga/vga_switcheroo.c | 84 ++
include/linux/vga_switcheroo.h | 10 +
2 files changed, 78 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/vga/vga_switcheroo.c b/drivers/gpu/vga/vga_switcheroo.c
At Thu, 10 May 2012 09:08:38 +0200,
Takashi Iwai wrote:
Dave,
this is a small patch series to add the support for audio clients
to VGA switcheroo. The background problem is that the HD-audio HDMI
controller of the discrete GPU is also disabled when the graphics core
is disabled by vga
At Thu, 10 May 2012 11:40:50 +0100,
Dave Airlie wrote:
On Thu, May 10, 2012 at 8:10 AM, Takashi Iwai ti...@suse.de wrote:
Add the support for audio clients to VGA-switcheroo for handling the
HDMI audio controller together with VGA switching. The id of the
audio controller should be given
At Thu, 10 May 2012 13:42:09 +0200,
Takashi Iwai wrote:
At Thu, 10 May 2012 12:20:05 +0100,
Alan Cox wrote:
On Thu, 10 May 2012 09:10:16 +0200
Takashi Iwai ti...@suse.de wrote:
Add the support for audio clients to VGA-switcheroo for handling the
HDMI audio controller together
At Thu, 10 May 2012 20:05:25 +0100,
Dave Airlie wrote:
On Thu, May 10, 2012 at 7:42 PM, Takashi Iwai ti...@suse.de wrote:
At Thu, 10 May 2012 13:42:09 +0200,
Takashi Iwai wrote:
At Thu, 10 May 2012 12:20:05 +0100,
Alan Cox wrote:
On Thu, 10 May 2012 09:10:16 +0200
Takashi
Hi Dave,
in kernel bug 43155, we found out that the HDMI audio controller on
AMD graphics is also disabled when the graphics chip is disabled via
vga-switcher:
https://bugzilla.kernel.org/show_bug.cgi?id=43155
This screws up the sound driver, takes too long time for boot.
Since the audio
Hi Dave,
in kernel bug 43155, we found out that the HDMI audio controller on
AMD graphics is also disabled when the graphics chip is disabled via
vga-switcher:
https://bugzilla.kernel.org/show_bug.cgi?id=43155
This screws up the sound driver, takes too long time for boot.
Since the audio
At Fri, 20 Apr 2012 13:05:48 +0100,
Dave Airlie wrote:
>
> On Thu, Apr 19, 2012 at 3:58 PM, Takashi Iwai wrote:
> > At Thu, 19 Apr 2012 14:03:58 +0200,
> > Takashi Iwai wrote:
> >>
> >> At Tue, 17 Apr 2012 17:26:26 +0200,
> >> Takashi Iwai wrote:
>
At Fri, 20 Apr 2012 13:04:42 +0100,
Dave Airlie wrote:
>
> On Thu, Apr 19, 2012 at 1:03 PM, Takashi Iwai wrote:
> > At Tue, 17 Apr 2012 17:26:26 +0200,
> > Takashi Iwai wrote:
> >>
> >> At Fri, 13 Apr 2012 16:56:26 -0400,
> >> Adam Jackson wrote:
&
At Fri, 20 Apr 2012 13:04:42 +0100,
Dave Airlie wrote:
On Thu, Apr 19, 2012 at 1:03 PM, Takashi Iwai ti...@suse.de wrote:
At Tue, 17 Apr 2012 17:26:26 +0200,
Takashi Iwai wrote:
At Fri, 13 Apr 2012 16:56:26 -0400,
Adam Jackson wrote:
On 4/13/12 4:33 PM, Adam Jackson wrote
At Fri, 20 Apr 2012 13:05:48 +0100,
Dave Airlie wrote:
On Thu, Apr 19, 2012 at 3:58 PM, Takashi Iwai ti...@suse.de wrote:
At Thu, 19 Apr 2012 14:03:58 +0200,
Takashi Iwai wrote:
At Tue, 17 Apr 2012 17:26:26 +0200,
Takashi Iwai wrote:
At Fri, 13 Apr 2012 16:56:26 -0400,
Adam
At Thu, 19 Apr 2012 14:03:58 +0200,
Takashi Iwai wrote:
>
> At Tue, 17 Apr 2012 17:26:26 +0200,
> Takashi Iwai wrote:
> >
> > At Fri, 13 Apr 2012 16:56:26 -0400,
> > Adam Jackson wrote:
> > >
> > > On 4/13/12 4:33 PM, Adam Jackson wrote:
&g
At Tue, 17 Apr 2012 17:26:26 +0200,
Takashi Iwai wrote:
>
> At Fri, 13 Apr 2012 16:56:26 -0400,
> Adam Jackson wrote:
> >
> > On 4/13/12 4:33 PM, Adam Jackson wrote:
> > > Incorporates some feedback from Rodrigo and Takashi. Major themes of the
> > >
At Tue, 17 Apr 2012 17:26:26 +0200,
Takashi Iwai wrote:
At Fri, 13 Apr 2012 16:56:26 -0400,
Adam Jackson wrote:
On 4/13/12 4:33 PM, Adam Jackson wrote:
Incorporates some feedback from Rodrigo and Takashi. Major themes of the
series:
- Fix the DMT list to include reduced
At Thu, 19 Apr 2012 14:03:58 +0200,
Takashi Iwai wrote:
At Tue, 17 Apr 2012 17:26:26 +0200,
Takashi Iwai wrote:
At Fri, 13 Apr 2012 16:56:26 -0400,
Adam Jackson wrote:
On 4/13/12 4:33 PM, Adam Jackson wrote:
Incorporates some feedback from Rodrigo and Takashi. Major themes
-by: Takashi Iwai
---
drivers/gpu/drm/radeon/radeon_connectors.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c
b/drivers/gpu/drm/radeon/radeon_connectors.c
index bd05156..aa8268d 100644
--- a/drivers/gpu/drm/radeon/radeon_connectors.c
At Wed, 18 Apr 2012 14:39:54 +0200,
Takashi Iwai wrote:
>
> Hi,
>
> I noticed that one machine here gives only the blank output with
> 3.4-rc's. The bisection lead me to affecting commit:
>
> commit e00e8b5e760cbbe9067daeae5454d67c44c8d035
> Author: Alex Deuche
Hi,
I noticed that one machine here gives only the blank output with
3.4-rc's. The bisection lead me to affecting commit:
commit e00e8b5e760cbbe9067daeae5454d67c44c8d035
Author: Alex Deucher
Date: Fri Mar 16 12:22:09 2012 -0400
drm/radeon/kms: fix analog load detection on
Hi,
I noticed that one machine here gives only the blank output with
3.4-rc's. The bisection lead me to affecting commit:
commit e00e8b5e760cbbe9067daeae5454d67c44c8d035
Author: Alex Deucher alexander.deuc...@amd.com
Date: Fri Mar 16 12:22:09 2012 -0400
drm/radeon/kms: fix
At Wed, 18 Apr 2012 14:39:54 +0200,
Takashi Iwai wrote:
Hi,
I noticed that one machine here gives only the blank output with
3.4-rc's. The bisection lead me to affecting commit:
commit e00e8b5e760cbbe9067daeae5454d67c44c8d035
Author: Alex Deucher alexander.deuc...@amd.com
...@vger.kernel.org
Signed-off-by: Takashi Iwai ti...@suse.de
---
drivers/gpu/drm/radeon/radeon_connectors.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c
b/drivers/gpu/drm/radeon/radeon_connectors.c
index bd05156..aa8268d 100644
--- a/drivers
At Tue, 17 Apr 2012 17:33:17 +0200,
Takashi Iwai wrote:
>
> At Fri, 13 Apr 2012 16:33:28 -0400,
> Adam Jackson wrote:
> >
> > Incorporates some feedback from Rodrigo and Takashi. Major themes of the
> > series:
> >
> > - Fix the DMT list to include redu
At Fri, 13 Apr 2012 16:33:28 -0400,
Adam Jackson wrote:
>
> Incorporates some feedback from Rodrigo and Takashi. Major themes of the
> series:
>
> - Fix the DMT list to include reduced-blanking modes
> - Add modes from DMT for any range descriptor type
> - Add an extra modes list for things not
At Fri, 13 Apr 2012 16:56:26 -0400,
Adam Jackson wrote:
>
> On 4/13/12 4:33 PM, Adam Jackson wrote:
> > Incorporates some feedback from Rodrigo and Takashi. Major themes of the
> > series:
> >
> > - Fix the DMT list to include reduced-blanking modes
> > - Add modes from DMT for any range
At Fri, 13 Apr 2012 16:33:37 -0400,
Adam Jackson wrote:
>
> Signed-off-by: Adam Jackson
> ---
> include/drm/drm_edid.h | 26 --
> 1 files changed, 20 insertions(+), 6 deletions(-)
>
> diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h
> index
At Fri, 13 Apr 2012 16:33:37 -0400,
Adam Jackson wrote:
Signed-off-by: Adam Jackson a...@redhat.com
---
include/drm/drm_edid.h | 26 --
1 files changed, 20 insertions(+), 6 deletions(-)
diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h
index
At Tue, 17 Apr 2012 17:33:17 +0200,
Takashi Iwai wrote:
At Fri, 13 Apr 2012 16:33:28 -0400,
Adam Jackson wrote:
Incorporates some feedback from Rodrigo and Takashi. Major themes of the
series:
- Fix the DMT list to include reduced-blanking modes
- Add modes from DMT for any
At Fri, 13 Apr 2012 12:31:25 -0400,
Adam Jackson wrote:
>
> On 4/13/12 11:41 AM, Takashi Iwai wrote:
> > At Fri, 13 Apr 2012 11:30:01 -0400, Alex Deucher wrote:
> >> One thing to be careful of is that some monitors (especially LCD
> >> panels) don't like mod
At Fri, 13 Apr 2012 11:30:01 -0400,
Alex Deucher wrote:
>
> On Fri, Apr 13, 2012 at 11:13 AM, Takashi Iwai wrote:
> > At Fri, 13 Apr 2012 15:35:04 +0100,
> > Dave Airlie wrote:
> >>
> >> > I don't think we need to support all wild modes, too. ?But the _
At Fri, 13 Apr 2012 10:55:16 -0400,
Adam Jackson wrote:
>
> On 4/13/12 10:29 AM, Takashi Iwai wrote:
> > At Fri, 13 Apr 2012 10:14:46 -0400,
> > Adam Jackson wrote:
> >> Yeah, that's a bug. That's why I said it should be renamed
> >> drm_dmt_modes_for_rang
At Fri, 13 Apr 2012 15:35:04 +0100,
Dave Airlie wrote:
>
> > I don't think we need to support all wild modes, too. ?But the _very_
> > common modes like 1366x768 and 1600x900 should be really supported as
> > default.
>
> You guys still haven't answered the basic question, what HW is this
At Fri, 13 Apr 2012 10:14:46 -0400,
Adam Jackson wrote:
>
> On 4/12/12 7:09 PM, Rodrigo Vivi wrote:
>
> >> CVT monitors _must_ accept GTF as well, EDID says so. So functionally
> >> there's nothing wrong with the existing code.
> >
> > Actually the current code just check for gtf flag... so if
At Fri, 13 Apr 2012 10:14:46 -0400,
Adam Jackson wrote:
On 4/12/12 7:09 PM, Rodrigo Vivi wrote:
CVT monitors _must_ accept GTF as well, EDID says so. So functionally
there's nothing wrong with the existing code.
Actually the current code just check for gtf flag... so if a monitor
At Fri, 13 Apr 2012 15:35:04 +0100,
Dave Airlie wrote:
I don't think we need to support all wild modes, too. But the _very_
common modes like 1366x768 and 1600x900 should be really supported as
default.
You guys still haven't answered the basic question, what HW is this broken?
The
At Fri, 13 Apr 2012 10:55:16 -0400,
Adam Jackson wrote:
On 4/13/12 10:29 AM, Takashi Iwai wrote:
At Fri, 13 Apr 2012 10:14:46 -0400,
Adam Jackson wrote:
Yeah, that's a bug. That's why I said it should be renamed
drm_dmt_modes_for_range and run unconditionally if we find a range
At Fri, 13 Apr 2012 11:30:01 -0400,
Alex Deucher wrote:
On Fri, Apr 13, 2012 at 11:13 AM, Takashi Iwai ti...@suse.de wrote:
At Fri, 13 Apr 2012 15:35:04 +0100,
Dave Airlie wrote:
I don't think we need to support all wild modes, too. But the _very_
common modes like 1366x768
At Fri, 13 Apr 2012 12:31:25 -0400,
Adam Jackson wrote:
On 4/13/12 11:41 AM, Takashi Iwai wrote:
At Fri, 13 Apr 2012 11:30:01 -0400, Alex Deucher wrote:
One thing to be careful of is that some monitors (especially LCD
panels) don't like modes that are not in their EDIDs. As such when
At Wed, 11 Apr 2012 21:59:28 -0300,
Rodrigo Vivi wrote:
>
> There are many bugs open on fd.o regarding missing modes that are supported
> on Windows and other closed source drivers.
> >From EDID spec we can (might?) infer modes using GTF and CVT when monitor
> >allows it trough range limited
At Wed, 11 Apr 2012 21:59:28 -0300,
Rodrigo Vivi wrote:
There are many bugs open on fd.o regarding missing modes that are supported
on Windows and other closed source drivers.
From EDID spec we can (might?) infer modes using GTF and CVT when monitor
allows it trough range limited flag...
At Mon, 21 Nov 2011 09:58:09 +0800,
Wu Fengguang wrote:
>
> On Sat, Nov 19, 2011 at 01:46:44AM +0800, Keith Packard wrote:
> > On Fri, 18 Nov 2011 17:37:40 +0800, Wu Fengguang > intel.com> wrote:
> >
> > > However when in X, ->mode_set won't be called at all. Only
> > > ->get_modes and
At Mon, 21 Nov 2011 09:58:09 +0800,
Wu Fengguang wrote:
On Sat, Nov 19, 2011 at 01:46:44AM +0800, Keith Packard wrote:
On Fri, 18 Nov 2011 17:37:40 +0800, Wu Fengguang fengguang...@intel.com
wrote:
However when in X, -mode_set won't be called at all. Only
-get_modes and -detect
At Wed, 16 Nov 2011 13:58:57 +0100,
Daniel Mack wrote:
>
> On 11/14/2011 11:39 AM, Takashi Iwai wrote:
> > OK, then perhaps a better fix is to change the check to be equivalent
> > with pineview, as you mentioned in the original post. The handling of
> > bit 0 for o
At Wed, 16 Nov 2011 13:58:57 +0100,
Daniel Mack wrote:
On 11/14/2011 11:39 AM, Takashi Iwai wrote:
OK, then perhaps a better fix is to change the check to be equivalent
with pineview, as you mentioned in the original post. The handling of
bit 0 for old chips was lost during
At Mon, 14 Nov 2011 13:03:46 +0100,
Daniel Mack wrote:
>
> On 11/14/2011 11:39 AM, Takashi Iwai wrote:
> > [Added Chris to Cc]
> >
> > At Sun, 13 Nov 2011 17:24:09 +0100,
> > Daniel Mack wrote:
> >>
> >> Hi Takashi,
> >>
> >> On
[Added Chris to Cc]
At Sun, 13 Nov 2011 17:24:09 +0100,
Daniel Mack wrote:
>
> Hi Takashi,
>
> On 11/10/2011 04:39 PM, Takashi Iwai wrote:
> > At Thu, 10 Nov 2011 16:11:29 +0100,
> > Daniel Mack wrote:
> >>
> >> On 11/08/2011 01:57 AM, Daniel Mack wrote
[Added Chris to Cc]
At Sun, 13 Nov 2011 17:24:09 +0100,
Daniel Mack wrote:
Hi Takashi,
On 11/10/2011 04:39 PM, Takashi Iwai wrote:
At Thu, 10 Nov 2011 16:11:29 +0100,
Daniel Mack wrote:
On 11/08/2011 01:57 AM, Daniel Mack wrote:
Didn't get any response yet, hence copying LKML
At Mon, 14 Nov 2011 13:03:46 +0100,
Daniel Mack wrote:
On 11/14/2011 11:39 AM, Takashi Iwai wrote:
[Added Chris to Cc]
At Sun, 13 Nov 2011 17:24:09 +0100,
Daniel Mack wrote:
Hi Takashi,
On 11/10/2011 04:39 PM, Takashi Iwai wrote:
At Thu, 10 Nov 2011 16:11:29 +0100,
Daniel
At Thu, 10 Nov 2011 16:11:29 +0100,
Daniel Mack wrote:
>
> On 11/08/2011 01:57 AM, Daniel Mack wrote:
> > Didn't get any response yet, hence copying LKML for a broader audience.
>
> Nobody, really?
>
> This is a rather annoying regression, as touching the brightness keys
> appearantly switches
At Thu, 10 Nov 2011 16:11:29 +0100,
Daniel Mack wrote:
On 11/08/2011 01:57 AM, Daniel Mack wrote:
Didn't get any response yet, hence copying LKML for a broader audience.
Nobody, really?
This is a rather annoying regression, as touching the brightness keys
appearantly switches off the
At Tue, 8 Nov 2011 12:23:30 -0800,
Linus Torvalds wrote:
>
> Hmm, I don't know what caused this to trigger, but I'm adding both the
> i915 people and the HDA people to the cc, and they can fight to the
> death about this in the HDMI Thunderdome.
It must be the new addition of ELD-passing code.
At Tue, 8 Nov 2011 12:23:30 -0800,
Linus Torvalds wrote:
Hmm, I don't know what caused this to trigger, but I'm adding both the
i915 people and the HDA people to the cc, and they can fight to the
death about this in the HDMI Thunderdome.
It must be the new addition of ELD-passing code.
{enable|disable}_backlight() call the internal function not
to update the recorded level wrongly.
Cc:
Signed-off-by: Takashi Iwai
---
Tested on 3.1-rc9 and 3.0.6 kernels.
v1->v2:
make an internal intel_panel_actually_set_backlight() and call from
enable/disable functions for track
At Thu, 13 Oct 2011 12:28:07 -0700,
Keith Packard wrote:
>
> On Thu, 13 Oct 2011 20:05:49 +0200, Takashi Iwai wrote:
>
> > Yes, this looks more understandable, indeed.
> > Would you patch it by yourself or should I refresh the patch?
> > In either way, I'll test tomor
At Thu, 13 Oct 2011 09:40:29 -0700,
Keith Packard wrote:
>
> On Thu, 13 Oct 2011 10:57:35 +0200, Takashi Iwai wrote:
>
> > This patch fixes the bug by recording the backlight level always
> > when changed but only when dev_priv->backlight_enabled is set.
> >
set.
In this way, the bogus value for disabling backlight can be skipped.
Signed-off-by: Takashi Iwai
---
Feel free to add Cc to stable kernel, as this is a regression fix.
I've tested only a few machines here so more tests would be
appreciated, because the backlight issue is SOOO sensit
.
In this way, the bogus value for disabling backlight can be skipped.
Signed-off-by: Takashi Iwai ti...@suse.de
---
Feel free to add Cc to stable kernel, as this is a regression fix.
I've tested only a few machines here so more tests would be
appreciated, because the backlight issue is SOOO sensitive
At Thu, 13 Oct 2011 09:40:29 -0700,
Keith Packard wrote:
On Thu, 13 Oct 2011 10:57:35 +0200, Takashi Iwai ti...@suse.de wrote:
This patch fixes the bug by recording the backlight level always
when changed but only when dev_priv-backlight_enabled is set.
In this way, the bogus value
At Thu, 13 Oct 2011 12:28:07 -0700,
Keith Packard wrote:
On Thu, 13 Oct 2011 20:05:49 +0200, Takashi Iwai ti...@suse.de wrote:
Yes, this looks more understandable, indeed.
Would you patch it by yourself or should I refresh the patch?
In either way, I'll test tomorrow, as I'm already
At Wed, 29 Jun 2011 14:20:13 +0800,
Wu Fengguang wrote:
>
> This patch is tested OK on G45/HDMI and IbexPeak/HDMI. DisplayPort is
> tested on several IbexPeak and Sandybridge boxes, however not working,
> possibly due to hardware/monitor problems.
We've got some reports that DP audio doesn't
At Wed, 29 Jun 2011 14:20:13 +0800,
Wu Fengguang wrote:
This patch is tested OK on G45/HDMI and IbexPeak/HDMI. DisplayPort is
tested on several IbexPeak and Sandybridge boxes, however not working,
possibly due to hardware/monitor problems.
We've got some reports that DP audio doesn't work
At Tue, 10 May 2011 13:08:23 +0200,
Melchior FRANZ wrote:
>
> * Michael Chang -- Tuesday 10 May 2011:
> > Could you please try this patch and get the log ? We wonder why
> > is_backlight_combination_mode () returns false.
>
> This information was already buried in the bugzilla thread:
>
>
At Tue, 10 May 2011 13:08:23 +0200,
Melchior FRANZ wrote:
* Michael Chang -- Tuesday 10 May 2011:
Could you please try this patch and get the log ? We wonder why
is_backlight_combination_mode () returns false.
This information was already buried in the bugzilla thread:
At Mon, 09 May 2011 02:50:50 -0600,
Joey Lee wrote:
>
> Add Cc. Michael Chang for he is our i915 expert.
>
> Hi Melchior,
>
> ? ??2011-05-08 ? 16:05 +0200?Melchior FRANZ ???
> >
> > > Does it work to you direct control brightness by access
> > > by /sys/class/backlight/acer-wmi/brightness ?
>
At Sat, 7 May 2011 22:22:40 +0200,
Melchior FRANZ wrote:
>
> * Melchior FRANZ -- Friday 06 May 2011:
> > last patch prevents the backlight from being turned off, but it also
> > breaks the brightness adjustment keys at runtime with acpi_osi=Linux.
>
> It has turned out that acpi key events seem
At Sat, 7 May 2011 22:22:40 +0200,
Melchior FRANZ wrote:
* Melchior FRANZ -- Friday 06 May 2011:
last patch prevents the backlight from being turned off, but it also
breaks the brightness adjustment keys at runtime with acpi_osi=Linux.
It has turned out that acpi key events seem to be
At Mon, 09 May 2011 02:50:50 -0600,
Joey Lee wrote:
Add Cc. Michael Chang for he is our i915 expert.
Hi Melchior,
於 日，2011-05-08 於 16:05 +0200，Melchior FRANZ 提到：
Does it work to you direct control brightness by access
by /sys/class/backlight/acer-wmi/brightness ?
No. A
At Sat, 30 Apr 2011 13:34:51 +0200,
Melchior FRANZ wrote:
>
> Dropping Linus from the CC.
>
>
> * Takashi Iwai -- Saturday 30 April 2011:
> * * At Sat, 30 Apr 2011 10:32:04 +0200, Melchior FRANZ wrote:
> > > Yes, backlight adjustment generally works
At Sat, 30 Apr 2011 13:34:51 +0200,
Melchior FRANZ wrote:
Dropping Linus from the CC.
* Takashi Iwai -- Saturday 30 April 2011:
* * At Sat, 30 Apr 2011 10:32:04 +0200, Melchior FRANZ wrote:
Yes, backlight adjustment generally works on this notebook, but only
with acpi_osi=Linux
At Sat, 30 Apr 2011 10:32:04 +0200,
Melchior FRANZ wrote:
>
> * Takashi Iwai -- Saturday 30 April 2011:
> > I remember vaguely that the value zero could be interpreted as the max.
>
> > Also, with the patch, does the backlight level can be adjusted
> > correctly to
At Fri, 29 Apr 2011 22:09:54 +0200,
Melchior FRANZ wrote:
>
> * Takashi Iwai -- Friday 29 April 2011:
> [https://bugzilla.kernel.org/show_bug.cgi?id=31522]
> > Looking at bugzilla, the problem seems like the case lbpc=0.
> > What about the patch below instead?
>
>
At Fri, 29 Apr 2011 22:09:54 +0200,
Melchior FRANZ wrote:
* Takashi Iwai -- Friday 29 April 2011:
[https://bugzilla.kernel.org/show_bug.cgi?id=31522]
Looking at bugzilla, the problem seems like the case lbpc=0.
What about the patch below instead?
- val *= lbpc
At Sat, 30 Apr 2011 10:32:04 +0200,
Melchior FRANZ wrote:
* Takashi Iwai -- Saturday 30 April 2011:
I remember vaguely that the value zero could be interpreted as the max.
Also, with the patch, does the backlight level can be adjusted
correctly to different values? I wonder whether
At Fri, 29 Apr 2011 19:41:53 +0200,
Melchior FRANZ wrote:
>
> * Takashi Iwai -- Friday 29 April 2011:
> > Melchior FRANZ wrote:
> > > The bug was introduced with commit
> > > ba3820ade317ee36e496b9b40d2ec3987dd4aef0
> > > [...] when using KMS my not
sion was
> 2.6.38-rc8. The problem has been reported[1], but the bug got closed
> in the wrong assumption that the bug is fixed. I reported that, too.
> No reactions to that.
>
> The bug was introduced with commit ba3820ade317ee36e496b9b40d2ec3987dd4aef0
> by Takashi Iwai. The result
At Fri, 29 Apr 2011 19:41:53 +0200,
Melchior FRANZ wrote:
* Takashi Iwai -- Friday 29 April 2011:
Melchior FRANZ wrote:
The bug was introduced with commit
ba3820ade317ee36e496b9b40d2ec3987dd4aef0
[...] when using KMS my notebook's[2] screen remains dark, because the
backlight
At Sun, 17 Apr 2011 18:26:54 +0200,
Florian Mickler wrote:
>
> On Wed, 22 Dec 2010 12:53:07 +
> Chris Wilson wrote:
>
> > On Wed, 22 Dec 2010 12:42:32 +, Chris Wilson > chris-wilson.co.uk> wrote:
> > > From: Takashi Iwai
> >
> > >
At Sun, 17 Apr 2011 18:26:54 +0200,
Florian Mickler wrote:
On Wed, 22 Dec 2010 12:53:07 +
Chris Wilson ch...@chris-wilson.co.uk wrote:
On Wed, 22 Dec 2010 12:42:32 +, Chris Wilson ch...@chris-wilson.co.uk
wrote:
From: Takashi Iwai ti...@suse.de
This patch adds a new
s an additional patch, but I think it's likely a 2.6.39
material.
All you comments below look reasonable. Could you send a new patch?
thanks,
Takashi
> On Thu, March 10, 2011 14:02, Takashi Iwai wrote:
> > This reverts commit 951f3512dba5bd44cda3e5ee22b4b522e4bb09fb
> >
> >
s merged to Linus tree.
Anyway, the patch looks good to me. A nice clean-up.
Reviewed-by: Takashi Iwai
thanks,
Takashi
a fix for the original
issue (weird backlight levels) by removing the wrong bit shift for
computing the current backlight level.
Also, including typo fixes (lpbc -> lbpc).
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=34524
Acked-by: Indan Zupancic
Cc:
Signed-off-by: Takashi I
At Thu, 10 Mar 2011 11:06:28 +0100 (CET),
Indan Zupancic wrote:
>
> On Thu, March 10, 2011 09:25, Takashi Iwai wrote:
> > At Thu, 10 Mar 2011 08:49:37 +0100,
> > Takashi Iwai wrote:
> >>
> >> At Thu, 10 Mar 2011 06:50:09 +0100 (CET),
> >&
At Thu, 10 Mar 2011 09:45:18 +0100 (CET),
Indan Zupancic wrote:
>
> On Thu, March 10, 2011 08:49, Takashi Iwai wrote:
> > At Thu, 10 Mar 2011 06:50:09 +0100 (CET),
> > Indan Zupancic wrote:
> >>
> >> Hello,
> >>
> >> On Fri, March 4, 2011 19:
At Thu, 10 Mar 2011 08:49:37 +0100,
Takashi Iwai wrote:
>
> At Thu, 10 Mar 2011 06:50:09 +0100 (CET),
> Indan Zupancic wrote:
> >
> > Hello,
> >
> > On Fri, March 4, 2011 19:47, Linus Torvalds wrote:
> > > Alex, can you confirm that the revert of 951f35
At Thu, 10 Mar 2011 06:50:09 +0100 (CET),
Indan Zupancic wrote:
>
> Hello,
>
> On Fri, March 4, 2011 19:47, Linus Torvalds wrote:
> > Alex, can you confirm that the revert of 951f3512dba5 plus the
> > one-liner patch from Takashi that Indan quoted also works for you?
> >
> > Linus
At Thu, 10 Mar 2011 08:49:37 +0100,
Takashi Iwai wrote:
At Thu, 10 Mar 2011 06:50:09 +0100 (CET),
Indan Zupancic wrote:
Hello,
On Fri, March 4, 2011 19:47, Linus Torvalds wrote:
Alex, can you confirm that the revert of 951f3512dba5 plus the
one-liner patch from Takashi
At Thu, 10 Mar 2011 09:45:18 +0100 (CET),
Indan Zupancic wrote:
On Thu, March 10, 2011 08:49, Takashi Iwai wrote:
At Thu, 10 Mar 2011 06:50:09 +0100 (CET),
Indan Zupancic wrote:
Hello,
On Fri, March 4, 2011 19:47, Linus Torvalds wrote:
Alex, can you confirm that the revert
At Thu, 10 Mar 2011 11:06:28 +0100 (CET),
Indan Zupancic wrote:
On Thu, March 10, 2011 09:25, Takashi Iwai wrote:
At Thu, 10 Mar 2011 08:49:37 +0100,
Takashi Iwai wrote:
At Thu, 10 Mar 2011 06:50:09 +0100 (CET),
Indan Zupancic wrote:
Hello,
On Fri, March 4, 2011 19:47
-by: Takashi Iwai ti...@suse.de
---
drivers/gpu/drm/i915/i915_reg.h| 10 ++
drivers/gpu/drm/i915/intel_panel.c | 36
2 files changed, 46 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
good to me. A nice clean-up.
Reviewed-by: Takashi Iwai ti...@suse.de
thanks,
Takashi
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
At Thu, 3 Feb 2011 17:11:14 -0800,
Linus Torvalds wrote:
>
> On Thu, Feb 3, 2011 at 5:05 PM, Keith Packard wrote:
> >
> > The goal is to make it so that when you *do* set a mode, DPMS gets set
> > to ON (as the monitor will actually be "on" at that point). Here's a
> > patch which does the
At Thu, 3 Feb 2011 17:11:14 -0800,
Linus Torvalds wrote:
On Thu, Feb 3, 2011 at 5:05 PM, Keith Packard kei...@keithp.com wrote:
The goal is to make it so that when you *do* set a mode, DPMS gets set
to ON (as the monitor will actually be on at that point). Here's a
patch which does the
At Thu, 3 Feb 2011 07:42:05 -0800,
Linus Torvalds wrote:
>
> On Thu, Feb 3, 2011 at 3:23 AM, Carlos R. Mafra wrote:
> > On Thu ?3.Feb'11 at ?1:03:41 +0100, Rafael J. Wysocki wrote:
> >>
> >> If you know of any other unresolved post-2.6.36 regressions, please let us
> >> know
> >> either and
At Thu, 3 Feb 2011 07:42:05 -0800,
Linus Torvalds wrote:
On Thu, Feb 3, 2011 at 3:23 AM, Carlos R. Mafra crmaf...@gmail.com wrote:
On Thu 3.Feb'11 at 1:03:41 +0100, Rafael J. Wysocki wrote:
If you know of any other unresolved post-2.6.36 regressions, please let us
know
either and
://bugzilla.kernel.org/show_bug.cgi?id=26952
https://bugzilla.kernel.org/show_bug.cgi?id=27272
I quickly tried these patches. After adding the missing EXPORT_SYMBOL,
it seems working fine. Tested on a SNB laptop and a PineView laptop.
Put my tag to all patches:
Tested-by: Takashi Iwai ti...@suse.de
At Wed, 22 Dec 2010 16:59:06 +,
Chris Wilson wrote:
>
> On Wed, 22 Dec 2010 17:24:36 +0100, Takashi Iwai wrote:
> > The commit 448f53a1ede54eb854d036abf54573281412d650
> > drm/i915/bios: Reverse order of 100/120 Mhz SSC clocks
> >
> > causes a regression
At Tue, 21 Dec 2010 23:43:18 + (GMT),
Dave Airlie wrote:
>
>
> Hi,
>
> meant to get this out earlier, but I've been off sick as well as having a
> sick kid, also meant a few things piled up when I wasn't looking
>
> contains a revert for reported regression in intel and also one in
At Wed, 22 Dec 2010 16:59:06 +,
Chris Wilson wrote:
On Wed, 22 Dec 2010 17:24:36 +0100, Takashi Iwai ti...@suse.de wrote:
The commit 448f53a1ede54eb854d036abf54573281412d650
drm/i915/bios: Reverse order of 100/120 Mhz SSC clocks
causes a regression on a SandyBridge machine here
Add a missing NULL check and fix the wrong address passed to kunmap()
in i830_cleanup().
Signed-off-by: Takashi Iwai ti...@suse.de
---
drivers/char/agp/intel-gtt.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/char/agp/intel-gtt.c b/drivers/char/agp/intel
Add a missing NULL check and fix the wrong address passed to kunmap()
in i830_cleanup().
Signed-off-by: Takashi Iwai
---
drivers/char/agp/intel-gtt.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/char/agp/intel-gtt.c b/drivers/char/agp/intel-gtt.c
index
501 - 600 of 610 matches
Mail list logo
