Currently enabling OMAP DRM support automatically pulls in
fbdev dependency. However this dep is unnecessary since
DRM core already handles this for us (DRM_FBDEV_EMULATION).
Signed-off-by: Tobias Jakobi
---
drivers/gpu/drm/omapdrm/Kconfig | 5 -
1 file changed, 5 deletions(-)
diff --git
Currently enabling Marvell Armada DRM support automatically pulls
in fbdev dependency. However this dep is unnecessary since
DRM core already handles this for us (DRM_FBDEV_EMULATION).
Signed-off-by: Tobias Jakobi
---
drivers/gpu/drm/armada/Kconfig | 4
1 file changed, 4 deletions(-)
diff
Currently enabling ARC DRM support automatically pulls in
fbdev dependency. However this dep is unnecessary since
DRM core already handles this for us (DRM_FBDEV_EMULATION).
Signed-off-by: Tobias Jakobi
---
drivers/gpu/drm/arc/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers
Hello,
as request by Daniel here
(http://www.spinics.net/lists/dri-devel/msg112592.html) I went ahead and also
cleaned up the other Kconfig files. I have mostly compile tested the changes on
an ARMv7 system (COMPILE_TEST).
With best wishes,
Tobias
Tobias Jakobi (21):
drm/arc: make fbdev
Benjamin Gaignard wrote:
> zpos new fields are correctly documented in drm-kms.html after running
> make htmldocs.
I'm not sure I understand. Where does htmldocs get the information from
then?
- Tobias
> Benjamin
>
> 2016-07-07 16:01 GMT+02:00 Tobias Jakobi :
&g
+--
> drivers/gpu/drm/sti/sti_plane.h | 7 +-
> include/drm/drm_crtc.h| 30
> 20 files changed, 324 insertions(+), 147 deletions(-)
> create mode 100644 drivers/gpu/drm/drm_blend.c
>
> Cc: Inki Dae
> Cc: Daniel Vetter
> Cc: Vill
Ping!
- Tobias
Tobias Jakobi wrote:
> Currently enabling Exynos DRM support automatically pulls in
> lots of fbdev dependencies. However these deps are
> unnecessary since DRM core already enables them when
> needed.
>
> Signed-off-by: Tobias Jakobi
> ---
> drivers/gp
Currently enabling Exynos DRM support automatically pulls in
lots of fbdev dependencies. However these deps are
unnecessary since DRM core already enables them when
needed.
Signed-off-by: Tobias Jakobi
---
drivers/gpu/drm/exynos/Kconfig | 4
1 file changed, 4 deletions(-)
diff --git
Hello Daniel,
Daniel Vetter wrote:
> On Fri, Jun 10, 2016 at 12:12:45PM +0200, Tobias Jakobi wrote:
>> Ping!
>
> exynos maintainer Inki isn't on cc, so good chances he'll miss this.
Both the initial mail and my ping have Inki in the Cc.
- Tobias
> -Daniel
>
>>
>
Ping!
- Tobias
Tobias Jakobi wrote:
> This makes the defines consistent with the rest.
>
> Signed-off-by: Tobias Jakobi
> ---
> drivers/gpu/drm/exynos/exynos_drm_g2d.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git
Ping!
- Tobias
Tobias Jakobi wrote:
> Neither of these files issue any fbdev related calls.
>
> Signed-off-by: Tobias Jakobi
> ---
> drivers/gpu/drm/exynos/exynos7_drm_decon.c | 1 -
> drivers/gpu/drm/exynos/exynos_drm_core.c | 1 -
> drivers/gpu/drm/exynos/exynos_dr
Ping!
- Tobias
Tobias Jakobi wrote:
> The current bitwise AND should result in the same assembler
> but this is what the code is actually supposed to do.
>
> Signed-off-by: Tobias Jakobi
> ---
> drivers/gpu/drm/exynos/exynos_drm_plane.c | 2 +-
> 1 file changed, 1 ins
Hey Krzysztof,
Krzysztof Kozlowski wrote:
> On 05/24/2016 06:05 PM, Tobias Jakobi wrote:
>> Hello Krzysztof,
>>
>>
>> Krzysztof Kozlowski wrote:
>>> On 05/24/2016 03:49 PM, Tobias Jakobi wrote:
>>>> Hello Krzysztof,
>>>>
>>
This makes the defines consistent with the rest.
Signed-off-by: Tobias Jakobi
---
drivers/gpu/drm/exynos/exynos_drm_g2d.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
index
Neither of these files issue any fbdev related calls.
Signed-off-by: Tobias Jakobi
---
drivers/gpu/drm/exynos/exynos7_drm_decon.c | 1 -
drivers/gpu/drm/exynos/exynos_drm_core.c | 1 -
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/drivers/gpu
The current bitwise AND should result in the same assembler
but this is what the code is actually supposed to do.
Signed-off-by: Tobias Jakobi
---
drivers/gpu/drm/exynos/exynos_drm_plane.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos
Hello Andrzej,
sorry for the delay.
Andrzej Hajda wrote:
> On 05/07/2016 12:33 PM, Tobias Jakobi wrote:
>> Hello Andrzej,
>>
>> I've applied this to my 4.5.3 based tree, but I'm still seeing the page
>> fault.
>
> Thats pity, I hoped to solve two issue
Hello Krzysztof,
Krzysztof Kozlowski wrote:
> On 05/24/2016 03:49 PM, Tobias Jakobi wrote:
>> Hello Krzysztof,
>>
>> are you sure that these are the only differences. Because AFAIK there
>> are quite a few more:
>> - DMA submission of commands
>>
Hello Krzysztof,
are you sure that these are the only differences. Because AFAIK there
are quite a few more:
- DMA submission of commands
- blend mode / rounding
- solid fill
- YCrCb support
- and probably more
One would need to add least split the command list parser into a v3 and
v41 version
t; + * VA LINUX SYSTEMS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> + * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + * OTHER DEALINGS IN THE SOFTWARE.
> */
>
> #i
Hello,
just voicing my interest in having this feature in DRM core.
- Tobias
Daniel Vetter wrote:
> On Mon, May 09, 2016 at 10:42:45AM +0200, Benjamin Gaignard wrote:
>> Hello,
>>
>> I little up in this topic.
>> If generic z-order patches can't land into drm core,
>> I wille have to resend
Hello Andrzej,
I've applied this to my 4.5.3 based tree, but I'm still seeing the page
fault. In fact the calls leading to the fault haven't changed at all.
> [ 153.437877] [drm:fimd_update_plane] start addr = 0x2060, end addr =
> 0x20a08000, size = 0x408000
> [ 153.446903]
Hello Andrzej,
Andrzej Hajda wrote:
> Hi Tobias,
>
> On 05/05/2016 07:27 PM, Tobias Jakobi wrote:
>> Hello,
>>
>> here's another issue I experience when enabling FIMD on the ODROID-X2.
>>
>> I can trigger a IOMMU pagefault by starting X once, quitting, an
Hello,
here's another issue I experience when enabling FIMD on the ODROID-X2.
I can trigger a IOMMU pagefault by starting X once, quitting, and
restarting X again.
I've put the full logs from both startx runs below.
I think the interesting part is the following:
> [ 326.603473]
divisor.
Signed-off-by: Tobias Jakobi
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
index 57020f9..9d4cae4 100644
--- a/drivers/gpu/drm
Hello Andrzej,
Andrzej Hajda wrote:
> On 05/05/2016 11:12 AM, Andrzej Hajda wrote:
>>
>> Regarding the initial question, mode->vrefresh is set in
>> drm_helper_probe_single_connector_modes. I guess division by zero could
>> be caused by lack of clock in timings provided by dts timing node.
>> As
Hey Daniel,
Daniel Vetter wrote:
> On Mon, May 02, 2016 at 04:30:37PM +0200, Tobias Jakobi wrote:
>> Hello Alex,
>>
>>
>> Alex Deucher wrote:
>>> On Sat, Apr 30, 2016 at 5:37 PM, Tobias Jakobi
>>> wrote:
>>>> Hello,
>>>>
&
Hello Alex,
Alex Deucher wrote:
> On Sat, Apr 30, 2016 at 5:37 PM, Tobias Jakobi
> wrote:
>> Hello,
>>
>> while playing around with FIMD enabled, I noticed that when first using
>> the device a zero division was triggered in fimd_calc_clkdiv(). I
>> rememb
Hello,
while playing around with FIMD enabled, I noticed that when first using
the device a zero division was triggered in fimd_calc_clkdiv(). I
remembered that I had a similar issue some time ago.
I added a stub fimd_atomic_check() which shows that vrefresh is zero
when fimd_calc_clkdiv() is
Hello all,
I wanted to ask if there has been any progress since last time. Also I
was wondering if it would be feasible to just fixup the IPP API and then
go from there (instead of trying to do automagic behind the scenes).
Marek has pointed out that currently the API has some major flaws and
the
Hello Inki,
my main system which I also used for development was stolen on Tuesday,
so I won't be working on this series anytime soon. If anyone wants to
pick it up, please go ahead.
- Tobias
Inki Dae wrote:
> 2015-11-24 2:44 GMT+09:00 Tobias Jakobi :
>> Hey Inki,
>>
>&
Hello Emil,
my main system which I also used for development was stolen on Tuesday,
so I won't be working on this series anytime soon. If anyone wants to
pick it up, please go ahead.
- Tobias
Emil Velikov wrote:
> On 22 November 2015 at 18:48, Tobias Jakobi
> wrote:
>> This al
Hey Inki,
Inki Dae wrote:
>
>
> 2015ë
11ì 23ì¼ 01:09ì Tobias Jakobi ì´(ê°) ì´ ê¸:
>> This updates the blending setup when the layer configuration
>> changes (triggered by mixer_win_{commit,disable}).
>>
>> To avoid unnecesary reconfigurations we cach
Hey Inki,
Inki Dae wrote:
>
>
> 2015ë
11ì 23ì¼ 01:09ì Tobias Jakobi ì´(ê°) ì´ ê¸:
>> This analyses the current layer configuration (which layers
>> are enabled, which have alpha-pixelformat, etc.) and setups
>> blending accordingly.
>>
>> We
Hey Inki,
Inki Dae wrote:
> Hi Tobias,
>
> 2015ë
11ì 23ì¼ 01:09ì Tobias Jakobi ì´(ê°) ì´ ê¸:
>> First step in allowing a more generic way to setup complex
>> blending for the different layers.
>>
>> Signed-off-by: Tobias Jakobi
>> ---
>>
The Exynos API was extended quite a bit, so reflect this in the
version number.
Signed-off-by: Tobias Jakobi
---
exynos/libdrm_exynos.pc.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/exynos/libdrm_exynos.pc.in b/exynos/libdrm_exynos.pc.in
index 5ce9118..ff1c432 100644
After the rewrite of the command buffer submission
handling g2d_reset() is no longer called internally.
Still the user might want to reset the G2D
context so expose this call.
Signed-off-by: Tobias Jakobi
---
exynos/exynos-symbol-check | 1 +
exynos/exynos_fimg2d.c | 28
This unmaps a previously mapped (via exynos_bo_map())
buffer object.
Signed-off-by: Tobias Jakobi
---
exynos/exynos-symbol-check | 1 +
exynos/exynos_drm.c| 20
exynos/exynos_drmif.h | 1 +
3 files changed, 22 insertions(+)
diff --git a/exynos/exynos-symbol
Hwang
Signed-off-by: Tobias Jakobi
---
tests/exynos/exynos_fimg2d_test.c | 132 ++
1 file changed, 132 insertions(+)
diff --git a/tests/exynos/exynos_fimg2d_test.c
b/tests/exynos/exynos_fimg2d_test.c
index dfb00a0..797fb6e 100644
--- a/tests/exynos
of g2d_move()
as suggested by Hyungwon Hwang.
Signed-off-by: Tobias Jakobi
---
exynos/exynos_fimg2d.c | 95 ++
exynos/exynos_fimg2d.h | 3 ++
2 files changed, 98 insertions(+)
diff --git a/exynos/exynos_fimg2d.c b/exynos/exynos_fimg2d.c
index 4d5419c
This allows setting the two direction registers, which specify how
the engine blits pixels. This can be used for overlapping blits,
which happen e.g. when 'moving' a rectangular region inside a
fixed buffer.
Reviewed-by: Hyungwon Hwang
Signed-off-by: Tobias Jakobi
---
exynos/exynos_fimg2d.c
This matches the G2D color mode that is used in the entire code.
The previous (incorrect) RGBA would only work since the
Exynos mixer did its configuration based on the bpp, and not
based on the actual pixelformat.
Reviewed-by: Hyungwon Hwang
Signed-off-by: Tobias Jakobi
---
tests/exynos
'busy' being
potentially uninitialized. Also enable timeout for poll()
in the monitor thread. This fixes pthread_join() not working
because of poll() not returning.
v4: Use explicit/fixed values for the DRM event context versions.
v5: Add binary to .gitignore.
Signed-off-by: Tobias Jakobi
This is a more 'flexible' version of g2d_exec allowing to pass
some flags which modify the behaviour of g2d_exec. Currently
only the 'async' operation flag is supported.
v2: Add g2d_exec2() to Exynos symbol test.
Signed-off-by: Tobias Jakobi
---
exynos/exynos-symbol-check | 1 +
exynos
the current API (e.g. by adding
a userdata argument to each public functions).
v2: Add g2d_config_event() to Exynos symbol test.
Signed-off-by: Tobias Jakobi
---
exynos/exynos-symbol-check | 1 +
exynos/exynos_fimg2d.c | 28 ++--
exynos/exynos_fimg2d.h | 1 +
3 files
Reviewed-by: Hyungwon Hwang
Signed-off-by: Tobias Jakobi
---
.gitignore| 1 +
tests/exynos/Makefile.am | 19 ++-
tests/exynos/exynos_fimg2d_perf.c | 327 ++
3 files changed, 345 insertions(+), 2 deletions(-)
create mode
Used to handle kernel events specific to the Exynos platform.
Currently only G2D events are handled.
v2: Adapt to container approach.
v3: Add exynos_handle_event() to Exynos symbol test.
Signed-off-by: Tobias Jakobi
---
exynos/exynos-symbol-check | 1 +
exynos/exynos_drm.c| 28
event
and 'ctx' the event context (casted to void).
This way we don't have to maintain a copy of drmHandleEvent()
in the vendor code.
v2: Remove the opaque pointer, since this can be better
handled with a container approach.
Signed-off-by: Tobias Jakobi
---
xf86drm.h | 21
, don't worry! ;)
Changes since v1:
- Added wording changes suggested by Hyungwon Hwang.
- Added binaries for new test applications to .gitignore.
- Collected r-b and t-b tags.
Tobias Jakobi (13):
drm: Implement drmHandleEvent2()
exynos: Introduce exynos_handle_event()
tests/exynos: add fimg2d
Allow the remaining alpha formats now that blending
is properly setup.
Signed-off-by: Tobias Jakobi
---
drivers/gpu/drm/exynos/exynos_mixer.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c
b/drivers/gpu/drm/exynos/exynos_mixer.c
index 1c24fb5
-by: Tobias Jakobi
---
drivers/gpu/drm/exynos/exynos_mixer.c | 41 +--
1 file changed, 39 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c
b/drivers/gpu/drm/exynos/exynos_mixer.c
index ec9659e..1c24fb5 100644
--- a/drivers/gpu/drm/exynos
Previously blending setup was static and most of it was
done in mixer_win_reset().
Signed-off-by: Tobias Jakobi
---
drivers/gpu/drm/exynos/exynos_mixer.c | 23 ---
1 file changed, 23 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c
b/drivers/gpu/drm/exynos
enabled when the layer has a pixelformat
with alpha attached.
Signed-off-by: Tobias Jakobi
---
drivers/gpu/drm/exynos/exynos_mixer.c | 88 +++
drivers/gpu/drm/exynos/regs-mixer.h | 1 +
2 files changed, 89 insertions(+)
diff --git a/drivers/gpu/drm/exynos
First step in allowing a more generic way to setup complex
blending for the different layers.
Signed-off-by: Tobias Jakobi
---
drivers/gpu/drm/exynos/exynos_mixer.c | 84 ++-
1 file changed, 73 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/exynos
: General code clean-up, indentation fixes and other small misc changes.
Layer state caching was added, to reduce the amount of register programming.
Tobias Jakobi (5):
drm/exynos: mixer: refactor layer setup
drm/exynos: mixer: introduce mixer_layer_blending()
drm/exynos: mixer: remove all
Hey Marek,
Marek Szyprowski wrote:
> Hello,
>
> On 2015-11-17 19:00, Tobias Jakobi wrote:
>> Marek Szyprowski wrote:
>>> This patch adds common structure for keeping plane configuration and
>>> capabilities data. This patch is inspired by similar co
Small typo:
'scalling' -> 'scaling'
With best wishes,
Tobias
Marek Szyprowski wrote:
> This patch fixes calculation of src x/y offset for negative crtc x/y
> values when scalling is enabled. This fixes possible IOMMU fault when
> scalling is enabled.
>
> Signed-off-by: Marek Szyprowski
> ---
>
Hello guys,
Daniel Stone wrote:
> Hi Marek,
>
> On 16 November 2015 at 11:35, Marek Szyprowski
> wrote:
>> On 2015-11-12 15:46, Daniel Stone wrote:
>>> On 12 November 2015 at 12:44, Tobias Jakobi
>>> wrote:
>>>> I wonder how this interacts with
Hello Marek,
Marek Szyprowski wrote:
> This patch adds common structure for keeping plane configuration and
> capabilities data. This patch is inspired by similar code developed by
> Tobias Jakobi.
>
> Signed-off-by: Marek Szyprowski
> ---
> drivers/gpu/drm/exynos/exynos
Hello,
Marek Szyprowski wrote:
> From: Seung-Woo Kim
>
> NV12 and YUV420 formats are need to calculate offset of each plane
> for ipp fimc in a gem buffer. Without proper offset, only Y plane
> can be processed, so result shows green frame.
> This patch fixes to calculate offset for cbcr
This one looks a bit strange. It only changes the argument list of
fimd_win_set_pixfmt() but the commit message that it actually fixes
something.
The corresponding upstream commit:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=66367461e573321f0fbb0be0391165b5a54d5fe4
Hey Daniel,
Daniel Stone wrote:
> Hi,
>
> On 12 November 2015 at 12:44, Tobias Jakobi
> wrote:
>> Daniel Stone wrote:
>>> On 10 November 2015 at 13:23, Marek Szyprowski >> samsung.com> wrote:
>>>> This patch series introduces a new life into E
Hello,
Daniel Stone wrote:
> Hi Marek,
>
> On 10 November 2015 at 13:23, Marek Szyprowski
> wrote:
>> This patch series introduces a new life into Exynos IPP (Image Post
>> Processing) subsystem by integrating it (transparently for userspace
>> applications) with Exynos DRM core plane
Hello Marek,
this looks very interesting. I'll try to integrate this with my mpv DRM
backend once the colorspace conversion bits are implemented.
I also wanted to suggest that using the IPP blocks (rotator, FIMC)
should be still be possible without any kind of display active. So
similar in the
Hello Hyungwon,
Hyungwon Hwang wrote:
> Hello Tobias,
>
> On Mon, 09 Nov 2015 10:47:02 +0100
> Tobias Jakobi wrote:
>
>> Hello Hyungwon,
>>
>>
>> Hyungwon Hwang wrote:
>>> Hello Tobias,
>>>
>>> I was in vacation last week, so
Hello Hyungwon,
Hyungwon Hwang wrote:
> Hello Tobias,
>
> On Mon, 09 Nov 2015 10:47:13 +0100
> Tobias Jakobi wrote:
>
>> Hello Hyungwon,
>>
>>
>> Hyungwon Hwang wrote:
>>> Hello,
>>>
>>> I think this patch should update .git
width limits us.
With best wishes,
Tobias
>
>
> Best regards,
> Hyungwon Hwang
>
>
> On Mon, 02 Nov 2015 10:52:09 +0100
> Tobias Jakobi wrote:
>
>> Currently only fast solid color clear performance is measured.
>> A large buffer is allocated
gt; But without it, it looks good to me, and I tested it on my Odroid U3
> board.
>
> Tested-by: Hyungwon Hwang
> Reviewed-by: Hyungwon Hwang
>
> Best regards,
> Hyungwon Hwang
>
>
> On Tue, 22 Sep 2015 17:54:59 +0200
> Tobias Jakobi wrote:
>
>>
the naming is fine though, since it mirrors libc's naming.
And the user is supposed to read the documentation anyway.
With best wishes,
Tobias
>
> Best regards,
> Hyungwon Hwang
>
> On Tue, 22 Sep 2015 17:54:58 +0200
> Tobias Jakobi wrote:
>
>> We already have g2d_co
Hello Joonyoung,
Joonyoung Shim wrote:
> On 10/31/2015 05:44 AM, Tobias Jakobi wrote:
>> Hey there,
>>
>> this question arose during some discussion with someone concerning the
>> Exynos mixer and G2D.
>>
>> The question is the following. Consider the E
this.
v2: Add GPLv2 header, argument handling and documentation.
Tool is only installed when requested.
v3: Free images array in fimg2d_perf_multi() as pointed out
by Hyungwon Hwang.
v4: Include header for error numbers (fixes build).
Signed-off-by: Tobias Jakobi
---
tests/exynos
'busy' being
potentially uninitialized. Also enable timeout for poll()
in the monitor thread. This fixes pthread_join() not working
because of poll() not returning.
v4: Use explicit/fixed values for the DRM event context versions.
Signed-off-by: Tobias Jakobi
---
tests/exynos/Makefile.am
this.
v2: Add GPLv2 header, argument handling and documentation.
Tool is only installed when requested.
v3: Free images array in fimg2d_perf_multi() as pointed out
by Hyungwon Hwang.
Signed-off-by: Tobias Jakobi
---
tests/exynos/Makefile.am | 19 ++-
tests/exynos
Hey there,
this question arose during some discussion with someone concerning the
Exynos mixer and G2D.
The question is the following. Consider the Exynos mixer when run under
the IOMMU (that's sysmmu_tv IIRC). What exactly does setup the IOMMU
mapping so that the mixer can scanout the
Tobias Jakobi wrote:
> Hello Hyungwon,
>
>
> Hyungwon Hwang wrote:
>> On Tue, 22 Sep 2015 17:54:57 +0200
>> Tobias Jakobi wrote:
>>
>>> This allows setting the two direction registers, which specify how
>>> the engine blits pixels. This can be
Hey Emil,
Emil Velikov wrote:
> On 30 October 2015 at 11:28, Tobias Jakobi
> wrote:
>> Hello Emil,
>>
>>
>> Emil Velikov wrote:
>>> On 30 October 2015 at 11:16, Tobias Jakobi
>>> wrote:
>>>> Hello Hyungwon,
>>>>
>>
Hello Emil,
Emil Velikov wrote:
> On 30 October 2015 at 11:16, Tobias Jakobi
> wrote:
>> Hello Hyungwon,
>>
>> first of all thanks for reviewing the series!
>>
>>
>>
>> Hyungwon Hwang wrote:
>>> On Tue, 22 Sep 2015 17:54:55 +
Hello Hyungwon,
Hyungwon Hwang wrote:
> On Tue, 22 Sep 2015 17:54:58 +0200
> Tobias Jakobi wrote:
>
>> We already have g2d_copy() which implements G2D copy
>> operations from one buffer to another. However we can't
>> do a overlapping copy operation in one buffer.
Hello Hyungwon,
Hyungwon Hwang wrote:
> On Tue, 22 Sep 2015 17:54:57 +0200
> Tobias Jakobi wrote:
>
>> This allows setting the two direction registers, which specify how
>> the engine blits pixels. This can be used for overlapping blits,
>> which happen e.g. when 'm
Hello Hyungwon,
Hyungwon Hwang wrote:
> On Tue, 22 Sep 2015 17:54:52 +0200
> Tobias Jakobi wrote:
>
>> Currently only fast solid color clear performance is measured.
>> A large buffer is allocated and solid color clear operations
>> are executed on it with randomly
Hello Hyungwon,
Hyungwon Hwang wrote:
> On Tue, 22 Sep 2015 17:54:56 +0200
> Tobias Jakobi wrote:
>
>> This matches the G2D color mode that is used in the entire code.
>> The previous (incorrect) RGBA would only work since the
>> Exynos mixer did its con
Hello Hyungwon,
first of all thanks for reviewing the series!
Hyungwon Hwang wrote:
> On Tue, 22 Sep 2015 17:54:55 +0200
> Tobias Jakobi wrote:
>
>> This tests async processing of G2D jobs. A separate thread is spawned
>> to monitor the DRM fd for events and ch
Another ping!
With best wishes,
Tobias
Tobias Jakobi wrote:
> Hello,
>
> this series mostly touches G2D code. It introduces the following:
>
> (1) drmHandleEvent2() is added to enable processing of vendor-specific
> events. This will be used to expose asyn
Another ping!
I need someone from Samsung to review this, or at least someone familiar
with the G2D.
With best wishes,
Tobias
Tobias Jakobi wrote:
> Gentle ping! :-)
>
> - Tobias
>
>
> Tobias Jakobi wrote:
>> Hello,
>>
>> this series mostly touches G
Gentle ping! :-)
- Tobias
Tobias Jakobi wrote:
> Hello,
>
> this series mostly touches G2D code. It introduces the following:
>
> (1) drmHandleEvent2() is added to enable processing of vendor-specific
> events. This will be used to expose asynchronous operatio
Hello Gustavo,
just wanted to ask if the series is still meant to go upstream. I tried
applying the series to torvalds/master and I get a conflict because of
Inki's commit 148ba09c465cc54d8e68f041bf9a30332b315c39 ('drm/exynos: dp:
remove suspend/resume functions').
With best wishes,
Tobias
The Exynos API was extended quite a bit, so reflect this in the
version number.
Signed-off-by: Tobias Jakobi
---
exynos/libdrm_exynos.pc.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/exynos/libdrm_exynos.pc.in b/exynos/libdrm_exynos.pc.in
index 5ce9118..ff1c432 100644
After the rewrite of the command buffer submission
handling g2d_reset() is no longer called internally.
Still the user might want to reset the G2D
context so expose this call.
Signed-off-by: Tobias Jakobi
---
exynos/exynos-symbol-check | 1 +
exynos/exynos_fimg2d.c | 28
This unmaps a previously mapped (via exynos_bo_map())
buffer object.
Signed-off-by: Tobias Jakobi
---
exynos/exynos-symbol-check | 1 +
exynos/exynos_drm.c| 20
exynos/exynos_drmif.h | 1 +
3 files changed, 22 insertions(+)
diff --git a/exynos/exynos-symbol
To check if g2d_move() works properly we create a small checkerboard
pattern in the center of the screen and then shift this pattern
around with g2d_move(). The pattern should be properly preserved
by the operation.
Signed-off-by: Tobias Jakobi
---
tests/exynos/exynos_fimg2d_test.c | 132
We already have g2d_copy() which implements G2D copy
operations from one buffer to another. However we can't
do a overlapping copy operation in one buffer.
Add g2d_move() which acts like the standard memmove()
and properly handles overlapping copies.
Signed-off-by: Tobias Jakobi
---
exynos
This allows setting the two direction registers, which specify how
the engine blits pixels. This can be used for overlapping blits,
which happen e.g. when 'moving' a rectangular region inside a
fixed buffer.
Signed-off-by: Tobias Jakobi
---
exynos/exynos_fimg2d.c | 13 +
exynos
This matches the G2D color mode that is used in the entire code.
The previous (incorrect) RGBA would only work since the
Exynos mixer did its configuration based on the bpp, and not
based on the actual pixelformat.
Signed-off-by: Tobias Jakobi
---
tests/exynos/exynos_fimg2d_test.c | 2 +-
1
'busy' being
potentially uninitialized. Also enable timeout for poll()
in the monitor thread. This fixes pthread_join() not working
because of poll() not returning.
Signed-off-by: Tobias Jakobi
---
tests/exynos/Makefile.am | 11 +-
tests/exynos/exynos_fimg2d_event.c | 326
This is a more 'flexible' version of g2d_exec allowing to pass
some flags which modify the behaviour of g2d_exec. Currently
only the 'async' operation flag is supported.
v2: Add g2d_exec2() to Exynos symbol test.
Signed-off-by: Tobias Jakobi
---
exynos/exynos-symbol-check | 1 +
exynos
the current API (e.g. by adding
a userdata argument to each public functions).
v2: Add g2d_config_event() to Exynos symbol test.
Signed-off-by: Tobias Jakobi
---
exynos/exynos-symbol-check | 1 +
exynos/exynos_fimg2d.c | 28 ++--
exynos/exynos_fimg2d.h | 1 +
3 files
this.
v2: Add GPLv2 header, argument handling and documentation.
Tool is only installed when requested.
Signed-off-by: Tobias Jakobi
---
tests/exynos/Makefile.am | 19 ++-
tests/exynos/exynos_fimg2d_perf.c | 320 ++
2 files changed, 337 insertions
Used to handle kernel events specific to the Exynos platform.
Currently only G2D events are handled.
v2: Adapt to container approach.
v3: Add exynos_handle_event() to Exynos symbol test.
Signed-off-by: Tobias Jakobi
---
exynos/exynos-symbol-check | 1 +
exynos/exynos_drm.c| 28
event
and 'ctx' the event context (casted to void).
This way we don't have to maintain a copy of drmHandleEvent()
in the vendor code.
v2: Remove the opaque pointer, since this can be better
handled with a container approach.
Signed-off-by: Tobias Jakobi
---
xf86drm.h | 21
, don't worry! ;)
Tobias Jakobi (13):
drm: Implement drmHandleEvent2()
exynos: Introduce exynos_handle_event()
tests/exynos: add fimg2d performance analysis
exynos/fimg2d: add g2d_config_event
exynos: fimg2d: add g2d_exec2
tests/exynos: add fimg2d event test
tests/exynos: use XRGB
201 - 300 of 615 matches
Mail list logo
