[PATCH v3 20/32] drm/exynos: Remove unused/useless fimd_context members

2013-11-11 Thread Tomasz Figa
/exynos/exynos_drm_fimd.c | 13 + > 1 file changed, 1 insertion(+), 12 deletions(-) Reviewed-by: Tomasz Figa Best regards, Tomasz

[PATCH v3 19/32] drm/exynos: Use mode_set to configure fimd

2013-11-10 Thread Tomasz Figa
Hi Sean, On Tuesday 29 of October 2013 12:13:05 Sean Paul wrote: > This patch uses the mode passed into mode_set to configure fimd instead > of directly using the panel from context. This will allow us to move > the exynos_drm_display implementation from fimd into the DP driver > where it

[PATCH v3 13/32] drm/exynos: hdmi: remove the i2c drivers and use devtree

2013-11-10 Thread Tomasz Figa
Hi Sean, Daniel, Please see my comments inline. On Tuesday 29 of October 2013 12:12:59 Sean Paul wrote: > From: Daniel Kurtz > > The i2c client was previously being passed into the hdmi driver via a > dedicated i2c driver, and then a global variable. This patch removes all > of that and just

[PATCH v3 12/32] drm/exynos: Split manager/display/subdrv

2013-11-12 Thread Tomasz Figa
On Tuesday 12 of November 2013 12:51:11 Sean Paul wrote: > On Sun, Nov 10, 2013 at 4:09 PM, Tomasz Figa wrote: > > Hi Sean, > > > > On Tuesday 29 of October 2013 12:12:58 Sean Paul wrote: > >> This patch splits display and manager from subdrv. The result is that &g

[PATCH v3 13/32] drm/exynos: hdmi: remove the i2c drivers and use devtree

2013-11-28 Thread Tomasz Figa
On Monday 11 of November 2013 09:44:27 Thierry Reding wrote: > On Sun, Nov 10, 2013 at 09:46:02PM +0100, Tomasz Figa wrote: > [...] > > On Tuesday 29 of October 2013 12:12:59 Sean Paul wrote: > [...] > > [snip] > > > @@ -1957,21 +1943,30 @@ static int hdmi_probe(struc

[PATCH v3 19/32] drm/exynos: Use mode_set to configure fimd

2013-11-28 Thread Tomasz Figa
On Friday 15 of November 2013 21:53:16 Daniel Kurtz wrote: > Hi Sean, Tomasz, > > On Mon, Nov 11, 2013 at 6:03 AM, Tomasz Figa wrote: > > Hi Sean, > > > > On Tuesday 29 of October 2013 12:13:05 Sean Paul wrote: > >> This patch uses the mode passed int

[PATCH v3 12/32] drm/exynos: Split manager/display/subdrv

2013-11-29 Thread Tomasz Figa
On Tuesday 26 of November 2013 10:00:13 Olof Johansson wrote: > On Tue, Nov 12, 2013 at 10:35 AM, Tomasz Figa > wrote: > > On Tuesday 12 of November 2013 12:51:11 Sean Paul wrote: > >> On Sun, Nov 10, 2013 at 4:09 PM, Tomasz Figa > >> wrote: > >>

[PATCH v3 12/32] drm/exynos: Split manager/display/subdrv

2013-11-29 Thread Tomasz Figa
On Friday 29 of November 2013 08:52:22 Daniel Vetter wrote: > On Fri, Nov 29, 2013 at 12:04:04AM +0100, Tomasz Figa wrote: > > On Tuesday 26 of November 2013 10:00:13 Olof Johansson wrote: > > > More like code written in the same style as x86 DRM stuff, where >

[PATCH v3 26/32] drm/exynos: Consolidate suspend/resume in drm_drv

2013-11-29 Thread Tomasz Figa
Hi Sean, On Tuesday 29 of October 2013 12:13:12 Sean Paul wrote: > This patch removes all of the suspend/resume logic from the individual > drivers and consolidates it in drm_drv. This consolidation reduces the > number of functions which enable/disable the hardware to just one -- the > dpms

[PATCH v3 28/32] drm/exynos: Implement drm_connector in hdmi directly

2013-11-29 Thread Tomasz Figa
Hi Sean, On Tuesday 29 of October 2013 12:13:14 Sean Paul wrote: > This patch implements drm_connector in the hdmi driver directly, instead > of using exynos_drm_connector. > > Signed-off-by: Sean Paul > --- > > Changes in v3: > - Added to the patchset > >

[PATCH v3 29/32] drm/exynos: Implement drm_connector directly in dp driver

2013-11-29 Thread Tomasz Figa
- Added to the patchset > > drivers/gpu/drm/exynos/exynos_dp_core.c | 99 > ++--- > drivers/gpu/drm/exynos/exynos_dp_core.h | 4 ++ > 2 files changed, 94 insertions(+), 9 deletions(-) Reviewed-by: Tomasz Figa Best regards, Tomasz

[PATCH v3 30/32] drm/exynos: Implement drm_connector directly in vidi driver

2013-11-29 Thread Tomasz Figa
- Added to the patchset > > drivers/gpu/drm/exynos/exynos_drm_vidi.c | 163 > --- > 1 file changed, 107 insertions(+), 56 deletions(-) Reviewed-by: Tomasz Figa Best regards, Tomasz

[PATCH v3 32/32] drm/exynos: Remove the exynos_drm_connector shim

2013-11-29 Thread Tomasz Figa
_connector.c > delete mode 100644 drivers/gpu/drm/exynos/exynos_drm_connector.h Reviewed-by: Tomasz Figa Best regards, Tomasz

[PATCH v3 31/32] drm/exynos: Move lvds bridge discovery into DP driver

2013-11-29 Thread Tomasz Figa
Hi Sean, On Tuesday 29 of October 2013 12:13:17 Sean Paul wrote: > This patch moves the lvds bridge discovery and connector pre-emption > code from exynos common code into the dp driver (since the bridge is > only applicable for dp). > > Signed-off-by: Sean Paul > --- > > Changes in v3: >

[PATCH v3 12/32] drm/exynos: Split manager/display/subdrv

2013-11-29 Thread Tomasz Figa
On Friday 29 of November 2013 09:13:19 Rob Clark wrote: > On Fri, Nov 29, 2013 at 4:10 AM, Tomasz Figa wrote: > > I would mostly agree with you if we were discussing SoC-internal > > components here. Mostly, because the ARM world is more complex and you > > can see the same

[PATCH 4/4] drm: exynos: hdmi: Add dt support for hdmiphy settings

2013-11-29 Thread Tomasz Figa
Hi Shirish, Please see my comments inline. On Monday 25 of November 2013 14:24:39 Shirish S wrote: > This patch adds dt support to hdmiphy config settings > as it is board specific and depends on the signal pattern > of board. > > Signed-off-by: Shirish S > --- >

[PATCH v3 31/32] drm/exynos: Move lvds bridge discovery into DP driver

2013-11-30 Thread Tomasz Figa
Hi Inki, On Saturday 30 of November 2013 14:18:08 Inki Dae wrote: > Hi Tomasz, > > Thanks for review, You're welcome. > > 2013/11/30 Tomasz Figa : > > Hi Sean, > > > > On Tuesday 29 of October 2013 12:13:17 Sean Paul wrote: > >> This patch moves t

[PATCH V3 1/2] drm/exynos: add platform_device_id table and driver data for exynos5 drm fimd

2012-09-05 Thread Tomasz Figa
imd_driver_ids); If I see correctly, this will crash on a null pointer dereference on Exynos4 without DT, because of NULL driver_data. P.S. I think you should CC linux-arm-kernel and linux-samsung-soc lists when submitting patches related to ARM and Samsung SoCs. Best regards, -- Tomasz Figa Samsung Poland R Center

[PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-21 Thread Tomasz Figa
Hi, On Monday 08 of April 2013 16:41:54 Viresh Kumar wrote: > On 8 April 2013 16:37, Vikas Sajjan wrote: > > While migrating to common clock framework (CCF), I found that the FIMD > > clocks were pulled down by the CCF. > > If CCF finds any clock(s) which has NOT been claimed by any of the > >

[PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-21 Thread Tomasz Figa
On Sunday 21 of April 2013 13:23:10 Viresh Kumar wrote: > On 20 April 2013 20:56, Inki Dae wrote: > > Sorry for being late. I think clk_prepare/unprepare are nothing to do > > yet in case of Exynos but those might be used for in the future so > > your patch looks good to me as is. > > > >

[PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-21 Thread Tomasz Figa
Hi Inki, On Sunday 21 of April 2013 23:05:45 Inki Dae wrote: > 2013/4/21 Tomasz Figa > > > On Sunday 21 of April 2013 13:23:10 Viresh Kumar wrote: > > > On 20 April 2013 20:56, Inki Dae wrote: > > > > Sorry for being late. I think clk_prepare/unprepare are

[PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-21 Thread Tomasz Figa
Hi Inki, On Sunday 21 of April 2013 22:36:08 Inki Dae wrote: > 2013/4/21 Tomasz Figa > > > Hi, > > > > On Monday 08 of April 2013 16:41:54 Viresh Kumar wrote: > > > On 8 April 2013 16:37, Vikas Sajjan wrote: > > > > While migra

[PATCH] MAINTAINERS: Add linux-samsung-soc list to all related entries

2013-04-21 Thread Tomasz Figa
, even though they are related to Samsung SoCs. This patch adds pointers to linux-samsung-soc mailing list to affected entries of MAINTAINERS file. Signed-off-by: Tomasz Figa --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6c0d68b

[PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Tomasz Figa
On Sunday 21 of April 2013 22:36:08 Inki Dae wrote: > > > 2013/4/21 Tomasz Figa > > > > > > > Hi, > > > > > > > > On Monday 08 of April 2013 16:41:54 Viresh Kumar wrote: > > > > > On 8 April 2013 16:37, Vikas Sajjan > >

[PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Tomasz Figa
On Monday 22 of April 2013 10:44:00 Viresh Kumar wrote: > On 21 April 2013 20:13, Tomasz Figa wrote: > > 3) after those two changes, all that remains is to fix compliance with > > Common Clock Framework, in other words: > > > > s/clk_enable/clk_prepare_enable/ > >

[PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Tomasz Figa
out making the driver dependant on PM_RUNTIME and making it always > use pm_runtime_* API, regardless if the platform actually implements runtime > PM or not ? Is there any issue in using the Runtime PM core always, rather > than coding any workarounds in drivers when PM_RUNTIME is dis

[PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Tomasz Figa
On Monday 22 of April 2013 12:05:49 Sylwester Nawrocki wrote: > On 04/22/2013 11:56 AM, Tomasz Figa wrote: > > On Monday 22 of April 2013 10:44:00 Viresh Kumar wrote: > >> On 21 April 2013 20:13, Tomasz Figa wrote: > >>> 3) after those two changes, all tha

[PATCH] drm/exynos: fix multiple definition build error

2013-04-26 Thread Tomasz Figa
Hi Inki, On Friday 26 of April 2013 14:03:10 Inki Dae wrote: > This patch fixes multiple definition error like below when building it > as moudle with device tree support. > > drivers/gpu/drm/exynos/exynos_drm_g2d.o: In function `.LANCHOR1': > exynos_drm_g2d.c:(.rodata+0x6c): multiple definition

[PATCH] drm/exynos: fix multiple definition build error

2013-04-26 Thread Tomasz Figa
On Friday 26 of April 2013 11:48:50 Sylwester Nawrocki wrote: > On 04/26/2013 10:20 AM, Inki Dae wrote: > > Exactly right. it's my mistake. But now it seems that > > __mode_of_device_table is multi defined at fimd and g2d side so there > > still is module build error. :( > Since all drivers seem

[PATCH] drm/exynos: Add check for IOMMU while passing physically continous memory flag

2013-08-02 Thread Tomasz Figa
Hi Vikas, On Thursday 01 of August 2013 16:49:32 Vikas Sajjan wrote: > While trying to get boot-logo up on exynos5420 SMDK which has eDP panel > connected with resolution 2560x1600, following error occured even with > IOMMU enabled: > [0.88] [drm:lowlevel_buffer_allocate] *ERROR* failed to

[PATCH] drm/exynos: Add check for IOMMU while passing physically continous memory flag

2013-08-02 Thread Tomasz Figa
Hi Vikas, On Friday 02 of August 2013 12:08:52 Vikas Sajjan wrote: > Hi Rob, > > On 2 August 2013 06:03, Rob Clark wrote: > > On Thu, Aug 1, 2013 at 7:20 PM, Tomasz Figa wrote: > >> Hi Vikas, > >> > >> On Thursday 01 of August 2013 16:49:32 Vikas Sa

[PATCH V2] drm/exynos: Add fallback option to get non physically continous memory for fb

2013-08-05 Thread Tomasz Figa
CONTIG > memory allocation fails. > > Signed-off-by: Vikas Sajjan > Signed-off-by: Arun Kumar > --- > changes since v1: >- Modified to add the fallback patch if CONTIG alloc fails as suggested > by Rob Clark robdclark at gmail.com and Tomasz Figa > . > >

[PATCHv2 1/5] drm/exynos: add device tree support for rotator

2013-08-09 Thread Tomasz Figa
Hi Chanho, On Friday 09 of August 2013 16:40:49 Chanho Park wrote: > The exynos4 platform is only dt-based since 3.10, we should convert > driver data and ids to dt-based parsing methods. The rotator driver has > a limit table to get size limit of input picture. Each SoCs has slightly > different

[PATCHv2 2/5] ARM: dts: Add rotator node for exynos4210

2013-08-09 Thread Tomasz Figa
On Friday 09 of August 2013 16:40:50 Chanho Park wrote: > This patch adds a rotator node for exynos4210. The exynos4210 has > different limitation of image size compared with later chips. > > Signed-off-by: Chanho Park > Cc: Thomas Abraham > Cc: Kukjin Kim > Cc: Inki Dae > Signed-off-by:

[PATCHv2 5/5] ARM: dts: Add dt binding documentation for exynos rotator

2013-08-09 Thread Tomasz Figa
Hi Chanho, On Friday 09 of August 2013 16:40:53 Chanho Park wrote: > This patch describes each nodes of rotator and specifies a example how to > bind it. > > Signed-off-by: Chanho Park > Cc: Thomas Abraham > Cc: Kukjin Kim > Cc: Inki Dae > Signed-off-by: Kyungmin Park > --- >

[PATCHv2 5/5] ARM: dts: Add dt binding documentation for exynos rotator

2013-08-09 Thread Tomasz Figa
On Friday 09 of August 2013 10:38:30 Stephen Warren wrote: > On 08/09/2013 07:15 AM, Tomasz Figa wrote: > > Hi Chanho, > > > > On Friday 09 of August 2013 16:40:53 Chanho Park wrote: > >> This patch describes each nodes of rotator and specifies a example how > >

[PATCH 0/3] Add dt support for exynos hdmiphy settings

2013-08-14 Thread Tomasz Figa
Hi Shirish, On Tuesday 13 of August 2013 12:39:27 Shirish S wrote: > For various revision of chipset if the signal pattern is changed for > every board, then the phy setting need to be updated correspondingly by > measuring the signal. > With the hdmiphy settings fixed in the driver the only way

[PATCH 0/2] update pixel format setting to fimd driver

2013-08-21 Thread Tomasz Figa
ing > drm/exynos: check a pixel format to a particular window layer > > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 45 > -- 1 files changed, 24 insertions(+), 21 > deletions(-) For the whole series: Reviewed-by: Tomasz Figa Best regards, Tomasz

[PATCH 6/6] drm/exynos: Make Exynos DRM drivers depend on OF

2013-08-22 Thread Tomasz Figa
Hi Sachin, On Thursday 22 of August 2013 11:15:23 Sachin Kamat wrote: > Exynos is a DT-only platform. Add this info to Kconfig. > > Signed-off-by: Sachin Kamat > --- > drivers/gpu/drm/exynos/Kconfig |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

[PATCH v3 28/32] drm/exynos: Implement drm_connector in hdmi directly

2013-12-02 Thread Tomasz Figa
On Monday 02 of December 2013 10:46:37 Thierry Reding wrote: > On Fri, Nov 29, 2013 at 04:58:46PM +0100, Tomasz Figa wrote: > > On Tuesday 29 of October 2013 12:13:14 Sean Paul wrote: > [...] > > > diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c > > > b/driver

[PATCH] of: Add MIPI DSI bus device tree bindings

2013-12-02 Thread Tomasz Figa
+ > + #address-cells = <1>; > + #size-cells = <0>; > + > + peripheral at 0 { > + compatible = "..."; > + reg = <0>; > + }; > + > + ... > + }; > In general, this looks good to me as a starter, so we could have support for DSI bus merged. IMHO we should consider adding some generic bus properties in future, though. Anyway, have my Reviewed-by: Tomasz Figa Best regards, Tomasz

[PATCH 4/4] drm: exynos: hdmi: Add dt support for hdmiphy settings

2013-12-19 Thread Tomasz Figa
On Thursday 19 of December 2013 17:42:28 Shirish S wrote: > This patch adds dt support to hdmiphy config settings > as it is board specific and depends on the signal pattern > of board. > > Signed-off-by: Shirish S > --- > .../devicetree/bindings/video/exynos_hdmi.txt | 34 >

[RFC PATCH 0/4] Common Display Framework-TF

2013-02-03 Thread Tomasz Figa
Hi Laurent, On Saturday 02 of February 2013 11:39:59 Laurent Pinchart wrote: > Hi Tomasz, > > Thank you for your RFC. > > On Wednesday 30 January 2013 16:38:59 Tomasz Figa wrote: > > Hi, > > > > After pretty long time of trying to adapt Exynos-specific DSI disp

[RFC PATCH 4/4] video: display: Add Samsung s6e8ax0 display panel driver

2013-02-07 Thread Tomasz Figa
On Thursday 07 of February 2013 15:04:30 Vikas Sajjan wrote: > Hi Figa, > > On Wed, Jan 30, 2013 at 9:09 PM, Tomasz Figa wrote: > > This patch adds Common Display Framework driver for Samsung s6e8ax0 > > MIPI DSI display panel. > > > > Signed-off-by: Tomasz

[PATCH 2/2] [RFC] video: display: Adding frame related ops to MIPI DSI video source struct

2013-01-03 Thread Tomasz Figa
nd clear_frame_done do not look at anything used at the moment and if frame done status monitoring will be ever needed, I think a better way should be implemented. Best regards, -- Tomasz Figa Samsung Poland R Center SW Solution Development, Linux Platform

[RFC v2 0/5] Common Display Framework

2013-01-08 Thread Tomasz Figa
On Tuesday 08 of January 2013 11:12:26 Marcus Lorentzon wrote: > On 01/08/2013 09:18 AM, Laurent Pinchart wrote: > > On Thursday 27 December 2012 15:43:34 Tomasz Figa wrote: > >> > On Monday 24 of December 2012 15:12:28 Laurent Pinchart wrote: > >>> > &g

[RFC PATCH 0/4] Common Display Framework-TF

2013-01-30 Thread Tomasz Figa
de control over entity state to userspace using lcd device. However it can be used to demonstrate video source ops in use. Feel free to comment as much as you can. Tomasz Figa (4): video: add display-core video: add makefile & kconfig video: display: Add exynos-dsi video source

[RFC PATCH 1/4] video: add display-core

2013-01-30 Thread Tomasz Figa
Signed-off-by: Tomasz Figa Signed-off-by: Kyungmin Park --- drivers/video/display/display-core.c | 295 +++ include/video/display.h | 230 +++ 2 files changed, 525 insertions(+) create mode 100644 drivers/video/display

[RFC PATCH 2/4] video: add makefile & kconfig

2013-01-30 Thread Tomasz Figa
Signed-off-by: Tomasz Figa Signed-off-by: Kyungmin Park --- drivers/video/Kconfig | 1 + drivers/video/Makefile | 1 + drivers/video/display/Kconfig | 10 ++ drivers/video/display/Makefile | 1 + 4 files changed, 13 insertions(+) create mode 100644 drivers/video

[RFC PATCH 3/4] video: display: Add exynos-dsi video source driver

2013-01-30 Thread Tomasz Figa
This patch adds new driver for DSI master block available in Samsung Exynos SoCs. The driver is designed and written specifically for Common Display Framework. Signed-off-by: Tomasz Figa Signed-off-by: Kyungmin Park --- drivers/video/display/Kconfig |3 + drivers/video/display

[RFC PATCH 4/4] video: display: Add Samsung s6e8ax0 display panel driver

2013-01-30 Thread Tomasz Figa
This patch adds Common Display Framework driver for Samsung s6e8ax0 MIPI DSI display panel. Signed-off-by: Tomasz Figa Signed-off-by: Kyungmin Park --- drivers/video/display/Kconfig |3 + drivers/video/display/Makefile|1 + drivers/video/display/panel-s6e8ax0.c | 1027

[PATCH] drm/exynos: Add missing includes

2013-07-06 Thread Tomasz Figa
On Tuesday 02 of July 2013 16:04:49 Mark Brown wrote: > On Tue, Jul 02, 2013 at 09:21:32PM +0900, Inki Dae wrote: > > > Ensure that all externally accessed functions are correctly > > > prototyped > > > when defined in each file by making sure the headers with the > > > protoypes > > > are

[PATCH] drm/exynos: exynos_drm_ipp: fix return value check

2013-07-06 Thread Tomasz Figa
jun > --- > drivers/gpu/drm/exynos/exynos_drm_ipp.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > Reviewed-by: Tomasz Figa Best regards, Tomasz

DT binding review for Armada display subsystem

2013-07-15 Thread Tomasz Figa
Hi, On Sunday 14 of July 2013 00:09:55 Russell King - ARM Linux wrote: > On Sun, Jul 14, 2013 at 12:16:58AM +0200, Sylwester Nawrocki wrote: > > On 07/13/2013 11:02 PM, Russell King - ARM Linux wrote: > >> On Sat, Jul 13, 2013 at 10:43:29PM +0200, Sylwester Nawrocki wrote: > >>> I wasn't aware of

[PATCH 2/3] drm/exynos: add dt-binding documentation for rotator

2013-07-22 Thread Tomasz Figa
On Monday 22 of July 2013 16:00:22 Sylwester Nawrocki wrote: > On 07/22/2013 03:31 PM, Inki Dae wrote: > >> ---Original Message- > >> > >> > From: linux-samsung-soc-owner at vger.kernel.org > >> > [mailto:linux-samsung-soc- owner at vger.kernel.org] On Behalf Of > >> > Lucas Stach > >> >

[PATCH 1/3] drm/exynos: add device tree support for rotator

2013-07-22 Thread Tomasz Figa
On Monday 22 of July 2013 15:49:25 Chanho Park wrote: > The exynos4 platform is only dt-based since 3.10, we should convert > driver data and ids to dt-based parsing methods. The rotator driver has > a limit table to get size limit. The minimum size of RGB888 format is 8 > x 8 and maximum size is

[PATCH] drm/exynos: fimd: Get signal polarities from device tree

2013-06-05 Thread Tomasz Figa
On Wednesday 01 of May 2013 21:06:09 Tomasz Figa wrote: > This patch modifies the driver to perform two stage parsing of video > timings from device tree, to get timing information as struct videomode, > which contains more data than struct fb_videomode. > > Thanks to this chan

[PATCH 0/4] drm/exynos: fimd: Add support for S3C6400/S3C6410

2013-06-05 Thread Tomasz Figa
On Sunday 19 of May 2013 13:26:57 Tomasz Figa wrote: > Hi, > > On Wednesday 01 of May 2013 21:02:25 Tomasz Figa wrote: > > Much of the code in Exynos DRM subsystem is generic enough to use > > it for older (non-Exynos) Samsung SoCs as well, after minor > > modifica

[PATCH] drm/exynos: fimd: Get signal polarities from device tree

2013-06-06 Thread Tomasz Figa
Hi Joonyoung, On Thursday 06 of June 2013 13:30:49 Joonyoung Shim wrote: > On 05/19/2013 08:32 PM, Tomasz Figa wrote: > > Hi, > > > > On Wednesday 01 of May 2013 22:00:25 Daniel Vetter wrote: > >> On Wed, May 01, 2013 at 09:06:09PM +0200, Tomasz Figa wrote: > &

[PATCH 1/4] drm/exynos: rename compatible strings for hdmi subsystem

2013-06-19 Thread Tomasz Figa
Hi Rahul, On Tuesday 18 of June 2013 18:19:35 Rahul Sharma wrote: > This patch renames the combatible strings for hdmi, mixer, ddc > and hdmiphy. It follows the convention of using compatible string > which represent the SoC in which the IP was added for the first > time. > > Signed-off-by:

[PATCH 1/4] drm/exynos: rename compatible strings for hdmi subsystem

2013-06-19 Thread Tomasz Figa
i-devel-bounces+inki.dae=samsung.com at lists.freedesktop.org] On > >> Behalf Of Lucas Stach > >> Sent: Wednesday, June 19, 2013 4:59 PM > >> To: Tomasz Figa > >> Cc: kgene.kim at samsung.com; devicetree-discuss at lists.ozlabs.org; > >> sw0312.kim

[PATCH v3 1/3] drm/exynos: add new compatible strings for hdmi subsystem

2013-06-20 Thread Tomasz Figa
Hi Rahul, On Thursday 20 of June 2013 07:41:53 Rahul Sharma wrote: > Hi Tomasz, Lucas, > > How does this patch look to you ? Please share your views. Looks fine now. Have my Reviewed-by: Tomasz Figa for the whole series. Best regards, Tomasz > regards, > Rahul Sharma. >

[PATCH v2] drm/rockchip: Add BGR formats to VOP

2015-05-30 Thread Tomasz Figa
On Mon, May 11, 2015 at 7:55 PM, Tomasz Figa wrote: > VOP can support BGR formats in all windows thanks to red/blue swap option > provided in WINx_CTRL0 registers. This patch enables support for > ABGR, XBGR, BGR888 and BGR565 formats by using this feature. > > Signed-off-

[PATCH v6 01/12] dt-bindings: drm/mediatek: Add Mediatek display subsystem dts binding

2015-11-24 Thread Tomasz Figa
Hi Philipp, CK, Please see my comments inline. On Thu, Nov 19, 2015 at 2:34 AM, Philipp Zabel wrote: > From: CK Hu > > Add device tree binding documentation for the display subsystem in > Mediatek MT8173 SoCs. > > Signed-off-by: CK Hu > Signed-off-by: Philipp Zabel > Acked-by: Rob Herring

[PATCH v6 02/12] drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.

2015-11-24 Thread Tomasz Figa
Hi Philipp, CK, Please see my comments inline. On Thu, Nov 19, 2015 at 2:34 AM, Philipp Zabel wrote: [snip] > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > new file mode 100644 > index 000..508c8f3 > --- /dev/null > +++

[GIT PULL] drm/rockchip: fixes and new features

2015-07-01 Thread Tomasz Figa
On Wed, Jul 1, 2015 at 5:20 PM, Daniel Vetter wrote: > On Wed, Jul 01, 2015 at 05:03:39PM +0900, Tomasz Figa wrote: >> Hi Mark, >> >> On Tue, Jun 30, 2015 at 3:50 PM, Mark yao wrote: >> > >> > Hi Dave. >> > >> > Som

[GIT PULL] drm/rockchip: fixes and new features

2015-07-01 Thread Tomasz Figa
On Wed, Jul 1, 2015 at 5:32 PM, Mark yao wrote: > On 2015年07月01日 16:03, Tomasz Figa wrote: >> >> Hi Mark, >> >> On Tue, Jun 30, 2015 at 3:50 PM, Mark yao wrote: >>> >>> Hi Dave. >>> >>> Some fixes and some new features.

[GIT PULL] drm/rockchip: fixes and new features

2015-07-01 Thread Tomasz Figa
On Wed, Jul 1, 2015 at 6:13 PM, Mark yao wrote: By the way, if we're using window 3 for cursor plane, because the cursor window needs special handling, is it okay to expose the cusor window as an overlay plane to userspace, as we do currently? >>> >>> >>> special handling? what

[PATCH v2 1/5] drm/rockchip: vop: optimize virtual stride calculate

2015-07-02 Thread Tomasz Figa
On Fri, Jun 26, 2015 at 7:07 PM, Mark Yao wrote: > vir_stride need number words of the virtual width, and fb->pitches > save bytes_per_pixel, so just div 4 switch to stride. > > Signed-off-by: Mark Yao > --- > Changes in v2: None > > drivers/gpu/drm/rockchip/rockchip_drm_vop.c |2 +- > 1

[PATCH v2 2/5] drm/rockchip: vop: fix yuv plane support

2015-07-02 Thread Tomasz Figa
Hi Mark, Please see my comments inline. On Fri, Jun 26, 2015 at 7:07 PM, Mark Yao wrote: > vop support yuv with NV12, NV16 and NV24, only 2 plane yuv. > > Signed-off-by: Mark Yao > > Changes in v2: > - Uv buffer not support odd offset, align it. > - Fix error display when move yuv image. > >

[PATCH v2 2/5] drm/rockchip: vop: fix yuv plane support

2015-07-02 Thread Tomasz Figa
On Thu, Jul 2, 2015 at 3:53 PM, Mark yao wrote: > Hi Tomasz > Thanks for your review, I will fix it soon. > > On 2015年07月02日 14:00, Tomasz Figa wrote: >> >> Hi Mark, >> >> Please see my comments inline. >> >> On Fri, Jun 26, 2015 at 7

[PATCH v2 3/5] drm/rockchip: vop: support plane scale

2015-07-03 Thread Tomasz Figa
Hi Mark, Please see my comments inline. On Fri, Jun 26, 2015 at 7:07 PM, Mark Yao wrote: > Win_full support 1/8 to 8 scale down/up engine, support > all format scale. [snip] > @@ -351,6 +412,15 @@ static inline void vop_mask_write_relaxed(struct vop > *vop, uint32_t offset, > } > }

[PATCH v2 4/5] drm/rockchip: vop: switch cursor plane to window 3

2015-07-03 Thread Tomasz Figa
--- > 1 file changed, 4 insertions(+), 3 deletions(-) > Reviewed-by: Tomasz Figa Best regards, Tomasz

[PATCH v2 5/5] drm/rockchip: default enable win2/3 area0 bit

2015-07-03 Thread Tomasz Figa
Hi Mark, Please see my comments inline. On Fri, Jun 26, 2015 at 7:10 PM, Mark Yao wrote: > Win2/3 support 4 area display, but now havn't found a suitable > way to use it, and it enable by win gate and area gate, > so default enable area0 gate, so that its behaviour just like a > win. So I

[PATCH v2 5/5] drm/rockchip: default enable win2/3 area0 bit

2015-07-03 Thread Tomasz Figa
On Fri, Jul 3, 2015 at 5:19 PM, Mark yao wrote: > On 2015年07月03日 16:02, Tomasz Figa wrote: >> >> Hi Mark, >> >> Please see my comments inline. >> >> On Fri, Jun 26, 2015 at 7:10 PM, Mark Yao wrote: >>> >>> Win2/3 support 4 are

[PATCH v2 3/5] drm/rockchip: vop: support plane scale

2015-07-03 Thread Tomasz Figa
On Fri, Jul 3, 2015 at 6:17 PM, Mark yao wrote: >>> +static void _vop_cal_scl_fac(struct vop *vop, const struct vop_win_data >>> *win, >>> +uint32_t src_w, uint32_t src_h, uint32_t >>> dst_w, >>> +uint32_t dst_h, uint32_t pixel_format) >>>

[PATCH v2 3/5] drm/rockchip: vop: support plane scale

2015-07-04 Thread Tomasz Figa
On Fri, Jul 3, 2015 at 7:22 PM, Mark yao wrote: > On 2015年07月03日 17:58, Tomasz Figa wrote: >>>> >>>> >>Aren't the scl_modes for CbCr planes always the same as for Y plane? >>> >>> > >>> > >>> >No, such as src

[PATCH v2 5/5] drm/rockchip: default enable win2/3 area0 bit

2015-07-21 Thread Tomasz Figa
On Fri, Jul 3, 2015 at 7:08 PM, Mark yao wrote: > On 2015年07月03日 17:24, Tomasz Figa wrote: >> >> On Fri, Jul 3, 2015 at 5:19 PM, Mark yao wrote: >>> >>> On 2015年07月03日 16:02, Tomasz Figa wrote: >>>> >>>> Hi Mark, >>>&g

[PATCH v2] drm/rockchip: vop: remove hardware cursor window

2015-07-21 Thread Tomasz Figa
> 1 file changed, 11 deletions(-) Reviewed-by: Tomasz Figa Best regards, Tomasz

[PATCH v2 4/5] drm/rockchip: vop: switch cursor plane to window 3

2015-07-21 Thread Tomasz Figa
I missed it originally, but if it's not too late yet... On Fri, Jun 26, 2015 at 7:07 PM, Mark Yao wrote: > Window 1 support scale and yuv format, it's waste use it for a > cursor, use window 3 is enough. > > Signed-off-by: Mark Yao > --- > Changes in v2: None > >

[GIT PULL] drm/rockchip: fixes and new features

2015-07-01 Thread Tomasz Figa
Hi Mark, On Tue, Jun 30, 2015 at 3:50 PM, Mark yao wrote: > > Hi Dave. > > Some fixes and some new features. I'd like you can pull them. > > The following changes since commit c5fd936e992dd2829167d2adc63e151675ca6898: > > drm/nouveau: Pause between setting gpu to D3hot and cutting the

[PATCH] drm/rockchip: Add BGR formats to VOP

2015-05-08 Thread Tomasz Figa
VOP can support BGR formats in all windows thanks to red/blue swap option provided in WINx_CTRL0 registers. This patch enables support for ABGR, XBGR, BGR888 and BGR565 formats by using this feature. Signed-off-by: Tomasz Figa --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 33

[PATCH] drm/prime: Allow internal imports without import_sg_table

2015-05-08 Thread Tomasz Figa
patch makes the helper check this condition only in case of external imports fo rwhich importing sg table is indeed needed. Signed-off-by: Tomasz Figa --- drivers/gpu/drm/drm_prime.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/g

[PATCH] drm/rockchip: Add BGR formats to VOP

2015-05-08 Thread Tomasz Figa
Hi Mark, Thanks for review. On Fri, May 8, 2015 at 5:40 PM, Mark yao wrote: >> @@ -233,6 +243,7 @@ static const struct vop_win_phy win23_data = { >> .nformats = ARRAY_SIZE(formats_234), >> .enable = VOP_REG(WIN2_CTRL0, 0x1, 0), >> .format = VOP_REG(WIN2_CTRL0, 0x7, 1),

[PATCH v2] drm/rockchip: Add BGR formats to VOP

2015-05-11 Thread Tomasz Figa
VOP can support BGR formats in all windows thanks to red/blue swap option provided in WINx_CTRL0 registers. This patch enables support for ABGR, XBGR, BGR888 and BGR565 formats by using this feature. Signed-off-by: Tomasz Figa --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 33

[RFC v2 0/5] Common Display Framework

2012-12-21 Thread Tomasz Figa
ed panel, add > the panel device (device_add() ) to kernel and register the display > entity with its control and video ops with CDF. > > I can give this a try. I am currently in progress of reworking Exynos MIPI DSIM code and s6e8ax0 LCD driver to use the v2 RFC of Common Display Framework. I have most of the work done, I have just to solve several remaining problems. Best regards, -- Tomasz Figa Samsung Poland R Center SW Solution Development, Linux Platform

[RFC v2 0/5] Common Display Framework

2012-12-27 Thread Tomasz Figa
Hi Laurent, On Monday 24 of December 2012 15:12:28 Laurent Pinchart wrote: > Hi Tomasz, > > On Friday 21 December 2012 11:00:52 Tomasz Figa wrote: > > On Tuesday 18 of December 2012 08:31:30 Vikas Sajjan wrote: > > > On 17 December 2012 20:55, Laurent Pinchart

[RFC 0/6] Common Display Framework-T

2012-12-31 Thread Tomasz Figa
plit the display entities into video sources > > > (struct > > > video_source) and display entities (struct display_entity). To make > > > generic pipeline operations easier, we agreed to merge the video > > > source > > > and the display entity back. struct displ

[PATCH 1/3] Move FIMD register headers to include/video/

2012-07-30 Thread Tomasz Figa
Hi, On Monday 30 of July 2012 at 16:46:03, Leela Krishna Amudala wrote: > Hello Jingoo Han, > > On Mon, Jul 30, 2012 at 2:23 PM, Jingoo Han wrote: > > On Monday, July 30, 2012 5:45 PM, Leela Krishna Amudala wrote: > >> Moved the contents of regs-fb-v4.h and regs-fb.h from arch side > >> to

[PATCH 1/3] Move FIMD register headers to include/video/

2012-07-31 Thread Tomasz Figa
(0x10)) > > In this case, the FIMD driver does not need to change. > Also, one binary is available. > This would look good indeed, but there are some drawbacks: - it would not scale nicely for future SoCs using the new FIMD - it would add the overhead of checking SoC ID for every access

Re: [PATCH 34/41] drm/bridge: analogix_dp: Allow master driver to cleanup in unbind

2017-03-09 Thread Tomasz Figa
Hi Sean, On Fri, Mar 10, 2017 at 1:32 PM, Sean Paul <seanp...@chromium.org> wrote: > > From: Tomasz Figa <tf...@chromium.org> > > Since we take the ownership of drvdata, the master driver does not have > any means of accessing its own data from unbind callback and

Re: [RFC v4 10/18] vb2: dma-contig: Fix DMA attribute and cache management

2017-05-10 Thread Tomasz Figa
Hi Sakari, Some comments inline. On Mon, May 8, 2017 at 11:03 PM, Sakari Ailus wrote: > Patch ccc66e73 ("ARM: 8508/2: videobuf2-dc: Let drivers specify DMA > attrs") added support for driver specific DMA attributes to > videobuf2-dma-contig but it had several

Re: [RFC v4 07/18] vb2: dma-contig: Remove redundant sgt_base field

2017-05-10 Thread Tomasz Figa
Hi Sakari, Some comments inline. On Mon, May 8, 2017 at 11:03 PM, Sakari Ailus wrote: > The struct vb2_dc_buf contains two struct sg_table fields: sgt_base and > dma_sgt. The former is used by DMA-BUF buffers whereas the latter is used > by USERPTR. > > Unify the

Re: [RFC v4 13/18] vb2: Don't sync cache for a buffer if so requested

2017-05-10 Thread Tomasz Figa
Hi Sakari, Few comments inline. On Mon, May 8, 2017 at 11:03 PM, Sakari Ailus wrote: > From: Samu Onkalo > > The user may request to the driver (vb2) to skip the cache maintenance > operations in case the buffer does not need cache

Re: [RFC 0/4] Exynos DRM: add Picture Processor extension

2017-05-09 Thread Tomasz Figa
Hi Everyone, On Wed, May 10, 2017 at 9:24 AM, Inki Dae wrote: > > > 2017년 04월 26일 07:21에 Sakari Ailus 이(가) 쓴 글: >> Hi Marek, >> >> On Thu, Apr 20, 2017 at 01:23:09PM +0200, Marek Szyprowski wrote: >>> Hi Laurent, >>> >>> On 2017-04-20 12:25, Laurent Pinchart wrote: Hi

Re: [RFC 0/4] Exynos DRM: add Picture Processor extension

2017-05-10 Thread Tomasz Figa
On Wed, May 10, 2017 at 2:27 PM, Inki Dae <inki@samsung.com> wrote: > Hi Tomasz, > > 2017년 05월 10일 14:38에 Tomasz Figa 이(가) 쓴 글: >> Hi Everyone, >> >> On Wed, May 10, 2017 at 9:24 AM, Inki Dae <inki@samsung.com> wrote: >>> >>> >

minigbm/cros_gralloc handle struct (Was: Re: [drm_hwc] PSA: drm_hwc submissions via gitlab)

2018-05-06 Thread Tomasz Figa
[Really taking this to another thread. Leaving CC as is for the time being.] On Sat, May 5, 2018 at 4:16 AM Mauro Rossi wrote: > > Il 04 mag 2018 19:51, "Alistair Strachan" ha > scritto: > > On Fri, May 4, 2018 at 10:35 AM Sean Paul

Re: [PATCH] drm/rockchip: vop: fix irq disabled after vop driver probed

2018-05-24 Thread Tomasz Figa
Hi Heiko, Sandy, On Fri, May 25, 2018 at 7:07 AM Heiko Stübner wrote: > From: Sandy Huang > The vop irq is shared between vop and iommu and irq probing in the > iommu driver moved to the probe function recently. This can in some > cases lead to a stall if

Re: [PATCH v4 1/2] drm/rockchip: vop: split out core clock enablement into separate functions

2018-06-18 Thread Tomasz Figa
d, 31 insertions(+), 13 deletions(-) Reviewed-by: Tomasz Figa Best regards, Tomasz ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v3 2/2] drm/rockchip: vop: fix irq disabled after vop driver probed

2018-06-18 Thread Tomasz Figa
active_irqs); > > + vop_core_clks_disable(vop); > + > +out: > + pm_runtime_put(vop->dev); > return ret; > } Other than that: Reviewed-by: Tomasz Figa Best regards, Tomasz ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

<    1   2   3   4   5   >