First thing that struck me is that the chip's reset is actually low active
reset-gpios = < 3 24 GPIO_ACTIVE_LOW>; /* PD24 */
(please correct this in patches 11 and 12)
Consequently, you're using inverted values here in the driver:
> +static void
On Thu, Oct 18, 2018 at 03:33:18PM +0800, Icenowy Zheng wrote:
> This patchset brings the support for Analogix ANX6345 RGB-(e)DP bridge,
> which is used by some Allwinner A64 laptops, such as Pinebook and Olimex
> TERES-I.
>
So what's the status here? I'm working on the Teres-I and I find myself
On Thu, May 16, 2019 at 09:06:41AM -0700, Vasily Khoruzhick wrote:
>
> Driver can talk to the panel over AUX channel only after t1+t3, t1 is
> up to 10ms, t3 is up to 200ms.
This is after power-on. The boot loader needs to deal with this.
> It works with older version of driver
> that keeps
On Fri, 17 May 2019 09:27:38 +0200
Maxime Ripard wrote:
> On Thu, May 16, 2019 at 06:48:59PM +0200, Torsten Duwe wrote:
> > On Thu, May 16, 2019 at 09:06:41AM -0700, Vasily Khoruzhick wrote:
> > >
> > > Driver can talk to the panel over AUX channel only after t1+t3,
On Fri, May 17, 2019 at 11:08:45AM +0200, Maxime Ripard wrote:
> >
> > So for all current practical purposes, we can assume the Teres-I panel
> > to be powered properly and providing valid EDID; nothing to worry about
> > in software.
>
> You're creating a generic binding for all the users of
Hi all,
left over from my previous Teres-I device tree series, here comes
the revised anx6345 node for the Teres-I, along with the driver.
The innolux panel attached to it is already known; pinebooks can be
enabled on top of this series, once their panels are introduced.
Changes from the
From: Icenowy Zheng
As ANA78xx chips are designed and produced by Analogix Semiconductor,
Inc, move their driver codes into analogix subdirectory.
Signed-off-by: Icenowy Zheng
Signed-off-by: Vasily Khoruzhick
Reviewed-by: Laurent Pinchart
Signed-off-by: Torsten Duwe
---
drivers/gpu/drm
Teres-I has an anx6345 bridge connected to the RGB666 LCD output, and
the I2C controlling signals are connected to I2C0 bus. eDP output goes
to an Innolux N116BGE panel.
Enable it in the device tree.
Signed-off-by: Icenowy Zheng
Signed-off-by: Torsten Duwe
---
.../boot/dts/allwinner/sun50i
ANX6345 LVTTL->eDP video bridge, driver with device tree bindings.
Changes from v1:
* fixed up copyright information. Most code changes are only moves and thus
retain copyright and module ownership. Even the new analogix-anx6345.c
originates
from the old 1495-line analogix-anx78xx.c,
-off-by: Vasily Khoruzhick
Signed-off-by: Torsten Duwe
---
drivers/gpu/drm/bridge/analogix/analogix-anx78xx.h | 465 +
.../gpu/drm/bridge/analogix/analogix-i2c-dptx.h| 256
.../drm/bridge/analogix/analogix-i2c-txcommon.h| 242 +++
3 files changed
Add bit definitions required for the anx6345 and add a
sanity check in anx_dp_aux_transfer.
Signed-off-by: Icenowy Zheng
Signed-off-by: Vasily Khoruzhick
Signed-off-by: Torsten Duwe
---
drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.c | 2 +-
drivers/gpu/drm/bridge/analogix/analogix
The anx6345 is an ultra-low power DisplayPort/eDP transmitter designed
for portable devices.
Add a binding document for it.
Signed-off-by: Icenowy Zheng
Signed-off-by: Vasily Khoruzhick
Reviewed-by: Rob Herring
Signed-off-by: Torsten Duwe
Reviewed-by: Laurent Pinchart
---
.../devicetree
-by: Vasily Khoruzhick
Signed-off-by: Torsten Duwe
---
drivers/gpu/drm/bridge/analogix/Kconfig| 12 +
drivers/gpu/drm/bridge/analogix/Makefile | 1 +
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 814 +
3 files changed, 827 insertions(+)
create
From: Icenowy Zheng
Some code can be shared within different DP bridges by Analogix.
Extract them to analogix_dp.
Signed-off-by: Icenowy Zheng
Signed-off-by: Vasily Khoruzhick
Signed-off-by: Torsten Duwe
---
drivers/gpu/drm/bridge/analogix/Makefile | 2 +-
drivers/gpu/drm/bridge
On Tue, Jun 04, 2019 at 08:08:40AM -0700, Vasily Khoruzhick wrote:
> On Tue, Jun 4, 2019 at 5:23 AM Torsten Duwe wrote:
> >
> > Teres-I has an anx6345 bridge connected to the RGB666 LCD output, and
> > the I2C controlling signals are connected to I2C0 bus. eDP output g
On Fri, Jun 07, 2019 at 08:28:02AM +0200, Maxime Ripard wrote:
> On Thu, Jun 06, 2019 at 03:59:27PM +0200, Harald Geyer wrote:
> >
> > If think valid compatible properties would be:
> > compatible = "innolux,n116bge", "simple-panel";
> > compatible = "edp-connector", "simple-panel";
>
> A
On Wed, Jun 12, 2019 at 10:16:37AM +0200, Andrzej Hajda wrote:
> > +The ANX6345 is an ultra-low power Full-HD eDP transmitter designed for
> > +portable devices.
> > +
> > +Required properties:
> > +
> > + - compatible : "analogix,anx6345"
> > + - reg : I2C address
On Tue, 14 May 2019 10:48:40 -0700
Vasily Khoruzhick wrote:
> > + anx6345: anx6345@38 {
> > + compatible = "analogix,anx6345";
> > + reg = <0x38>;
> > + reset-gpios = < 3 24 GPIO_ACTIVE_LOW>; /* PD24
> > */
> > + dvdd25-supply =
Hi all,
based on Maxime's sunxi-dt64-for-5.2, here is what I found so far
still missing in the device tree. Those bits and pieces have already
been submitted but were not yet applied. Currently I also have the
uart1 for bluetooth here, but I'm unsure about the bindings for the
in-kernel btuart.
From: Icenowy Zheng
Some code can be shared within different DP bridges by Analogix.
Extract them to a new module.
Signed-off-by: Icenowy Zheng
Signed-off-by: Vasily Khoruzhick
Signed-off-by: Torsten Duwe
---
drivers/gpu/drm/bridge/analogix/Kconfig| 4 +
drivers/gpu/drm
-by: Vasily Khoruzhick
Signed-off-by: Torsten Duwe
---
drivers/gpu/drm/bridge/analogix/Kconfig| 11 +
drivers/gpu/drm/bridge/analogix/Makefile | 1 +
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 808 +
.../gpu/drm/bridge/analogix/analogix-i2c
From: Icenowy Zheng
The anx6345 is an ultra-low power DisplayPort/eDP transmitter designed
for portable devices.
Add a binding document for it.
Signed-off-by: Icenowy Zheng
Signed-off-by: Vasily Khoruzhick
Reviewed-by: Rob Herring
Signed-off-by: Torsten Duwe
---
.../bindings/display
From: Icenowy Zheng
Teres-I has an anx6345 bridge connected to the RGB666 LCD output, and
the I2C controlling signals are connected to I2C0 bus. eDP output goes
to an Innolux N116BGE panel.
Enable it in the device tree.
Signed-off-by: Icenowy Zheng
Signed-off-by: Torsten Duwe
---
arch/arm64
From: Icenowy Zheng
As ANA78xx chips are designed and produced by Analogix Semiconductor,
Inc, move their driver codes into analogix subdirectory.
Signed-off-by: Icenowy Zheng
Signed-off-by: Vasily Khoruzhick
Reviewed-by: Laurent Pinchart
Signed-off-by: Torsten Duwe
---
drivers/gpu/drm
-off-by: Vasily Khoruzhick
Signed-off-by: Torsten Duwe
---
drivers/gpu/drm/bridge/analogix/analogix-anx78xx.h | 464 +
.../gpu/drm/bridge/analogix/analogix-i2c-dptx.h| 248 +++
.../drm/bridge/analogix/analogix-i2c-txcommon.h| 237 +++
3 files changed
On Thu, May 23, 2019 at 10:50:35AM +0300, Laurent Pinchart wrote:
> On Thu, May 23, 2019 at 03:40:25PM +0800, Chen-Yu Tsai wrote:
> >
> > If this was simple code movement, then the original copyright still applies.
> > A different copyright notice should not be used. I suppose the same applies
>
On Thu, May 23, 2019 at 11:05:40AM +0200, Maxime Ripard wrote:
> > +Optional properties:
> > +
> > + - Video ports for RGB input and eDP output using the DT bindings
> > + defined in [1]
>
> The output node can be optional, but the input one is probably going
> to be needed all the time, since
On Thu, May 23, 2019 at 10:50:41AM +0300, Laurent Pinchart wrote:
> Hi Torsten,
>
> Thank you for the patch.
Thank you for the thorough review!
> On Thu, May 23, 2019 at 08:53:56AM +0200, Torsten Duwe wrote:
> > +{
> > + struct anx6345 *anx6345 = connector_to_anx6345
On Thu, May 23, 2019 at 07:48:03AM -0700, Vasily Khoruzhick wrote:
> On Wed, May 22, 2019 at 11:54 PM Torsten Duwe wrote:
> >
> >
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-tere
On Wed, May 15, 2019 at 08:08:57AM -0700, Vasily Khoruzhick wrote:
> On Wed, May 15, 2019 at 12:32 AM Torsten Duwe wrote:
> >
> > It does comply with the bindings. The ports are all optional.
> > As far as DT is concerned, the signal path ends here. This is also the
> >
Hi all,
based on Maxime's sunxi-dt64-for-5.2, here is what I found so far
still missing in the device tree. Those bits and pieces have already
been submitted but were not yet applied.
Changes since v1:
* lcd-rgb666-pins
-
* dvdd12-supply, dvdd25-supply now are required by the
From: Icenowy Zheng
The ANX6345 is an ultra-low power DisplayPort/eDP transmitter designed
for portable devices.
Add a binding document for it.
Signed-off-by: Icenowy Zheng
Signed-off-by: Vasily Khoruzhick
Reviewed-by: Rob Herring
Signed-off-by: Torsten Duwe
---
.../bindings/display
Signed-off-by: Harald Geyer
Signed-off-by: Torsten Duwe
---
.../boot/dts/allwinner/sun50i-a64-teres-i.dts | 53 +++
1 file changed, 53 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
index f9
From: Icenowy Zheng
Allwinner A64's TCON0 can output RGB666 LCD signal.
Add its pinmux.
Signed-off-by: Icenowy Zheng
Signed-off-by: Vasily Khoruzhick
Signed-off-by: Torsten Duwe
---
arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 9 +
1 file changed, 9 insertions(+)
diff --git
From: Icenowy Zheng
TERES-I has an ANX6345 bridge connected to the RGB666 LCD output, and
the I2C controlling signals are connected to I2C0 bus.
Enable it in the device tree.
Signed-off-by: Icenowy Zheng
Signed-off-by: Torsten Duwe
---
originally: patchwork.kernel.org/patch/10646867
From: Icenowy Zheng
Allwinner A64's TCON0 can output RGB666 LCD signal.
Add its pinmux.
Signed-off-by: Icenowy Zheng
Signed-off-by: Vasily Khoruzhick
Signed-off-by: Torsten Duwe
---
originally: patchwork.kernel.org/patch/10814179
Almost trivial, and obviously correct.
I added the /omit
From: Icenowy Zheng
The ANX6345 is an ultra-low power DisplayPort/eDP transmitter designed
for portable devices.
Add a binding document for it.
Signed-off-by: Icenowy Zheng
Signed-off-by: Vasily Khoruzhick
Reviewed-by: Rob Herring
Signed-off-by: Torsten Duwe
---
originally
by the driver.
Signed-off-by: Harald Geyer
Signed-off-by: Torsten Duwe
---
originally: patchwork.kernel.org/patch/10792589
Removed the questionable issues, leaving the unchallenged parts.
---
.../boot/dts/allwinner/sun50i-a64-teres-i.dts | 53 +++
1 file changed, 53 insertions
From: Icenowy Zheng
TERES-I has an ANX6345 bridge connected to the RGB666 LCD output, and
the I2C controlling signals are connected to I2C0 bus.
Enable it in the device tree.
Signed-off-by: Icenowy Zheng
Signed-off-by: Torsten Duwe
---
originally: patchwork.kernel.org/patch/10646867
On Fri, Jul 26, 2019 at 06:36:01PM +0200, Maxime Ripard wrote:
> > +
> > + dvdd12-supply:
> > +maxItems: 1
> > +description: Regulator for 1.2V digital core power.
> > +$ref: /schemas/types.yaml#/definitions/phandle
> > +
> > + dvdd25-supply:
> > +maxItems: 1
> > +
On Wed, Jun 12, 2019 at 11:13:10AM +0200, Andrzej Hajda wrote:
> On 04.06.2019 14:23, Torsten Duwe wrote:
> > +
> > +static void anx6345_poweron(struct anx6345 *anx6345)
> > +{
> > + int err;
> > +
> > + /* Ensure reset is ass
On Mon, Jul 22, 2019 at 11:51:36AM -0700, Vasily Khoruzhick wrote:
> On Mon, Jul 22, 2019 at 8:12 AM Torsten Duwe wrote:
> >
> > The anx6345 is an ultra-low power DisplayPort/eDP transmitter designed
> > for portable devices.
> >
> > Add a binding document f
The anx6345 is an ultra-low power DisplayPort/eDP transmitter designed
for portable devices.
Add a binding document for it.
Signed-off-by: Icenowy Zheng
Signed-off-by: Vasily Khoruzhick
Reviewed-by: Rob Herring
Signed-off-by: Torsten Duwe
Reviewed-by: Laurent Pinchart
---
.../devicetree
On Thu, Jul 25, 2019 at 05:45:15PM +0200, Enric Balletbo Serra wrote:
> Hi,
>
> Missatge de Vasily Khoruzhick del dia dl., 22 de
> jul. 2019 a les 20:50:
> >
> > On Mon, Jul 22, 2019 at 8:11 AM Torsten Duwe wrote:
> > >
> > > +module_i2c_driver(anx6345_
On Mon, Jul 22, 2019 at 11:49:48AM -0700, Vasily Khoruzhick wrote:
> On Mon, Jul 22, 2019 at 8:11 AM Torsten Duwe wrote:
> >
> > +module_i2c_driver(anx6345_driver);
> > +
> > +MODULE_DESCRIPTION("ANX6345 eDP Transmitter driver");
> > +MODULE_AUTHOR
ANX6345 LVTTL->eDP video bridge, driver with device tree bindings.
Changes from v2:
* use SPDX-IDs throughout
* removed the panel output again, as it was not what Maxime had in mind.
At least the Teres-I does very well without. No connector spec, no
"quirks"[1],
just plain EDID at work.
*
From: Icenowy Zheng
Some code can be shared within different DP bridges by Analogix.
Extract them to analogix_dp.
Signed-off-by: Icenowy Zheng
Signed-off-by: Vasily Khoruzhick
Signed-off-by: Torsten Duwe
Reviewed-by: Andrzej Hajda
---
drivers/gpu/drm/bridge/analogix/Makefile
-off-by: Vasily Khoruzhick
Signed-off-by: Torsten Duwe
Reviewed-by: Andrzej Hajda
---
drivers/gpu/drm/bridge/analogix/analogix-anx78xx.h | 465 +
.../gpu/drm/bridge/analogix/analogix-i2c-dptx.h| 247 +++
.../drm/bridge/analogix/analogix-i2c-txcommon.h| 233
From: Icenowy Zheng
As ANA78xx chips are designed and produced by Analogix Semiconductor,
Inc, move their driver codes into analogix subdirectory.
Signed-off-by: Icenowy Zheng
Signed-off-by: Vasily Khoruzhick
Reviewed-by: Laurent Pinchart
Signed-off-by: Torsten Duwe
Reviewed-by: Andrzej
Add bit definitions required for the anx6345 and add a
sanity check in anx_dp_aux_transfer.
Signed-off-by: Icenowy Zheng
Signed-off-by: Vasily Khoruzhick
Signed-off-by: Torsten Duwe
Reviewed-by: Andrzej Hajda
---
drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.c | 2 +-
drivers/gpu/drm
-by: Vasily Khoruzhick
Signed-off-by: Torsten Duwe
---
drivers/gpu/drm/bridge/analogix/Kconfig| 12 +
drivers/gpu/drm/bridge/analogix/Makefile | 1 +
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 797 +
3 files changed, 810 insertions(+)
create
The anx6345 is an ultra-low power DisplayPort/eDP transmitter designed
for portable devices.
Add a binding document for it.
Signed-off-by: Icenowy Zheng
Signed-off-by: Vasily Khoruzhick
Reviewed-by: Rob Herring
Signed-off-by: Torsten Duwe
Reviewed-by: Laurent Pinchart
---
.../devicetree
Teres-I has an anx6345 bridge connected to the RGB666 LCD output, and
the I2C controlling signals are connected to I2C0 bus.
Enable it in the device tree, and the display engine, video mixer
and tcon0 as well.
Signed-off-by: Icenowy Zheng
Signed-off-by: Torsten Duwe
---
.../boot/dts/allwinner
From: Icenowy Zheng
Some code can be shared within different DP bridges by Analogix.
Extract them to analogix_dp.
Signed-off-by: Icenowy Zheng
Signed-off-by: Vasily Khoruzhick
Signed-off-by: Torsten Duwe
Reviewed-by: Andrzej Hajda
---
drivers/gpu/drm/bridge/analogix/Makefile
Add bit definitions required for the anx6345 and add a
sanity check in anx_dp_aux_transfer.
Signed-off-by: Icenowy Zheng
Signed-off-by: Vasily Khoruzhick
Signed-off-by: Torsten Duwe
Reviewed-by: Andrzej Hajda
---
drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.c | 2 +-
drivers/gpu/drm
to make it compile in 5.2
Icenowy Zheng (4):
drm/bridge: move ANA78xx driver to analogix subdirectory
drm/bridge: split some definitions of ANX78xx to dedicated headers
drm/bridge: extract some Analogix I2C DP common code
drm/bridge: Add Analogix anx6345 support
Torsten Duwe (3):
From: Icenowy Zheng
As ANA78xx chips are designed and produced by Analogix Semiconductor,
Inc, move their driver codes into analogix subdirectory.
Signed-off-by: Icenowy Zheng
Signed-off-by: Vasily Khoruzhick
Reviewed-by: Laurent Pinchart
Signed-off-by: Torsten Duwe
Reviewed-by: Andrzej
The anx6345 is an ultra-low power DisplayPort/eDP transmitter designed
for portable devices.
Add a binding document for it.
Signed-off-by: Icenowy Zheng
Signed-off-by: Vasily Khoruzhick
Reviewed-by: Rob Herring
Signed-off-by: Torsten Duwe
Reviewed-by: Laurent Pinchart
---
.../bindings
-off-by: Vasily Khoruzhick
Signed-off-by: Torsten Duwe
Reviewed-by: Andrzej Hajda
---
drivers/gpu/drm/bridge/analogix/analogix-anx78xx.h | 465 +
.../gpu/drm/bridge/analogix/analogix-i2c-dptx.h| 247 +++
.../drm/bridge/analogix/analogix-i2c-txcommon.h| 233
Teres-I has an anx6345 bridge connected to the RGB666 LCD output, and
the I2C controlling signals are connected to I2C0 bus.
Enable it in the device tree, and enable the display engine, video mixer
and tcon0 as well.
Signed-off-by: Icenowy Zheng
Signed-off-by: Torsten Duwe
---
.../boot/dts
-by: Vasily Khoruzhick
Signed-off-by: Torsten Duwe
---
drivers/gpu/drm/bridge/analogix/Kconfig| 12 +
drivers/gpu/drm/bridge/analogix/Makefile | 1 +
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 793 +
3 files changed, 806 insertions(+)
create
gix anx6345 support
Torsten Duwe (3):
drm/bridge: Prepare Analogix anx6345 support
dt-bindings: Add ANX6345 DP/eDP transmitter binding
arm64: dts: allwinner: a64: enable ANX6345 bridge on Teres-I
.../bindings/display/bridge/anx6345.yaml | 92 +++
.../boot/dts/allwinner/sun
From: Icenowy Zheng
Some code can be shared within different DP bridges by Analogix.
Extract them to analogix_dp.
Signed-off-by: Icenowy Zheng
Signed-off-by: Vasily Khoruzhick
Signed-off-by: Torsten Duwe
Reviewed-by: Andrzej Hajda
---
drivers/gpu/drm/bridge/analogix/Makefile
From: Icenowy Zheng
As ANA78xx chips are designed and produced by Analogix Semiconductor,
Inc, move their driver codes into analogix subdirectory.
Signed-off-by: Icenowy Zheng
Signed-off-by: Vasily Khoruzhick
Reviewed-by: Laurent Pinchart
Signed-off-by: Torsten Duwe
Reviewed-by: Andrzej
-by: Vasily Khoruzhick
Signed-off-by: Torsten Duwe
---
drivers/gpu/drm/bridge/analogix/Kconfig| 12 +
drivers/gpu/drm/bridge/analogix/Makefile | 1 +
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 793 +
3 files changed, 806 insertions(+)
create
The anx6345 is an ultra-low power DisplayPort/eDP transmitter designed
for portable devices.
Add a binding document for it.
Signed-off-by: Icenowy Zheng
Signed-off-by: Vasily Khoruzhick
Reviewed-by: Rob Herring
Signed-off-by: Torsten Duwe
Reviewed-by: Laurent Pinchart
---
.../bindings
From: Icenowy Zheng
Some code can be shared within different DP bridges by Analogix.
Extract them to analogix_dp.
Signed-off-by: Icenowy Zheng
Signed-off-by: Vasily Khoruzhick
Signed-off-by: Torsten Duwe
Reviewed-by: Andrzej Hajda
---
drivers/gpu/drm/bridge/analogix/Makefile
From: Icenowy Zheng
As ANA78xx chips are designed and produced by Analogix Semiconductor,
Inc, move their driver codes into analogix subdirectory.
Signed-off-by: Icenowy Zheng
Signed-off-by: Vasily Khoruzhick
Reviewed-by: Laurent Pinchart
Signed-off-by: Torsten Duwe
Reviewed-by: Andrzej
-off-by: Vasily Khoruzhick
Signed-off-by: Torsten Duwe
Reviewed-by: Andrzej Hajda
---
drivers/gpu/drm/bridge/analogix/analogix-anx78xx.h | 461 +
.../gpu/drm/bridge/analogix/analogix-i2c-dptx.h| 247 +++
.../drm/bridge/analogix/analogix-i2c-txcommon.h| 233
Add bit definitions required for the anx6345 and add a
sanity check in anx_dp_aux_transfer.
Signed-off-by: Icenowy Zheng
Signed-off-by: Vasily Khoruzhick
Signed-off-by: Torsten Duwe
Reviewed-by: Andrzej Hajda
---
drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.c | 2 +-
drivers/gpu/drm
Teres-I has an anx6345 bridge connected to the RGB666 LCD output, and
the I2C controlling signals are connected to I2C0 bus.
Enable it in the device tree, and enable the display engine, video mixer
and tcon0 as well.
Signed-off-by: Icenowy Zheng
Signed-off-by: Torsten Duwe
---
.../boot/dts
t, to make it compile in 5.2
Icenowy Zheng (4):
drm/bridge: move ANA78xx driver to analogix subdirectory
drm/bridge: split some definitions of ANX78xx to dedicated headers
drm/bridge: extract some Analogix I2C DP common code
drm/bridge: Add Analogix anx6345 support
Torsten Duwe (3):
-off-by: Vasily Khoruzhick
Signed-off-by: Torsten Duwe
Reviewed-by: Andrzej Hajda
---
On Tue, Nov 05, 2019 at 11:41:26AM +0100, Maxime Ripard wrote:
>
> This one doesn't apply on drm-misc-next. The fix doesn't look really
> obvious to me, can you rebase and resend it?
Sure.
The set
On Thu, Oct 31, 2019 at 01:51:00PM +0100, Maxime Ripard wrote:
> On Tue, Oct 29, 2019 at 01:16:57PM +0100, Torsten Duwe wrote:
> > +
> > + ports:
> > +anyOf:
> > + - port@0:
> > +description: Video port for LVTTL input
> > + - port@
On Tue, Nov 12, 2019 at 10:22:39AM +0100, Maxime Ripard wrote:
> Hi Thorsten,
>
> On Mon, Nov 11, 2019 at 11:53:20PM +0800, kbuild test robot wrote:
> >
> >drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:48:20: error: field
> > 'bridge' has incomplete type
> > struct drm_bridge
.
Signed-off-by: Torsten Duwe
---
The commits in question are ff1e8fb68ea06 and ee68c743f8d07, but I guess the
next rebase will change these. next-20191112 plus the anx6345-v5a series plus
this patch compile cleanly on arm64.
--- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
+++ b/drivers/gpu
On Tue, Nov 05, 2019 at 11:43:42AM +0100, Maxime Ripard wrote:
>
> On Tue, Oct 29, 2019 at 01:16:57PM +0100, Torsten Duwe wrote:
> > The anx6345 is an ultra-low power DisplayPort/eDP transmitter designed
> > for portable devices.
> >
> > Add a binding docum
drm_dp_link_rate_to_bw_code and ...bw_code_to_link_rate simply divide by
and multiply with 27000, respectively. Avoid an overflow in the u8 dpcd[0]
and the multiply+divide alltogether.
fixes: e1cff82c1097bda2478 ("fix anx6345 compilation for v5.5")
Signed-off-by: Torsten Duwe
---
Sa
drm_dp_link_rate_to_bw_code and ...bw_code_to_link_rate simply divide by
and multiply with 27000, respectively. Avoid an overflow in the u8 dpcd[0]
and the multiply+divide alltogether.
fixes: ff1e8fb68ea06027 ("analogix-anx78xx: Avoid drm_dp_link helpers")
Signed-off-by: Torsten Duw
of_get_regulator() will unconditionally add "-supply" to form the
property name. This is documented in commit 69511a452e6dc ("map consumer
regulator based on device tree").
Signed-off-by: Torsten Duwe
---
IMHO that commit message should have ended up somewhere
On Sat, Feb 22, 2020 at 10:43:02AM +0800, Icenowy Zheng wrote:
>
>
> 于 2020年2月22日 GMT+08:00 上午1:13:28, Torsten Duwe 写到:
> >On Sat, Feb 22, 2020 at 12:51:27AM +0800, Icenowy Zheng wrote:
> >> Current code tries to store the link rate (in bps, which is a big
> >&
Hi all,
I'm still not sure about your release and merge cycles, but it looks
like these fixes got dropped:
https://patchwork.freedesktop.org/patch/343003
https://patchwork.freedesktop.org/patch/343004
https://patchwork.freedesktop.org/patch/343005
The erroneous code is in drm-misc-next for
uot;dvdd25-supply not found\n");
> > return PTR_ERR(anx6345->dvdd25);
> >
>
> This is a duplicate of "drm/bridge: analogix-anx6345: Avoid duplicate -supply
> suffix" (20200218155440.befb968...@verein.lst.de)
>
> But this one has fixes and re
On Sat, Feb 22, 2020 at 12:51:27AM +0800, Icenowy Zheng wrote:
> Current code tries to store the link rate (in bps, which is a big
> number) in a u8, which surely overflow. Then it's converted back to
> bandwidth code (which is thus 0) and written to the chip.
>
> The code sometimes works because
On Fri, Feb 21, 2020 at 03:39:32PM +0100, Thomas Zimmermann wrote:
> Hi Torsten
>
> Am 21.02.20 um 15:04 schrieb Torsten Duwe:
> > drm_dp_link_rate_to_bw_code and ...bw_code_to_link_rate simply divide by
> > and multiply with 27000, respectively. Avoid an over
drm_dp_link_rate_to_bw_code and ...bw_code_to_link_rate simply divide by
and multiply with 27000, respectively. Avoid an overflow in the u8 dpcd[0]
and the multiply+divide alltogether.
fixes: e1cff82c1097bda2478 ("fix anx6345 compilation for v5.5")
Signed-off-by: Torsten Duwe
of_get_regulator() will unconditionally add "-supply" to form the
property name. This is documented in commit 69511a452e6dc ("map consumer
regulator based on device tree"). Remove the suffix from the requests.
Signed-off-by: Torsten Duwe
---
https://patchwork.freedesktop.org
drm_dp_link_rate_to_bw_code and ...bw_code_to_link_rate simply divide by
and multiply with 27000, respectively. Avoid an overflow in the u8 dpcd[0]
and the multiply+divide alltogether.
fixes: ff1e8fb68ea06027 ("analogix-anx78xx: Avoid drm_dp_link helpers")
Signed-off-by: Torsten Duwe
drm_dp_link_rate_to_bw_code and ...bw_code_to_link_rate simply divide by
and multiply with 27000, respectively. Avoid an overflow in the u8 dpcd[0]
and the multiply+divide alltogether.
fixes: e1cff82c1097bda2478 ("fix anx6345 compilation for v5.5")
Signed-off-by: Torsten Duwe
of_get_regulator() will unconditionally add "-supply" to form the
property name. This is documented in commit 69511a452e6dc ("map consumer
regulator based on device tree"). Remove the suffix from the requests.
Signed-off-by: Torsten Duwe
Reviewed-by: Mark Brown
---
Mark h
drm_dp_link_rate_to_bw_code and ...bw_code_to_link_rate simply divide by
and multiply with 27000, respectively. Avoid an overflow in the u8 dpcd[0]
and the multiply+divide alltogether.
fixes: ff1e8fb68ea06027 ("analogix-anx78xx: Avoid drm_dp_link helpers")
Signed-off-by: Torsten Duwe
On Wed, 18 May 2022 09:53:58 -0700
Vasily Khoruzhick wrote:
> On Thu, Apr 28, 2022 at 8:58 AM Torsten Duwe wrote:
> > power on the eDP bridge? Could there be any leftovers from that
> > mechanism? I use a hacked-up U-Boot with a procedure similar to the
> > k
APTOP/blob/master/
HARDWARE/A64-TERES/TERES-PCB1-A64-MAIN/Rev.C/TERES_PCB1-A64-MAIN_Rev.C.pdf
(page 5, blue comment down left)
Reported-by: Harald Geyer
Signed-off-by: Torsten Duwe
Cc: sta...@vger.kernel.org
---
This fixes the problem that e.g. X screensaver turns the screen black,
and it stays b
On Mon, 18 Apr 2022 17:25:57 -0700
Vasily Khoruzhick wrote:
> On Sun, Apr 17, 2022 at 11:52 AM Vasily Khoruzhick
> wrote:
> > The change looks good to me, but I'll need some time to actually
> > test it. If you don't hear from me for longer than a week please
> > ping me.
>
> Your change
94 matches
Mail list logo
