Re: [PATCH 1/3] drm/sti: use atomic_helper for commit

Acked-by: Vincent Abriou <vincent.abr...@st.com> On 01/12/2017 05:27 PM, Fabien Dessenne wrote: > Since nonblocking atomic commits are now supported, the driver can > now use drm_atomic_helper_commit(). > > Signed-off-by: Fabien Dessenne <fabien.desse...@st.com> >

Re: [PATCH 2/3] drm/sti: Fix up crtc_state->event handling

Acked-by: Vincent Abriou <vincent.abr...@st.com> On 01/12/2017 05:27 PM, Fabien Dessenne wrote: > Use drm-core to handle event. > This is required to be able to use the nonblocking helpers. > > Signed-off-by: Fabien Dessenne <fabien.desse...@st.com> > --- > driver

Re: [PATCH 3/3] drm/sti: do not check hw scaling if mode is not set

Acked-by: Vincent Abriou <vincent.abr...@st.com> On 01/12/2017 05:27 PM, Fabien Dessenne wrote: > Fix a division by 0 case : in some cases, when the HQVDP plane is being > disabled atomic_check() is called with "mode->clock = 0". > In that case, do not check for scal

[PATCH 1/2] drm/sti: remove deprecated sink_term config

stih416 chip family is no more supported in Linux v4.9. Then sink_term config becomes useless. The field of the register it was referring to is tag as reserved for stih410 chip family. Signed-off-by: Vincent Abriou <vincent.abr...@st.com> --- drivers/gpu/drm/sti/sti_hdmi.c | 7 ---

[PATCH 0/2] drm/sti cleanup: remove deprecated register and functionnalities

Remove stih416 chip deprecated register and functionnalities since stih416 chip is no more supported from Linux v4.9. Vincent Abriou (2): drm/sti: remove deprecated sink_term config drm/sti: remove deprecated legacy vtg slave drivers/gpu/drm/sti/sti_hdmi.c | 7 - drivers/gpu/drm/sti

[PATCH 2/2] drm/sti: remove deprecated legacy vtg slave

stih416 chip family is no more supported in Linux v4.9. It is then useless to keep vtg slave field since it not used at all for the stih407/10 chip family supported by sti driver. Signed-off-by: Vincent Abriou <vincent.abr...@st.com> --- drivers/gpu/drm/sti/sti_vtg.

[PATCH 3/3] drm/sti: do not post GDP command if no update

Do not process update requests with unmodified parameters. This typically happens when the driver is called with legacy (non-atomic) IOCTL : in that case atomic_update() is called multiple times with the same parameters. Signed-off-by: Vincent Abriou <vincent.abr...@st.com> --- drivers/g

[PATCH 2/3] drm/sti: do not set gdp pixel clock rate if mode is not set

Fix a division by 0 case : in some cases, when the GDP plane is being disabled atomic_check() is called with "mode->clock = 0". In that case, do not set parent and pixel clock rate. Signed-off-by: Vincent Abriou <vincent.abr...@st.com> --- drivers/gpu/drm/sti/sti_gdp.c | 2 +-

[PATCH 0/3] drm/sti: gdp pixel clock and plane update fixes

This patch series fix issues met around gpd plane: - fix gdp clock selection and enabling - fix div by zero when GDP plane is being disabled - do not process gdp update requests with unmodified parameters Vincent Abriou (3): drm/sti: enable gdp pixel clock in atomic_update drm/sti: do

[PATCH 1/3] drm/sti: enable gdp pixel clock in atomic_update

Set gdp pix clock rate and parent in atomic_check function and enable it in the atomic_update only the first time. Signed-off-by: Vincent Abriou <vincent.abr...@st.com> --- drivers/gpu/drm/sti/sti_gdp.c | 70 --- 1 file changed, 32 insertions(

[PATCH] drm/sti: debug fps reset

From: Fabien Dessenne Reset the fps debug information when 'fps_show' is updated. Signed-off-by: Fabien Dessenne --- drivers/gpu/drm/sti/sti_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/sti/sti_drv.c

[PATCH] drm/sti: hdmi: automatically check DVI/HDMI mode

Remove the hdmi_mode_property and use drm_detect_hdmi_monitor function to check whether the connected monitor is HDMI capable or DVI only. Signed-off-by: Vincent Abriou <vincent.abr...@st.com> --- drivers/gpu/drm/sti/sti_hdmi.c | 31 ++- drivers/gpu/drm/sti/sti_

[PATCH] drm/sti: unbind all components while driver cleanup

Unbind all the components when the STI driver is unregistered. Signed-off-by: Vincent Abriou <vincent.abr...@st.com> --- drivers/gpu/drm/sti/sti_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c index e433853..60a41cc

Re: [PATCH] drm/sti: Fix compilation failure for drm_framebuffer.pixel_format

Hi Chris, Thank for the patch. Acked-by: Vincent Abriou <vincent.abr...@st.com> Vincent On 01/25/2017 11:10 AM, Chris Wilson wrote: > drivers/gpu/drm/sti/sti_plane.c:76:33: error: ‘struct drm_framebuffer’ > has no member named ‘pixel_format’; did you mean ‘format’? > > I d

Re: [PATCH 13/19] drm/sti: Remove drm_debugfs_remove_files() calls

Thank for this patch. It is working fine with sti driver. Acked-by: Vincent Abriou <vincent.abr...@st.com> Tested-by: Vincent Abriou <vincent.abr...@st.com> Vincent On 01/26/2017 11:56 PM, Noralf Trønnes wrote: > drm_debugfs_cleanup() now removes all minor->debugfs_list entri

[PATCH 1/1] drm/sti: fix build warnings in sti_drv.c and sti_vtg.c files

Fix compilation warning introduced by: commit 0c7ff84f7f9d ("drm/sti: remove deprecated legacy vtg slave") commit 5e60f595d6ca ("drm/sti: use atomic_helper for commit") Signed-off-by: Vincent Abriou <vincent.abr...@st.com> --- drivers/gpu/drm/sti/sti_drv.c | 9

[PULL] sti-drm-next-2017-02-10

ode is not set Vincent Abriou (8): drm/sti: remove deprecated sink_term config drm/sti: remove deprecated legacy vtg slave drm/sti: enable gdp pixel clock in atomic_update drm/sti: do not set gdp pixel clock rate if mode is not set drm/sti: do not post GDP comm

[PATCH v4 05/14] drm: sti: Replace drm_fb_get_bpp_depth() with drm_format_plane_cpp()

; Signed-off-by: Laurent Pinchart > Acked-by: Vincent Abriou > --- > drivers/gpu/drm/sti/sti_gdp.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > Cc: Benjamin Gaignard > Cc: Vincent Abriou > > diff --git a/drivers/gpu/drm/sti/sti_gdp.c b/drivers/gpu

[PATCH] drm/sti: dpms function missing for HDMI connector

Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_hdmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c index c6aa291..d850dda 100644 --- a/drivers/gpu/drm/sti/sti_hdmi.c +++ b/drivers/gpu/drm/sti/sti_hdmi.c @@ -1054,6

[PATCH] drm/sti: forbid plane on several mixer

when the plane is in use (gdp is running). Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_gdp.c | 15 +++ drivers/gpu/drm/sti/sti_plane.h | 2 ++ 2 files changed, 17 insertions(+) diff --git a/drivers/gpu/drm/sti/sti_gdp.c b/drivers/gpu/drm/sti/sti_gdp.c index 3fc62c1

[PATCH] drm/sti: fix compositor debugfs creation

Fix typo and issue while creating the vid and mixer debugfs entries. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_compositor.c | 8 ++-- drivers/gpu/drm/sti/sti_compositor.h | 4 ++-- drivers/gpu/drm/sti/sti_crtc.c | 2 +- 3 files changed, 9 insertions(+), 5 deletions

[PATCH] drm/sti: forbid plane on several mixer

On 09/15/2016 04:27 PM, Ville Syrjälä wrote: > On Wed, Sep 14, 2016 at 01:40:02PM +0200, Vincent Abriou wrote: >> When a plane is going to be enabled we re-evaluate the possible crtcs >> for the associated drm plane. Only the crtc on which the plane should be >> di

[PATCH v2] drm/sti: fix compositor debugfs creation

Fix typo and issue while creating the vid and mixer debugfs entries. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_compositor.c | 22 +- drivers/gpu/drm/sti/sti_compositor.h | 4 ++-- drivers/gpu/drm/sti/sti_crtc.c | 2 +- 3 files changed, 12 insertions

[PATCH] drm/sti: mark symbols static where possible

Acked-by: Vincent Abriou On 09/15/2016 01:39 PM, Baoyou Xie wrote: > We get 4 warnings when building kernel with W=1: > drivers/gpu/drm/sti/sti_gdp.c:476:5: warning: no previous prototype for > 'sti_gdp_field_cb' [-Wmissing-prototypes] > drivers/gpu/drm/sti/sti_hqvdp.c:78

[PATCH 1/8] drm/sti: fix debug logs

Acked-by: Vincent Abriou On 09/15/2016 03:41 PM, Fabien Dessenne wrote: > Add some missing \n in logs. > > Signed-off-by: Fabien Dessenne > --- > drivers/gpu/drm/sti/sti_gdp.c | 2 +- > drivers/gpu/drm/sti/sti_hda.c | 4 ++-- > drivers/gpu/drm/sti/sti_hdmi.c | 2 +-

[PATCH 2/8] drm/sti: run hqvdp init sequence only once

Acked-by: Vincent Abriou On 09/15/2016 03:41 PM, Fabien Dessenne wrote: > Do not rely on plane->status to define whether this is the first update > but rather check for hqvdp->xp70_initialized bit status. > This avoids multiple and unwanted calls to sti_vtg_register_client()

[PATCH 3/8] drm/sti: run gdp init sequence only once

Acked-by: Vincent Abriou On 09/15/2016 03:41 PM, Fabien Dessenne wrote: > Do not rely on plane->status to define whether this is the first update > but rather check for gdp->vtg. > This avoids multiple and unwanted calls to sti_vtg_register_client() > which breaks th

[PATCH 4/8] drm/sti: fix atomic_disable check

Acked-by: Vincent Abriou On 09/15/2016 03:41 PM, Fabien Dessenne wrote: > When a drm_plane is being disabled, its ->crtc member is set to NULL > before the .atomic_disable() func is called. > To get the crtc of the plane, read old_state->crtc instead of > drm_plane-&g

[PATCH 5/8] drm/sti: use different notifier_block for each pipe

Acked-by: Vincent Abriou On 09/15/2016 03:41 PM, Fabien Dessenne wrote: > Each pipe shall have its own notifier block to manage the vblank event. > This fixes issues where a client registered on given pipe is later > abusively notified of events on the other pipe. > > Signed

[PATCH 6/8] drm/sti: use vtg array instead of vtg_main/aux

Acked-by: Vincent Abriou On 09/15/2016 03:41 PM, Fabien Dessenne wrote: > This is more generic and more consistent with the other members of the > sti_compositor struct. > > Signed-off-by: Fabien Dessenne > --- > drivers/gpu/drm/sti/sti_compositor.c | 4 ++-- >

[PATCH 7/8] drm/sti: in crtc_atomic_flush, enable only planes of this crtc

Acked-by: Vincent Abriou On 09/15/2016 03:41 PM, Fabien Dessenne wrote: > crtc_atomic_flush performs some additional processing, like plane > enable at mixer level. > Enable only the planes attached to the CRTC. > > Signed-off-by: Fabien Dessenne > --- > drivers/gpu/d

[PATCH 8/8] drm/sti: use valid video mode

Acked-by: Vincent Abriou On 09/15/2016 03:41 PM, Fabien Dessenne wrote: > In atomic mode the crtc_xxx (eg crtc_hdisplay) members of the mode > structure may be unset before calling atomic_check/commit for planes. > Instead of, use xxx members which are actually set. > > Signed

[PATCH] drm/sti: forbid plane on several mixer

On 09/15/2016 05:57 PM, Ville Syrjälä wrote: > On Thu, Sep 15, 2016 at 04:59:55PM +0200, Vincent ABRIOU wrote: >> >> >> On 09/15/2016 04:27 PM, Ville Syrjälä wrote: >>> On Wed, Sep 14, 2016 at 01:40:02PM +0200, Vincent Abriou wrote: >>>> When a p

[PATCH 12/14] drm/sti: Fix sparse warnings

Acked-by: Vincent Abriou On 09/19/2016 03:33 PM, ville.syrjala at linux.intel.com wrote: > From: Ville Syrjälä > > drm/sti/sti_mixer.c:361:6: warning: symbol 'sti_mixer_set_matrix' was not > declared. Should it be static? > drm/sti/sti_gdp.c:476:5: warning: symbol 's

[PATCH] drm/sti: remove stih415-416 platform support

stih415 and stih416 platform are obsolete and no more supported. Only stih407 and stih410 platform are maintained. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/Kconfig| 6 +- drivers/gpu/drm/sti/sti_compositor.c | 19 -- drivers/gpu/drm/sti/sti_hda.c

[PATCH v2] drm/sti: remove stih415-416 platform support

stih415 and stih416 platform are obsolete and no more supported. Only stih407 and stih410 platform are maintained. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/Kconfig| 6 +- drivers/gpu/drm/sti/Makefile | 1 - drivers/gpu/drm/sti/sti_compositor.c

[PULL] sti-drm-next-2016-09-20

: in crtc_atomic_flush, enable only planes of this crtc drm/sti: use valid video mode Ville Syrjälä (1): drm/sti: Fix sparse warnings Vincent Abriou (3): drm/sti: dpms function missing for HDMI connector drm/sti: fix compositor debugfs creation drm/sti: remove

[PATCH] drm: Make the connector .detect() callback optional

Hi Laurent, For the sti driver: Acked-by: Vincent Abriou Vincent On 11/29/2016 09:56 PM, Laurent Pinchart wrote: > Many drivers (21 to be exact) create connectors that are always > connected (for instance to an LVDS or DSI panel). Instead of forcing > them to implement a dumm

[PATCH v3 11/13] drm: Set on-chip bridges' encoder type

i_dvo.c > @@ -472,6 +472,8 @@ static int sti_dvo_bind(struct device *dev, struct device > *master, void *data) > bridge->driver_private = dvo; > bridge->funcs = _dvo_bridge_funcs; > bridge->of_node = dvo->dev.of_node; > + bridge->encoder_type = DRM_MODE_ENCODER_LVDS; > + > err = drm_bridge_add(bridge); > if (err) { > DRM_ERROR("Failed to add bridge\n"); For the sti dvo part: Acked-by: Vincent Abriou Vincent >

[PATCH v3 03/13] drm: bridge: Link encoder and bridge in core code

drivers/gpu/drm/sti/sti_hda.c | 3 +- > drivers/gpu/drm/sti/sti_hdmi.c | 3 +- Hi Laurent, For sti dvo, hda and hdmi: Acked-by: Vincent Abriou Vincent > drivers/gpu/drm/sun4i/sun4i_rgb.c | 13 +++--- > include/drm/drm_bridge.h

[PATCH] drm/sti: mark symbols static where possible

Yes true, patch from Ville https://lists.freedesktop.org/archives/dri-devel/2016-September/118631.html; already fix patches sent by Baoyou. Vincent On 09/27/2016 09:07 PM, Benjamin Gaignard wrote: > I think that create conflicts with what is already in Vincent pull > request where we have fix

[PATCH] drm: Remove the struct drm_device platformdev field

Hi Laurent, Ok for the sti driver. Acked-by: Vincent Abriou On 12/17/2016 11:39 PM, Laurent Pinchart wrote: > The field contains a pointer to the parent platform device of the DRM > device. As struct drm_device also contains a dev pointer to the struct > device embedded in the platfo

[PATCH] drm/sti: update fps debugfs entries

This update allows to have a clearer fps log trace by adding information about plane size and plane pixel format. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_plane.c | 17 + drivers/gpu/drm/sti/sti_plane.h | 2 +- 2 files changed, 14 insertions(+), 5 deletions

[PATCH 0/2] drm/sti: set connector status and create fbdev at binding

While binding the sti drm driver the initial connectors status are set and the fbdev is created. Vincent Abriou (2): drm/sti: set initial connectors status at binding drm/sti: create fbdev at binding drivers/gpu/drm/sti/sti_drv.c | 27 ++- drivers/gpu/drm/sti

[PATCH 1/2] drm/sti: set initial connectors status at binding

This avoid to have an "unknown" connector status after the sti driver is registered. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_dvo.c | 3 +++ drivers/gpu/drm/sti/sti_hdmi.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drive

[PATCH 2/2] drm/sti: create fbdev at binding

Do not wait for a hot plug event to create fbdev. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_drv.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c index ff71e25

[PATCH] drm/sti: remove deprecated sti_vtac.c file

sti_vtac.c file is deprecated since stih416 chip family is not supported anymore. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/Makefile | 1 - drivers/gpu/drm/sti/sti_drv.c | 1 - drivers/gpu/drm/sti/sti_drv.h | 1 - drivers/gpu/drm/sti/sti_vtac.c | 223

[v1] gpu: drm: sti: sti_vtg:- Handle return NULL error from devm_ioremap_nocache

Thanks for the patch. Acked-by: Vincent Abriou I will take it for pull request that should be issued by the end of the week. Vincent On 12/21/2016 06:30 AM, Arvind Yadav wrote: > Here, If devm_ioremap_nocache will fail. It will return NULL. > Kernel can run into a NULL-pointer deref

[v1] gpu: drm: sti: sti_vtac:- Handle return NULL error from devm_ioremap_nocache

Hi Arvind, Thank for this patch. Since sti_vtac.c file is deprecated, I rather suppress the sti_vtac.c file. I just push a new patch to suppress it. Thank for pointing this out. Br Vincent On 12/21/2016 06:22 AM, Arvind Yadav wrote: > Here, If devm_ioremap_nocache will fail. It will return

[PATCH] drm/sti: remove deprecated sti_vtac.c file

On 01/04/2017 10:40 AM, Daniel Vetter wrote: > On Wed, Jan 04, 2017 at 10:26:46AM +0100, Vincent Abriou wrote: >> sti_vtac.c file is deprecated since stih416 chip family is not >> supported anymore. >> >> Signed-off-by: Vincent Abriou > > Ehrm, removing existing

[PATCH v2] drm/sti: remove deprecated sti_vtac.c file

stih416 chip family is no more supported in Linux v4.9. It is then useless to keep sti_vtac.c file since it not used at all for the stih407/10 chip family supported by sti driver. Signed-off-by: Vincent Abriou --- v2: Take into account Daniel's comment => add a more explicit commit mess

[PATCH 1/2] drm/sti: set initial connectors status at binding

On 01/04/2017 10:39 AM, Daniel Vetter wrote: > On Wed, Jan 04, 2017 at 10:15:45AM +0100, Vincent Abriou wrote: >> This avoid to have an "unknown" connector status after the sti driver is >> registered. >> >> Signed-off-by: Vincent Abriou > > Wh

[PATCH] drm/sti: create fbdev at binding

Do not wait for a hot plug event to create fbdev. Cc: Tomi Valkeinen Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_drv.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c

[PATCH] drm: sti: allow audio playback on HDMI even if disabled.

Acked-by: Vincent Abriou On 09/30/2016 05:17 PM, Arnaud Pouliquen wrote: > This fix allows to play audio while HDMI is disconnected. > When HDMI is disable, audio configuration is stored and samples > are dropped (by HDMI IP). > When HDMI is enabled, audio HDMI configuratio

[PULL] sti-drm-next-2017-01-06

once drm/sti: do not post HQVDP command if no update Vincent Abriou (3): drm/sti: update fps debugfs entries drm/sti: create fbdev at binding drm/sti: remove deprecated sti_vtac.c file drivers/gpu/drm/sti/Makefile| 1 - drivers/gpu/drm/sti/sti_drv.c | 28

[PATCH 0/2] get fbdev size from cmdline if no connector found

your connector cable but you want your fbdev to have the size you have defined in the command line. Then when you plug your connector cable, the fbdev will match your display size. In case no command line is specified, the 1024x768 fbdev resolution is keept as default fbdev resolution. Vincent

[PATCH 2/2] drm: get fbdev size from cmdline if no connector found

-by: Vincent Abriou --- drivers/gpu/drm/drm_fb_helper.c | 32 +++- 1 file changed, 27 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 77d9ac6..115c265 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu

[PATCH 1/2] drm: remove useless parameters from drm_pick_cmdline_mode function

drm_pick_cmdline_mode width and height parameters are useless. Just remove them. Cc: Daniel Vetter Cc: Jani Nikula Signed-off-by: Vincent Abriou --- drivers/gpu/drm/drm_fb_helper.c| 7 +++ drivers/gpu/drm/i915/intel_fbdev.c | 2 +- include/drm/drm_fb_helper.h| 3 +-- 3 files

[PULL v2] sti-drm-next-2017-01-06

/sti: allow audio playback on HDMI even if disabled. Arvind Yadav (1): drm/sti: sti_vtg: Handle return NULL error from devm_ioremap_nocache Fabien DESSENNE (2): drm/sti: load XP70 firmware only once drm/sti: do not post HQVDP command if no update Vincent Abriou (3): drm/sti

[PATCH v2] drm: get fbdev size from cmdline mode if it exists

-by: Vincent Abriou --- Patch v2: add a break in the connector for loop when a first cmdline mode is found drivers/gpu/drm/drm_fb_helper.c | 34 +- 1 file changed, 29 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm

[PATCH v2] drm: get fbdev size from cmdline mode if it exists

On 01/10/2017 12:39 PM, Daniel Vetter wrote: > On Tue, Jan 10, 2017 at 12:21:09PM +0100, Vincent Abriou wrote: >> In case no connector is found while creating the fbdev, gives the >> possibility to specify the default fbdev size by firstly checking if the >> command line is

[PATCH v2] drm: get fbdev size from cmdline mode if it exists

On 01/11/2017 08:48 AM, Daniel Vetter wrote: > On Tue, Jan 10, 2017 at 10:06:44PM +0200, Laurent Pinchart wrote: >> Hi Vincent, >> >> On Tuesday 10 Jan 2017 13:33:29 Vincent ABRIOU wrote: >>> On 01/10/2017 12:39 PM, Daniel Vetter wrote: >>>> On Tue,

[PATCH 08/12] drm/sti: Rename async to nonblock.

Hi Maarten, Thanks for the patch. Acked-by: Vincent Abriou On 04/26/2016 04:11 PM, Maarten Lankhorst wrote: > The async name is deprecated and should be changed to nonblocking. > > Cc: Benjamin Gaignard > Cc: Vincent Abriou > Signed-off-by: Maarten Lankhorst > --- >

[PATCH v2] drm: drop DRIVER_HAVE_IRQ flag for some drivers

Acked-by: Vincent Abriou On 08/16/2016 09:06 AM, Shawn Guo wrote: > Since commit 4984979b9b90 ("drm/irq: simplify irq checks in > drm_wait_vblank"), the drm driver feature flag DRIVER_HAVE_IRQ is only > required for drivers that have an IRQ handler managed by the DRM core. >

[PATCH v2 2/3] drm: convert DT component matching to component_match_add_release()

, , compare_of, child_np); > - of_node_put(child_np); > + component_match_add_of(dev, , child_np); > child_np = of_get_next_available_child(node, child_np); > } > Hi Russel, Ok for the sti driver. Acked-by: Vincent Abriou

[PATCH v2 11/20] drm: sti: Rely on the default ->best_encoder() behavior

Hi Boris, Thanks for the patch. Acked-by: Vincent Abriou Vincent On 06/07/2016 01:48 PM, Boris Brezillon wrote: > All outputs have a 1:1 relationship between connectors and encoders > and the driver is relying on the atomic helpers: we can drop the custom > ->best_encoder() imp

[PATCH v3 07/15] drm: sti: Replace drm_fb_get_bpp_depth() with drm_format_plane_cpp()

changed, 3 insertions(+), 3 deletions(-) > > Cc: Benjamin Gaignard > Cc: Vincent Abriou > > diff --git a/drivers/gpu/drm/sti/sti_gdp.c b/drivers/gpu/drm/sti/sti_gdp.c > index ff33c38da197..be7e80535083 100644 > --- a/drivers/gpu/drm/sti/sti_gdp.c > +++ b/drivers/gpu/drm/st

[PATCH v3 07/15] drm: sti: Replace drm_fb_get_bpp_depth() with drm_format_plane_cpp()

Hi Laurent, On 06/09/2016 11:17 AM, Laurent Pinchart wrote: > Hi Vincent, > > On Thursday 09 Jun 2016 09:52:05 Vincent ABRIOU wrote: >> On 06/09/2016 01:32 AM, Laurent Pinchart wrote: >>> The driver needs the number of bytes per pixel, not the bpp and depth >>> i

[PATCH, RESEND] drm/sti: use u32 to store DMA addresses

Hi Arnd, Your patch will be part of the next pull request for the STI driver that will be done by the end of next week. Reviewed-by: Vincent Abriou On 02/25/2016 10:11 PM, Arnd Bergmann wrote: > The STi drm driver correctly warns about invalid format strings > when built with

[PATCH 1/2] drm: Add DRM_MODE_FB_BFF flag definition

Hi, Have you any comment for this proposal? BR Vincent On 02/12/2016 10:26 AM, Vincent Abriou wrote: > From: Fabien Dessenne > > If a buffer is interlaced, this "Bottom Field First" flag specifies > which of the top or the bottom field shall be displayed first. > W

[PATCH 1/2] drm: Add DRM_MODE_FB_BFF flag definition

On 02/29/2016 04:32 PM, Daniel Vetter wrote: > On Fri, Feb 26, 2016 at 11:33:08AM +0100, Vincent ABRIOU wrote: >> Hi, >> >> Have you any comment for this proposal? > > I guess since we don't really have userspace that uses interlaced modes, > much less actually bot

[PATCH 0/5] drm/sti: planes bug fixes and improvment

Vincent Abriou (2): drm/sti: GDP cropping fails when we remove 2 pixels horizontally drm/sti: implement atomic_check for the planes drivers/gpu/drm/sti/sti_cursor.c | 101 +++--- drivers/gpu/drm/sti/sti_gdp.c| 216 +-- drivers/gpu/drm/sti

[PATCH 1/5] drm/sti: fallback for GDP scaling

From: Bich Hemon When a GDP gets a scale request (which it does not support), it accepts it but crops or clamps and outputs a warning message. Signed-off-by: Bich Hemon --- drivers/gpu/drm/sti/sti_gdp.c | 36 +++- 1 file changed, 31

[PATCH 2/5] drm/sti: GDP cropping fails when we remove 2 pixels horizontally

GDP source width should be equal to the destination width to get rid of this issue. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_gdp.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_gdp.c b/drivers/gpu/drm/sti/sti_gdp.c index

[PATCH 3/5] drm/sti: force cursor CLUT fetch

From: Fabien Dessenne It may happen that the cursor is displayed with wrong colors which can be explained by a CLUT wrongly fetched at the first display. Fetching the CLUT at each commit (=move) ensures that the right colors are used, at least from the first cursor move.

[PATCH 4/5] drm/sti: implement atomic_check for the planes

Atomic update should never fail. Thus all checks must be done in the atomic_check function for each plane (gdp, hqvdp and cursor). Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_cursor.c | 90 +--- drivers/gpu/drm/sti/sti_gdp.c| 173

[PATCH 5/5] drm/sti: adapt YUV colorspace in display pipeline

From: Bich Hemon Use BT601 for SD/ED resolution and BT709 for HD resolution Signed-off-by: Bich Hemon --- drivers/gpu/drm/sti/sti_tvout.c | 61 ++--- drivers/gpu/drm/sti/sti_vid.c | 31 + 2 files changed, 64

[PATCH 00/11] drm/sti: encoders/connectors bug fixes

at start up. Bich Hemon (2): drm/sti: adjust delay for DVO drm/sti: fix dvo data_enable signal Vincent Abriou (9): drm/sti: do not clip RGB/YUV component value at connector side drm/sti: fix panel detection for DVO connector drm/sti: add missing encoder cleanup for DVO connector drm

[PATCH 02/11] drm/sti: fix panel detection for DVO connector

The DVO connector is tag as disconnect because of a wrong management of the panel detection. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_dvo.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c

[PATCH 01/11] drm/sti: do not clip RGB/YUV component value at connector side

Disable the clipping mode for hdmi, dvo and hda connectors. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_tvout.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_tvout.c b/drivers/gpu/drm/sti/sti_tvout.c index 1c27a2c

[PATCH 03/11] drm/sti: add missing encoder cleanup for DVO connector

Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_tvout.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/sti/sti_tvout.c b/drivers/gpu/drm/sti/sti_tvout.c index 784a3e2..0b171fd 100644 --- a/drivers/gpu/drm/sti/sti_tvout.c +++ b/drivers/gpu/drm/sti/sti_tvout.c

[PATCH 04/11] drm/sti: adjust delay for DVO

From: Bich Hemon Modify delay to display last pixel column on DVO Signed-off-by: Bich Hemon --- drivers/gpu/drm/sti/sti_vtg.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sti/sti_vtg.c b/drivers/gpu/drm/sti/sti_vtg.c index

[PATCH 05/11] drm/sti: fix dvo data_enable signal

From: Bich Hemon Modify AWG algorithm in order to handle more than 1023 lines Signed-off-by: Bich Hemon --- drivers/gpu/drm/sti/sti_awg_utils.c | 51 + 1 file changed, 35 insertions(+), 16 deletions(-) diff --git

[PATCH 06/11] drm/sti: reset HD DACS when HDA connector is created

Make sure the HD DACS are disabled when the HDA connector is created. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_hda.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c index 49cce83..293a133 100644 --- a/drivers

[PATCH 07/11] drm/sti: HDMI infoframe transmission mode not take into account

Set the infoframe transmission mode according to the type of the infoframe. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c index cd50156..8537852

[PATCH 09/11] drm/sti: add HDMI vendor specific infoframe

Vendor specific infoframe is mandatory for 4K2K resolution. Without this, the HDMI protocol compliance fails. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_hdmi.c | 82 +- 1 file changed, 73 insertions(+), 9 deletions(-) diff --git a/drivers

[PATCH 08/11] drm/sti: reset infoframe transmission when HDMI is stopped

Clear all infoframe registers when the HDMI link is stopped. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_hdmi.c | 43 ++ 1 file changed, 43 insertions(+) diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c index

[PATCH 10/11] drm/sti: add colorspace property to the HDMI connector

Make the value of the colorspace of the HDMI infoframe configurable. HDMI colorspace could be: RGB, YUV422 or YUV444 Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_hdmi.c | 68 +- drivers/gpu/drm/sti/sti_hdmi.h | 12 2 files changed

[PATCH 11/11] drm/sti: add hdmi_mode property for HDMI connector

Configures the framer of the HDMI connection. By default starts in HDMI mode and can be swtich to DVI. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_hdmi.c | 30 -- drivers/gpu/drm/sti/sti_hdmi.h | 15 +++ 2 files changed, 43 insertions(+), 2

[PATCH 00/10] drm/sti: debugfs

Those patches introduce debugfs for connector, encoder, crtc and planes. It adds the following entries: - planes: gdpx / gdpx_node hqvdp cursor vid fps_get / fps_show - crtc: mixer_aux / mixer_main - encoder: tvout - connectors: hda hdmi dvo Vincent Abriou (10

[PATCH 01/10] drm/sti: add debugfs entries for HDMI connector

Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_hdmi.c | 175 - drivers/gpu/drm/sti/sti_hdmi.h | 4 +- 2 files changed, 175 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c index

[PATCH 02/10] drm/sti: add debugfs entries for DVO connector

Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_dvo.c | 70 +++ 1 file changed, 70 insertions(+) diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c index 9e90b74..25f7663 100644 --- a/drivers/gpu/drm/sti/sti_dvo.c +++ b

[PATCH 04/10] drm/sti: add debugfs entries for CURSOR plane

Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_cursor.c | 79 1 file changed, 79 insertions(+) diff --git a/drivers/gpu/drm/sti/sti_cursor.c b/drivers/gpu/drm/sti/sti_cursor.c index a4c67ab..9eac1b9 100644 --- a/drivers/gpu/drm/sti

[PATCH 03/10] drm/sti: add debugfs entries for HDA connector

Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_hda.c | 105 +- 1 file changed, 104 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c index 293a133..ec0d017 100644 --- a/drivers/gpu/drm/sti

[PATCH 05/10] drm/sti: add debugfs entries for GDP planes

Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_gdp.c | 236 ++ 1 file changed, 236 insertions(+) diff --git a/drivers/gpu/drm/sti/sti_gdp.c b/drivers/gpu/drm/sti/sti_gdp.c index a6fba9c..8f0e89f 100644 --- a/drivers/gpu/drm/sti/sti_gdp.c +++ b

[PATCH 06/10] drm/sti: add debugfs entries for HQVDP plane

Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_hqvdp.c | 243 1 file changed, 243 insertions(+) diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c index eace56d..8d2118a 100644 --- a/drivers/gpu/drm/sti/sti_hqvdp.c

[PATCH 07/10] drm/sti: add debugfs entries for VID plane

Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_compositor.c | 2 +- drivers/gpu/drm/sti/sti_vid.c| 94 +++- drivers/gpu/drm/sti/sti_vid.h| 4 +- 3 files changed, 95 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/sti

[PATCH 09/10] drm/sti: add debugfs entries for TVOUT encoders

Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_tvout.c | 157 1 file changed, 157 insertions(+) diff --git a/drivers/gpu/drm/sti/sti_tvout.c b/drivers/gpu/drm/sti/sti_tvout.c index 0b171fd..d4bb953 100644 --- a/drivers/gpu/drm/sti/sti_tvout.c

[PATCH 08/10] drm/sti: add debugfs entries for MIXER crtc

Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_compositor.c | 2 +- drivers/gpu/drm/sti/sti_mixer.c | 146 ++- drivers/gpu/drm/sti/sti_mixer.h | 4 +- 3 files changed, 149 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/sti

[PATCH 10/10] drm/sti: add debugfs fps_show/fps_get mechanism for planes

Display fps on demand for each used plane: cat /sys/kernel/debug/dri/0/fps_get Display fps in live in the console for each used plane: echo 255 > /sys/kernel/debug/dri/0/fps_show Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_cursor.c | 2 + drivers/gpu/drm/sti/sti_drv.c|

  1   2   >