Re: [PATCH] dt-bindings: Drop redundant minItems/maxItems

2021-06-16 Thread Vinod Koul
l | 2 -- > Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml | 2 -- > Documentation/devicetree/bindings/phy/renesas,usb3-phy.yaml | 1 - Acked-By: Vinod Koul -- ~Vinod

Re: [Freedreno] [RFC PATCH 00/13] drm/msm: Add Display Stream Compression Support

2021-06-17 Thread Vinod Koul
On 03-06-21, 16:40, abhin...@codeaurora.org wrote: > On 2021-06-02 04:01, Vinod Koul wrote: > > On 27-05-21, 16:30, Rob Clark wrote: > > > > yeah that is always a very different world. although it might make sense > > to use information in tables and try to deduce infor

[RFC PATCH 02/13] dt-bindings: msm/dsi: Document Display Stream Compression (DSC) parameters

2021-05-21 Thread Vinod Koul
-off-by: Vinod Koul --- .../devicetree/bindings/display/msm/dsi.txt | 15 +++ 1 file changed, 15 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/dsi.txt b/Documentation/devicetree/bindings/display/msm/dsi.txt index b9a64d3ff184..83d2fb92267e 100644

[RFC PATCH 03/13] drm/msm/disp/dpu1: Add support for DSC

2021-05-21 Thread Vinod Koul
Display Stream Compression (DSC) is one of the hw blocks in dpu, so add support by adding hw blocks for DSC Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/Makefile | 1 + .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h| 26 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c

[RFC PATCH 03/13] drm/msm/dsi: add support for dsc data

2021-05-21 Thread Vinod Koul
DSC needs some configuration from device tree, add support to read and store these params and add DSC structures in msm_drv Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/dsi/dsi_host.c | 170 + drivers/gpu/drm/msm/msm_drv.h | 32 ++ 2 files changed, 202

[RFC PATCH 04/13] drm/msm/disp/dpu1: Add support for DSC in pingpong block

2021-05-21 Thread Vinod Koul
In SDM845, DSC can be enabled by writing to pingpong block registers, so add support for DSC in hw_pp Signed-off-by: Vinod Koul --- .../gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 32 +++ .../gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h | 14 2 files changed, 46 insertions

[RFC PATCH 04/13] drm/msm/disp/dpu1: Add support for DSC

2021-05-21 Thread Vinod Koul
Display Stream Compression (DSC) is one of the hw blocks in dpu, so add support by adding hw blocks for DSC Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/Makefile | 1 + .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h| 26 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c

[RFC PATCH 01/13] drm/dsc: Add dsc pps header init function

2021-05-21 Thread Vinod Koul
We required a helper to create and set the dsc_dce_header, so add the dsc_dce_header and API drm_dsc_dsi_pps_header_init Signed-off-by: Vinod Koul --- drivers/gpu/drm/drm_dsc.c | 11 +++ include/drm/drm_dsc.h | 16 2 files changed, 27 insertions(+) diff --git

[RFC PATCH 00/13] drm/msm: Add Display Stream Compression Support

2021-05-21 Thread Vinod Koul
(not part of this series) and DT changes can be found at: git.linaro.org/people/vinod.koul/kernel.git pixel/dsc_rfc Comments welcome! Vinod Koul (13): drm/dsc: Add dsc pps header init function dt-bindings: msm/dsi: Document Display Stream Compression (DSC) parameters drm/msm/dsi: add support

[RFC PATCH 05/13] drm/msm/dsi: add support for dsc data

2021-05-21 Thread Vinod Koul
DSC needs some configuration from device tree, add support to read and store these params and add DSC structures in msm_drv Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/dsi/dsi_host.c | 171 + drivers/gpu/drm/msm/msm_drv.h | 32 ++ 2 files changed, 203

[RFC PATCH 06/13] drm/msm/disp/dpu1: Add DSC support in RM

2021-05-21 Thread Vinod Koul
This add the bits in RM to enable the DSC blocks Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 32 + drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 1 + 3 files changed, 34 insertions(+) diff --git

[RFC PATCH 10/13] drm/msm/disp/dpu1: Add support for DSC in encoder

2021-05-21 Thread Vinod Koul
When DSC is enabled in DT, we need to configure the encoder for DSC configuration, calculate DSC parameters for the given timing. This patch adds that support by adding dpu_encoder_prep_dsc() which is invoked when DSC is enabled in DT Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/disp/dpu1

[RFC PATCH 11/13] drm/msm/disp/dpu1: Add support for DSC in topology

2021-05-21 Thread Vinod Koul
2 encoders. So for now we blindly create 2,2,1 topology when DSC is enabled Co-developed-by: Abhinav Kumar Signed-off-by: Abhinav Kumar Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm

[RFC PATCH 13/13] drm/msm/dsi: Pass DSC params to drm_panel

2021-05-21 Thread Vinod Koul
When DSC is enabled, we need to pass the DSC parameters to panel driver as well, so add a dsc parameter in panel and set it when DSC is enabled Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/dsi/dsi_host.c | 5 + include/drm/drm_panel.h| 7 +++ 2 files changed, 12

[RFC PATCH 09/13] drm/msm/disp/dpu1: Don't use DSC with mode_3d

2021-05-21 Thread Vinod Koul
We cannot enable mode_3d when we are using the DSC. So pass configuration to detect DSC is enabled and not enable mode_3d when we are using DSC We add a helper dpu_encoder_helper_get_dsc_mode() to detect dsc enabled and pass this to .setup_intf_cfg() Signed-off-by: Vinod Koul --- drivers/gpu

[RFC PATCH 09/13] drm/msm/disp/dpu1: Dont use DSC with mode_3d

2021-05-21 Thread Vinod Koul
We cannot enable mode_3d when we are using the DSC. So pass configuration to detect DSC is enabled and not enable mode_3d when we are using DSC We add a helper dpu_encoder_helper_get_dsc_mode() to detect dsc enabled and pass this to .setup_intf_cfg() Signed-off-by: Vinod Koul --- drivers/gpu

[RFC PATCH 12/13] drm/msm/dsi: Add support for DSC configuration

2021-05-21 Thread Vinod Koul
When DSC is enabled, we need to configure DSI registers accordingly and configure the respective stream compression registers. Add support to calculate the register setting based on DSC params and timing information and configure these registers. Signed-off-by: Vinod Koul --- drivers/gpu/drm

[RFC PATCH 07/13] drm/msm/disp/dpu1: Add DSC for SDM845 to hw_catalog

2021-05-21 Thread Vinod Koul
This add SDM845 DSC blocks into hw_catalog Signed-off-by: Vinod Koul --- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 22 +++ 1 file changed, 22 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c index

[RFC PATCH 08/13] drm/msm/disp/dpu1: Add DSC support in hw_ctl

2021-05-21 Thread Vinod Koul
Later gens of hardware have DSC bits moved to hw_ctl, so configure these bits so that DSC would work there as well Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1

[RFC PATCH 05/13] drm/msm/disp/dpu1: Add support for DSC in pingpong block

2021-05-21 Thread Vinod Koul
In SDM845, DSC can be enabled by writing to pingpong block registers, so add support for DSC in hw_pp Signed-off-by: Vinod Koul --- .../gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 32 +++ .../gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h | 14 2 files changed, 46 insertions

Re: [RFC PATCH 02/13] dt-bindings: msm/dsi: Document Display Stream Compression (DSC) parameters

2021-05-21 Thread Vinod Koul
On 21-05-21, 08:18, Rob Herring wrote: > On Fri, May 21, 2021 at 7:50 AM Vinod Koul wrote: > > > > DSC enables streams to be compressed before we send to panel. This > > requires DSC enabled encoder and a panel to be present. So we add this > > information in bo

Re: [RFC PATCH 02/13] dt-bindings: msm/dsi: Document Display Stream Compression (DSC) parameters

2021-05-25 Thread Vinod Koul
On 24-05-21, 10:08, Bjorn Andersson wrote: > On Mon 24 May 02:30 CDT 2021, Vinod Koul wrote: > > > On 21-05-21, 09:42, Bjorn Andersson wrote: > > > On Fri 21 May 07:49 CDT 2021, Vinod Koul wrote: > > > > > > > DSC enables streams to be compressed befo

Re: [Freedreno] [RFC PATCH 00/13] drm/msm: Add Display Stream Compression Support

2021-05-25 Thread Vinod Koul
Hello Jeff, On 21-05-21, 08:09, Jeffrey Hugo wrote: > On Fri, May 21, 2021 at 6:50 AM Vinod Koul wrote: > > > > Display Stream Compression (DSC) compresses the display stream in host which > > is later decoded by panel. This series enables this for Qualcomm msm driver

Re: [Freedreno] [RFC PATCH 00/13] drm/msm: Add Display Stream Compression Support

2021-06-02 Thread Vinod Koul
On 27-05-21, 16:30, Rob Clark wrote: > On Wed, May 26, 2021 at 8:00 AM Jeffrey Hugo wrote: > > On Tue, May 25, 2021 at 11:46 PM Vinod Koul wrote: > > Frankly, I don't like the MSM ACPI solution that I've seen on the laptops. > > The ACPI assumes the entire MDSS (includi

Re: [Freedreno] [RFC PATCH 00/13] drm/msm: Add Display Stream Compression Support

2021-06-02 Thread Vinod Koul
On 26-05-21, 09:00, Jeffrey Hugo wrote: > On Tue, May 25, 2021 at 11:46 PM Vinod Koul wrote: > > On 21-05-21, 08:09, Jeffrey Hugo wrote: > > > On Fri, May 21, 2021 at 6:50 AM Vinod Koul wrote: > > > > > > > > Display Stream Compression (DSC) compresses

Re: [RFC PATCH 03/13] drm/msm/dsi: add support for dsc data

2021-06-02 Thread Vinod Koul
On 28-05-21, 02:45, Dmitry Baryshkov wrote: > On 21/05/2021 15:49, Vinod Koul wrote: > > DSC needs some configuration from device tree, add support to read and > > store these params and add DSC structures in msm_drv > > > > Signed-off-by: Vinod Koul > >

Re: [RFC PATCH 03/13] drm/msm/dsi: add support for dsc data

2021-06-02 Thread Vinod Koul
On 28-05-21, 13:29, Dmitry Baryshkov wrote: > On 21/05/2021 15:49, Vinod Koul wrote: > > DSC needs some configuration from device tree, add support to read and > > store these params and add DSC structures in msm_drv > > > > Signed-off-by: Vinod Koul > >

Re: [RFC PATCH 02/13] dt-bindings: msm/dsi: Document Display Stream Compression (DSC) parameters

2021-05-24 Thread Vinod Koul
On 21-05-21, 09:42, Bjorn Andersson wrote: > On Fri 21 May 07:49 CDT 2021, Vinod Koul wrote: > > > DSC enables streams to be compressed before we send to panel. This > > requires DSC enabled encoder and a panel to be present. So we add this > > information in board

Re: [RFC PATCH 01/13] drm/dsc: Add dsc pps header init function

2021-05-24 Thread Vinod Koul
On 21-05-21, 17:29, Daniel Vetter wrote: > On Fri, May 21, 2021 at 06:19:30PM +0530, Vinod Koul wrote: > > We required a helper to create and set the dsc_dce_header, so add the > > dsc_dce_header and API drm_dsc_dsi_pps_header_init > > > > Signed-off-by: Vinod Koul &

Re: [PATCH v4 2/5] phy: Add LVDS configuration options

2021-03-25 Thread Vinod Koul
On 18-03-21, 10:22, Liu Ying wrote: > > Can we have these in kernel-doc style please, similar to style in > > linux/phy/phy.h > > I take this way of in-line member documentation comment for the below 3 > reasons: > > 1) Members of struct phy_configure_opts_mipi_dphy and > struct

Re: [PATCH 14/30] Revert "s3c24xx-dma.c: Fix a typo"

2021-03-30 Thread Vinod Koul
On 29-03-21, 05:23, Bhaskar Chowdhury wrote: > s/transferred/transfered/ > > This reverts commit a2ddb8aea8106bd5552f8516ad7a8a26b9282a8f. This is not upstream, why not squash in. Also would make sense to write sensible changelog and not phrases and use the right subsystem conventions! Droped

Re: [PATCH v4 2/5] phy: Add LVDS configuration options

2021-03-17 Thread Vinod Koul
arameters > should cover all potential users. > > Cc: Kishon Vijay Abraham I > Cc: Vinod Koul > Cc: NXP Linux Team > Reviewed-by: Robert Foss > Signed-off-by: Liu Ying > --- > v3->v4: > * Add Robert's R-b tag. > > v2->v3: > * No change. >

Re: [PATCH] drm/msm/dp: add support of HBR3 link rate

2021-02-17 Thread Vinod Koul
On 17-02-21, 09:36, Stephen Boyd wrote: > Quoting Kuogee Hsieh (2021-02-17 08:58:42) > > Add hbr3_hbr2 voltage and pre-emphasis swing table to support > > HBR3 link rate > > > > Signed-off-by: Kuogee Hsieh > > --- > > drivers/gpu/drm/msm/dp/dp_panel.c | 4 > >

Re: [PATCH v3 1/9] dt-bindings: phy: mediatek: tphy: support type switch by pericfg

2021-08-17 Thread Vinod Koul
On 17-08-21, 17:19, Chunfeng Yun wrote: > Add support type switch by pericfg register between USB3, PCIe, > SATA, SGMII, this is used to replace the way through efuse or > jumper. Applied all, thanks -- ~Vinod

[PATCH 01/11] drm/msm/dsi: add support for dsc data

2021-07-15 Thread Vinod Koul
Display Stream Compression (DSC) parameters need to be calculated. Add helpers and struct msm_display_dsc_config in msm_drv for this msm_display_dsc_config uses drm_dsc_config for DSC parameters. Signed-off-by: Vinod Koul --- Changes since RFC: - Drop the DT parsing code - Port dsc param

[PATCH 02/11] drm/msm/disp/dpu1: Add support for DSC

2021-07-15 Thread Vinod Koul
Display Stream Compression (DSC) is one of the hw blocks in dpu, so add support by adding hw blocks for DSC Signed-off-by: Vinod Koul --- Changes since RFC: - Drop unused enums drivers/gpu/drm/msm/Makefile | 1 + .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h| 13

[PATCH 07/11] drm/msm/disp/dpu1: Don't use DSC with mode_3d

2021-07-15 Thread Vinod Koul
We cannot enable mode_3d when we are using the DSC. So pass configuration to detect DSC is enabled and not enable mode_3d when we are using DSC We add a helper dpu_encoder_helper_get_dsc_mode() to detect dsc enabled and pass this to .setup_intf_cfg() Signed-off-by: Vinod Koul --- drivers/gpu

[PATCH 00/11] drm/msm: Add Display Stream Compression Support

2021-07-15 Thread Vinod Koul
comments raised by Dimitry - Add dsc parameters calculation from downstream Vinod Koul (11): drm/msm/dsi: add support for dsc data drm/msm/disp/dpu1: Add support for DSC drm/msm/disp/dpu1: Add support for DSC in pingpong block drm/msm/disp/dpu1: Add DSC support in RM drm/msm/disp/dpu1: Add

[PATCH 04/11] drm/msm/disp/dpu1: Add DSC support in RM

2021-07-15 Thread Vinod Koul
This add the bits in RM to enable the DSC blocks Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 32 + drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 1 + 3 files changed, 34 insertions(+) diff --git

[PATCH 05/11] drm/msm/disp/dpu1: Add DSC for SDM845 to hw_catalog

2021-07-15 Thread Vinod Koul
This add SDM845 DSC blocks into hw_catalog Signed-off-by: Vinod Koul --- Changes since RFC: - use BIT values from MASK .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 22 +++ 1 file changed, 22 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b

[PATCH 03/11] drm/msm/disp/dpu1: Add support for DSC in pingpong block

2021-07-15 Thread Vinod Koul
In SDM845, DSC can be enabled by writing to pingpong block registers, so add support for DSC in hw_pp Signed-off-by: Vinod Koul --- .../gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 32 +++ .../gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h | 14 2 files changed, 46 insertions

[PATCH 06/11] drm/msm/disp/dpu1: Add DSC support in hw_ctl

2021-07-15 Thread Vinod Koul
Later gens of hardware have DSC bits moved to hw_ctl, so configure these bits so that DSC would work there as well Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1

[PATCH 08/11] drm/msm/disp/dpu1: Add support for DSC in encoder

2021-07-15 Thread Vinod Koul
When DSC is enabled in DT, we need to configure the encoder for DSC configuration, calculate DSC parameters for the given timing. This patch adds that support by adding dpu_encoder_prep_dsc() which is invoked when DSC is enabled in DT Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/disp/dpu1

[PATCH 09/11] drm/msm/disp/dpu1: Add support for DSC in topology

2021-07-15 Thread Vinod Koul
-by: Abhinav Kumar Signed-off-by: Abhinav Kumar Signed-off-by: Vinod Koul --- Changes since RFC: - Add more details in changelog drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers

[PATCH 10/11] drm/msm/dsi: Add support for DSC configuration

2021-07-15 Thread Vinod Koul
When DSC is enabled, we need to configure DSI registers accordingly and configure the respective stream compression registers. Add support to calculate the register setting based on DSC params and timing information and configure these registers. Signed-off-by: Vinod Koul --- drivers/gpu/drm

[PATCH 11/11] drm/msm/dsi: Pass DSC params to drm_panel

2021-07-15 Thread Vinod Koul
When DSC is enabled, we need to pass the DSC parameters to panel driver as well, so add a dsc parameter in panel and set it when DSC is enabled Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/dsi/dsi_host.c | 16 +++- include/drm/drm_panel.h| 7 +++ 2 files

Re: [PATCH v2 04/11] drm/msm/disp/dpu1: Add DSC support in RM

2021-10-19 Thread Vinod Koul
On 14-10-21, 17:11, Dmitry Baryshkov wrote: > On 07/10/2021 10:08, Vinod Koul wrote: > > +static int _dpu_rm_reserve_dsc(struct dpu_rm *rm, > > + struct dpu_global_state *global_state, > > + struct drm_encoder *enc)

Re: [PATCH v2 04/11] drm/msm/disp/dpu1: Add DSC support in RM

2021-10-19 Thread Vinod Koul
On 19-10-21, 18:52, Dmitry Baryshkov wrote: > On Tue, 19 Oct 2021 at 18:30, Vinod Koul wrote: > > > > On 14-10-21, 17:11, Dmitry Baryshkov wrote: > > > On 07/10/2021 10:08, Vinod Koul wrote: > > > > > > +static int _dpu_rm_reserve_dsc(struct dpu_rm *rm,

Re: [PATCH v2 02/11] drm/msm/disp/dpu1: Add support for DSC

2021-10-19 Thread Vinod Koul
On 14-10-21, 17:40, Dmitry Baryshkov wrote: > On 07/10/2021 10:08, Vinod Koul wrote: > > +static void dpu_hw_dsc_config(struct dpu_hw_dsc *hw_dsc, > > + struct msm_display_dsc_config *dsc, u32 mode) > > +{ > > + struct dpu_hw_blk_reg_map *c =

Re: [PATCH v2 06/11] drm/msm/disp/dpu1: Don't use DSC with mode_3d

2021-10-20 Thread Vinod Koul
On 14-10-21, 16:50, Dmitry Baryshkov wrote: > On 14/10/2021 16:41, Dmitry Baryshkov wrote: > > On 07/10/2021 10:08, Vinod Koul wrote: > > > We cannot enable mode_3d when we are using the DSC. So pass > > > configuration to detect DSC is enabled and not enable mode_3d

Re: [PATCH v2 07/11] drm/msm/disp/dpu1: Add DSC support in hw_ctl

2021-10-20 Thread Vinod Koul
On 14-10-21, 17:06, Dmitry Baryshkov wrote: > On 07/10/2021 10:08, Vinod Koul wrote: > > Later gens of hardware have DSC bits moved to hw_ctl, so configure these > > bits so that DSC would work there as well > > > > Signed-off-by: Vinod Koul > > --- >

Re: [PATCH v2 10/11] drm/msm/dsi: Add support for DSC configuration

2021-10-20 Thread Vinod Koul
On 15-10-21, 02:18, Dmitry Baryshkov wrote: > On 07/10/2021 10:08, Vinod Koul wrote: > > When DSC is enabled, we need to configure DSI registers accordingly and > > configure the respective stream compression registers. > > > > Add support to calculate the register

Re: [PATCH 1/4] phy: mediatek: add support for phy-mtk-hdmi-mt8195

2021-10-01 Thread Vinod Koul
On 07-09-21, 10:37, Guillaume Ranquet wrote: > Add basic support for the mediatek hdmi phy on MT8195 SoC > > Signed-off-by: Guillaume Ranquet > --- > drivers/phy/mediatek/Makefile | 1 + > drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c | 777 + >

Re: [Freedreno] [PATCH 07/11] drm/msm/disp/dpu1: Don't use DSC with mode_3d

2021-10-06 Thread Vinod Koul
On 02-08-21, 17:24, abhin...@codeaurora.org wrote: > On 2021-07-14 23:51, Vinod Koul wrote: > > We cannot enable mode_3d when we are using the DSC. So pass > > configuration to detect DSC is enabled and not enable mode_3d > > when we are using DSC >

Re: [Freedreno] [PATCH 08/11] drm/msm/disp/dpu1: Add support for DSC in encoder

2021-10-06 Thread Vinod Koul
On 02-08-21, 17:57, abhin...@codeaurora.org wrote: > On 2021-07-14 23:52, Vinod Koul wrote: > > When DSC is enabled in DT, we need to configure the encoder for DSC > > configuration, calculate DSC parameters for the given timing. > > > > This patch adds that support by

Re: [Freedreno] [PATCH 05/11] drm/msm/disp/dpu1: Add DSC for SDM845 to hw_catalog

2021-10-06 Thread Vinod Koul
On 02-08-21, 16:29, abhin...@codeaurora.org wrote: > On 2021-07-14 23:51, Vinod Koul wrote: > > This add SDM845 DSC blocks into hw_catalog > /add --> adds > > > > Signed-off-by: Vinod Koul > > --- > > Changes since RFC: > > - use BIT values

Re: [PATCH 04/11] drm/msm/disp/dpu1: Add DSC support in RM

2021-10-06 Thread Vinod Koul
On 29-07-21, 23:23, Dmitry Baryshkov wrote: > On 15/07/2021 09:51, Vinod Koul wrote: > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c > > b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c > > index fd2d104f0a91..4da6d72b7996 100644 > > --- a/drivers/gpu/drm/msm/disp/dpu1

Re: [PATCH 08/11] drm/msm/disp/dpu1: Add support for DSC in encoder

2021-10-06 Thread Vinod Koul
On 29-07-21, 23:54, Dmitry Baryshkov wrote: > On 15/07/2021 09:52, Vinod Koul wrote: > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > > b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > > index 8d942052db8a..41140b781e66 100644 > > --- a/drivers/gpu/drm/

Re: [Freedreno] [PATCH 04/11] drm/msm/disp/dpu1: Add DSC support in RM

2021-10-06 Thread Vinod Koul
On 02-08-21, 16:24, abhin...@codeaurora.org wrote: > On 2021-07-14 23:51, Vinod Koul wrote: > > @@ -476,6 +498,9 @@ static int _dpu_rm_reserve_intf( > > } > > > > global_state->intf_to_enc_id[idx] = enc_id; > > + > > + global_state->ds

Re: [PATCH 05/11] drm/msm/disp/dpu1: Add DSC for SDM845 to hw_catalog

2021-10-06 Thread Vinod Koul
On 29-07-21, 23:25, Dmitry Baryshkov wrote: > On 15/07/2021 09:51, Vinod Koul wrote: > > This add SDM845 DSC blocks into hw_catalog > > > > Signed-off-by: Vinod Koul > > --- > > Changes since RFC: > > - use BIT values from MASK > > > >

Re: [PATCH 06/11] drm/msm/disp/dpu1: Add DSC support in hw_ctl

2021-10-06 Thread Vinod Koul
On 30-07-21, 01:15, Dmitry Baryshkov wrote: > On 15/07/2021 09:51, Vinod Koul wrote: > > Later gens of hardware have DSC bits moved to hw_ctl, so configure these > > bits so that DSC would work there as well > > > > Signed-off-by: Vinod Koul > > --- &g

Re: [Freedreno] [PATCH 06/11] drm/msm/disp/dpu1: Add DSC support in hw_ctl

2021-10-06 Thread Vinod Koul
On 02-08-21, 17:00, abhin...@codeaurora.org wrote: > On 2021-07-14 23:51, Vinod Koul wrote: > > Later gens of hardware have DSC bits moved to hw_ctl, so configure these > > bits so that DSC would work there as well > > > > Signed-off-by: Vinod Koul > Please correct

[PATCH v2 06/11] drm/msm/disp/dpu1: Don't use DSC with mode_3d

2021-10-07 Thread Vinod Koul
We cannot enable mode_3d when we are using the DSC. So pass configuration to detect DSC is enabled and not enable mode_3d when we are using DSC We add a helper dpu_encoder_helper_get_dsc_mode() to detect dsc enabled and pass this to .setup_intf_cfg() Signed-off-by: Vinod Koul --- Changes since

[PATCH v2 07/11] drm/msm/disp/dpu1: Add DSC support in hw_ctl

2021-10-07 Thread Vinod Koul
Later gens of hardware have DSC bits moved to hw_ctl, so configure these bits so that DSC would work there as well Signed-off-by: Vinod Koul --- Changes since v1: - Move this patch from 6 to 7 due to dependency on 6th one - Use DSC indices for programming DSC registers and program only on non

[PATCH v2 10/11] drm/msm/dsi: Add support for DSC configuration

2021-10-07 Thread Vinod Koul
When DSC is enabled, we need to configure DSI registers accordingly and configure the respective stream compression registers. Add support to calculate the register setting based on DSC params and timing information and configure these registers. Signed-off-by: Vinod Koul --- drivers/gpu/drm

[PATCH v2 11/11] drm/msm/dsi: Pass DSC params to drm_panel

2021-10-07 Thread Vinod Koul
When DSC is enabled, we need to pass the DSC parameters to panel driver as well, so add a dsc parameter in panel and set it when DSC is enabled Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/dsi/dsi_host.c | 16 +++- include/drm/drm_panel.h| 7 +++ 2 files

[PATCH v2 08/11] drm/msm/disp/dpu1: Add support for DSC in encoder

2021-10-07 Thread Vinod Koul
We need to configure the encoder for DSC configuration and calculate DSC parameters for the given timing so this patch adds that support by adding dpu_encoder_prep_dsc() which is invoked when DSC is enabled. Signed-off-by: Vinod Koul --- Changes since v1: - Remove duplicate defines - Update

[PATCH v2 09/11] drm/msm/disp/dpu1: Add support for DSC in topology

2021-10-07 Thread Vinod Koul
. The panel has been tested only with 2,2,1 configuration, so for now we blindly create 2,2,1 topology when DSC is enabled Co-developed-by: Abhinav Kumar Signed-off-by: Abhinav Kumar Signed-off-by: Vinod Koul --- Changes since RFC: - Add more details in changelog drivers/gpu/drm/msm/disp/dpu1

[PATCH v2 00/11] drm/msm: Add Display Stream Compression Support

2021-10-07 Thread Vinod Koul
mask, use 0 - Check for DSC in hw_ctl Changes since RFC: - Drop the DT binding patch as we derive the configuration from panel - Drop the drm api patch as we no longer need it (use pps drm api) - Fix comments raised by Dimitry - Add dsc parameters calculation from downstream Vinod Koul (11

[PATCH v2 01/11] drm/msm/dsi: add support for dsc data

2021-10-07 Thread Vinod Koul
Display Stream Compression (DSC) parameters need to be calculated. Add helpers and struct msm_display_dsc_config in msm_drv for this msm_display_dsc_config uses drm_dsc_config for DSC parameters. Signed-off-by: Vinod Koul --- Changes since v1: - Drop unused fields from msm_display_dsc_config

[PATCH v2 02/11] drm/msm/disp/dpu1: Add support for DSC

2021-10-07 Thread Vinod Koul
Display Stream Compression (DSC) is one of the hw blocks in dpu, so add support by adding hw blocks for DSC Signed-off-by: Vinod Koul --- Changes since v1: - remove unused variable lp - Update copyright year RFC: - Drop unused enums drivers/gpu/drm/msm/Makefile | 1

[PATCH v2 03/11] drm/msm/disp/dpu1: Add support for DSC in pingpong block

2021-10-07 Thread Vinod Koul
In SDM845, DSC can be enabled by writing to pingpong block registers, so add support for DSC in hw_pp Reviewed-by: Abhinav Kumar Signed-off-by: Vinod Koul --- .../gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 32 +++ .../gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h | 14 2

[PATCH v2 04/11] drm/msm/disp/dpu1: Add DSC support in RM

2021-10-07 Thread Vinod Koul
This add the bits in RM to enable the DSC blocks Signed-off-by: Vinod Koul --- Changes since v1: - Add _dpu_rm_reserve_dsc() function which checks if DSC is enabled - Fix to use dsc_blks drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 61

[PATCH v2 05/11] drm/msm/disp/dpu1: Add DSC for SDM845 to hw_catalog

2021-10-07 Thread Vinod Koul
This adds SDM845 DSC blocks into hw_catalog Signed-off-by: Vinod Koul --- Changes since v1: - Remove DSC_SDM845_MASK and use 0 as feature mask .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 20 +++ 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1

Re: [Freedreno] [PATCH 01/11] drm/msm/dsi: add support for dsc data

2021-10-05 Thread Vinod Koul
Hi Abhinav, On 02-08-21, 15:55, abhin...@codeaurora.org wrote: > > +static int dsi_populate_dsc_params(struct msm_display_dsc_config *dsc) > > +{ > > + int mux_words_size; > > + int groups_per_line, groups_total; > > + int min_rate_buffer_size; > > + int hrd_delay; > > + int

Re: [Freedreno] [PATCH 02/11] drm/msm/disp/dpu1: Add support for DSC

2021-10-05 Thread Vinod Koul
On 02-08-21, 16:03, abhin...@codeaurora.org wrote: > On 2021-07-14 23:51, Vinod Koul wrote: > > Display Stream Compression (DSC) is one of the hw blocks in dpu, so add > > support by adding hw blocks for DSC > > > > Signed-off-by: Vinod Koul > > --- > >

Re: [PATCH v5 6/7] phy: phy-mtk-dp: Add driver for DP phy

2021-10-21 Thread Vinod Koul
On 21-10-21, 11:27, Markus Schneider-Pargmann wrote: > This is a new driver that supports the integrated DisplayPort phy for > mediatek SoCs, especially the mt8195. The phy is integrated into the > DisplayPort controller and will be created by the mtk-dp driver. This > driver expects a struct

Re: [PATCH v5 6/7] phy: phy-mtk-dp: Add driver for DP phy

2021-10-25 Thread Vinod Koul
On 22-10-21, 15:06, Markus Schneider-Pargmann wrote: > > > + dp_phy->regs = *(struct regmap **)dev->platform_data; > > > + if (!dp_phy->regs) { > > > + dev_err(dev, "No data passed, requires struct regmap**\n"); > > > + return -EINVAL; > > > + } > > > > is there a reason to do it

Re: [PATCH v4 00/22] Support HDMI audio on NVIDIA Tegra20

2021-12-16 Thread Vinod Koul
esend after the merge window. > > This patch is included as a part of this series, please see the patch #6. > > > > I saw that Vinod Koul already merged it into his DMA tree [1] a day ago, > > but there is no stable branch there. > > > > [1] > > https://git.

Re: [PATCH v7 6/8] phy: phy-mtk-dp: Add driver for DP phy

2021-12-28 Thread Vinod Koul
On 17-12-21, 16:08, Guillaume Ranquet wrote: > From: Markus Schneider-Pargmann Pls cc relevant folks on cover so that they know what is going on in the series... Is this dependent on rest? It should not and can be sent and reviewed separately! > This is a new driver that supports the

[PATCH v3 11/13] drm/msm/dsi: add mode valid callback for dsi_mgr

2021-11-15 Thread Vinod Koul
Add a mode valid callback for dsi_mgr for checking mode being valid in case of DSC. For DSC the height and width needs to be multiple of slice, so we check that here Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/dsi/dsi.h | 2 ++ drivers/gpu/drm/msm/dsi/dsi_host.c| 26

[PATCH v3 12/13] drm/msm/dsi: Add support for DSC configuration

2021-11-15 Thread Vinod Koul
When DSC is enabled, we need to configure DSI registers accordingly and configure the respective stream compression registers. Add support to calculate the register setting based on DSC params and timing information and configure these registers. Signed-off-by: Vinod Koul --- drivers/gpu/drm

[PATCH v3 13/13] drm/msm/dsi: Pass DSC params to drm_panel

2021-11-15 Thread Vinod Koul
When DSC is enabled, we need to pass the DSC parameters to panel driver as well, so add a dsc parameter in panel and set it when DSC is enabled Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/dsi/dsi_host.c | 16 +++- include/drm/drm_panel.h| 7 +++ 2 files

[PATCH v3 07/13] drm/msm/disp/dpu1: Add support for DSC in encoder

2021-11-15 Thread Vinod Koul
We need to configure the encoder for DSC configuration and calculate DSC parameters for the given timing so this patch adds that support by adding dpu_encoder_prep_dsc() which is invoked when DSC is enabled. Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 140

[PATCH v3 02/13] drm/msm/disp/dpu1: Add support for DSC

2021-11-15 Thread Vinod Koul
Display Stream Compression (DSC) is one of the hw blocks in dpu, so add support by adding hw blocks for DSC Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/Makefile | 1 + .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h| 13 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c

[PATCH v3 00/13] drm/msm: Add Display Stream Compression Support

2021-11-15 Thread Vinod Koul
patch as we no longer need it (use pps drm api) - Fix comments raised by Dimitry - Add dsc parameters calculation from downstream Vinod Koul (13): drm/msm/dsi: add support for dsc data drm/msm/disp/dpu1: Add support for DSC drm/msm/disp/dpu1: Add support for DSC in pingpong block drm/msm/disp

[PATCH v3 01/13] drm/msm/dsi: add support for dsc data

2021-11-15 Thread Vinod Koul
Display Stream Compression (DSC) parameters need to be calculated. Add helpers and struct msm_display_dsc_config in msm_drv for this msm_display_dsc_config uses drm_dsc_config for DSC parameters. Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/dsi/dsi_host.c | 132

[PATCH v3 09/13] drm/msm/disp/dpu1: Add support for DSC in topology

2021-11-15 Thread Vinod Koul
. The panel has been tested only with 2,2,1 configuration, so for now we blindly create 2,2,1 topology when DSC is enabled Co-developed-by: Abhinav Kumar Signed-off-by: Abhinav Kumar Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 18 ++ drivers/gpu/drm

[PATCH v3 10/13] drm/msm/disp/dpu1: Add DSC support in RM

2021-11-15 Thread Vinod Koul
This add the bits in RM to enable the DSC blocks Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 66 + drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 1 + 3 files changed, 68 insertions(+) diff --git

[PATCH v3 04/13] drm/msm/disp/dpu1: Add DSC for SDM845 to hw_catalog

2021-11-15 Thread Vinod Koul
This adds SDM845 DSC blocks into hw_catalog Reviewed-by: Dmitry Baryshkov Signed-off-by: Vinod Koul --- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 20 +++ 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm

[PATCH v3 05/13] drm/msm/disp/dpu1: Don't use DSC with mode_3d

2021-11-15 Thread Vinod Koul
We cannot enable mode_3d when we are using the DSC. So pass configuration to detect DSC is enabled and not enable mode_3d when we are using DSC We add a helper dpu_encoder_helper_get_dsc() to detect dsc enabled and pass this to .setup_intf_cfg() Signed-off-by: Vinod Koul --- drivers/gpu/drm

[PATCH v3 06/13] drm/msm/disp/dpu1: Add DSC support in hw_ctl

2021-11-15 Thread Vinod Koul
Later gens of hardware have DSC bits moved to hw_ctl, so configure these bits so that DSC would work there as well Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp

[PATCH v3 03/13] drm/msm/disp/dpu1: Add support for DSC in pingpong block

2021-11-15 Thread Vinod Koul
In SDM845, DSC can be enabled by writing to pingpong block registers, so add support for DSC in hw_pp Reviewed-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov Signed-off-by: Vinod Koul --- .../gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 32 +++ .../gpu/drm/msm/disp/dpu1

[PATCH v3 08/13] drm/msm: Add missing structure documentation

2021-11-15 Thread Vinod Koul
Somehow documentation for dspp was missed, so add that Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/msm_drv.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h index de7cb65bfc52..c4a588ad226e 100644 --- a/drivers/gpu/drm/msm

Re: [PATCH 08/11] dmaengine: xilinx_dpdma: stop using slave_id field

2021-11-15 Thread Vinod Koul
On 15-11-21, 11:21, Arnd Bergmann wrote: > On Mon, Nov 15, 2021 at 10:14 AM Laurent Pinchart > wrote: > > On Mon, Nov 15, 2021 at 09:54:00AM +0100, Arnd Bergmann wrote: > > > @@ -1285,11 +1287,13 @@ static int xilinx_dpdma_config(struct dma_chan > > > *dchan, > > > spin_lock_irqsave(>lock,

Re: [PATCH 07/11] dmaengine: qcom-adm: stop abusing slave_id config

2021-11-25 Thread Vinod Koul
On 25-11-21, 09:25, Arnd Bergmann wrote: > On Thu, Nov 25, 2021 at 8:57 AM kernel test robot wrote: > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > > > All warnings (new ones prefixed by >>): > > > > >>

Re: [PATCH] lontium-lt9611: check a different register bit for HDMI sensing

2021-11-16 Thread Vinod Koul
On 16-11-21, 22:49, Anibal Limon wrote: > Dmitry, > > May be this is the reason of my HP monitor not working in RB5. Rb5 has Lt9611UXC > > Regards, > Anibal > > El mar., 16 de noviembre de 2021 20:07, Peter Collingbourne > escribió: > > > It has been observed that with certain monitors

Re: [PATCH] lontium-lt9611: check a different register bit for HDMI sensing

2021-11-16 Thread Vinod Koul
Hi John, On 16-11-21, 20:47, John Stultz wrote: > On Tue, Nov 16, 2021 at 6:07 PM Peter Collingbourne wrote: > > > > It has been observed that with certain monitors such as the HP Z27n, > > the register 0x825e reads a value of 0x79 when the HDMI cable is > > connected and 0x78 when it is

Re: [PATCH v2 06/11] drm/msm/disp/dpu1: Don't use DSC with mode_3d

2021-10-25 Thread Vinod Koul
On 25-10-21, 17:40, Dmitry Baryshkov wrote: > On 20/10/2021 09:57, Vinod Koul wrote: > > On 14-10-21, 16:50, Dmitry Baryshkov wrote: > > > On 14/10/2021 16:41, Dmitry Baryshkov wrote: > > > > On 07/10/2021 10:08, Vinod Koul wrote: > > > > > diff --git

Re: [PATCH v2 09/11] drm/msm/disp/dpu1: Add support for DSC in topology

2021-10-25 Thread Vinod Koul
On 25-10-21, 17:37, Dmitry Baryshkov wrote: > On 14/10/2021 17:13, Dmitry Baryshkov wrote: > > On 07/10/2021 10:08, Vinod Koul wrote: > > > @@ -572,8 +574,22 @@ static struct msm_display_topology > > > dpu_encoder_get_topology( > > >   topology.num_en

<    1   2   3   4   >