Re: [Xen-devel] [PATCH 0/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver

2018-04-25 Thread Wei Liu
rote: > >>>> On 24/04/18 07:43, Oleksandr Andrushchenko wrote: > >>>>> On 04/24/2018 01:41 AM, Boris Ostrovsky wrote: > >>>>>> On 04/23/2018 08:10 AM, Oleksandr Andrushchenko wrote: > >>>>>>> On 04/23/2018 02:52 PM,

Re: [Xen-devel] [PATCH 0/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver

2018-04-24 Thread Wei Liu
On Fri, Apr 20, 2018 at 02:25:20PM +0300, Oleksandr Andrushchenko wrote: > > > the gntdev. > > > > > > I think this is generic enough that it could be implemented by a > > > device not tied to Xen. AFAICT the hyper_dma guys also wanted > > > something similar to this. > > You can't just wrap

Re: [PATCH -next 019/491] Hyper-V CORE AND DRIVERS: Use fallthrough;

2020-03-11 Thread Wei Liu
oe Perches Reviewed-by: Wei Liu ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 01/28] x86/hyperv: use vmalloc_exec for the hypercall page

2020-04-09 Thread Wei Liu
On Wed, Apr 08, 2020 at 01:58:59PM +0200, Christoph Hellwig wrote: > Use the designated helper for allocating executable kernel memory, and > remove the now unused PAGE_KERNEL_RX define. > > Signed-off-by: Christoph Hellwig Acked-by: Wei Liu ___

Re: [PATCH 21/29] mm: remove the pgprot argument to __vmalloc

2020-04-14 Thread Wei Liu
*hvp = __vmalloc(PAGE_SIZE, GFP_KERNEL | __GFP_ZERO); > } Acked-by: Wei Liu ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] video: hyperv_fb: Directly use the MMIO VRAM

2020-11-24 Thread Wei Liu
On Tue, Nov 24, 2020 at 08:33:32AM +, Dexuan Cui wrote: > Hi Wei Liu, > Please do not pick up this patch, because actually MMIO VRAM can not work > with fb_deferred_io. > No problem. Thanks for the heads-up. Wei. ___ dri-devel mail

Re: [PATCH] video: hyperv_fb: Fix the cache type when mapping the VRAM

2020-11-18 Thread Wei Liu
On Wed, Nov 18, 2020 at 12:20:11AM +, Michael Kelley wrote: > From: Dexuan Cui Sent: Tuesday, November 17, 2020 4:03 > PM > > > > x86 Hyper-V used to essentially always overwrite the effective cache type > > of guest memory accesses to WB. This was problematic in cases where there > > is a

Re: [PATCH v4 3/3] MAINTAINERS: Add maintainer for hyperv video device

2021-05-17 Thread Wei Liu
On Mon, May 17, 2021 at 04:59:22AM -0700, Deepak Rawat wrote: > Maintainer for hyperv synthetic video device. > > Signed-off-by: Deepak Rawat > --- > MAINTAINERS | 16 > 1 file changed, 16 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index

Re: [bug report] Commit ccf953d8f3d6 ("fb_defio: Remove custom address_space_operations") breaks Hyper-V FB driver

2021-06-04 Thread Wei Liu
On Fri, Jun 04, 2021 at 02:25:01PM +0200, Vitaly Kuznetsov wrote: > Hi, > > Commit ccf953d8f3d6 ("fb_defio: Remove custom address_space_operations") > seems to be breaking Hyper-V framebuffer > (drivers/video/fbdev/hyperv_fb.c) driver for me: Hyper-V guest boots > well and plymouth even works but

Re: [PATCH] video/fbdev: Fix a double free in hvfb_probe

2021-03-23 Thread Wei Liu
Thanks for your patch. I would like to change the prefix to "video: hyperv_fb:" to be more specific. On Tue, Mar 23, 2021 at 12:33:50AM -0700, Lv Yunlong wrote: > In function hvfb_probe in hyperv_fb.c, it calls hvfb_getmem(hdev, info) > and return err when info->apertures is freed. > > In the

Re: [PATCH v2] video: hyperv_fb: Fix a double free in hvfb_probe

2021-03-25 Thread Wei Liu
ory and > leaving the pointer non-NULL, resulting in a double free if an error > occurs or later if hvfb_remove() is called. > > Fix this by removing all kfree(info->apertures) calls in hvfb_getmem(). > This will allow framebuffer_release() to free the memory, which follow

Re: [PATCH 1/1] video: hyperv_fb: Add ratelimit on error message

2021-04-20 Thread Wei Liu
On Tue, Apr 20, 2021 at 08:44:19AM -0700, Michael Kelley wrote: > Due to a full ring buffer, the driver may be unable to send updates to > the Hyper-V host. But outputing the error message can make the problem > worse because console output is also typically written to the frame > buffer. As a

Re: [PATCH v2] hv: account for packet descriptor in maximum packet size

2022-01-14 Thread Wei Liu
On Mon, Jan 10, 2022 at 01:44:19AM +0100, Andrea Parri wrote: > (Extending Cc: list,) > > On Sun, Jan 09, 2022 at 05:55:16PM +0800, Yanming Liu wrote: > > Commit adae1e931acd ("Drivers: hv: vmbus: Copy packets sent by Hyper-V > > out of the ring buffer") introduced a notion of maximum packet size

Re: [PATCH 1/1] video: hyperv_fb: Fix validation of screen resolution

2022-01-23 Thread Wei Liu
On Sun, Jan 23, 2022 at 10:27:56PM +, Michael Kelley (LINUX) wrote: > From: Wei Liu Sent: Sunday, January 23, 2022 1:56 PM > > > > On Sun, Jan 16, 2022 at 09:53:06PM +, Haiyang Zhang wrote: > > > > > > > > > > -Original Message- >

Re: [PATCH 1/1] video: hyperv_fb: Fix validation of screen resolution

2022-01-23 Thread Wei Liu
On Sun, Jan 16, 2022 at 09:53:06PM +, Haiyang Zhang wrote: > > > > -Original Message- > > From: Michael Kelley (LINUX) > > Sent: Sunday, January 16, 2022 2:19 PM > > To: KY Srinivasan ; Haiyang Zhang > > ; Stephen > > Hemminger ; wei@kernel.org; Wei Hu > > ; Dexuan > > Cui ;

Re: [PATCH 1/1] video: hyperv_fb: Fix validation of screen resolution

2022-01-24 Thread Wei Liu
On Mon, Jan 24, 2022 at 02:48:57PM +0100, Helge Deller wrote: > On 1/24/22 14:31, Wei Liu wrote: [...] > >> > >> Linus hasn't pulled my tree yet, and he will probably not before the > >> next merge window. So, if this is an urgent bugfix for you, I can offer >

Re: [PATCH 1/1] video: hyperv_fb: Fix validation of screen resolution

2022-01-24 Thread Wei Liu
On Mon, Jan 24, 2022 at 10:52:22AM +0100, Helge Deller wrote: > On 1/23/22 23:30, Wei Liu wrote: > > On Sun, Jan 23, 2022 at 10:27:56PM +, Michael Kelley (LINUX) wrote: > >> From: Wei Liu Sent: Sunday, January 23, 2022 1:56 PM > >>> > >>> On Sun,

Re: [PATCH v2] drm/hyperv: Added error message for fb size greater then allocated

2022-04-07 Thread Wei Liu
On Wed, Apr 06, 2022 at 11:27:07PM -0700, Saurabh Sengar wrote: > Added error message when the size of requested framebuffer is more then > the allocated size by vmbus mmio region for framebuffer > > Signed-off-by: Saurabh Sengar > --- > v1 -> v2 : Corrected Sign-off > >

Re: [PATCH 14/15] hyper-v/azure: Remove now superfluous sentinel element from ctl_table array

2023-09-28 Thread Wei Liu
Please change the prefix to "Drivers: hv:" in the subject line in the two patches. On Thu, Sep 28, 2023 at 03:21:39PM +0200, Joel Granados via B4 Relay wrote: > From: Joel Granados > > This commit comes at the tail end of a greater effort to remove the > empty elements at the end of the

Re: [PATCH] drm/hyperv : Removing the restruction of VRAM allocation with PCI bar size

2022-05-20 Thread Wei Liu
On Fri, May 20, 2022 at 12:20:40AM -0700, Saurabh Sengar wrote: > There were two different approaches getting used in this driver to > allocate vram: > 1. VRAM allocation from PCI region for Gen1 > 2. VRAM alloaction from MMIO region for Gen2 > First approach limilts the vram to PCI

Re: [PATCH v2] drm/hyperv : Removing the restruction of VRAM allocation with PCI bar size

2022-07-11 Thread Wei Liu
On Sat, May 21, 2022 at 07:23:39AM -0700, Saurabh Sengar wrote: > There were two different approaches getting used in this driver to > allocate vram: > 1. VRAM allocation from PCI region for Gen1 > 2. VRAM alloaction from MMIO region for Gen2 > First approach limilts the vram to PCI

Re: [PATCH] video: hyperv_fb: Allow resolutions with size > 64 MB for Gen1

2022-04-28 Thread Wei Liu
On Wed, Apr 27, 2022 at 06:47:53AM -0700, Saurabh Sengar wrote: > This patch fixes a bug where GEN1 VMs doesn't allow resolutions greater > than 64 MB size (eg 7680x4320). Unnecessary PCI check limits Gen1 VRAM > to legacy PCI BAR size only (ie 64MB). Thus any, resolution requesting > greater then

Re: [PATCH 0/4] Remove support for Hyper-V 2008 and 2008R2/Win7

2022-05-03 Thread Wei Liu
On Mon, May 02, 2022 at 09:36:27AM -0700, Michael Kelley wrote: > Linux code for running as a Hyper-V guest includes special cases for the > first released versions of Hyper-V: 2008 and 2008R2/Windows 7. These > versions were very thinly used for running Linux guests when first > released more

Re: [PATCH v4] drm/hyperv: Add error message for fb size greater than allocated

2022-05-03 Thread Wei Liu
On Tue, May 03, 2022 at 07:50:16AM -0700, Saurabh Singh Sengar wrote: > On Tue, Apr 12, 2022 at 05:06:07AM +, Dexuan Cui wrote: > > > From: Saurabh Sengar > > > Sent: Monday, April 11, 2022 9:29 PM > > > ... > > > Add error message when the size of requested framebuffer is more than > > >

Re: [PATCH 0/4] Remove support for Hyper-V 2008 and 2008R2/Win7

2022-05-11 Thread Wei Liu
On Mon, May 02, 2022 at 09:36:27AM -0700, Michael Kelley wrote: > Linux code for running as a Hyper-V guest includes special cases for the > first released versions of Hyper-V: 2008 and 2008R2/Windows 7. These > versions were very thinly used for running Linux guests when first > released more

Re: [PATCH 0/4] Remove support for Hyper-V 2008 and 2008R2/Win7

2022-05-09 Thread Wei Liu
On Sun, May 08, 2022 at 03:43:26PM +, Michael Kelley (LINUX) wrote: > From: Pavel Machek Sent: Wednesday, May 4, 2022 10:23 AM > > > > Hi! > > > > > Linux code for running as a Hyper-V guest includes special cases for the > > > first released versions of Hyper-V: 2008 and 2008R2/Windows 7.

Re: [PATCH v3 0/3] Drivers: hv: Avoid allocating MMIO from framebuffer region for other passed through PCI devices

2022-09-05 Thread Wei Liu
On Sat, Aug 27, 2022 at 03:03:42PM +0200, Vitaly Kuznetsov wrote: [...] > Changes since v2re (PATCH3). > > Vitaly Kuznetsov (3): > PCI: Move PCI_VENDOR_ID_MICROSOFT/PCI_DEVICE_ID_HYPERV_VIDEO > definitions to pci_ids.h > Drivers: hv: Always reserve framebuffer region for Gen1 VMs >

Re: [PATCH v3 1/3] PCI: Move PCI_VENDOR_ID_MICROSOFT/PCI_DEVICE_ID_HYPERV_VIDEO definitions to pci_ids.h

2022-09-05 Thread Wei Liu
On Tue, Aug 30, 2022 at 09:31:54AM +0200, Vitaly Kuznetsov wrote: > Bjorn Helgaas writes: > > > On Sat, Aug 27, 2022 at 03:03:43PM +0200, Vitaly Kuznetsov wrote: > >> There are already three places in kernel which define > >> PCI_VENDOR_ID_MICROSOFT > >> and two for PCI_DEVICE_ID_HYPERV_VIDEO

Re: [PATCH] drm/hyperv: Don't overwrite dirt_needed value set by host

2022-09-23 Thread Wei Liu
On Mon, Sep 12, 2022 at 08:32:46AM -0700, Saurabh Sengar wrote: > Existing code is causing a race condition where dirt_needed value is > already set by the host and gets overwritten with default value. Remove > this default setting of dirt_needed, to avoid overwriting the value > received in the

Re: [PATCH] drm/hyperv: Add ratelimit on error message

2022-09-29 Thread Wei Liu
On Sun, Sep 11, 2022 at 09:11:42AM -0700, Saurabh Singh Sengar wrote: > On Sat, Sep 10, 2022 at 08:06:05PM +0200, Thomas Zimmermann wrote: > > Hi > > > > Am 09.09.22 um 17:09 schrieb Saurabh Sengar: > > >Due to a full ring buffer, the driver may be unable to send updates to > > >the Hyper-V host.

Re: [PATCH] drm/hyperv: Fix an error handling path in hyperv_vmbus_probe()

2022-08-15 Thread Wei Liu
On Fri, Aug 05, 2022 at 06:35:01PM +, Michael Kelley (LINUX) wrote: > From: Christophe JAILLET Sent: Sunday, July > 31, 2022 1:02 PM > > > > hyperv_setup_vram() calls vmbus_allocate_mmio(). > > This must be undone in the error handling path of the probe, as already > > done in the remove

Re: [PATCH] Replace ioremap_cache() with memremap()

2023-11-12 Thread Wei Liu
On Wed, Nov 01, 2023 at 09:01:48AM -0700, Nischala Yelchuri wrote: > Current Hyper-V code for CoCo VMs uses ioremap_cache() to map normal memory > as decrypted. > ioremap_cache() is ideally used to map I/O device memory when it has the > characteristics > of normal memory. It should not be used

Re: [PATCH 1/1] fbdev/hyperv_fb: Fix logic error for Gen2 VMs in hvfb_getmem()

2024-03-01 Thread Wei Liu
On Fri, Feb 09, 2024 at 04:53:37PM +0100, Helge Deller wrote: > On 2/9/24 16:23, Michael Kelley wrote: > > From: Thomas Zimmermann Sent: Thursday, February 1, > > 2024 12:17 AM [...] > > > > Wei Liu and Helge Deller -- > > > > Should this fix go thr