[PATCH 1/2] drm/omap: hdmi4: fix reference leak in hdmi_runtime_get

2020-11-06 Thread Zhang Qilong
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to pm_runtime_put_noidle will result in reference leak in hdmi_runtime_get, so we should fix it. Fixes: ac7674567c620 ("drm: omapdrm: hdmi4: Allocate the omap_hdmi data structure dynamically") Signed-off

[PATCH 0/2] drm/omap: hdmi: fix reference leak in error handling

2020-11-06 Thread Zhang Qilong
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to pm_runtime_put_noidle will result in reference leak. This two patches try to fix them in hdmi_runtime_get. Zhang Qilong (2): drm/omap: hdmi4: fix reference leak in hdmi_runtime_get drm/omap: hdmi5: fix reference

[PATCH 2/2] drm/omap: hdmi5: fix reference leak in hdmi_runtime_get

2020-11-06 Thread Zhang Qilong
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to pm_runtime_put_noidle will result in reference leak in hdmi_runtime_get, so we should fix it. Fixes: c44991ce21bef ("drm: omapdrm: hdmi5: Allocate the omap_hdmi data structure dynamically") Signed-off

[PATCH 1/2] drm: omapdrm: dsi: fix-reference-leak-in dsi_runtime_get.

2020-11-08 Thread Zhang Qilong
ned-off-by: Zhang Qilong --- drivers/gpu/drm/omapdrm/dss/dsi.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c index eeccf40bae41..f407d9c60ada 100644 --- a/drivers/gpu/drm/omapdrm/dss/dsi.c +++ b/d

[PATCH 2/2] drm: omapdrm: dss: fix reference leak in dss_runtime_get

2020-11-08 Thread Zhang Qilong
ned-off-by: Zhang Qilong --- drivers/gpu/drm/omapdrm/dss/dss.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c b/drivers/gpu/drm/omapdrm/dss/dss.c index 6ccbc29c4ce4..9571f3db6f71 100644 --- a/drivers/gpu/drm/omapdrm/dss/dss.c +++ b/d

[PATCH 0/2] drm: omapdrm: fix reference leak in runtime get ops

2020-11-08 Thread Zhang Qilong
reference leak in Moreover, this device cannot enter the idle state and always stay busy or other non-idle state later. So we should fix it through adding pm_runtime_put_noidle. Zhang Qilong (2): drm: omapdrm: dsi: fix-reference-leak-in dsi_runtime_get. drm: omapdrm: dss: fix reference leak in

[PATCH 4/4] drm/omap: hdmi5: fix reference leak in hdmi_runtime_get

2020-11-10 Thread Zhang Qilong
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to pm_runtime_put_noidle will result in reference leak in hdmi_runtime_get, so we should fix it. Fixes: c44991ce21bef ("drm: omapdrm: hdmi5: Allocate the omap_hdmi data structure dynamically") Signed-off

[PATCH 1/4] drm: omapdrm: dsi: fix-reference-leak-in dsi_runtime_get.

2020-11-10 Thread Zhang Qilong
ned-off-by: Zhang Qilong --- drivers/gpu/drm/omapdrm/dss/dsi.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c index eeccf40bae41..f407d9c60ada 100644 --- a/drivers/gpu/drm/omapdrm/dss/dsi.c +++ b/d

[PATCH 2/4] drm: omapdrm: dss: fix reference leak in dss_runtime_get

2020-11-10 Thread Zhang Qilong
ned-off-by: Zhang Qilong --- drivers/gpu/drm/omapdrm/dss/dss.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c b/drivers/gpu/drm/omapdrm/dss/dss.c index 6ccbc29c4ce4..9571f3db6f71 100644 --- a/drivers/gpu/drm/omapdrm/dss/dss.c +++ b/d

[PATCH 0/4] drm/omap: fix reference leak in runtime get ops

2020-11-10 Thread Zhang Qilong
This series of patches fixed several usage counter leaks refer to pm_runtime_get_sync. Many callers forget to call pm_runtime_put_noidle when pm_runtime_get_sync failed, and we fixed it. Zhang Qilong (4): drm: omapdrm: dsi: fix-reference-leak-in dsi_runtime_get. drm: omapdrm: dss: fix

[PATCH 3/4] drm/omap: hdmi4: fix reference leak in hdmi_runtime_get

2020-11-10 Thread Zhang Qilong
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to pm_runtime_put_noidle will result in reference leak in hdmi_runtime_get, so we should fix it. Fixes: ac7674567c620 ("drm: omapdrm: hdmi4: Allocate the omap_hdmi data structure dynamically") Signed-off

[PATCH -next 0/2] fix PM usage counter unbalance

2022-09-22 Thread Zhang Qilong
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. We fix it by replacing it with the newest pm_runtime_resume_and_get to keep usage counter balanced. Zhang Qilong (2): drm/rockchip: vop: fix PM usage counter

[PATCH -next 2/2] drm/rockchip: fix PM usage counter unbalance in poweron

2022-09-22 Thread Zhang Qilong
kchip Soc LVDS") Fixes:cca1705c3d895 ("drm/rockchip: lvds: Add PX30 support") Signed-off-by: Zhang Qilong --- drivers/gpu/drm/rockchip/rockchip_lvds.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c b/driv

[PATCH -next 1/2] drm/rockchip: vop: fix PM usage counter unbalance in vop ops

2022-09-22 Thread Zhang Qilong
omain before vop_initial") Fixes:604be85547ce4 ("drm/rockchip: Add VOP2 driver") Signed-off-by: Zhang Qilong --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/driv

[PATCH -next] drm: omapdrm: dss: using pm_runtime_resume_and_get instead of pm_runtime_get_sync

2022-09-23 Thread Zhang Qilong
Using the newest pm_runtime_resume_and_get is more appropriate for simplifing code here. Signed-off-by: Zhang Qilong --- drivers/gpu/drm/omapdrm/dss/dispc.c | 6 ++ drivers/gpu/drm/omapdrm/dss/dsi.c | 6 ++ drivers/gpu/drm/omapdrm/dss/dss.c | 6 ++ drivers/gpu/drm/omapdrm/dss

[PATCH -next] drm/amdgpu: Discard unnecessary breaks

2020-10-26 Thread Zhang Qilong
The 'break' is unnecessary because of previous 'return', discard it. Signed-off-by: Zhang Qilong --- drivers/gpu/drm/amd/amdgpu/atombios_encoders.c | 6 -- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 4 drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 7

[PATCH -next] drm/nouveau/nvkm: discard unnecessary breaks

2020-10-29 Thread Zhang Qilong
The 'break' is not necessary and reachable because of previous 'return', and we could discard it for better view. Signed-off-by: Zhang Qilong --- drivers/gpu/drm/nouveau/nvkm/subdev/bios/pll.c | 1 - drivers/gpu/drm/nouveau/nvkm/subdev/clk/mcp77.c | 2 -- 2 files changed,