Hi Sean,
On 03/22/2017 03:55 AM, Sean Paul wrote:
On Tue, Mar 21, 2017 at 02:42:11PM +0800, Jeffy Chen wrote:
Currently we are adding all components from the dts, if one of their
drivers been disabled, we would not be able to bring up others.
Refactor component match logic, follow exynos drm
Hi Arnd,
Tested-by: Jeffy Chen <jeffy.c...@rock-chips.com>
Thanx for fixing this :)
On 03/29/2017 12:37 AM, Guenter Roeck wrote:
On Tue, Mar 28, 2017 at 3:16 AM, Arnd Bergmann <a...@arndb.de> wrote:
A bug that I had fixed earlier just came back, with CONFIG_EXTCON=m,
the rockchi
Hi Heiko,
On 03/16/2017 01:00 AM, Heiko Stuebner wrote:
Am Mittwoch, 15. März 2017, 18:20:47 CET schrieb Jeffy Chen:
Currently we are adding all components from the dts, if one of their
drivers been disabled, we would not be able to bring up others.
Refactor component match logic, follow
Hi Andrzej,
On 03/14/2017 08:05 PM, Andrzej Hajda wrote:
Hi Jeffy,
On 14.03.2017 11:45, Jeffy Chen wrote:
Currently we are adding all components from the dts, if one of their
drivers been disabled, we would not be able to bring up others.
Refactor component match logic, follow exynos drm
Hi Sean,
On 03/14/2017 05:06 AM, Sean Paul wrote:
On Wed, Mar 08, 2017 at 01:58:14PM +0800, Jeffy Chen wrote:
Currently we are adding all components from the dts, if one of their
drivers been disabled, we would not be able to bring up others.
Refactor component match logic, follow exynos drm
Hi Heiko,
On 03/16/2017 04:20 PM, Heiko Stuebner wrote:
Hi Jeffy,
Am Donnerstag, 16. März 2017, 10:05:56 CET schrieb Jeffy Chen:
Currently we are adding all components from the dts, if one of their
drivers been disabled, we would not be able to bring up others.
Refactor component match logic
Hi Sean,
On 04/11/2017 03:26 AM, Sean Paul wrote:
On Mon, Apr 10, 2017 at 06:00:43PM +0800, Jeffy Chen wrote:
Hi Jeffy,
Thanks for sending this up again.
Verified on rk3399 chromebook kevin, no more crashes during unbind/bind drm.
I'm assuming this is on the chromeos-4.4 kernel? If so
Hi Sean,
On 04/11/2017 04:31 AM, Sean Paul wrote:
On Mon, Apr 10, 2017 at 06:00:45PM +0800, Jeffy Chen wrote:
After unbinding drm, the user space may still owns the drm dev fd,
and may trigger fb release after cleanup mode config.
Add a sanity check to prevent that.
Signed-off-by: Jeffy Chen
Hi Sean,
On 04/05/2017 03:42 AM, Sean Paul wrote:
On Sat, Apr 01, 2017 at 07:35:25PM +0800, Jeffy Chen wrote:
Hi Jeffy,
Could you please add commit messages describing *why* you're making the change?
It might be obvious to you (and maybe me), but others will benefit from better
descriptions
Hi Sean,
On 04/05/2017 03:44 AM, Sean Paul wrote:
On Sat, Apr 01, 2017 at 07:35:26PM +0800, Jeffy Chen wrote:
We should not cleanup iommu before cleanup other resources.
Reorder unload sequence, follow exynos drm.
This doesn't match the cleanup sequence in rockchip_drm_bind. Also make sure
Hi Daniel,
On 04/03/2017 03:41 PM, Daniel Vetter wrote:
On Sat, Apr 01, 2017 at 07:35:28PM +0800, Jeffy Chen wrote:
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v2: None
Wut? How is this even possible? If you haven't registered the driver yet,
there's
Hi Daniel,
On 04/03/2017 03:58 PM, Daniel Vetter wrote:
On Sat, Apr 1, 2017 at 1:35 PM, Jeffy Chen <jeffy.c...@rock-chips.com> wrote:
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
index a5d83cb..5dbf011 100644
--- a/drivers/g
Hi Daniel,
On 04/12/2017 02:33 PM, Daniel Vetter wrote:
On Tue, Apr 11, 2017 at 11:31:41AM +0800, Jeffy Chen wrote:
After unbinding drm, the user space may still owns the drm dev fd,
and may still be able to call drm ioctl.
We're using an unplugged state to prevent something like that, so
Hi Daniel,
On 04/12/2017 02:36 PM, Daniel Vetter wrote:
On Tue, Apr 11, 2017 at 11:31:42AM +0800, Jeffy Chen wrote:
We are freeing all framebuffers in drm_mode_config_cleanup without
sync the drm_file's fbs list.
So if someone try to unbind drm before release drm dev fd, the fbs
list would
Hi Daniel,
missed some questions...
On 04/12/2017 04:17 PM, jeffy wrote:
Hi Daniel,
On 04/12/2017 02:33 PM, Daniel Vetter wrote:
On Tue, Apr 11, 2017 at 11:31:41AM +0800, Jeffy Chen wrote:
After unbinding drm, the user space may still owns the drm dev fd,
and may still be able to call drm
Hi Sean,
On 04/12/2017 11:03 PM, Sean Paul wrote:
On Wed, Apr 12, 2017 at 04:56:21PM +0800, Jeffy Chen wrote:
After unbinding drm, the user space may still owns the drm dev fd, and
may still be able to call drm ioctl.
We're using an unplugged state to prevent something like that, so let's
Hi Andrzej,
On 04/06/2017 03:19 PM, Andrzej Hajda wrote:
On 05.04.2017 10:29, Jeffy Chen wrote:
Normally we do this in drm_mode_config_cleanup. But analogix dp's
connector is allocated in bind, and freed after unbind. So we need
to destroy it in unbind to avoid further access.
Signed-off
Hi Andrzej,
On 04/06/2017 03:11 PM, Andrzej Hajda wrote:
On 05.04.2017 10:29, Jeffy Chen wrote:
The dp aux is registered when binding analogix dp.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
Reviewed-by: Andrzej Hajda <a.ha...@samsung.com>
Btw, if you are wor
Hi Sean,
On 04/06/2017 08:26 PM, Sean Paul wrote:
On Thu, Apr 06, 2017 at 10:47:59AM +0800, jeffy wrote:
Hi Sean,
On 04/06/2017 12:28 AM, Sean Paul wrote:
On Wed, Apr 05, 2017 at 04:29:26PM +0800, Jeffy Chen wrote:
After unbinding drm, the userspace may still has a chance to access
gem buf
Hi Sean,
On 04/06/2017 12:28 AM, Sean Paul wrote:
On Wed, Apr 05, 2017 at 04:29:26PM +0800, Jeffy Chen wrote:
After unbinding drm, the userspace may still has a chance to access
gem buf.
Add a sanity check for a NULL dev_private to prevent that from
happening.
I still don't understand how
Hi Daniel,
On 04/06/2017 04:26 PM, Daniel Vetter wrote:
On Wed, Apr 05, 2017 at 12:28:40PM -0400, Sean Paul wrote:
On Wed, Apr 05, 2017 at 04:29:26PM +0800, Jeffy Chen wrote:
After unbinding drm, the userspace may still has a chance to access
gem buf.
Add a sanity check for a NULL
Hi Daniel,
On 04/07/2017 02:30 PM, Daniel Vetter wrote:
On Thu, Apr 6, 2017 at 1:09 PM, jeffy <jeffy.c...@rock-chips.com> wrote:
On 04/06/2017 04:26 PM, Daniel Vetter wrote:
On Wed, Apr 05, 2017 at 12:28:40PM -0400, Sean Paul wrote:
On Wed, Apr 05, 2017 at 04:29:26PM +0800, Jeff
Hi Daniel,
On 04/07/2017 03:16 PM, Daniel Vetter wrote:
On Thu, Apr 06, 2017 at 08:31:25PM +0800, Jeffy Chen wrote:
After unbinding drm, the user space may still owns the drm dev fd,
and may still be able to call drm ioctl.
Add a sanity check here to prevent that from happening.
Signed-off
alloc(version->desc_len + 1);
...
if (version->name_len) version->name[version->name_len] = '\0';
<-- crashed here, since the name_len would always be zero, so
version->name would be nullptr.
On 07/12/2017 02:18 PM, Jeffy Chen wrote:
DRM_IOCTL_VERSION is supposed to update the name
for difference chips.
To make it clean, initialize registers directly, and drops
init_table mechanism out.
Signed-off-by: Mark Yao<mark@rock-chips.com>
Tested-by: Heiko Stuebner<he...@sntech.de>
Reviewed-by: Jeffy Chen <jeffy.c...
is the details for this register
VOP_WIN0_CTRL2
bit[7:4] win_rid_win0_cbr
axi read id of win0 cbr channel
bit[3:0] win_rid_win0_yrgb
axi read id of win0 yrgb channel
Signed-off-by: Mark Yao<mark@rock-chips.com>
Reviewed-by: Jeffy Chen <jeffy.c...@rock-
method that is
inefficient, hardcode the write_relaxed flags to vop registers,
then can only do synchronize write for those actual needed register.
Signed-off-by: Mark Yao<mark@rock-chips.com>
Tested-by: Heiko Stuebner<he...@sntech.de>
Reviewed-by: Jeffy Chen <jeffy.c...
: on same structure, newer design vop will bigger
then old one.
Signed-off-by: Mark Yao<mark@rock-chips.com>
Reviewed-by: Jeffy Chen <jeffy.c...@rock-chips.com>
___
dri-devel mailing list
dri-devel@lists.freedeskt
Hi mark,
On 07/26/2017 02:19 PM, Mark yao wrote:
Grouping the vop registers facilitates make register
definition clearer, and also is useful for different vop
reuse the same group register.
Signed-off-by: Mark Yao<mark@rock-chips.com>
Reviewed-by: Jeffy Chen <jeffy.c...@rock-
Hi Sean,
On 04/28/2017 11:03 PM, Sean Paul wrote:
On Fri, Apr 28, 2017 at 03:37:47PM +0800, Jeffy Chen wrote:
We need to set vop config done after update line flag config, it's a
new requirement for chips newer than rk3368.
Since we would only use line flag irq for vact_end, let's move
Hi Thierry,
i hit a compile error with this patch:
CC drivers/gpu/drm/tegra/trace.o
In file included from drivers/gpu/drm/tegra/trace.h:68:0,
from drivers/gpu/drm/tegra/trace.c:2:
./include/trace/define_trace.h:88:43: fatal error: ./trace.h: No such
file or directory
Hi sean,
On 05/25/2017 11:30 PM, Sean Paul wrote:
On Tue, May 23, 2017 at 02:39:43PM +0800, Jeffy Chen wrote:
The system would crash when trying to alloc zero sized gem buffer:
[6.712435] Unable to handle kernel NULL pointer dereference at virtual address
0010 <--ZERO_SIZE_
Hi Mark,
Reviewed-by: Jeffy Chen <jeffy.c...@rock-chips.com>
On 05/27/2017 07:43 PM, yao mark wrote:
Force vop output mode on encoder driver seem not a good idea,
EDP, HDMI, DisplayPort all have 10bit input on rk3399,
On non-10bit vop, vop 8bit output bit[0-7] connect to the
encoder hig
Hi Hans,
thanx for investigating :)
On 05/30/2017 03:06 PM, Hans de Goede wrote:
Hi,
On 29-05-17 22:25, Chris Wilson wrote:
On Fri, Apr 14, 2017 at 11:15:04AM -0400, Sean Paul wrote:
On Thu, Apr 13, 2017 at 03:32:44PM +0800, Jeffy Chen wrote:
After unbinding drm, the user space may still
Hi Brian,
On 10/17/2017 07:57 AM, Brian Norris wrote:
This is going to be a*lot* of churn throughout the tree, if we expect
all resource consumers to do this. I think we'd want some kind of
agreement from the PM maintainers and (larger) subsystem owners before
going down this route...
And in
Hi Sean,
On 09/28/2017 04:27 AM, Sean Paul wrote:
>@@ -299,6 +300,7 @@ static int rockchip_drm_sys_resume(struct device *dev)
>
>priv = drm->dev_private;
>drm_atomic_helper_resume(drm, priv->state);
>+ drm_atomic_state_put(priv->state);
Won't this be freed for you eventually in
Hi Sean,
On 09/28/2017 11:16 AM, jeffy wrote:
Hi Sean,
On 09/28/2017 04:27 AM, Sean Paul wrote:
>@@ -299,6 +300,7 @@ static int rockchip_drm_sys_resume(struct device
*dev)
>
> priv = drm->dev_private;
> drm_atomic_helper_resume(drm, priv->state);
>+drm_
Hi Sean,
Thanks for your review.
On 10/18/2017 02:10 AM, Sean Paul wrote:
On Tue, Oct 17, 2017 at 06:16:20PM +0800, Jeffy Chen wrote:
>Add missing clk_disable_unprepare() in bind()'s error handling path.
This also isn't disabled in unbind(), is that intentional?
i wasn't able to
‘ret’ [-Wunused-variable]
int ret;
^~~
sorry, i thought i fixed that, but it looks like i amended it to the
wrong commit by mistake...
Fixes: 102712a32ff5 ("drm/rockchip: analogix_dp: Remove unnecessary init
code")
Cc: Jeffy Chen <jeffy.c...@rock-chips.com>
Cc
Hi Sean,
On 10/21/2017 12:52 AM, Sean Paul wrote:
On Thu, Oct 19, 2017 at 11:48:05AM +0800, Jeffy Chen wrote:
This patch has somehow lost it's original author. I assume this is not
intentional.
oops, sorry, guess i used some wrongly command during the rebasing...
will fix
Currently we are adding all components from the dts, if one of their
drivers been disabled, we would not be able to bring up others.
Refactor component match logic, follow exynos drm.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
Reviewed-by: Andrzej Hajda <a.ha...@samsung.c
Currently we are adding all components from the dts, if one of their
drivers been disabled, we would not be able to bring up others.
Refactor component match logic, follow exynos drm.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
Reviewed-by: Andrzej Hajda <a.ha...@samsung.c
Currently we are adding all components from the dts, if one of their
drivers been disabled, we would not be able to bring up others.
Refactor component match logic, follow exynos drm.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
Reviewed-by: Andrzej Hajda <a.ha...@sa
Currently we are adding all components from the dts, if one of their
drivers been disabled, we would not be able to bring up others.
Refactor component match logic, follow exynos drm.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
Reviewed-by: Andrzej Hajda <a.ha...@samsung.c
Currently we are adding all components from the dts, if one of their
drivers been disabled, we would not be able to bring up others.
Refactor component match logic, follow exynos drm.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
Reviewed-by: Andrzej Hajda <a.ha...@sa
Currently we are adding all components from the dts, if one of their
drivers been disabled, we would not be able to bring up others.
Refactor component match logic, follow exynos drm.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
drivers/gpu/drm/rockchip/K
Normally we do this in drm_mode_config_cleanup. But analogix dp's
connector is allocated when binding, and would be freed after unbind.
So we need to destroy it when unbinding, to avoid further access.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
drivers/gpu/drm/bridge/an
In current sound framework, there's no way to unbind dai link after
unregister codec.
So don't unregister the codec when unbinding for now.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
drivers/gpu/drm/rockchip/cdn-dp-core.c | 6 +++---
1 file changed, 3 insertions(+), 3 del
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v2: None
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
index a5d83cb..5dbf011
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 31 +++--
1 file changed, 21 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
b/drivers/gpu/drm/rockchip/rockchip_drm
The dp aux is registered when binding analogix dp.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v2: None
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
b/d
Verified on rk3399 chromebook kevin, no more crashes during unbind/bind drm.
Changes in v6:
Address Daniel Vetter <dan...@ffwll.ch>'s comments.
Changes in v5:
Fix wrong git account.
Changes in v2:
Fix some commit messages.
Jeffy Chen (2):
drm: Unplug drm device when unregistering it
After unbinding drm, the user space may still owns the drm dev fd,
and may still be able to call drm ioctl.
We're using an unplugged state to prevent something like that, so
let's reuse it here.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v6:
Address Daniel Vette
After unbinding drm, the user space may still owns the drm dev fd,
and may trigger fb release after cleanup mode config.
Add a sanity check to prevent that.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v6: None
Changes in v5: None
Changes in v2: None
drivers/g
After unbinding drm, the user space may still owns the drm dev fd,
and may still be able to call drm ioctl.
We're using an unplugged state to prevent something like that, so
let's reuse it here.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
Reviewed-by: Sean Paul <seanp...@chr
directly.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
drivers/gpu/drm/drm_drv.c | 15 +--
include/drm/drm_drv.h | 1 -
2 files changed, 1 insertion(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
index ad13e20..cc2d018
ix wrong git account.
Changes in v2:
Fix some commit messages.
Jeffy Chen (2):
drm: Unplug drm device when unregistering it
drm: Prevent release fb after cleanup drm_mode_config
drivers/gpu/drm/drm_drv.c | 8
drivers/gpu/drm/drm_framebuffer.c | 5 +
drivers/gpu/drm/udl/udl_d
that.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v7:
Update commit message.
Changes in v6: None
Changes in v5: None
Changes in v2: None
drivers/gpu/drm/drm_framebuffer.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/drm_framebuffer.c
b/d
The dp aux is registered when binding analogix dp.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v3: None
Changes in v2: None
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/bridge/an
After unbinding drm, the userspace may still has a chance to access
gem buf.
Add a sanity check for a NULL dev_private to prevent that from
happening.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v3:
Address Daniel Vetter <dan...@ffwll.ch>'s comments.
U
<dan...@ffwll.ch>'s comments.
Update commit message.
Address Daniel Vetter <dan...@ffwll.ch>'s comments.
Update commit message.
Update commit message.
Changes in v2:
Fix some commit messages.
Jeffy Chen (9):
drm: bridge: analogix: Detach panel when unbinding analogix dp
drm: bri
The panel is attached when binding analogix dp.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v3: None
Changes in v2:
Fix some commit messages.
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/
Current drm bind/unbind sequence would cause some memory issues.
For example we should not cleanup iommu before cleanup mode config.
Reorder bind/unbind sequence, follow exynos drm.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v3:
Address Sean Paul <seanp...@chr
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v3:
Address Daniel Vetter <dan...@ffwll.ch>'s comments.
Update commit message.
Changes in v2: None
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/
After snd_soc_unregister_codec, the dai link would remain bound to
the invalid codec. That would cause crashes after unbind dp driver.
Let's unregister audio codec when removing dp driver to prevent that.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v3:
Update
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v3: None
Changes in v2: None
drivers/gpu/drm/rockchip/cdn-dp-core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c
b/drivers/gpu/drm/rockchip/cdn-dp-core.c
to the end of vop_bind for eaiser error handling.
2/ correct the err_put_pm_runtime of vop_enable.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v3:
Address Sean Paul <seanp...@chromium.org>'s comments.
Update commit message.
Changes in v2: None
drivers/gpu/
Normally we do this in drm_mode_config_cleanup. But analogix dp's
connector is allocated in bind, and freed after unbind. So we need
to destroy it in unbind to avoid further access.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v3: None
Changes in v2: None
drive
After unbinding drm, the user space may still owns the drm dev fd, and
may still be able to call drm ioctl.
We're using an unplugged state to prevent something like that, so let's
reuse it here.
Also drop drm_unplug_dev, because it would be unused after other changes.
Signed-off-by: Jeffy Chen
that.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v8: None
Changes in v7:
Update commit message.
Changes in v6: None
Changes in v5: None
Changes in v2: None
drivers/gpu/drm/drm_framebuffer.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/g
essage.
Changes in v6:
Address Daniel Vetter <dan...@ffwll.ch>'s comments.
Changes in v5:
Fix wrong git account.
Changes in v2:
Fix some commit messages.
Jeffy Chen (2):
drm: Unplug drm device when unregistering it
drm: Prevent release fb after cleanup drm_mode_config
drivers/gpu/d
drm_device_set_plug_state helper.
Changes in v6:
Reuse unplug status.
Changes in v5:
Fix wrong git account.
Changes in v2:
Fix some commit messages.
Jeffy Chen (1):
drm: Unplug drm device when unregistering it
drivers/gpu/drm/drm_drv.c | 26 ++
drivers/gpu/drm/udl/udl_drv.c
After unbinding drm, the user space may still owns the drm dev fd, and
may still be able to call drm ioctl.
We're using an unplugged state to prevent something like that, so let's
reuse it here.
Also drop drm_unplug_dev, because it would be unused after other changes.
Signed-off-by: Jeffy Chen
into drm_drv.
v7: Add missing drm_dev_unref in udl_drv.
v8: Fix compiler errors after enable udl.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
drivers/gpu/drm/drm_drv.c | 26 ++
drivers/gpu/drm/udl/udl_drv.c | 3 ++-
include/drm/drmP.h
Currently we are adding all components from the dts, if one of their
drivers been disabled, we would not be able to bring up others.
Refactor component match logic, follow exynos drm.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
drivers/gpu/drm/rockchip/K
Verified on rk3399 chromebook kevin:
1/ stop ui && pkill -9 frecon
2/ unbind/bind drm
Changes in v2:
Fix some commit messages.
Jeffy Chen (9):
drm: bridge: analogix: Detach panel when unbinding analogix dp
drm: bridge: analogix: Unregister dp aux when unbinding
drm: bridge:
Normally we do this in drm_mode_config_cleanup. But analogix dp's
connector is allocated in bind, and freed after unbind. So we need
to destroy it in unbind to avoid further access.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v2: None
drivers/gpu/drm/bridge/an
The dp aux is registered when binding analogix dp.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
b/drivers/gpu/drm/
In current sound framework, there's no way to unbind dai link after
unregister codec.
So move unregister codec to driver remove for now.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v2: None
drivers/gpu/drm/rockchip/cdn-dp-core.c | 6 +++---
1 file chan
The panel is attached when binding analogix dp.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v2:
Fix some commit messages.
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/bridge/an
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
index df9e570..19679b2 100644
--- a/d
We should don't cleanup iommu before cleanup other resources.
Reorder unload sequence, follow exynos drm.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drive
We should not cleanup iommu before cleanup other resources.
Reorder unload sequence, follow exynos drm.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v2: None
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v2: None
drivers/gpu/drm/rockchip/cdn-dp-core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c
b/drivers/gpu/drm/rockchip/cdn-dp-core.c
index fd79a70..a
Verified on rk3399 chromebook kevin:
1/ stop ui && pkill -9 frecon
2/ unbind/bind drm
Jeffy Chen (9):
drm: bridge: analogix: Detach panel when unbinding analogix dp
drm: bridge: analogix: Unregister dp aux when unbinding
drm: bridge: analogix: Destroy connector when unbindi
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
drivers/gpu/drm/rockchip/cdn-dp-core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c
b/drivers/gpu/drm/rockchip/cdn-dp-core.c
index fd79a70..a97f3f4 100644
--- a/drive
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v2: None
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
index df9e570..2
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
index a5d83cb..5dbf011 100644
--- a/drivers/g
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v2: None
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 31 +++--
1 file changed, 21 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
b/drivers/gpu/drm/ro
The panel is attached when binding analogix dp.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
b/drivers/gpu/drm/
The dp aux is registered when binding analogix dp.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
Reviewed-by: Andrzej Hajda <a.ha...@samsung.com>
---
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None
drivers/gpu/drm/bridge/analogix/analogix_d
After unbinding drm, the user space may still owns the drm dev fd,
and may still be able to call drm ioctl.
Add a sanity check here to prevent that from happening.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None
drivers/gpu/drm/rockchip/cdn-dp-core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-cor
Current drm bind/unbind sequence would cause some memory issues.
For example we should not cleanup iommu before cleanup mode config.
Reorder bind/unbind sequence, follow exynos drm.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v5: None
Changes in v4: None
Changes
The clock is enabled when binding cdn dp.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
After snd_soc_unregister_codec, the dai link would remain bound to
the invalid codec. That would cause crashes after unbind dp driver.
Let's unregister audio codec when removing dp driver to prevent that.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v5: None
C
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v5: None
Changes in v4: None
Changes in v3:
Address Daniel Vetter <dan...@ffwll.ch>'s comments.
Update commit message.
Changes in v2: None
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 +
1 file changed,
to the end of vop_bind for eaiser error handling.
2/ correct the err_put_pm_runtime of vop_enable.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v5: None
Changes in v4: None
Changes in v3:
Address Sean Paul <seanp...@chromium.org>'s comments.
Update commit message.
C
The clocks are prepared when binding vop.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4
1 file changed, 4 insertions(+)
diff --git a/drive
The clock is enabled when binding analogix dp.
Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
---
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 1 +
1 file changed, 1 insertion(+)
diff
1 - 100 of 157 matches
Mail list logo
