Re: [Freedreno] [PATCH] drm/msm/dpu: ensure device suspend happens during PM sleep

2020-04-01 Thread kalyan_t
On 2020-03-31 00:25, Doug Anderson wrote: Hi, On Mon, Mar 30, 2020 at 2:04 AM Kalyan Thota wrote: "The PM core always increments the runtime usage counter before calling the ->suspend() callback and decrements it after calling the ->resume() callback" DPU and DSI are managed as runtime

Re: [PATCH] drm/msm/dpu: ensure device suspend happens during PM sleep

2020-04-02 Thread kalyan_t
On 2020-03-31 21:30, Doug Anderson wrote: Hi, On Tue, Mar 31, 2020 at 6:58 AM Kalyan Thota wrote: "The PM core always increments the runtime usage counter before calling the ->suspend() callback and decrements it after calling the ->resume() callback" DPU and DSI are managed as runtime

Re: [PATCH] drm/msm/dpu: ensure device suspend happens during PM sleep

2020-03-26 Thread kalyan_t
On 2020-03-25 21:20, Doug Anderson wrote: Hi, On Wed, Mar 25, 2020 at 8:40 AM Rob Clark wrote: On Tue, Mar 24, 2020 at 7:35 AM Doug Anderson wrote: > > Hi, > > On Sun, Mar 22, 2020 at 11:14 PM Kalyan Thota wrote: > > > > "The PM core always increments the runtime usage counter > > before

Re: [Freedreno] [PATCH] drm/msm/dpu: ensure device suspend happens during PM sleep

2020-05-16 Thread kalyan_t
On 2020-05-14 21:47, Doug Anderson wrote: Hi, On Fri, May 1, 2020 at 6:31 AM Kalyan Thota wrote: "The PM core always increments the runtime usage counter before calling the ->suspend() callback and decrements it after calling the ->resume() callback" DPU and DSI are managed as runtime

Re: [Freedreno] [v1] drm/msm/dpu: Fix reservation failures in modeset

2020-08-07 Thread kalyan_t
On 2020-08-05 21:18, Rob Clark wrote: On Wed, Aug 5, 2020 at 6:34 AM Kalyan Thota wrote: In TEST_ONLY commit, rm global_state will duplicate the object and request for new reservations, once they pass then the new state will be swapped with the old and will be available for the Atomic Commit.

Re: [Freedreno] [v1] drm/msm/dpu: update reservations in commit path

2020-08-06 Thread kalyan_t
On 2020-08-05 01:02, Rob Clark wrote: On Tue, Aug 4, 2020 at 4:32 AM Kalyan Thota wrote: DPU resources reserved in the atomic_check path gets unwinded during modeset operation before commit happens in a non seamless transition. Update the reservations in the commit path to avoid resource

Re: [Freedreno] [v1] drm/msm/dpu: Fix reservation failures in modeset

2020-08-10 Thread kalyan_t
On 2020-08-06 22:15, Rob Clark wrote: On Thu, Aug 6, 2020 at 7:46 AM wrote: On 2020-08-05 21:18, Rob Clark wrote: > On Wed, Aug 5, 2020 at 6:34 AM Kalyan Thota > wrote: >> >> In TEST_ONLY commit, rm global_state will duplicate the >> object and request for new reservations, once they pass >>

Re: [Freedreno] [v1] drm/msm/dpu: enumerate second cursor pipe for external interface

2020-07-14 Thread kalyan_t
On 2020-07-10 22:19, Rob Clark wrote: On Thu, Jun 25, 2020 at 5:46 AM Kalyan Thota wrote: Setup an RGB HW pipe as cursor which can be used on secondary interface. For SC7180 2 HW pipes are enumerated as cursors 1 - primary interface 2 - secondary interface Signed-off-by: Kalyan Thota ---

Re: [Freedreno] [v1] drm/msm/dpu: add support for clk and bw scaling for display

2020-07-14 Thread kalyan_t
On 2020-07-10 22:38, Rob Clark wrote: On Thu, Jun 18, 2020 at 7:09 AM Kalyan Thota wrote: This change adds support to scale src clk and bandwidth as per composition requirements. Interconnect registration for bw has been moved to mdp device node from mdss to facilitate the scaling. Changes

Re: [Freedreno] [v1] drm/msm/dpu: add support for clk and bw scaling for display

2020-07-15 Thread kalyan_t
On 2020-07-13 22:50, Rob Clark wrote: On Mon, Jul 13, 2020 at 8:59 AM wrote: On 2020-07-10 22:38, Rob Clark wrote: > On Thu, Jun 18, 2020 at 7:09 AM Kalyan Thota > wrote: >> >> This change adds support to scale src clk and bandwidth as >> per composition requirements. >> >> Interconnect

Re: [v1] drm/msm/dpu: add support for clk and bw scaling for display

2020-07-15 Thread kalyan_t
On 2020-07-14 06:42, Matthias Kaehlcke wrote: On Thu, Jun 18, 2020 at 07:38:41PM +0530, Kalyan Thota wrote: This change adds support to scale src clk and bandwidth as per composition requirements. Interconnect registration for bw has been moved to mdp device node from mdss to facilitate the

Re: [Freedreno] [PATCH] drm/msm/dpu: add support for dither block in display

2020-06-26 Thread kalyan_t
On 2020-06-25 01:55, Rob Clark wrote: On Wed, Jun 24, 2020 at 4:57 AM Kalyan Thota wrote: This change enables dither block for primary interface in display. Enabled for 6bpc in the current version. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 45

Re: [Freedreno] [PATCH] drm/msm/dpu: ensure device suspend happens during PM sleep

2020-06-05 Thread kalyan_t
On 2020-05-28 03:41, Doug Anderson wrote: Hi, On Fri, May 15, 2020 at 9:37 AM Doug Anderson wrote: Hi, On Fri, May 15, 2020 at 5:06 AM wrote: > > On 2020-05-14 21:47, Doug Anderson wrote: > > Hi, > > > > On Fri, May 1, 2020 at 6:31 AM Kalyan Thota > > wrote: > >> > >> "The PM core always

Re: [Freedreno] [PATCH] drm/msm/dpu: fix/enable 6bpc dither with split-lm

2020-07-21 Thread kalyan_t
On 2020-07-16 03:49, Rob Clark wrote: From: Rob Clark If split-lm is used (for ex, on sdm845), we can have multiple ping- pongs, but only a single phys encoder. We need to configure dithering on each of them. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 22

Re: [Freedreno] [PATCH] drm/msm/dpu: fix/enable 6bpc dither with split-lm

2020-07-21 Thread kalyan_t
On 2020-07-20 20:53, Rob Clark wrote: On Mon, Jul 20, 2020 at 5:53 AM wrote: On 2020-07-16 03:49, Rob Clark wrote: > From: Rob Clark > > If split-lm is used (for ex, on sdm845), we can have multiple ping- > pongs, but only a single phys encoder. We need to configure dithering > on each of

Re: [Freedreno] [PATCH 3/3] drm/msm/dpu: add support for clk and bw scaling for display

2020-11-25 Thread kalyan_t
On 2020-11-08 23:25, Amit Pundir wrote: On Tue, 4 Aug 2020 at 21:09, Rob Clark wrote: On Thu, Jul 16, 2020 at 4:36 AM Kalyan Thota wrote: > > This change adds support to scale src clk and bandwidth as > per composition requirements. > > Interconnect registration for bw has been moved to

Re: [Freedreno] [v2] drm/msm/disp/dpu1: turn off vblank irqs aggressively in dpu driver

2021-02-10 Thread kalyan_t
On 2021-02-01 00:46, Rob Clark wrote: On Fri, Dec 18, 2020 at 2:27 AM Kalyan Thota wrote: Set the flag vblank_disable_immediate = true to turn off vblank irqs immediately as soon as drm_vblank_put is requested so that there are no irqs triggered during idle state. This will reduce cpu wakeups

Re: [Freedreno] [v2] drm/msm/disp/dpu1: turn off vblank irqs aggressively in dpu driver

2021-02-11 Thread kalyan_t
On 2021-02-11 01:56, Rob Clark wrote: On Wed, Feb 10, 2021 at 3:41 AM wrote: On 2021-02-01 00:46, Rob Clark wrote: > On Fri, Dec 18, 2020 at 2:27 AM Kalyan Thota > wrote: >> >> Set the flag vblank_disable_immediate = true to turn off vblank irqs >> immediately as soon as drm_vblank_put is

Re: [Freedreno] [v1] drm/msm/disp/dpu1: fix warn stack reported during dpu resume

2021-04-01 Thread kalyan_t
On 2021-04-01 07:37, Dmitry Baryshkov wrote: On 01/04/2021 01:47, Rob Clark wrote: On Wed, Mar 31, 2021 at 9:03 AM Dmitry Baryshkov wrote: On 31/03/2021 14:27, Kalyan Thota wrote: WARN_ON was introduced by the below commit to catch runtime resumes that are getting triggered before icc path

Re: [Freedreno] [v1] drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume

2021-03-31 Thread kalyan_t
On 2021-03-31 00:04, Steev Klimaszewski wrote: On 3/22/21 4:17 AM, Kalyan Thota wrote: From: Kalyan Thota DPU runtime resume will request for a min vote on the AXI bus as it is a necessary step before turning ON the AXI clock. The change does below 1) Move the icc path set before requesting

Re: [Freedreno] [v1] drm/msm/disp/dpu1: fix warn stack reported during dpu resume

2021-04-02 Thread kalyan_t
On 2021-04-01 19:01, Dmitry Baryshkov wrote: On Thu, 1 Apr 2021 at 16:19, wrote: On 2021-04-01 07:37, Dmitry Baryshkov wrote: > On 01/04/2021 01:47, Rob Clark wrote: >> On Wed, Mar 31, 2021 at 9:03 AM Dmitry Baryshkov >> wrote: >>> >>> On 31/03/2021 14:27, Kalyan Thota wrote: WARN_ON

Re: [Freedreno] [v4] drm/msm/disp/dpu1: turn off vblank irqs aggressively in dpu driver

2021-02-23 Thread kalyan_t
On 2021-02-22 21:38, Rob Clark wrote: On Thu, Feb 18, 2021 at 4:36 AM Kalyan Thota wrote: Set the flag vblank_disable_immediate = true to turn off vblank irqs immediately as soon as drm_vblank_put is requested so that there are no irqs triggered during idle state. This will reduce cpu wakeups

Re: [Freedreno] [v2] drm/msm/disp/dpu1: turn off vblank irqs aggressively in dpu driver

2021-02-16 Thread kalyan_t
On 2021-02-12 23:19, Rob Clark wrote: On Thu, Feb 11, 2021 at 7:31 AM wrote: On 2021-02-11 01:56, Rob Clark wrote: > On Wed, Feb 10, 2021 at 3:41 AM wrote: >> >> On 2021-02-01 00:46, Rob Clark wrote: >> > On Fri, Dec 18, 2020 at 2:27 AM Kalyan Thota >> > wrote: >> >> >> >> Set the flag

Re: [Freedreno] [v2] drm/msm/disp/dpu1: add safe lut config in dpu driver

2021-08-03 Thread kalyan_t
On 2021-08-04 01:43, Stephen Boyd wrote: Quoting Kalyan Thota (2021-08-03 03:41:47) Add safe lut configuration for all the targets in dpu driver as per QOS recommendation. Issue reported on SC7280: With wait-for-safe feature in smmu enabled, RT client buffer levels are checked to be safe