Re: [PATCH v12,2/3] drm: mediatek: Set dpi format in mmsys

2022-10-21 Thread xinlei . lee
On Thu, 2022-10-20 at 12:40 -0400, Nícolas F. R. A. Prado wrote: > On Wed, Oct 19, 2022 at 10:52:15AM +0800, xinlei@mediatek.com > wrote: > [..] > > @@ -134,6 +137,7 @@ struct mtk_dpi_yc_limit { > > * @yuv422_en_bit: Enable bit of yuv422. > > * @csc_enable_bit: Enable bit of CSC. > > *

Re: [PATCH v12,1/3] soc: mediatek: Add all settings to mtk_mmsys_ddp_dpi_fmt_config func

2022-10-21 Thread xinlei . lee
On Thu, 2022-10-20 at 12:33 -0400, Nícolas F. R. A. Prado wrote: > Hi, > > On Wed, Oct 19, 2022 at 10:52:14AM +0800, xinlei@mediatek.com > wrote: > > From: Xinlei Lee > > > > The difference between MT8186 and other ICs is that when modifying > > the

Re: [PATCH v12,1/3] soc: mediatek: Add all settings to mtk_mmsys_ddp_dpi_fmt_config func

2022-10-22 Thread xinlei . lee
xinlei@mediatek.com > > > wrote: > > > > From: Xinlei Lee > > > > > > > > The difference between MT8186 and other ICs is that when > > > > modifying > > > > the > > > > output format, we need to modify the mms

Re: [PATCH v12,2/3] drm: mediatek: Set dpi format in mmsys

2022-10-22 Thread xinlei . lee
On Fri, 2022-10-21 at 11:39 -0400, Nícolas F. R. A. Prado wrote: > On Fri, Oct 21, 2022 at 08:18:25PM +0800, xinlei.lee wrote: > > On Thu, 2022-10-20 at 12:40 -0400, Nícolas F. R. A. Prado wrote: > > > On Wed, Oct 19, 2022 at 10:52:15AM +0800, xinlei@mediatek.com > > > wrote: > > [..] > > > >

Re: [PATCH,2/2] drm: mediatek: Add mt8188 dpi compatibles and platform data

2022-10-20 Thread xinlei . lee
On Thu, 2022-10-20 at 10:33 +0200, AngeloGioacchino Del Regno wrote: > Il 20/10/22 09:05, xinlei@mediatek.com ha scritto: > > From: xinlei lee > > > > For MT8188, the vdosys0 only supports 1T1P mode, so we need to add > > the compatible for mt8188 edp-intf. > &g

Re: [PATCH v6,2/3] drm: mediatek: Adjust the dpi output format to MT8186

2022-09-21 Thread xinlei . lee
On Wed, 2022-09-21 at 09:35 +0800, CK Hu wrote: > Hi, Xinlei: > > On Wed, 2022-09-14 at 21:21 +0800, xinlei@mediatek.com wrote: > > From: Xinlei Lee > > > > Dpi output needs to adjust the output format to dual edge for > > MT8186. > > The bri

Re: [PATCH v6,3/3] drm: mediatek: Add mt8186 dpi compatible to mtk_dpi.c

2022-09-21 Thread xinlei . lee
On Wed, 2022-09-21 at 09:42 +0800, CK Hu wrote: > Hi, Xinlei: > > On Wed, 2022-09-14 at 21:21 +0800, xinlei@mediatek.com wrote: > > From: Xinlei Lee > > > > Add the compatible because use edge_cfg_in_mmsys in mt8186. > > > > Signed-off-by: Xinlei Lee

Re: [PATCH v7,1/3] soc: mediatek: Add mmsys func to adapt to dpi output for MT8186

2022-09-22 Thread xinlei . lee
On Thu, 2022-09-22 at 15:29 +0800, xinlei@mediatek.com wrote: > From: Xinlei Lee > > The difference between MT8186 and other ICs is that when modifying > the > output format, we need to modify the mmsys_base+0x400 register to > take > effect. > So when setting the dp

Re: [PATCH v7,1/3] soc: mediatek: Add mmsys func to adapt to dpi output for MT8186

2022-09-22 Thread xinlei . lee
On Thu, 2022-09-22 at 10:16 +0200, AngeloGioacchino Del Regno wrote: > Il 22/09/22 09:29, xinlei@mediatek.com ha scritto: > > From: Xinlei Lee > > > > The difference between MT8186 and other ICs is that when modifying > > the > > output format, we need to mod

Re: [PATCH v8,2/3]drm: mediatek: Adjust the dpi output format to MT8186

2022-09-23 Thread xinlei . lee
or dual edge already > exist in other SoC and is not special in MT8186. So I think you > should > change the title to 'Set dpi format in mmsys' > > > On Thu, 2022-09-22 at 20:45 +0800, xinlei@mediatek.com wrote: > > From: Xinlei Lee > > > > Due to th

Re: [PATCH v9,0/3] Add dpi output format control for MT8186

2022-09-23 Thread xinlei . lee
On Fri, 2022-09-23 at 11:19 +0200, AngeloGioacchino Del Regno wrote: > Il 23/09/22 10:40, xinlei@mediatek.com ha scritto: > > From: Xinlei Lee > > > > Base on the branch of ck-linux-next/mediatek-drm-fixes. > > > > Hello Xinlei, > > I've reviewed

Re: [PATCH] drm: mediatek: Modify dpi power on/off sequence.

2022-10-12 Thread xinlei . lee
On Mon, 2022-09-05 at 21:53 +0800, xinlei@mediatek.com wrote: > From: Xinlei Lee > > Modify dpi power on/off sequence so that the first gpio operation > will take effect. > > Fixes: 6bd4763fd532 ("drm/mediatek: set dpi pin mode to gpio low to > avoid leakage &