et = drm_connector_init(bridge->dev, connector,
> > _connector_funcs,
> > @@ -578,6 +591,10 @@ static void lt8912_bridge_detach(struct drm_bridge
> > *bridge)
> >
> > if (lt->is_attached) {
> > lt8912_hard_power_off(lt);
(could be removed without
> affecting the HDMI port).
>
> No changes on the actual register writes.
>
> Signed-off-by: Francesco Dolcini
> Signed-off-by: Philippe Schenker
Acked-by: Adrien Grassein
> ---
>
> drivers/gpu/drm/bridge/lontium-lt8912b.c | 26 --
undarydevices/linux/blob/boundary-imx_5.10.x_2.0.0/drivers/video/lt8912.c#L296
>
> Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge")
> Signed-off-by: Francesco Dolcini
> Signed-off-by: Philippe Schenker
Acked-by: Adrien Grassein
> ---
>
> drive
roduce LT8912B DSI to HDMI bridge")
> Signed-off-by: Philippe Schenker
Acked-by: Adrien Grassein
> ---
>
> drivers/gpu/drm/bridge/lontium-lt8912b.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt8912b.c
> b/drivers/gpu/drm/brid
was read out from the display.
>
> Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge")
> Signed-off-by: Philippe Schenker
Acked-by: Adrien Grassein
>
> ---
>
> drivers/gpu/drm/bridge/lontium-lt8912b.c | 9 -
> 1 file changed, 8 insertion
Reviewed-by: Adren Grassein
Le sam. 29 mai 2021 à 02:30, Linus Walleij a écrit :
>
> The Lontium bridge is including legacy header files for GPIO
> but not using them. Delete the includes.
>
> Cc: Adrien Grassein
> Cc: Robert Foss
> Signed-off-by: Linus Walleij
>
Fixed proposed at:
https://lore.kernel.org/dri-devel/20210504220207.4004511-1-adrien.grass...@gmail.com/T/#u
Thanks,
Le mar. 4 mai 2021 à 21:19, Adrien Grassein
a écrit :
>
> Ok thanks,
>
> I will investigate this.
>
> Le mar. 4 mai 2021 à 21:04, Michal Suchánek a écr
LONTIUM_LT8912B uses "drm_display_mode_to_videomode" from
DRM framework that needs VIDEOMODE_HELPERS to be enabled.
Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge")
Reported-by: Michal Suchánek
Signed-off-by: Adrien Grassein
---
drivers/gpu/drm/bri
Ok thanks,
I will investigate this.
Le mar. 4 mai 2021 à 21:04, Michal Suchánek a écrit :
>
> Hello,
>
> I have only one from ppc64, the other architectures don't have the
> problem or fail earlier.
>
> Thanks
>
> Michal
>
> On Tue, May 04, 2021 at 08:45:
Hello,
I think this is self-evident but could you please send the config to confirm?
Thanks,
Le mar. 4 mai 2021 à 20:30, Michal Suchánek a écrit :
>
> Hello,
>
> I get errors about missing symbol in the lontium-lt8912b module.
>
> Is the problem self-evident or do you need the config as well?
Hi Robert,
Could you please have a look at this patch?
It has been reviewed by the bug reporter and another person.
I don't receive any "merged" message.
Thanks a lot,
Adrien
Le mer. 31 mars 2021 à 16:42, Dan Carpenter a écrit :
>
> On Wed, Mar 31, 2021 at 03:33:13PM +0200,
> too many)
>
> Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge")
> Fixes: 0cbbd5b1a012 ("drm: bridge: add support for lontium LT9611UXC bridge")
> Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge")
> Signed
A static analysis shows several issues in the driver code at
probing time.
DT parsing errors were bad handled and could lead to bugs:
- Bad error detection;
- Bad release of ressources
Reported-by: Dan Carpenter
Suggested-by: Dan Carpenter
Signed-off-by: Adrien Grassein
Reviewed
Hi,
This patch fixes issues found by a static checker:
- Bad handling of handling of of_* return values.
Thanks,
Adrien Grassein (1):
drm/bridge: lt8912b: fix incorrect handling of of_* return values
drivers/gpu/drm/bridge/lontium-lt8912b.c | 32 +---
1 file changed
Some issues where found during static analysis of this driver.
Reported-by: Dan Carpenter
Suggested-by: Dan Carpenter
Signed-off-by: Adrien Grassein
---
drivers/gpu/drm/bridge/lontium-lt8912b.c | 27 +++-
1 file changed, 17 insertions(+), 10 deletions(-)
diff --git
Hi,
This patch fixes issues found by a static checker.
Thanks,
Adrien Grassein (1):
drm/bridge: lt8912b: Fix issues found during static analysis
drivers/gpu/drm/bridge/lontium-lt8912b.c | 27 +++-
1 file changed, 17 insertions(+), 10 deletions(-)
--
2.25.1
Le mer. 31 mars 2021 à 13:36, Dan Carpenter a écrit :
>
> On Wed, Mar 31, 2021 at 01:21:37PM +0200, Adrien Grassein wrote:
> > - lt->data_lanes = of_property_count_u32_elems(endpoint, "data-lanes");
> > + data_lanes = of_property_count_
Some issues where found during static analysis of this driver.
Reported-by: Dan Carpenter
Suggested-by: Dan Carpenter
Signed-off-by: Adrien Grassein
---
drivers/gpu/drm/bridge/lontium-lt8912b.c | 27 +++-
1 file changed, 17 insertions(+), 10 deletions(-)
diff --git
Hi,
This patch fixes issues found by a static checker.
Thanks,
Adrien Grassein (1):
drm/bridge: lt8912b: Fix issues found during static analysis
drivers/gpu/drm/bridge/lontium-lt8912b.c | 27 +++-
1 file changed, 17 insertions(+), 10 deletions(-)
--
2.25.1
Some issues where found during static analysis of this driver.
Reported-by: Dan Carpenter
Suggested-by: Dan Carpenter
Signed-off-by: Adrien Grassein
---
drivers/gpu/drm/bridge/lontium-lt8912b.c | 24 +++-
1 file changed, 15 insertions(+), 9 deletions(-)
diff --git
Hi,
This patch fixes issues found by a static checker.
Thanks,
Adrien Grassein (1):
drm/bridge: lt8912b: Fix issues found during static analysis
drivers/gpu/drm/bridge/lontium-lt8912b.c | 24 +++-
1 file changed, 15 insertions(+), 9 deletions(-)
--
2.25.1
Le mer. 31 mars 2021 à 12:29, Dan Carpenter a écrit :
>
> On Wed, Mar 31, 2021 at 11:38:22AM +0200, Adrien Grassein wrote:
> > Some issues where found during static analysis of this driver.
> >
> > Reported-by: Dan Carpenter
> > Suggested-by: Dan Carpenter
>
Some issues where found during static analysis of this driver.
Reported-by: Dan Carpenter
Suggested-by: Dan Carpenter
Signed-off-by: Adrien Grassein
---
drivers/gpu/drm/bridge/lontium-lt8912b.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/drivers
Hi,
This patch fixes issues found by a static checker.
Thanks,
Adrien Grassein (1):
drm/bridge: lt8912b: Fix issues found during static analysis
drivers/gpu/drm/bridge/lontium-lt8912b.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
--
2.25.1
Le mer. 31 mars 2021 à 11:27, Dan Carpenter a écrit :
>
> On Wed, Mar 31, 2021 at 11:17:20AM +0200, Adrien Grassein wrote:
> > Hello,
> >
> > thanks for your review.
> >
> > I will publish a patch soon.
> >
> > What tag should I add to my com
Hello,
thanks for your review.
I will publish a patch soon.
What tag should I add to my commit to mention that you find bugs
(Suggested-by for example)?
Thanks;
Le mer. 31 mars 2021 à 10:14, Dan Carpenter a écrit :
>
> On Wed, Mar 31, 2021 at 11:12:38AM +0300, Dan Carpenter wrote:
> >644
Lontium LT8912B is a DSI to HDMI bridge.
Signed-off-by: Adrien Grassein
Reported-by: kernel test robot
Reviewed-by: Robert Foss
---
MAINTAINERS | 1 +
drivers/gpu/drm/bridge/Kconfig | 14 +
drivers/gpu/drm/bridge/Makefile | 1 +
drivers/gpu
).
Update in v9
- Fix errors found in scripts/checkpatch.pl --strict
Thanks,
Adrien Grassein (2):
dt-bindings: display: bridge: Add documentation for LT8912B
drm/bridge: Introduce LT8912B DSI to HDMI bridge
.../display/bridge/lontium,lt8912b.yaml | 102 +++
M
Lontium LT8912B is a DSI to HDMI bridge.
Signed-off-by: Adrien Grassein
Reviewed-by: Rob Herring
---
.../display/bridge/lontium,lt8912b.yaml | 102 ++
MAINTAINERS | 5 +
2 files changed, 107 insertions(+)
create mode 100644
Lontium LT8912B is a DSI to HDMI bridge.
Signed-off-by: Adrien Grassein
Reported-by: kernel test robot
Reviewed-by: Robert Foss
---
MAINTAINERS | 1 +
drivers/gpu/drm/bridge/Kconfig | 14 +
drivers/gpu/drm/bridge/Makefile | 1 +
drivers/gpu
Lontium LT8912B is a DSI to HDMI bridge.
Signed-off-by: Adrien Grassein
Reviewed-by: Rob Herring
---
.../display/bridge/lontium,lt8912b.yaml | 102 ++
MAINTAINERS | 5 +
2 files changed, 107 insertions(+)
create mode 100644
).
Thanks,
Adrien Grassein (2):
dt-bindings: display: bridge: Add documentation for LT8912B
drm/bridge: Introduce LT8912B DSI to HDMI bridge
.../display/bridge/lontium,lt8912b.yaml | 102 +++
MAINTAINERS | 6 +
drivers/gpu/drm/bridge/Kconfig
Le mar. 23 mars 2021 à 15:16, Adrien Grassein
a écrit :
>
> Le mar. 23 mars 2021 à 15:07, Robert Foss a écrit :
> >
> > > > > >
> > > > > > > +static enum drm_connector_status
> > > > > > > lt8912_check_cable_
Le mar. 23 mars 2021 à 15:07, Robert Foss a écrit :
>
> > > > >
> > > > > > +static enum drm_connector_status lt8912_check_cable_status(struct
> > > > > > lt8912 *lt)
> > > > > > +{
> > > > > > + int ret;
> > > > > > + unsigned int reg_val;
> > > > > > +
> > > > > > + ret =
Le mar. 23 mars 2021 à 11:42, Robert Foss a écrit :
>
> On Tue, 23 Mar 2021 at 11:01, Adrien Grassein
> wrote:
> >
> > Hey Robert,
> >
> > Thanks for the update.
> >
> > Le mar. 23 mars 2021 à 10:10, Robert Foss a écrit :
> > >
> >
Hey Robert,
Thanks for the update.
Le mar. 23 mars 2021 à 10:10, Robert Foss a écrit :
>
> Hey Adrien,
>
> Sorry about the slow reply, but I just received the documentation from
> the vendor. So let's dig in to the HPD issue.
No problem :)
>
> > +static enum drm_connector_status
Lontium LT8912B is a DSI to HDMI bridge.
Signed-off-by: Adrien Grassein
Reported-by: kernel test robot
---
MAINTAINERS | 1 +
drivers/gpu/drm/bridge/Kconfig | 14 +
drivers/gpu/drm/bridge/Makefile | 1 +
drivers/gpu/drm/bridge/lontium
Lontium LT8912B is a DSI to HDMI bridge.
Signed-off-by: Adrien Grassein
Reviewed-by: Rob Herring
---
.../display/bridge/lontium,lt8912b.yaml | 102 ++
MAINTAINERS | 5 +
2 files changed, 107 insertions(+)
create mode 100644
using a workqueue and polling the
status regularly.
Update in v6
- Fix a warning found by "kernel test robot"
Update in v7
- Fix HPD logic (via an HW emulation);
- HPD from chip is still not working.
Thanks,
Adrien Grassein (2):
dt-bindings: display: bridge: Add documentation f
Lontium LT8912B is a DSI to HDMI bridge.
Signed-off-by: Adrien Grassein
Reported-by: kernel test robot
---
MAINTAINERS | 1 +
drivers/gpu/drm/bridge/Kconfig | 14 +
drivers/gpu/drm/bridge/Makefile | 1 +
drivers/gpu/drm/bridge/lontium
Lontium LT8912B is a DSI to HDMI bridge.
Signed-off-by: Adrien Grassein
Reviewed-by: Rob Herring
---
.../display/bridge/lontium,lt8912b.yaml | 102 ++
MAINTAINERS | 5 +
2 files changed, 107 insertions(+)
create mode 100644
using a workqueue and polling the
status regularly.
Update in v6
- Fix a warning found by "kernel test robot"
Thanks,
Adrien Grassein (2):
dt-bindings: display: bridge: Add documentation for LT8912B
drm/bridge: Introduce LT8912B DSI to HDMI bridge
.../display/bridge/lontium,lt
Lontium LT8912B is a DSI to HDMI bridge.
Signed-off-by: Adrien Grassein
---
MAINTAINERS | 1 +
drivers/gpu/drm/bridge/Kconfig | 14 +
drivers/gpu/drm/bridge/Makefile | 1 +
drivers/gpu/drm/bridge/lontium-lt8912b.c | 817
Lontium LT8912B is a DSI to HDMI bridge.
Signed-off-by: Adrien Grassein
Reviewed-by: Rob Herring
---
.../display/bridge/lontium,lt8912b.yaml | 102 ++
MAINTAINERS | 5 +
2 files changed, 107 insertions(+)
create mode 100644
using a workqueue and polling the
status regularly.
Thanks,
Adrien Grassein (2):
dt-bindings: display: bridge: Add documentation for LT8912B
drm/bridge: Introduce LT8912B DSI to HDMI bridge
.../display/bridge/lontium,lt8912b.yaml | 102 +++
MAINTAINERS
Lontium Lt8912 is a DSI to HDMI bridge.
Signed-off-by: Adrien Grassein
---
MAINTAINERS | 1 +
drivers/gpu/drm/bridge/Kconfig | 14 +
drivers/gpu/drm/bridge/Makefile | 1 +
drivers/gpu/drm/bridge/lontium-lt8912.c | 764
4
Lontium LT8912 is a DSI to HDMI bridge.
Signed-off-by: Adrien Grassein
Reviewed-by: Rob Herring
---
.../display/bridge/lontium,lt8912.yaml| 102 ++
MAINTAINERS | 5 +
2 files changed, 107 insertions(+)
create mode 100644
the DB_DSIHD board from BoundaryDevices.
Update in v2
- Use standard data-lanes instead of a custom prop;
- Use hdmi-connector node.
Update in v3
- Fix indentation;
- Implement missing bridge functions;
- Add some comments.
Update in v4
- Fix bridge ops;
- Fix i2c error detection.
Adrien
Hey Robert,
Le ven. 19 févr. 2021 à 22:47, Adrien Grassein
a écrit :
>
> Le ven. 19 févr. 2021 à 22:28, Robert Foss a écrit :
> >
> > On Fri, 19 Feb 2021 at 16:01, Adrien Grassein
> > wrote:
> > >
> > > Hey Robert,
> > >
> > >
Le ven. 19 févr. 2021 à 22:28, Robert Foss a écrit :
>
> On Fri, 19 Feb 2021 at 16:01, Adrien Grassein
> wrote:
> >
> > Hey Robert,
> >
> > Le ven. 19 févr. 2021 à 14:27, Robert Foss a écrit
> > :
> > >
> > > Hey Adrien,
> > &g
Hey Robert,
Le ven. 19 févr. 2021 à 14:27, Robert Foss a écrit :
>
> Hey Adrien,
>
>
> Thanks for the quick update.
No problem, I have some free time at the moment.
>
> On Thu, 18 Feb 2021 at 22:05, Adrien Grassein
> wrote:
> >
> > Lontium Lt8912 is a DS
Hey Robert,
Thank you for your time and for your review.
Le mer. 17 févr. 2021 à 18:32, Robert Foss a écrit :
>
> Hey Adrien,
>
> Thanks for submitting this!
>
> On Mon, 15 Feb 2021 at 00:31, Adrien Grassein
> wrote:
> >
> > Lontium Lt8912 is a DSI t
Lontium LT8912 is a DSI to HDMI bridge.
Signed-off-by: Adrien Grassein
Reviewed-by: Rob Herring
---
.../display/bridge/lontium,lt8912.yaml| 102 ++
MAINTAINERS | 5 +
2 files changed, 107 insertions(+)
create mode 100644
Lontium Lt8912 is a DSI to HDMI bridge.
Signed-off-by: Adrien Grassein
---
MAINTAINERS | 1 +
drivers/gpu/drm/bridge/Kconfig | 14 +
drivers/gpu/drm/bridge/Makefile | 1 +
drivers/gpu/drm/bridge/lontium-lt8912.c | 760
4
board from BoundaryDevices.
Update in v2
- Use standard data-lanes instead of a custom prop;
- Use hdmi-connector node.
Update in v3
- Fix indentation;
- Implement missing bridge functions;
- Add some comments.
Thanks,
Adrien Grassein
Adrien Grassein (2):
dt-bindings: display: bridge
the DB_DSIHD board from BoundaryDevices.
Update in v2
- Use standard data-lanes instead of a custom prop;
- Use hdmi-connector node.
Thanks,
Adrien Grassein
Adrien Grassein (2):
dt-bindings: display: bridge: Add documentation for LT8912
drm/bridge: Introduce LT8912 DSI to HDMI bridge
Lontium LT8912 is a DSI to HDMI bridge.
Signed-off-by: Adrien Grassein
---
.../display/bridge/lontium,lt8912.yaml| 102 ++
MAINTAINERS | 5 +
2 files changed, 107 insertions(+)
create mode 100644
Documentation/devicetree/bindings
Lontium Lt8912 is a DSI to HDMI bridge.
Signed-off-by: Adrien Grassein
---
MAINTAINERS | 1 +
drivers/gpu/drm/bridge/Kconfig | 14 +
drivers/gpu/drm/bridge/Makefile | 1 +
drivers/gpu/drm/bridge/lontium-lt8912.c | 719
4
the DB_DSIHD board from BoundaryDevices.
Thanks,
Adrien Grassein
Adrien Grassein (2):
dt-bindings: display: bridge: Add documentation for LT8912
drm/bridge: Introduce LT8912 DSI to HDMI bridge
.../display/bridge/lontium,lt8912.yaml| 92 +++
MAINTAINERS
Lontium LT8912 is a DSI to HDMI bridge.
Signed-off-by: Adrien Grassein
---
.../display/bridge/lontium,lt8912.yaml| 92 +++
MAINTAINERS | 5 +
2 files changed, 97 insertions(+)
create mode 100644
Documentation/devicetree/bindings
Lontium Lt8912 is a DSI to HDMI bridge.
Signed-off-by: Adrien Grassein
---
MAINTAINERS | 1 +
drivers/gpu/drm/bridge/Kconfig | 14 +
drivers/gpu/drm/bridge/Makefile | 1 +
drivers/gpu/drm/bridge/lontium-lt8912.c | 749
4
Lontium LT8912 is a DSI to HDMI bridge.
Signed-off-by: Adrien Grassein
---
.../display/bridge/lontium,lt8912.yaml| 92 +++
MAINTAINERS | 5 +
2 files changed, 97 insertions(+)
create mode 100644
Documentation/devicetree/bindings
62 matches
Mail list logo
