Re: [PATCH] drm/amd/powerplay: Delete a redundant memory setting in vega20_set_default_od8_setttings()

2019-06-17 Thread Alex Deucher
Applied this and the dc patch. Thanks! Alex On Mon, Jun 17, 2019 at 10:07 AM Markus Elfring wrote: > > From: Markus Elfring > Date: Mon, 17 Jun 2019 14:24:14 +0200 > > The memory was set to zero already by a call of the function “kzalloc”. > Thus remove an extra call of the function “memset”

Re: [PATCH] drm/amd/display: Add missing newline at end of file

2019-06-17 Thread Alex Deucher
On Mon, Jun 17, 2019 at 10:45 AM Geert Uytterhoeven wrote: > > "git diff" says: > > \ No newline at end of file > > after modifying the file. > > Signed-off-by: Geert Uytterhoeven Applied. thanks! Alex > --- > drivers/gpu/drm/amd/display/modules/power/Makefile | 2 +- > 1 file changed,

Re: [PATCH] drm/amdgpu: fix error handling in df_v3_6_pmc_start

2019-06-17 Thread Alex Deucher
On Mon, Jun 17, 2019 at 8:57 AM Arnd Bergmann wrote: > > When df_v3_6_pmc_get_ctrl_settings() fails for some reason, we > store uninitialized data in a register, as gcc points out: > > drivers/gpu/drm/amd/amdgpu/df_v3_6.c: In function 'df_v3_6_pmc_start': >

Re: [PATCH] drm/amd/display: fix compilation error

2019-06-13 Thread Alex Deucher
On Thu, Jun 13, 2019 at 2:42 PM Sam Ravnborg wrote: > > Hi Alex. > > On Wed, Jun 12, 2019 at 10:35:26PM -0400, Alex Deucher wrote: > > On Wed, Jun 12, 2019 at 10:34 PM Hariprasad Kelam > > wrote: > > > > > > this patch fixes below compilation er

Re: [PATCH] drm/connector: Fix kerneldoc warning in HDR_OUTPUT_METADATA description

2019-06-13 Thread Alex Deucher
> Cc: Hans Verkuil > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fb...@vger.kernel.org > Cc: Sean Paul (v1) > Cc: Uma Shankar > Cc: Daniel Vetter > Cc: "Ville Syrjälä" > Signed-off-by: Sean Paul Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/drm_conn

Re: linux-next: Tree for Jun 12 (amdgpu: dcn10_hw_sequencer)

2019-06-13 Thread Alex Deucher
On Thu, Jun 13, 2019 at 3:27 AM Randy Dunlap wrote: > > On 6/12/19 12:00 AM, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20190611: > > > > on x86_64: > > ../drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In > function ‘dcn10_apply_ctx_for_surface’: >

Re: [PATCH] radeon: no need to check return value of debugfs_create functions

2019-06-13 Thread Alex Deucher
On Thu, Jun 13, 2019 at 7:56 AM Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Alex Deucher >

Re: [PATCH] drm/amd/powerplay/smu7_hwmgr: replace blocking delay with non-blocking

2019-06-13 Thread Alex Deucher
On Tue, Jun 4, 2019 at 4:22 PM Yrjan Skrimstad wrote: > > On Thu, May 30, 2019 at 02:08:21AM +0200, Yrjan Skrimstad wrote: > > This driver currently contains a repeated 500ms blocking delay call > > which causes frequent major buffer underruns in PulseAudio. This patch > > fixes this issue by

Re: [PATCH] drm/amd/display: fix compilation error

2019-06-12 Thread Alex Deucher
On Wed, Jun 12, 2019 at 10:34 PM Hariprasad Kelam wrote: > > this patch fixes below compilation error > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In > function ‘dcn10_apply_ctx_for_surface’: > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3:

[pull] amdgpu drm-fixes-5.2

2019-06-12 Thread Alex Deucher
(2019-06-12 20:39:49 -0500) Alex Deucher (1): drm/amdgpu: return 0 by default in amdgpu_pm_load_smu_firmware Dan Carpenter (1): drm/amdgpu: Fix bounds checking in amdgpu_ras_is_supported() Shirish S (1): drm/amdgpu

Re: [PATCH v1 0/10] drm/amd: drop use of drmP.h

2019-06-10 Thread Alex Deucher
s of include > failes are seperated by empty lines. > This account for some of the added lines. Series is: Reviewed-by: Alex Deucher I'm fine to have this go through either drm-misc or my tree. Alex > > Sam > > Sam Ravnborg (10): > drm: fix build errors with drm_

Re: [PATCH v1 0/7] drm/radeon: drop obsolete header files

2019-06-10 Thread Alex Deucher
was all build tested on various architectures, > and as usual alpha resulted in a few extra build issues. > > The patches are made on top of drm-misc-next, but applies > clean to drm-next-5.3-wip branch of the agd5f git tree. Series is: Reviewed-by: Alex Deucher Feel free to take it through d

[pull v2] amdgpu, ttm drm-next-5.3

2019-06-05 Thread Alex Deucher
8:09 -0500) ---- Alex Deucher (3): drm/amdgpu: fix a race in GPU reset with IB test (v2) drm/amdgpu/display: Drop some new CONFIG_DRM_AMD_DC_DCN1_01 guards Revert "drm/amdgpu: add DRIVER_SYNCOBJ_TIMELINE to amdgpu" Anthony Koo (2): drm/amd/d

Re: [pull] amdgpu, ttm drm-next-5.3

2019-06-05 Thread Alex Deucher
On Wed, Jun 5, 2019 at 10:34 PM Dave Airlie wrote: > > On Thu, 6 Jun 2019 at 05:12, Alex Deucher wrote: > > > > Hi Dave, Daniel, > > > > More new stuff for 5.3: > > > > amdgpu: > > - Revert timeline support until KHR is ready > > - Various d

[pull] amdgpu, ttm drm-next-5.3

2019-06-05 Thread Alex Deucher
4:27 -0500) ---- Alex Deucher (3): drm/amdgpu: fix a race in GPU reset with IB test (v2) drm/amdgpu/display: Drop some new CONFIG_DRM_AMD_DC_DCN1_01 guards Revert "drm/amdgpu: add DRIVER_SYNCOBJ_TIMELINE to amdgpu" Anthony Koo (2): drm/amd/display: do not power on

[pull] amdgpu drm-fixes-5.2

2019-06-05 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.2: - A fix to make VCE resume more reliable - Updates for new raven variants The following changes since commit 2a3e0b716296a504d9e65fea7acb379c86fe4283: Merge tag 'imx-drm-fixes-2019-05-29' of git://git.pengutronix.de/git/pza/linux into drm-fixes (2019-05-31

Re: [pull] amdgpu, amdkfd drm-next-5.3

2019-06-04 Thread Alex Deucher
On Mon, Jun 3, 2019 at 11:36 AM Daniel Vetter wrote: > > On Thu, May 30, 2019 at 12:09 AM Alex Deucher wrote: > > > > Hi Dave, Daniel, > > > > New stuff for 5.3: > > - Add new thermal sensors for vega asics > > - Various RAS fixes > > - Add

Re: [PATCH 11/22] gpu: amdgpu: fix broken amdgpu_dma_buf.c references

2019-05-31 Thread Alex Deucher
On Fri, May 31, 2019 at 10:00 AM Christian König wrote: > > Am 30.05.19 um 01:23 schrieb Mauro Carvalho Chehab: > > This file was renamed, but docs weren't updated accordingly. > > > > WARNING: kernel-doc './scripts/kernel-doc -rst -enable-lineno > > -function PRIME Buffer Sharing

[pull] amdgpu, amdkfd drm-next-5.3

2019-05-29 Thread Alex Deucher
: fix null pointer dereference on dev (2019-05-29 16:50:09 -0500) Alex Deucher (3): drm/amdgpu/vega20: use mode1 reset for RAS and XGMI drm/amdgpu: use pcie_bandwidth_available rather than open coding it drm/amdgpu/soc15

[pull] amdgpu drm-fixes-5.2

2019-05-29 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.2: - Respin the Raven DMCU patch with the ifdef fixed - Fix for a clean display when loading the driver on Raven The following changes since commit c074989171801171af6c5f53dd16b27f36b31deb: Revert "drm/amd/display: Don't load DMCU for Raven 1" (2019-05-24 19:56:50

Re: [PATCH] drm/sched: Fix make htmldocs warnings.

2019-05-29 Thread Alex Deucher
On Wed, May 29, 2019 at 10:29 AM Andrey Grodzovsky wrote: > > Signed-off-by: Andrey Grodzovsky Reviewed-by: Alex Deucher I'll push it to drm-misc in a minute unless you have commit rights. Alex > --- > drivers/gpu/drm/scheduler/sched_main.c | 2 ++ > 1 file change

Re: [PATCH 2/2] drm/edid: Ignore "DFP 1.x" bit for EDID 1.2 and earlier

2019-05-29 Thread Alex Deucher
and therefore > cannot be interpreted to mean anything." > > And since EDID 1.4 redefines that bit let's consult it only for > EDID 1.3. > > Cc: Mario Kleiner > Signed-off-by: Ville Syrjälä Series is: Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/drm_edid.c |

Re: [PATCH 07/10] drm/amd/display: use ttm_eu_reserve_buffers instead of amdgpu_bo_reserve v2

2019-05-28 Thread Alex Deucher
On Tue, May 28, 2019 at 1:05 PM Sam Ravnborg wrote: > > Hi Christian. > > On Tue, May 28, 2019 at 06:25:54PM +0200, Christian König wrote: > > From: Chunming Zhou > > > > add ticket for display bo, so that it can preempt busy bo. > > > > v2: fix stupid rebase error > > > > Change-Id:

Re: [RFC PATCH] drm/ttm, drm/vmwgfx: Have TTM support AMD SEV encryption

2019-05-24 Thread Alex Deucher
crypted pages in the dma page pool regardless of their > >>>>>>> caching > >>>>>>> state. > >>>>>> This patch is unnecessary, SEV support already works fine with at > >>>>>> least > >>>>>> amd

[pull] amdgpu, amdkfd drm-fixes-5.2

2019-05-22 Thread Alex Deucher
switching (2019-05-20 21:22:49 -0500) Alex Deucher (2): drm/amdgpu/soc15: skip reset on init drm/amdgpu/gmc9: set vram_width properly for SR-IOV Dan Carpenter (1): drm/amd/powerplay: fix locking

Re: [PATCH v2] drm/scheduler: Fix job cleanup without timeout handler

2019-05-21 Thread Alex Deucher
On Tue, May 21, 2019 at 2:48 AM Koenig, Christian wrote: > > Am 21.05.19 um 01:16 schrieb Erico Nunes: > > [CAUTION: External Email] > > > > After "5918045c4ed4 drm/scheduler: rework job destruction", jobs are > > only deleted when the timeout handler is able to be cancelled > > successfully. > >

Re: [PATCH] gpu: drm: use struct_size() in kmalloc()

2019-05-20 Thread Alex Deucher
On Mon, May 20, 2019 at 7:19 PM Pan, Xinhui wrote: > > Daniel, what you are talking about is totally wrong. > 1) AFAIK, only one zero-size array can be in the end of a struct. > 2) two struct_size will add up struct itself twice. the sum is wrong then. > > No offense. I can't help feeling lucky

Re: [PATCH] gpu: drm: use struct_size() in kmalloc()

2019-05-20 Thread Alex Deucher
On Fri, May 17, 2019 at 8:43 AM xiaolinkui wrote: > > Use struct_size() helper to keep code simple. > > Signed-off-by: xiaolinkui > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) This patch results in the following build error: DESCEND

Re: [PATCH] gpu: fix typos in code comments

2019-05-20 Thread Alex Deucher
On Mon, May 20, 2019 at 1:04 PM Weitao Hou wrote: > > fix eror to error > > Signed-off-by: Weitao Hou Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: Preparation for unpinned DMA-buf handling

2019-05-15 Thread Alex Deucher
On Wed, May 15, 2019 at 4:52 PM Daniel Vetter wrote: > > On Wed, May 15, 2019 at 10:08 PM Alex Deucher wrote: > > > > On Wed, May 15, 2019 at 4:54 AM Daniel Vetter wrote: > > > > > > On Tue, May 14, 2019 at 04:05:13PM +0200, Christian König wrote: > &g

Re: [PATCH][next] drm/amdgpu: fix spelling mistake "retrived" -> "retrieved"

2019-05-15 Thread Alex Deucher
On Fri, May 10, 2019 at 3:07 AM Colin King wrote: > > From: Colin Ian King > > There is a spelling mistake in a DRM_ERROR error message. Fix this. > > Signed-off-by: Colin Ian King Applied. thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/df_v3_6.c | 2 +- > 1 file changed, 1 insertion(+),

Re: Preparation for unpinned DMA-buf handling

2019-05-15 Thread Alex Deucher
On Wed, May 15, 2019 at 4:54 AM Daniel Vetter wrote: > > On Tue, May 14, 2019 at 04:05:13PM +0200, Christian König wrote: > > Hi Daniel, > > > > since we are not moving forward with this I've separated the change out of > > the larger patchset. > > > > Any objections to this now? It's basically

Re: [PATCH 2/2] mm/hmm: Only set FAULT_FLAG_ALLOW_RETRY for non-blocking

2019-05-14 Thread Alex Deucher
On Tue, May 14, 2019 at 5:12 PM Kuehling, Felix wrote: > > > On 2019-05-13 4:21 p.m., Deucher, Alexander wrote: > > [CAUTION: External Email] > > I reverted all the amdgpu HMM patches for 5.2 because they also > > depended on this patch: > >

[PATCH] Revert "vgaarb: Keep adding VGA device in queue"

2019-05-10 Thread Alex Deucher
This breaks multiple graphics cards in the Amigaone x5000 on PPC. This reverts commit 3d42f1ddc47a69c0ce155f9f30d764c4d689a5fa. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=109345 Signed-off-by: Alex Deucher CC: Aaron Ma --- drivers/gpu/vga/vgaarb.c | 2 +- 1 file changed, 1 insertion

[pull] amdgpu, radeon drm-next-5.2

2019-05-09 Thread Alex Deucher
pointers to early_init (2019-05-09 17:47:04 -0500) Aaron Liu (1): drm/amdgpu: remove ATPX_DGPU_REQ_POWER_FOR_DISPLAYS check when hotplug-in Alex Deucher (1): drm/amdgpu/psp: move psp version specific function pointers

Re: [PATCH] drm/amd/display: Make some functions static

2019-05-09 Thread Alex Deucher
On Wed, May 8, 2019 at 10:47 AM Wang Hai wrote: > > Fix the following sparse warnings: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_resource.c:483:21: > warning: symbol 'dce120_clock_source_create' was not declared. Should it be > static? >

Re: [PATCH] drm: Fix timestamp docs for variable refresh properties.

2019-05-07 Thread Alex Deucher
On Tue, May 7, 2019 at 1:15 AM Mario Kleiner wrote: > > Nag nag: The below documentation patch, acked-by Daniel and r-b'd by > Nicholas seems to not have made it into drm-next yet? Pushed to drm-misc-next-fixes Thanks! Alex > > thanks, > -mario > > On Thu, Apr 18, 2019 at 2:45 PM Kazlauskas,

Re: [PATCH 1/1] MAINTAINERS: update amdkfd maintainer

2019-05-06 Thread Alex Deucher
RS > @@ -798,9 +798,9 @@ F: drivers/iommu/amd_iommu*.[ch] > F: include/linux/amd-iommu.h > > AMD KFD > -M: Oded Gabbay > +M: Alex Deucher > L: dri-devel@lists.freedesktop.org > -T: git git://people.freedesktop.org/~gabbayo/linux.git > +T: g

[pull] amdgpu drm-next-5.2

2019-05-02 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.2: - SR-IOV fixes - Raven flickering fix - Misc spelling fixes - Vega20 power fixes - Freesync improvements - DC fixes The following changes since commit f55be0be5b7296e73f1634e2839a1953dc12d11e: drm/amd/display: Add profiling tools for bandwidth validation

Re: [PATCH] MAINTAINERS: drop Jerry as TTM maintainer

2019-04-30 Thread Alex Deucher
On Tue, Apr 30, 2019 at 5:41 AM Christian König wrote: > > He unfortunately doesn't work for AMD any more. > > Signed-off-by: Christian König Acked-by: Alex Deucher > --- > MAINTAINERS | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINT

Re: [PATCH][next] drm/amd/display: fix incorrect null check on pointer

2019-04-29 Thread Alex Deucher
On Fri, Apr 26, 2019 at 5:48 PM Colin King wrote: > > From: Colin Ian King > > Currently an allocation is being made but the allocation failure > check is being performed on another pointer. Fix this by checking > the correct pointer. Also use the normal kernel idiom for null > pointer checks. >

[pull] sched, ttm drm-fixes-5.1

2019-04-24 Thread Alex Deucher
Hi Dave, Daniel, Pretty quiet. Just two fixes: - ttm regression fix - sched documentation fix The following changes since commit 00fd14ff3017f64a9a03a08291e4be0d87bedc17: Merge branch 'drm-fixes-5.1' of git://people.freedesktop.org/~agd5f/linux into drm-fixes (2019-04-18 06:56:35 +1000)

Re: [RFC][PATCH 4/5] libdrm: reduce number of reallocations in drmModeAtomicAddProperty

2019-04-22 Thread Alex Deucher
Atomic Commit call. > > Increase this to as many as can fit in a memory PAGE to avoid having to > reallocate memory too often. > > Cc: Emil Velikov > Cc: Sean Paul > Cc: Alistair Strachan > Cc: Marissa Wall > Signed-off-by: John Stultz Reviewed-by: Alex Deucher > --- &

Re: [RFC][PATCH 1/5] libdrm: Use mmap64 instead of __mmap2

2019-04-22 Thread Alex Deucher
ap64 takes. > > Cc: Emil Velikov > Cc: Sean Paul > Cc: Alistair Strachan > Cc: Marissa Wall > Signed-off-by: Sean Paul > Signed-off-by: John Stultz Acked-by: Alex Deucher > --- > libdrm_macros.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >

Re: [RFC][PATCH 3/5] libdrm: Avoid additional drm open close

2019-04-22 Thread Alex Deucher
On Sat, Apr 20, 2019 at 12:25 AM John Stultz wrote: > > From: Prabhanjan Kandula > > Avoid additional drm device open and close. > > Cc: Emil Velikov > Cc: Sean Paul > Cc: Alistair Strachan > Cc: Marissa Wall > Signed-off-by: John Stultz Reviewed-by: Alex De

Re: [RFC][PATCH 2/5] libdrm: amdgpu: Initialize unions with memset rather than "= {0}"

2019-04-22 Thread Alex Deucher
On Sat, Apr 20, 2019 at 12:25 AM John Stultz wrote: > > Clang complains when initializing unions using "= {0}" > so instead use memset. > > Cc: Emil Velikov > Cc: Sean Paul > Cc: Alistair Strachan > Cc: Marissa Wall > Signed-off-by: John Stultz Reviewed-

Re: [PATCH 6/6] drm/amdgpu: add support for exporting VRAM using DMA-buf v2

2019-04-19 Thread Alex Deucher
On Thu, Apr 18, 2019 at 8:09 AM Christian König wrote: > > We should be able to do this now after checking all the prerequisites. > > v2: fix entrie count in the sgt > > Signed-off-by: Christian König Series is: Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/a

Re: [PATCH 05/12] dma-buf: add explicit buffer pinning

2019-04-19 Thread Alex Deucher
On Tue, Apr 16, 2019 at 2:39 PM Christian König wrote: > > Add optional explicit pinning callbacks instead of implicitly assume the > exporter pins the buffer when a mapping is created. > > Signed-off-by: Christian König > --- > drivers/dma-buf/dma-buf.c | 39

Re: [PATCH 2/6] PCI/P2PDMA: start with a whitelist for root complexes

2019-04-19 Thread Alex Deucher
On Thu, Apr 18, 2019 at 8:09 AM Christian König wrote: > > A lot of root complexes can still do P2P even when PCI devices > don't share a common upstream bridge. > > Start adding a whitelist and allow P2P if both participants are > attached to known good root complex. > > Signed-off-by: Christian

Re: [PATCH] drm/amd/amdgpu: fix spelling mistake "recieve" -> "receive"

2019-04-19 Thread Alex Deucher
On Thu, Apr 18, 2019 at 1:58 PM Mukesh Ojha wrote: > > > On 4/18/2019 3:55 PM, Colin King wrote: > > From: Colin Ian King > > > > There is a spelling mistake in a pr_err message. Fix it. > > > > Signed-off-by: Colin Ian King > Reviewed-by: Mukesh Ojha Applied. thanks! Alex > > Cheers, >

Re: [PATCH] drm/amdgpu: fix spelling mistake "gateing" -> "gating"

2019-04-19 Thread Alex Deucher
On Wed, Apr 17, 2019 at 3:04 AM Mukesh Ojha wrote: > > > On 4/16/2019 5:29 PM, Colin King wrote: > > From: Colin Ian King > > > > There is a spelling mistake in a DRM_INFO message. Fix it. > > > > Signed-off-by: Colin Ian King > Reviewed-by: Mukesh Ojha Applied. thanks! Alex > > Cheers, >

[pull] amdgpu drm-next-5.2

2019-04-19 Thread Alex Deucher
Hi Dave, Daniel, More updates for 5.2: - Add the amdgpu specific bits for timeline support - Add internal interfaces for xgmi pstate support - DC Z ordering fixes for planes - Add support for NV12 planes in DC - Add colorspace properties for planes in DC - eDP optimizations if the GOP driver

[pull] amdgpu, ttm drm-fixes-5.1

2019-04-14 Thread Alex Deucher
to c238bfe0be9ef7420f7669a69e27c8c8f4d8a568: drm/amd/display: If one stream full updates, full update all planes (2019-04-14 23:45:43 -0500) Alex Deucher (1): drm/amdgpu/gmc9: fix VM_L2_CNTL3 programming Christian König (3): drm/ttm: fix out

Re: [PATCH] drm: remove redundant 'default n' from Kconfig

2019-04-12 Thread Alex Deucher
people that a bare 'default n' is > redundant. > ... > > Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Alex Deucher for amdgpu and drm. > --- > drivers/gpu/drm/Kconfig |5 - > drivers/gpu/drm/amd/amdgpu/Kconfig |1 - > drivers/gpu/

[pull] amdgpu drm-next-5.2

2019-04-10 Thread Alex Deucher
Hi Dave, Daniel, More stuff for 5.2: - Fixes for powerplay custom profiles - DC bandwidth clean ups and fixes - RAS fixes for vega20 - DC atomic resume fix - Better plane handling in DC - Freesync improvements - Misc bug fixes and cleanups The following changes since commit

[pull] amdgpu, amdkfd drm-fixes-5.1

2019-04-10 Thread Alex Deucher
) Alex Deucher (1): drm/amdkfd: Add picasso pci id Nicholas Kazlauskas (1): drm/amd/display: Fix negative cursor pos programming (v2) shaoyunl (1): drm/amdgpu: Adjust IB test timeout for XGMI configuration tiancyin (1): drm/amd

Re: [PATCH 3/3] drm/udl: move to embedding drm device inside udl device.

2019-04-05 Thread Alex Deucher
right thing. Patches 1, 2 are: Reviewed-by: Alex Deucher Patch 3: Acked-by: Alex Deucher > --- > drivers/gpu/drm/udl/udl_drv.c | 56 +++--- > drivers/gpu/drm/udl/udl_drv.h | 9 +++--- > drivers/gpu/drm/udl/udl_fb.c | 2 +- > drivers/gpu/drm/udl

[pull] amdgpu drm-fixes-5.1

2019-04-03 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.1: - Fix for pcie dpm - Powerplay fixes for vega20 - Fix vbios display on reboot if driver display state is retained - Gfx9 resume robustness fix The following changes since commit 0ab925d3690614aa44cd29fb84cdcef03eab97dc: drm/amd/display: Only allow VRR when

[pull] amdgpu, amdkfd, ttm drm-next-5.2

2019-04-02 Thread Alex Deucher
repository at: git://people.freedesktop.org/~agd5f/linux drm-next-5.2 for you to fetch changes up to 7a65bdc6903d4cae56855eceabfd8f879a3b8f6e: drm/amdgpu/smu11: fix warning on 32bit arches (2019-04-02 09:10:55 -0500) Alex Deucher

[pull] amdgpu, amdkfd, ttm drm-next-5.2

2019-03-28 Thread Alex Deucher
ifier" (2019-03-28 10:16:12 -0500) ---- Alex Deucher (12): drm/amdgpu/powerplay: add missing breaks in polaris10_smumgr drm/amdgpu/powerplay: add BACO support for vega12 drm/amdgpu/powerplay: split out common smu9

[pull] amdgpu drm-fixes-5.1

2019-03-27 Thread Alex Deucher
Hi Dave, Daniel, Just one fix this week for freesync. The following changes since commit 72464382fc2d3673eb51f21a57f2c0a320c1552f: drm/amdgpu: fix invalid use of change_bit (2019-03-19 14:01:42 -0500) are available in the Git repository at: git://people.freedesktop.org/~agd5f/linux

Re: [PATCH 21/21] drm/fb-helper: Unexport fill_{var,info}

2019-03-26 Thread Alex Deucher
On Tue, Mar 26, 2019 at 9:21 AM Daniel Vetter wrote: > > Not used by drivers anymore. > > v2: Rebase > > Signed-off-by: Daniel Vetter Other than the spelling typos noted by Noralf, the series is: Reviewed-by: Alex Deucher > --- > drivers/gpu/

Re: Radeon HD 7450 brightness oversaturated

2019-03-21 Thread Alex Deucher
On Thu, Mar 21, 2019 at 4:41 PM Meelis Roos wrote: > > I decided to put a discrete graphics card into a PC and found a fitting > Radeon HD 7450. > It works, but there is strange whiteness like the brightness is oversaturated > and > light places turn into other colors: > * on fbcon, right after

Re: [PATCH -next] drm/ttm: remove set but not used variable 'rdev'

2019-03-21 Thread Alex Deucher
On Wed, Mar 20, 2019 at 9:25 AM YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/radeon/radeon_ttm.c: In function 'radeon_move_vram_ram': > drivers/gpu/drm/radeon/radeon_ttm.c:254:24: warning: > variable 'rdev' set but not used [-Wunused-but-set-variable]

Re: [PATCH] drm/amd/powerplay: Zero initialize num_of_levels in vega20_set_single_dpm_table

2019-03-21 Thread Alex Deucher
On Wed, Mar 20, 2019 at 4:33 AM Nathan Chancellor wrote: > > When building with -Wsometimes-uninitialized, Clang warns: > > drivers/gpu/drm/amd/amdgpu/../powerplay/vega20_ppt.c:456:2: warning: > variable 'num_of_levels' is used uninitialized whenever '?:' condition > is false

Re: [PATCH][next] drm/amd/powerplay: fix spelling mistake "unknow" -> "unknown"

2019-03-21 Thread Alex Deucher
On Wed, Mar 20, 2019 at 1:29 PM Colin King wrote: > > From: Colin Ian King > > There is a spelling mistake in pr_warn message; fix it. > > Signed-off-by: Colin Ian King Applied. thanks! Alex > --- > drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: Clang warning in drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

2019-03-20 Thread Alex Deucher
On Wed, Mar 20, 2019 at 4:49 PM Nick Desaulniers wrote: > > On Wed, Mar 20, 2019 at 2:37 AM Koenig, Christian > wrote: > > > > Am 20.03.19 um 05:34 schrieb Nathan Chancellor: > > > On Wed, Mar 20, 2019 at 01:31:27AM +, Pan, Xinhui wrote: > > >> these two enumerated types are same for now.

Re: [PATCH libdrm] tests/amdgpu: minor fix for dispatch/draw test

2019-03-20 Thread Alex Deucher
On Tue, Mar 19, 2019 at 10:47 PM Cui, Flora wrote: > > 1. clear cmd buffer > 2. make amdgpu_memcpy_dispatch_test static > 3. tab/space fix > > Change-Id: Idf55f8881f66458b585092eccb55b6042520e4ad > Signed-off-by: Flora Cui Reviewed-by: Alex Deucher and pushed. Thanks!

[pull] amdgpu drm-fixes-5.1

2019-03-20 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.1: - Parially revert a bulk move clean up change to fix a ref count bug - Fix invalid use of change_bit that caused a crash on PPC64 and ARM64 The following changes since commit 9e98c678c2d6ae3a17cb2de55d17f69dddaa231b: Linux 5.1-rc1 (2019-03-17 14:22:26 -0700)

Re: Missing Thunderbolt 3 PCI-E atomics support

2019-03-15 Thread Alex Deucher
As Mika said pci atomics have to be supported by the bridge for the device to be able to use them. Alex On Fri, Mar 15, 2019 at 3:46 PM Dieter Nützel wrote: > > Hello to both of you, Tim and Mika, > > sorry that I step in so late, but after I've read that Tim's laptop > didn't have PCIe atomics

[pull] amdgpu drm-next-5.1

2019-03-13 Thread Alex Deucher
Hi Dave, Daniel, A few fixes for 5.1: - Update golden regs for gfx9 - Powerplay fixes The following changes since commit 59d3191f14dc18881fec1172c7096b7863622803: drm/amd/display: don't call dm_pp_ function from an fpu block (2019-03-06 15:31:20 -0500) are available in the Git repository

Re: [PATCH] drm/dp: Set the connector's TILE property even for DP SST connectors

2019-03-13 Thread Alex Deucher
s been tested with xrandr --props and modetest and verified > that TILE property is exposed correctly. > > Cc: Dave Airlie > Cc: Jani Nikula > Cc: Daniel Vetter > Cc: Ville Syrjälä > Signed-off-by: Manasi Navare Reviewed-by: Alex Deucher > --- > drivers/gpu/drm

Re: [PATCH] drm: fallback to dma_alloc_coherent when memory encryption is active

2019-03-13 Thread Alex Deucher
On Wed, Mar 13, 2019 at 5:21 AM Christian König wrote: > > We can't just map any randome page we get when memory encryption is > active. > > Signed-off-by: Christian König Acked-by: Alex Deucher > --- > drivers/gpu/drm/drm_memory.c | 7 +++ > 1 file changed,

Re: [PATCH] MAINTAINERS: Add an entry for the vboxvideo driver

2019-03-11 Thread Alex Deucher
On Mon, Mar 11, 2019 at 12:35 PM Hans de Goede wrote: > > Add a MAINTAINERS entry for the vboxvideo driver, now that it has been > moved out of staging. > > Acked-by: Daniel Vetter > Signed-off-by: Hans de Goede Acked-by: Alex Deucher > --- > MAINTAINERS | 7

[pull] amdgpu drm-next-5.1

2019-03-07 Thread Alex Deucher
function from an fpu block (2019-03-06 15:31:20 -0500) Alex Deucher (1): drm/amdgpu/powerplay: add missing breaks in polaris10_smumgr Anthony Koo (1): drm/amd/display: Fix issue with link_active state not correct for MST

Re: [PATCH 2/7] drm/edid: Allow to ignore the audio EDID data

2019-03-05 Thread Alex Deucher
On Tue, Mar 5, 2019 at 2:15 PM Ville Syrjälä wrote: > > On Tue, Mar 05, 2019 at 05:24:13PM +0200, Ville Syrjälä wrote: > > On Tue, Mar 05, 2019 at 10:12:40AM +0100, Maxime Ripard wrote: > > > On Mon, Mar 04, 2019 at 03:05:31PM -0500, Alex Deucher wrote: > > > > On

Re: randr: Virtual monitor not present with MST display

2019-03-05 Thread Alex Deucher
On Tue, Mar 5, 2019 at 1:16 PM Paul Menzel wrote: > > Dear Linux folks, > > > Using the MST display Dell UP3214Q (two panels) with an AMD system, > the virtual monitor object is not created. GDM and Xfce consider both > panels as separate screens (`xrandr --listmonitors`). > > [0.00]

Re: [PATCH 2/7] drm/edid: Allow to ignore the audio EDID data

2019-03-04 Thread Alex Deucher
On Mon, Mar 4, 2019 at 2:53 PM Eric Anholt wrote: > > Maxime Ripard writes: > > > In some cases, in order to accomodate with displays with poor EDIDs, we > > need to ignore that the monitor alledgedly supports audio output and > > disable the audio output. > > > > Signed-off-by: Maxime Ripard >

Re: [PATCH][drm-next] drm/amdgpu: fix missing assignment of error return code to variable ret

2019-03-04 Thread Alex Deucher
On Sat, Mar 2, 2019 at 5:17 PM Colin King wrote: > > From: Colin Ian King > > An earlier commit replaced ttm_bo_wait with amdgpu_bo_sync_wait and > removed the error return assignment to variable ret. Fix this by adding > the assignment back. Also break line to clean up checkpatch overly > long

Re: [PATCH] drm/amdgpu/powerplay: Fix missing break in switch statement

2019-03-01 Thread Alex Deucher
On Fri, Mar 1, 2019 at 4:51 PM Gustavo A. R. Silva wrote: > > Add missing break statement in order to prevent the code from falling > through to case SMU_Discrete_DpmTable. > > This bug was found thanks to the ongoing efforts to enable > -Wimplicit-fallthrough. > > Fixes: 34a564eaf528

Re: [PATCH] drm/amdgpu/gfx_v8_0: Mark expected switch fall-through

2019-03-01 Thread Alex Deucher
On Fri, Mar 1, 2019 at 3:58 PM Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warning: > > drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c: In function >

Re: [PATCH] drm/ttm: Fix spelling of "KiB"

2019-03-01 Thread Alex Deucher
On Fri, Mar 1, 2019 at 3:31 AM Jakub Wilk wrote: > > The symbol for binary prefix kibi is "Ki", with uppercase K. > (In contrast, the symbol for decimal kilo is lowercase "k".) > > Signed-off-by: Jakub Wilk Applied. thanks! Alex > --- > drivers/gpu/drm/ttm/ttm_memory.c | 4 ++-- > 1 file

Re: [PATCH] drm/amd/powerplay: fix semicolon code style issue

2019-03-01 Thread Alex Deucher
On Thu, Feb 28, 2019 at 8:12 PM Yang Wei wrote: > > From: Yang Wei > > Delete superfluous semicolons. > > Signed-off-by: Yang Wei Applied. thanks! Alex > --- > drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 8 > drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c | 2 +-

Re: big conflict in drm-tip (amdgpu)

2019-03-01 Thread Alex Deucher
On Thu, Feb 28, 2019 at 12:43 PM Chris Wilson wrote: > > Quoting Alex Deucher (2019-02-28 17:25:41) > > On Thu, Feb 28, 2019 at 4:54 AM Chris Wilson > > wrote: > > > > > > Quoting Daniel Vetter (2019-02-28 09:49:51) > > > > On

Re: linux-next: manual merge of the drm tree with the drm-fixes tree

2019-03-01 Thread Alex Deucher
On Thu, Feb 28, 2019 at 9:24 PM Stephen Rothwell wrote: > > Hi all, > > Today's linux-next merge of the drm tree got a conflict in: > > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > between commit: > > d63716658ac1 ("drm/amd/display: Use vrr friendly pageflip throttling in > DC.") >

Re: big conflict in drm-tip (amdgpu)

2019-02-28 Thread Alex Deucher
On Thu, Feb 28, 2019 at 4:54 AM Chris Wilson wrote: > > Quoting Daniel Vetter (2019-02-28 09:49:51) > > On Thu, Feb 28, 2019 at 5:30 AM Dave Airlie wrote: > > > > > > I merged some fixes into drm-fixes, pushed it out, then saw tip > > > breaking, but I'm needed elsewhere, so if anyone can fix

Re: [PATCH -next] drm/amdgpu: remove set but not used variable 'vbi_time_out'

2019-02-27 Thread Alex Deucher
Applied. thanks! On Tue, Feb 26, 2019 at 12:36 AM YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/amd/amdgpu/si_dpm.c: In function 'si_program_response_times': > drivers/gpu/drm/amd/amdgpu/si_dpm.c:4101:29: warning: > variable 'backbias_response_time'

Re: [PATCH -next] drm/amdgpu: remove set but not used variables 'vm, bo'

2019-02-27 Thread Alex Deucher
Applied. thanks! On Wed, Feb 20, 2019 at 3:05 AM YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c: In function > 'update_gpuvm_pte': > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:840:20: warning: > variable 'bo' set

Re: [PATCH -next] drm/ttm: remove set but not used variable 'bdev'

2019-02-27 Thread Alex Deucher
Applied. Thanks! On Tue, Feb 19, 2019 at 3:22 AM YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/ttm/ttm_execbuf_util.c: In function > 'ttm_eu_fence_buffer_objects': > drivers/gpu/drm/ttm/ttm_execbuf_util.c:191:24: warning: > variable 'bdev' set but

Re: [PATCH] drm/amd/display: Pass app_tf by value rather than by reference

2019-02-27 Thread Alex Deucher
Applied. Sorry for the delay. Alex On Fri, Feb 22, 2019 at 10:36 AM Nathan Chancellor wrote: > > On Mon, Dec 10, 2018 at 04:42:01PM -0700, Nathan Chancellor wrote: > > Clang warns when an expression that equals zero is used as a null > > pointer constant (in lieu of NULL): > > > >

[pull] amdgpu drm-fixes-5.0

2019-02-27 Thread Alex Deucher
Hi Dave, Daniel, A fix for freesync to prevent stuttering in certain cases. Freesync was added in 5.0 so it would be nice to get this in. If not, I can just send it to stable once 5.0 is released. The following changes since commit a213c2c7e235cfc0e0a161a558f7fdf2fb3a624a: drm/amdgpu:

Re: [Intel-gfx] [RFC PATCH 00/42] Introduce memory region concept (including device local memory)

2019-02-26 Thread Alex Deucher
On Tue, Feb 26, 2019 at 12:20 PM Alex Deucher wrote: > > On Tue, Feb 26, 2019 at 7:17 AM Joonas Lahtinen > wrote: > > > > Quoting Alex Deucher (2019-02-25 21:31:43) > > > On Mon, Feb 25, 2019 at 9:35 PM Joonas Lahtinen > > > wrote: > > > &g

Re: [Intel-gfx] [RFC PATCH 00/42] Introduce memory region concept (including device local memory)

2019-02-26 Thread Alex Deucher
On Tue, Feb 26, 2019 at 7:17 AM Joonas Lahtinen wrote: > > Quoting Alex Deucher (2019-02-25 21:31:43) > > On Mon, Feb 25, 2019 at 9:35 PM Joonas Lahtinen > > wrote: > > > > > > Quoting Dave Airlie (2019-02-25 12:24:48) > > > > On Tue, 19 F

Re: [PATCH 1/1] drm/ttm: Account for kernel allocations in kernel zone only

2019-02-25 Thread Alex Deucher
On Mon, Feb 25, 2019 at 11:25 PM Kuehling, Felix wrote: > > On 2/25/2019 2:58 PM, Thomas Hellstrom wrote: > > On Mon, 2019-02-25 at 14:20 +, Koenig, Christian wrote: > >> Am 23.02.19 um 00:19 schrieb Kuehling, Felix: > >>> Don't account for them in other zones such as dma32. The kernel > >>>

Re: [Intel-gfx] [RFC PATCH 00/42] Introduce memory region concept (including device local memory)

2019-02-25 Thread Alex Deucher
On Mon, Feb 25, 2019 at 9:35 PM Joonas Lahtinen wrote: > > Quoting Dave Airlie (2019-02-25 12:24:48) > > On Tue, 19 Feb 2019 at 23:32, Joonas Lahtinen > > wrote: > > > > > > + dri-devel mailing list, especially for the buddy allocator part > > > > > > Quoting Dave Airlie (2019-02-15 02:47:07) >

Re: [PATCH libdrm] libdrm: Fix issue about differrent domainID but same BDF

2019-02-22 Thread Alex Deucher
Pushed. Thanks! Alex On Thu, Feb 21, 2019 at 9:36 PM Deng, Emily wrote: > > Hi Alex, > Please help, thanks. > > Best wishes > Emily Deng > > > > >-----Original Message- > >From: Alex Deucher > >Sent: Friday, February 22, 2019 12:13 AM >

Re: [PATCH libdrm] tests/amdgpu: add dispatch test

2019-02-22 Thread Alex Deucher
On Mon, Feb 18, 2019 at 9:26 PM Zhang, Hawking wrote: > > Although the shader is simple enough, please work with CQE to test it on all > gfx9 ASICs before push it. > > The patch is Reviewed-by: Hawking Zhang Please make sure this patch gets upstream as well. It doesn't seem to apply cleanly

[pull] amdgpu, radeon, sched drm-next-5.1

2019-02-21 Thread Alex Deucher
://people.freedesktop.org/~agd5f/linux drm-next-5.1 for you to fetch changes up to 767e06a9924162ce8ca5890533932174b04471f3: drm/amdgpu: Bump amdgpu version for context priority override. (2019-02-21 15:52:56 -0500) Alex Deucher (6

Re: [PATCH libdrm] libdrm: Fix issue about differrent domainID but same BDF

2019-02-21 Thread Alex Deucher
s the fd1 is not master privilege, then > drmSetInterfaceVersion > will fail, and then won't compare domain ID, then return the wrong fd for > Card1. > > Solution: > First loop search the best match fd about drm 1.4. > > Signed-off-by: Emily Deng Reviewed-by: Alex De

[pull] radeon and amdgpu drm-fixes-5.0

2019-02-20 Thread Alex Deucher
-fixes-5.0 for you to fetch changes up to a213c2c7e235cfc0e0a161a558f7fdf2fb3a624a: drm/amdgpu: disable bulk moves for now (2019-02-20 17:13:27 -0500) Alex Deucher (1): drm/amdgpu: Set DPM_FLAG_NEVER_SKIP when enabling PM-runtime

  1   2   3   4   5   6   7   8   9   10   >