Re: [PATCH 5/9] rtc: test: Fix invalid format specifier.

2024-02-27 Thread Alexandre Belloni
On 27/02/2024 14:23:29-0700, Shuah Khan wrote: > On 2/27/24 13:32, Alexandre Belloni wrote: > > Hello, > > > > On 21/02/2024 17:27:18+0800, David Gow wrote: > > > 'days' is a s64 (from div_s64), and so should use a %lld specifier. > > > > > > This

Re: [PATCH 5/9] rtc: test: Fix invalid format specifier.

2024-02-27 Thread Alexandre Belloni
/%02d (%2d) : %ld", \ > + #define FAIL_MSG "%d/%02d/%02d (%2d) : %lld", \ > year, month, mday, yday, days > > KUNIT_ASSERT_EQ_MSG(test, year - 1900, result.tm_year, > FAIL_MSG); > -- > 2.44.0.rc0.258.g7320e95886-goog > > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v2 2/3] dt-bindings: atmel, hlcdc: convert pwm bindings to json-schema

2024-01-16 Thread Alexandre Belloni
in is legally the same entity as free-electrons) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/pwm/atmel,hlcdc-pwm.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Atmel's HLCDC's PWM controller > > + &g

Re: [PATCH 06/17] dt-bindings: rtc: s3c-rtc: add specific compatibles for existing SoC

2023-11-08 Thread Alexandre Belloni
ree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like > compatibles. > > Signed-off-by: Krzysztof Kozlo

Re: [PATCH 5/5] spi: make remove callback a void function

2022-01-26 Thread Alexandre Belloni
return no value. This > way driver authors are not tempted to assume that passing an error to > the upper layer is a good idea. All drivers are adapted accordingly. > There is no intended change of behaviour, all callbacks were prepared to > return 0 before. > > Signed-off-by: Uwe Kleine-K

Re: [PATCH] dt-bindings: Remove "status" from schema examples

2021-07-20 Thread Alexandre Belloni
am Ravnborg > Cc: Rui Miguel Silva > Cc: Laurent Pinchart > Cc: Mauro Carvalho Chehab > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: Mark Brown > Cc: Robert Marko > Cc: Philipp Zabel > Cc: Alessandro Zummo > Cc: Alexandre Belloni > Cc: Ramesh S

Re: (subset) [PATCHv2 0/5] Support for GE B1x5v2 and B1x5Pv2

2021-05-24 Thread Alexandre Belloni
port for fixed clock commit: f765e349c3e1f2e676ad4bd61197216b26976022 Best regards, -- Alexandre Belloni

Re: [PATCHv1 1/6] rtc: m41t80: add support for protected clock

2021-02-22 Thread Alexandre Belloni
On 22/02/2021 22:20:47+0100, Alexandre Belloni wrote: > On 22/02/2021 18:12:42+0100, Sebastian Reichel wrote: > > Congatec's QMX6 system on module (SoM) uses a m41t62 as RTC. The > > modules SQW clock output defaults to 32768 Hz. This behaviour is > > used to provide the i

Re: [PATCHv1 1/6] rtc: m41t80: add support for protected clock

2021-02-22 Thread Alexandre Belloni
ware limitations and is > described in Documentation/devicetree/bindings/clock/clock-bindings.txt. > > Signed-off-by: Sebastian Reichel Acked-by: Alexandre Belloni > --- > Documentation/devicetree/bindings/rtc/rtc-m41t80.txt | 1 + > drivers/rtc/rtc-m41t80.c

Re: [GIT PULL] ib-drm-gpio-pdx86-rtc-wdt-v5.12-1

2021-02-04 Thread Alexandre Belloni
bsystem trees, > the idea about the IM branch was that all subsystem-trees would merge that. > > I can certainly point out the problem in the pdx86 pull-req to Linus, > but the GPIO pull-req also contains a merge of the IM branch as will > the x86/tip and rtc pull-reqs I believe. We can

Re: [PATCH 1/4] dt-bindings: Add missing 'unevaluatedProperties'

2020-10-08 Thread Alexandre Belloni
etree/bindings/rtc/s3c-rtc.yaml > @@ -74,6 +74,8 @@ allOf: >items: > - const: rtc > > +unevaluatedProperties: false This one can be simply additionalProperties: false -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com __

Re: [PATCH 4/4] dt-bindings: Explicitly allow additional properties in common schemas

2020-10-08 Thread Alexandre Belloni
alProperties. > > Signed-off-by: Rob Herring Acked-by: Alexandre Belloni > --- > Documentation/devicetree/bindings/arm/cpus.yaml | 2 ++ > .../devicetree/bindings/arm/nvidia,tegra194-ccplex.yaml | 2 ++ > Documentation/devicetree/bindings/ata/pata-common.yaml | 2

Re: [PATCH 1/2] dt-bindings: Clean-up schema indentation formatting

2020-04-17 Thread Alexandre Belloni
o transforms on the schema files. > > Signed-off-by: Rob Herring Acked-by: Alexandre Belloni > --- > .../devicetree/bindings/arm/altera.yaml | 6 +- > .../amlogic/amlogic,meson-gx-ao-secure.yaml | 2 +- > .../devicetree/bindings/arm/bitmain.yaml | 2 +- >

Re: [PATCH 05/46] ARM: pxa: split up mach/hardware.h

2019-10-19 Thread Alexandre Belloni
l Turquette > Cc: Stephen Boyd > Cc: Viresh Kumar > Cc: Dmitry Torokhov > Cc: Jacek Anaszewski > Cc: Pavel Machek > Cc: Ulf Hansson > Cc: Dominik Brodowski > Cc: Alexandre Belloni > Cc: Greg Kroah-Hartman > Cc: Guenter Roeck > Cc: Mark Brown > Cc: linux-...

Re: [PATCH v3] video: fbdev: atmel_lcdfb: add COMPILE_TEST support

2019-06-01 Thread Alexandre Belloni
On 30/05/2019 14:30:19+0200, Bartlomiej Zolnierkiewicz wrote: > Add COMPILE_TEST support to atmel_lcdfb driver for better compile > testing coverage. > > While at it fix improper use of UL (to silence build warnings on > x86_64). > > Cc: Alexandre Belloni Acked-by: Ale

Re: [PATCH v2] video: fbdev: atmel_lcdfb: add COMPILE_TEST support

2019-05-21 Thread Alexandre Belloni
On 21/05/2019 12:52:17+0200, Bartlomiej Zolnierkiewicz wrote: > Add COMPILE_TEST support to atmel_lcdfb driver for better compile > testing coverage. > > Signed-off-by: Bartlomiej Zolnierkiewicz Reviewed-by: Alexandre Belloni > --- > v2: add missing HAVE_CLK &&a

Re: [PATCH] video: fbdev: atmel_lcdfb: add COMPILE_TEST support

2019-04-16 Thread Alexandre Belloni
On 12/04/2019 13:29:11+0200, Bartlomiej Zolnierkiewicz wrote: > Add COMPILE_TEST support to atmel_lcdfb driver for better compile > testing coverage. > > Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Alexandre Belloni > --- > drivers/video/fbdev/Kconfig |2 +- &g

Re: [PATCH 0/7] add LCD support for SAM9X60

2019-03-01 Thread Alexandre Belloni
an you elaborate a little more which chips that are relevant. > To be able to look into the right data-sheet, while reviewing. > Link to data-sheet would be nice too. > sam9x60 is the chip name (i.e. x is not a wildcard). I don't think the datasheet is finished/public yet. -- A

[PATCH] video: fbdev: atmel_lcdfb: drop AVR and platform_data support

2019-02-26 Thread Alexandre Belloni
Make the driver OF only as since AVR32 has been removed from the kernel, there are only OF enabled platform using it. Signed-off-by: Alexandre Belloni --- drivers/video/fbdev/Kconfig | 6 +- drivers/video/fbdev/atmel_lcdfb.c | 114 ++ 2 files changed, 7

[PATCH] drm/i915: fix spelling mistake "reserverd" -> "reserved"

2018-11-21 Thread Alexandre Belloni
Fix a spelling mistake in a comment. Signed-off-by: Alexandre Belloni --- drivers/gpu/drm/i915/i915_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index f9ce35da4123..742f8ff101e4 100644

Re: [RFC PATCH 0/7] add at91sam9 LCDC DRM driver

2018-08-15 Thread Alexandre Belloni
e driver to a drm/microchip/ directory > (Then we can only hope that microchip do not change name or > are purchased by someone else). > The compatible string should remain the same but the drivers have to be mutually exclusive in Kconfig. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engine

Re: [Intel-gfx] [PATCH] drm/core: Remove drm_dev_unref() and it's uses

2018-04-27 Thread Alexandre Belloni
gle patch instead of splitting it per driver, you might want > to blame me for that. > Doesn't splitting the change per driver break bisectability unless there is a guarantee that the change in include/drm/drm_drv.h is applied after all the driver trees have been merged? -- Alexandre Bell

Re: [PATCH v2 4/5] ARM: dts: Add support for emtrion emCON-MX6 series

2017-12-29 Thread Alexandre Belloni
On 26/12/2017 at 11:16:34 -0600, Rob Herring wrote: > On Fri, Dec 22, 2017 at 4:56 AM, Alexandre Belloni > <alexandre.bell...@free-electrons.com> wrote: > > + Philippe > > > > On 22/12/2017 at 11:43:33 +0100, Andreas Färber wrote: > >> >> I'll change i

Re: [PATCH v2 4/5] ARM: dts: Add support for emtrion emCON-MX6 series

2017-12-23 Thread Alexandre Belloni
> arch/arm/boot/dts/imx6q-zii-rdu2.dts > The license is already fully included in COPYING with the warranty disclaimer. > > > > > + * > > > + * SPDX-License-Identifier: GPL-2.0 > > > > You have this. > > > > Also, the rules around this are g

Re: [PATCH v2 4/5] ARM: dts: Add support for emtrion emCON-MX6 series

2017-12-23 Thread Alexandre Belloni
DX-License-Identifier: So I think we will end up with a mix of both. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [trivial PATCH] treewide: Align function definition open/close braces

2017-12-19 Thread Alexandre Belloni
to work > properly for these modified functions. > > Miscellanea: > > o Remove extra trailing ; and blank line from xfs_agf_verify > > Signed-off-by: Joe Perches <j...@perches.com> For RTC: Acked-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> -- Alexandr

Re: [PATCH] drm/atmel-hlcdc: Fix output initialization

2017-05-18 Thread Alexandre Belloni
zero, which prevents us from probing all outputs. > > We also move the atmel_hlcdc_rgb_output allocation after the > panel/bridge detection to avoid useless allocations. > > Reported-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> Tested-by: Alexandre Belloni <

Re: [PATCH 0/8] ARM: sun8i: a33: Mali improvements

2017-02-17 Thread Alexandre Belloni
ause you must not add a driver using bindings that are not documented first. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v5 1/2] drm/bridge: Add sii902x driver

2016-06-03 Thread Alexandre Belloni
u have any suggestions, should be 'mass convert' DRM to use only > one of the two ? > 0 is an invalid irq number for any i2c devices since dab472eb931bc2916fa779e56deccd0ec319cf5b. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com

[PATCH v4 2/2] drm: panel: simple: add QiaoDian qd43003c0-40

2015-12-16 Thread Alexandre Belloni
his patch. The > v4 wasn't Cc: dri-devel, so I ended up applying v3 from patchwork. From > the changelog it seems like that's okay, though. > I think v3 didn't have the documentation at the correct place, this should be: Documentation/devicetree/bindings/display/panel/qiaodian,qd43003c0

[PATCH v2] MAINTAINERS: add a maintainer for the atmel-hlcdc DRM driver

2015-10-15 Thread Alexandre Belloni
On 13/10/2015 at 11:55:42 +0200, Boris Brezillon wrote : > Add myself as the maintainer of the atmel-hlcdc DRM driver. > > Signed-off-by: Boris Brezillon > Acked-by: Nicolas Ferre Acked-by: Alexandre Belloni -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android

[PATCH] MAINTAINERS: add maintainer for the atmel-hlcdc DRM driver

2015-10-10 Thread Alexandre Belloni
> index 797236b..11173b5 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -3591,6 +3591,13 @@ F: drivers/gpu/drm/i915/ > F: include/drm/i915* > F: include/uapi/drm/i915* > > +DRM DRIVERS FOR ATMEL_AT91 I would remove AT91 -- Alexandre Belloni, Free Electrons Emb

[PATCH v3 2/2] drm: panel: simple: add QiaoDian qd43003c0-40

2015-10-08 Thread Alexandre Belloni
From: Josh Wu <josh...@atmel.com> The QiaoDian Xianshi QD43003C0-40 is a 4"3 TFT LCD panel. Timings from the OTA5180A document, ver 0.9, section 10.1.1: http://www.orientdisplay.com/pdf/OTA5180A.pdf Signed-off-by: Josh Wu Signed-off-by: Alexandre Belloni --- .../bindings/pan

[PATCH v3 1/2] of: Add vendor prefix for QiaoDian Xianshi

2015-10-08 Thread Alexandre Belloni
Use "qiaodian" as the vendor prefix for QiaoDian Xianshi Corporation in device tree compatible strings. Signed-off-by: Alexandre Belloni --- Changes in v3: -use qiaodian as the vendor prefix as preferred by Rob Herring Documentation/devicetree/bindings/vendor-prefixes.txt | 1

[PATCH 1/2] of: Add vendor prefix for QiaoDian Xianshi

2015-10-01 Thread Alexandre Belloni
On 30/09/2015 at 17:16:10 -0500, Rob Herring wrote : > On Wed, Sep 30, 2015 at 4:42 PM, Alexandre Belloni > wrote: > > Use "qiaodian" as the vendor prefix for QiaoDian Xianshi Corporation in > > device tree compatible strings. > > > > Signed-off-by: Alexa

[PATCH 2/2] drm: panel: simple: add QiaoDian qd43003c0-40

2015-10-01 Thread Alexandre Belloni
And I forgot to add that this is V2, I've just added .bpc. On 30/09/2015 at 23:42:17 +0200, Alexandre Belloni wrote : > From: Josh Wu > > The QiaoDian Xianshi QD43003C0-40 is a 4"3 TFT LCD panel. > > Timings from the OTA5180A document, ver 0.9, sectio

[PATCH 2/2] drm: panel: simple: add QiaoDian qd43003c0-40

2015-10-01 Thread Alexandre Belloni
From: Josh Wu <josh...@atmel.com> The QiaoDian Xianshi QD43003C0-40 is a 4"3 TFT LCD panel. Timings from the OTA5180A document, ver 0.9, section 10.1.1: http://www.orientdisplay.com/pdf/OTA5180A.pdf Signed-off-by: Josh Wu Signed-off-by: Alexandre Belloni --- .../devicetree/bin

[PATCH 1/2] of: Add vendor prefix for QiaoDian Xianshi

2015-10-01 Thread Alexandre Belloni
Use "qiaodian" as the vendor prefix for QiaoDian Xianshi Corporation in device tree compatible strings. Signed-off-by: Alexandre Belloni --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindi

[PATCH] drm: panel: simple: add QiaoDian qd43003c0-40

2015-08-17 Thread Alexandre Belloni
On 17/08/2015 at 12:09:14 +0200, Thierry Reding wrote : > On Sat, Aug 01, 2015 at 12:44:31AM +0200, Alexandre Belloni wrote: > > From: Josh Wu > > > > The QiaoDian Xianshi QD43003C0-40 is a 4"3 TFT LCD panel. > > > > Timings from the OTA5180A document, v

[PATCH] drm: panel: simple: add QiaoDian qd43003c0-40

2015-08-01 Thread Alexandre Belloni
From: Josh Wu <josh...@atmel.com> The QiaoDian Xianshi QD43003C0-40 is a 4"3 TFT LCD panel. Timings from the OTA5180A document, ver 0.9, section 10.1.1: http://www.orientdisplay.com/pdf/OTA5180A.pdf Signed-off-by: Josh Wu Signed-off-by: Alexandre Belloni --- .../devicetree/bin

[PATCH v2 2/7] pwm: add support for atmel-hlcdc-pwm device

2014-06-13 Thread Alexandre Belloni
of(*chip), GFP_KERNEL); > + if (!chip) > + return -ENOMEM; > + > + chip->hlcdc = dev_get_drvdata(dev->parent); > + chip->chip.ops = _hlcdc_pwm_ops; > + chip->chip.dev = dev; > + chip->chip.base = -1; > + chip->chip.npwm = 1; > + chip->chip.of_xlate = of_pwm_xlate_with_flags; > + chip->chip.of_pwm_n_cells = 3; > + chip->chip.can_sleep = 1; > + > + ret = pwmchip_add(>chip); > + if (ret) > + return ret; > + > + platform_set_drvdata(pdev, chip); > + > + return 0; > +} > + > +static int atmel_hlcdc_pwm_remove(struct platform_device *pdev) > +{ > + struct atmel_hlcdc_pwm_chip *chip = platform_get_drvdata(pdev); > + > + return pwmchip_remove(>chip); > +} > + > +static const struct of_device_id atmel_hlcdc_pwm_dt_ids[] = { > + { .compatible = "atmel,hlcdc-pwm" }, > + { /* sentinel */ }, > +}; > + > +static struct platform_driver atmel_hlcdc_pwm_driver = { > + .driver = { > + .name = "atmel-hlcdc-pwm", > + .of_match_table = atmel_hlcdc_pwm_dt_ids, > + }, > + .probe = atmel_hlcdc_pwm_probe, > + .remove = atmel_hlcdc_pwm_remove, > +}; > +module_platform_driver(atmel_hlcdc_pwm_driver); > + > +MODULE_ALIAS("platform:atmel-hlcdc-pwm"); > +MODULE_AUTHOR("Boris Brezillon "); > +MODULE_DESCRIPTION("Atmel HLCDC PWM driver"); > +MODULE_LICENSE("GPL"); > -- > 1.8.3.2 > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com