Re: [PATCH v3 0/4] Add display support for stm32mp135f-dk board

2024-04-24 Thread Alexandre TORGUE 

Hi Raphael

On 2/23/24 13:36, Raphael Gallais-Pou wrote:

This serie aims to enable display support for the stm32mp135f-dk board

Those are only patches of the device-tree since the driver support has
already been added [1].

It respectivelly:
- adds support for the display controller on stm32mp135
- adds pinctrl for the display controller
- enables panel, backlight and display controller on
  stm32mp135f-dk

Finally it fixes the flags on the panel default mode in the
'panel-simple' driver, allowing to override the default mode by one
described in the device tree, and push further the blanking limit on the
panel.

[1] commit 1726cee3d053 ("drm/stm: ltdc: support of new hardware version")

Changes in v3:
   - [4/4] Allow every properties from panel-common in panel-simple.yaml
   - [4/4] Rewrite commit description to match changes

Changes in v2:
   - Removed already merged patches
https://lore.kernel.org/lkml/17072972.1647630.4818786052103823648.b4...@linaro.org/
https://lore.kernel.org/lkml/170729755662.1647630.425379349649657352.b4...@linaro.org/
   - Fixed CHECK_DTBS warnings
   - Added missing properties in panel-simple.yaml

Signed-off-by: Raphael Gallais-Pou 
---
Raphael Gallais-Pou (4):
   ARM: dts: stm32: add LTDC support for STM32MP13x SoC family
   ARM: dts: stm32: add LTDC pinctrl on STM32MP13x SoC family
   ARM: dts: stm32: enable display support on stm32mp135f-dk board
   dt-bindings: display: simple: allow panel-common properties

  .../bindings/display/panel/panel-simple.yaml   | 11 +
  arch/arm/boot/dts/st/stm32mp13-pinctrl.dtsi| 57 ++
  arch/arm/boot/dts/st/stm32mp135.dtsi   | 11 +
  arch/arm/boot/dts/st/stm32mp135f-dk.dts| 53 
  4 files changed, 122 insertions(+), 10 deletions(-)
---
base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
change-id: 20240124-ltdc_mp13-2f86a782424c

Best regards,


Series applied on stm32-next.

Thanks!!

Alex

Re: [drm-drm-misc:drm-misc-next v2] dt-bindings: nt35510: document 'port' property

2024-02-29 Thread Alexandre TORGUE 

Hi

On 2/25/24 10:01, Dario Binacchi wrote:

Hi,

On Wed, Feb 14, 2024 at 10:47 AM Alexandre TORGUE
 wrote:


Hi Heiko

On 1/31/24 16:53, Conor Dooley wrote:

On Wed, Jan 31, 2024 at 10:28:44AM +0100, Dario Binacchi wrote:

Allow 'port' property (coming from panel-common.yaml) to be used in DTS:

st/stm32f769-disco-mb1166-reva09.dtb: panel@0: 'port' does not match any of 
the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Dario Binacchi 
Cc: Alexandre Torgue 


Acked-by: Conor Dooley 




---

Changes in v2:
- Rework the patch to drop errors found by command
'make DT_CHECKER_FLAGS=-m dt_binding_check'.

   .../devicetree/bindings/display/panel/novatek,nt35510.yaml   | 1 +
   1 file changed, 1 insertion(+)

diff --git 
a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml 
b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
index a4afaff483b7..91921f4b0e5f 100644
--- a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
+++ b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
@@ -31,6 +31,7 @@ properties:
 vddi-supply:
   description: regulator that supplies the vddi voltage
 backlight: true
+  port: true

   required:
 - compatible
--
2.43.0



Do you plan to take this patch in drm-misc next branch ? As I have a
dependency with it to merge a DT patch I can take in my tree
(stm32-next) if you prefer. Let me know.

Cheers
Alex


It's been some weeks, so a gentle ping seems in order :)


Applied on stm32-next.

Thanks
Alex




Thanks and regards,
Dario

Re: [PATCH 0/5] Add display support for stm32mp135f-dk board

2024-02-14 Thread Alexandre TORGUE 

Hi Raphael

On 2/5/24 10:06, Raphael Gallais-Pou wrote:

This serie aims to enable display support for the stm32mp135f-dk board

Those are only patches of the device-tree since the driver support has
already been added [1].

It respectivelly:
- adds support for the display controller on stm32mp135
- adds pinctrl for the display controller
- enables panel, backlight and display controller on
  stm32mp135f-dk

Finally it fixes the flags on the panel default mode in the
'panel-simple' driver, allowing to override the default mode by one
described in the device tree, and push further the blanking limit on the
panel.

[1] commit 1726cee3d053 ("drm/stm: ltdc: support of new hardware version")

Signed-off-by: Raphael Gallais-Pou 
---
Raphael Gallais-Pou (5):
   ARM: dts: stm32: add LTDC support for STM32MP13x SoC family
   ARM: dts: stm32: add LTDC pinctrl on STM32MP13x SoC family
   ARM: dts: stm32: enable display support on stm32mp135f-dk board
   drm/panel: simple: fix flags on RK043FN48H
   drm/panel: simple: push blanking limit on RK32FN48H

  arch/arm/boot/dts/st/stm32mp13-pinctrl.dtsi | 57 +
  arch/arm/boot/dts/st/stm32mp135.dtsi| 11 ++
  arch/arm/boot/dts/st/stm32mp135f-dk.dts | 55 
  drivers/gpu/drm/panel/panel-simple.c|  7 ++--
  4 files changed, 127 insertions(+), 3 deletions(-)
---
base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
change-id: 20240124-ltdc_mp13-2f86a782424c

Best regards,


I got the following errors during YAML verification:

arch/arm/boot/dts/st/stm32mp135f-dk.dtb: /soc/i2c@40012000/pinctrl@21: 
failed to match any schema with compatible: ['microchip,mcp23017']
/local/home/frq08678/STLINUX/kernel/my-kernel/stm32/arch/arm/boot/dts/st/stm32mp135f-dk.dtb: 
panel-backlight: 'default-brightness-level' does not match any of the 
regexes: 'pinctrl-[0-9]+'
	from schema $id: 
http://devicetree.org/schemas/leds/backlight/gpio-backlight.yaml#
/local/home/frq08678/STLINUX/kernel/my-kernel/stm32/arch/arm/boot/dts/st/stm32mp135f-dk.dtb: 
panel-rgb: data-mapping:0: 'bgr666' is not one of ['jeida-18', 
'jeida-24', 'vesa-24']
	from schema $id: 
http://devicetree.org/schemas/display/panel/panel-simple.yaml#
/local/home/frq08678/STLINUX/kernel/my-kernel/stm32/arch/arm/boot/dts/st/stm32mp135f-dk.dtb: 
panel-rgb: compatible: ['rocktech,rk043fn48h', 'panel-dpi'] is too long
	from schema $id: 
http://devicetree.org/schemas/display/panel/panel-simple.yaml#
/local/home/frq08678/STLINUX/kernel/my-kernel/stm32/arch/arm/boot/dts/st/stm32mp135f-dk.dtb: 
panel-rgb: data-mapping: False schema does not allow ['bgr666']
	from schema $id: 
http://devicetree.org/schemas/display/panel/panel-simple.yaml#
/local/home/frq08678/STLINUX/kernel/my-kernel/stm32/arch/arm/boot/dts/st/stm32mp135f-dk.dtb: 
panel-rgb: 'height-mm', 'panel-timing', 'width-mm' do not match any of 
the regexes: 'pinctrl-[0-9]+'
	from schema $id: 
http://devicetree.org/schemas/display/panel/panel-simple.yaml#
/local/home/frq08678/STLINUX/kernel/my-kernel/stm32/arch/arm/boot/dts/st/stm32mp135f-dk.dtb: 
panel-rgb: 'data-mapping' does not match any of the regexes: 
'pinctrl-[0-9]+'
	from schema $id: 
http://devicetree.org/schemas/display/panel/panel-dpi.yaml#


Do I miss something ?

Alex

Re: [drm-drm-misc:drm-misc-next v2] dt-bindings: nt35510: document 'port' property

2024-02-14 Thread Alexandre TORGUE 

Hi Heiko

On 1/31/24 16:53, Conor Dooley wrote:

On Wed, Jan 31, 2024 at 10:28:44AM +0100, Dario Binacchi wrote:

Allow 'port' property (coming from panel-common.yaml) to be used in DTS:

   st/stm32f769-disco-mb1166-reva09.dtb: panel@0: 'port' does not match any of 
the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Dario Binacchi 
Cc: Alexandre Torgue 


Acked-by: Conor Dooley 




---

Changes in v2:
- Rework the patch to drop errors found by command
   'make DT_CHECKER_FLAGS=-m dt_binding_check'.

  .../devicetree/bindings/display/panel/novatek,nt35510.yaml   | 1 +
  1 file changed, 1 insertion(+)

diff --git 
a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml 
b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
index a4afaff483b7..91921f4b0e5f 100644
--- a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
+++ b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
@@ -31,6 +31,7 @@ properties:
vddi-supply:
  description: regulator that supplies the vddi voltage
backlight: true
+  port: true
  
  required:

- compatible
--
2.43.0



Do you plan to take this patch in drm-misc next branch ? As I have a 
dependency with it to merge a DT patch I can take in my tree 
(stm32-next) if you prefer. Let me know.


Cheers
Alex

Re: [PATCH v3 4/4] arm: dts: st: fix DSI peripheral clock on stm32mp15 boards

2024-01-25 Thread Alexandre TORGUE 

Hi

On 1/4/24 14:44, Raphael Gallais-Pou wrote:

In RCC driver, 'DSI_K' is a kernel clock while 'DSI' has pclk4 as parent
clock, which means that it is an APB peripheral clock. Swap the clocks
in the DSI peripheral clock reference.

Signed-off-by: Raphael Gallais-Pou 
---


After updating commit title:

Applied on stm32-next.

Thanks
Alex


  arch/arm/boot/dts/st/stm32mp157.dtsi  | 2 +-
  arch/arm/boot/dts/st/stm32mp157a-dk1-scmi.dts | 2 +-
  arch/arm/boot/dts/st/stm32mp157c-dk2-scmi.dts | 2 +-
  arch/arm/boot/dts/st/stm32mp157c-ed1-scmi.dts | 2 +-
  arch/arm/boot/dts/st/stm32mp157c-ev1-scmi.dts | 2 +-
  5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/st/stm32mp157.dtsi 
b/arch/arm/boot/dts/st/stm32mp157.dtsi
index 6197d878894d..97cd24227cef 100644
--- a/arch/arm/boot/dts/st/stm32mp157.dtsi
+++ b/arch/arm/boot/dts/st/stm32mp157.dtsi
@@ -20,7 +20,7 @@ gpu: gpu@5900 {
dsi: dsi@5a00 {
compatible = "st,stm32-dsi";
reg = <0x5a00 0x800>;
-   clocks = < DSI_K>, <_hse>, < DSI_PX>;
+   clocks = < DSI>, <_hse>, < DSI_PX>;
clock-names = "pclk", "ref", "px_clk";
phy-dsi-supply = <>;
resets = < DSI_R>;
diff --git a/arch/arm/boot/dts/st/stm32mp157a-dk1-scmi.dts 
b/arch/arm/boot/dts/st/stm32mp157a-dk1-scmi.dts
index afcd6285890c..8634699cc65e 100644
--- a/arch/arm/boot/dts/st/stm32mp157a-dk1-scmi.dts
+++ b/arch/arm/boot/dts/st/stm32mp157a-dk1-scmi.dts
@@ -30,7 +30,7 @@  {
  };
  
   {

-   clocks = < DSI_K>, <_clk CK_SCMI_HSE>, < DSI_PX>;
+   clocks = < DSI>, <_clk CK_SCMI_HSE>, < DSI_PX>;
  };
  
   {

diff --git a/arch/arm/boot/dts/st/stm32mp157c-dk2-scmi.dts 
b/arch/arm/boot/dts/st/stm32mp157c-dk2-scmi.dts
index 39358d902000..3a897fa7e167 100644
--- a/arch/arm/boot/dts/st/stm32mp157c-dk2-scmi.dts
+++ b/arch/arm/boot/dts/st/stm32mp157c-dk2-scmi.dts
@@ -36,7 +36,7 @@  {
  
   {

phy-dsi-supply = <_reg18>;
-   clocks = < DSI_K>, <_clk CK_SCMI_HSE>, < DSI_PX>;
+   clocks = < DSI>, <_clk CK_SCMI_HSE>, < DSI_PX>;
  };
  
   {

diff --git a/arch/arm/boot/dts/st/stm32mp157c-ed1-scmi.dts 
b/arch/arm/boot/dts/st/stm32mp157c-ed1-scmi.dts
index 07ea765a4553..29d6465b1fe6 100644
--- a/arch/arm/boot/dts/st/stm32mp157c-ed1-scmi.dts
+++ b/arch/arm/boot/dts/st/stm32mp157c-ed1-scmi.dts
@@ -35,7 +35,7 @@  {
  };
  
   {

-   clocks = < DSI_K>, <_clk CK_SCMI_HSE>, < DSI_PX>;
+   clocks = < DSI>, <_clk CK_SCMI_HSE>, < DSI_PX>;
  };
  
   {

diff --git a/arch/arm/boot/dts/st/stm32mp157c-ev1-scmi.dts 
b/arch/arm/boot/dts/st/stm32mp157c-ev1-scmi.dts
index 813086ec2489..5acb78f0a084 100644
--- a/arch/arm/boot/dts/st/stm32mp157c-ev1-scmi.dts
+++ b/arch/arm/boot/dts/st/stm32mp157c-ev1-scmi.dts
@@ -37,7 +37,7 @@  {
  
   {

phy-dsi-supply = <_reg18>;
-   clocks = < DSI_K>, <_clk CK_SCMI_HSE>, < DSI_PX>;
+   clocks = < DSI>, <_clk CK_SCMI_HSE>, < DSI_PX>;
  };
  
   {

Re: [RESEND PATCH v2 2/6] ARM: dts: stm32: add pin map for LTDC on stm32f7

2023-06-12 Thread Alexandre TORGUE 

hi Dario

On 6/9/23 08:21, Dario Binacchi wrote:

Hi Alexandre,

On Thu, Jun 8, 2023 at 2:42 PM Alexandre TORGUE
 wrote:


Hi Dario

On 6/7/23 08:31, Dario Binacchi wrote:

Add pin configurations for using LTDC (LCD-tft Display Controller) on
stm32f746-disco board.

Signed-off-by: Dario Binacchi 
---

(no changes since v1)

   arch/arm/boot/dts/stm32f7-pinctrl.dtsi | 35 ++
   1 file changed, 35 insertions(+)

diff --git a/arch/arm/boot/dts/stm32f7-pinctrl.dtsi 
b/arch/arm/boot/dts/stm32f7-pinctrl.dtsi
index 9f65403295ca..f3f90b9bcd61 100644
--- a/arch/arm/boot/dts/stm32f7-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stm32f7-pinctrl.dtsi
@@ -365,6 +365,41 @@ pins2 {
   bias-pull-up;
   };
   };
+
+
+ ltdc_pins_a: ltdc-pins-a-0 {


   ltdc-pins-a-0 -->  ltdc-pins-0 is a bit cleaner. I know that I have to
fix sdio pins nodes in this file to keep the same spirit for all group
names.


I have looked at the file arch/arm/boot/dts/stm32f7-pinctrl.dtsi, and
based on the following nodes:
usart1_pins_a: usart1-0
i2c1_pins_b: i2c1-0
can1_pins_a: can1-0

I have decided to rename ltdc-pins-a-0 to ltdc-0.

I hope you agree.


Yes! perfect.

Alex



Thanks and regards,

Dario



If there is no V3 I wil do it directly when I'll apply DT patches if you
agree.

Alex



+ pins {
+ pinmux = , /* 
LCD_B0 */
+  ,  /* 
LCD_B4 */
+  , /* 
LCD_VSYNC */
+  , /* 
LCD_HSYNC */
+  , /* 
LCD_CLK */
+  , /* 
LCD_R0 */
+  , /* 
LCD_R1 */
+  , /* 
LCD_R2 */
+  , /* 
LCD_R3 */
+  , /* 
LCD_R4 */
+  , /* 
LCD_R5 */
+  , /* 
LCD_R6 */
+  , /* 
LCD_R7 */
+  , /* 
LCD_G0 */
+  , /* 
LCD_G1 */
+  , /* 
LCD_G2 */
+  , /* 
LCD_G3 */
+  , /* 
LCD_G4 */
+  , /* 
LCD_B1 */
+  , /* 
LCD_B2 */
+  , /* 
LCD_B3 */
+  , /* 
LCD_G5 */
+  , /* 
LCD_G6 */
+  , /* 
LCD_G7 */
+  , /* 
LCD_B5 */
+  , /* 
LCD_B6 */
+  , /* 
LCD_B7 */
+  ; /* 
LCD_DE */
+ slew-rate = <2>;
+ };
+ };
   };
   };
   };

Re: [RESEND PATCH v2 2/6] ARM: dts: stm32: add pin map for LTDC on stm32f7

2023-06-08 Thread Alexandre TORGUE 

Hi Dario

On 6/7/23 08:31, Dario Binacchi wrote:

Add pin configurations for using LTDC (LCD-tft Display Controller) on
stm32f746-disco board.

Signed-off-by: Dario Binacchi 
---

(no changes since v1)

  arch/arm/boot/dts/stm32f7-pinctrl.dtsi | 35 ++
  1 file changed, 35 insertions(+)

diff --git a/arch/arm/boot/dts/stm32f7-pinctrl.dtsi 
b/arch/arm/boot/dts/stm32f7-pinctrl.dtsi
index 9f65403295ca..f3f90b9bcd61 100644
--- a/arch/arm/boot/dts/stm32f7-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stm32f7-pinctrl.dtsi
@@ -365,6 +365,41 @@ pins2 {
bias-pull-up;
};
};
+
+
+   ltdc_pins_a: ltdc-pins-a-0 {


 ltdc-pins-a-0 -->  ltdc-pins-0 is a bit cleaner. I know that I have to 
fix sdio pins nodes in this file to keep the same spirit for all group 
names.


If there is no V3 I wil do it directly when I'll apply DT patches if you 
agree.


Alex



+   pins {
+   pinmux = , 
/* LCD_B0 */
+,  
/* LCD_B4 */
+, 
/* LCD_VSYNC */
+, 
/* LCD_HSYNC */
+, 
/* LCD_CLK */
+, 
/* LCD_R0 */
+, 
/* LCD_R1 */
+, 
/* LCD_R2 */
+, 
/* LCD_R3 */
+, 
/* LCD_R4 */
+, 
/* LCD_R5 */
+, 
/* LCD_R6 */
+, 
/* LCD_R7 */
+, 
/* LCD_G0 */
+, 
/* LCD_G1 */
+, 
/* LCD_G2 */
+, 
/* LCD_G3 */
+, 
/* LCD_G4 */
+, 
/* LCD_B1 */
+, 
/* LCD_B2 */
+, 
/* LCD_B3 */
+, 
/* LCD_G5 */
+, 
/* LCD_G6 */
+, 
/* LCD_G7 */
+, 
/* LCD_B5 */
+, 
/* LCD_B6 */
+, 
/* LCD_B7 */
+; 
/* LCD_DE */
+   slew-rate = <2>;
+   };
+   };
};
};
  };

Re: [PATCH v4 2/4] dt-bindings: display: st,stm32-dsi: Remove unnecessary fields

2023-05-30 Thread Alexandre TORGUE 

On 5/30/23 14:27, Krzysztof Kozlowski wrote:

On Mon, 29 May 2023 11:13:57 +0200, Raphael Gallais-Pou wrote:

"#address-cells" and "#size-cells" are two properties that are not
mandatory. For instance, the DSI could refer to a bridge outside the scope
of the node rather than include a 'panel@0' subnode. By doing so, address
and size fields become then unnecessary, creating a warning at build time.

Signed-off-by: Raphael Gallais-Pou 
Acked-by: Conor Dooley 
Reviewed-by: Marek Vasut 
---
  Documentation/devicetree/bindings/display/st,stm32-dsi.yaml | 2 --
  1 file changed, 2 deletions(-)



Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings
I checked it before merging the series on stm32-next tree. I didn't get 
this error. I didn't check commit per commit.


Do you get this error after merging the whole series ?




Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/1787034


dsi@40016c00: Unevaluated properties are not allowed ('panel-dsi@0' was 
unexpected)
arch/arm/boot/dts/stm32f469-disco.dtb

dsi@5a00: Unevaluated properties are not allowed ('panel-dsi@0' was 
unexpected)
arch/arm/boot/dts/stm32mp157c-ev1.dtb
arch/arm/boot/dts/stm32mp157c-ev1-scmi.dtb

Re: [PATCH v4 0/4] STM32 warning cleanup

2023-05-30 Thread Alexandre TORGUE 

Hi Raphael

On 5/29/23 11:13, Raphael Gallais-Pou wrote:

This serie aims to reduce the number of device-tree warnings of
following boards :

   - STM32F469-DISCO
   - STM32MP15*

Those warnings were appearing either during build or when checking
dt-bindings and concern mostly LTDC and DSI IPs. They were due to the
following cases:

   - 'panel-dsi@0' instead of 'panel@0' according to the YAML
   - unnecessary #address-cells and #size-cells properties
   - residual 'reg' field on single endpoints

First patch fixes stm32f469-disco device-tree.
Second patch fixes st,stm32-dsi.yaml dt-bindings.
Third patch fixes DSI warnings on stm32mp15* device-trees.
Last patch fixes LTDC warnings on stm32mp15* device-trees.

Changes since v3:
* Added Conor's acked-by
* Added Marek's reviewed-by
* Split last patch into two separate for clearer review

Changes since v2:
* Added changelog
* Enhanced commit descriptions

Changes since v1:
* Added DSI subnode name change
* Included stm32f469-disco DT in the cleanup
* Included YAML fix to prevent regression

Raphael Gallais-Pou (4):
   ARM: dts: stm32: fix warnings on stm32f469-disco board
   dt-bindings: display: st,stm32-dsi: Remove unnecessary fields
   ARM: dts: stm32: fix dsi warnings on stm32mp15 boards
   ARM: dts: stm32: fix ltdc warnings in stm32mp15 boards

  .../bindings/display/st,stm32-dsi.yaml|  2 --
  arch/arm/boot/dts/stm32f469-disco.dts |  4 ++--
  arch/arm/boot/dts/stm32mp151.dtsi |  5 -
  arch/arm/boot/dts/stm32mp157.dtsi |  7 ---
  arch/arm/boot/dts/stm32mp157a-dk1.dts | 20 +++
  ...tm32mp157a-icore-stm32mp1-ctouch2-of10.dts |  6 --
  .../stm32mp157a-icore-stm32mp1-edimm2.2.dts   |  6 --
  ...157a-microgea-stm32mp1-microdev2.0-of7.dts |  3 +--
  arch/arm/boot/dts/stm32mp157c-dk2.dts |  8 
  arch/arm/boot/dts/stm32mp157c-ev1.dts | 10 +++---
  arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts |  3 +--
  .../boot/dts/stm32mp15xx-dhcor-avenger96.dtsi |  6 +-
  arch/arm/boot/dts/stm32mp15xx-dkx.dtsi| 18 +
  13 files changed, 49 insertions(+), 49 deletions(-)



Thanks for this series! No more W=1 Warnings and no more YAML issue 
regarding DSI/LTDC stuff. Thanks Marek for reviews and feedback.


Series applied on stm32-next.

Cheers
Alx

Re: [PATCH v3 6/6] ARM: dts: stm32: Use new media bus type macros

2023-01-17 Thread Alexandre TORGUE 

Hi Laurent

On 6/16/22 00:14, Laurent Pinchart wrote:

Now that a header exists with macros for the media interface bus-type
values, replace hardcoding numerical constants with the corresponding
macros in the DT sources.

Signed-off-by: Laurent Pinchart 



Applied on stm32-next.

Thanks.
Alex

Re: [PATCH v3 6/6] ARM: dts: stm32: Use new media bus type macros

2023-01-17 Thread Alexandre TORGUE 

Hi Laurent

On 1/14/23 16:36, Laurent Pinchart wrote:

Hugues, Maxime, Alexandre, could one of you take this patch in your tree
for v6.3 ? The two patches that it depends on have both been merged in
v6.2.


Yes sure.

Cheers
Alex



On Thu, Jun 16, 2022 at 01:14:10AM +0300, Laurent Pinchart wrote:

Now that a header exists with macros for the media interface bus-type
values, replace hardcoding numerical constants with the corresponding
macros in the DT sources.

Signed-off-by: Laurent Pinchart 
---
  arch/arm/boot/dts/stm32429i-eval.dts  | 3 ++-
  arch/arm/boot/dts/stm32mp157c-ev1.dts | 3 ++-
  2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/stm32429i-eval.dts 
b/arch/arm/boot/dts/stm32429i-eval.dts
index 0d98aca01736..5fae11e6607b 100644
--- a/arch/arm/boot/dts/stm32429i-eval.dts
+++ b/arch/arm/boot/dts/stm32429i-eval.dts
@@ -50,6 +50,7 @@
  #include "stm32f429-pinctrl.dtsi"
  #include 
  #include 
+#include 
  
  / {

model = "STMicroelectronics STM32429i-EVAL board";
@@ -186,7 +187,7 @@  {
port {
dcmi_0: endpoint {
remote-endpoint = <_0>;
-   bus-type = <5>;
+   bus-type = ;
bus-width = <8>;
hsync-active = <0>;
vsync-active = <0>;
diff --git a/arch/arm/boot/dts/stm32mp157c-ev1.dts 
b/arch/arm/boot/dts/stm32mp157c-ev1.dts
index d142dd30e16b..306d41a6138f 100644
--- a/arch/arm/boot/dts/stm32mp157c-ev1.dts
+++ b/arch/arm/boot/dts/stm32mp157c-ev1.dts
@@ -8,6 +8,7 @@
  #include "stm32mp157c-ed1.dts"
  #include 
  #include 
+#include 
  
  / {

model = "STMicroelectronics STM32MP157C eval daughter on eval mother";
@@ -90,7 +91,7 @@  {
port {
dcmi_0: endpoint {
remote-endpoint = <_0>;
-   bus-type = <5>;
+   bus-type = ;
bus-width = <8>;
hsync-active = <0>;
vsync-active = <0>;

Re: [PATCH v2 3/3] ARM: dts: Use new media bus type macros

2022-04-07 Thread Alexandre TORGUE 

On 4/7/22 15:31, Laurent Pinchart wrote:

Hi Alexandre,

On Thu, Apr 07, 2022 at 02:41:58PM +0200, Alexandre TORGUE wrote:

On 3/6/22 18:39, Laurent Pinchart wrote:

Now that a header exists with macros for the media interface bus-type
values, replace hardcoding numerical constants with the corresponding
macros in the DT sources.

Signed-off-by: Laurent Pinchart 
---
   arch/arm/boot/dts/imx6ul-14x14-evk.dtsi   |  4 +++-
   arch/arm/boot/dts/omap3-n900.dts  |  5 +++--
   arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts   | 11 +++
   .../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi |  4 +++-
   .../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi |  4 +++-
   arch/arm/boot/dts/stm32429i-eval.dts  |  3 ++-
   arch/arm/boot/dts/stm32mp157c-ev1.dts |  3 ++-
   7 files changed, 23 insertions(+), 11 deletions(-)


sorry for this late answer. Is it possible to split ARM DT patches by
vendor ?


Sure. Is that only to ease backporting, or do you want the ST part to be
merged through a different tree ?


I usually take all STM32 DT patches in my stm32-next branch. It's to 
avoid merge issue at arm-soc maintainer level.


thanks
alex


diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi 
b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
index a3fde3316c73..89234bbd02f4 100644
--- a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
+++ b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
@@ -2,6 +2,8 @@
   //
   // Copyright (C) 2015 Freescale Semiconductor, Inc.
   
+#include 

+
   / {
chosen {
stdout-path = 
@@ -170,7 +172,7 @@  {
port {
parallel_from_ov5640: endpoint {
remote-endpoint = <_to_parallel>;
-   bus-type = <5>; /* Parallel bus */
+   bus-type = ;
};
};
   };
diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
index d40c3d2c4914..9cad9d6a83e2 100644
--- a/arch/arm/boot/dts/omap3-n900.dts
+++ b/arch/arm/boot/dts/omap3-n900.dts
@@ -9,6 +9,7 @@
   #include "omap34xx.dtsi"
   #include 
   #include 
+#include 
   
   /*

* Default secure signed bootloader (Nokia X-Loader) does not enable L3 
firewall
@@ -194,7 +195,7 @@ port@1 {
   
   			csi_isp: endpoint {

remote-endpoint = <_cam1>;
-   bus-type = <3>; /* CCP2 */
+   bus-type = ;
clock-lanes = <1>;
data-lanes = <0>;
lane-polarity = <0 0>;
@@ -835,7 +836,7 @@ cam1: camera@3e {
   
   		port {

csi_cam1: endpoint {
-   bus-type = <3>; /* CCP2 */
+   bus-type = ;
strobe = <1>;
clock-inv = <0>;
crc = <1>;
diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts 
b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
index 3c8a7c8b1fdd..1043603fc4a5 100644
--- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
+++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
@@ -7,6 +7,9 @@
*/
   
   /dts-v1/;

+
+#include 
+
   #include "r8a7742-iwg21d-q7.dts"
   
   / {

@@ -242,7 +245,7 @@ port {
vin0ep: endpoint {
remote-endpoint = <>;
bus-width = <8>;
-   bus-type = <6>;
+   bus-type = ;
};
};
   };
@@ -273,7 +276,7 @@ port {
vin1ep: endpoint {
remote-endpoint = <>;
bus-width = <8>;
-   bus-type = <6>;
+   bus-type = ;
};
};
   };
@@ -305,7 +308,7 @@ vin2ep: endpoint {
remote-endpoint = <>;
bus-width = <8>;
data-shift = <8>;
-   bus-type = <6>;
+   bus-type = ;
};
};
   };
@@ -335,7 +338,7 @@ port {
vin3ep: endpoint {
remote-endpoint = <>;
bus-width = <8>;
-   bus-type = <6>;
+   bus-type = ;
};
};
   };
diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi 
b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
index 40cef0b1d1e6..c73160df619d 100644
--- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
+++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
@@ -7,6 +7,8 @@
* Copyright (C) 2020 Renesas Electronics Corp.
*/
   
+#include

Re: [PATCH v2 3/3] ARM: dts: Use new media bus type macros

2022-04-07 Thread Alexandre TORGUE 

Hi Laurent

On 3/6/22 18:39, Laurent Pinchart wrote:

Now that a header exists with macros for the media interface bus-type
values, replace hardcoding numerical constants with the corresponding
macros in the DT sources.

Signed-off-by: Laurent Pinchart 
---
  arch/arm/boot/dts/imx6ul-14x14-evk.dtsi   |  4 +++-
  arch/arm/boot/dts/omap3-n900.dts  |  5 +++--
  arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts   | 11 +++
  .../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi |  4 +++-
  .../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi |  4 +++-
  arch/arm/boot/dts/stm32429i-eval.dts  |  3 ++-
  arch/arm/boot/dts/stm32mp157c-ev1.dts |  3 ++-
  7 files changed, 23 insertions(+), 11 deletions(-)



sorry for this late answer. Is it possible to split ARM DT patches by 
vendor ?


Thanks
Alex



diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi 
b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
index a3fde3316c73..89234bbd02f4 100644
--- a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
+++ b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
@@ -2,6 +2,8 @@
  //
  // Copyright (C) 2015 Freescale Semiconductor, Inc.
  
+#include 

+
  / {
chosen {
stdout-path = 
@@ -170,7 +172,7 @@  {
port {
parallel_from_ov5640: endpoint {
remote-endpoint = <_to_parallel>;
-   bus-type = <5>; /* Parallel bus */
+   bus-type = ;
};
};
  };
diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
index d40c3d2c4914..9cad9d6a83e2 100644
--- a/arch/arm/boot/dts/omap3-n900.dts
+++ b/arch/arm/boot/dts/omap3-n900.dts
@@ -9,6 +9,7 @@
  #include "omap34xx.dtsi"
  #include 
  #include 
+#include 
  
  /*

   * Default secure signed bootloader (Nokia X-Loader) does not enable L3 
firewall
@@ -194,7 +195,7 @@ port@1 {
  
  			csi_isp: endpoint {

remote-endpoint = <_cam1>;
-   bus-type = <3>; /* CCP2 */
+   bus-type = ;
clock-lanes = <1>;
data-lanes = <0>;
lane-polarity = <0 0>;
@@ -835,7 +836,7 @@ cam1: camera@3e {
  
  		port {

csi_cam1: endpoint {
-   bus-type = <3>; /* CCP2 */
+   bus-type = ;
strobe = <1>;
clock-inv = <0>;
crc = <1>;
diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts 
b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
index 3c8a7c8b1fdd..1043603fc4a5 100644
--- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
+++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
@@ -7,6 +7,9 @@
   */
  
  /dts-v1/;

+
+#include 
+
  #include "r8a7742-iwg21d-q7.dts"
  
  / {

@@ -242,7 +245,7 @@ port {
vin0ep: endpoint {
remote-endpoint = <>;
bus-width = <8>;
-   bus-type = <6>;
+   bus-type = ;
};
};
  };
@@ -273,7 +276,7 @@ port {
vin1ep: endpoint {
remote-endpoint = <>;
bus-width = <8>;
-   bus-type = <6>;
+   bus-type = ;
};
};
  };
@@ -305,7 +308,7 @@ vin2ep: endpoint {
remote-endpoint = <>;
bus-width = <8>;
data-shift = <8>;
-   bus-type = <6>;
+   bus-type = ;
};
};
  };
@@ -335,7 +338,7 @@ port {
vin3ep: endpoint {
remote-endpoint = <>;
bus-width = <8>;
-   bus-type = <6>;
+   bus-type = ;
};
};
  };
diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi 
b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
index 40cef0b1d1e6..c73160df619d 100644
--- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
+++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
@@ -7,6 +7,8 @@
   * Copyright (C) 2020 Renesas Electronics Corp.
   */
  
+#include 

+
  #define CAM_ENABLED   1
  
  _PARENT_I2C {

@@ -26,7 +28,7 @@ port {
CAM_EP: endpoint {
bus-width = <8>;
data-shift = <2>;
-   bus-type = <6>;
+   bus-type = ;
pclk-sample = <1>;
remote-endpoint = <_EP>;
};
diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi

Re: [PATCH v4 2/3] ARM: dts: stm32: fix dtbs_check warning on ili9341 dts binding

2021-11-25 Thread Alexandre TORGUE 

Hi Dillon

On 7/24/21 5:44 AM, dillon.min...@gmail.com wrote:

From: Dillon Min 

Since the compatible string defined from ilitek,ili9341.yaml is
"st,sf-tc240t-9370-t", "ilitek,ili9341"

so, append "ilitek,ili9341" to avoid the below dtbs_check warning.

arch/arm/boot/dts/stm32f429-disco.dt.yaml: display@1: compatible:
['st,sf-tc240t-9370-t'] is too short

Fixes: a726e2f000ec ("ARM: dts: stm32: enable ltdc binding with ili9341, gyro l3gd20 
on stm32429-disco board")
Signed-off-by: Dillon Min 
Reported-by: kernel test robot 
---
v4: no change.

  arch/arm/boot/dts/stm32f429-disco.dts | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/stm32f429-disco.dts 
b/arch/arm/boot/dts/stm32f429-disco.dts
index 075ac57d0bf4..6435e099c632 100644
--- a/arch/arm/boot/dts/stm32f429-disco.dts
+++ b/arch/arm/boot/dts/stm32f429-disco.dts
@@ -192,7 +192,7 @@
  
  	display: display@1{

/* Connect panel-ilitek-9341 to ltdc */
-   compatible = "st,sf-tc240t-9370-t";
+   compatible = "st,sf-tc240t-9370-t", "ilitek,ili9341";
reg = <1>;
spi-3wire;
spi-max-frequency = <1000>;



Patch applied on stm32-next. I updated commit title to indicate targeted 
board.


regards
Alex

Re: [PATCH v4 2/3] ARM: dts: stm32: fix dtbs_check warning on ili9341 dts binding

2021-08-05 Thread Alexandre TORGUE 

Hi Dillon

On 8/5/21 11:19 AM, Dillon Min wrote:

Hi Linus

Thanks.

On Thu, 5 Aug 2021 at 17:11, Linus Walleij  wrote:


On Sat, Jul 24, 2021 at 5:44 AM  wrote:


From: Dillon Min 

Since the compatible string defined from ilitek,ili9341.yaml is
"st,sf-tc240t-9370-t", "ilitek,ili9341"

so, append "ilitek,ili9341" to avoid the below dtbs_check warning.

arch/arm/boot/dts/stm32f429-disco.dt.yaml: display@1: compatible:
['st,sf-tc240t-9370-t'] is too short

Fixes: a726e2f000ec ("ARM: dts: stm32: enable ltdc binding with ili9341, gyro l3gd20 
on stm32429-disco board")
Signed-off-by: Dillon Min 
Reported-by: kernel test robot 
---
v4: no change.


Reviewed-by: Linus Walleij 

Please funnel this patch through the STM and ARM SoC tree.


Sure, I will let Alex know. Thanks for your help on this driver.

Hi Alex,
Should I send v5 with Linus's Reviewed-by tag on this patch? thanks.


No, I'll do it.

cheers
alex



Best Regards
Dillon



Yours,
Linus Walleij

Re: [PATCH] ARM: multi_v7_defconfig: add STM32 CEC support

2021-01-26 Thread Alexandre TORGUE 

Hi Yannick

On 1/15/21 3:32 PM, Yannick Fertre wrote:

Enable CEC support for STMicroelectronics as loadable module.

Signed-off-by: Yannick Fertre 
---
  arch/arm/configs/multi_v7_defconfig | 1 +
  1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/multi_v7_defconfig 
b/arch/arm/configs/multi_v7_defconfig
index c5f25710fedc..05cc0607a9ad 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -656,6 +656,7 @@ CONFIG_V4L_TEST_DRIVERS=y
  CONFIG_VIDEO_VIVID=m
  CONFIG_CEC_PLATFORM_DRIVERS=y
  CONFIG_CEC_SAMSUNG_S5P=m
+CONFIG_CEC_STM32=m
  CONFIG_VIDEO_ADV7180=m
  CONFIG_VIDEO_ADV7604=m
  CONFIG_VIDEO_ADV7604_CEC=y



Applied on stm32-next.

Thanks.
Alex
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v5 0/8] Enable ili9341 and l3gd20 on stm32f429-disco

2020-07-21 Thread Alexandre Torgue 



On 7/21/20 2:55 PM, dillon min wrote:

Hi, Alexandre,


On Tue, Jul 21, 2020 at 7:54 PM Alexandre Torgue
 wrote:




On 7/21/20 12:39 PM, dillon min wrote:

Hi Alexandre,

On Tue, Jul 21, 2020 at 5:19 PM Alexandre Torgue
 wrote:


Hi Dillon

On 5/25/20 5:40 AM, dillon.min...@gmail.com wrote:

From: dillon min 

V5's update based on Mark Brown's suggestion, use 'SPI_MASTER_MUST_RX'
for SPI_SIMPLEX_RX mode on stm32 spi controller.

V5:
1 instead of add send dummy data out under SIMPLEX_RX mode,
  add flags 'SPI_CONTROLLER_MUST_TX' for stm32 spi driver
2 bypass 'SPI_CONTROLLER_MUST_TX' and 'SPI_CONTROLLER_MUST_RX' under
'SPI_3WIRE' mode



Concerning DT patches, they look goods for me. However I'll merge them
when drivers parts will be merged.

regards
Alex

This patchset status is :
dts:
  ARM: dts: stm32: Add dma config for spi5
  ARM: dts: stm32: Add pin map for ltdc & spi5 on stm32f429-disco board
  ARM: dts: stm32: enable ltdc binding with ili9341, gyro l3gd20 on
stm32429-disco board

panel-bindings: Reviewed-by: Rob Herring， need more reviewing to merge
  dt-bindings: display: panel: Add ilitek ili9341 panel bindings

clk: Acked-by: Stephen Boyd , need more reviewing to merge
  clk: stm32: Fix stm32f429's ltdc driver hang in set clock rate,
fix duplicated ltdc clock register to 'clk_core' case ltdc's clock
  turn off by clk_disable_unused()

drm-panel:  Reviewed-by: Linus Walleij . need more reviewing to merge
  drm/panel: Add ilitek ili9341 panel driver

spi-driver: Acked-by: Mark Brown ，merged into mainline
  spi: stm32: Add 'SPI_SIMPLEX_RX', 'SPI_3WIRE_RX' support for stm32f4
  spi: flags 'SPI_CONTROLLER_MUST_RX' and 'SPI_CONTROLLER_MUST_TX' can't
becoexit with 'SPI_3WIRE' mode

For ili9341 drivers, it seems to need more time to review, or might be dropped.
since the drm maintainer might create a new interface to support
DPI,DBI,DSI in one driver.
Currently it's under discussion. I will rework the ili9341 driver after that.

But, we can use the existing "drivers/gpu/drm/tiny/ili9341.c" driver to support
ili9341 on stm32f429-disco board only using the spi bus. except the
display refresh performance is not as good as the ltdc interface.

I can submit a new patch just with dts changed this week for it, if you need.




Thanks for this status. I'm close to send my PR for v5.9. There is no
needs to have an intermediate version (Except you absolutely want it).

Thanks
alex

Ok, I prefer to use the ltdc interface to drive ili9341 either.


Ok, so let's wait for the full review of this series.

Cheers
Alex



Thanks,
Dillon.



Thanks,
Dillon.





V4:
According to alexandre torgue's suggestion, combine ili9341 and
l3gd20's modification on stm32f429-disco board to one patchset.

Changes:

ili9341:

1 update ili9341 panel driver according to Linus's suggestion
2 drop V1's No.5 patch, sumbit new changes for clk-stm32f4
3 merge l3gd20's change to this patchset

V3:
1 merge original tiny/ili9341.c driver to panel/panel-ilitek-ili9341.c
 to support serial spi & parallel rgb interface in one driver.
2 update ilitek,ili9341.yaml dts binding documentation.
3 update stm32f429-disco dts binding

V2:
1 verify ilitek,ili9341.yaml with make O=../linux-stm32
 dt_binding_check
 DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/panel/
 ilitek,ili9341.yaml

V1:
1 add ili9341 drm panel driver
2 add ltdc, spi5 controller for stm32f429-disco
3 add ltdc, spi5 pin map for stm32f429-disco
4 add docs about ili9341
5 fix ltdc driver loading hang in clk set rate bug


L3gd20:
V3:
1 merge stm32f429-disco dtbs binding with ili9341 part

V2:
1 insert blank line at stm32f420-disco.dts line 143
2 add more description for l3gd20 in commit message

V1:
1 enable spi5 controller on stm32f429-disco (dts)
2 add spi5 pinmap for stm32f429-disco  (dts)
3 add SPI_SIMPLEX_RX, SPI_3WIRE_RX support for stm32f4


dillon min (8):
 ARM: dts: stm32: Add dma config for spi5
 ARM: dts: stm32: Add pin map for ltdc & spi5 on stm32f429-disco board
 ARM: dts: stm32: enable ltdc binding with ili9341, gyro l3gd20 on
   stm32429-disco board
 dt-bindings: display: panel: Add ilitek ili9341 panel bindings
 clk: stm32: Fix stm32f429's ltdc driver hang in set clock rate,
   fix duplicated ltdc clock register to 'clk_core' case ltdc's clock
 turn off by clk_disable_unused()
 drm/panel: Add ilitek ili9341 panel driver
 spi: stm32: Add 'SPI_SIMPLEX_RX', 'SPI_3WIRE_RX' support for stm32f4
 spi: flags 'SPI_CONTROLLER_MUST_RX' and 'SPI_CONTROLLER_MUST_TX' can't
   be coexit with 'SPI_3WIRE' mode

.../bindings/display/panel/ilitek,ili9341.yaml |   69 ++
arch/arm/boot/dts/stm32f4-pinctrl.dtsi |   67 +
arch/arm/boot/dts/stm32f429-disco.dts  |   48 +
arch/arm/boot/dts/stm32f429.dtsi   |3 +
drivers/clk/clk-stm32f4.c

Re: [PATCH v5 0/8] Enable ili9341 and l3gd20 on stm32f429-disco

2020-07-21 Thread Alexandre Torgue 



On 7/21/20 12:39 PM, dillon min wrote:

Hi Alexandre,

On Tue, Jul 21, 2020 at 5:19 PM Alexandre Torgue
 wrote:


Hi Dillon

On 5/25/20 5:40 AM, dillon.min...@gmail.com wrote:

From: dillon min 

V5's update based on Mark Brown's suggestion, use 'SPI_MASTER_MUST_RX'
for SPI_SIMPLEX_RX mode on stm32 spi controller.

V5:
1 instead of add send dummy data out under SIMPLEX_RX mode,
 add flags 'SPI_CONTROLLER_MUST_TX' for stm32 spi driver
2 bypass 'SPI_CONTROLLER_MUST_TX' and 'SPI_CONTROLLER_MUST_RX' under
'SPI_3WIRE' mode



Concerning DT patches, they look goods for me. However I'll merge them
when drivers parts will be merged.

regards
Alex

This patchset status is :
dts:
 ARM: dts: stm32: Add dma config for spi5
 ARM: dts: stm32: Add pin map for ltdc & spi5 on stm32f429-disco board
 ARM: dts: stm32: enable ltdc binding with ili9341, gyro l3gd20 on
   stm32429-disco board

panel-bindings: Reviewed-by: Rob Herring， need more reviewing to merge
 dt-bindings: display: panel: Add ilitek ili9341 panel bindings

clk: Acked-by: Stephen Boyd , need more reviewing to merge
 clk: stm32: Fix stm32f429's ltdc driver hang in set clock rate,
   fix duplicated ltdc clock register to 'clk_core' case ltdc's clock
 turn off by clk_disable_unused()

drm-panel:  Reviewed-by: Linus Walleij . need more reviewing to merge
 drm/panel: Add ilitek ili9341 panel driver

spi-driver: Acked-by: Mark Brown ，merged into mainline
 spi: stm32: Add 'SPI_SIMPLEX_RX', 'SPI_3WIRE_RX' support for stm32f4
 spi: flags 'SPI_CONTROLLER_MUST_RX' and 'SPI_CONTROLLER_MUST_TX' can't
   becoexit with 'SPI_3WIRE' mode

For ili9341 drivers, it seems to need more time to review, or might be dropped.
since the drm maintainer might create a new interface to support
DPI,DBI,DSI in one driver.
Currently it's under discussion. I will rework the ili9341 driver after that.

But, we can use the existing "drivers/gpu/drm/tiny/ili9341.c" driver to support
ili9341 on stm32f429-disco board only using the spi bus. except the
display refresh performance is not as good as the ltdc interface.

I can submit a new patch just with dts changed this week for it, if you need.




Thanks for this status. I'm close to send my PR for v5.9. There is no 
needs to have an intermediate version (Except you absolutely want it).


Thanks
alex


Thanks,
Dillon.





V4:
According to alexandre torgue's suggestion, combine ili9341 and
l3gd20's modification on stm32f429-disco board to one patchset.

Changes:

ili9341:

1 update ili9341 panel driver according to Linus's suggestion
2 drop V1's No.5 patch, sumbit new changes for clk-stm32f4
3 merge l3gd20's change to this patchset

V3:
1 merge original tiny/ili9341.c driver to panel/panel-ilitek-ili9341.c
to support serial spi & parallel rgb interface in one driver.
2 update ilitek,ili9341.yaml dts binding documentation.
3 update stm32f429-disco dts binding

V2:
1 verify ilitek,ili9341.yaml with make O=../linux-stm32
dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/panel/
ilitek,ili9341.yaml

V1:
1 add ili9341 drm panel driver
2 add ltdc, spi5 controller for stm32f429-disco
3 add ltdc, spi5 pin map for stm32f429-disco
4 add docs about ili9341
5 fix ltdc driver loading hang in clk set rate bug


L3gd20:
V3:
1 merge stm32f429-disco dtbs binding with ili9341 part

V2:
1 insert blank line at stm32f420-disco.dts line 143
2 add more description for l3gd20 in commit message

V1:
1 enable spi5 controller on stm32f429-disco (dts)
2 add spi5 pinmap for stm32f429-disco  (dts)
3 add SPI_SIMPLEX_RX, SPI_3WIRE_RX support for stm32f4


dillon min (8):
ARM: dts: stm32: Add dma config for spi5
ARM: dts: stm32: Add pin map for ltdc & spi5 on stm32f429-disco board
ARM: dts: stm32: enable ltdc binding with ili9341, gyro l3gd20 on
  stm32429-disco board
dt-bindings: display: panel: Add ilitek ili9341 panel bindings
clk: stm32: Fix stm32f429's ltdc driver hang in set clock rate,
  fix duplicated ltdc clock register to 'clk_core' case ltdc's clock
turn off by clk_disable_unused()
drm/panel: Add ilitek ili9341 panel driver
spi: stm32: Add 'SPI_SIMPLEX_RX', 'SPI_3WIRE_RX' support for stm32f4
spi: flags 'SPI_CONTROLLER_MUST_RX' and 'SPI_CONTROLLER_MUST_TX' can't
  be coexit with 'SPI_3WIRE' mode

   .../bindings/display/panel/ilitek,ili9341.yaml |   69 ++
   arch/arm/boot/dts/stm32f4-pinctrl.dtsi |   67 +
   arch/arm/boot/dts/stm32f429-disco.dts  |   48 +
   arch/arm/boot/dts/stm32f429.dtsi   |3 +
   drivers/clk/clk-stm32f4.c  |7 +-
   drivers/gpu/drm/panel/Kconfig  |   12 +
   drivers/gpu/drm/panel/Makefile |1 +
   drivers/gpu/drm/panel/panel-ilitek-ili9341.c   | 1301 

   drivers/spi/spi-stm32.c|   19 +

Re: [PATCH v5 0/8] Enable ili9341 and l3gd20 on stm32f429-disco

2020-07-21 Thread Alexandre Torgue 

Hi Dillon

On 5/25/20 5:40 AM, dillon.min...@gmail.com wrote:

From: dillon min 

V5's update based on Mark Brown's suggestion, use 'SPI_MASTER_MUST_RX'
for SPI_SIMPLEX_RX mode on stm32 spi controller.

V5:
1 instead of add send dummy data out under SIMPLEX_RX mode,
add flags 'SPI_CONTROLLER_MUST_TX' for stm32 spi driver
2 bypass 'SPI_CONTROLLER_MUST_TX' and 'SPI_CONTROLLER_MUST_RX' under
'SPI_3WIRE' mode



Concerning DT patches, they look goods for me. However I'll merge them 
when drivers parts will be merged.


regards
Alex




V4:
According to alexandre torgue's suggestion, combine ili9341 and
l3gd20's modification on stm32f429-disco board to one patchset.

Changes:

ili9341:

1 update ili9341 panel driver according to Linus's suggestion
2 drop V1's No.5 patch, sumbit new changes for clk-stm32f4
3 merge l3gd20's change to this patchset

V3:
1 merge original tiny/ili9341.c driver to panel/panel-ilitek-ili9341.c
   to support serial spi & parallel rgb interface in one driver.
2 update ilitek,ili9341.yaml dts binding documentation.
3 update stm32f429-disco dts binding

V2:
1 verify ilitek,ili9341.yaml with make O=../linux-stm32
   dt_binding_check
   DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/panel/
   ilitek,ili9341.yaml

V1:
1 add ili9341 drm panel driver
2 add ltdc, spi5 controller for stm32f429-disco
3 add ltdc, spi5 pin map for stm32f429-disco
4 add docs about ili9341
5 fix ltdc driver loading hang in clk set rate bug


L3gd20:
V3:
1 merge stm32f429-disco dtbs binding with ili9341 part

V2:
1 insert blank line at stm32f420-disco.dts line 143
2 add more description for l3gd20 in commit message

V1:
1 enable spi5 controller on stm32f429-disco (dts)
2 add spi5 pinmap for stm32f429-disco  (dts)
3 add SPI_SIMPLEX_RX, SPI_3WIRE_RX support for stm32f4


dillon min (8):
   ARM: dts: stm32: Add dma config for spi5
   ARM: dts: stm32: Add pin map for ltdc & spi5 on stm32f429-disco board
   ARM: dts: stm32: enable ltdc binding with ili9341, gyro l3gd20 on
 stm32429-disco board
   dt-bindings: display: panel: Add ilitek ili9341 panel bindings
   clk: stm32: Fix stm32f429's ltdc driver hang in set clock rate,
 fix duplicated ltdc clock register to 'clk_core' case ltdc's clock
   turn off by clk_disable_unused()
   drm/panel: Add ilitek ili9341 panel driver
   spi: stm32: Add 'SPI_SIMPLEX_RX', 'SPI_3WIRE_RX' support for stm32f4
   spi: flags 'SPI_CONTROLLER_MUST_RX' and 'SPI_CONTROLLER_MUST_TX' can't
 be coexit with 'SPI_3WIRE' mode

  .../bindings/display/panel/ilitek,ili9341.yaml |   69 ++
  arch/arm/boot/dts/stm32f4-pinctrl.dtsi |   67 +
  arch/arm/boot/dts/stm32f429-disco.dts  |   48 +
  arch/arm/boot/dts/stm32f429.dtsi   |3 +
  drivers/clk/clk-stm32f4.c  |7 +-
  drivers/gpu/drm/panel/Kconfig  |   12 +
  drivers/gpu/drm/panel/Makefile |1 +
  drivers/gpu/drm/panel/panel-ilitek-ili9341.c   | 1301 
  drivers/spi/spi-stm32.c|   19 +-
  drivers/spi/spi.c  |3 +-
  10 files changed, 1521 insertions(+), 9 deletions(-)
  create mode 100644 
Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml
  create mode 100644 drivers/gpu/drm/panel/panel-ilitek-ili9341.c


___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v6 0/9] Enable ili9341 and l3gd20 on stm32f429-disco

2020-06-16 Thread Alexandre Torgue 

Hi Dillon,

On 5/27/20 9:27 AM, dillon.min...@gmail.com wrote:

From: dillon min 


...


dillon min (9):
   ARM: dts: stm32: Add dma config for spi5
   ARM: dts: stm32: Add pin map for ltdc & spi5 on stm32f429-disco board
   ARM: dts: stm32: enable ltdc binding with ili9341, gyro l3gd20 on
 stm32429-disco board
   dt-bindings: display: panel: Add ilitek ili9341 panel bindings
   clk: stm32: Fix stm32f429's ltdc driver hang in set clock rate
   clk: stm32: Fix ltdc's clock turn off by clk_disable_unused() after
 kernel startup
   drm/panel: Add ilitek ili9341 panel driver
   spi: stm32: Add 'SPI_SIMPLEX_RX', 'SPI_3WIRE_RX' support for stm32f4
   spi: flags 'SPI_CONTROLLER_MUST_RX' and 'SPI_CONTROLLER_MUST_TX' can't
 be coexit with 'SPI_3WIRE' mode

  .../bindings/display/panel/ilitek,ili9341.yaml |   69 ++
  arch/arm/boot/dts/stm32f4-pinctrl.dtsi |   67 +
  arch/arm/boot/dts/stm32f429-disco.dts  |   48 +
  arch/arm/boot/dts/stm32f429.dtsi   |3 +
  drivers/clk/clk-stm32f4.c  |7 +-
  drivers/gpu/drm/panel/Kconfig  |   12 +
  drivers/gpu/drm/panel/Makefile |1 +
  drivers/gpu/drm/panel/panel-ilitek-ili9341.c   | 1288 
  drivers/spi/spi-stm32.c|   19 +-
  drivers/spi/spi.c  |3 +-
  10 files changed, 1508 insertions(+), 9 deletions(-)
  create mode 100644 
Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml
  create mode 100644 drivers/gpu/drm/panel/panel-ilitek-ili9341.c



DT patches (patch 1 to 3) applied on stm32-next. I assume that binding 
one will go with drm/panel driver patch.


Thanks
Alex
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v6 2/9] ARM: dts: stm32: Add pin map for ltdc & spi5 on stm32f429-disco board

2020-06-16 Thread Alexandre Torgue 

Hi Dillon

On 5/27/20 9:27 AM, dillon.min...@gmail.com wrote:

From: dillon min 

This patch adds the pin configuration for ltdc and spi5 controller
on stm32f429-disco board.

Signed-off-by: dillon min 
---
  arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 67 ++
  1 file changed, 67 insertions(+)

diff --git a/arch/arm/boot/dts/stm32f4-pinctrl.dtsi 
b/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
index 392fa143ce07..0eb107f968cd 100644
--- a/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
@@ -316,6 +316,73 @@
};
};
  
+			ltdc_pins_f429_disco: ltdc-1 {


Sorry I missed this issue during review. I changed ltdc_pins_f429_disco 
by ltdc_pins_b when I applied your patch.



Regards
alex


+   pins {
+   pinmux = ,
+   /* LCD_HSYNC */
+,
+/* LCD_VSYNC */
+,
+/* LCD_CLK */
+,
+/* LCD_R2 */
+,
+/* LCD_R3 */
+,
+/* LCD_R4 */
+,
+/* LCD_R5 */
+,
+/* LCD_R6*/
+,
+/* LCD_R7 */
+,
+/* LCD_G2 */
+,
+/* LCD_G3 */
+,
+/* LCD_G4 */
+,
+/* LCD_B2 */
+,
+/* LCD_B3*/
+,
+/* LCD_G5 */
+,
+/* LCD_G6 */
+,
+/* LCD_G7 */
+,
+/* LCD_B4 */
+,
+/* LCD_B5 */
+,
+/* LCD_B6 */
+,
+/* LCD_B7 */
+;
+/* LCD_DE */
+   slew-rate = <2>;
+   };
+   };
+
+   spi5_pins: spi5-0 {
+   pins1 {
+   pinmux = ,
+   /* SPI5_CLK */
+;
+   /* SPI5_MOSI */
+   bias-disable;
+   drive-push-pull;
+   slew-rate = <0>;
+   };
+   pins2 {
+   pinmux = ;
+   /* SPI5_MISO */
+   bias-disable;
+   };
+   };
+
dcmi_pins: dcmi-0 {
pins {
pinmux = , 
/* DCMI_HSYNC */


___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v3 3/5] ARM: dts: stm32: enable ltdc binding with ili9341 on stm32429-disco board

2020-05-15 Thread Alexandre Torgue 




On 5/14/20 10:24 AM, Linus Walleij wrote:

On Tue, May 12, 2020 at 9:04 AM  wrote:


From: dillon min 

Enable the ltdc & ili9341 on stm32429-disco board.

Signed-off-by: dillon min 


This mostly looks good but...


+ {
+   status = "okay";
+   pinctrl-0 = <_pins>;
+   pinctrl-names = "default";
+   #address-cells = <1>;
+   #size-cells = <0>;
+   cs-gpios = < 2 GPIO_ACTIVE_LOW>;
+   dmas = < 3 2 0x400 0x0>,
+  < 4 2 0x400 0x0>;
+   dma-names = "rx", "tx";


These DMA assignments seem to be SoC things and should
rather be in the DTS(I) file where  is defined, right?
stm32f429.dtsi I suppose?


I agree with Linus, DMA have to be defined in SoC dtsi. And if a board 
doesn't want to use it, we use the "delete-property".




It is likely the same no matter which device is using spi5.

Yours,
Linus Walleij


___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] add drm panel driver for stm32f429-dicovery board the change details:

2020-05-01 Thread Alexandre Torgue 

Hi,

You have first to split this patch in several patches and add relevant 
people in TO (using get_maintainer script) for each patch. Quickly, 
you should at least have 4 patches (DT, clock driver, spi driver and drm 
). Then review will be more efficient.


regards
Alexandre

On 4/30/20 10:07 AM, dillon.min...@gmail.com wrote:

From: dillon min 

1) add support drm ili9341 panel driver connect to ltdc

2) add i2c3/spi5 ltdc pins dts configuration for gyro/stmpe

3) add SPI_SIMPLEX_RX/SPI_3WIRE_RX in spi-stm32f4.c
for SPI_SIMPLEX_RX , as we running kernel in sdram, so
that the performance is not as good as internal flash,
need add send dummy data out while in rx,
otherwise will get many overrun errors.

4) fix hang bugs durning ltdc driver load , in clk-stm32f4.c
store clk_hw to the wrong offset PLL_VCO_SAI, PLL_VCO_I2S

5) add CLK_IGNORE_UNUSED for ltdc, otherwise system will close
ltdc clk

===

Signed-off-by: dillon min 
---
  .../bindings/display/panel/ilitek,ili9341.txt  |  43 ++
  arch/arm/boot/dts/stm32f4-pinctrl.dtsi |  79 +++
  arch/arm/boot/dts/stm32f429-disco.dts  |  88 
  arch/arm/boot/dts/stm32f429.dtsi   |  12 +
  drivers/clk/clk-stm32f4.c  |   7 +-
  drivers/gpu/drm/panel/Kconfig  |   8 +
  drivers/gpu/drm/panel/Makefile |   1 +
  drivers/gpu/drm/panel/panel-ilitek-ili9341.c   | 561 +
  drivers/spi/spi-stm32.c|  26 +-
  9 files changed, 818 insertions(+), 7 deletions(-)
  create mode 100644 
Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt
  create mode 100644 drivers/gpu/drm/panel/panel-ilitek-ili9341.c

diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt 
b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt
new file mode 100644
index 000..a03825f
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt
@@ -0,0 +1,43 @@
+Ilitek ILI9341 TFT panel driver with SPI control bus
+
+This is a driver for 320x240 TFT panels, accepting a rgb input
+streams that get adapted and scaled to the panel.
+VCOMH outputs.
+
+Required properties:
+  - compatible: "stm32f429-disco,ltdc-panel", "ilitek,ili9341"
+(full system-specific compatible is always required to look up 
configuration)
+  - reg: address of the panel on the SPI bus
+
+Optional properties:
+  - reset-gpios: a GPIO spec for the reset pin, see gpio/gpio.txt
+  - dc-gpios: a GPIO spec for the dc pin, see gpio/gpio.txt
+
+  The following optional properties only apply to RGB input mode:
+
+  - pixelclk-active: see display/panel/display-timing.txt
+  - de-active: see display/panel/display-timing.txt
+  - hsync-active: see display/panel/display-timing.txt
+  - vsync-active: see display/panel/display-timing.txt
+
+The panel must obey the rules for a SPI slave device as specified in
+spi/spi-bus.txt
+
+The device node can contain one 'port' child node with one child
+'endpoint' node, according to the bindings defined in
+media/video-interfaces.txt. This node should describe panel's video bus.
+
+Example:
+
+panel: display@0 {
+   compatible = "stm32f429-disco,ltdc-panel", "ilitek,ili9341";
+   reg = <0>;
+   spi-3wire;
+   spi-max-frequency = <1000>;
+   dc-gpios = < 13 0>;
+   port {
+   panel_in: endpoint {
+   remote-endpoint = <_out>;
+   };
+   };
+};
diff --git a/arch/arm/boot/dts/stm32f4-pinctrl.dtsi 
b/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
index 392fa14..45b68f4 100644
--- a/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
@@ -316,6 +316,85 @@
};
};
  
+			ltdc_pins_f429_disco: ltdc-1 {

+   pins {
+   pinmux = ,
+   /* LCD_HSYNC */
+,
+/* LCD_VSYNC */
+,
+/* LCD_CLK */
+,
+/* LCD_R2 */
+,
+/* LCD_R3 */
+,
+/* LCD_R4 */
+,
+/* LCD_R5 */
+,
+/* LCD_R6*/
+,
+/* LCD_R7 */
+

Re: [PATCH 1/4] add dts node for drm panel driver ili9341 add dts i2c3 for stmpe touch add dts spi5 for gyro & ili9341

2020-05-01 Thread Alexandre Torgue 



On 4/30/20 12:26 PM, dillon min wrote:

Hi Alexandre,

Alexandre Torgue <mailto:alexandre.tor...@st.com>> 于2020年4月30日周四 下午5:57写道：


Hi

On 4/30/20 11:43 AM, dillon.min...@gmail.com
<mailto:dillon.min...@gmail.com> wrote:
 > From: dillon min mailto:dillon.min...@gmail.com>>
 >
 > Signed-off-by: dillon min mailto:dillon.min...@gmail.com>>

Commit title should be ARM: dts: stm32: bla bla on stm32f429 and please
a commit message.


*okay, thanks for your quicky response, this is my first kernel pull 
request, i will resubmit all patchsets following the history submits 
style who was did.*


ok no pb. In general way you have to execute ./scripts/checkpatch.pl to 
check some style errors before sending. Use ./scripts/get_maintainer.pl 
to see to who you have to send the patch. When you have several patches 
in a series, you need to have a cover-letter which explains the aim of 
your series. To have an idea of commit format just use git log on the 
file changed to see how previous accepted commi have been written.


More details here: Documentation/process/submitting-patches.rst



 > ---
 >   .../bindings/display/panel/ilitek,ili9341.txt      | 42 +++
 >   arch/arm/boot/dts/stm32f4-pinctrl.dtsi             | 79
+++
 >   arch/arm/boot/dts/stm32f429-disco.dts              | 88
++
 >   arch/arm/boot/dts/stm32f429.dtsi                   | 12 +++
 >   4 files changed, 221 insertions(+)
 >   create mode 100644
Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt
 >
 > diff --git
a/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt
b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt

This binding description should be in a separate patch and you have to
write in YAML format.

*okay, will do it later. *


 > new file mode 100644
 > index 000..f5a4e55
 > --- /dev/null
 > +++
b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt
 > @@ -0,0 +1,42 @@
 > +Ilitek ILI9341 TFT panel driver with SPI control bus
 > +
 > +This is a driver for 240x320 TFT panels, accepting a rgb input
 > +streams that get adapted and scaled to the panel.
 > +
 > +Required properties:
 > +  - compatible: "stm32f429-disco,ltdc-panel", "ilitek,ili9341"
 > +    (full system-specific compatible is always required to look
up configuration)
 > +  - reg: address of the panel on the SPI bus
 > +
 > +Optional properties:
 > +  - reset-gpios: a GPIO spec for the reset pin, see gpio/gpio.txt
 > +  - dc-gpios: a GPIO spec for the dc pin, see gpio/gpio.txt
 > +
 > +  The following optional properties only apply to RGB input mode:
 > +
 > +  - pixelclk-active: see display/panel/display-timing.txt
 > +  - de-active: see display/panel/display-timing.txt
 > +  - hsync-active: see display/panel/display-timing.txt
 > +  - vsync-active: see display/panel/display-timing.txt
 > +
 > +The panel must obey the rules for a SPI slave device as specified in
 > +spi/spi-bus.txt
 > +
 > +The device node can contain one 'port' child node with one child
 > +'endpoint' node, according to the bindings defined in
 > +media/video-interfaces.txt. This node should describe panel's
video bus.
 > +
 > +Example:
 > +
 > +panel: display@0 {
 > +     compatible = "stm32f429-disco,ltdc-panel", "ilitek,ili9341";
 > +     reg = <0>;
 > +     spi-3wire;
 > +     spi-max-frequency = <1000>;
 > +     dc-gpios = < 13 0>;
 > +     port {
 > +             panel_in: endpoint {
 > +                     remote-endpoint = <_out>;
 > +             };
 > +     };
 > +};
 > diff --git a/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
b/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
 > index 392fa14..45b68f4 100644
 > --- a/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
 > +++ b/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
 > @@ -316,6 +316,85 @@
 >                               };
 >                       };
 >
 > +                     ltdc_pins_f429_disco: ltdc-1 {
 > +                             pins {
 > +                                     pinmux = ,
 > +                                             /* LCD_HSYNC */
 > +                                              ,
 > +                                              /* LCD_VSYNC */
 > +                                             

Re: [PATCH 1/4] add dts node for drm panel driver ili9341 add dts i2c3 for stmpe touch add dts spi5 for gyro & ili9341

2020-05-01 Thread Alexandre Torgue 

Hi

On 4/30/20 11:43 AM, dillon.min...@gmail.com wrote:

From: dillon min 

Signed-off-by: dillon min 


Commit title should be ARM: dts: stm32: bla bla on stm32f429 and please 
a commit message.



---
  .../bindings/display/panel/ilitek,ili9341.txt  | 42 +++
  arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 79 +++
  arch/arm/boot/dts/stm32f429-disco.dts  | 88 ++
  arch/arm/boot/dts/stm32f429.dtsi   | 12 +++
  4 files changed, 221 insertions(+)
  create mode 100644 
Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt

diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt 
b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt


This binding description should be in a separate patch and you have to 
write in YAML format.




new file mode 100644
index 000..f5a4e55
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt
@@ -0,0 +1,42 @@
+Ilitek ILI9341 TFT panel driver with SPI control bus
+
+This is a driver for 240x320 TFT panels, accepting a rgb input
+streams that get adapted and scaled to the panel.
+
+Required properties:
+  - compatible: "stm32f429-disco,ltdc-panel", "ilitek,ili9341"
+(full system-specific compatible is always required to look up 
configuration)
+  - reg: address of the panel on the SPI bus
+
+Optional properties:
+  - reset-gpios: a GPIO spec for the reset pin, see gpio/gpio.txt
+  - dc-gpios: a GPIO spec for the dc pin, see gpio/gpio.txt
+
+  The following optional properties only apply to RGB input mode:
+
+  - pixelclk-active: see display/panel/display-timing.txt
+  - de-active: see display/panel/display-timing.txt
+  - hsync-active: see display/panel/display-timing.txt
+  - vsync-active: see display/panel/display-timing.txt
+
+The panel must obey the rules for a SPI slave device as specified in
+spi/spi-bus.txt
+
+The device node can contain one 'port' child node with one child
+'endpoint' node, according to the bindings defined in
+media/video-interfaces.txt. This node should describe panel's video bus.
+
+Example:
+
+panel: display@0 {
+   compatible = "stm32f429-disco,ltdc-panel", "ilitek,ili9341";
+   reg = <0>;
+   spi-3wire;
+   spi-max-frequency = <1000>;
+   dc-gpios = < 13 0>;
+   port {
+   panel_in: endpoint {
+   remote-endpoint = <_out>;
+   };
+   };
+};
diff --git a/arch/arm/boot/dts/stm32f4-pinctrl.dtsi 
b/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
index 392fa14..45b68f4 100644
--- a/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
@@ -316,6 +316,85 @@
};
};
  
+			ltdc_pins_f429_disco: ltdc-1 {

+   pins {
+   pinmux = ,
+   /* LCD_HSYNC */
+,
+/* LCD_VSYNC */
+,
+/* LCD_CLK */
+,
+/* LCD_R2 */
+,
+/* LCD_R3 */
+,
+/* LCD_R4 */
+,
+/* LCD_R5 */
+,
+/* LCD_R6*/
+,
+/* LCD_R7 */
+,
+/* LCD_G2 */
+,
+/* LCD_G3 */
+,
+/* LCD_G4 */
+,
+/* LCD_B2 */
+,
+/* LCD_B3*/
+,
+/* LCD_G5 */
+,
+/* LCD_G6 */
+,
+/* LCD_G7 */
+,
+/* LCD_B4 */
+,
+

Re: [PATCH v1 0/5] Add supply property for DSI controller

2019-04-11 Thread Alexandre Torgue 

Hi Yannick

On 4/3/19 10:16 AM, Yannick Fertré wrote:

The DSI controller needs a new property that powers its physical layer.
Binding has been updated to documented this property.
Device tree of stm32mp157c soc.
Move reg18 & reg11 to stm32mp157c device tree file.
Remove property phy-dsi-supply property to stm32mp157c-dk2.dts file.

Yannick Fertré (5):


...


   ARM: dts: stm32: add phy-dsi-supply property on stm32mp157c
   ARM: dts: stm32: move fixe regulators reg11 & reg18
   ARM: dts: stm32: remove phy-dsi-supply property on stm32mp157c-dk2
 board



For ARM part:

Another series is currently under review: "Add support for STM32MP1 
power regulators" (https://lkml.org/lkml/2019/4/8/614).


As soon I'll merge it I'll take your patches without patch
"ARM: dts: stm32: move fixe regulators reg11 & reg18" as it will be no 
longer relevant.


regards
Alexandre



  .../devicetree/bindings/display/st,stm32-ltdc.txt|  3 +++
  arch/arm/boot/dts/stm32mp157c-dk2.dts|  9 -
  arch/arm/boot/dts/stm32mp157c-ed1.dts| 16 
  arch/arm/boot/dts/stm32mp157c.dtsi   | 17 +
  drivers/gpu/drm/stm/dw_mipi_dsi-stm.c| 20 
  5 files changed, 40 insertions(+), 25 deletions(-)


___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v7 0/9] STM32 LCD-TFT display controller

2017-06-12 Thread Alexandre Torgue 

Hi Yannick

On 04/14/2017 12:13 PM, Yannick Fertre wrote:
...


The purpose of this set of patches is to add a new driver for stm32f429.
This driver was developed and tested on evaluation board stm32429i.

Stm32f4 is a MCU platform which don't have MMU so the last patches developed
by Benjamin Gaignard regarding "DRM: allow to use mmuless devices"
are necessary.

The board stm429i embeds a Ampire AM-480272H3TMQW-T01H screen.
A new simple panel am-480272h3tmqw-t01h have been added to support it.


Yannick Fertre (9):
   drm/cma: Update DEFINE_DRM_GEM_CMA_FOPS to add get_unmapped_area
   drm/fb-cma-helper: Add drm_fb_cma_get_gem_addr()
   dt-bindings: display: Add STM32 LTDC driver
   drm/stm: Add STM32 LTDC driver
   MAINTAINERS: add maintainers for DRM STM driver
   ARM: dts: stm32: Add ltdc support on stm32f429 MCU
   ARM: dts: stm32: Enable ltdc & simple panel on stm32f429-Eval board
   ARM: configs: stm32: Add DRM support in STM32 defconfig
   ARM: configs: stm32: Add simple panel support in STM32 defconfig


For STM32 machine part:

Patches 6 & 7 applied on stm32-dt-for-v4.13

Patches 8 & 9 will not be applied:
As SDRAM used on STM32 MCUs is small, I don't want to penalize other users:
 - by increasing static kernel size
 - by enabling devices which consume dynamically lot of memory

User will be free to enable it through menuconfig.

Regards
Alex
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v4 8/8] ARM: configs: Add STM32 panel simple support in STM32 defconfig

2017-03-23 Thread Alexandre Torgue 

Hi,

On 03/15/2017 06:02 PM, Yannick Fertre wrote:

Signed-off-by: Yannick Fertre 
---


Same remarks than patch7


 arch/arm/configs/stm32_defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/configs/stm32_defconfig b/arch/arm/configs/stm32_defconfig
index 9c6ba54e..f7ddf29b 100644
--- a/arch/arm/configs/stm32_defconfig
+++ b/arch/arm/configs/stm32_defconfig
@@ -50,6 +50,8 @@ CONFIG_SERIAL_STM32_CONSOLE=y
 # CONFIG_HW_RANDOM is not set
 # CONFIG_HWMON is not set
 CONFIG_DRM=y
+CONFIG_DRM_PANEL_SIMPLE=y
+CONFIG_BACKLIGHT_LCD_SUPPORT=y
 CONFIG_MFD_SYSCON=y
 # CONFIG_USB_SUPPORT is not set
 CONFIG_NEW_LEDS=y


___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v4 7/8] ARM: configs: Add STM32 LTDC support in STM32 defconfig

2017-03-23 Thread Alexandre Torgue 

Hi

On 03/15/2017 06:02 PM, Yannick Fertre wrote:

Signed-off-by: Yannick Fertre 
---


Can you change commit header by:" ARM: config: stm32: Add LTDC support"
and can you fill a commit message please ?


 arch/arm/configs/stm32_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/stm32_defconfig b/arch/arm/configs/stm32_defconfig
index 436240d..9c6ba54e 100644
--- a/arch/arm/configs/stm32_defconfig
+++ b/arch/arm/configs/stm32_defconfig
@@ -49,6 +49,7 @@ CONFIG_SERIAL_STM32=y
 CONFIG_SERIAL_STM32_CONSOLE=y
 # CONFIG_HW_RANDOM is not set
 # CONFIG_HWMON is not set
+CONFIG_DRM=y
 CONFIG_MFD_SYSCON=y
 # CONFIG_USB_SUPPORT is not set
 CONFIG_NEW_LEDS=y


___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 7/7] ARM: configs: stm32: ADD LDTC support

2017-02-13 Thread Alexandre Torgue 

Hi Yannick

On 02/10/2017 04:24 PM, Yannick Fertre wrote:

Signed-off-by: Yannick Fertre 


Please add a commit message.


---
 arch/arm/configs/stm32_defconfig | 5 +
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/configs/stm32_defconfig b/arch/arm/configs/stm32_defconfig
index e995209..d6a00b8 100644
--- a/arch/arm/configs/stm32_defconfig
+++ b/arch/arm/configs/stm32_defconfig
@@ -70,3 +70,8 @@ CONFIG_MAGIC_SYSRQ=y
 # CONFIG_FTRACE is not set
 CONFIG_CRC_ITU_T=y
 CONFIG_CRC7=y
+CONFIG_DRM=y
+CONFIG_DRM_ST=y
+CONFIG_DRM_PANEL=y
+CONFIG_DRM_PANEL_SIMPLE=y
+CONFIG_BACKLIGHT_LCD_SUPPORT=y


___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v1 6/7] ARM: dts: stm32429i-eval: Enable ltdc & simple panel on Eval board

2017-01-16 Thread Alexandre Torgue 

Hi

On 01/16/2017 02:29 PM, Yannick Fertre wrote:

Enable ltdc & enable am-480272h3tmqw-t01h panel.

Signed-off-by: Yannick Fertre 
---


Can you please change commit header with:

"ARM: dts: stm32: Enable ltdc & simple panel on stm32f429-Eval board"


 arch/arm/boot/dts/stm32429i-eval.dts | 58 
 1 file changed, 58 insertions(+)

diff --git a/arch/arm/boot/dts/stm32429i-eval.dts 
b/arch/arm/boot/dts/stm32429i-eval.dts
index 2de6487..f987ca5 100644
--- a/arch/arm/boot/dts/stm32429i-eval.dts
+++ b/arch/arm/boot/dts/stm32429i-eval.dts
@@ -88,6 +88,52 @@
clocks = < 0 30>;
clock-names = "main_clk";
};
+
+   panel_rgb: panel-rgb {
+   compatible = "ampire,am-480272h3tmqw-t01h";
+   status = "okay";
+   port {
+   panel_in_rgb: endpoint {
+   remote-endpoint = <_out_rgb>;
+   };
+   };
+   };
+};
+
+ {
+   pinctrl_ltdc: ltdc@0 {
+   pins {


Pinmuxing definition is SOC specific. Please move it in stm32f429.dtsi 
file. Note that a development is ongoing to define pinmuxing in a 
dedicated pinctrl-stm32f4.dtsi file.




+   pinmux = ,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+;
+   slew-rate = <2>;
+   };
+   };
 };

 _hse {
@@ -123,3 +169,15 @@
pinctrl-names = "default";
status = "okay";
 };
+
+_host{
+   status = "okay";
+   pinctrl-0 = <_ltdc>;
+   pinctrl-names = "default";
+
+   port {
+   ltdc_out_rgb: endpoint {
+   remote-endpoint = <_in_rgb>;
+   };
+   };
+};


___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v1 7/7] ARM: configs: Add STM32 LTDC support in STM32 defconfig

2017-01-16 Thread Alexandre Torgue 

Hi

On 01/16/2017 02:29 PM, Yannick Fertre wrote:

Signed-off-by: Yannick Fertre 
---


commit header "ARM: configs: stm32: ADD LDTC support"


 arch/arm/configs/stm32_defconfig | 5 +
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/configs/stm32_defconfig b/arch/arm/configs/stm32_defconfig
index 29068f5..e3974d9 100644
--- a/arch/arm/configs/stm32_defconfig
+++ b/arch/arm/configs/stm32_defconfig
@@ -71,3 +71,8 @@ CONFIG_MAGIC_SYSRQ=y
 # CONFIG_FTRACE is not set
 CONFIG_CRC_ITU_T=y
 CONFIG_CRC7=y
+CONFIG_DRM=y
+CONFIG_DRM_ST=y
+CONFIG_DRM_PANEL=y
+CONFIG_DRM_PANEL_SIMPLE=y
+CONFIG_BACKLIGHT_LCD_SUPPORT=y


___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v1 5/7] ARM: dts: stm32f429: Add ltdc support

2017-01-16 Thread Alexandre Torgue 

Hi,

On 01/16/2017 02:29 PM, Yannick Fertre wrote:

Add LTDC (Lcd-tft Display Controller) support.

Signed-off-by: Yannick Fertre 


Can you change commit header by: "ARM: dts: stm32: Add ltdc support on 
stm32f429 MCU" please



---
 arch/arm/boot/dts/stm32f429.dtsi | 25 -
 1 file changed, 24 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi
index 336ee4f..fc43415 100644
--- a/arch/arm/boot/dts/stm32f429.dtsi
+++ b/arch/arm/boot/dts/stm32f429.dtsi
@@ -185,7 +185,7 @@
interrupts = <1>, <2>, <3>, <6>, <7>, <8>, <9>, <10>, <23>, <40>, <41>, 
<42>, <62>, <76>;
};

-   pin-controller {
+   pinctrl: pin-controller {
#address-cells = <1>;
#size-cells = <1>;
compatible = "st,stm32f429-pinctrl";
@@ -404,6 +404,29 @@
interrupts = <80>;
clocks = < 0 38>;
};
+
+   st-display-subsystem {
+   compatible = "st,display-subsystem";
+   #address-cells = <1>;
+   #size-cells = <1>;
+   ranges;
+   dma-ranges;
+
+   ltdc_host: stm32-ltdc@40016800 {
+   compatible = "st,ltdc";
+   reg = <0x40016800 0x200>;
+   interrupts = <88>, <89>;
+   resets = < 314>;
+   clocks = < 1 8>;
+   clock-names = "clk-lcd";
+   status = "disabled";
+
+   port {
+   ltdc_out_rgb: endpoint {
+   };
+   };
+   };
+   };
};
 };



___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel