Re: [PATCH v2 9/9] platform/chrome: chromeos_laptop: use helper pci_dev_id

2019-04-25 Thread Benson Leung
Hi Heiner, On Wed, Apr 24, 2019 at 09:17:19PM +0200, Heiner Kallweit wrote: > Use new helper pci_dev_id() to simplify the code. > > Signed-off-by: Heiner Kallweit Acked-By: Benson Leung > --- > drivers/platform/chrome/chromeos_laptop.c | 2 +- > 1 file changed, 1 insert

Re: [PATCH] drm/dp: Correctly mask DP_TRAINING_AUX_RD_INTERVAL values for DP 1.4

2018-03-16 Thread Benson Leung
changes > V5: typo > V6: print statement revisions, DP_REV to DPCD_REV, comment correction > V7: typo > V8: Style > > Signed-off-by: Matt Atwood Tested-by: Benson Leung This version still passes link training on the panel with 8th bit set in DPCD 0x000e. Thanks, Benson --

Re: v3.9-rc1 instability on Chromebook Pixel with gmbus irq

2013-03-06 Thread Benson Leung
Hi Daniel, I've just tried drm-intel-fixes merged into v3.9-rc1, and so far it's looking good. No suspicious timeouts. Thanks for the quick response! Benson On Wed, Mar 6, 2013 at 12:14 AM, Daniel Vetter wrote: > On Wed, Mar 6, 2013 at 3:35 AM, Benson Leung wrote: >> I

v3.9-rc1 instability on Chromebook Pixel with gmbus irq

2013-03-06 Thread Benson Leung
Hi Daniel, I've just tried drm-intel-fixes merged into v3.9-rc1, and so far it's looking good. No suspicious timeouts. Thanks for the quick response! Benson On Wed, Mar 6, 2013 at 12:14 AM, Daniel Vetter wrote: > On Wed, Mar 6, 2013 at 3:35 AM, Benson Leung wrote: >> I

v3.9-rc1 instability on Chromebook Pixel with gmbus irq

2013-03-05 Thread Benson Leung
ng with interrupt driven gmbus is now as fast as with busy-looping gmbus at 28 ms here (with negligible cpu overhead). Reviewed-by: Imre Deak Signed-off-by: Daniel Vetter Is there anything I can do to help debug this some more? -- Benson Leung Software

v3.9-rc1 instability on Chromebook Pixel with gmbus irq

2013-03-05 Thread Benson Leung
ng with interrupt driven gmbus is now as fast as with busy-looping gmbus at 28 ms here (with negligible cpu overhead). Reviewed-by: Imre Deak Signed-off-by: Daniel Vetter Is there anything I can do to help debug this some more? -- Benson Leung Software Engineer, Chrom* OS bleung at chromium.org

[PATCH] drm/i915: Fix single msg gmbus_xfers writes

2012-02-09 Thread Benson Leung
: 0) Fixed the latter by waiting on GMBUS_ACTIVE to deassert before disable. Signed-off-by: Benson Leung --- drivers/gpu/drm/i915/intel_i2c.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_i2c.c b/drivers/gpu/drm/i915/intel_i2c.c

[PATCH] drm/i915: Fix single msg gmbus_xfers writes

2012-02-09 Thread Benson Leung
: 0) Fixed the latter by waiting on GMBUS_ACTIVE to deassert before disable. Signed-off-by: Benson Leung --- drivers/gpu/drm/i915/intel_i2c.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_i2c.c b/drivers/gpu/drm/i915/intel_i2c.c