Re: [PATCH v3 9/9] drm/mediatek: reduce clear event

2020-07-08 Thread Bibby Hsieh
ent always clear before wait. > This fix depend on patch: > "soc: mediatek: cmdq: add clear option in cmdq_pkt_wfe api" > > Fixes: 2f965be7f9008 ("drm/mediatek: apply CMDQ control flow") > Signed-off-by: Dennis YC Hsieh Reviewed-by: Bibby Hsieh > --- &

Re: [PATCH v3 1/9] soc: mediatek: cmdq: add address shift in jump

2020-07-08 Thread Bibby Hsieh
Reviewed-by: Bibby Hsieh On Tue, 2020-07-07 at 23:45 +0800, Dennis YC Hsieh wrote: > Add address shift when compose jump instruction > to compatible with 35bit format. > > Change since v1: > - Rename cmdq_mbox_shift() to cmdq_get_shift_pa(). > > Signed-of

Re: [PATCH v1 01/11] soc: mediatek: cmdq: add address shift in jump

2020-06-21 Thread Bibby Hsieh
Reviewed-by: Bibby Hsieh Thanks. On Sun, 2020-06-21 at 22:18 +0800, Dennis YC Hsieh wrote: > Add address shift when compose jump instruction > to compatible with 35bit format. > > Signed-off-by: Dennis YC Hsieh > --- > drivers/soc/mediatek/mtk-cmdq-helper.c |3 ++- &g

Re: [PATCH v1 0/11] support cmdq helper function on mt6779 platform

2020-06-21 Thread Bibby Hsieh
Hi, Dennis, Please add "depends on patch: support gce on mt6779 platform" in cover letter. Thanks Bibby On Sun, 2020-06-21 at 22:18 +0800, Dennis YC Hsieh wrote: > This patch support cmdq helper function on mt6779 platform, > based on "support gce on mt6779 platform" patchset. > > > Dennis YC

Re: [PATCH 1/3] arm64: dts: mt8183: Add gce setting in display node

2020-05-21 Thread Bibby Hsieh
On Thu, 2020-05-21 at 12:10 +0200, Matthias Brugger wrote: > On 14/02/2020 11:06, Matthias Brugger wrote: > > > > > > On 14/02/2020 05:49, Bibby Hsieh wrote: > >> In order to use GCE function, we need add some information > >> into display node (mboxes

[PATCH v1 3/3] drm/mediatek: move gce event property to mutex device node

2020-02-17 Thread Bibby Hsieh
According mtk hardware design, stream_done0 and stream_done1 are generated by mutex, so we move gce event property to mutex device mode. Signed-off-by: Bibby Hsieh Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v1 1/3] arm64: dts: mt8183: Add gce setting in display node

2020-02-17 Thread Bibby Hsieh
In order to use GCE function, we need add some information into display node (mboxes, mediatek,gce-client-reg, mediatek,gce-events). Signed-off-by: Bibby Hsieh Signed-off-by: Yongqiang Niu --- This patch depends on ptach: [RESEND,v6,02/17] arm64: dts: add display nodes for mt8183 https

[PATCH v1 2/3] drm/mediatek: make sure previous message done or be aborted before send

2020-02-17 Thread Bibby Hsieh
: [0/3] Remove atomic_exec https://patchwork.kernel.org/cover/11381677/ Signed-off-by: Bibby Hsieh Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c

[PATCH 2/3] drm/mediatek: make sure previous message done or be aborted before send

2020-02-13 Thread Bibby Hsieh
: [0/3] Remove atomic_exec https://patchwork.kernel.org/cover/11381677/ Signed-off-by: Bibby Hsieh --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c index 3c53ea22208c

[PATCH 1/3] arm64: dts: mt8183: Add gce setting in display node

2020-02-13 Thread Bibby Hsieh
In order to use GCE function, we need add some information into display node (mboxes, mediatek,gce-client-reg, mediatek,gce-events). Signed-off-by: Bibby Hsieh Signed-off-by: Yongqiang Niu --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 16 1 file changed, 16 insertions

[PATCH 3/3] drm/mediatek: move gce event property to mutex device node

2020-02-13 Thread Bibby Hsieh
According mtk hardware design, stream_done0 and stream_done1 are generated by mutex, so we move gce event property to mutex device mode. Signed-off-by: Bibby Hsieh --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm

Re: [PATCH 1/2] arm64: dts: mt8183: Add gce setting in display node

2020-02-12 Thread Bibby Hsieh
On Wed, 2020-02-12 at 18:48 +0800, CK Hu wrote: > On Wed, 2020-02-12 at 17:55 +0800, Bibby Hsieh wrote: > > In order to use GCE function, we need add some information > > into display node (mboxes, mediatek,gce-client-reg, mediatek,gce-events). > > > > Signed-off-by:

[PATCH 2/2] drm/mediatek: add fb swap in async_update

2020-02-12 Thread Bibby Hsieh
Besides x, y position, width and height, fb also need updating in async update. Fixes: 920fffcc8912 ("drm/mediatek: update cursors by using async atomic update") Signed-off-by: Bibby Hsieh --- drivers/gpu/drm/mediatek/mtk_drm_plane.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 1/2] drm/mediatek: add plane check in async_check function

2020-02-12 Thread Bibby Hsieh
MTK do rotation checking and transferring in layer check function, but we do not check that in atomic_check, so add back in atomic_check function. Fixes: 920fffcc8912 ("drm/mediatek: update cursors by using async atomic update") Signed-off-by: Bibby Hsieh --- drivers/gpu/dr

[PATCH 2/2] drm/mediatek: move gce event property to mutex device node

2020-02-12 Thread Bibby Hsieh
According mtk hardware design, stream_done0 and stream_done1 are generated by mutex, so we move gce event property to mutex device mode. Signed-off-by: Bibby Hsieh --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH 1/2] arm64: dts: mt8183: Add gce setting in display node

2020-02-12 Thread Bibby Hsieh
In order to use GCE function, we need add some information into display node (mboxes, mediatek,gce-client-reg, mediatek,gce-events). Signed-off-by: Bibby Hsieh Signed-off-by: Yongqiang Niu --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 16 1 file changed, 16 insertions

[PATCH v5 0/7] drm/mediatek: fix cursor issue and apply CMDQ in MTK DRM

2019-12-09 Thread Bibby Hsieh
- merge the duplicate code - use async instead of cursor Changes since v0: - remove redundant code - remove patch "drm/mediatek: fix atomic_state reference counting" After remove this patch, the issue we met before is gone. So I do not add any extra code to do something. Bibb

[PATCH v5 1/7] drm/mediatek: use DRM core's atomic commit helper

2019-12-09 Thread Bibby Hsieh
The DRM core atomic helper now supports asynchronous commits natively. The custom drm implementation isn't needed anymore, remove it. Signed-off-by: Bibby Hsieh Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 86 ++ drivers/gpu/drm/mediatek/mtk_drm_drv.h

[PATCH v5 3/7] drm/mediatek: update cursors by using async atomic update

2019-12-09 Thread Bibby Hsieh
Support to async updates of cursors by using the new atomic interface for that. Signed-off-by: Bibby Hsieh Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 98 +++- drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 2 + drivers/gpu/drm/mediatek/mtk_drm_plane.c

[PATCH v5 5/7] drm/mediatek: remove unused external function

2019-12-09 Thread Bibby Hsieh
layer_on and layer_off both are unused external function, remove them from mtk_ddp_comp_funcs structure. Signed-off-by: Bibby Hsieh Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 2 -- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 16 2 files changed, 18

[PATCH v5 7/7] drm/mediatek: apply CMDQ control flow

2019-12-09 Thread Bibby Hsieh
Signed-off-by: CK Hu Signed-off-by: Philipp Zabel Signed-off-by: Bibby Hsieh Signed-off-by: Yongqiang Niu Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 56 + 1 file changed, 49 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm

[PATCH v5 4/7] drm/mediatek: disable all the planes in atomic_disable

2019-12-09 Thread Bibby Hsieh
Under shadow register case, we do not disable all the plane before disable all the hardwares. Fix it. Fixes: 9dc84e98a31f ("drm/mediatek: add shadow register support") Signed-off-by: Bibby Hsieh Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 1 + 1 file changed, 1

[PATCH v5 6/7] drm/mediatek: support CMDQ interface in ddp component

2019-12-09 Thread Bibby Hsieh
-by: CK Hu Signed-off-by: Philipp Zabel Signed-off-by: Bibby Hsieh Signed-off-by: Yongqiang Niu Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_disp_color.c | 7 +- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 65 +- drivers/gpu/drm/mediatek/mtk_disp_rdma.c| 43

[PATCH v5 2/7] drm/mediatek: handle events when enabling/disabling crtc

2019-12-09 Thread Bibby Hsieh
it. Signed-off-by: Bibby Hsieh Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c index 4bb468fd9226..af097b7db72f 100644 --- a/drivers/gpu/drm

[PATCH v4 6/7] drm/mediatek: support CMDQ interface in ddp component

2019-12-05 Thread Bibby Hsieh
-by: CK Hu Signed-off-by: Philipp Zabel Signed-off-by: Bibby Hsieh Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_color.c | 7 +- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 65 +- drivers/gpu/drm/mediatek/mtk_disp_rdma.c| 43 --- drivers/gpu/drm/mediatek

[PATCH v4 0/7] drm/mediatek: fix cursor issue and apply CMDQ in MTK DRM

2019-12-05 Thread Bibby Hsieh
do not add any extra code to do something. Bibby Hsieh (7): drm/mediatek: use DRM core's atomic commit helper drm/mediatek: handle events when enabling/disabling crtc drm/mediatek: update cursors by using async atomic update drm/mediatek: disable all the planes in atomic_disable drm/mediat

[PATCH v4 2/7] drm/mediatek: handle events when enabling/disabling crtc

2019-12-05 Thread Bibby Hsieh
it. Signed-off-by: Bibby Hsieh Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c index f5eeb0eebf76..4bc52346093d 100644 --- a/drivers/gpu/drm

[PATCH v4 7/7] drm/mediatek: apply CMDQ control flow

2019-12-05 Thread Bibby Hsieh
Signed-off-by: CK Hu Signed-off-by: Philipp Zabel Signed-off-by: Bibby Hsieh Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 56 + 1 file changed, 49 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drive

[PATCH v4 5/7] drm/mediatek: remove unused external function

2019-12-05 Thread Bibby Hsieh
layer_on and layer_off both are unused external function, remove them from mtk_ddp_comp_funcs structure. Signed-off-by: Bibby Hsieh Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 2 -- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 16 2 files changed, 18

[PATCH v4 3/7] drm/mediatek: update cursors by using async atomic update

2019-12-05 Thread Bibby Hsieh
Support to async updates of cursors by using the new atomic interface for that. Signed-off-by: Bibby Hsieh --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 98 +++- drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 2 + drivers/gpu/drm/mediatek/mtk_drm_plane.c | 47

[PATCH v4 4/7] drm/mediatek: disable all the planes in atomic_disable

2019-12-05 Thread Bibby Hsieh
Under shadow register case, we do not disable all the plane before disable all the hardwares. Fix it. Signed-off-by: Bibby Hsieh --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek

[PATCH v4 1/7] drm/mediatek: use DRM core's atomic commit helper

2019-12-05 Thread Bibby Hsieh
The DRM core atomic helper now supports asynchronous commits natively. The custom drm implementation isn't needed anymore, remove it. Signed-off-by: Bibby Hsieh Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 86 ++ drivers/gpu/drm/mediatek/mtk_drm_drv.h

[PATCH v3 4/6] drm/mediatek: remove unused external function

2019-12-04 Thread Bibby Hsieh
layer_on and layer_off both are unused external function, remove them from mtk_ddp_comp_funcs structure. Signed-off-by: Bibby Hsieh Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 2 -- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 16 2 files changed, 18

[PATCH v3 5/6] drm/mediatek: support CMDQ interface in ddp component

2019-12-04 Thread Bibby Hsieh
-by: CK Hu Signed-off-by: Philipp Zabel Signed-off-by: Bibby Hsieh Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_color.c | 7 +- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 65 +- drivers/gpu/drm/mediatek/mtk_disp_rdma.c| 43 --- drivers/gpu/drm/mediatek

[PATCH v3 6/6] drm/mediatek: apply CMDQ control flow

2019-12-04 Thread Bibby Hsieh
Signed-off-by: CK Hu Signed-off-by: Philipp Zabel Signed-off-by: Bibby Hsieh Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 80 - 1 file changed, 77 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drive

[PATCH v3 3/6] drm/mediatek: update cursors by using async atomic update

2019-12-04 Thread Bibby Hsieh
Support to async updates of cursors by using the new atomic interface for that. Signed-off-by: Bibby Hsieh --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 75 +--- drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 2 + drivers/gpu/drm/mediatek/mtk_drm_plane.c | 50

[PATCH v3 2/6] drm/mediatek: handle events when enabling/disabling crtc

2019-12-04 Thread Bibby Hsieh
it. Signed-off-by: Bibby Hsieh Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c index f5eeb0eebf76..4bc52346093d 100644 --- a/drivers/gpu/drm

[PATCH v3 1/6] drm/mediatek: use DRM core's atomic commit helper

2019-12-04 Thread Bibby Hsieh
The DRM core atomic helper now supports asynchronous commits natively. The custom drm implementation isn't needed anymore, remove it. Signed-off-by: Bibby Hsieh Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 86 ++ drivers/gpu/drm/mediatek/mtk_drm_drv.h

[PATCH v3 0/6] drm/mediatek: fix cursor issue and apply CMDQ in MTK DRM

2019-12-04 Thread Bibby Hsieh
the duplicate code - use async instead of cursor Changes since v0: - remove redundant code - remove patch "drm/mediatek: fix atomic_state reference counting" After remove this patch, the issue we met before is gone. So I do not add any extra code to do something. Bibby Hsieh

[PATCH v2 6/6] drm/mediatek: apply CMDQ control flow

2019-12-02 Thread Bibby Hsieh
Signed-off-by: CK Hu Signed-off-by: Philipp Zabel Signed-off-by: Bibby Hsieh Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 163 +--- 1 file changed, 118 insertions(+), 45 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drive

[PATCH v2 4/6] drm/mediatek: remove unused external function

2019-12-02 Thread Bibby Hsieh
layer_on and layer_off both are unused external function, remove them from mtk_ddp_comp_funcs structure. Signed-off-by: Bibby Hsieh --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 2 -- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 16 2 files changed, 18 deletions(-) diff

[PATCH v2 3/6] drm/mediatek: update cursors by using async atomic update

2019-12-02 Thread Bibby Hsieh
Support to async updates of cursors by using the new atomic interface for that. Signed-off-by: Bibby Hsieh --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 33 drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 2 + drivers/gpu/drm/mediatek/mtk_drm_plane.c | 50

[PATCH v2 1/6] drm/mediatek: use DRM core's atomic commit helper

2019-12-02 Thread Bibby Hsieh
The DRM core atomic helper now supports asynchronous commits natively. The custom drm implementation isn't needed anymore, remove it. Signed-off-by: Bibby Hsieh Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 86 ++ drivers/gpu/drm/mediatek/mtk_drm_drv.h

[PATCH v2 5/6] drm/mediatek: support CMDQ interface in ddp component

2019-12-02 Thread Bibby Hsieh
-by: CK Hu Signed-off-by: Philipp Zabel Signed-off-by: Bibby Hsieh Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_color.c | 7 +- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 65 +- drivers/gpu/drm/mediatek/mtk_disp_rdma.c| 43 --- drivers/gpu/drm/mediatek

[PATCH v2 2/6] drm/mediatek: handle events when enabling/disabling crtc

2019-12-02 Thread Bibby Hsieh
it. Signed-off-by: Bibby Hsieh Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c index 29d0582e90e9..4c25ad2182b0 100644 --- a/drivers/gpu/drm

[PATCH v2 0/6] drm/mediatek: fix cursor issue and apply CMDQ in MTK DRM

2019-12-02 Thread Bibby Hsieh
- remove patch "drm/mediatek: fix atomic_state reference counting" After remove this patch, the issue we met before is gone. So I do not add any extra code to do something. Bibby Hsieh (6): drm/mediatek: use DRM core's atomic commit helper drm/mediatek: handle events whe

Re: [PATCH v1 6/6] drm/mediatek: apply CMDQ control flow

2019-12-02 Thread Bibby Hsieh
On Tue, 2019-12-03 at 09:38 +0800, CK Hu wrote: > Hi, Bibby: > > On Thu, 2019-11-28 at 10:42 +0800, Bibby Hsieh wrote: > > Unlike other SoCs, MT8183 does not have "shadow" > > registers for performaing an atomic video mode > > set or page flip at vblank/vs

[PATCH v1 0/6] drm/mediatek: fix cursor issue and apply CMDQ in

2019-11-27 Thread Bibby Hsieh
this patch, the issue we met before is gone. So I do not add any extra code to do something. Bibby Hsieh (6): drm/mediatek: put "event" in critical section drm/mediatek: use DRM core's atomic commit helper drm/mediatek: handle events when enabling/disabling crtc drm/mediatek: update cu

[PATCH v1 6/6] drm/mediatek: apply CMDQ control flow

2019-11-27 Thread Bibby Hsieh
Signed-off-by: CK Hu Signed-off-by: Philipp Zabel Signed-off-by: Bibby Hsieh Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 86 - drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 31 2 files changed, 113 insertions(+), 4 deletions(-)

[PATCH v1 1/6] drm/mediatek: put "event" in critical section

2019-11-27 Thread Bibby Hsieh
) Signed-off-by: Bibby Hsieh --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c index 29d0582e90e9..71f4089a8117 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c

[PATCH v1 3/6] drm/mediatek: handle events when enabling/disabling crtc

2019-11-27 Thread Bibby Hsieh
it. Signed-off-by: Bibby Hsieh --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c index 71f4089a8117..cb87a538b8ff 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c

[PATCH v1 4/6] drm/mediatek: update cursors by using async atomic update

2019-11-27 Thread Bibby Hsieh
Support to async updates of cursors by using the new atomic interface for that. Signed-off-by: Bibby Hsieh --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 35 + drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 2 + drivers/gpu/drm/mediatek/mtk_drm_drv.c | 22 ++- drivers/gpu

[PATCH v1 5/6] drm/mediatek: support CMDQ interface in ddp component

2019-11-27 Thread Bibby Hsieh
-by: CK Hu Signed-off-by: Philipp Zabel Signed-off-by: Bibby Hsieh Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_color.c | 7 +- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 65 ++- drivers/gpu/drm/mediatek/mtk_disp_rdma.c| 43 --- drivers/gpu/drm/mediatek

[PATCH v1 2/6] drm/mediatek: use DRM core's atomic commit helper

2019-11-27 Thread Bibby Hsieh
The DRM core atomic helper now supports asynchronous commits natively. The custom drm implementation isn't needed anymore, remove it. Signed-off-by: Bibby Hsieh --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 86 ++ drivers/gpu/drm/mediatek/mtk_drm_drv.h | 7 --- 2 files

Re: [PATCH 1/7] drm/mediatek: fix atomic_state reference counting

2019-11-27 Thread Bibby Hsieh
On Wed, 2019-11-27 at 17:56 +0800, Daniel Vetter wrote: > On Wed, Nov 27, 2019 at 09:41:52AM +0800, Bibby Hsieh wrote: > > On Tue, 2019-11-26 at 09:49 +0100, Daniel Vetter wrote: > > > On Tue, Nov 26, 2019 at 02:29:26PM +0800, Bibby Hsieh wrote: > > > > The DRM core

Re: [PATCH 1/7] drm/mediatek: fix atomic_state reference counting

2019-11-26 Thread Bibby Hsieh
On Tue, 2019-11-26 at 09:49 +0100, Daniel Vetter wrote: > On Tue, Nov 26, 2019 at 02:29:26PM +0800, Bibby Hsieh wrote: > > The DRM core takes care of all atomic state refcounting. > > However, mediatek drm defers some work that accesses planes > > and plane_states in drm_a

[PATCH 6/7] drm/mediatek: support CMDQ interface in ddp component

2019-11-25 Thread Bibby Hsieh
-by: CK Hu Signed-off-by: Philipp Zabel Signed-off-by: Bibby Hsieh Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_color.c | 7 +- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 65 ++- drivers/gpu/drm/mediatek/mtk_disp_rdma.c| 43 --- drivers/gpu/drm/mediatek

[PATCH 7/7] drm/mediatek: apply CMDQ control flow

2019-11-25 Thread Bibby Hsieh
Signed-off-by: CK Hu Signed-off-by: Philipp Zabel Signed-off-by: Bibby Hsieh Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 165 ++-- drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 3 +- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 31 drive

[PATCH 0/7] drm/mediatek: fix cursor issue and apply CMDQ in

2019-11-25 Thread Bibby Hsieh
-emeril.freedesktop.org/series/69015/) drm/mediatek: Check return value of mtk_drm_ddp_comp_for_plane (https://lore.kernel.org/patchwork/patch/1154517/) Bibby Hsieh (7): drm/mediatek: fix atomic_state reference counting drm/mediatek: put "event" in critical section drm/mediatek: use

[PATCH 1/7] drm/mediatek: fix atomic_state reference counting

2019-11-25 Thread Bibby Hsieh
() and ensure all the information in atomic_state already was updated in hardware for showing on screen and then schedules unreference_work to drop references on atomic_state. Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.") Signed-off-by: Bibby Hsieh --- drive

[PATCH 4/7] drm/mediatek: handle events when enabling/disabling crtc

2019-11-25 Thread Bibby Hsieh
it. Signed-off-by: Bibby Hsieh --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c index e38506d7a4e8..408a6d6a15ba 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c

[PATCH 3/7] drm/mediatek: use DRM core's atomic commit helper

2019-11-25 Thread Bibby Hsieh
The DRM core atomic helper now supports asynchronous commits natively. The custom drm implementation isn't needed anymore, remove it. Signed-off-by: Bibby Hsieh --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 92 +- drivers/gpu/drm/mediatek/mtk_drm_drv.h | 7 -- 2 files

[PATCH 2/7] drm/mediatek: put "event" in critical section

2019-11-25 Thread Bibby Hsieh
) Signed-off-by: Bibby Hsieh --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c index 68b92adc96bb..e38506d7a4e8 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c

[PATCH 5/7] drm/mediatek: update cursors by using async atomic update

2019-11-25 Thread Bibby Hsieh
Support to async updates of cursors by using the new atomic interface for that. Signed-off-by: Bibby Hsieh --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 41 ++- drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 3 ++ drivers/gpu/drm/mediatek/mtk_drm_drv.c | 4 ++ drivers/gpu/drm

[PATCH v2] drm/mediatek: support CMDQ interface in ddp component

2019-10-24 Thread Bibby Hsieh
-by: Bibby Hsieh Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_color.c | 7 +- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 65 +-- drivers/gpu/drm/mediatek/mtk_disp_rdma.c| 43 drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 114

[PATCH] drm/mediatek: covert to helper nonblocking atomic commit

2019-10-24 Thread Bibby Hsieh
In order to commit state asynchronously, we change .atomic_commit to drm_atomic_helper_commit(). Signed-off-by: Bibby Hsieh --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 11 drivers/gpu/drm/mediatek/mtk_drm_drv.c | 86 ++--- drivers/gpu/drm/mediatek/mtk_drm_drv.h | 7

[PATCH] drm/mediatek: update cursors by using async atomic update

2019-10-24 Thread Bibby Hsieh
Support to async updates of cursors by using the new atomic interface for that. Signed-off-by: Bibby Hsieh --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 32 + drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 3 ++ drivers/gpu/drm/mediatek/mtk_drm_plane.c | 44

[PATCH] arm64: dts: mt8183: Add gce setting in display node

2019-09-02 Thread Bibby Hsieh
In order to use GCE function, we need add some informations into display node (mboxes, mediatek,gce-client-reg, mediatek,gce-events). Signed-off-by: Bibby Hsieh Signed-off-by: Yongqiang Niu --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 15 +++ 1 file changed, 15 insertions

[PATCH 0/2] Support CMDQ interface and control flow

2019-08-30 Thread Bibby Hsieh
://patchwork.kernel.org/cover/11123119/) add drm support for MT8183 (https://patchwork.kernel.org/cover/11121519/) support gce on mt8183 platform (https://patchwork.kernel.org/cover/11120153/) Bibby Hsieh (2): drm/mediatek: Support CMDQ interface in ddp component drm/mediatek: Apply CMDQ control

[PATCH 2/2] drm/mediatek: Apply CMDQ control flow

2019-08-30 Thread Bibby Hsieh
Signed-off-by: CK Hu Signed-off-by: Philipp Zabel Signed-off-by: Bibby Hsieh Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 190 +--- drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 2 + drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 34 drive

[PATCH 1/2] drm/mediatek: Support CMDQ interface in ddp component

2019-08-30 Thread Bibby Hsieh
-by: CK Hu Signed-off-by: Philipp Zabel Signed-off-by: Bibby Hsieh Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_color.c | 7 +- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 78 +++--- drivers/gpu/drm/mediatek/mtk_disp_rdma.c| 66 ++-- drivers/gpu/drm

[PATCH 1/2] drm/mediatek: Only block updates to CRTCs that have a pending update

2019-08-30 Thread Bibby Hsieh
, and don't block if there are only pending updates for other CRTCs. Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.") Signed-off-by: Daniel Kurtz Signed-off-by: Bibby Hsieh --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 14 +- drivers/gpu/drm/mediatek/mtk_drm_dr

[PATCH 2/2] drm/mediatek: Bypass atomic helpers for cursor updates

2019-08-30 Thread Bibby Hsieh
("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.") Signed-off-by: Bibby Hsieh Signed-off-by: Daniel Kurtz --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 41 - drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 2 + drivers/gpu/drm/mediatek/mtk_drm_drv.c | 34 ++

[PATCH 0/2] drm/mediatek: fixup cursor moving unsmooth issue

2019-08-30 Thread Bibby Hsieh
These patches can fixup cursor moving is not smooth when heavy load in webgl. Bibby Hsieh (2): drm/mediatek: Only block updates to CRTCs that have a pending update drm/mediatek: Bypass atomic helpers for cursor updates drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 53 +- drivers/gpu/drm

[PATCH v5 09/11] drm/mediatek: add hdmi driver for MT2701 and MT7623

2018-10-02 Thread Bibby Hsieh
From: chunhui dai This patch adds hdmi dirver suppot for both MT2701 and MT7623. And also support other (existing or future) chips that use the same binding and driver. Signed-off-by: chunhui dai --- drivers/gpu/drm/mediatek/Makefile | 3 +- drivers/gpu/drm/mediatek/mtk_hdmi.c

[PATCH v5 06/11] drm/mediatek: add dpi driver for mt2701 and mt7623

2018-10-02 Thread Bibby Hsieh
From: chunhui dai This patch adds dpi dirver suppot for both mt2701 and mt7623. And also support other (existing or future) chips that use the same binding and driver. Reviewed-by: CK Hu Signed-off-by: chunhui dai --- drivers/gpu/drm/mediatek/mtk_dpi.c | 21 +

[PATCH v5 05/11] drm/mediatek: convert dpi driver to use drm_of_find_panel_or_bridge

2018-10-02 Thread Bibby Hsieh
From: chunhui dai Convert dpi driver to use drm_of_find_panel_or_bridge. This changes some error messages to debug messages (in the graph core). Graph connections are often "no connects" depending on the particular board, so we want to avoid spurious messages. Plus the kernel is not a DT

[PATCH v5 10/11] drm/mediatek: implement connection from BLS to DPI0

2018-10-02 Thread Bibby Hsieh
Modify display driver to support connection from BLS to DPI. Signed-off-by: Bibby Hsieh Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm

[PATCH v5 03/11] drm/mediatek: adjust EDGE to match clock and data

2018-10-02 Thread Bibby Hsieh
From: chunhui dai The default timing of DPI data and clock is not match. We could adjust this bit to make them match. Signed-off-by: chunhui dai Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_dpi.c | 8 drivers/gpu/drm/mediatek/mtk_dpi_regs.h | 1 + 2 files changed, 9

[PATCH v5 01/11] drm/mediatek: add refcount for DPI power on/off

2018-10-02 Thread Bibby Hsieh
power on/off to protect the flow. Signed-off-by: Bibby Hsieh Signed-off-by: chunhui dai Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_dpi.c | 43 -- 1 file changed, 13 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b

[PATCH v5 00/11] drm/mediatek: support hdmi output for mt2701 and mt7623

2018-10-02 Thread Bibby Hsieh
ion. Changes since v0: - Correct some typos in commit message. - Fixup the build warning (tmp variable didn't be initialized) Bibby Hsieh (2): drm/mediatek: implement connection from BLS to DPI0 drm/mediatek: add a error return value when clock driver has been prepared chunhui dai (9):

[PATCH v5 02/11] drm/mediatek: move hardware register to node data

2018-10-02 Thread Bibby Hsieh
From: chunhui dai The address of register DPI_H_FRE_CON is different in different IC. Using of_node data to find this address. Reviewed-by: CK Hu Signed-off-by: chunhui dai --- drivers/gpu/drm/mediatek/mtk_dpi.c | 19 --- drivers/gpu/drm/mediatek/mtk_dpi_regs.h | 1 - 2

[PATCH v5 08/11] drm/mediatek: add support for SPDIF audio in HDMI

2018-10-02 Thread Bibby Hsieh
From: chunhui dai add support for SPDIF audio in HDMI Signed-off-by: chunhui dai Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c index

[PATCH v5 11/11] drm/mediatek: add a error return value when clock driver has been prepared

2018-10-02 Thread Bibby Hsieh
DRM driver get the comp->clk by of_clk_get(), we only assign NULL to comp->clk when error happened, but do not return the error number. Signed-off-by: Bibby Hsieh Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v5 07/11] drm/mediatek: separate hdmi phy to different file

2018-10-02 Thread Bibby Hsieh
From: chunhui dai Different IC has different phy setting of HDMI. This patch separates the phy hardware relate part for mt8173. Signed-off-by: chunhui dai Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/Makefile | 6 +- drivers/gpu/drm/mediatek/mtk_hdmi.c| 1 +

[PATCH v5 04/11] drm/mediatek: add clock factor for different IC

2018-10-02 Thread Bibby Hsieh
From: chunhui dai different IC has different clock designed in HDMI, the factor for calculate clock should be different. Usinng the data in of_node to find this factor. Reviewed-by: CK Hu Signed-off-by: chunhui dai --- drivers/gpu/drm/mediatek/mtk_dpi.c | 24 +++- 1 file

[PATCH v4 01/11] drm/mediatek: add refcount for DPI power on/off

2018-10-02 Thread Bibby Hsieh
power on/off to protect the flow. Signed-off-by: Bibby Hsieh Signed-off-by: chunhui dai --- drivers/gpu/drm/mediatek/mtk_dpi.c | 43 -- 1 file changed, 13 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek

[PATCH v4 06/11] drm/mediatek: add dpi driver for mt2701 and mt7623

2018-10-02 Thread Bibby Hsieh
From: chunhui dai This patch adds dpi dirver suppot for both mt2701 and mt7623. And also support other (existing or future) chips that use the same binding and driver. Reviewed-by: CK Hu Signed-off-by: chunhui dai --- drivers/gpu/drm/mediatek/mtk_dpi.c | 21 +

[PATCH v4 02/11] drm/mediatek: move hardware register to node data

2018-10-02 Thread Bibby Hsieh
From: chunhui dai The address of register DPI_H_FRE_CON is different in different IC. Using of_node data to find this address. Reviewed-by: CK Hu Signed-off-by: chunhui dai --- drivers/gpu/drm/mediatek/mtk_dpi.c | 19 --- drivers/gpu/drm/mediatek/mtk_dpi_regs.h | 1 - 2

[PATCH v4 10/11] drm/mediatek: implement connection from BLS to DPI0

2018-10-02 Thread Bibby Hsieh
Modify display driver to support connection from BLS to DPI. Signed-off-by: Bibby Hsieh Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm

[PATCH v4 08/11] drm/mediatek: add support for SPDIF audio in HDMI

2018-10-02 Thread Bibby Hsieh
From: chunhui dai add support for SPDIF audio in HDMI Signed-off-by: chunhui dai Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c index

[PATCH v4 05/11] drm/mediatek: convert dpi driver to use drm_of_find_panel_or_bridge

2018-10-02 Thread Bibby Hsieh
From: chunhui dai Convert dpi driver to use drm_of_find_panel_or_bridge. This changes some error messages to debug messages (in the graph core). Graph connections are often "no connects" depending on the particular board, so we want to avoid spurious messages. Plus the kernel is not a DT

[PATCH v4 04/11] drm/mediatek: add clock factor for different IC

2018-10-02 Thread Bibby Hsieh
From: chunhui dai different IC has different clock designed in HDMI, the factor for calculate clock should be different. Usinng the data in of_node to find this factor. Reviewed-by: CK Hu Signed-off-by: chunhui dai --- drivers/gpu/drm/mediatek/mtk_dpi.c | 24 +++- 1 file

[PATCH v4 03/11] drm/mediatek: adjust EDGE to match clock and data

2018-10-02 Thread Bibby Hsieh
From: chunhui dai The default timing of DPI data and clock is not match. We could adjust this bit to make them match. Signed-off-by: chunhui dai Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_dpi.c | 8 drivers/gpu/drm/mediatek/mtk_dpi_regs.h | 1 + 2 files changed, 9

[PATCH v4 07/11] drm/mediatek: separate hdmi phy to different file

2018-10-02 Thread Bibby Hsieh
From: chunhui dai Different IC has different phy setting of HDMI. This patch separates the phy hardware relate part for mt8173. Signed-off-by: chunhui dai --- drivers/gpu/drm/mediatek/Makefile | 6 +- drivers/gpu/drm/mediatek/mtk_hdmi.c| 1 +

[PATCH v4 00/11] drm/mediatek: support hdmi output for mt2701 and mt7623

2018-10-02 Thread Bibby Hsieh
age. - Fixup the build warning (tmp variable didn't be initialized) Bibby Hsieh (2): drm/mediatek: implement connection from BLS to DPI0 drm/mediatek: add a error return value when clock driver has been prepared chunhui dai (9): drm/mediatek: add refcount for DPI power on/off drm/media

[PATCH v4 09/11] drm/mediatek: add hdmi driver for MT2701 and MT7623

2018-10-02 Thread Bibby Hsieh
From: chunhui dai This patch adds hdmi dirver suppot for both MT2701 and MT7623. And also support other (existing or future) chips that use the same binding and driver. Signed-off-by: chunhui dai --- drivers/gpu/drm/mediatek/Makefile | 3 +- drivers/gpu/drm/mediatek/mtk_hdmi.c

[PATCH v4 11/11] drm/mediatek: add a error return value when clock driver has been prepared

2018-10-02 Thread Bibby Hsieh
DRM driver get the comp->clk by of_clk_get(), we only assign NULL to comp->clk when error happened, but do not return the error number. Signed-off-by: Bibby Hsieh Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v3 12/12] drm/mediatek: config component output by device node port

2018-09-20 Thread Bibby Hsieh
We can select output component by decive node port. Main path default output component is DSI. External path default output component is DPI. Signed-off-by: Bibby Hsieh --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 37 ++ drivers/gpu/drm/mediatek/mtk_drm_drv.h

[PATCH v3 02/12] drm/mediatek: move hardware register to node data

2018-09-20 Thread Bibby Hsieh
From: chunhui dai The address of register DPI_H_FRE_CON is different in different IC. Using of_node data to find this address. Signed-off-by: chunhui dai --- drivers/gpu/drm/mediatek/mtk_dpi.c | 19 --- drivers/gpu/drm/mediatek/mtk_dpi_regs.h | 1 - 2 files changed, 16

  1   2   3   >