Re: [PATCH 3/5] drm/v3d: Create a struct to store the GPU stats

2024-04-15 Thread Chema Casanova
El 3/4/24 a las 22:24, Maíra Canal escribió: This will make it easier to instantiate the GPU stats variables and it will create a structure where we can store all the variables that refer to GPU stats. Signed-off-by: Maíra Canal --- drivers/gpu/drm/v3d/v3d_drv.c | 14 ++

Re: [PATCH 4/5] drm/v3d: Create function to update a set of GPU stats

2024-04-15 Thread Chema Casanova
El 3/4/24 a las 22:24, Maíra Canal escribió: Given a set of GPU stats, that is, a `struct v3d_stats` related to a queue in a given context, create a function that can update all this set of GPU stats. Signed-off-by: Maíra Canal --- drivers/gpu/drm/v3d/v3d_sched.c | 20

Re: [PATCH 1/5] drm/v3d: Don't increment `enabled_ns` twice

2024-04-15 Thread Chema Casanova
El 3/4/24 a las 22:24, Maíra Canal escribió: The commit 509433d8146c ("drm/v3d: Expose the total GPU usage stats on sysfs") introduced the calculation of global GPU stats. For the regards, it used the already existing infrastructure provided by commit 09a93cc4f7d1 ("drm/v3d: Implement

Re: [PATCH 2/5] drm/v3d: Create two functions to update all GPU stats variables

2024-04-15 Thread Chema Casanova
El 3/4/24 a las 22:24, Maíra Canal escribió: Currently, we manually perform all operations to update the GPU stats variables. Apart from the code repetition, this is very prone to errors, as we can see on the previous commit. Therefore, create two functions to manage updating all GPU stats

Re: [PATCH v3 0/2] drm/v3d: Expose GPU usage stats

2023-10-24 Thread Chema Casanova
cument the expected behavior in case of a GPU reset (Melissa Wen) * Add a brief description about the sysfs outputs (Melissa Wen) * Instead of having multiple sysfs files, use only one sysfs file, called gpu_stats, with all the information (Chema Casanova) * Add the number of jobs submitted in the

Re: [PATCH] drm/vc4: add tracepoints for CL submissions

2022-03-10 Thread Chema Casanova
(Emma, Iago maybe?) I'll be definitely be ok merging that patch I've checked this patch and I've been using these tracepoints. They have been working properly. Reviewed-by: Jose Maria Casanova Crespo Regards, Chema Casanova

Re: [PATCH 3/3] drm/v3d: Add job timeout module param

2021-02-10 Thread Chema Casanova
On 5/2/21 13:28, Yukimasa Sugizaki wrote: On 05/02/2021, Eric Anholt wrote: On Thu, Feb 4, 2021 at 10:09 AM Chema Casanova wrote: On 3/9/20 18:48, Yukimasa Sugizaki wrote: From: Yukimasa Sugizaki The default timeout is 500 ms which is too short for some workloads including Piglit

Re: [PATCH 3/3] drm/v3d: Add job timeout module param

2021-02-04 Thread Chema Casanova
mething such complex. I think it would also make sense to increase our default value for the compute jobs. What do you think? In any case I think that having this general scheduling timeout parameter as other drivers do is a good idea. Regards, Chema Casanova static struct v3d_

Re: [PATCH 1/3] drm/v3d: Don't resubmit guilty CSD jobs

2021-02-04 Thread Chema Casanova
I've tested the patch and confirmed that applies correctly over drm-next. I've also confirmed that the timeout happens with the described test case by the developer. https://github.com/raspberrypi/linux/pull/3816#issuecomment-682251862 Considering this is my first review of a patch in v3d