Re: [PATCH v2] MAINTAINERS: add Dan Murphy as TP LP8xxx drivers maintainer

2020-09-24 Thread Dan Murphy
Hello On 9/22/20 10:28 AM, Krzysztof Kozlowski wrote: Milo Kim's email in TI bounces with permanent error (550: Invalid recipient). Last email from him on LKML was in 2017. Move Milo Kim to credits and add Dan Murphy from TI to look after: - TI LP855x backlight driver, - TI LP8727 ch

Re: [PATCH] MAINTAINERS: move Milo Kim to credits

2020-09-23 Thread Dan Murphy
e a few patches this year to fix random bugs. Since I have worked in these other subsystems if replacing the Maintainer is desired over removal then my name and email can be added like I did with Andrews. Dan Murphy Dan ___ dri-dev

Re: [PATCH 2/7] docs: dt: fix several broken references due to renames

2020-02-24 Thread Dan Murphy
eds/common.yaml| 2 +- For LEDs Reviewed-by: Dan Murphy ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH V6 5/8] backlight: qcom-wled: Restructure the driver for WLED3

2019-10-01 Thread Dan Murphy
Kiran On 9/30/19 1:39 AM, Kiran Gunda wrote: Restructure the driver to add the support for new WLED peripherals. Signed-off-by: Kiran Gunda Acked-by: Daniel Thompson --- drivers/video/backlight/qcom-wled.c | 395 ++-- 1 file changed, 245 insertions(+), 150 d

Re: [PATCH V6 3/8] backlight: qcom-wled: Add new properties for PMI8998

2019-10-01 Thread Dan Murphy
Kiran On 9/30/19 1:39 AM, Kiran Gunda wrote: Update the bindings with the new properties used for PMI8998. Signed-off-by: Kiran Gunda Reviewed-by: Bjorn Andersson Reviewed-by: Rob Herring Acked-by: Daniel Thompson --- .../bindings/leds/backlight/qcom-wled.txt | 76 +++

Re: [PATCH V6 2/8] backlight: qcom-wled: restructure the qcom-wled bindings

2019-10-01 Thread Dan Murphy
Kiran On 9/30/19 1:39 AM, Kiran Gunda wrote: Restructure the qcom-wled bindings for the better readability. Signed-off-by: Kiran Gunda Reviewed-by: Bjorn Andersson Reviewed-by: Rob Herring Acked-by: Daniel Thompson Acked-by: Pavel Machek --- .../bindings/leds/backlight/qcom-wled.txt

Re: [PATCH V6 1/8] backlight: qcom-wled: Rename pm8941-wled.c to qcom-wled.c

2019-10-01 Thread Dan Murphy
Kiran On 9/30/19 1:39 AM, Kiran Gunda wrote: pm8941-wled.c driver is supporting the WLED peripheral on pm8941. Rename it to qcom-wled.c so that it can support WLED on multiple PMICs. Signed-off-by: Kiran Gunda Reviewed-by: Bjorn Andersson Acked-by: Rob Herring Acked-by: Daniel Thompson Acke

Re: [PATCH v4 1/2] dt-bindings: backlight: lm3630a: add enable_gpios

2019-09-13 Thread Dan Murphy
Andreas On 9/12/19 4:32 PM, Andreas Kemnade wrote: add enable-gpios to describe HWEN pin Signed-off-by: Andreas Kemnade Acked-by: Daniel Thompson Reviewed-by: Dan Murphy --- changes in v2: added example changes in v3: added Acked-by changes in v4: moved enable-gpios to the right

Re: [PATCH v3 1/2] dt-bindings: backlight: lm3630a: add enable_gpios

2019-09-12 Thread Dan Murphy
Andreas On 9/12/19 9:58 AM, Andreas Kemnade wrote: On Thu, 12 Sep 2019 06:39:50 -0500 Dan Murphy wrote: Andreas On 9/11/19 12:21 PM, Andreas Kemnade wrote: add enable-gpios to describe HWEN pin Signed-off-by: Andreas Kemnade Acked-by: Daniel Thompson --- changes in v2: added example

Re: [PATCH v3 2/2] backlight: lm3630a: add an enable gpio for the HWEN pin

2019-09-12 Thread Dan Murphy
; + } + /* chip initialize */ rval = lm3630a_chip_init(pchip); if (rval < 0) { Thanks for the explanation It looks good to me Reviewed-by: Dan Murphy

Re: [PATCH v3 1/2] dt-bindings: backlight: lm3630a: add enable_gpios

2019-09-12 Thread Dan Murphy
- reg @@ -92,6 +96,7 @@ examples: i2c { #address-cells = <1>; #size-cells = <0>; +enable-gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>; led-controller@38 { compatible = "ti,lm3630a"; Looks good to me Reviewed-by: Dan Murphy

Re: [PATCH v2 2/2] backlight: lm3630a: add an enable gpio for the HWEN pin

2019-09-11 Thread Dan Murphy
On 9/11/19 5:25 AM, Daniel Thompson wrote: On Tue, Sep 10, 2019 at 11:29:09PM +0200, Andreas Kemnade wrote: For now just enable it in the probe function to allow i2c access. Disabling also means resetting the register values to default and according to the datasheet does not give power savings

Re: [PATCH v2 1/2] dt-bindings: backlight: lm3630a: add enable_gpios

2019-09-11 Thread Dan Murphy
Andreas On 9/11/19 5:08 AM, Daniel Thompson wrote: On Tue, Sep 10, 2019 at 11:29:08PM +0200, Andreas Kemnade wrote: add enable-gpios to describe HWEN pin Signed-off-by: Andreas Kemnade Acked-by: Daniel Thompson --- changes in v2: add example .../bindings/leds/backlight/lm3630a-backlight

Re: [PATCH 1/2] dt-bindings: backlight: fix vendor prefix for ArcticSand arcxcnn driver bindings

2019-07-10 Thread Dan Murphy
his stuff. On Mon, Jul 8, 2019 at 2:02 PM Dan Murphy <mailto:dmur...@ti.com>> wrote: Brian On 6/30/19 7:28 PM, Brian Dodge wrote: > The vendor-prefixes.txt file properly refers to ArcticSand > as arctic but the driver bindings improperly abbreviated the > pre

Re: [PATCH 2/2] backlight: arcxcnn: add "arctic" vendor prefix

2019-07-09 Thread Dan Murphy
we should retain the ArcticSand copyright as well. Probably a question for your legal department. Otherwise Reviewed-by: Dan Murphy + * Copyright 2016-2019 pSemi, Inc. + * Author : Brian Dodge */ #include @@ -191,27 +191,46 @@ static void arcxcnn_parse_dt(struct arcxcnn *lp)

Re: [PATCH 1/2] dt-bindings: backlight: fix vendor prefix for ArcticSand arcxcnn driver bindings

2019-07-09 Thread Dan Murphy
Note: Optional properties not specified will default to values in IC EPROM Example: arc2c0608@30 { - compatible = "arc,arc2c0608"; + compatible = "arctic,arc2c0608"; reg = <0x30>; default-brightness = <500>; label = &

Re: [PATCH 2/4] devicetree: Update led binding

2019-07-01 Thread Dan Murphy
JJ On 7/1/19 10:14 AM, Jean-Jacques Hiblot wrote: Update the led binding to describe the possibility to add a "compatible" option to create a child-device, user of the LED. Signed-off-by: Jean-Jacques Hiblot Cc: devicet...@vger.kernel.org --- Documentation/devicetree/bindings/leds/common.txt

Re: [PATCH 2/2] backlight: arcxcnn: add "arctic" vendor prefix

2019-06-27 Thread Dan Murphy
Hello One other thing On 6/26/19 6:42 AM, Dan Murphy wrote: Hello On 6/24/19 11:05 PM, Brian Dodge wrote: The original patch adding this driver and DT bindings improperly used "arc" as the vendor-prefix. This adds "arctic" which is the proper prefix and retains "arc

Re: [PATCH 1/2] dt-bindings: backlight: fix vendor prefix for ArcticSand arcxcnn driver bindings

2019-06-27 Thread Dan Murphy
Hello On 6/25/19 3:55 AM, Daniel Thompson wrote: On Tue, Jun 25, 2019 at 12:05:28AM -0400, Brian Dodge wrote: The vendor-prefixes.txt file properly refers to ArcticSand as arctic but the driver bindings improperly abbreviated the prefix to arc. This was a mistake in the original

Re: [PATCH 1/2] dt-bindings: backlight: fix vendor prefix for ArcticSand arcxcnn driver bindings

2019-06-27 Thread Dan Murphy
On 6/26/19 9:56 AM, Pavel Machek wrote: On Wed 2019-06-26 11:56:14, Daniel Thompson wrote: On Tue, Jun 25, 2019 at 07:44:06AM -0400, Brian Dodge wrote: I would like to deprecate the old prefix in the future after communicating with all chip customers, which is why the old prefix is not documen

Re: [PATCH 2/2] backlight: arcxcnn: add "arctic" vendor prefix

2019-06-27 Thread Dan Murphy
Hello On 6/24/19 11:05 PM, Brian Dodge wrote: The original patch adding this driver and DT bindings improperly used "arc" as the vendor-prefix. This adds "arctic" which is the proper prefix and retains "arc" to allow existing users of the "arc" prefix to update to new kernels. There is at least

Re: [PATCH] dt-bindings: backlight: lm3630a: correct schema validation

2019-05-21 Thread Dan Murphy
>>> >>> Fixes: 32fcb75c66a0 ("dt-bindings: backlight: Add lm3630a bindings") >>> Signed-off-by: Brian Masney >>> Reported-by: Rob Herring >>> --- >>> .../leds/backlight/lm3630a-backlight.yaml | 20 +-- >>> 1 file changed, 14 insertions(+), 6 deletions(-) >> >> Reviewed-by: Rob Herring > > Acked-by: Daniel Thompson > Acked-by: Dan Murphy

Re: [PATCH v3 3/3] backlight: lm3630a: add firmware node support

2019-05-02 Thread Dan Murphy
Pavel On 5/1/19 3:26 AM, Pavel Machek wrote: > Hi! > >>> @@ -396,13 +506,20 @@ static int lm3630a_probe(struct i2c_client *client, >>> GFP_KERNEL); >>> if (pdata == NULL) >>> return -ENOMEM; >>> + >>> /* default values *

Re: [PATCH v5 3/3] backlight: lm3630a: add firmware node support

2019-04-24 Thread Dan Murphy
Hello On 4/18/19 10:11 AM, Brian Masney wrote: > Add fwnode support to the lm3630a driver and optionally allow > configuring the label, default brightness level, and maximum brightness > level. The two outputs can be controlled by bank A and B independently > or bank A can control both outputs. >

Re: [PATCH v5 3/3] backlight: lm3630a: add firmware node support

2019-04-24 Thread Dan Murphy
Brian On 4/23/19 11:00 AM, Brian Masney wrote: > On Tue, Apr 23, 2019 at 10:31:41AM -0500, Dan Murphy wrote: >> On 4/23/19 9:01 AM, Brian Masney wrote: >>> On Tue, Apr 23, 2019 at 08:49:20AM -0500, Dan Murphy wrote: >>>>> +static int lm3630a_parse_led_s

Re: [PATCH v5 3/3] backlight: lm3630a: add firmware node support

2019-04-24 Thread Dan Murphy
Brian On 4/23/19 9:01 AM, Brian Masney wrote: > On Tue, Apr 23, 2019 at 08:49:20AM -0500, Dan Murphy wrote: >>> +static int lm3630a_parse_led_sources(struct fwnode_handle *node, >>> +int default_led_sources) >>> +{ >>

Re: [PATCH v4 3/3] backlight: lm3630a: add firmware node support

2019-04-18 Thread Dan Murphy
Brian On 4/16/19 6:53 PM, Brian Masney wrote: > Add fwnode support to the lm3630a driver and optionally allow > configuring the label, default brightness level, and maximum brightness > level. The two outputs can be controlled by bank A and B independently > or bank A can control both outputs. >

Re: [PATCH v3 2/3] dt-bindings: backlight: add lm3630a bindings

2019-04-16 Thread Dan Murphy
Brian On 4/15/19 2:29 AM, Brian Masney wrote: > Add new backlight bindings for the TI LM3630A dual-string white LED. > > Signed-off-by: Brian Masney > --- > Rob: Since the common bindings aren't converted to the new JSON schema > yet, I'm not sure how to do led-sources here. I would expect that w

Re: [PATCH v3 3/3] backlight: lm3630a: add firmware node support

2019-04-16 Thread Dan Murphy
On 4/15/19 2:29 AM, Brian Masney wrote: > Add fwnode support to the lm3630a driver and allow configuring > the initial and maximum LED brightness on both LED banks independently. > The two outputs can be controlled by bank A and B independently or > bank A can control both outputs. > > If the pl

Re: [PATCH v2 3/3] backlight: lm3630a: add device tree supprt

2019-04-02 Thread Dan Murphy
evice_id lm3630a_id[] = { > {} > }; > > +static const struct of_device_id lm3630a_match_table[] = { > + { .compatible = "ti,lm3630a", }, > + { }, > +}; > + > + > MODULE_DEVICE_TABLE(i2c, lm3630a_id); > > static struct i2c_driver lm3630a_i2c_driver = { > .driver = { > .name = LM3630A_NAME, > +.of_match_table = lm3630a_match_table, > }, > .probe = lm3630a_probe, > .remove = lm3630a_remove, > -- -- Dan Murphy ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 2/3] dt-bindings: backlight: add lm3630a bindings

2019-04-02 Thread Dan Murphy
; > + > +lm3630a_bl@38 { > +compatible = "ti,lm3630a"; > +status = "ok"; > +reg = <0x38>; > + > +led-bank-a { > +led-sources = <0>; > +default-brightness = <150>; > +ti,linear-mapping-mode; > +}; > + > +led-bank-b { > +led-sources = <1>; > +default-brightness = <225>; > +ti,linear-mapping-mode; > +}; > +}; > +}; > -- -- Dan Murphy ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 2/3] dt-bindings: backlight: add lm3630a bindings

2019-04-02 Thread Dan Murphy
Brian On 4/2/19 8:24 AM, Brian Masney wrote: > On Tue, Apr 02, 2019 at 07:56:55AM -0500, Dan Murphy wrote: >> This would connect control bank B to control bank A. Or just use a flag to >> denote to connect them >> and not use led-sources. But led-sources is the property o

Re: [PATCH v2 3/3] backlight: lm3630a: add device tree supprt

2019-04-02 Thread Dan Murphy
On 4/2/19 11:45 AM, Pavel Machek wrote: > On Tue 2019-04-02 08:45:40, Dan Murphy wrote: >> Hello >> >> On 4/1/19 5:30 AM, Brian Masney wrote: >>> Add device tree support to the lm3630a driver and allow configuring >>> independently on both banks

Re: [PATCH 1/2] dt-bindings: trivial: add ti,lm3630a binding

2018-12-02 Thread Dan Murphy
we could use the property default-brightness-level for leda_init_brt >> and ledb_init_brt in struct lm3630a_platform_data. The max-brightness >> property can populate leda_max_brt and ledb_max_brt. >> >> I need to look at other bindings this weekend to see if there are any &g