Re: [PATCH v1] drm/ci: uprev IGT and deqp-runner

2024-09-05 Thread Daniel Stone
Hi Vignesh, On Thu, 5 Sept 2024 at 10:41, Vignesh Raman wrote: > Uprev IGT to the latest version and deqp-runner > to v0.20.0. Also update expectation files. Thanks! This is: Reviewed-by: Daniel Stone

Re: [RFC PATCH 00/17] VKMS: Add configfs support

2024-08-14 Thread Daniel Stone
Hi José, On Tue, 13 Aug 2024 at 11:51, José Expósito wrote: > - When a CRTC is added and removed before device creation, there >is a vblank warning. >The issue is caused because vblanks are referenced using the >CRTC index but, because one of the CRTCs is removed, the >indices ar

Re: [PATCH v1] drm/ci: uprev mesa

2024-08-07 Thread Daniel Stone
On Wed, 7 Aug 2024 at 09:21, Vignesh Raman wrote: > Uprev mesa to adapt to the latest changes in mesa ci. > Project 'anholt/deqp-runner' was moved to 'mesa/deqp-runner'. > So update the link. Reviewed-by: Daniel Stone

Re: [PATCH v9 0/6] drm/ci: Add support for GPU and display testing

2024-08-05 Thread Daniel Stone
it series adds support in drm-ci to run tests > for both GPU and display drivers for MediaTek mt8173/mt8183, Rockchip > rk3288/rk3399, and Amlogic Meson G12B (A311D) platforms. > > Update the expectations file, and skip driver-specific tests and > tools_test on non-intel platforms. Tha

Re: [PATCH v3] rockchip/drm: vop2: add support for gamma LUT

2024-07-26 Thread Daniel Stone
Hi Piotr, On Thu, 25 Jul 2024 at 20:06, Piotr Zalewski wrote: > I based my patch on how gamma LUT is handled in VOP. There, in atomic > enable, gamma LUT write takes places at the end too, after the mutex was > already first-time unlocked. I understand the concept of DRM atomic state > updates an

Re: [PATCH v8 5/5] drm/ci: rockchip: add tests for rockchip display driver

2024-07-26 Thread Daniel Stone
Hi Vignesh, On Wed, 24 Jul 2024 at 11:12, Vignesh Raman wrote: > For rockchip rk3288 and rk3399, the display driver is rockchip > and gpu driver is panfrost. Currently, in drm-ci for rockchip > rk3288 and rk3399, only the gpu driver is tested. Refactor > the existing rockchip jobs to test both di

Re: [PATCH v8 2/5] drm/ci: mediatek: add tests for mediatek display driver

2024-07-26 Thread Daniel Stone
Hi Vignesh, On Wed, 24 Jul 2024 at 11:11, Vignesh Raman wrote: > +dumb_buffer@create-clear,Fail > +dumb_buffer@create-valid-dumb,Fail > +dumb_buffer@invalid-bpp,Fail > +dumb_buffer@map-invalid-size,Fail > +dumb_buffer@map-uaf,Fail > +dumb_buffer@map-valid,Fail > +fbdev@eof,Fail > +fbdev@read,Fail

Re: [PATCH v3] rockchip/drm: vop2: add support for gamma LUT

2024-07-25 Thread Daniel Stone
Hi Piotr, On Wed, 24 Jul 2024 at 23:06, Piotr Zalewski wrote: > Add support for gamma LUT in VOP2 driver. The implementation is based on > the one found in VOP driver and modified to be compatible with VOP2. Blue > and red channels in gamma LUT register write were swapped with respect to > how ga

Re: [PATCH] drm/mediatek: Declare Z Position for all planes

2024-07-18 Thread Daniel Stone
andle overlapping overlay planes, and any userspace which supports overlays (including Weston) already looks at zpos, handles immutable properties, and will dtrt. Anyway, this is: Acked-by: Daniel Stone Cheers, Daniel

Re: [PATCH] drm/mediatek: Set sensible cursor width/height values to fix crash

2024-07-18 Thread Daniel Stone
ame change before: > > Reviewed-by: Fei Shao > > Tested-by: Fei Shao > > Thanks! And: Reviewed-by: Daniel Stone > >> OOTH, Intel recently added a feature for enumerating "suggested" > >> cursor sizes. See https://patchwork.freedesktop.org/patc

Re: [PATCH] drm/ci: update link to Gitlab server

2024-07-18 Thread Daniel Stone
te the link from anongit to the Gitlab server to prevent the build > script from hanging indefinitely. It should be fixed by now, but yeah, the canonical source has changed. Reviewed-by: Daniel Stone Thanks Deborah! Cheers, Daniel

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-06-28 Thread Daniel Stone
Hi, On Fri, 28 Jun 2024 at 10:43, Tomeu Vizoso wrote: > On Wed, Jun 26, 2024 at 9:26 PM Daniel Stone wrote: > > It's not just etnaviv, it's literally every Mesa driver which works > > with decoupled render/display. So that would be etnaviv-v2, > > panfrost-v2,

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-06-26 Thread Daniel Stone
On Wed, 26 Jun 2024 at 18:52, Daniel Vetter wrote: > On Wed, Jun 26, 2024 at 11:39:01AM +0100, Daniel Stone wrote: > > On Wed, 26 Jun 2024 at 09:28, Lucas Stach wrote: > > > So we are kind of stuck here between breaking one or the other use- > > > case. I'm leani

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-06-26 Thread Daniel Stone
Hi, On Wed, 26 Jun 2024 at 09:28, Lucas Stach wrote: > Mesa doesn't cope right now. Mostly because of the renderonly thing > where we magically need to match render devices to otherwise render > incapable KMS devices. The way this matching works is that the > renderonly code tries to open a scree

Re: [PATCH v2 1/2] MAINTAINERS: drm: vc4: Add Raspberry Pi as maintainers

2024-06-21 Thread Daniel Stone
Hi Dave, On Fri, 21 Jun 2024 at 14:19, Dave Stevenson wrote: > Add myself as maintainer for VC4 alongside Maxime, and > our internal review list as reviewer. Both patches are: Acked-by: Daniel Stone Cheers, Daniel

Re: [PATCH v3 2/9] drm: Export drm_plane_has_format()

2024-06-19 Thread Daniel Stone
On Wed, 19 Jun 2024 at 12:31, Ville Syrjala wrote: > Export drm_plane_has_format() so that drivers can use it. Acked-by: Daniel Stone

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-05-20 Thread Daniel Stone
Hi, On Mon, 20 May 2024 at 08:39, Tomeu Vizoso wrote: > On Fri, May 10, 2024 at 10:34 AM Lucas Stach wrote: > > Am Mittwoch, dem 24.04.2024 um 08:37 +0200 schrieb Tomeu Vizoso: > > > If we expose a render node for NPUs without rendering capabilities, the > > > userspace stack will offer it to co

Re: [PATCH 0/2] drm/fourcc.h: Add libcamera to Open Source Waiver

2024-05-09 Thread Daniel Stone
nd its extensions, 2) Vulkan and its extensions, 3) libcamera. But it doesn't really make much difference; people are going to get the point. With whatever reasonable wording, series is: Reviewed-by: Daniel Stone Thanks Jacopo! -d

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-09 Thread Daniel Stone
Hi, On Wed, 8 May 2024 at 16:49, Daniel Vetter wrote: > On Wed, May 08, 2024 at 09:38:33AM +0100, Daniel Stone wrote: > > Right now, if your platform requires CMA for display, then the app > > needs access to the GPU render node and the display node too, in order > > to a

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-08 Thread Daniel Stone
On Wed, 8 May 2024 at 09:33, Daniel Vetter wrote: > On Wed, May 08, 2024 at 06:46:53AM +0100, Daniel Stone wrote: > > That would have the unfortunate side effect of making sandboxed apps > > less efficient on some platforms, since they wouldn't be able to do > > direct

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-07 Thread Daniel Stone
Hi, On Tue, 7 May 2024 at 12:15, Daniel Vetter wrote: > On Mon, May 06, 2024 at 04:01:42PM +0200, Hans de Goede wrote: > > On 5/6/24 3:38 PM, Daniel Vetter wrote: > > I agree that bad applications are an issue, but not for the flathub / snaps > > case. Flatpacks / snaps run sandboxed and don't ha

Re: [PATCH v2 1/2] drm: Introduce plane SIZE_HINTS property

2024-02-28 Thread Daniel Stone
/HEIGHT caps, which can only declare > a one size fits all limit for the whole device. Acked-by: Daniel Stone Cheers, Daniel

Re: drm-misc migration to Gitlab server

2024-02-26 Thread Daniel Stone
On Mon, 26 Feb 2024 at 12:03, Jani Nikula wrote: > On Mon, 26 Feb 2024, Daniel Stone wrote: > > It's a fair question. If you want to verify that someone is > > @intel.com, maybe get them to email you out-of-band to check it. If > > you want to check something else, j

Re: drm-misc migration to Gitlab server

2024-02-26 Thread Daniel Stone
On Mon, 26 Feb 2024 at 11:57, Jani Nikula wrote: > On Mon, 26 Feb 2024, Maxime Ripard wrote: > > For the recent-ish subscriptions, it's possible since we've required to > > open a Gitlab issue for a while, so we have the association between the > > Gitlab account and the SSH account already. > >

Re: [PULL] drm-xe-next

2024-02-26 Thread Daniel Stone
Hi, On Mon, 26 Feb 2024 at 03:21, Lucas De Marchi wrote: > All of this should be fixed by now: dim is used for applying and pushing > patches, which has additional checks so that doesn't happen again. Still > pending confirmation from Daniel Stone if the git server hooks are ready

Re: drm-misc migration to Gitlab server

2024-02-20 Thread Daniel Stone
Hi Stephen, On Tue, 20 Feb 2024 at 22:46, Stephen Rothwell wrote: > On Tue, 20 Feb 2024 11:25:05 +0000 Daniel Stone wrote: > > cc sfr - once we move the DRM repos to a different location, what's > > the best way to update linux-next? > > These are (I think) all the

Re: drm-misc migration to Gitlab server

2024-02-20 Thread Daniel Stone
On Tue, 20 Feb 2024 at 09:05, Maxime Ripard wrote: > On Tue, Feb 20, 2024 at 09:49:25AM +0100, Maxime Ripard wrote: > > This will be mostly transparent to current committers and users: we'll > > still use dim, in the exact same way, the only change will be the URL of > > the repo. This will also b

Re: [PATCH 1/2] drm/tidss: Fix initial plane zpos values

2024-02-16 Thread Daniel Stone
Hi, On Fri, 16 Feb 2024 at 09:00, Tomi Valkeinen wrote: > On 13/02/2024 13:39, Daniel Stone wrote: > > Specifically, you probably want commits 4cde507be6a1 and 58dde0e0c000. > > I think the window of breakage was small enough that - assuming either > > those commits or an up

Re: [PATCH 1/2] drm/tidss: Fix initial plane zpos values

2024-02-13 Thread Daniel Stone
Hi, On Tue, 13 Feb 2024 at 10:18, Marius Vlad wrote: > On Tue, Feb 13, 2024 at 11:57:59AM +0200, Tomi Valkeinen wrote: > > I haven't. I'm quite unfamiliar with Weston, and Randolph from TI (cc'd) has > > been working on the Weston side of things. I also don't know if there's > > something TI spec

Re: [PATCH] drm/vmwgfx: Filter modes which exceed 3/4 of graphics memory.

2024-02-06 Thread Daniel Stone
On Wed, 31 Jan 2024 at 02:31, Zack Rusin wrote: > On Tue, Jan 30, 2024 at 6:50 PM Daniel Stone wrote: > > The entire model we have is that basis timing flows backwards. The > > 'hardware' gives us a deadline, KMS angles to meet that with a small > > margin, the

Re: [PATCH] drm/vmwgfx: Filter modes which exceed 3/4 of graphics memory.

2024-01-30 Thread Daniel Stone
Hi, On Tue, 30 Jan 2024 at 18:39, Zack Rusin wrote: > In general, yes. Of course it's a little more convoluted because we'll > act like OpenGL runtime here (i.e. glXSwapBuffers), i.e. our driver > will fake page-flips because the only memory we'll have is a single > buffer as the actual page-flip

Re: [PATCH] drm/etnaviv: fix DMA direction handling for cached read/write buffers

2024-01-29 Thread Daniel Stone
Hi Lucas, On Fri, 26 Jan 2024 at 17:00, Lucas Stach wrote: > The dma sync operation needs to be done with DMA_BIDIRECTIONAL when > the BO is prepared for both read and write operations. With the > current inverted if ladder it would only be synced for DMA_FROM_DEVICE. > > [...] > > static inline

Re: [PATCH v2 2/7] drm/ci: mediatek: Rename exisitng job

2024-01-16 Thread Daniel Stone
Hi Vignesh, On Tue, 16 Jan 2024 at 09:55, Vignesh Raman wrote: > Rename the name of xfail files for mediatek (mt8173 and mt8183), > to include information about the tested driver and update xfails > accordingly. Since the correct driver name is passed from the job to > test gpu and display driver

Re: [PATCH v1 0/8] drm/ci: Add support for GPU and display testing

2024-01-11 Thread Daniel Stone
Hi Vignesh, On Wed, 10 Jan 2024 at 10:47, Vignesh Raman wrote: > On 09/01/24 19:08, Daniel Stone wrote: > > A better sequencing would be something like: > >1. add ANX7625 config > >2. refactor _existing_ MTK display jobs to use YAML includes, change > > the ex

Re: [PATCH 2/7] drm/uAPI: Add "active color format" drm property as feedback for userspace

2024-01-10 Thread Daniel Stone
Hi, On Wed, 10 Jan 2024 at 10:44, Daniel Vetter wrote: > On Tue, Jan 09, 2024 at 11:12:11PM +, Andri Yngvason wrote: > > ţri., 9. jan. 2024 kl. 22:32 skrifađi Daniel Stone : > > > How does userspace determine what's happened without polling? Will it > > > onl

Re: [PATCH 2/7] drm/uAPI: Add "active color format" drm property as feedback for userspace

2024-01-09 Thread Daniel Stone
Hi, On Tue, 9 Jan 2024 at 18:12, Andri Yngvason wrote: > + * active color format: > + * This read-only property tells userspace the color format actually used > + * by the hardware display engine "on the cable" on a connector. The > chosen > + * value depends on hardware capabilities

Re: [PATCH v1 0/8] drm/ci: Add support for GPU and display testing

2024-01-09 Thread Daniel Stone
Hi, On Wed, 20 Dec 2023 at 12:11, Vignesh Raman wrote: > Some ARM SOCs have a separate display controller and GPU, each with > different drivers. For mediatek mt8173, the GPU driver is powervr, > and the display driver is mediatek. In the case of mediatek mt8183, > the GPU driver is panfrost, and

Re: [PATCH v6 06/10] drm: ci: mediatek: Set IGT_FORCE_DRIVER for mt8173

2023-11-29 Thread Daniel Stone
Hi Vignesh, On Wed, 29 Nov 2023 at 12:19, Vignesh Raman wrote: > Expected driver for mt8173 is "mediatek" and for mt8183 > it is "panfrost". Set IGT_FORCE_DRIVER to 'mediatek' as > the expected driver for mt8173. Actually, for mt8183 it's both. And for mt8173 it will probably be mediatek+pvr pre

Re: [PATCH v2 2/2] drm: introduce CLOSEFB IOCTL

2023-10-24 Thread Daniel Stone
ble at [3]. IGT test available > at [4]. Series is: Reviewed-by: Daniel Stone

Re: [PATCH v5 9/9] drm: ci: Update xfails

2023-10-19 Thread Daniel Stone
Hi Vignesh, On Thu, 19 Oct 2023 at 09:07, Vignesh Raman wrote: > +# Some tests crashes with malloc error and IGT tests floods > +# the CI log with error messages and we end up with a warning message > +# Job's log exceeded limit of 4194304 bytes. > +# Job execution will continue but no more outpu

Re: [PATCH v7 04/23] dt-bindings: display: mediatek: padding: Add MT8188

2023-10-16 Thread Daniel Stone
Hi Shawn, On Mon, 16 Oct 2023 at 06:23, Shawn Sung (宋孝謙) wrote: > On Fri, 2023-10-13 at 17:26 +0100, Daniel Stone wrote: > > If I understand the driver correctly, padding is automatically > > applied > > to compensate for unaligned dimensions. The first/last rows/columns &

Re: [PATCH] drm/ci: Default to UART for logging

2023-10-13 Thread Daniel Stone
On Fri, 6 Oct 2023 at 18:32, Rob Clark wrote: > ssh logging is the default for mesa, as it is generally more reliable. > But if there are kernel issues, especially at boot, UART logging is > infinitely more useful. Hmm, we should still be capturing the UART boot logs regardless. Those go into a c

Re: [PATCH v7 04/23] dt-bindings: display: mediatek: padding: Add MT8188

2023-10-13 Thread Daniel Stone
Hi Shawn, On Fri, 6 Oct 2023 at 08:38, Hsiao Chien Sung wrote: > + Padding provides ability to add pixels to width and height of a layer with > + specified colors. Due to hardware design, Mixer in VDOSYS1 requires > + width of a layer to be 2-pixel-align, or 4-pixel-align when ETHDR is > enab

Re: drm/vkms: deadlock between dev->event_lock and timer

2023-09-18 Thread Daniel Stone
On Mon, 18 Sept 2023 at 23:02, Helen Koike wrote: > On 14/09/2023 05:12, Daniel Vetter wrote: > > Also yes how that landed without anyone running lockdep is ... not good. I > > guess we need a lockdep enabled drm ci target that runs vkms tests asap > > :-) > > btw, I just executed a draft version

Re: [PATCH 00/10] Add mediate-drm secure flow for SVP

2023-09-18 Thread Daniel Stone
Hi Jason, CK, On Tue, 19 Sept 2023 at 04:04, Jason-JH.Lin wrote: > The patch series provides drm driver support for enabling secure video > path (SVP) playback on MediaiTek hardware in the Linux kernel. > > [...] > > Memory Usage in SVP: > The overall flow of SVP starts with encrypted video comin

Re: [PATCH v11] drm: Add initial ci/ subdirectory

2023-09-15 Thread Daniel Stone
Hey, On Thu, 14 Sept 2023 at 10:54, Maxime Ripard wrote: > On Tue, Sep 12, 2023 at 02:16:41PM +0100, Daniel Stone wrote: > > Hopefully less mangled formatting this time: turns out Thunderbird + > > plain text is utterly unreadable, so that's one less MUA that is > > act

Re: [PATCH v11] drm: Add initial ci/ subdirectory

2023-09-12 Thread Daniel Stone
Hi Maxime, Hopefully less mangled formatting this time: turns out Thunderbird + plain text is utterly unreadable, so that's one less MUA that is actually usable to send email to kernel lists without getting shouted at. On Mon, 11 Sept 2023 at 15:46, Maxime Ripard wrote: > On Mon, Sep 11, 2023 at

Re: [PATCH v11] drm: Add initial ci/ subdirectory

2023-09-07 Thread Daniel Stone
Hi, On 04/09/2023 09:54, Daniel Vetter wrote: On Wed, 30 Aug 2023 at 17:14, Helen Koike > wrote: >> >> On 30/08/2023 11:57, Maxime Ripard wrote: >>> >>> I agree that we need a baseline, but that baseline should be >>> defined by the tests own merits, not their outcome on a >>> particular plat

Re: [RFC]: shmem fd for non-DMA buffer sharing cross drivers

2023-08-25 Thread Daniel Stone
Hi, On Fri, 25 Aug 2023 at 08:56, Hsia-Jun Li wrote: > On 8/25/23 15:40, Pekka Paalanen wrote: > > if userspace cannot access things like an image's HDR metadata, then it > > will be impossible for userspace to program KMS to have the correct > > color pipeline, or to send intended HDR metadata t

Re: [PATCH v2 5/8] drm/client: Convert drm_client_buffer_addfb() to drm_mode_addfb2()

2023-08-24 Thread Daniel Stone
Hi Geert, On Thu, 24 Aug 2023 at 16:09, Geert Uytterhoeven wrote: > struct drm_client_dev *client = buffer->client; > - struct drm_mode_fb_cmd fb_req = { }; > - const struct drm_format_info *info; > + struct drm_mode_fb_cmd2 fb_req = { }; > int ret; > > - i

Re: [PATCH v2 13/15] drm/panthor: Allow driver compilation

2023-08-11 Thread Daniel Stone
Hi, On 11/08/2023 17:35, Robin Murphy wrote: On 2023-08-09 17:53, Boris Brezillon wrote: +obj-$(CONFIG_DRM_PANTHOR) += panthor.o FWIW I still think it would be nice to have a minor directory/Kconfig/Makefile reshuffle and a trivial bit of extra registration glue to build both drivers into a

[PATCH] drm/rockchip: Don't spam logs in atomic check

2023-08-08 Thread Daniel Stone
Userspace should not be able to trigger DRM_ERROR messages to spam the logs; especially not through atomic commit parameters which are completely legitimate for userspace to attempt. Signed-off-by: Daniel Stone Fixes: 7707f7227f09 ("drm/rockchip: Add support for afbc") --- drive

[PATCH v2 1/2] doc: dma-buf: Rewrite intro section a little

2023-08-03 Thread Daniel Stone
Make it a little bit more clear what's going on and fix some formatting. Signed-off-by: Daniel Stone --- Documentation/driver-api/dma-buf.rst | 24 1 file changed, 16 insertions(+), 8 deletions(-) v2: New. diff --git a/Documentation/driver-api/dma-buf.r

[PATCH v2 2/2] doc: uapi: Add document describing dma-buf semantics

2023-08-03 Thread Daniel Stone
ff-by: Daniel Stone --- Documentation/driver-api/dma-buf.rst | 8 + Documentation/gpu/drm-uapi.rst| 7 + .../userspace-api/dma-buf-alloc-exchange.rst | 384 ++ Documentation/userspace-api/index.rst | 1 + 4 files changed, 400 insertions(+) c

[PATCH v2 0/2] doc: uapi: Document dma-buf interop design & semantics

2023-08-03 Thread Daniel Stone
Hi all, This is v2 to the linked patch series; thanks to everyone for reviewing the initial version. I've moved this out of a pure DRM scope and into the general userspace-API design section. Hopefully it helps others and answers a bunch of questions. I think it'd be great to have input/links/refl

Re: [PATCH] doc: gpu: Add document describing buffer exchange

2023-08-03 Thread Daniel Stone
On Thu, 3 Aug 2023 at 16:46, Daniel Stone wrote: > On Tue, 9 Nov 2021 at 09:13, Daniel Vetter wrote: > > Seconded on just landing this without trying to perfect it first, because > > I was just looking for it and didn't find it anywhere :-/ > > Swing and a miss ... >

Re: [PATCH] doc: gpu: Add document describing buffer exchange

2023-08-03 Thread Daniel Stone
ractice around negotiating, allocating, importing, and > > > > using buffers when crossing context/process/device/subsystem boundaries. > > > > > > > > This ties up all of dmabuf, formats and modifiers, and their usage. > > > > > > > > Signed-o

Re: [PATCH v10] drm: Add initial ci/ subdirectory

2023-07-27 Thread Daniel Stone
I have this working. > > Tested-by: Rob Clark > Acked-by: Rob Clark And it's also: Acked-by: Daniel Stone It's been back and forth a few times by now and reviewed pretty heavily by all the people who are across the CI details. I think the next step is to answer all the workflo

Re: [PATCH RESEND] drm/mediatek: Add valid modifier check

2023-07-25 Thread Daniel Stone
On Mon, 24 Jul 2023 at 18:58, Justin Green wrote: > + if (cmd->modifier[0] && > This is not DRM_FORMAT_MOD_INVALID. Please either explicitly compare against INVALID if that's what you meant, or against LINEAR if that's what you meant, or both. Cheers, Daniel

Re: display band (display area vs real visible area)

2023-03-21 Thread Daniel Stone
Hi, On Tue, 21 Mar 2023 at 12:08, Jani Nikula wrote: > On Tue, 21 Mar 2023, Daniel Stone wrote: > > There have been some threads - mostly motivated by MacBooks and the > > Asahi team - about creating a KMS property to express invisible areas. > > This would be the same thi

Re: display band (display area vs real visible area)

2023-03-21 Thread Daniel Stone
Hi, On Tue, 21 Mar 2023 at 11:24, Jani Nikula wrote: > On Tue, 21 Mar 2023, Michael Nazzareno Trimarchi > wrote: > > On Tue, Mar 21, 2023 at 11:43 AM Jani Nikula > > wrote: > >> On Tue, 21 Mar 2023, Michael Nazzareno Trimarchi > >> wrote: > >> > I would like to know the best approach in the

Re: [PATCH] drm: document expectations for GETFB2 handles

2023-02-16 Thread Daniel Stone
Hi, On Thu, 16 Feb 2023 at 09:25, Simon Ser wrote: > On Thursday, February 16th, 2023 at 10:11, Pekka Paalanen > wrote: > > Btw. does this also mean that if you use GETFB2 to get handle A, you > > export that as dmabuf and import in the same open device instance, you > > again get handle A? > >

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-15 Thread Daniel Stone
On Wed, 15 Feb 2023 at 20:54, Harry Wentland wrote: > On 2/15/23 06:46, Daniel Stone wrote: > > On Tue, 14 Feb 2023 at 16:57, Harry Wentland wrote: > >> On 2/14/23 10:49, Sebastian Wick wrote: > >> From what I've seen recently I am inclined to favor an incrementa

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-15 Thread Daniel Stone
Hi, On Tue, 14 Feb 2023 at 16:57, Harry Wentland wrote: > On 2/14/23 10:49, Sebastian Wick wrote: > From what I've seen recently I am inclined to favor an incremental > approach more. The reason is that any API, or portion thereof, is > useless unless it's enabled full stack. When it isn't it bec

Re: [PATCH v3 0/3] drm/rockchip: dw_hdmi: Add 4k@30 support

2023-02-06 Thread Daniel Stone
Hi Sascha, On Mon, 6 Feb 2023 at 15:49, Sascha Hauer wrote: > On Mon, Feb 06, 2023 at 03:04:48PM +0100, Sascha Hauer wrote: > > I guess a first step would be to limit the maximum resolution of vopl > > to what the hardware can do. We would likely end up with 1080p by > > default then for the appl

Re: [RFC] drm/fourcc: Add a modifier for contiguous memory

2022-11-29 Thread Daniel Stone
Hi Randy, On Tue, 29 Nov 2022 at 10:11, Hsia-Jun Li wrote: > Currently, we assume all the pixel formats are multiple planes, devices > could support each component has its own memory plane. > But that may not apply for any device in the world. We could have a > device without IOMMU then this is n

Re: [PATCH v4 0/4] new subsystem for compute accelerator devices

2022-11-24 Thread Daniel Stone
it.kernel.org/pub/scm/linux/kernel/git/ogabbay/accel.git/log/?h=accel_v4 Series is: Acked-by: Daniel Stone Cheers, Daniel

Re: [PATCH] drm/fourcc: Document open source user waiver

2022-11-24 Thread Daniel Stone
was already clarified in some vulkan discussions, but I > can't find that anywhere anymore. At least not in a public link. I seem to recall the policy being set in an IRC discussion at some point (or perhaps during the AFBC merge?). This is a good clarification of what we already do in practice. Acked-by: Daniel Stone

Re: Try to address the DMA-buf coherency problem

2022-10-28 Thread Daniel Stone
Hi Christian, On Fri, 28 Oct 2022 at 18:50, Christian König wrote: > Am 28.10.22 um 17:46 schrieb Nicolas Dufresne: > > Though, its not generically possible to reverse these roles. If you want to > > do > > so, you endup having to do like Android (gralloc) and ChromeOS (minigbm), > > because you

Re: [PATCH v8] drm: Add initial ci/ subdirectory

2022-10-25 Thread Daniel Stone
Hi all, On Tue, 25 Oct 2022 at 08:32, Daniel Vetter wrote: > On Fri, 9 Sept 2022 at 19:18, Daniel Stone wrote: > > But equally - and sorry for not jumping on the IRC (?) discussion as I was > > in the middle of other stuff when it came up - I'm don't think th

Re: [PATCH v4] drm/mediatek: Add AFBC support to Mediatek DRM driver

2022-10-14 Thread Daniel Stone
@collabora.com> > And also: Acked-by: Daniel Stone I was worried about INVALID being passed through, but for the most part it seems like it magically turns into LINEAR through either zero extension or explicit initialisation to zero. Cheers, Daniel

Re: [PATCH v3] drm/mediatek: Add AFBC support to Mediatek DRM driver

2022-10-13 Thread Daniel Stone
Hi Justin, On Wed, 12 Oct 2022 at 20:12, Justin Green wrote: > @@ -226,6 +249,32 @@ int mtk_ovl_layer_check(struct device *dev, unsigned > int idx, > if (state->fb->format->is_yuv && rotation != 0) > return -EINVAL; > > + if (state->fb->modifier) { > Please spell t

Re: [PATCH 4/5] drm/damage-helper: Do partial updates if framebuffer has not been changed

2022-09-20 Thread Daniel Stone
Hi, On Tue, 20 Sept 2022 at 15:31, Ville Syrjälä wrote: > On Tue, Sep 20, 2022 at 03:56:18PM +0200, Thomas Zimmermann wrote: > > Set partial updates on a plane if the framebuffer has not been changed > > on an atomic commit. If such a plane has damage clips, the driver will > > use them; otherwi

Re: [PATCH v8] drm: Add initial ci/ subdirectory

2022-09-09 Thread Daniel Stone
Hi, On Fri, 9 Sept 2022 at 15:15, Tomeu Vizoso wrote: > Also include a configuration file that points to the out-of-tree CI > scripts. > I think this para is outdated given ... v8: > - Move all files specific to testing the kernel into the kernel tree > (thus I have dropped the r-bs I h

Re: Meeting (BOF) at Plumbers Dublin to discuss backlight brightness as connector object property RFC?

2022-09-09 Thread Daniel Stone
On Fri, 9 Sept 2022 at 12:50, Simon Ser wrote: > On Friday, September 9th, 2022 at 12:23, Hans de Goede < > hdego...@redhat.com> wrote: > > "people using > > non fully integrated desktop environments like e.g. sway often use custom > > scripts binded to hotkeys to get functionality like the brigh

Re: [PATCH] drm/virtio: set fb_modifiers_not_supported

2022-08-31 Thread Daniel Stone
. > > Fixes: 2af104290da5 ("drm: introduce fb_modifiers_not_supported flag in > mode_config") > Suggested-by: Shao-Chuan Lee > Signed-off-by: Chia-I Wu Reviewed-by: Daniel Stone

Re: DMA-buf and uncached system memory

2022-06-23 Thread Daniel Stone
Hi Christian, On Thu, 23 Jun 2022 at 12:11, Christian König wrote: > > In fact DMA-buf sharing works fine on most of those SoCs because > > everyone just assumes that all the accelerators don't snoop, so the > > memory shared via DMA-buf is mostly CPU uncached. It only falls apart > > for uses li

Re: DMA-buf and uncached system memory

2022-06-22 Thread Daniel Stone
Hi Nicolas, On Wed, 22 Jun 2022 at 20:39, Nicolas Dufresne wrote: > Le mardi 16 février 2021 à 10:25 +0100, Daniel Vetter a écrit : > > So I think if AMD also guarantees to drop clean cachelines just do the > > same thing we do right now for intel integrated + discrete amd, but in > > reserve. It

Re: [PATCH 0/6] drm: Add mouse cursor hotspot support to atomic KMS

2022-06-14 Thread Daniel Stone
Hi, On Tue, 14 Jun 2022 at 15:40, Zack Rusin wrote: > On Tue, 2022-06-14 at 10:36 +0300, Pekka Paalanen wrote: > > The reason I am saying that you need to fix other issues with > > virtualized drivers at the same time is because those other issues are > > the sole and only reason why the driver w

Re: 504 to gitlab.freedesktop.org

2022-06-13 Thread Daniel Stone
Hi, On Mon, 13 Jun 2022 at 08:39, Daniel Stone wrote: > Yes, that's what's happening. Our (multi-host-replicated etc) Ceph > storage setup has entered a degraded mode due to the loss of a couple > of disks - no data has been lost but the cluster is currently unhappy. >

Re: 504 to gitlab.freedesktop.org

2022-06-13 Thread Daniel Stone
On Mon, 13 Jun 2022 at 05:17, Peter Hutterer wrote: > On Sun, Jun 12, 2022 at 05:57:05PM -0700, Jeremy Sequoia wrote: > > I was going to spend a little bit of time putting out an update to XQuartz > > to address a few bugs that I've been meaning to squash, but I'm having a bit > > of an issue pull

Re: Tackling the indefinite/user DMA fence problem

2022-05-25 Thread Daniel Stone
Hi, On Wed, 25 May 2022 at 15:07, Simon Ser wrote: > On Wednesday, May 25th, 2022 at 15:51, Daniel Vetter wrote: > > > You can add that to the list of reasons why compositors need to stop > > > using buffers with unsignaled fences. There's plenty of other reasons > > > there already (the big one

Re: [PATCH 0/2] dma-buf: Add an API for exporting sync files (v14)

2022-05-25 Thread Daniel Stone
re's > no real disagreement on that one. The import ioctl, however, has a lot of > debate around it so it's intended to be RFC-only for now. Errr, I think we're good with this one now right? >From the uAPI point of view, having looked through the Mesa MR, both are: Acked-by: Daniel Stone Cheers, Daniel

Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-05-03 Thread Daniel Stone
On Sun, 1 May 2022 at 08:08, Paul Menzel wrote: > Am 26.04.22 um 15:53 schrieb Gong, Richard: > > I think so. We captured dmesg log. > > Then the (whole) system did *not* freeze, if you could still log in > (maybe over network) and execute `dmesg`. Please also paste the > amdgpu(?) error logs in t

Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support

2022-04-25 Thread Daniel Stone
Hi Piotr, On Fri, 15 Apr 2022 at 12:11, Piotr Oniszczuk wrote: > Looking on Qt sources it looks to me this format should be supported: > > https://code.qt.io/cgit/qt/qtbase.git/tree/src/platformsupport/kmsconvenience/qkmsdevice.cpp?h=5.15.2#n380 > > Interesting that with custom Qt config1: "forma

Re: [PATCH v11 00/24] drm/rockchip: RK356x VOP2 support

2022-04-25 Thread Daniel Stone
t; window. I don't believe there's anything left, no; the core driver itself remains: Acked-by: Daniel Stone At this point there's no reason to not push it into the tree, and any remaining bugs can be shaken out and fixed there. Cheers, Daniel

Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support

2022-04-12 Thread Daniel Stone
On Tue, 12 Apr 2022 at 11:14, Piotr Oniszczuk wrote: > > Wiadomość napisana przez Lucas Stach w dniu > > 12.04.2022, o godz. 10:10: > > 1. The application feeds a wrong modifier list to the GBM > > implementation, as it may have queried another plane in the assumption > > that supported modifier

Re: DRM Master ignoring hotplug event during display switching (QT)

2022-03-30 Thread Daniel Stone
Hi, On Wed, 30 Mar 2022 at 20:47, Daniel Vetter wrote: > On Thu, Mar 31, 2022 at 12:14:31AM +0530, Jagan Teki wrote: > > Does it mean the userspace knows when to disconnect and connect the > > LVDS or HDMI? What if display-switch ISR will disconnect LVDS and > > connect HDMI when HPD is On and co

Re: Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

2022-03-23 Thread Daniel Stone
On Wed, 23 Mar 2022 at 15:14, Alex Deucher wrote: > On Wed, Mar 23, 2022 at 11:04 AM Daniel Stone wrote: > > That's not what anyone's saying here ... > > > > No-one's demanding AMD publish RTL, or internal design docs, or > > hardware specs,

Re: Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

2022-03-23 Thread Daniel Stone
Hi Alex, On Wed, 23 Mar 2022 at 14:42, Alex Deucher wrote: > On Wed, Mar 23, 2022 at 10:00 AM Daniel Stone wrote: > > On Wed, 23 Mar 2022 at 08:19, Christian König > > wrote: > > > Well the key point is it's not about you to judge that. > > > > >

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-23 Thread Daniel Stone
Hi, On Mon, 21 Mar 2022 at 16:02, Rob Clark wrote: > On Mon, Mar 21, 2022 at 2:30 AM Christian König > wrote: > > Well you can, it just means that their contexts are lost as well. > > Which is rather inconvenient when deqp-egl reset tests, for example, > take down your compositor ;-) Yeah. Or a

Re: Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

2022-03-23 Thread Daniel Stone
On Wed, 23 Mar 2022 at 08:19, Christian König wrote: > Am 23.03.22 um 09:10 schrieb Paul Menzel: > > Sorry, I disagree. The motivation needs to be part of the commit > > message. For example see recent discussion on the LWN article > > *Donenfeld: Random number generator enhancements for Linux 5.1

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-17 Thread Daniel Stone
Hi, On Thu, 17 Mar 2022 at 09:21, Christian König wrote: > Am 17.03.22 um 09:42 schrieb Sharma, Shashank: > >> AFAIU you probably want to be passing around a `struct pid *`, and > >> then somehow use pid_vnr() in the context of the process reading the > >> event to get the numeric pid. Otherwise

Re: [PATCH v8 22/24] drm: rockchip: Add VOP2 driver

2022-03-15 Thread Daniel Stone
Hi Andy, On Tue, 15 Mar 2022 at 06:46, Andy Yan wrote: > On 3/11/22 16:33, Sascha Hauer wrote: > > The driver is tested with HDMI and MIPI-DSI display on a RK3568-EVB > > board. Overlay support is tested with the modetest utility. AFBC support > > on the cluster windows is tested with weston-simp

Re: [PATCH v7 22/24] drm: rockchip: Add VOP2 driver

2022-03-14 Thread Daniel Stone
Hi Andy, On Mon, 14 Mar 2022 at 11:02, Andy Yan wrote: >Remember you said our downstream vop2 driver is very slow on weston. > > Would you please share the case you run ? or how can i test frame rate > on weston? We were able to observe this by just using either waylandsink (using dmabuf fro

Re: [PATCH v7 22/24] drm: rockchip: Add VOP2 driver

2022-03-08 Thread Daniel Stone
On Tue, 8 Mar 2022 at 08:42, Andy Yan wrote: > On 3/7/22 21:09, Daniel Stone wrote: > > On Mon, 7 Mar 2022 at 12:18, Andy Yan wrote: > >> When run a weston 10.0.0: > >> > >># export XDG_RUNTIME_DIR=/tmp > >># weston --backend=drm-backend.s

Re: [PATCH v7 22/24] drm: rockchip: Add VOP2 driver

2022-03-07 Thread Daniel Stone
Hi Andy, On Mon, 7 Mar 2022 at 12:18, Andy Yan wrote: > On 2/25/22 15:51, Sascha Hauer wrote: > > The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. > > It replaces the VOP unit found in the older Rockchip SoCs. > > > > This driver has been derived from the downstream Rockchip

Re: [igt-dev] Mandatory Test Suite for KMS Drivers?

2022-03-04 Thread Daniel Stone
Hi, On Thu, 3 Mar 2022 at 10:53, Rodrigo Vivi wrote: > On Thu, Mar 03, 2022 at 10:05:07AM +0100, Maxime Ripard wrote: > > Back at XDC we floated the idea of creating a test suite for IGT that we > > expect any KMS driver to pass, similar to what v4l2-compliance and > > cec-compliance provide for

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-16 Thread Daniel Stone
On Wed, 16 Feb 2022 at 14:13, Sui Jingfeng <15330273...@189.cn> wrote: > On 2022/2/16 21:46, Daniel Stone wrote: > > Other systems have this limitation, and Mesa's 'kmsro' concept makes > > this work transparently, as long as your driver can export dmabufs >

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-16 Thread Daniel Stone
On Wed, 9 Feb 2022 at 15:41, Sui Jingfeng <15330273...@189.cn> wrote: > On 2022/2/9 16:43, Maxime Ripard wrote: > > More fundamentally (and this extends to the CMA, caching and VRAM stuff > > you explained above), why can't the driver pick the right decision all > > the time and why would that be u

  1   2   3   4   5   6   7   8   >