Re: [PATCH 00/20] drm: Split out the formats API and move it to a common place

2019-04-23 Thread Daniel Stone
Hi Laurent, On Tue, 23 Apr 2019 at 16:54, Laurent Pinchart wrote: > On Tue, Apr 23, 2019 at 09:59:37AM +0100, Daniel Stone wrote: > > On Tue, 23 Apr 2019 at 08:26, Daniel Vetter wrote: > > Totally. Let's take DRM_FORMAT_XRGB + I915_FORMAT_MOD_Y_TILED as > > an

Re: [PATCH 00/20] drm: Split out the formats API and move it to a common place

2019-04-23 Thread Daniel Stone
Hi, On Tue, 23 Apr 2019 at 08:26, Daniel Vetter wrote: > On Sun, Apr 21, 2019 at 01:59:04AM +0300, Laurent Pinchart wrote: > > > > > - drm fourcc code doesn't actually define the drm_format_info > > > > > uniquely, drivers can override that (that's an explicit design > > > > > intent of

Re: [PATCH] drm/cirrus: rewrite and modernize driver.

2019-04-03 Thread Daniel Stone
On Wed, 3 Apr 2019 at 16:12, Adam Jackson wrote: > On Wed, 2019-04-03 at 09:23 +0200, Gerd Hoffmann wrote: > > - Only DRM_FORMAT_RGB565 (depth 16) is supported. The old driver does > >that too by default. There was a module parameter which enables 24/32 > >bpp support and disables

Re: [PATCH v2 1/2] drm/file: Rehabilitate the firstopen hook for non-legacy drivers

2019-03-29 Thread Daniel Stone
Hi, On Fri, 29 Mar 2019 at 18:14, Eric Anholt wrote: > Paul Kocialkowski writes: > > I'm not totally convinced that it's okay to have a delay outside of > > init/enumeration, even if it's a smaller delay. > > You'll have non-dumb buffers created during GL context creation, so > early in xserver

Re: [PATCH v2 1/2] drm/file: Rehabilitate the firstopen hook for non-legacy drivers

2019-03-29 Thread Daniel Stone
Hi, On Thu, 28 Mar 2019 at 18:53, Daniel Vetter wrote: > On Thu, Mar 21, 2019 at 04:27:06PM +0100, Paul Kocialkowski wrote: > > I don't see other options either, and using firstclose/lastopen feels > > overall more readable in the driver code. > > > > I'm not sure there is such a big overhead

Re: [PATCH v2] drm: add non-desktop quirks to Sensics and OSVR headsets.

2019-03-15 Thread Daniel Stone
Hi, On Mon, 3 Dec 2018 at 17:04, Philipp Zabel wrote: > On Mon, 2018-12-03 at 10:46 -0600, Ryan Pavlik wrote: > > Add two EDID vendor/product pairs used across a variety of > > Sensics products, as well as the OSVR HDK and HDK 2. > > > > Signed-off-by: Ryan Pavlik > > Reviewed-by: Philipp Zabel

Fwd: PSA: Mailman changes, From addresses no longer accurate

2019-02-12 Thread Daniel Stone
that you are replying to the original sender (in Reply-To) and not the list itself. Cheers, Daniel -- Forwarded message - From: Daniel Stone Date: Mon, 11 Feb 2019 at 23:38 Subject: PSA: Mailman changes, From addresses no longer accurate To: , Hi all, We have hit another step change

Re: [PATCH libdrm] xf86drm: fix return type for drmIsMaster()

2019-02-08 Thread Daniel Stone
Hi Eric, On Fri, 8 Feb 2019 at 15:03, Eric Engestrom wrote: > Xserver has struct members named `bool`, which means the last commit > breaks its build with errors like this: > > error: two or more data types in declaration specifiers > Bool bool; >^ > > Fix this by making it return a

Re: [Intel-gfx] [v7 1/2] drm: Add colorspace connector property

2019-01-29 Thread Daniel Stone
e-time. So, in include/uapi there shouldn't be these numeric > values. > > The strings themselves effectively form the UABI, so I was wondering > if they should be defined in include/uapi, but you would be the first > to do that. > > Daniel Vetter and/or Daniel Stone mi

Re: [igt-dev] [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-23 Thread Daniel Stone
Hi, On Tue, 22 Jan 2019 at 19:42, Wentland, Harry wrote: > On 2019-01-22 2:19 p.m., Daniel Vetter wrote: > > I'd say we'll shrug these cases off as "can't be reasonable tested, > > won't have an igt". First driver team with hw that can be validated > > gets to fill the gaps :-) In practice still

Re: [PATCH] lib/scatterlist: Provide a DMA page iterator

2019-01-16 Thread Daniel Stone
On Wed, 16 Jan 2019 at 16:06, h...@lst.de wrote: > On Wed, Jan 16, 2019 at 07:28:13AM +, Koenig, Christian wrote: > > To summarize once more: We have an array of struct pages and want to > > coherently map that to a device. > > And the answer to that is very simple: you can't. What is so

Re: [PATCH] [RFC] MAINTAINERS: Daniel for drm co-maintainer

2018-12-11 Thread Daniel Stone
excellent leader of our community so far, and I don't > expect that to change just because you officially wear a new hat. > > Acked-by: Eric Anholt Eric speaks for me. Acked-by: Daniel Stone Cheers, Daniel ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH libdrm] tests: skip drmdevice test if the machine doesn't have any drm device

2018-11-10 Thread Daniel Stone
On Fri, 9 Nov 2018 at 19:13, Eric Engestrom wrote: > Error message was invalid too, negative values aren't the number of > devices, they're errno error codes. > > Signed-off-by: Eric Engestrom Reviewed-by: Daniel Stone ___ dri-devel mail

Re: [RFC] Allow fd.o to join forces with X.Org

2018-10-26 Thread Daniel Stone
Hi, On Fri, 26 Oct 2018 at 11:57, Daniel Vetter wrote: > On Fri, Oct 26, 2018 at 10:13:51AM +1000, Peter Hutterer wrote: > > On Wed, Oct 17, 2018 at 02:37:25PM +0200, Daniel Vetter wrote: > > > On Wed, Oct 17, 2018 at 2:05 PM Daniel Stone wrote: > > > > Yeah, I thi

Re: [RFC] Allow fd.o to join forces with X.Org

2018-10-17 Thread Daniel Stone
On Tue, 16 Oct 2018 at 08:17, Peter Hutterer wrote: > On Mon, Oct 15, 2018 at 10:49:24AM -0400, Harry Wentland wrote: > > + \item Support free and open source projects through the > > freedesktop.org > > + infrastructure. For projects outside the scope of item (\ref{1}) > > support > >

Re: Add new DIRTY fb flags to pass interlaced alternate fields

2018-09-17 Thread Daniel Stone
Hi Satish, On Fri, 7 Sep 2018 at 23:04, Satish Nagireddy wrote: > The requirement is to render interlaced alternate buffers. In case of > alternate, top field and bottom field are in two different buffers. > > The question is, can we pass existing flags DRM_MODE_PRESENT_TOP_FIELD > and

Re: [PATCH libdrm] CONTRIBUTING: clarify how to request a Developer role

2018-09-17 Thread Daniel Stone
Hi, On Sat, 15 Sep 2018 at 00:56, Lucas De Marchi wrote: > -To apply for commit rights ("Developer" role in gitlab) send a mail to > -dri-devel@lists.freedesktop.org and please ping the maintainers if your > request > -is stuck. > +To apply for commit rights ("Developer" role in gitlab), check

Re: drm | Pipeline #4114 has failed for master | c55f1b9b

2018-09-06 Thread Daniel Stone
Hi, On Thu, 6 Sep 2018 at 10:11, Lucas De Marchi wrote: > On Wed, Sep 5, 2018 at 7:00 PM Rodrigo Vivi wrote: > > well it builds for me. > > > > but any idea what might be wrong here on gitlab ci? You can simulate what happens in CI by running the same script inside the same container.

[PATCH libdrm] CI: Capture test logs as GitLab artifacts

2018-09-06 Thread Daniel Stone
GitLab CI already captures all the stdout/stderr output from the build process as the log. However, some other important information is hidden in other log files. Taken from Wayland, capture logs from the configuration process as well as from every check. Signed-off-by: Daniel Stone Cc: Rodrigo

Re: [RFC] drm/amdgpu: Add macros and documentation for format modifiers.

2018-09-04 Thread Daniel Stone
Hi, On Tue, 4 Sep 2018 at 11:44, Christian König wrote: > Am 04.09.2018 um 12:15 schrieb Daniel Stone: > > Right. The conclusion, after people went through and started sorting > > out the kinds of formats for which they would _actually_ export real > > colour buffers f

Re: [RFC] drm/amdgpu: Add macros and documentation for format modifiers.

2018-09-04 Thread Daniel Stone
Hi, On Tue, 4 Sep 2018 at 11:05, Daniel Vetter wrote: > On Tue, Sep 4, 2018 at 3:00 AM, Bas Nieuwenhuizen > wrote: > > +/* The chip this is compatible with. > > + * > > + * If compression is disabled, use > > + * - AMDGPU_CHIP_TAHITI for GFX6-GFX8 > > + * - AMDGPU_CHIP_VEGA10 for GFX9+ > >

Re: [PATCH libdrm] add gitlab-ci builds of libdrm

2018-09-03 Thread Daniel Stone
> > --- > > See it in action on my fork: > > https://gitlab.freedesktop.org/eric/libdrm/pipelines/3885 > > With the --no-check-certificate things explained: > > Reviewed-by: Daniel Vetter Indeed, and also: Reviewed-by: Daniel Stone Thanks for doing this! Cheers, Daniel

Re: [PATCH libdrm] add gitlab-ci builds of libdrm

2018-08-31 Thread Daniel Stone
Hi Eric, On Fri, 31 Aug 2018 at 15:22, Eric Engestrom wrote: > +- LIBPCIACCESS_VERSION=libpciaccess-0.10 && > + wget --no-check-certificate > https://xorg.freedesktop.org/releases/individual/lib/$LIBPCIACCESS_VERSION.tar.bz2 > && Why are you using --no-check-certificate?! Cheers,

Re: [PATCH] drm/kms/crtc: Improving the func drm_mode_setcrtc

2018-08-24 Thread Daniel Stone
Hi Satendra, On Fri, 27 Jul 2018 at 11:13, Satendra Singh Thakur wrote: > Following changes are done to this func: I would certainly agree with Sean, Martin, and Jani's comments. This patch was difficult to follow as it made so many changes at once. Being a crucial function which has many

Re: [igt-dev] RFC: Migration to Gitlab

2018-08-22 Thread Daniel Stone
Hi Rodrigo, On Wed, 22 Aug 2018 at 17:06, Rodrigo Vivi wrote: > On Wed, Aug 22, 2018 at 10:19:19AM -0400, Adam Jackson wrote: > > On Wed, 2018-08-22 at 16:13 +0300, Jani Nikula wrote: > > > - Sticking to fdo bugzilla and disabling gitlab issues for at least > > > drm-intel for the time being.

Re: [igt-dev] RFC: Migration to Gitlab

2018-08-22 Thread Daniel Stone
Hi, On Wed, 22 Aug 2018 at 15:44, Daniel Vetter wrote: > On Wed, Aug 22, 2018 at 3:13 PM, Jani Nikula > wrote: > > Just a couple of concerns from drm/i915 perspective for starters: > > > > - Patchwork integration. I think we'll want to keep patchwork for at > > least intel-gfx etc. for the

Re: RFC: Migration to Gitlab

2018-08-22 Thread Daniel Stone
Hi, On Wed, 22 Aug 2018 at 16:02, Emil Velikov wrote: > On 22 August 2018 at 12:44, Daniel Vetter wrote: > > I think it's time to brainstorm a bit about the gitlab migration. Basic > > reasons: > > > > - fd.o admins want to deprecate shell accounts and hand-rolled > > infrastructure, because

Re: [Mesa-dev] [PATCH libdrm] Add basic CONTRIBUTING file

2018-08-22 Thread Daniel Stone
On Wed, 22 Aug 2018 at 11:51, Daniel Vetter wrote: > +See the gitlab project owners for contact details of the libdrm maintainers. Think this should be 'See MAINTAINERS' ... ? The rest looks good to me, though I would encourage linking to Patchwork so people can find patches from others, as

Re: [PATCH libdrm v3] tests/modetest: Add atomic support

2018-08-07 Thread Daniel Stone
Hi Emil, This is off-topic for the list, but ... On Tue, 7 Aug 2018 at 14:46, Emil Velikov wrote: > Aside: libdrm following X/Wayland in that it lacks contributor/push access > docs. > Might be worth, copying the Mesa ones and adding a doc in-tree.

Re: [PATCH] MAINTAINERS: update drm tree

2018-07-09 Thread Daniel Stone
Hi, On Mon, 9 Jul 2018 at 08:38, Daniel Vetter wrote: > On Fri, Jul 06, 2018 at 04:43:09PM +0100, Mike Lothian wrote: > > Any change of this moving to https or the gitlab instance where its on as > > default? > > Moving all the drm repos over to gitlab is somewhere on the plans, but we > need to

Re: Shared atomic state causing Weston repaint failure

2018-07-06 Thread Daniel Stone
Hey Jakob, On Thu, 5 Jul 2018 at 14:32, Jakob Bornecrantz wrote: > So from a VR compositor getting blocked like this is a no-go as the > user would quickly throw EPUKE. The situation is compounded by the > fact that the VR compositor has no idea what the display compositor is > doing with

Shared atomic state causing Weston repaint failure

2018-07-04 Thread Daniel Stone
Hi, The atomic API being super-explicit about how userspace sequences its calls is great and all, but having shared global state implicitly dragged in is kind of ruining my day. Currently on Intel, Weston sometimes fails on hotplug, because a commit which only enables CRTC B (not touching CRTC A

Re: [PATCH 19/24] drm/armada: Move GEM BO to drm_framebuffer

2018-06-27 Thread Daniel Stone
Hi Russell, On Tue, 26 Jun 2018 at 15:49, Russell King - ARM Linux wrote: > On Thu, May 17, 2018 at 04:41:35PM +0100, Daniel Stone wrote: > > Thanks Russell. I did do a build test locally as well which had no > > complaints. I'll merge this through drm-misc. > > I've not s

Re: [git pull] drm for v4.18-rc1

2018-06-06 Thread Daniel Stone
Hi, On 6 June 2018 at 04:50, Dave Airlie wrote: > First up I've moved the drm tree to a new location on freedesktop.org. The > main > reason was to explore using Daniel's maintainer tools (dim-tools) to manage > pull requests and possibly open the drm to having co-maintainers at the top > level

Re: Linux 4.17-rc7

2018-06-03 Thread Daniel Stone
Hi Pavel, On 2 June 2018 at 18:55, Pavel Machek wrote: >> On 30 May 2018 at 12:17, Pavel Machek wrote: >> > Any chance to still get in this one? >> > >> > https://github.com/freedesktop/drm-misc/commit/2bc5ff0bdc00d81d719dad74589317a260d583ed >> > >> > ...it fixes display on Nokia N900, and

Re: [PATCH] drm/edid: Quirk Vive Pro VR headset non-desktop.

2018-06-02 Thread Daniel Stone
On 30 May 2018 at 15:03, Jani Nikula wrote: > On Wed, 30 May 2018, Daniel Stone wrote: >> On 29 May 2018 at 12:52, Lubosz Sarnecki >> wrote: >>> This adds the Vive Pro's EDID information and >>> sets EDID_QUIRK_NON_DESKTOP. >> >> Trivial

Re: [PATCH] drm/edid: Quirk Vive Pro VR headset non-desktop.

2018-05-30 Thread Daniel Stone
On 29 May 2018 at 12:52, Lubosz Sarnecki wrote: > This adds the Vive Pro's EDID information and > sets EDID_QUIRK_NON_DESKTOP. Trivially: Reviewed-by: Daniel Stone ___ dri-devel mailing list dri-devel@lists.freedesktop.org

Re: Linux 4.17-rc7

2018-05-30 Thread Daniel Stone
Hi Pavel, On 30 May 2018 at 12:17, Pavel Machek wrote: >> The bulk of it is really pretty trivial one-liners, and nothing looks >> particularly scary. Let's see how next week looks, but if nothing really >> happens I suspect we can make do without an rc8. >> >> Shortlog appended as usual. Go out

Re: [PATCH] drm/gma500: Fix Medfield for drm_framebuffer move

2018-05-22 Thread Daniel Stone
On 22 May 2018 at 10:19, Thierry Reding <thierry.red...@gmail.com> wrote: > On Mon, May 21, 2018 at 03:24:49PM +0100, Daniel Stone wrote: >> bc61c97502e2 moved the gtt_range structure, from being in >> psb_framebuffer and embedding the GEM object, to being placed in t

[PATCH] drm/gma500: Fix Medfield for drm_framebuffer move

2018-05-21 Thread Daniel Stone
config. Do the trivial fixup here. Signed-off-by: Daniel Stone <dani...@collabora.com> Reported-by: kbuild test robot <l...@intel.com> Fixes: bc61c97502e2 ("drm/gma500: Move GEM BO to drm_framebuffer") Cc: Thierry Reding <tred...@nvidia.com> Cc: Patrik Jakobsson &

[PATCH v2 3/3] drm/mtk: mtk_drm_fb -> drm_framebuffer

2018-05-18 Thread Daniel Stone
Now that mtk_drm_fb is an empty wrapper around drm_framebuffer, we can just delete it. Signed-off-by: Daniel Stone <dani...@collabora.com> Reviewed-by: CK Hu <ck...@mediatek.com> Reviewed-by: Thierry Reding <tred...@nvidia.com> Reviewed-by: Sean Paul <seanp...@chromium.o

[PATCH v2 1/3] drm/mtk: Remove impossible internal error

2018-05-18 Thread Daniel Stone
We cannot create a framebuffer with no objects, so there's no point testing for it. v2: Remove the error entirely. (Sean, CK, Thierry) Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: Sean Paul <seanp...@chromium.org> Cc: Thierry Reding <tred...@nvidia.com> Cc: CK Hu &

[PATCH v2 2/3] drm/mtk: Move GEM BO to drm_framebuffer

2018-05-18 Thread Daniel Stone
Since drm_framebuffer can now store GEM objects directly, place them there rather than in our own subclass. As this makes the framebuffer create_handle and destroy functions the same as the GEM framebuffer helper, we can reuse those. Signed-off-by: Daniel Stone <dani...@collabora.com> Re

Re: [PATCH 19/24] drm/armada: Move GEM BO to drm_framebuffer

2018-05-17 Thread Daniel Stone
On 17 May 2018 at 16:26, Russell King - ARM Linux <li...@armlinux.org.uk> wrote: > On Thu, May 17, 2018 at 02:15:40PM +0100, Daniel Stone wrote: >> On 30 March 2018 at 15:11, Daniel Stone <dani...@collabora.com> wrote: >> > Since drm_framebuffer can now store GE

Re: [PATCH 05/24] drm/rockchip: rockchip_drm_fb -> drm_framebuffer

2018-05-17 Thread Daniel Stone
Hi Heiko, On 17 May 2018 at 14:42, Heiko Stübner <he...@sntech.de> wrote: > Am Donnerstag, 17. Mai 2018, 15:08:15 CEST schrieb Daniel Stone: >> On 30 March 2018 at 15:11, Daniel Stone <dani...@collabora.com> wrote: >> > Now that rockchip_drm_fb is just a wrap

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Move GEM BO inside drm_framebuffer

2018-05-17 Thread Daniel Stone
Hi Ville, On 23 March 2018 at 14:49, Daniel Stone <dan...@fooishbar.org> wrote: > On 23 March 2018 at 14:42, Ville Syrjälä <ville.syrj...@linux.intel.com> > wrote: >> Hmm. I'm thinking we can stick to the single reference per fb. >> IIRC this counter is there just

Re: [PATCH 19/24] drm/armada: Move GEM BO to drm_framebuffer

2018-05-17 Thread Daniel Stone
Hi Russell, On 30 March 2018 at 15:11, Daniel Stone <dani...@collabora.com> wrote: > Since drm_framebuffer can now store GEM objects directly, place them > there rather than in our own subclass. As this makes the framebuffer > create_handle and destroy functions the same as the

Re: [PATCH 10/24] drm/mtk: mtk_drm_fb -> drm_framebuffer

2018-05-17 Thread Daniel Stone
Hi CK, Philipp, On 30 March 2018 at 15:11, Daniel Stone <dani...@collabora.com> wrote: > Now that mtk_drm_fb is an empty wrapper around drm_framebuffer, we can > just delete it. Did you get a chance to look at these three patches for Mediatek? Ch

Re: [PATCH 07/24] drm/omap: Move buffer pitch/offset to drm_framebuffer

2018-05-17 Thread Daniel Stone
On 30 March 2018 at 21:53, Sebastian Reichel <sebastian.reic...@collabora.co.uk> wrote: > On Fri, Mar 30, 2018 at 03:11:21PM +0100, Daniel Stone wrote: >> drm_framebuffer already holds per-plane pitch and offsets, which is >> filled out for us when we create the framebuffer

Re: [PATCH 21/24] drm/msm: Move GEM BOs to drm_framebuffer

2018-05-17 Thread Daniel Stone
Hi Rob, On 30 March 2018 at 15:11, Daniel Stone <dani...@collabora.com> wrote: > Since drm_framebuffer can now store GEM objects directly, place them > there rather than in our own subclass. As this makes the framebuffer > create_handle function the same as the GEM framebuffer h

Re: [PATCH 13/24] drm/tegra: tegra_fb -> drm_framebuffer

2018-05-17 Thread Daniel Stone
Hi Thierry, On 30 March 2018 at 15:11, Daniel Stone <dani...@collabora.com> wrote: > Since tegra_fb is now the same as drm_framebuffer, we can just replace > the type completely. > > Signed-off-by: Daniel Stone <dani...@collabora.com> > Cc: Thierry Reding <thierry.re

Re: [PATCH 05/24] drm/rockchip: rockchip_drm_fb -> drm_framebuffer

2018-05-17 Thread Daniel Stone
On 30 March 2018 at 15:11, Daniel Stone <dani...@collabora.com> wrote: > Now that rockchip_drm_fb is just a wrapper around drm_framebuffer, we > can remove it. > > Signed-off-by: Daniel Stone <dani...@collabora.com> > Cc: Sandy Huang <h...@rock-chips.com> >

Re: [drm_hwc] PSA: drm_hwc submissions via gitlab

2018-05-04 Thread Daniel Stone
Hi, On 3 May 2018 at 20:12, Sean Paul wrote: > On Thu, May 03, 2018 at 08:30:18PM +0200, Daniel Vetter wrote: >> On Thu, May 3, 2018 at 5:04 PM, Sean Paul wrote: >> > If you're still reading, I'll point out a couple other things: >> > - There is a

Re: [drm_hwc] PSA: drm_hwc submissions via gitlab

2018-05-04 Thread Daniel Stone
Hey all, On 4 May 2018 at 09:43, Robert Foss wrote: > On 2018-05-03 17:04, Sean Paul wrote: >> Apologies for the direct ping. I've harvested your emails from drm_hwc git >> logs, >> and didn't want to leave anyone out. The good news is that your email >> address >>

Re: RFC for a render API to support adaptive sync and VRR

2018-04-21 Thread Daniel Stone
Hi, On 20 April 2018 at 21:32, Manasi Navare wrote: > On Wed, Apr 18, 2018 at 09:39:02AM +0200, Daniel Vetter wrote: >> On Wed, Apr 18, 2018 at 5:58 AM, Keith Packard wrote: >> > I'd also encourage using a single unit for all of these values, >> >

Re: [PATCHv3 3/8] drm/omap: add support for manually updated displays

2018-04-20 Thread Daniel Stone
Hi Tony! On 20 April 2018 at 15:25, Tony Lindgren <t...@atomide.com> wrote: > * Daniel Stone <dan...@fooishbar.org> [180420 10:21]: >> On 20 April 2018 at 08:09, Tomi Valkeinen <tomi.valkei...@ti.com> wrote: >> > It's actually not quite clear to me how manua

Re: [PATCHv3 3/8] drm/omap: add support for manually updated displays

2018-04-20 Thread Daniel Stone
Hi Tomi, On 20 April 2018 at 08:09, Tomi Valkeinen wrote: > It's actually not quite clear to me how manual update displays work with > DRM... > > As far as I see, we have essentially two cases: 1) single buffering, > where the userspace must set an area in the fb dirty,

Re: [PATCH 16/24] drm/exynos: Move GEM BOs to drm_framebuffer

2018-04-13 Thread Daniel Stone
Hi Inki, On 13 April 2018 at 10:55, Inki Dae <inki@samsung.com> wrote: > 2018년 03월 30일 23:11에 Daniel Stone 이(가) 쓴 글: >> Since drm_framebuffer can now store GEM objects directly, place them >> there rather than in our own subclass. As this makes the framebuffer >>

Re: [RfC PATCH] Add udmabuf misc device

2018-04-06 Thread Daniel Stone
Hi Gerd, On 14 March 2018 at 08:03, Gerd Hoffmann wrote: >> Either mlock account (because it's mlocked defacto), and get_user_pages >> won't do that for you. >> >> Or you write the full-blown userptr implementation, including mmu_notifier >> support (see i915 or amdgpu), but

Re: [PATCH libdrm 1/2] headers: Sync with drm-next

2018-03-30 Thread Daniel Stone
On 30 March 2018 at 14:30, Alex Deucher <alexdeuc...@gmail.com> wrote: > On Fri, Mar 30, 2018 at 8:28 AM, Daniel Stone <dani...@collabora.com> wrote: >> Taken from the drm-next pull for 4.17-rc1 (694f54f680f7), and manually > > Reviewed-by: Alex Deucher <alexander

Re: [PATCH 00/24] drm_framebuffer boilerplate removal

2018-03-30 Thread Daniel Stone
Hi Alex, On 30 March 2018 at 15:47, Alex Deucher <alexdeuc...@gmail.com> wrote: > On Fri, Mar 30, 2018 at 10:11 AM, Daniel Stone <dani...@collabora.com> wrote: >> I intend to remove create_handle when all drivers are converted over >> to placing BOs directly insid

[PATCH 01/24] drm/cirrus: Place GEM BOs in drm_framebuffer

2018-03-30 Thread Daniel Stone
Since drm_framebuffer can now store GEM objects directly, place them there rather than in our own subclass. As this makes the framebuffer create_handle and destroy functions the same as the GEM framebuffer helper, we can reuse those. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc

[PATCH 18/24] drm/exynos: exynos_drm_fb -> drm_framebuffer

2018-03-30 Thread Daniel Stone
Now exynos_drm_fb is just an empty wrapper around drm_framebuffer, we can drop it. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: Inki Dae <inki@samsung.com> Cc: Joonyoung Shim <jy0922.s...@samsung.com> Cc: Seung-Woo Kim <sw0312@samsung.com> Cc: K

[PATCH 12/24] drm/tegra: Move GEM BOs to drm_framebuffer

2018-03-30 Thread Daniel Stone
Since drm_framebuffer can now store GEM objects directly, place them there rather than in our own subclass. As this makes the framebuffer create_handle function the same as the GEM framebuffer helper, we can reuse that. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: Thierry

[PATCH 23/24] drm/radeon: radeon_framebuffer -> drm_framebuffer

2018-03-30 Thread Daniel Stone
Since drm_framebuffer can now store GEM objects directly, place them there rather than in our own subclass. As this makes the framebuffer create_handle and destroy functions the same as the GEM framebuffer helper, we can reuse those. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc

[PATCH 02/24] drm/cirrus: cirrus_framebuffer -> drm_framebuffer

2018-03-30 Thread Daniel Stone
Now cirrus_framebuffer is just an empty wrapper around drm_framebuffer, we can drop it. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: Dave Airlie <airl...@redhat.com> Cc: Gerd Hoffmann <kra...@redhat.com> Cc: virtualizat...@lists.linux-foundation.org --- driv

[PATCH 19/24] drm/armada: Move GEM BO to drm_framebuffer

2018-03-30 Thread Daniel Stone
Since drm_framebuffer can now store GEM objects directly, place them there rather than in our own subclass. As this makes the framebuffer create_handle and destroy functions the same as the GEM framebuffer helper, we can reuse those. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: R

[PATCH 20/24] drm/gma500: Move GEM BO to drm_framebuffer

2018-03-30 Thread Daniel Stone
Since drm_framebuffer can now store GEM objects directly, place them there rather than in our own subclass. As this makes the framebuffer create_handle and destroy functions the same as the GEM framebuffer helper, we can reuse those. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc:

[PATCH 17/24] drm/exynos: Move dma_addr out of exynos_drm_fb

2018-03-30 Thread Daniel Stone
This can be calculated from the GEM BO DMA address as well as the offset stored in the base framebuffer. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: Inki Dae <inki@samsung.com> Cc: Joonyoung Shim <jy0922.s...@samsung.com> Cc: Seung-Woo Kim <sw0312@sams

[PATCH 05/24] drm/rockchip: rockchip_drm_fb -> drm_framebuffer

2018-03-30 Thread Daniel Stone
Now that rockchip_drm_fb is just a wrapper around drm_framebuffer, we can remove it. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: Sandy Huang <h...@rock-chips.com> Cc: Heiko Stübner <he...@sntech.de> --- drivers/gpu/drm/rockchip/rockc

[PATCH 10/24] drm/mtk: mtk_drm_fb -> drm_framebuffer

2018-03-30 Thread Daniel Stone
Now that mtk_drm_fb is an empty wrapper around drm_framebuffer, we can just delete it. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: CK Hu <ck...@mediatek.com> Cc: Philipp Zabel <p.za...@pengutronix.de> --- drivers/gpu/drm/mediatek

[PATCH 13/24] drm/tegra: tegra_fb -> drm_framebuffer

2018-03-30 Thread Daniel Stone
Since tegra_fb is now the same as drm_framebuffer, we can just replace the type completely. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: Thierry Reding <thierry.red...@gmail.com> Cc: linux-te...@vger.kernel.org --- drivers/gpu/drm/tegra/drm.h | 6 +- drivers/gpu/dr

[PATCH 14/24] drm/tegra: Move fbdev unmap special case

2018-03-30 Thread Daniel Stone
cial case unmapping from the general-purpose framebuffer destroy, and move it to fbdev teardown. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: Thierry Reding <thierry.red...@gmail.com> Cc: linux-te...@vger.kernel.org --- drivers/gpu/drm/tegra/fb.c | 17 +++-

[PATCH 08/24] drm/mtk: Promote impossible internal error to WARN_ON

2018-03-30 Thread Daniel Stone
A FB with no object is something we should be shouting very loudly about, not quietly logging as debug. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: CK Hu <ck...@mediatek.com> Cc: Philipp Zabel <p.za...@pengutronix.de> --- drivers/gpu/drm/mediatek/mtk_drm_plane.c

[PATCH 21/24] drm/msm: Move GEM BOs to drm_framebuffer

2018-03-30 Thread Daniel Stone
Since drm_framebuffer can now store GEM objects directly, place them there rather than in our own subclass. As this makes the framebuffer create_handle function the same as the GEM framebuffer helper, we can reuse that. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: Rob Clark &

[PATCH 16/24] drm/exynos: Move GEM BOs to drm_framebuffer

2018-03-30 Thread Daniel Stone
Since drm_framebuffer can now store GEM objects directly, place them there rather than in our own subclass. As this makes the framebuffer create_handle and destroy functions the same as the GEM framebuffer helper, we can reuse those. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc

[PATCH 22/24] drm/radeon: Move GEM BO to drm_framebuffer

2018-03-30 Thread Daniel Stone
Since drm_framebuffer can now store GEM objects directly, place them there rather than in our own subclass. As this makes the framebuffer create_handle and destroy functions the same as the GEM framebuffer helper, we can reuse those. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc

[PATCH 11/24] drm/tegra: Remove duplicate framebuffer num_planes

2018-03-30 Thread Daniel Stone
drm_framebuffer already stores num_planes for us. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: Thierry Reding <thierry.red...@gmail.com> Cc: linux-te...@vger.kernel.org --- drivers/gpu/drm/tegra/drm.h | 1 - drivers/gpu/drm/tegra/fb.c | 6 ++ 2 files changed, 2 inse

[PATCH 06/24] drm/omap: Move GEM BO to drm_framebuffer

2018-03-30 Thread Daniel Stone
Since drm_framebuffer can now store GEM objects directly, place them there rather than in our own subclass. As this makes the framebuffer create_handle and destroy functions the same as the GEM framebuffer helper, we can reuse those. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc

[PATCH 24/24] drm/amdgpu: Move GEM BO to drm_framebuffer

2018-03-30 Thread Daniel Stone
Since drm_framebuffer can now store GEM objects directly, place them there rather than in our own subclass. As this makes the framebuffer create_handle and destroy functions the same as the GEM framebuffer helper, we can reuse those. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc

[PATCH 07/24] drm/omap: Move buffer pitch/offset to drm_framebuffer

2018-03-30 Thread Daniel Stone
drm_framebuffer already holds per-plane pitch and offsets, which is filled out for us when we create the framebuffer. Nuke our local copy in the plane struct. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: Tomi Valkeinen <tomi.valkei...@ti.com> --- drivers/gpu/drm/omapdrm/om

[PATCH 09/24] drm/mtk: Move GEM BO to drm_framebuffer

2018-03-30 Thread Daniel Stone
Since drm_framebuffer can now store GEM objects directly, place them there rather than in our own subclass. As this makes the framebuffer create_handle and destroy functions the same as the GEM framebuffer helper, we can reuse those. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc:

[PATCH 15/24] drm/tegra: Use drm_gem_fb_destroy

2018-03-30 Thread Daniel Stone
Now that our destroy function is the same as the helper, use that directly. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: Thierry Reding <thierry.red...@gmail.com> Cc: linux-te...@vger.kernel.org --- drivers/gpu/drm/tegra/fb.c | 17 + 1 file changed, 1 inse

[PATCH 04/24] drm/rockchip: Place GEM BOs in drm_framebuffer

2018-03-30 Thread Daniel Stone
Since drm_framebuffer can now store GEM objects directly, place them there rather than in our own subclass. As this makes the framebuffer create_handle and destroy functions the same as the GEM framebuffer helper, we can reuse those. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc:

[PATCH 03/24] drm/virtio: Place GEM BOs in drm_framebuffer

2018-03-30 Thread Daniel Stone
Since drm_framebuffer can now store GEM objects directly, place them there rather than in our own subclass. As this makes the framebuffer create_handle and destroy functions the same as the GEM framebuffer helper, we can reuse those. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc

[PATCH 00/24] drm_framebuffer boilerplate removal

2018-03-30 Thread Daniel Stone
Hi, I've been working on a getfb2[0] ioctl, which amongst other things supports multi-planar framebuffers as well as modifiers. getfb currently calls the framebuffer's handle_create hook, which doesn't support multiple planes. Thanks to Noralf's recent work, drivers can just store GEM objects

[PATCH libdrm 2/2] headers: Update README

2018-03-30 Thread Daniel Stone
Nouveau has made a very deliberate choice to hide its actual kernel ABI behind libdrm. i915 is no longer out of date. Signed-off-by: Daniel Stone <dani...@collabora.com> --- include/drm/README | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/include/drm/README b/i

[PATCH libdrm 1/2] headers: Sync with drm-next

2018-03-30 Thread Daniel Stone
- Add support for explicit fencing nouveau: - Add TILE_COMP layout vc4: - Add perfmon ioctls virtgpu: - Add capset-fix param vmware: - Add handle-close ioctl and explicit-fencing support Signed-off-by: Daniel Stone <dani...@collabora.com> --- etnaviv/etnaviv_drm.h

Re: [PATCH xserver 3/3] modesetting/drmmode: Use drmModeGetFB2

2018-03-27 Thread Daniel Stone
Hi Emil, On 26 March 2018 at 16:22, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 23 March 2018 at 13:50, Daniel Stone <dani...@collabora.com> wrote: >> Much like AddFB -> AddFB2, GetFB2 lets us get multiple buffers back as >> well as modifier information. Thi

Re: [PATCH v2 4/4] drm/vc4: Restrict active CTM to one CRTC

2018-03-26 Thread Daniel Stone
On 26 March 2018 at 09:29, Daniel Vetter <dan...@ffwll.ch> wrote: > On Sun, Mar 25, 2018 at 08:14:35PM +0200, Stefan Schake wrote: >> On Sun, Mar 25, 2018 at 10:01 AM, Daniel Stone <dan...@fooishbar.org> wrote: >> > On 25 March 2018 at 02:52, Stefan Schake <stsch..

Re: [PATCH v2 4/4] drm/vc4: Restrict active CTM to one CRTC

2018-03-25 Thread Daniel Stone
Hi Stefan, On 25 March 2018 at 02:52, Stefan Schake wrote: > +static int vc4_crtc_get_ctm_fifo(struct vc4_dev *vc4) > +{ > + return VC4_GET_FIELD(HVS_READ(SCALER_OLEDOFFS), > +SCALER_OLEDOFFS_DISPFIFO); > +} This needs to be managed as a

Re: [PATCH 4/4] drm: Add getfb2 ioctl

2018-03-24 Thread Daniel Stone
On 23 March 2018 at 17:31, Ville Syrjälä <ville.syrj...@linux.intel.com> wrote: > On Fri, Mar 23, 2018 at 05:00:11PM +0000, Daniel Stone wrote: >> On 23 March 2018 at 14:49, Ville Syrjälä <ville.syrj...@linux.intel.com> >> wrote: >> > On Fri, Mar 23, 2018 at

Re: [PATCH 4/4] drm: Add getfb2 ioctl

2018-03-23 Thread Daniel Stone
Hi, On 23 March 2018 at 14:49, Ville Syrjälä <ville.syrj...@linux.intel.com> wrote: > On Fri, Mar 23, 2018 at 01:45:52PM +0000, Daniel Stone wrote: >> + for (i = 0; i < ARRAY_SIZE(r->handles); i++) { >> + r->handles[i] = 0; >> + r

Re: [igt-dev] [PATCH i-g-t 1/3] tests/kms_getfb: Split property-ID get into helper

2018-03-23 Thread Daniel Stone
On 23 March 2018 at 14:53, Ville Syrjälä <ville.syrj...@linux.intel.com> wrote: > On Fri, Mar 23, 2018 at 01:46:14PM +0000, Daniel Stone wrote: >> +/** >> + * Find and return an arbitrary valid property ID. >> + */ >> +static uint32_t get_prop_id(int fd) > &

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Move GEM BO inside drm_framebuffer

2018-03-23 Thread Daniel Stone
Hi Ville, On 23 March 2018 at 14:42, Ville Syrjälä <ville.syrj...@linux.intel.com> wrote: > On Fri, Mar 23, 2018 at 01:45:50PM +0000, Daniel Stone wrote: >> --- a/drivers/gpu/drm/i915/intel_display.c >> +++ b/drivers/gpu/drm/i915/intel_display.c >> @@ -1391

Re: [PATCH 0/8] Add GetFB2 ioctl

2018-03-23 Thread Daniel Stone
On 23 March 2018 at 13:42, Daniel Stone <dan...@fooishbar.org> wrote: > This submission rights that historical wrong, which allows Xorg > -background none to continue to work in the face of exotic buffers. > I've written patches to Xorg to use this as UABI verification, and >

[PATCH i-g-t 3/3] tests/kms_getfb: Add getfb2 tests

2018-03-23 Thread Daniel Stone
Mirroring addfb2, add tests for the new ioctl which will return us information about framebuffers containing multiple buffers, as well as modifiers. Signed-off-by: Daniel Stone <dani...@collabora.com> --- tests/kms_getfb.c | 91 +++

[PATCH i-g-t 2/3] NOMERGE: Update DRM UAPI to latest kernel version

2018-03-23 Thread Daniel Stone
This depends on unmerged kernel code, so. --- include/drm-uapi/amdgpu_drm.h | 1 + include/drm-uapi/drm.h | 1 + include/drm-uapi/drm_mode.h| 9 ++--- include/drm-uapi/etnaviv_drm.h | 1 + include/drm-uapi/msm_drm.h | 9 - include/drm-uapi/virtgpu_drm.h | 1 + 6 files

[PATCH 2/4] drm/i915: Move GEM BO inside drm_framebuffer

2018-03-23 Thread Daniel Stone
Since drm_framebuffer can now store GEM objects directly, place them there rather than in our own subclass. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: Jani Nikula <jani.nik...@linux.intel.com> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Cc: Rodri

[PATCH 1/4] drm/i915: Use intel_fb_obj() everywhere

2018-03-23 Thread Daniel Stone
We already have a macro to pull the GEM object from a FB, so use it everywhere. We'll make use of this later to move the object storage. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: Jani Nikula <jani.nik...@linux.intel.com> Cc: Joonas Lahtinen <joonas.lahti...@linu

  1   2   3   4   5   6   >