Re: [Intel-gfx] [PATCH 1/3] drm/atomic-helpers: remove legacy_cursor_update hacks

2020-10-22 Thread Daniel Vetter
On Thu, Oct 22, 2020 at 7:22 PM Rob Clark wrote: > > On Thu, Oct 22, 2020 at 10:02 AM Rob Clark wrote: > > > > On Wed, Oct 21, 2020 at 9:32 AM Daniel Vetter > > wrote: > > > > > > The stuff never really worked, and leads to lots of fun because it >

Re: [Outreachy kernel][PATCH 0/5] drm/amdgpu: Replace snprintf() with sysfs_emit

2020-10-22 Thread Daniel Vetter
dgpu_atombios.c | 2 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 > drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 4 ++-- > drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 ++-- > 5 files changed, 10 insertions

Re: [PATCH 1/3] drm/atomic-helpers: remove legacy_cursor_update hacks

2020-10-22 Thread Daniel Vetter
On Thu, Oct 22, 2020 at 09:36:23AM -0400, Kazlauskas, Nicholas wrote: > On 2020-10-21 12:32 p.m., Daniel Vetter wrote: > > The stuff never really worked, and leads to lots of fun because it > > out-of-order frees atomic states. Which upsets KASAN, among other > > things. >

Re: [PATCH v2 0/3] drm/panel: mantix panel reset fixes

2020-10-22 Thread Daniel Vetter
On Tue, Oct 20, 2020 at 01:57:11PM +0200, Guido Günther wrote: > Hi Daniel, Sam, > On Mon, Oct 19, 2020 at 05:44:37PM +0200, Daniel Vetter wrote: > > On Sat, Oct 17, 2020 at 12:47:36PM +0200, Sam Ravnborg wrote: > > > Hi Guido. > > > > > > On Sat, Oct 17,

Re: [PATCH v3 12/16] PCI: Obey iomem restrictions for procfs mmap

2020-10-22 Thread Daniel Vetter
On Thu, Oct 22, 2020 at 1:43 PM Jason Gunthorpe wrote: > > On Thu, Oct 22, 2020 at 09:00:44AM +0200, Daniel Vetter wrote: > > On Thu, Oct 22, 2020 at 1:20 AM Jason Gunthorpe wrote: > > > > > > On Wed, Oct 21, 2020 at 09:24:08PM +0200, Daniel Vetter wrote: > >

Re: [PATCH 1/4] drm: allow drm_atomic_print_state() to accept any drm_printer

2020-10-22 Thread Daniel Vetter
rm_atomic_print_state(state, ); > > ret = drm_atomic_commit(state); > } > diff --git a/drivers/gpu/drm/drm_crtc_internal.h > b/drivers/gpu/drm/drm_crtc_internal.h > index da96b2f64d7e..d34215366936 100644 > --- a/drivers/gpu/drm/drm_crtc_internal.h > +++ b/

Re: [PATCH v5 08/10] drm/gem: Store client buffer mappings as struct dma_buf_map

2020-10-22 Thread Daniel Vetter
On Thu, Oct 22, 2020 at 11:18 AM Thomas Zimmermann wrote: > > Hi > > On 22.10.20 10:49, Daniel Vetter wrote: > > On Tue, Oct 20, 2020 at 02:20:44PM +0200, Thomas Zimmermann wrote: > >> Kernel DRM clients now store their framebuffer address in an instance > >&

Re: [PATCH v5 10/10] drm/fb_helper: Support framebuffers in I/O memory

2020-10-22 Thread Daniel Vetter
On Thu, Oct 22, 2020 at 10:37:56AM +0200, Thomas Zimmermann wrote: > Hi > > On 22.10.20 10:05, Daniel Vetter wrote: > > On Tue, Oct 20, 2020 at 02:20:46PM +0200, Thomas Zimmermann wrote: > >> At least sparc64 requires I/O-specific access to framebuffers. This > >>

Re: [PATCH v5 08/10] drm/gem: Store client buffer mappings as struct dma_buf_map

2020-10-22 Thread Daniel Vetter
_vmap() receive a copy of the value in > the call's supplied arguments. It can be accessed and modified with > dma_buf_map interfaces. > > Signed-off-by: Thomas Zimmermann > Reviewed-by: Daniel Vetter > Tested-by: Sam Ravnborg > --- >

Re: [PATCH v5 10/10] drm/fb_helper: Support framebuffers in I/O memory

2020-10-22 Thread Daniel Vetter
dependencies on the fbdev module. Some of the > +helpers could further benefit from using struct dma_buf_map instead of > +raw pointers. > + > +Contact: Thomas Zimmermann , Daniel Vetter > + > +Level: Advanced > + > + > drm_framebuffer_funcs and drm_mode_config_funcs.f

Re: [PATCH v2 08/17] s390/pci: Remove races against pte updates

2020-10-22 Thread Daniel Vetter
ed was waiting for v3. Hence the delay. Cheers, Daniel > > Best regards, > Niklas Schnelle > > On 10/12/20 4:19 PM, Daniel Vetter wrote: > > On Mon, Oct 12, 2020 at 04:03:28PM +0200, Niklas Schnelle wrote: > ... snip > >>> Cc: Jason Gunthorpe > >&g

Re: [PATCH v3 12/16] PCI: Obey iomem restrictions for procfs mmap

2020-10-22 Thread Daniel Vetter
On Thu, Oct 22, 2020 at 1:20 AM Jason Gunthorpe wrote: > > On Wed, Oct 21, 2020 at 09:24:08PM +0200, Daniel Vetter wrote: > > On Wed, Oct 21, 2020 at 6:37 PM Jason Gunthorpe wrote: > > > > > > On Wed, Oct 21, 2020 at 05:54:54PM +0200, Daniel Vetter wr

Re: [PATCH 0/3] drm: Store USB device in struct drm_device

2020-10-21 Thread Daniel Vetter
On Wed, Oct 21, 2020 at 10:01:29PM +0200, Daniel Vetter wrote: > On Wed, Oct 21, 2020 at 03:07:29PM +0200, Thomas Zimmermann wrote: > > The drivers gm12u320 and udl operate on USB devices. They leave the > > PCI device in struct drm_device empty and store the USB device in their

Re: [PATCH 0/3] drm: Store USB device in struct drm_device

2020-10-21 Thread Daniel Vetter
dl/udl_connector.c | 8 ++--- > drivers/gpu/drm/udl/udl_drv.c | 2 +- > drivers/gpu/drm/udl/udl_drv.h | 1 - > drivers/gpu/drm/udl/udl_main.c | 15 + > include/drm/drm_device.h| 21 > 6 files changed, 52 insertions(+), 47 deleti

Re: [PATCH v3 14/16] resource: Move devmem revoke code to resource framework

2020-10-21 Thread Daniel Vetter
On Wed, Oct 21, 2020 at 8:59 PM Dan Williams wrote: > > On Wed, Oct 21, 2020 at 1:57 AM Daniel Vetter wrote: > > > > We want all iomem mmaps to consistently revoke ptes when the kernel > > takes over and CONFIG_IO_STRICT_DEVMEM is enabled. This includes the > > p

Re: [PATCH v3 12/16] PCI: Obey iomem restrictions for procfs mmap

2020-10-21 Thread Daniel Vetter
On Wed, Oct 21, 2020 at 6:37 PM Jason Gunthorpe wrote: > > On Wed, Oct 21, 2020 at 05:54:54PM +0200, Daniel Vetter wrote: > > > The trouble is that io_remap_pfn adjust vma->pgoff, so we'd need to > > split that. So ideally ->mmap would never set up any ptes. > &g

Re: [PATCH] drm: add client cap to expose low power modes

2020-10-21 Thread Daniel Vetter
On Wed, Oct 21, 2020 at 05:11:00PM +0100, Daniel Stone wrote: > On Wed, 21 Oct 2020 at 16:58, Daniel Vetter wrote: > > On Wed, Oct 21, 2020 at 4:59 PM Ken Huang wrote: > > > It's useful in Android and other embedded devices to implement Always On > > > Display (ex. sh

[PATCH 3/3] drm/doc: Document legacy_cursor_update better

2020-10-21 Thread Daniel Vetter
It's the horror and shouldn't be used. Realized we're not clear on this in a discussion with Rob about what msm is doing to better support async commits. v2: Refine existing todo item to include this (Thomas) Cc: Sean Paul Cc: Rob Clark Signed-off-by: Daniel Vetter Cc: Maarten Lankhorst Cc

[PATCH 2/3] drm/vc4: Drop legacy_cursor_update override

2020-10-21 Thread Daniel Vetter
With the removal of helper support it doesn't do anything anymore. Also, we already have async plane update code in vc4. Signed-off-by: Daniel Vetter Cc: Eric Anholt Cc: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_kms.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 1/3] drm/atomic-helpers: remove legacy_cursor_update hacks

2020-10-21 Thread Daniel Vetter
retire this. References: https://bugzilla.kernel.org/show_bug.cgi?id=199425 Cc: mikita.lip...@amd.com Cc: Michel Dänzer Cc: harry.wentl...@amd.com Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_atomic_helper.c | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/g

Re: [PATCH] drm: Give irq_by_busid drm_legacy_ prefix

2020-10-21 Thread Daniel Vetter
On Thu, Oct 08, 2020 at 10:38:05AM -0400, Alex Deucher wrote: > On Thu, Oct 8, 2020 at 10:29 AM Daniel Vetter wrote: > > > > It's the only ioctl handler purely for legacy drivers that didn't have > > this yet. > > > > Signed-off-by: Daniel Vetter >

Re: [PATCH] drm: add client cap to expose low power modes

2020-10-21 Thread Daniel Vetter
idea what the semantics are. Even after you've explained the use-case. Also for new kms uapi we need an igt testcase to exercise this and make sure it works. -Daniel > > Thanks, > Ken > > Daniel Vetter 於 2020年10月21日 週三 下午4:34寫道: >> >> On Wed, Oct 21, 2020 at 07:40

Re: [PATCH v3 12/16] PCI: Obey iomem restrictions for procfs mmap

2020-10-21 Thread Daniel Vetter
On Wed, Oct 21, 2020 at 5:13 PM Jason Gunthorpe wrote: > > On Wed, Oct 21, 2020 at 04:42:11PM +0200, Daniel Vetter wrote: > > > Uh yes. In drivers/gpu this isn't a problem because we only install > > ptes from the vm_ops->fault handler. So no races. And I don

Re: [PATCH v3 12/16] PCI: Obey iomem restrictions for procfs mmap

2020-10-21 Thread Daniel Vetter
On Wed, Oct 21, 2020 at 2:50 PM Jason Gunthorpe wrote: > > On Wed, Oct 21, 2020 at 10:56:51AM +0200, Daniel Vetter wrote: > > There's three ways to access PCI BARs from userspace: /dev/mem, sysfs > > files, and the old proc interface. Two check against > > iomem_is_e

Re: [PATCH v3 08/16] s390/pci: Remove races against pte updates

2020-10-21 Thread Daniel Vetter
On Wed, Oct 21, 2020 at 11:38 AM Niklas Schnelle wrote: > > > > On 10/21/20 10:56 AM, Daniel Vetter wrote: > > Way back it was a reasonable assumptions that iomem mappings never > > change the pfn range they point at. But this has changed: > > > > - gpu dri

[PATCH v3 16/16] PCI: Revoke mappings like devmem

2020-10-21 Thread Daniel Vetter
map through a special pfn range and not through magic pte attributes. Aliasing is therefore not a problem. The only difference in access checks left is that sysfs PCI mmap does not check for CAP_RAWIO. I'm not really sure whether that should be added or not. Signed-off-by: Daniel Vetter Cc: Jas

[PATCH v3 13/16] /dev/mem: Only set filp->f_mapping

2020-10-21 Thread Daniel Vetter
ner, since in e.g. drivers/gpu we don't do that. Per Dan this seems to be copypasta from places which do care about pagecache consistency, but not needed. Hence remove it for slightly less confusion. Signed-off-by: Daniel Vetter Cc: Jason Gunthorpe Cc: Kees Cook Cc: Dan Williams Cc: Andrew Morton

[PATCH v3 14/16] resource: Move devmem revoke code to resource framework

2020-10-21 Thread Daniel Vetter
/resource.c. Reviewed-by: Greg Kroah-Hartman Signed-off-by: Daniel Vetter Cc: Jason Gunthorpe Cc: Kees Cook Cc: Dan Williams Cc: Andrew Morton Cc: John Hubbard Cc: Jérôme Glisse Cc: Jan Kara Cc: Dan Williams Cc: linux...@kvack.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-samsung

[PATCH v3 12/16] PCI: Obey iomem restrictions for procfs mmap

2020-10-21 Thread Daniel Vetter
is loaded and using it. Fix this by adding the same iomem_is_exclusive() check we already have on the sysfs side in pci_mmap_resource(). References: 90a545e98126 ("restrict /dev/mem to idle io memory ranges") Signed-off-by: Daniel Vetter Cc: Jason Gunthorpe Cc: Kees Cook Cc: Dan Wi

[PATCH v3 09/16] mm: Add unsafe_follow_pfn

2020-10-21 Thread Daniel Vetter
ype1 iommu). For now annotate these as unsafe and splat appropriately. This patch adds an unsafe_follow_pfn, which later patches will then roll out to all appropriate places. Signed-off-by: Daniel Vetter Cc: Jason Gunthorpe Cc: Kees Cook Cc: Dan Williams Cc: Andrew Morton Cc: John Hubbard

[PATCH v3 15/16] sysfs: Support zapping of binary attr mmaps

2020-10-21 Thread Daniel Vetter
mmap support allowing to adjust the ->f_mapping makes no sense. Reviewed-by: Greg Kroah-Hartman Signed-off-by: Daniel Vetter Cc: Jason Gunthorpe Cc: Kees Cook Cc: Dan Williams Cc: Andrew Morton Cc: John Hubbard Cc: Jérôme Glisse Cc: Jan Kara Cc: Dan Williams Cc: linux...@kvack.org C

[PATCH v3 03/16] misc/habana: Stop using frame_vector helpers

2020-10-21 Thread Daniel Vetter
All we need are a pages array, pin_user_pages_fast can give us that directly. Plus this avoids the entire raw pfn side of get_vaddr_frames. Reviewed-by: John Hubbard Signed-off-by: Daniel Vetter Cc: Jason Gunthorpe Cc: Andrew Morton Cc: John Hubbard Cc: Jérôme Glisse Cc: Jan Kara Cc: Dan

[PATCH v3 07/16] mm: Close race in generic_access_phys

2020-10-21 Thread Daniel Vetter
-...@vger.kernel.org Cc: linux-me...@vger.kernel.org Signed-off-by: Daniel Vetter -- v2: Fix inversion in the retry check (John). --- include/linux/mm.h | 3 ++- mm/memory.c| 44 ++-- 2 files changed, 44 insertions(+), 3 deletions(-) diff --git a/inclu

[PATCH v3 10/16] media/videbuf1|2: Mark follow_pfn usage as unsafe

2020-10-21 Thread Daniel Vetter
rt io userptr operations on io memory"). Signed-off-by: Daniel Vetter Cc: Jason Gunthorpe Cc: Kees Cook Cc: Dan Williams Cc: Andrew Morton Cc: John Hubbard Cc: Jérôme Glisse Cc: Jan Kara Cc: Dan Williams Cc: linux...@kvack.org Cc: linux-arm-ker...@lists.infradead.org Cc: lin

[PATCH v3 00/16] follow_pfn and other iomap races

2020-10-21 Thread Daniel Vetter
, Daniel Daniel Vetter (16): drm/exynos: Stop using frame_vector helpers drm/exynos: Use FOLL_LONGTERM for g2d cmdlists misc/habana: Stop using frame_vector helpers misc/habana: Use FOLL_LONGTERM for userptr mm/frame-vector: Use FOLL_LONGTERM media: videobuf2: Move frame_vector into media

[PATCH v3 05/16] mm/frame-vector: Use FOLL_LONGTERM

2020-10-21 Thread Daniel Vetter
section as suggested by Jason. By relying entirely on the vma checks in pin_user_pages and follow_pfn (for vm_flags and vma_is_fsdax) we can also streamline the code a lot. Signed-off-by: Daniel Vetter Cc: Jason Gunthorpe Cc: Pawel Osciak Cc: Marek Szyprowski Cc: Kyungmin Park Cc: Tomasz Figa

[PATCH v3 11/16] vfio/type1: Mark follow_pfn as unsafe

2020-10-21 Thread Daniel Vetter
up an mmu_notifier ... somehow. Probably means any invalidate is a fatal fault for this vfio device, but then this shouldn't ever happen if userspace is reasonable. Signed-off-by: Daniel Vetter Cc: Jason Gunthorpe Cc: Kees Cook Cc: Dan Williams Cc: Andrew Morton Cc: John Hubbard Cc: Jérôme

[PATCH v3 01/16] drm/exynos: Stop using frame_vector helpers

2020-10-21 Thread Daniel Vetter
All we need are a pages array, pin_user_pages_fast can give us that directly. Plus this avoids the entire raw pfn side of get_vaddr_frames. Reviewed-by: John Hubbard Signed-off-by: Daniel Vetter Cc: Jason Gunthorpe Cc: Inki Dae Cc: Joonyoung Shim Cc: Seung-Woo Kim Cc: Kyungmin Park Cc

[PATCH v3 08/16] s390/pci: Remove races against pte updates

2020-10-21 Thread Daniel Vetter
it message (Niklas) Reviewed-by: Gerald Schaefer Signed-off-by: Daniel Vetter Cc: Jason Gunthorpe Cc: Dan Williams Cc: Kees Cook Cc: Andrew Morton Cc: John Hubbard Cc: Jérôme Glisse Cc: Jan Kara Cc: linux...@kvack.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-samsung-...@vger.kernel.org

[PATCH v3 02/16] drm/exynos: Use FOLL_LONGTERM for g2d cmdlists

2020-10-21 Thread Daniel Vetter
The exynos g2d interface is very unusual, but it looks like the userptr objects are persistent. Hence they need FOLL_LONGTERM. Signed-off-by: Daniel Vetter Cc: Jason Gunthorpe Cc: Inki Dae Cc: Joonyoung Shim Cc: Seung-Woo Kim Cc: Kyungmin Park Cc: Kukjin Kim Cc: Krzysztof Kozlowski Cc

[PATCH v3 04/16] misc/habana: Use FOLL_LONGTERM for userptr

2020-10-21 Thread Daniel Vetter
These are persistent, not just for the duration of a dma operation. Signed-off-by: Daniel Vetter Cc: Jason Gunthorpe Cc: Andrew Morton Cc: John Hubbard Cc: Jérôme Glisse Cc: Jan Kara Cc: Dan Williams Cc: linux...@kvack.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-samsung

[PATCH v3 06/16] media: videobuf2: Move frame_vector into media subsystem

2020-10-21 Thread Daniel Vetter
It's the only user. This also garbage collects the CONFIG_FRAME_VECTOR symbol from all over the tree (well just one place, somehow omap media driver still had this in its Kconfig, despite not using it). Reviewed-by: John Hubbard Acked-by: Mauro Carvalho Chehab Signed-off-by: Daniel Vetter Cc

Re: [PATCH] drm: add client cap to expose low power modes

2020-10-21 Thread Daniel Vetter
al handling as they would usually require lower OPR > > content on framebuffers. > > I'm not familiar with OPR. Can you explain what it is and what it means > for user-space? Also since this is new uapi, I guess best explanation would include the userspace code that makes sensible

Re: [PATCH 3/3] drm/ttm: avoid multihop moves in drivers.

2020-10-21 Thread Daniel Vetter
(struct ttm_operation_ctx *ctx) > evict_mem.placement = 0; > evict_mem.mem_type = TTM_PL_SYSTEM; > > - ret = ttm_bo_handle_move_mem(bo, _mem, true, ); > + ret = ttm_bo_handle_move_mem(bo, _mem, true, , NULL); > if (unlikely(ret != 0)) > goto out; > } > @@ -1481,4 +1526,3 @@ void ttm_bo_tt_destroy(struct ttm_buffer_object *bo) > ttm_tt_destroy(bo->bdev, bo->ttm); > bo->ttm = NULL; > } > - > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c > b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c > index 88be48ad0344..d48b70605a56 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c > @@ -731,7 +731,8 @@ static void vmw_swap_notify(struct ttm_buffer_object *bo) > static int vmw_move(struct ttm_buffer_object *bo, > bool evict, > struct ttm_operation_ctx *ctx, > - struct ttm_resource *new_mem) > + struct ttm_resource *new_mem, > + struct ttm_place *hop) > { > struct ttm_resource_manager *old_man = ttm_manager_type(bo->bdev, > bo->mem.mem_type); > struct ttm_resource_manager *new_man = ttm_manager_type(bo->bdev, > new_mem->mem_type); > diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h > index 29f6a1d1c853..e4eab7a45ace 100644 > --- a/include/drm/ttm/ttm_bo_driver.h > +++ b/include/drm/ttm/ttm_bo_driver.h > @@ -133,12 +133,15 @@ struct ttm_bo_driver { >* the graphics address space >* @ctx: context for this move with parameters >* @new_mem: the new memory region receiving the buffer > + @ @hop: placement for driver directed intermediate hop >* >* Move a buffer between two memory regions. > + * Returns errno -EMULTIHOP if driver requests a hop >*/ > int (*move)(struct ttm_buffer_object *bo, bool evict, > struct ttm_operation_ctx *ctx, > - struct ttm_resource *new_mem); > + struct ttm_resource *new_mem, > + struct ttm_place *hop); > > /** >* struct ttm_bo_driver_member verify_access > -- > 2.27.0 > > ___ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 0/3] drm/msm: kthread_worker conversion

2020-10-21 Thread Daniel Vetter
On Tue, Oct 20, 2020 at 01:26:29PM -0700, Rob Clark wrote: > On Tue, Oct 20, 2020 at 11:14 AM Daniel Vetter wrote: > > > > On Tue, Oct 20, 2020 at 7:23 PM Rob Clark wrote: > > > > > > On Tue, Oct 20, 2020 at 10:02 AM Daniel Vetter wrote: > > > > >

Re: It appears drm-next TTM cleanup broke something . . .

2020-10-21 Thread Daniel Vetter
> >> > >> I know you have been working on and off on the openchrome driver for a > >> long time now. Any chance we will see the driver submitted for upstream > >> soon? > >> > >> Sam > >> > > ___

Re: [PATCH 0/3] drm/msm: kthread_worker conversion

2020-10-20 Thread Daniel Vetter
On Tue, Oct 20, 2020 at 7:23 PM Rob Clark wrote: > > On Tue, Oct 20, 2020 at 10:02 AM Daniel Vetter wrote: > > > > On Tue, Oct 20, 2020 at 5:08 PM Rob Clark wrote: > > > > > > On Tue, Oct 20, 2020 at 7:29 AM Daniel Vetter wrote: > > > > > >

Re: [PATCH 0/3] drm/msm: kthread_worker conversion

2020-10-20 Thread Daniel Vetter
On Tue, Oct 20, 2020 at 5:08 PM Rob Clark wrote: > > On Tue, Oct 20, 2020 at 7:29 AM Daniel Vetter wrote: > > > > On Tue, Oct 20, 2020 at 4:01 PM Rob Clark wrote: > > > > > > On Tue, Oct 20, 2020 at 1:24 AM Daniel Vetter wrote: > > > > >

[PATCH] drm/doc: Document legacy_cursor_update better

2020-10-20 Thread Daniel Vetter
It's the horror and shouldn't be used. Realized we're not clear on this in a discussion with Rob about what msm is doing to better support async commits. v2: Refine existing todo item to include this (Thomas) Cc: Sean Paul Cc: Rob Clark Signed-off-by: Daniel Vetter Cc: Maarten Lankhorst Cc

Re: [PATCH] drm/doc: Document legacy_cursor_update better

2020-10-20 Thread Daniel Vetter
On Tue, Oct 20, 2020 at 4:55 PM Thomas Zimmermann wrote: > > Hi > > On 20.10.20 16:39, Daniel Vetter wrote: > > It's the horror and shouldn't be used. Realized we're not clear on > > this in a discussion with Rob about what msm is doing to better > > support async

Re: [PATCH] drm/doc: Document legacy_cursor_update better

2020-10-20 Thread Daniel Vetter
commit support On Tue, Oct 20, 2020 at 4:39 PM Daniel Vetter wrote: > > It's the horror and shouldn't be used. Realized we're not clear on > this in a discussion with Rob about what msm is doing to better > support async commits. > > Cc: Rob Clark > Signed-off-by: Daniel

[PATCH] drm/doc: Document legacy_cursor_update better

2020-10-20 Thread Daniel Vetter
It's the horror and shouldn't be used. Realized we're not clear on this in a discussion with Rob about what msm is doing to better support async commits. Cc: Rob Clark Signed-off-by: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel

Re: [PATCH 0/3] drm/msm: kthread_worker conversion

2020-10-20 Thread Daniel Vetter
On Tue, Oct 20, 2020 at 4:01 PM Rob Clark wrote: > > On Tue, Oct 20, 2020 at 1:24 AM Daniel Vetter wrote: > > > > On Mon, Oct 19, 2020 at 02:10:50PM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > In particular, converting the async

Re: [PATCH v2 07/22] drm/msm: Do rpm get sooner in the submit path

2020-10-20 Thread Daniel Vetter
On Tue, Oct 20, 2020 at 1:24 PM Viresh Kumar wrote: > > On 20-10-20, 12:56, Daniel Vetter wrote: > > Yeah that's bad practice. Generally you shouldn't need to hold locks > > in setup/teardown code, since there's no other thread which can > > possible hold a reference t

Re: [PATCH v3 19/20] drm/tegra: Implement new UAPI

2020-10-20 Thread Daniel Vetter
(ideally in mesa3d too, using the gallium framework so that a lot of the boring integration glue is taken care of already) directly on top of drm. No v4l driver needed at all here. And it sounds like this nvdec thing would fit that bill pretty neatly. > I'm also not quite sure about

Re: [PATCH v2 07/22] drm/msm: Do rpm get sooner in the submit path

2020-10-20 Thread Daniel Vetter
On Tue, Oct 20, 2020 at 11:07 AM Viresh Kumar wrote: > > On 12-10-20, 08:43, Rob Clark wrote: > > On Mon, Oct 12, 2020 at 7:35 AM Daniel Vetter wrote: > > > > > > On Sun, Oct 11, 2020 at 07:09:34PM -0700, Rob Clark wrote: > > > > From: Rob

Re: [PATCH] drm/vkms: Unset preferred_depth

2020-10-20 Thread Daniel Vetter
On Tue, Oct 20, 2020 at 10:42 AM Simon Ser wrote: > > On Tuesday, October 20, 2020 10:35 AM, Daniel Vetter > wrote: > > > There's a confusion between the preferred_depth uapi and the generic > > fbdev helpers. Former wants depth, latter wants bpp, and for XRGB >

[PATCH] drm/vkms: Unset preferred_depth

2020-10-20 Thread Daniel Vetter
, and we have what we want. Reported-by: Simon Ser Cc: Simon Ser Signed-off-by: Daniel Vetter Cc: Rodrigo Siqueira Cc: Melissa Wen Cc: Haneen Mohammed Cc: Daniel Vetter --- drivers/gpu/drm/vkms/vkms_drv.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu

Re: [PATCH 3/3] drm/vkms: fbdev emulation support

2020-10-20 Thread Daniel Vetter
On Fri, Oct 16, 2020 at 07:10:56AM -0300, Melissa Wen wrote: > Hi, > > Thanks for this improvement. > > I could see that it increased the IGT test coverage, including now the > fbdev test cases. > > On 10/10, Daniel Vetter wrote: > > Hooray for generic fbdev suppo

Re: [PATCH 0/3] drm/msm: kthread_worker conversion

2020-10-20 Thread Daniel Vetter
| 13 +++--- > drivers/gpu/drm/msm/msm_kms.h | 23 ++--- > 13 files changed, 104 insertions(+), 43 deletions(-) > > -- > 2.26.2 > > ___ > dri-devel mailing list > dri-devel@lists.freedesktop.org >

Re: [PATCH v2] drm/of: Consider the state in which the ep is disabled

2020-10-20 Thread Daniel Vetter
On Mon, Oct 19, 2020 at 11:43:53AM +0800, Kever Yang wrote: > Hi Daniel, > > On 2020/10/15 下午11:23, Daniel Vetter wrote: > > On Wed, Oct 14, 2020 at 09:48:43AM +0800, Kever Yang wrote: > > > Hi Maintainers, > > > > > >     Does this patch ready to merge

Re: [PATCH 2/2 RESEND] docs: fb: Add font_6x8 to available built-in fonts

2020-10-19 Thread Daniel Vetter
se. The value 'name' can be any of the > - compiled-in fonts: 10x18, 6x10, 7x14, Acorn8x8, MINI4x6, > + compiled-in fonts: 10x18, 6x10, 6x8, 7x14, Acorn8x8, MINI4x6, > PEARL8x8, ProFont6x11, SUN12x22, SUN8x16, TER16x32, VGA8x16, VGA8x8. > > Note, not all drivers c

Re: [PATCH] drm/drm_vblank: use drm_warn_once() to warn undefined mode timing

2020-10-19 Thread Daniel Vetter
On Fri, Oct 16, 2020 at 07:46:41PM +0800, Shawn Guo wrote: > On Fri, Oct 16, 2020 at 11:30:04AM +0200, Daniel Vetter wrote: > > On Fri, Oct 16, 2020 at 10:54 AM Shawn Guo wrote: > > > > > > On Fri, Oct 16, 2020 at 09:58:46AM +0200, Daniel Vetter wrote: > > &g

Re: [PATCH v4 05/10] drm/ttm: Add vmap/vunmap to TTM and TTM GEM helpers

2020-10-19 Thread Daniel Vetter
_bo_mmap_obj - mmap memory backed by a ttm buffer object. > > > >    * > > > > diff --git a/include/linux/dma-buf-map.h b/include/linux/dma-buf-map.h > > > > index fd1aba545fdf..2e8bbecb5091 100644 > > > > --- a/include/linux/dma-buf-map.h > > > &

Re: [PATCH v2 0/3] drm/panel: mantix panel reset fixes

2020-10-19 Thread Daniel Vetter
maintainer-tools/committer-drm-misc.html#where-do-i-apply-my-patch Cheers, Daniel > > When you apply to drm-misc-fixes include a Fixes: tag so the tooling > will pick the patches automagically. > > In hindsight the patches should have carried a Fixes: tag fro

Re: [PATCH 1/2] Fonts: Support FONT_EXTRA_WORDS macros for font_6x8

2020-10-18 Thread Daniel Vetter
On Sun, Oct 18, 2020 at 10:45 PM Peilin Ye wrote: > > On Sun, Oct 18, 2020 at 10:33:11PM +0200, Daniel Vetter wrote: > > On Sun, Oct 18, 2020 at 10:18 PM Peilin Ye wrote: > > > 2/2 is just updating the fb documentation: > > > > > > [PATCH 2/2] docs: fb: A

Re: [PATCH 1/2] Fonts: Support FONT_EXTRA_WORDS macros for font_6x8

2020-10-18 Thread Daniel Vetter
On Sun, Oct 18, 2020 at 10:18 PM Peilin Ye wrote: > > On Sun, Oct 18, 2020 at 10:09:06PM +0200, Daniel Vetter wrote: > > Adding dri-devel too, not sure anyone is still listening on linux-fbdev. > > I see, thanks! > > > On Sun, Oct 18, 2020 at 8:13 PM Peilin Ye

Re: [PATCH 1/2] Fonts: Support FONT_EXTRA_WORDS macros for font_6x8

2020-10-18 Thread Daniel Vetter
truct font_desc font_6x8 = { > .idx= FONT6x8_IDX, > .name = "6x8", > .width = 6, > .height = 8, > - .data = fontdata_6x8, > + .data = fontdata_6x8.data, > .pref = 0, > }; > -- > 2.25.1 > -- Da

Re: [PATCH v5 1/5] RDMA/umem: Support importing dma-buf as user memory region

2020-10-18 Thread Daniel Vetter
e move_notify again. As a first thing I'd do the same thing you do for mmu notifier ranges, since it's kinda similarish. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/3] drm/vkms: Set preferred depth correctly

2020-10-17 Thread Daniel Vetter
On Sat, Oct 17, 2020 at 10:39 AM Melissa Wen wrote: > > On 10/16, Daniel Vetter wrote: > > On Fri, Oct 16, 2020 at 7:02 PM Melissa Wen wrote: > > > > > > On 10/16, Daniel Vetter wrote: > > > > On Fri, Oct 16, 2020 at 12:38 PM Simon Ser wrote: >

Re: [PATCH 1/3] drm/vkms: Set preferred depth correctly

2020-10-16 Thread Daniel Vetter
On Fri, Oct 16, 2020 at 7:02 PM Melissa Wen wrote: > > On 10/16, Daniel Vetter wrote: > > On Fri, Oct 16, 2020 at 12:38 PM Simon Ser wrote: > > > > > > > The only thing we support is xrgb. > > > > > > > > Signed-off-by: Daniel Vett

Re: [PATCH 1/3] drm/vkms: Set preferred depth correctly

2020-10-16 Thread Daniel Vetter
On Fri, Oct 16, 2020 at 12:38 PM Simon Ser wrote: > > > The only thing we support is xrgb. > > > > Signed-off-by: Daniel Vetter > > Cc: Rodrigo Siqueira > > Cc: Melissa Wen > > Cc: Haneen Mohammed > > Cc: Daniel Vetter > > --- >

Re: [PATCH] drm/drm_vblank: use drm_warn_once() to warn undefined mode timing

2020-10-16 Thread Daniel Vetter
On Fri, Oct 16, 2020 at 10:54 AM Shawn Guo wrote: > > On Fri, Oct 16, 2020 at 09:58:46AM +0200, Daniel Vetter wrote: > > On Fri, Oct 16, 2020 at 9:13 AM Shawn Guo wrote: > > > > > > Commit 5caa0feafcc6 ("drm/vblank: Lock down vblank->hwmode more") ad

Re: [PATCH v2 05/17] mm/frame-vector: Use FOLL_LONGTERM

2020-10-16 Thread Daniel Vetter
On Fri, Oct 16, 2020 at 9:54 AM John Hubbard wrote: > > On 10/9/20 12:59 AM, Daniel Vetter wrote: > ... > > @@ -48,40 +47,25 @@ int get_vaddr_frames(unsigned long start, unsigned int > > nr_frames, > > > > start = untagged_addr(start); > > > > -

Re: [PATCH] drm/drm_vblank: use drm_warn_once() to warn undefined mode timing

2020-10-16 Thread Daniel Vetter
ninitialized > mode.\n", > -pipe); > - drm_WARN_ON_ONCE(dev, drm_drv_uses_atomic_modeset(dev)); > + drm_warn_once(dev, "crtc %u: Noop due to uninitialized > mode.\n", > + pipe); > + &

Re: [PATCH 1/3] drm/vkms: Set preferred depth correctly

2020-10-15 Thread Daniel Vetter
On Mon, Oct 12, 2020 at 09:59:22AM -0300, Melissa Wen wrote: > On 10/10, Daniel Vetter wrote: > > The only thing we support is xrgb. > > > > Signed-off-by: Daniel Vetter > > Cc: Rodrigo Siqueira > > Cc: Melissa Wen > > Cc: Haneen Mohammed > >

Re: [PATCH v4 05/10] drm/ttm: Add vmap/vunmap to TTM and TTM GEM helpers

2020-10-15 Thread Daniel Vetter
invidual page (again using the dma_buf_map stuff). I'll let Christian with the details, but at a high level this is definitely Acked-by: Daniel Vetter Thanks a lot for doing all this. -Daniel > > > > > Signed-off-by: Thomas Zimmermann > > --- >

Re: [PATCH v4 1/5] RDMA/umem: Support importing dma-buf as user memory region

2020-10-15 Thread Daniel Vetter
buf->attach, > + DMA_BIDIRECTIONAL); > + > + if (IS_ERR(sgt)) { > + dma_resv_unlock(umem_dmabuf->attach->dmabuf->resv); > + return PTR_ERR(sgt); > + } > + > + umem_dmabuf->umem.sg_head = *sgt

Re: [PATCH v4 5/5] dma-buf: Clarify that dma-buf sg lists are page aligned

2020-10-15 Thread Daniel Vetter
tachment. The addresses and lengths in > + * the scatter list are PAGE_SIZE aligned. >* >* On failure, returns a negative error value wrapped into a pointer. >* May also return -EINTR when a signal was received while being > -- > 1.8.3.1 > &g

Re: [PATCH 2/3] drm/msm: add DRM_MSM_GEM_SYNC_CACHE for non-coherent cache maintenance

2020-10-15 Thread Daniel Vetter
addresses directly or ignore them if it knows they're > > overridden by its own IOMMU mapping. > > I'd be happy to review patches for this. -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 14/17] resource: Move devmem revoke code to resource framework

2020-10-15 Thread Daniel Vetter
On Thu, Oct 15, 2020 at 2:09 AM Jason Gunthorpe wrote: > > On Fri, Oct 09, 2020 at 11:28:54AM -0700, Dan Williams wrote: > > On Fri, Oct 9, 2020 at 7:32 AM Jason Gunthorpe wrote: > > > > > > On Fri, Oct 09, 2020 at 04:24:45PM +0200, Daniel Vetter wrote: > >

Re: [PATCH v2] drm/of: Consider the state in which the ep is disabled

2020-10-15 Thread Daniel Vetter
int_of_node(port, ep) { > > + if (!of_device_is_available(ep)) > > + continue; > > + > > remote_port = of_graph_get_remote_port(ep); > > if (!remote_port) { > > of_node

Re: [Freedreno] [PATCH v2 22/22] drm/msm: Don't implicit-sync if only a single ring

2020-10-15 Thread Daniel Vetter
On Tue, Oct 13, 2020 at 6:15 PM Rob Clark wrote: > > On Tue, Oct 13, 2020 at 4:08 AM Daniel Vetter wrote: > > > > On Mon, Oct 12, 2020 at 08:07:38AM -0700, Rob Clark wrote: > > > On Mon, Oct 12, 2020 at 7:40 AM Daniel Vetter wrote: > > > > > > >

Re: [PATCH v2 14/17] resource: Move devmem revoke code to resource framework

2020-10-15 Thread Daniel Vetter
On Thu, Oct 15, 2020 at 9:52 AM Daniel Vetter wrote: > > On Thu, Oct 15, 2020 at 2:09 AM Jason Gunthorpe wrote: > > > > On Fri, Oct 09, 2020 at 11:28:54AM -0700, Dan Williams wrote: > > > On Fri, Oct 9, 2020 at 7:32 AM Jason Gunthorpe wrote: > > > > >

Re: [PATCH v2 14/17] resource: Move devmem revoke code to resource framework

2020-10-15 Thread Daniel Vetter
On Thu, Oct 15, 2020 at 2:09 AM Jason Gunthorpe wrote: > > On Fri, Oct 09, 2020 at 11:28:54AM -0700, Dan Williams wrote: > > On Fri, Oct 9, 2020 at 7:32 AM Jason Gunthorpe wrote: > > > > > > On Fri, Oct 09, 2020 at 04:24:45PM +0200, Daniel Vetter wrote: > >

[PATCH] drm/vkms: Switch to shmem helpers

2020-10-13 Thread Daniel Vetter
v2: - Drop now unused container_of #define (Melissa) - Make sure we keep creating cached objects, this is for testing (Thomas) Signed-off-by: Daniel Vetter Cc: Chris Wilson Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc: Rodrigo Sique

Re: [PATCH v2 22/22] drm/msm: Don't implicit-sync if only a single ring

2020-10-13 Thread Daniel Vetter
On Mon, Oct 12, 2020 at 08:07:38AM -0700, Rob Clark wrote: > On Mon, Oct 12, 2020 at 7:40 AM Daniel Vetter wrote: > > > > On Sun, Oct 11, 2020 at 07:09:49PM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > Any cross-devi

Re: [PATCH 3/3] drm/vkms: fbdev emulation support

2020-10-13 Thread Daniel Vetter
On Tue, Oct 13, 2020 at 01:19:38PM +0300, Pekka Paalanen wrote: > On Tue, 13 Oct 2020 09:53:44 +0200 > Daniel Vetter wrote: > > > On Tue, Oct 13, 2020 at 8:14 AM Pekka Paalanen wrote: > > > > > > On Mon, 12 Oct 2020 16:23:35 +0200 > > > Daniel Vetter w

Re: [PATCH 3/3] drm/vkms: fbdev emulation support

2020-10-13 Thread Daniel Vetter
On Tue, Oct 13, 2020 at 8:14 AM Pekka Paalanen wrote: > > On Mon, 12 Oct 2020 16:23:35 +0200 > Daniel Vetter wrote: > > > On Mon, Oct 12, 2020 at 02:40:58PM +0200, Neil Armstrong wrote: > > > Hi, > > > > > ... > > > > It's weird

Re: [PATCH v2 22/22] drm/msm: Don't implicit-sync if only a single ring

2020-10-12 Thread Daniel Vetter
t;fctx, > @@ -768,7 +768,8 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void > *data, > if (ret) > goto out; > > - ret = submit_fence_sync(submit, !!(args->flags & > MSM_SUBMIT_NO_IMPLICIT)); > + ret = submit_fence_sync(submit, (gpu-&

Re: [PATCH v2 07/22] drm/msm: Do rpm get sooner in the submit path

2020-10-12 Thread Daniel Vetter
ww_class); > @@ -825,6 +834,8 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void > *data, > > > out: > + pm_runtime_put(>pdev->dev); > +out_pre_pm: > submit_cleanup(submit); > if (has_ww_ticket) > ww_acquire_fini(>ticket); &g

Re: [PATCH 1/2] drm: Ask whether drm_gem_get_pages() should clear the CPU cache

2020-10-12 Thread Daniel Vetter
; > - xen_obj->pages = drm_gem_get_pages(_obj->base); > + xen_obj->pages = drm_gem_get_pages(_obj->base, false); > if (IS_ERR(xen_obj->pages)) { > ret = PTR_ERR(xen_obj->pages); > xen_obj->pages = NULL; > diff --git a/include/drm/dr

Re: [PATCH 3/3] drm/vkms: fbdev emulation support

2020-10-12 Thread Daniel Vetter
On Mon, Oct 12, 2020 at 02:40:58PM +0200, Neil Armstrong wrote: > Hi, > > On 12/10/2020 13:24, Thomas Zimmermann wrote: > > Hi > > > > On Sat, 10 Oct 2020 01:21:56 +0200 Daniel Vetter > > wrote: > > > >> Hooray for generic fbdev support, ma

Re: [PATCH v2 08/17] s390/pci: Remove races against pte updates

2020-10-12 Thread Daniel Vetter
f you confirm there I can do the fixups when applying or you can resend. > > On 10/9/20 9:59 AM, Daniel Vetter wrote: > > Way back it was a reasonable assumptions that iomem mappings never > > change the pfn range they point at. But this has changed: > > > > - gpu dr

Re: [PATCH 1/4] drm/ttm: set the tt caching state at creation time

2020-10-12 Thread Daniel Vetter
* > > + * Copyright 2020 Advanced Micro Devices, Inc. > > + * > > + * Permission is hereby granted, free of charge, to any person obtaining a > > + * copy of this software and associated documentation files (the > > "Software"), > > + * to deal in the Software without

Re: [Intel-gfx] [PATCH] drm/vgem: Replace vgem_object_funcs with the common drm shmem helper

2020-10-12 Thread Daniel Vetter
On Mon, Oct 12, 2020 at 03:01:09PM +0100, Chris Wilson wrote: > Quoting Daniel Vetter (2020-10-12 14:55:07) > > On Mon, Oct 12, 2020 at 12:49 PM Chris Wilson > > wrote: > > > Quoting Daniel Vetter (2020-10-09 17:16:06) > > > > On Fri, Oct 9, 2020 at 1

Re: [PATCH] drm/ingenic: Fix bad revert

2020-10-12 Thread Daniel Vetter
genic: Add option to mmap GEM buffers > cached"" > Signed-off-by: Paul Cercueil Acked-by: Daniel Vetter And yes if you use git cherry-pick it'll do a 3 way merge, and occasionally it's very tricky to resolve that properly. Especially when you're not used to it. What I tend to d

Re: [Intel-gfx] [PATCH] drm/vgem: Replace vgem_object_funcs with the common drm shmem helper

2020-10-12 Thread Daniel Vetter
On Mon, Oct 12, 2020 at 12:49 PM Chris Wilson wrote: > Quoting Daniel Vetter (2020-10-09 17:16:06) > > On Fri, Oct 9, 2020 at 12:21 PM Chris Wilson > > wrote: > > > > > > vgem is a minimalistic driver that provides shmemfs objects to > > > userspace tha

Re: [PATCH v2 09/17] mm: Add unsafe_follow_pfn

2020-10-12 Thread Daniel Vetter
it might be enough for CMA drivers though (but there's more that's possible here). -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 09/17] mm: Add unsafe_follow_pfn

2020-10-10 Thread Daniel Vetter
On Sat, Oct 10, 2020 at 11:36 PM Laurent Pinchart wrote: > > Hi Tomasz, > > On Sat, Oct 10, 2020 at 07:22:48PM +0200, Tomasz Figa wrote: > > On Fri, Oct 9, 2020 at 7:52 PM Daniel Vetter wrote: > > > On Fri, Oct 9, 2020 at 2:48 PM Jason Gunthorpe wrote: > > >

  1   2   3   4   5   6   7   8   9   10   >