[Intel-gfx] [PATCH 1/1] drm/i915/dsi: silence a warning about uninitialized return value

On 08/09/16 00:02, Nicolas Iooss wrote: > On 07/09/16 18:03, Dave Gordon wrote: >> On 06/09/16 21:36, Nicolas Iooss wrote: >>> On 06/09/16 12:21, Dave Gordon wrote: >>>> On 04/09/16 19:58, Nicolas Iooss wrote: >>>>> When building the kernel with cla

[Intel-gfx] [PATCH 1/1] drm/i915/dsi: silence a warning about uninitialized return value

On 06/09/16 21:36, Nicolas Iooss wrote: > On 06/09/16 12:21, Dave Gordon wrote: >> On 04/09/16 19:58, Nicolas Iooss wrote: >>> When building the kernel with clang and some warning flags, the compiler >>> reports that the return value of dcs_get_backlight

[Intel-gfx] [PATCH 1/1] drm/i915/dsi: silence a warning about uninitialized return value

nbytes == sizeof(data) ? data : 0; } and if complains about that then it doesn't understand that passing allows it to be set. If it doesn't complain about this version, then the original error was actually correct, in the sense that data can indeed be used uninitialised if certain error path

[PATCH v5 1/4] drm: two more (drm_)printk() wrapper macros

as it seems unlikely that they'll be as useful. v2: Fix whitespace, missing ## (Eric Engestrom) v5: Much simplified after underlying functions were reworked. Signed-off-by: Dave Gordon Previously-Reviewed-by: Eric Engestrom (v2) Cc: Eric Engestrom Cc: dri-devel at lists.freedesktop.org

[PATCH v4 1/4] drm: extra printk() wrapper macros

underlying macro that does all the token-pasting. DRM_ERROR is unchanged, as it's not just a printk wrapper. v2: Fix whitespace, missing ## (Eric Engestrom) Signed-off-by: Dave Gordon Reviewed-by: Eric Engestrom Cc: dri-devel at lists.freedesktop.org --- include/drm/drmP.h | 26

[PATCH v4 1/4] drm: extra printk() wrapper macros

underlying macro that does all the token-pasting. DRM_ERROR is unchanged, as it's not just a printk wrapper. v2: Fix whitespace, missing ## (Eric Engestrom) Signed-off-by: Dave Gordon Reviewed-by: Eric Engestrom Cc: dri-devel at lists.freedesktop.org --- include/drm/drmP.h | 26

[PATCH v4 1/4] drm: extra printk() wrapper macros

underlying macro that does all the token-pasting. DRM_ERROR is unchanged, as it's not just a printk wrapper. v2: Fix whitespace, missing ## (Eric Engestrom) Signed-off-by: Dave Gordon Reviewed-by: Eric Engestrom Cc: dri-devel at lists.freedesktop.org --- include/drm/drmP.h | 26

[PATCH v4 1/4] drm: extra printk() wrapper macros

underlying macro that does all the token-pasting. DRM_ERROR is unchanged, as it's not just a printk wrapper. v2: Fix whitespace, missing ## (Eric Engestrom) Signed-off-by: Dave Gordon Reviewed-by: Eric Engestrom Cc: dri-devel at lists.freedesktop.org --- include/drm/drmP.h | 26

[PATCH] drm: avoid "possible bad bitmask?" warning

Recent versions of gcc say this: include/drm/i915_drm.h:96:34: warning: result of ‘65535 << 20’ requires 37 bits to represent, but ‘int’ only has 32 bits [-Wshift-overflow=] Reported-by: David Binderman Signed-off-by: Dave Gordon Cc: Dave Airlie --- include/drm/i915_drm.h | 2

[Intel-gfx] include/drm/i915_drm.h:96: possible bad bitmask ?

On 09/08/16 03:59, Dave Airlie wrote: > On 8 August 2016 at 19:40, Daniel Vetter wrote: >> On Mon, Aug 08, 2016 at 10:31:32AM +0100, David Binderman wrote: >>> Hello there, >>> >>> Recent versions of gcc say this: >>> >>> include/drm/i915_drm.h:96:34: warning: result of ‘65535 << 20’ >>>

[PATCH v4 1/3] drm: extra printk() wrapper macros

underlying macro that does all the token-pasting. DRM_ERROR is unchanged, as it's not just a printk wrapper. v2: Fix whitespace, missing ## (Eric Engestrom) Signed-off-by: Dave Gordon Reviewed-by: Eric Engestrom Cc: dri-devel at lists.freedesktop.org --- include/drm/drmP.h | 26

[PATCH v3 1/3] drm: extra printk() wrapper macros

underlying macro that does all the token-pasting. DRM_ERROR is unchanged, as it's not just a printk wrapper. v2: Fix whitespace, missing ## (Eric Engestrom) Signed-off-by: Dave Gordon Reviewed-by: Eric Engestrom Cc: dri-devel at lists.freedesktop.org --- include/drm/drmP.h | 26

[PATCH v2 3/3] drm/i915/guc: revisit GuC loader message levels

the log with developer-only details. v2: different permutation of levels :) Signed-off-by: Dave Gordon --- drivers/gpu/drm/i915/intel_guc_loader.c | 34 - 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_guc_loader.c b

[PATCH v2 2/3] drm/i915/guc: downgrade some DRM_ERROR() messages to DRM_WARN()

Where we're going to continue regardless of the problem, rather than fail, then the message should be a WARNing rather than an ERROR. Signed-off-by: Dave Gordon --- drivers/gpu/drm/i915/i915_guc_submission.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git

[PATCH v2 1/3] drm: extra printk() wrapper macros

underlying macro that does all the token-pasting. DRM_ERROR is unchanged, as it's not just a printk wrapper. v2: Fix whitespace, missing ## (Eric Engestrom) Signed-off-by: Dave Gordon Reviewed-by: Eric Engestrom --- include/drm/drmP.h | 26 -- 1 file changed, 20

[Intel-gfx] [PATCH 3/3] drm/i915/guc: revisit GuC loader message levels

On 12/07/16 10:26, Tvrtko Ursulin wrote: > > On 11/07/16 19:01, Dave Gordon wrote: >> Some downgraded from DRM_ERROR() to DRM_WARN(), some eliminated, >> and a few upgraded from DRM_INFO() to DRM_NOTE() or DRM_WARN(). >> >> Signed-off-by: Dave Gordon &g

[Intel-gfx] [PATCH 1/3] drm: extra printk() wrapper macros

On 12/07/16 15:25, Daniel Vetter wrote: > On Mon, Jul 11, 2016 at 07:01:27PM +0100, Dave Gordon wrote: >> We had only DRM_INFO() and DRM_ERROR(), whereas the underlying printk() >> provides several other useful intermediate levels such as NOTICE and >> WARNING. So this pa

[Intel-gfx] [PATCH 1/3] drm: extra printk() wrapper macros

On 12/07/16 10:06, Tvrtko Ursulin wrote: > > On 11/07/16 19:01, Dave Gordon wrote: >> We had only DRM_INFO() and DRM_ERROR(), whereas the underlying printk() >> provides several other useful intermediate levels such as NOTICE and >> WARNING. So this patch fills out t

[PATCH 3/3] drm/i915/guc: revisit GuC loader message levels

Some downgraded from DRM_ERROR() to DRM_WARN(), some eliminated, and a few upgraded from DRM_INFO() to DRM_NOTE() or DRM_WARN(). Signed-off-by: Dave Gordon --- drivers/gpu/drm/i915/intel_guc_loader.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git

[PATCH 2/3] drm/i915/guc: downgrade some DRM_ERROR() messages to DRM_WARN()

Where we're going to continue regardless of the problem, rather than fail, then the message should be a WARNing rather than an ERROR. Signed-off-by: Dave Gordon --- drivers/gpu/drm/i915/i915_guc_submission.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git

[PATCH 1/3] drm: extra printk() wrapper macros

underlying macro that does all the token-pasting. DRM_ERROR is unchanged, as it's not just a printk wrapper. Signed-off-by: Dave Gordon --- include/drm/drmP.h | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/include/drm/drmP.h b/include/drm/drmP.h index

[PATCH v7 7/7] drm: add parameter-order checking to drm memory allocators

-recursively!) from inside the #define [Chris Wilson] Signed-off-by: Dave Gordon Cc: Chris Wilson Cc: Ville Syrjälä Cc: dri- Cc: dri-devel at lists.freedesktop.org --- drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 2 +- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 8 include/drm

[PATCH v7 3/7] drm,i915: introduce drm_malloc_gfp()

Signed-off-by: Chris Wilson Cc: dri-devel at lists.freedesktop.org Cc: Ville Syrjälä Reviewed-by: Ville Syrjälä Acked-by: Dave Airlie Signed-off-by: Dave Gordon --- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 8 +++- drivers/gpu/drm/i915/i915_gem_gtt.c| 5 +++-- drivers/gpu/dr

[PATCH v6 2/7] drm: add parameter-order checking to drm memory allocators

-recursively!) from inside the #define [Chris Wilson] Signed-off-by: Dave Gordon Cc: Chris Wilson Cc: Ville Syrjälä Cc: dri- Cc: dri-devel at lists.freedesktop.org --- drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 2 +- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 8 include/drm

[PATCH v6 1/7] drm,i915: introduce drm_malloc_gfp()

Signed-off-by: Chris Wilson Cc: dri-devel at lists.freedesktop.org Cc: Ville Syrjälä Reviewed-by: Ville Syrjälä Acked-by: Dave Airlie Signed-off-by: Dave Gordon --- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 8 +++- drivers/gpu/drm/i915/i915_gem_gtt.c| 5 +++-- drivers/gpu/dr

[PATCH v5 2/7] drm: add parameter-order checking to drm memory allocators

(size) parameter isn't a sizeof() expression, or at least a compile-time constant. This patch also fixes those callers where the order was wrong. Signed-off-by: Dave Gordon Cc: Chris Wilson Cc: Ville Syrjälä Cc: dri- Cc: dri-devel at lists.freedesktop.org --- drivers/gpu/drm/etnaviv

[PATCH v5 1/7] drm,i915: introduce drm_malloc_gfp()

Signed-off-by: Chris Wilson Cc: dri-devel at lists.freedesktop.org Cc: Ville Syrjälä Reviewed-by: Ville Syrjälä Acked-by: Dave Airlie Signed-off-by: Dave Gordon --- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 8 +++- drivers/gpu/drm/i915/i915_gem_gtt.c| 5 +++-- drivers/gpu/dr

[Intel-gfx] [PATCH] drm: Documentation style guide

On 14/12/15 15:39, Thierry Reding wrote: > On Wed, Dec 09, 2015 at 05:08:02PM +0100, Daniel Vetter wrote: >> Every time I type or review docs this seems a bit different. Try to >> document the common style so we can try to unify at least new docs. >> >> v2: Spelling fixes from Pierre, Laurent and

[PATCH 2/2] drm/i915: Soften error messages in i915_gem_object_create_from_data()

On 28/07/15 17:34, Chris Wilson wrote: > On Tue, Jul 28, 2015 at 05:29:09PM +0100, Dave Gordon wrote: >> On 28/07/15 14:27, Chris Wilson wrote: >>> Since we already return -EFAULT to the user, emitting an error message >>> *and* WARN is overkill. If the call

[PATCH 2/2] drm/i915: Soften error messages in i915_gem_object_create_from_data()

on > Cc:: Alex Dai > Cc: Dave Gordon > Cc: Tom O'Rourke <Tom.O'Rourke at intel.com> > --- > drivers/gpu/drm/i915/i915_gem.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_ge

[Intel-gfx] [PATCH] drm: Avoid the double clflush on the last cache line in drm_clflush_virt_range()

On 10/06/15 15:58, Chris Wilson wrote: > As the clflush operates on cache lines, and we can flush any byte > address, in order to flush all bytes given in the range we issue an > extra clflush on the last byte to ensure the last cacheline is flushed. > We can can the iteration to be over the

[Intel-gfx] intel_check_page_flip() - WARN_ON(!in_interrupt())

On 29/05/15 07:26, Jani Nikula wrote: > On Fri, 29 May 2015, Shuah Khan wrote: >> I am seeing the following in the dmesg on 4.0.4 with rt patch >> >> [5.720319] [ cut here ] >> [5.720347] WARNING: CPU: 6 PID: 466 at >> drivers/gpu/drm/i915/intel_display.c:9748 >>

[Intel-gfx] [PATCH 1/5] drm: Kernel Crash in drm_unlock

On 28/04/15 10:21, Dave Gordon wrote: > On 24/04/15 06:52, Antoine, Peter wrote: >> I picked up this work due to the following Jira ticket created by the >> security team (on Android) and was asked to give it a second look and >> found a few more issues with the hw lock code.

[Intel-gfx] [PATCH 1/5] drm: Kernel Crash in drm_unlock

On 24/04/15 06:52, Antoine, Peter wrote: > I picked up this work due to the following Jira ticket created by the > security team (on Android) and was asked to give it a second look and > found a few more issues with the hw lock code. > > https://jira01.devtools.intel.com/browse/GMINL-5388 > I/O

[Intel-gfx] [KERNEL] Regression bug in drm/i915, Wrong assumption in commit e11aa36 breaks suspend on at least lenovo x61

On 19/02/15 11:08, Deak, Imre wrote: > On Thu, 2015-02-19 at 10:47 +0000, Dave Gordon wrote: >> On 18/02/15 16:24, Imre Deak wrote: >>> On ke, 2015-02-18 at 17:39 +0200, Jani Nikula wrote: >>>> On Tue, 17 Feb 2015, Klaus Ethgen <Klaus+lkml at ethgen.de> wrote: &

[Intel-gfx] [PATCH 3/4] drm/i915: Flatten DRIVER_MODESET checks in i915_irq.c

On 12/02/15 22:38, Imre Deak wrote: > On Tue, 2015-02-03 at 11:30 +0100, Daniel Vetter wrote: >> UMS is no more! >> >> Signed-off-by: Daniel Vetter Some machines now won't boot in "recovery mode", which specifies "nomodeset" and therefore results in various important bits of code not being

[Intel-gfx] [KERNEL] Regression bug in drm/i915, Wrong assumption in commit e11aa36 breaks suspend on at least lenovo x61

On 18/02/15 16:24, Imre Deak wrote: > On ke, 2015-02-18 at 17:39 +0200, Jani Nikula wrote: >> On Tue, 17 Feb 2015, Klaus Ethgen wrote: >>> After solving the conflicts, I applied the revert (see attachment) to >>> v3.18.7. I think it should also apply to the current head.