Re: [PATCH 55/86] drm/hyperv_drm: Run DRM default client setup

2024-08-16 Thread Deepak Rawat
Reviewed-by: Deepak Rawat On Fri, Aug 16, 2024 at 5:54 AM Thomas Zimmermann wrote: > > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > >

Re: [PATCH 11/43] drm/hyperv: Use fbdev-shmem

2024-03-12 Thread Deepak Rawat
Reviewed-by: Deepak Rawat On Tue, Mar 12, 2024 at 8:48 AM Thomas Zimmermann wrote: > > Implement fbdev emulation with fbdev-shmem. Avoids the overhead of > fbdev-generic's additional shadow buffering. No functional changes. > > Signed-off-by: Thomas Zimmermann

Re: [PATCH] drm/hyperv : Removing the restruction of VRAM allocation with PCI bar size

2022-05-20 Thread Deepak Rawat
pdev->dev, hv->fb_base, hv->fb_size); > - if (!hv->vram) { > - drm_err(dev, "Failed to map vram\n"); > - ret = -ENOMEM; > - } > - > -error: > - pci_dev_put(pdev); > - return ret; > -} > - > -st

Re: [PATCH 4/4] drm/hyperv: Remove support for Hyper-V 2008 and 2008R2/Win7

2022-05-03 Thread Deepak Rawat
ight_max = SYNTHVID_HEIGHT_WIN8; > } > > hv->mmio_megabytes = hdev->channel->offermsg.offer.mmio_megabytes; Do we need a new version for Windows 11? If the synthetic device version is decoupled from Windows version, then I guess we can rename the macro to reflect that. Reviewed-by: Deepak Rawat > -- > 1.8.3.1 >

Re: [PATCH v2] drm/hyperv: Added error message for fb size greater then allocated

2022-04-07 Thread Deepak Rawat
On Wed, Apr 6, 2022 at 11:27 PM Saurabh Sengar wrote: > > Added error message when the size of requested framebuffer is more then > the allocated size by vmbus mmio region for framebuffer > > Signed-off-by: Saurabh Sengar > --- > v1 -> v2 : Corrected Sign-off > > drivers/gpu/drm/hyperv/hyperv_dr

Re: [PATCH v2 24/37] drm/hyperv: Add support for the nomodeset kernel parameter

2021-12-20 Thread Deepak Rawat
> and only the system framebuffer will be available if it was set-up. > > But only a few DRM drivers currently check for nomodeset, make this driver > to also support the command line parameter. > > Signed-off-by: Javier Martinez Canillas > --- Acked-by: Deepak Rawat > >

Re: [PATCH] drm/hyperv: Fix device removal on Gen1 VMs

2021-11-19 Thread Deepak Rawat
Thanks for the patch. Reviewed-by: Deepak Rawat I will push this to drm-fixes, let me know otherwise. Deepak On Fri, 2021-11-19 at 12:29 +0100, Mohammed Gamal wrote: > The Hyper-V DRM driver tries to free MMIO region on removing > the device regardless of VM type, while Gen1 VMs don

Re: [PATCH] drm/hyperv: Fix double mouse pointers

2021-09-16 Thread Deepak Rawat
HI Dexuan, thanks for confirming. Could you please add this as a comment to the function. Reviewed-by: Deepak Rawat On Tue, Sep 14, 2021 at 11:59 PM Dexuan Cui wrote: > > > From: Deepak Rawat > > Sent: Tuesday, September 14, 2021 8:59 AM > > ... > > > +/* S

Re: [PATCH] drm/hyperv: Fix double mouse pointers

2021-09-14 Thread Deepak Rawat
into hyperv_drm. > > Fixes: 76c56a5affeb ("drm/hyperv: Add DRM driver for hyperv synthetic video > device") > Signed-off-by: Dexuan Cui > Cc: Deepak Rawat > Cc: Haiyang Zhang > --- > drivers/gpu/drm/hyperv/hyperv_drm.h | 1 + > drivers/gpu/drm/hyperv/hyperv_d

Re: [PATCH -next] drm/hyperv: Remove unused variable

2021-06-14 Thread Deepak Rawat
On Wed, 2021-06-09 at 09:46 +0200, Thomas Zimmermann wrote: > Hi > > Am 09.06.21 um 04:49 schrieb Pu Lehui: > > Fixes gcc '-Wunused-const-variable' warning: > >    drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:152:23: warning: > > 'hyperv_modifiers' defined but not used [-Wunused-const- > > var

Re: [PATCH v6 1/3] drm/hyperv: Add DRM driver for hyperv synthetic video device

2021-06-07 Thread Deepak Rawat
On Thu, 2021-05-27 at 15:35 +0200, Thomas Zimmermann wrote: > Hi > > if no further comments come in, this can be moved in a few days. > Since > you'll be the maintainer, you should request commit access to the > drm-misc repository. See > >   > https://drm.pages.freedesktop.org/maintainer-to

[PATCH v6 2/3] drm/hyperv: Handle feature change message from device

2021-05-27 Thread Deepak Rawat
Virtual device inform if screen update is needed or not with SYNTHVID_FEATURE_CHANGE message. Handle this message to set dirt_needed flag. Suggested-by: Dexuan Cui Signed-off-by: Deepak Rawat Acked-by: Thomas Zimmermann --- drivers/gpu/drm/hyperv/hyperv_drm.h | 1 + drivers/gpu/drm

[PATCH v6 3/3] MAINTAINERS: Add maintainer for hyperv video device

2021-05-27 Thread Deepak Rawat
Maintainer for hyperv synthetic video device. Signed-off-by: Deepak Rawat --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 315120c4124d..a4fdde4bb250 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6084,6 +6084,14 @@ T: git git

[PATCH v6 1/3] drm/hyperv: Add DRM driver for hyperv synthetic video device

2021-05-27 Thread Deepak Rawat
de/comment improvement as suggested by Dexuan Cui Signed-off-by: Deepak Rawat Acked-by: Thomas Zimmermann --- drivers/gpu/drm/Kconfig | 13 + drivers/gpu/drm/Makefile| 1 + drivers/gpu/drm/hyperv/Makefile | 8 + drivers/gpu/drm/hyperv/hy

Re: [PATCH v5 1/3] drm/hyperv: Add DRM driver for hyperv synthetic video device

2021-05-27 Thread Deepak Rawat
On Wed, 2021-05-26 at 21:42 +0200, Thomas Zimmermann wrote: > Hi > > Am 20.05.21 um 07:41 schrieb Dexuan Cui: > > > From: Deepak Rawat > > > Sent: Wednesday, May 19, 2021 9:38 AM > > > ... > > > +static int hyperv_vmbus_suspend(struct hv_device *h

[PATCH v5 3/3] MAINTAINERS: Add maintainer for hyperv video device

2021-05-19 Thread Deepak Rawat
Maintainer for hyperv synthetic video device. Signed-off-by: Deepak Rawat --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 41f2b2b85b6d..dbe4ed540e11 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6084,6 +6084,14 @@ T: git git

[PATCH v5 2/3] drm/hyperv: Handle feature change message from device

2021-05-19 Thread Deepak Rawat
Virtual device inform if screen update is needed or not with SYNTHVID_FEATURE_CHANGE message. Handle this message to set dirt_needed flag. Suggested-by: Dexuan Cui Signed-off-by: Deepak Rawat Acked-by: Thomas Zimmermann --- drivers/gpu/drm/hyperv/hyperv_drm.h | 1 + drivers/gpu/drm

[PATCH v5 1/3] drm/hyperv: Add DRM driver for hyperv synthetic video device

2021-05-19 Thread Deepak Rawat
n issue as suggested by Dexuan Cui - Use ioremap_cache as suggested by Dexuan Cui - Incorporated other review comments v4: - Fix bitrotted code - Review comments - Updated the copyright and license to match hyperv_fb v5: - Address review comments and rebased with drm-misc-next Signed-off-by: De

Re: [PATCH v4 1/3] drm/hyperv: Add DRM driver for hyperv synthetic video device

2021-05-18 Thread Deepak Rawat
> > + > > +static struct pci_driver hyperv_pci_driver = { > > +   .name = KBUILD_MODNAME, > > +   .id_table = hyperv_pci_tbl, > > +   .probe =hyperv_pci_probe, > > +   .remove =   hyperv_pci_remove, > > +}; > > The PCI code doesn't do anything. Do you need t

Re: [PATCH v4 3/3] MAINTAINERS: Add maintainer for hyperv video device

2021-05-17 Thread Deepak Rawat
On Mon, 2021-05-17 at 17:25 +, Wei Liu wrote: > On Mon, May 17, 2021 at 04:59:22AM -0700, Deepak Rawat wrote: > > Maintainer for hyperv synthetic video device. > > > > Signed-off-by: Deepak Rawat > > --- > >  MAINTAINERS | 16 &

Re: [PATCH v4 3/3] MAINTAINERS: Add maintainer for hyperv video device

2021-05-17 Thread Deepak Rawat
Sorry messed this patch during rebase. Will send this one again after fixing this. On Mon, May 17, 2021 at 4:59 AM Deepak Rawat wrote: > Maintainer for hyperv synthetic video device. > > Signed-off-by: Deepak Rawat > --- > MAINTAINERS | 16 > 1 file chan

[PATCH v4 3/3] MAINTAINERS: Add maintainer for hyperv video device

2021-05-17 Thread Deepak Rawat
Maintainer for hyperv synthetic video device. Signed-off-by: Deepak Rawat --- MAINTAINERS | 16 1 file changed, 16 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index bd7aff0c120f..261342551406 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6077,6 +6077,14 @@ T

[PATCH v4 2/3] drm/hyperv: Handle feature change message from device

2021-05-17 Thread Deepak Rawat
Virtual device inform if screen update is needed or not with SYNTHVID_FEATURE_CHANGE message. Handle this message to set dirt_needed flag. Suggested-by: Dexuan Cui Signed-off-by: Deepak Rawat --- drivers/gpu/drm/hyperv/hyperv_drm.h | 1 + drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 2

[PATCH v4 1/3] drm/hyperv: Add DRM driver for hyperv synthetic video device

2021-05-17 Thread Deepak Rawat
n issue as suggested by Dexuan Cui - Use ioremap_cache as suggested by Dexuan Cui - Incorporated other review comments v4: - Fix bitrotted code - Review comments - Updated the copyright and license to match hyperv_fb Signed-off-by: Deepak Rawat --- drivers/gpu/drm/Kconfig

Re: [PATCH v3 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2021-02-17 Thread Deepak Rawat
On Wed, 2021-02-17 at 13:22 +, Simon Ser wrote: > On Tuesday, February 16th, 2021 at 1:39 AM, Deepak Rawat < > drawat.fl...@gmail.com> wrote: > > > +static int hyperv_conn_init(struct hyperv_drm_device *hv) > > +{ > > +   drm_co

Re: [PATCH v3 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2021-02-17 Thread Deepak Rawat
On Wed, 2021-02-17 at 13:07 +0100, Vitaly Kuznetsov wrote: > Deepak Rawat writes: > > > DRM driver for hyperv synthetic video device, based on hyperv_fb > > framebuffer driver. Also added config option "DRM_HYPERV" to > > enabled > > this driver. &g

Re: [PATCH v3 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2021-02-17 Thread Deepak Rawat
On Tue, 2021-02-16 at 09:21 +0100, Thomas Zimmermann wrote: > Hi, > > fantastic. Thanks for sending an update. There's been a some bitrot > meanwhile. Review below. Thanks Thomas for the review. Will update as per review in next iteration. > > Am 16.02.21 um 01:

[PATCH v3 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2021-02-15 Thread Deepak Rawat
n issue as suggested by Dexuan Cui - Use ioremap_cache as suggested by Dexuan Cui - Incorporated other review comments Signed-off-by: Deepak Rawat --- drivers/gpu/drm/Kconfig | 12 + drivers/gpu/drm/Makefile| 1 + drivers/gpu/drm/hyperv/Makefile

[PATCH v3 2/2] MAINTAINERS: Add maintainer for hyperv video device

2021-02-15 Thread Deepak Rawat
Maintainer for hyperv synthetic video device. Signed-off-by: Deepak Rawat --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index d6dd31cb5ad1..b4aaf1810c7c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6057,6 +6057,14 @@ T: git git

Re: [PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2021-01-05 Thread Deepak Rawat
On Tue, 2021-01-05 at 12:30 +0100, Thomas Zimmermann wrote: > Hi > > Am 05.01.21 um 12:04 schrieb Gerd Hoffmann: > >    Hi, > > > > > > It's not possible to do page flip with this virtual device. The > > > > call to > > > > SYNTHVID_VRAM_LOCATION is only honoured once. So unfortunately > > > > ne

Re: [PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2021-01-04 Thread Deepak Rawat
On Mon, 2021-01-04 at 14:03 +0100, Thomas Zimmermann wrote: > Hi, > > I've been looking forward to this patchset. :) The code is really > nice > already. Thanks Thomas for the review. > >   > > +config DRM_HYPERV > > +   tristate "DRM Support for hyperv synthetic video device" > > +  

[PATCH 2/2] MAINTAINERS: Add maintainer for hyperv video device

2021-01-01 Thread Deepak Rawat
Maintainer for hyperv synthetic video device. Signed-off-by: Deepak Rawat --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7b073c41c3a0..e483fd32a684 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5515,6 +5515,14 @@ T: git git

[PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2021-01-01 Thread Deepak Rawat
DRM driver for hyperv synthetic video device, based on hyperv_fb framebuffer driver. Also added config option "DRM_HYPERV" to enabled this driver. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/tiny/Kconfig | 12 + drivers/gpu/drm/tiny/Makefile |1 + drivers/gp

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-11-16 Thread Deepak Rawat
> > > > > > Hi Thomas, > > > > > > I am working on adding gen2 VM support and cursor support. Also > > > for my > > > next interation moving the driver out of tiny. Progress is slow > > > lately > > > as busy with other stuff at work. Hopefully I will be able to > > > finish > > > during coming

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-11-15 Thread Deepak Rawat
On Sun, 2020-11-15 at 10:14 +0100, Thomas Zimmermann wrote: > Hi Deepak > > Am 11.09.20 um 02:38 schrieb Deepak Rawat: > > On Thu, 2020-09-10 at 08:19 +, Tang, Shaofeng wrote: > > > Hi Deepak, > > >   > > > Do you have a new version of this patch now?

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-09-10 Thread Deepak Rawat
ng, It seems you are running this with gen 2 VM, I have a patch to support gen 2 VM's at https://github.com/deepak-rawat/linux.git branch hyperv_t iny. If you still run into error after applying gen2 patch, feel free to reach out with details. Deepak > > BR, Shaofeng ___

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-06-24 Thread Deepak Rawat
> > > Thanks for the review. Unfortunately only the first vmbus message > > > take > > > effect and subsequent calls are ignored. I originally implemented > > > using > > > vram helpers but I figured out calling this vmbus message again > > > won't > > > change the vram location. > > /me notices

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-06-23 Thread Deepak Rawat
On Tue, 2020-06-23 at 09:59 +0200, Thomas Zimmermann wrote: > Hi Deepak > > I did not receive you pat series, so I can only comment on Sam's > reply. > See below for some points. Hi Thomas, Thanks for the review. I wanted to add you in cc list but messed it up with final git send-email. Sorry abo

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-06-22 Thread Deepak Rawat
On Tue, 2020-06-23 at 02:31 +, Dexuan Cui wrote: > > From: linux-hyperv-ow...@vger.kernel.org > > On Behalf Of Deepak Rawat > > Sent: Monday, June 22, 2020 4:06 AM > > > > DRM driver for hyperv synthetic video device, based on hyperv_fb > > framebuf

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-06-22 Thread Deepak Rawat
> > Just a buch of drive-by comments while browsing the code. > In general code looks good, especialyl for a v1. > > There is a few places that triggers warnings with checkpatch --strict > Most looks like things that should be fixed. > > Thanks Sam for the review. Will take care of the sugge

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-06-22 Thread Deepak Rawat
On Mon, 2020-06-22 at 14:46 +0200, Gerd Hoffmann wrote: > Hi, > > > +/* Should be done only once during init and resume */ > > +static int synthvid_update_vram_location(struct hv_device *hdev, > > + phys_addr_t vram_pp) > > +{ > > + struct hyperv_device *hv

[RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-06-22 Thread Deepak Rawat
DRM driver for hyperv synthetic video device, based on hyperv_fb framebuffer driver. Also added config option "DRM_HYPERV" to enabled this driver. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/tiny/Kconfig |9 + drivers/gpu/drm/tiny/Makefile |1 + drivers/gp

[RFC PATCH 2/2] MAINTAINERS: Add maintainer for hyperv video device

2020-06-22 Thread Deepak Rawat
Maintainer for hyperv synthetic video device. Signed-off-by: Deepak Rawat --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index f437f42b73ad..102f734b99bd 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5316,6 +5316,14 @@ T: git git

[RFC PATCH 0/2] DRM driver for hyper-v synthetic video device

2020-06-22 Thread Deepak Rawat
testing, ran GNOME and Weston with current changes in a Linux VM on Windows 10 with hyper-v enabled. Thanks, Deepak Deepak Rawat (2): drm/hyperv: Add DRM driver for hyperv synthetic video device MAINTAINERS: Add maintainer for hyperv video device MAINTAINERS |8

[GIT PULL] drm/vmwgfx: vmwgfx-next

2019-04-23 Thread Deepak Rawat
d variable 'fb_offset, fb_depth' (2019-04-08 10:29:05 -0700) Chengguang Xu (1): drm/vmwgfx: remove redundant unlikely annotation Deepak Rawat (8): drm/vmwgfx: Use preprocessor macro to get valid context node

[PATCH] drm: Put damage blob when destroy plane state

2018-12-21 Thread Deepak Rawat
Somehow the code to put the damage blob on destroy plane state and set the blob to NULL when duplicate plane state was not merged. May be because the files are refactored since the patch was written. With this fix add those. Cc: Daniel Vetter Signed-off-by: Deepak Rawat --- drivers/gpu/drm

[PATCH v2 2/2] drm/selftest: Add drm damage helper selftest

2018-10-16 Thread Deepak Rawat
Selftest for drm damage helper iterator functions. Cc: Daniel Vetter Cc: alexandru-cosmin.gheor...@arm.com Signed-off-by: Deepak Rawat Reviewed-by: Daniel Vetter Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/selftests/Makefile| 3 +- .../selftests

[PATCH v2 1/2] drm/selftest: Refactor drm mode setting selftests

2018-10-16 Thread Deepak Rawat
With this patch split the kernel module specific code from actual selftest code. This is done to allow adding more selftests as separate file. Also added kernel module exit stub with this patch. Cc: Daniel Vetter Cc: alexandru-cosmin.gheor...@arm.com Signed-off-by: Deepak Rawat Reviewed-by

[PATCH v3 08/18] drm/vmwgfx: Implement STDU plane update for BO backed fb

2018-10-10 Thread Deepak Rawat
Using the new interface implement STDU plane update for BO backed fb. v2: Rebase to new resource validation. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 11 ++ drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 212 +++ 2 files changed, 223 insertions

[PATCH v3 12/18] drm/vmwgfx: Implement SOU plane update for surface backed fb

2018-10-10 Thread Deepak Rawat
Using the new interface implement SOU plane update for surface backed fb. v2: Rebase to new resource validation. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 11 ++ drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 161 +++ 2 files changed, 172

[PATCH v3 16/18] drm/vmwgfx: Enable FB_DAMAGE_CLIPS property for SOU primary plane

2018-10-10 Thread Deepak Rawat
SOU primary plane now support damage clips, enable it for user-space. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c index 14bcd4db4f9c

[PATCH v3 14/18] drm/vmwgfx: Use the new interface for SOU plane update

2018-10-10 Thread Deepak Rawat
With new interface to do plane update on SOU available, use that instead of old kms_dirty. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c b/drivers

[PATCH v3 17/18] drm/vmwgfx: Use atomic helper function for dirty fb IOCTL

2018-10-10 Thread Deepak Rawat
USe new atomic helper for dirty fb IOCTL which make use of damage interface. Note that this is only done for STDU and SOU, for legacy display unit still using old interface. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 82 +++-- 1 file changed

[PATCH v3 15/18] drm/vmwgfx: Update comments for sou plane update function

2018-10-10 Thread Deepak Rawat
Update comments to sync with code. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c index 1cef622a779e

[PATCH v3 04/18] drm/selftest: Add drm damage helper selftest

2018-10-10 Thread Deepak Rawat
Selftest for drm damage helper iterator functions. Cc: ville.syrj...@linux.intel.com Cc: Daniel Vetter Cc: Pekka Paalanen Cc: Daniel Stone Cc: intel-...@lists.freedesktop.org Cc: igt-...@lists.freedesktop.org Cc: petri.latv...@intel.com Cc: ch...@chris-wilson.co.uk Signed-off-by: Deepak Rawat

[PATCH v3 18/18] drm/vmwgfx: Don't clear mode::type anymore

2018-10-10 Thread Deepak Rawat
With kernel commit 4f09c77b5c3b7, no need to clear mode::type for user-space bug. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 22 -- drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 3 --- drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 2 +- drivers/gpu/drm/vmwgfx

[PATCH v3 03/18] drm: Add helper iterator functions for plane fb_damage_clips blob

2018-10-10 Thread Deepak Rawat
plane update case in iter_next Cc: ville.syrj...@linux.intel.com Cc: Daniel Vetter Cc: Pekka Paalanen Cc: Daniel Stone Signed-off-by: Deepak Rawat --- drivers/gpu/drm/drm_damage_helper.c | 91 + include/drm/drm_damage_helper.h | 54 + include/drm

[PATCH v3 06/18] drm/vmwgfx: Add a new interface for plane update on a display unit

2018-10-10 Thread Deepak Rawat
Add a new struct vmw_du_update_plane similar to vmw_kms_dirty which represent the flow of operations needed to update a display unit from surface or bo (blit a new framebuffer). v2: - Kernel doc correction. - Rebase. v3: Rebase to new resource validation. Signed-off-by: Deepak Rawat

[PATCH v3 13/18] drm/vmwgfx: Implement SOU plane update for BO backed fb

2018-10-10 Thread Deepak Rawat
Using the new interface implement SOU plane update for BO backed fb. v2: Rebase to new resource validation. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 101 +++ 1 file changed, 101 insertions(+) diff --git a/drivers/gpu/drm/vmwgfx

[PATCH v3 07/18] drm/vmwgfx: Implement STDU plane update for surface backed fb

2018-10-10 Thread Deepak Rawat
Using the new interface implement STDU plane update for surface backed fb. v2: Rebase to new resource validation. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 182 ++- 1 file changed, 181 insertions(+), 1 deletion(-) diff --git a/drivers/gpu

[PATCH v3 11/18] drm/vmwgfx: Enable FB_DAMAGE_CLIPS property for STDU primary plane

2018-10-10 Thread Deepak Rawat
STDU primary plane now support damage clips, enable it for user-space. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c b/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c index 1821c4be0ef4

[PATCH v3 02/18] drm: Add a new helper to validate damage during atomic_check

2018-10-10 Thread Deepak Rawat
Cc: Pekka Paalanen Cc: Daniel Stone Signed-off-by: Deepak Rawat --- drivers/gpu/drm/drm_atomic_helper.c | 3 +++ drivers/gpu/drm/drm_damage_helper.c | 38 + include/drm/drm_damage_helper.h | 2 ++ 3 files changed, 43 insertions(+) diff --git a/drivers/gpu/drm

[PATCH v3 10/18] drm/vmwgfx: Updated comment for stdu plane update

2018-10-10 Thread Deepak Rawat
Update the commet to sync with code. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c b/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c index 64d11af2b81b

[PATCH v3 01/18] drm: Add a new plane property to send damage during plane update

2018-10-10 Thread Deepak Rawat
ges. Cc: ville.syrj...@linux.intel.com Cc: Daniel Vetter Cc: Pekka Paalanen Cc: Daniel Stone Signed-off-by: Lukasz Spintzyk Signed-off-by: Deepak Rawat --- Documentation/gpu/drm-kms.rst | 12 + drivers/gpu/drm/Makefile| 3 +- drivers/gpu/drm/drm_atomic.c| 22 +

[PATCH v3 05/18] drm: Add helper to implement legacy dirtyfb

2018-10-10 Thread Deepak Rawat
state::dirty flag. v3: - Use uapi drm_mode_rect. - Support annotate flags. v4: Correct kernel doc. Cc: ville.syrj...@linux.intel.com Cc: Daniel Vetter Cc: Pekka Paalanen Cc: Daniel Stone Signed-off-by: Rob Clark Signed-off-by: Deepak Rawat --- drivers/gpu/drm/drm_damage_helper.c

[PATCH v3 09/18] drm/vmwgfx: Use the new interface for STDU plane update

2018-10-10 Thread Deepak Rawat
With new interface to do plane update on STDU available, use that instead of old kms_dirty. v2: Use fence from new resource validation. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 54 +++- 1 file changed, 20 insertions(+), 34 deletions

[PATCH 18/18] drm/vmwgfx: Don't clear mode::type anymore

2018-09-27 Thread Deepak Rawat
With kernel commit 4f09c77b5c3b7, no need to clear mode::type for user-space bug. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 22 -- drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 3 --- drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 2 +- drivers/gpu/drm/vmwgfx

[PATCH 15/18] drm/vmwgfx: Update comments for sou plane update function

2018-09-27 Thread Deepak Rawat
Update comments to sync with code. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c index 8d8d61d6078f

[PATCH 13/18] drm/vmwgfx: Implement SOU plane update for BO backed fb

2018-09-27 Thread Deepak Rawat
Using the new interface implement SOU plane update for BO backed fb. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 132 +++ 1 file changed, 132 insertions(+) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c b/drivers/gpu/drm/vmwgfx

[PATCH 05/18] drm: Add helper to implement legacy dirtyfb

2018-09-27 Thread Deepak Rawat
state::dirty flag. v3: - Use uapi drm_mode_rect. - Support annotate flags. Cc: ville.syrj...@linux.intel.com Cc: Daniel Vetter Cc: Pekka Paalanen Signed-off-by: Rob Clark Signed-off-by: Deepak Rawat --- drivers/gpu/drm/drm_damage_helper.c | 121 includ

[PATCH 06/18] drm/vmwgfx: Add a new interface for plane update on a display unit

2018-09-27 Thread Deepak Rawat
Add a new struct vmw_du_update_plane similar to vmw_kms_dirty which represent the flow of operations needed to update a display unit from surface or bo (blit a new framebuffer). v2: - Kernel doc correction. - Rebase. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 99

[PATCH 17/18] drm/vmwgfx: Use atomic helper function for dirty fb IOCTL

2018-09-27 Thread Deepak Rawat
USe new atomic helper for dirty fb IOCTL which make use of damage interface. Note that this is only done for STDU and SOU, for legacy display unit still using old interface. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 82 +++-- 1 file changed

[PATCH 04/18] drm/selftest: Add drm damage helper selftest

2018-09-27 Thread Deepak Rawat
Selftest for drm damage helper iterator functions. Cc: ville.syrj...@linux.intel.com Cc: Daniel Vetter Cc: Pekka Paalanen Signed-off-by: Deepak Rawat --- drivers/gpu/drm/selftests/Makefile| 3 +- .../selftests/drm_damage_helper_selftests.h | 22 + .../drm/selftests/test

[PATCH 16/18] drm/vmwgfx: Enable FB_DAMAGE_CLIPS property for SOU primary plane

2018-09-27 Thread Deepak Rawat
SOU primary plane now support damage clips, enable it for user-space. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c index 9c3225e6bc1b

[PATCH 12/18] drm/vmwgfx: Implement SOU plane update for surface backed fb

2018-09-27 Thread Deepak Rawat
Using the new interface implement SOU plane update for surface backed fb. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 3 + drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 185 +++ 2 files changed, 188 insertions(+) diff --git a/drivers/gpu/drm/vmwgfx

[PATCH 09/18] drm/vmwgfx: Use the new interface for STDU plane update

2018-09-27 Thread Deepak Rawat
With new interface to do plane update on STDU available, use that instead of old kms_dirty. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c b/drivers

[PATCH 07/18] drm/vmwgfx: Implement STDU plane update for surface backed fb

2018-09-27 Thread Deepak Rawat
Using the new interface implement STDU plane update for surface backed fb. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 10 ++ drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 207 ++- 2 files changed, 216 insertions(+), 1 deletion(-) diff --git a

[PATCH 02/18] drm: Add a new helper to validate damage during atomic_check

2018-09-27 Thread Deepak Rawat
was clear damage. IMO the new name check_plane_damage() make more sense as this function really will be validating if need to discard damage. Cc: ville.syrj...@linux.intel.com Cc: Daniel Vetter Cc: Pekka Paalanen Signed-off-by: Deepak Rawat --- drivers/gpu/drm/drm_atomic_helper.c | 3

[PATCH 08/18] drm/vmwgfx: Implement STDU plane update for BO backed fb

2018-09-27 Thread Deepak Rawat
Using the new interface implement STDU plane update for BO backed fb. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 13 ++ drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 233 +++ 2 files changed, 246 insertions(+) diff --git a/drivers/gpu/drm/vmwgfx

[PATCH 14/18] drm/vmwgfx: Use the new interface for SOU plane update

2018-09-27 Thread Deepak Rawat
With new interface to do plane update on SOU available, use that instead of old kms_dirty. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c b/drivers

[PATCH 10/18] drm/vmwgfx: Updated comment for stdu plane update

2018-09-27 Thread Deepak Rawat
Update the comment to sync with code. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 22 -- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c b/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c index 3537f5b48b98

[PATCH 11/18] drm/vmwgfx: Enable FB_DAMAGE_CLIPS property for STDU primary plane

2018-09-27 Thread Deepak Rawat
STDU primary plane now support damage clips, enable it for user-space. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c b/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c index ce077522b2d6

[PATCH 01/18] drm: Add a new plane property to send damage during plane update

2018-09-27 Thread Deepak Rawat
ges. Cc: ville.syrj...@linux.intel.com Cc: Daniel Vetter Cc: Pekka Paalanen Signed-off-by: Lukasz Spintzyk Signed-off-by: Deepak Rawat --- Documentation/gpu/drm-kms.rst | 12 + drivers/gpu/drm/Makefile| 3 +- drivers/gpu/drm/drm_atomic.c| 22 drivers/gpu/drm

[PATCH 03/18] drm: Add helper iterator functions for plane fb_damage_clips blob

2018-09-27 Thread Deepak Rawat
plane update case in iter_next Cc: ville.syrj...@linux.intel.com Cc: Daniel Vetter Cc: Pekka Paalanen Signed-off-by: Deepak Rawat --- drivers/gpu/drm/drm_damage_helper.c | 91 + include/drm/drm_damage_helper.h | 54 + include/drm/drm_plane.h

[PATCH weston 2/3] compositor-drm: Add support for drm plane FB_DAMAGE_CLIPS property

2018-09-05 Thread Deepak Rawat
available. Signed-off-by: Deepak Rawat Cc: dri-devel@lists.freedesktop.org --- libweston/compositor-drm.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c index 6a87a296..30f6fce9 100644 --- a/libweston/

[PATCH i-g-t 5/5] tests/kms_atomic: Add a new test case for FB_DAMAGE_CLIPS plane property

2018-09-05 Thread Deepak Rawat
Some simple test cases to use FB_DAMAGE_CLIPS plane property. Signed-off-by: Deepak Rawat Cc: dri-devel@lists.freedesktop.org Cc: Daniel Vetter Cc: Lukasz Spintzyk Cc: Rob Clark Cc: Daniel Stone Cc: Noralf Trønnes Cc: Dave Airlie --- lib/igt_kms.c | 1 + lib/igt_kms.h

[PATCH libdrm] xf86drm: Add signed32 rectangle

2018-09-05 Thread Deepak Rawat
With drm subsystem using struct drm_rect to manage rectangular area this export it to user-space. Currently used by drm_mode_atomic blob property FB_DAMAGE_CLIPS. Signed-off-by: Deepak Rawat --- include/drm/drm_mode.h | 19 +++ xf86drmMode.h | 2 ++ 2 files changed

[PATCH 07/14] drm/vmwgfx: implement STDU plane update for BO backed fb

2018-09-05 Thread Deepak Rawat
Using the new interface implement STDU plane update for BO backed fb. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 14 ++ drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 235 +++ 2 files changed, 249 insertions(+) diff --git a/drivers/gpu/drm/vmwgfx

[PATCH 03/14] drm: clear plane damage during full modeset

2018-09-05 Thread Deepak Rawat
Plane damage is irrelevant when full modeset happens so clear the damage blob property(If set by user-space). With damage blob cleared damage helper iterator will return full plane src as damage clip. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/drm_atomic_helper.c | 4 include/drm

[PATCH 13/14] drm/vmwgfx: enable FB_DAMAGE_CLIPS property for SOU primary plane

2018-09-05 Thread Deepak Rawat
SOU primary plane now support damage clips, enable it for user-space. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c index 290d550d1b77

[PATCH 00/14] plane update with damage

2018-09-05 Thread Deepak Rawat
to update the screen so it is a good overall test of damage interface. Weston implementation also works as intended. Let me know what you think. Thanks, Deepak Deepak Rawat (12): drm: add helper iterator functions for plane fb_damage_clips blob drm: clear plane damage during full modeset drm

[PATCH 12/14] drm/vmwgfx: use the new interface for SOU plane update

2018-09-05 Thread Deepak Rawat
With new interface to do plane update on SOU available, use that instead of old kms_dirty. Updated the comments to sync with code. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 38 +++- 1 file changed, 9 insertions(+), 29 deletions(-) diff --git

[PATCH 11/14] drm/vmwgfx: implement SOU plane update for BO backed fb

2018-09-05 Thread Deepak Rawat
Using the new interface implement SOU plane update for BO backed fb. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 134 +++ 1 file changed, 134 insertions(+) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c b/drivers/gpu/drm/vmwgfx

[PATCH 14/14] drm/vmwgfx: use atomic helper function for dirty fb IOCTL

2018-09-05 Thread Deepak Rawat
With new atomic helper for dirty fb IOCTL is available which uses damage interface, use that for dirty fb IOCTL. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 116 +--- 1 file changed, 2 insertions(+), 114 deletions(-) diff --git a/drivers/gpu

[PATCH 08/14] drm/vmwgfx: use the new interface for STDU plane update

2018-09-05 Thread Deepak Rawat
With new interface to do plane update on STDU available, use that instead of old kms_dirty. Update the commet to sync with code. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 38 +++- 1 file changed, 9 insertions(+), 29 deletions(-) diff --git a

[PATCH 10/14] drm/vmwgfx: implement SOU plane update for surface backed fb

2018-09-05 Thread Deepak Rawat
Using the new interface implement SOU plane update for surface backed fb. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 3 + drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 187 +++ 2 files changed, 190 insertions(+) diff --git a/drivers/gpu/drm/vmwgfx

[PATCH 09/14] drm/vmwgfx: enable FB_DAMAGE_CLIPS property for STDU primary plane

2018-09-05 Thread Deepak Rawat
STDU primary plane now support damage clips, enable it for user-space. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c b/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c index 167190b75e2f

[PATCH 04/14] drm: add helper to implement legacy dirtyfb

2018-09-05 Thread Deepak Rawat
state::dirty flag. Signed-off-by: Rob Clark Signed-off-by: Deepak Rawat --- drivers/gpu/drm/drm_damage_helper.c | 116 include/drm/drm_damage_helper.h | 4 + 2 files changed, 120 insertions(+) diff --git a/drivers/gpu/drm/drm_damage_helper.c b/drivers/gp

[PATCH 05/14] drm/vmwgfx: add a new interface for plane update on a display unit

2018-09-05 Thread Deepak Rawat
Add a new struct vmw_du_update_plane similar to vmw_kms_dirty which represent the flow of operations needed to update a display unit from surface or bo(blit a new framebuffer). Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 108 + drivers/gpu/drm

[PATCH 06/14] drm/vmwgfx: implement STDU plane update for surface backed fb

2018-09-05 Thread Deepak Rawat
Using the new interface implement STDU plane update for surface backed fb. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 11 ++ drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 209 ++- 2 files changed, 219 insertions(+), 1 deletion(-) diff --git a

  1   2   >