Re: [PATCH 17/35] drivers/gpu: Convert remaining uses of pr_warning to pr_warn

;> 20 uses of pr_warn in drivers/gpu >> >> Signed-off-by: Joe Perches <j...@perches.com> > > Acked-by: Christian König <christian.koe...@amd.com>. Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> > >> --- >> drivers/gpu/drm/amd/

Re: [PATCH v5 0/3] Allow ASYNC flip with atomic helpers.

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/04/2017 04:46 AM, Alex Deucher wrote: > On Thu, Feb 2, 2017 at 4:56 PM, Andrey Grodzovsky > <andrey.grodzov...@amd.com> wrote: >> This series is a folow-up on >> https://patchwork.kernel.org/patch/

Re: [PATCH libdrm 0/3] some -pro patches for integration

This series is, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 01/29/2017 06:49 AM, Grazvydas Ignotas wrote: > I've taken several patches from amdgpu-pro libdrm that look useful > to me and I think can be applied already. The only things I did was > rebasing, fi

Re: [PATCH v2 0/3] Allow ASYNC flip with atomic helpers.

This series is, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 01/17/2017 04:16 PM, Andrey Grodzovsky wrote: > This series is a folow-up on > https://patchwork.kernel.org/patch/9501787/ > > The first patch makes changes to atomic helpers to allow for > d

[PATCH] drm/amd/amdgpu: fix spelling mistake: "comleted" -> "completed"

Reviewed-by: Edward O'Callaghan On 12/30/2016 12:39 PM, Zhou, David(ChunMing) wrote: > +amd-gfx, patch is Reviewed-by: Chunming Zhou > > -Original Message- > From: Colin King [mailto:colin.king at canonical.com] > Sent: Thursday, December 29, 2016 11:47 PM > To:

[PATCH] drm/amdgpu: update kernel-doc for some functions

Reviewed-by: Edward O'Callaghan On 10/24/2016 05:31 AM, Grazvydas Ignotas wrote: > The names were wrong. > > Signed-off-by: Grazvydas Ignotas > --- > drivers/gpu/drm/amd/scheduler/sched_fence.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --g

[PATCH 1/3] drm/amdgpu: change function declarations and add missing header dependencies

This series is, Acked-by: Edward O'Callaghan On 10/22/2016 07:48 PM, Baoyou Xie wrote: > We get a few warnings when building kernel with W=1: > drivers/gpu/drm/amd/amdgpu/atombios_crtc.c:38:6: warning: no previous > prototype for 'amdgpu_atombios_crtc_overscan_setup' [-Wmissing-p

[PATCH] drm/amd/powerplay: mark symbols static where possible

Oh dear, still more of these? Why not perhaps fix them all at once into a series? In any case, Acked-by: Edward O'Callaghan On 10/22/2016 07:56 PM, Baoyou Xie wrote: > We get a few warnings when building kernel with W=1: > drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/fiji_smumgr.c

[PATCH 1/3] x86/pat: export io memory reserve/free api.

On 10/18/2016 07:29 PM, Dave Airlie wrote: > On 18 Oct. 2016 17:23, "Edward O'Callaghan" <mailto:funfunctor at folklore1984.net>> wrote: >> >> NACK, >> >> I think you want to use 'iomap_create_wc()' instead to avoid aliasing. > > Please

[PATCH 1/3] x86/pat: export io memory reserve/free api.

NACK, I think you want to use 'iomap_create_wc()' instead to avoid aliasing. Kind Regards, Edward. On 10/18/2016 05:13 PM, Dave Airlie wrote: > From: Dave Airlie > > These functions are needed for gpu/ttm drivers to reserve the > VRAM area as write combined. In a lot of places we don't

[PATCH] drm/amd/powerplay: don't give up if DPM is already running

Reviewed-by: Edward O'Callaghan On 10/10/2016 06:23 AM, Grazvydas Ignotas wrote: > Currently the driver crashes if smu7_enable_dpm_tasks() returns early, > which it does if DPM is already active. It seems to be better just to > continue anyway, at least I haven't noticed any ill effe

[PATCH 1/4] drm/amd/powerplay: mark symbols static where possible

This series is, Reviewed-by: Edward O'Callaghan On 09/25/2016 06:19 PM, Baoyou Xie wrote: > We get a few warnings when building kernel with W=1: > drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/cz_hwmgr.c:69:10: warning: no > previous prototype for 'cz_get_eclk_level' [-Wmissing-p

[PATCH] drm: amdgpu: mark symbols static where possible

ctions, even their declarations > is different. Are you sure? Because apart from the crazy macro chain they look like they wind up being the same to me. > > On 3 September 2016 at 14:11, Edward O'Callaghan > mailto:funfunctor at folklore1984.net>> > wrote: > &

[PATCH] drm: amdgpu: mark symbols static where possible

Reviewed-by: Edward O'Callaghan Also, I just noticed cz_write_smc_sram_dword() and if I am not mistaken they seems identical in both: drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c and, drivers/gpu/drm/amd/amdgpu/cz_smc.c with a personal preference to the powerplay version I suppose

[PATCH] drm/ttm: partial revert "cleanup ttm_tt_(unbind|destroy)" v2

Reviewed-by: Edward O'Callaghan On 07/22/2016 11:10 PM, Christian König wrote: > From: Christian König > > We still need to unbind explicitely during a move. > > This partial reverts commit ff20caa0bcbfef9f7686f8d1868a3b990921afd6. > > v2: remove unnecessary chec

[pull] radeon and amdgpu drm-next-4.8

> > > Tom > > > > > *From:* amd-gfx on behalf of > Edward O'Callaghan > *Sent:* Monday, July 18, 2016 07:58 > *To:* Alex Deucher; dri-devel at lists.freedesktop.org; > amd-gfx at lists.freedesktop.org; airlied at gmail.com > *Cc:* Deucher, Alexander >

[pull] radeon and amdgpu drm-next-4.8

Hi Alex, If you need me to rebase on any tip just let me know which one if that makes life easier for you? Cheers, Edward. On 07/16/2016 04:31 AM, Alex Deucher wrote: > Hi Dave, > > A few more patches for 4.8. Mostly bug fixes and some prep work > for iceland powerplay support. I have a

[PATCH 9/9] amdkfd: Trim unnescessary intermediate err var in kfd_chardev.c

Found-By: Coccinelle Signed-off-by: Edward O'Callaghan --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c index 2925f56..ee3e04e 100644

[PATCH 8/9] amdkfd: Trim off unnescessary semicolon from kfd_packet_manager.c

Found-By: Coccinelle Signed-off-by: Edward O'Callaghan --- drivers/gpu/drm/amd/amdkfd/kfd_packet_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager.c index 48a68c7..ca8c093

[PATCH 7/9] amdkfd: Use the canonical form in branch predicates

Found-By: Coccinelle Signed-off-by: Edward O'Callaghan --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 10 +- drivers/gpu/drm/amd/amdkfd/kfd_events.c | 4 ++-- drivers/gpu/drm/amd/amdkfd

[PATCH 6/9] amdgpu/dal: Drop spurious double ';' at the end of lines

Found-By: Coccinelle Signed-off-by: Edward O'Callaghan --- drivers/gpu/drm/amd/dal/amdgpu_dm/amdgpu_dm_types.c | 10 +- drivers/gpu/drm/amd/dal/dc/bios/bios_parser.c | 4 ++-- drivers/gpu/drm/amd/dal/dc/calcs/scaler_filter.c| 4 ++-- drivers/gpu/drm/amd/dal/dc/gpio

[PATCH 5/9] amdgpu/dal: Use true/false over integers for boolean vars

Found-By: Coccinelle Signed-off-by: Edward O'Callaghan --- drivers/gpu/drm/amd/dal/dc/adapter/adapter_service.c | 2 +- drivers/gpu/drm/amd/dal/dc/calcs/bandwidth_calcs.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/dal/dc/adapter

[PATCH 4/9] amdgpu/dal: Use the canonical form in branch predicates

Found-By: Coccinelle Signed-off-by: Edward O'Callaghan --- drivers/gpu/drm/amd/dal/amdgpu_dm/amdgpu_dm_irq.c | 8 drivers/gpu/drm/amd/dal/amdgpu_dm/amdgpu_dm_types.c| 2 +- drivers/gpu/drm/amd/dal/dc/asic_capability/asic_capability.c | 2 +- drivers/gpu/drm

[PATCH 3/9] amdgpu/dal: Kill off stub dal_isr_*_lock() symbols

Signed-off-by: Edward O'Callaghan --- drivers/gpu/drm/amd/dal/amdgpu_dm/amdgpu_dm_services.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/gpu/drm/amd/dal/amdgpu_dm/amdgpu_dm_services.c b/drivers/gpu/drm/amd/dal/amdgpu_dm/amdgpu_dm_services.c index 03337f3..733b194

[PATCH 2/9] amdgpu/dal: Kill off stub amdgpu_dm_*_dal_lock() symbols

There are no call sites for these nor do they do anything but return a boolean true. For now avoid the clutter. Signed-off-by: Edward O'Callaghan --- drivers/gpu/drm/amd/dal/amdgpu_dm/amdgpu_dm.c | 14 -- drivers/gpu/drm/amd/dal/amdgpu_dm/amdgpu_dm.h | 5 - 2 files changed, 19

[PATCH 1/9] amdgpu/dal: Kill off stale dal directories

Signed-off-by: Edward O'Callaghan Reviewed-by: Michel Dänzer --- drivers/gpu/drm/amd/dal/utils/bw_calc_test_harness/.gitignore | 4 drivers/gpu/drm/amd/dal/utils/vba_to_c_converter/.gitignore | 4 2 files changed, 8 deletions(-) delete mode 100644 drivers/gpu/drm/amd/dal/utils

Misc DAL & amdkfd cleanups on top of drm-next-4.7-wip-dal

for us HPC folks. Please review. Thanks for your time, Edward O'Callaghan (9): amdgpu/dal: Kill off stale dal directories amdgpu/dal: Kill off stub amdgpu_dm_*_dal_lock() symbols amdgpu/dal: Kill off stub dal_isr_*_lock() symbols amdgpu/dal: Use the canonical form in branch predicates

[PATCH] amdgpu: Kill off stale dal directories

Signed-off-by: Edward O'Callaghan --- drivers/gpu/drm/amd/dal/utils/bw_calc_test_harness/.gitignore | 4 drivers/gpu/drm/amd/dal/utils/vba_to_c_converter/.gitignore | 4 2 files changed, 8 deletions(-) delete mode 100644 drivers/gpu/drm/amd/dal/utils/bw_calc_test_harness/.gitignore